Re: Borders in page regions

2015-11-11 Thread Luca Furini
Seifeddine Dridi wrote: > Does anybody know why it isn’t allowed to set borders in page regions ? The > XSL specs says that border-width and padding values must be 0, but I don’t > understand why it is enforcing this restriction, RenderX for instance allows > borders in page regions. You can

Request for developer's powers on JIRA

2015-02-14 Thread Luca Furini
Now that I'm back in harness, thanks to a lot of patient people, I only need the magical power to work on JIRA issues in order to be a (somewhat) useful committer. Glen, as I'm told you are FOP's JIRA administrator, could you please give the necessary privileges to my lfurini JIRA account? Do you

[jira] [Resolved] (FOP-2348) [PATCH] PDF File Attachment Extension is broken

2015-02-14 Thread Luca Furini (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Furini resolved FOP-2348. -- Resolution: Fixed Fix Version/s: trunk Patch applied in revision r1655099 Revision r1659776

[jira] [Resolved] (FOP-2441) pdf:embedded-file extension is broken, gives NullPointerException

2015-02-14 Thread Luca Furini (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Furini resolved FOP-2441. -- Resolution: Duplicate Fix Version/s: trunk Assignee: Luca Furini As Thanasis Giannimaras

Re: [jira] [Updated] (FOP-2441) pdf:embedded-file extension is broken, gives NullPointerException

2015-01-24 Thread Luca Furini
Luis Bernardo wrote: I am under the impression that committership rights are never revoked but I could be wrong. Are you sure that you can log in to your Apache account? Maybe a year ago or so Apache forced a change in passwords. Did you change your password when that happened? Yes, I

[jira] [Updated] (FOP-2441) pdf:embedded-file extension is broken, gives NullPointerException

2015-01-23 Thread Luca Furini (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Furini updated FOP-2441: - Attachment: test_attachment.fo Simple fo file to reproduce the error pdf:embedded-file extension

[jira] [Updated] (FOP-2441) pdf:embedded-file extension is broken, gives NullPointerException

2015-01-23 Thread Luca Furini (JIRA)
[ https://issues.apache.org/jira/browse/FOP-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Luca Furini updated FOP-2441: - Attachment: change.diff Proposed patch pdf:embedded-file extension is broken, gives NullPointerException

[jira] [Created] (FOP-2441) pdf:embedded-file extension is broken, gives NullPointerException

2015-01-23 Thread Luca Furini (JIRA)
Luca Furini created FOP-2441: Summary: pdf:embedded-file extension is broken, gives NullPointerException Key: FOP-2441 URL: https://issues.apache.org/jira/browse/FOP-2441 Project: Fop Issue

Re: Absolute-positioned block-containers using left and bottom

2008-07-07 Thread Luca Furini
On Fri, Jul 4, 2008 at 6:09 PM, Andreas Delmelle [EMAIL PROTECTED] wrote: Now, I'm wondering... In theory, it should not be too difficult to get at this info, since ultimately it is also needed when computing 'top' or 'left' if they are specified as a percentage. In that case, the value is

Re: Absolute-positioned block-containers using left and bottom

2008-07-04 Thread Luca Furini
On Wed, Jul 2, 2008 at 8:24 PM, Andreas Delmelle [EMAIL PROTECTED] wrote: If you have the area's own dimensions, and the complement properties (bottom-right), is that not enough? For the renderer: - top = (bottom - area-bpd - borders - padding)) - left = (right - area-bpd - borders -

Absolute-positioned block-containers using left and bottom

2008-07-03 Thread Luca Furini
(it's still me, I just subscribed with the gmail account I use more frequently, to avoid problems of messages not reaching the list ...) On Wed, Jul 2, 2008 at 8:24 PM, Andreas Delmelle [EMAIL PROTECTED] wrote: If you have the area's own dimensions, and the complement properties

Re: Absolute-positioned block-containers using left and bottom

2008-07-02 Thread Luca Furini
(I'm re-posting this message as I sent it yesterday and still cannot see it in the list archives, I hope I'm not duplicating it unnecessarily) On Mon, Jun 23, 2008 at 5:12 PM, Luca Furini [EMAIL PROTECTED] wrote: If there is a block-container with both width and height set, its position can

Absolute-positioned block-containers using left and bottom

2008-06-23 Thread Luca Furini
While playing a bit with absolute positioned block container, I think I stumbled into a little bug. If there is a block-container with both width and height set, its position can be correctly controlled using top and left (and indeed there are many testcases checking that) but bottom and right do

Re: Border and padding on page regions

2008-06-20 Thread Luca Furini
On Thu, Jun 19, 2008 at 3:45 PM, Jeremias Maerki [EMAIL PROTECTED] wrote: There's both in FOP. block-container has the border on the viewport. table-cell has it on the reference area (table-cell doesn't generate a viewport). But I fear we might actually be wrong about having the border and

Border and padding on page regions

2008-06-19 Thread Luca Furini
Some time ago (well, almost 2 years!) we spoke about the possibility to allow users to define borders and padding for the page regions [1]. This week I finally found some time to do it, so I have it working on my local copy ... but then I was struck by a dilemma: the additional traits about

Re: Border and padding on page regions

2008-06-19 Thread Luca Furini
On Thu, Jun 19, 2008 at 1:26 PM, Luca Furini [EMAIL PROTECTED] wrote: Only a reference-area may have a block-progression-direction which is different from that of its parent. Ops, I realize only now that it says direction and not dimension :-) Ok, so I think this definitely means

Re: svn commit: r668177 - in /xmlgraphics/fop/trunk: ./ src/java/org/apache/fop/layoutmgr/ test/layoutengine/standard-testcases/

2008-06-16 Thread Luca Furini
On Mon, Jun 16, 2008 at 4:52 PM, [EMAIL PROTECTED] wrote: Fixing the PageBreakingAlgorithm, replacing calls to getLineWidth() with getLineWidth(int) so as to take into account each page's real height. This fixes the positioning of footnotes when the page bpd is not the same for all

Re: Checking: difference between negative stretch and positive shrink?

2007-09-17 Thread Luca Furini
Andreas L Delmelle wrote: Just wondering about some KnuthSequences for spaces I noticed during a debug-session: glue w=0 stretch=10008 shrink=0 penalty w=0 p=0 glue w=3336 stretch=-10008 shrink=0 What does it mean that the latter glue can be stretched by a negative amount? Why not: glue

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-25 Thread Luca Furini
(I see that Jeremias agrees with Andreas about how to interpret the nested keeps, so I reply just once) Andreas L. Delmelle wrote: In very rough terms, the logic behind it would be: if a given break #1 has a plain adjustment ratio of 3 and a governing keep of auto, and the next break #2,

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-20 Thread Luca Furini
Andreas L. Delmelle wrote: That's one detail I was still unsure about. Only if the other factors remain identical, the algorithm would prefer a break at penalty 50 over one at penalty 100... but if the value of the penalty is only of marginal influence as you suggest, then this would indeed

Re: svn commit: r557347 - in /xmlgraphics/fop/trunk: ./ src/documentation/content/xdocs/ src/java/org/apache/fop/fo/ src/java/org/apache/fop/layoutmgr/inline/ test/layoutengine/ test/layoutengine/stan

2007-07-19 Thread Luca Furini
Firstly, hi all! It has been quite a long time since I last posted or committed anything, but I'm still here!. :-) Then, congratulations for all the great progresses fop is making! And finally, concerning the keeps ... Andreas L. Delmelle wrote: [inserting penalties with higher value to

Re: Footnotes in the float branch

2007-03-27 Thread Luca Furini
Vincent Hennebert wrote: Hi Luca, Hi! I had a look at your patch and have several comments: - I see you re-enabled the noBreakBetween method; I don't think it's a good solution because it artificially prevents some nodes to be created, which even if bad may be necessary for some complex

Footnotes in the float branch

2007-03-26 Thread Luca Furini
Hi all I recently had the time (and the pleasure) to look at before-float implementation branch, and I played a bit with it. I focused on the handling of footnotes, as I noticed that sometimes they were placed on a page following their citations without a real necessity to do it; as I wrote

Re: Footnotes in the float branch

2007-03-26 Thread Luca Furini
On Mon, 26 Mar 2007, Luca Furini wrote: I'm attaching a diff file showing the changes Well, *now* I'm attaching bla bla :-) Regards LucaIndex: src/java/org/apache/fop/layoutmgr/breaking/FootnotesRecord.java === --- src

Re: Before floats + footnotes

2007-01-24 Thread Luca Furini
Vincent Hennebert wrote: I've had a quick look, that's not handled currently. At some place in the code the space-before set on the separator is converted into a MinOptMax(opt, opt, opt). If I remember correctly, the separator bpd is taken from the generated area (so there isn't any stretch

Re: Before floats + footnotes

2007-01-22 Thread Luca Furini
Vincent Hennebert wrote: I don't think there is much you can do in that case. It appears that the 15 lines of text at 12 pt exactly fill the 3 inch-high page. So that makes a feasible node which is always preferred to too-short nodes. Change the page-height to 3.1 inch and you no longer have

Before floats + footnotes

2007-01-19 Thread Luca Furini
Hi all! At long last, I'm finally allowed some time to look at the float branch and ... wow! Really impressive, a great lot of good work! In order to apologize for my long absence :-) , I'm trying to see what's wrong with the failing testcases, in particular the ones with footnotes.

Fix for bugs 41019 + 41121

2006-12-22 Thread Luca Furini
Hi all I have a patch fixing bugs 41019 and 41121, for both trunk and float branch, and I'm wondering how it's best for me to proceed in order to avoid merging problems: should I change both trunk and branch, or just one of them? The patch is extremely simple and does not break any

LineBreakUtils compilation error?

2006-12-22 Thread Luca Furini
I've just updated my local copy of trunk and rebuilt. At first, I could not be able to successfully complete the compilation, as I received an error concerning the file src/java/org/apache/fop/text/linebreak/LineBreakUtils.java non containing the class

Re: UAX#14 implementation

2006-12-20 Thread Luca Furini
Manuel Mall wrote: After making the appropriate adjustment to the checks in that testcase ALL testcases are now passing! Wonderful! I'm really looking forward to see this great new feature! Just a couple of doubts concerning the differences with respect to the old implementation (I must

Re: DO NOT REPLY [Bug 41019] - Left-align oddness with long, unbreakable strings following

2006-12-12 Thread Luca Furini
Vincent Hennebert wrote: I'd have to think more about it, but: - perhaps the compareNodes method should compare the line/page numbers for each node rather than the index in the Knuth sequence. Or some mixing of the two. The index can tell us which node allows to lay out more content, the

Re: DO NOT REPLY [Bug 41019] - Left-align oddness with long, unbreakable strings following

2006-12-05 Thread Luca Furini
Chuck Bearden wrote: If in a left-aligned block some typical text words are followed by a string longer than the line-length and containing no spaces (e.g. a long URL), then the foregoing text will have premature line breaks, i.e. halfway to two-thirds the way into the line. I had a look at

Re: XSL-FO 2.0 workshop in Heidelberg next week

2006-10-10 Thread Luca Furini
Jeremias Maerki wrote: If anyone has any requirements for XSL-FO 2.0 which I should bring up at the workshop in Heidelberg next week, please let me know. Deadline 2006-10-16 so I have time to prepare. Luca, are you going, too? How do you travel? Yes, I'm going. I think I'll travel by train,

Re: Necessary conditions to defer footnotes

2006-07-12 Thread Luca Furini
Vincent Hennebert wrote: there is something I don't get with the handling of footnotes. When there is not enough room on the current page to place all the footnotes, the algorithm tries to find a place where to split them. But there is a condition: it must be possible to defer old footnotes

Re: Error message: Should be first

2006-07-11 Thread Luca Furini
Jeremias Maerki wrote: One of my clients reported to me that he gets a Should be first error message on the log. This happens in (Page)BreakingAlgorithm.removeNode(). I get the impression that the code there is not finished rather than that is a real error condition. I'll try to extend

Re: Error message: Should be first

2006-07-11 Thread Luca Furini
I've had another look at this. A few debug outputs shows that the error arises when trying to remove the node KnuthNode at 734 4527603+682968-135942 line:10 prev:687 dem:11527.971465493918 while the list of active nodes contains [ KnuthNode at 734 4527603+682968-135942 line:10 prev:683

Re: keep...=always and Knuth penalties

2006-06-20 Thread Luca Furini
Jeremias Maerki wrote: On 19.06.2006 15:45:36 Luca Furini wrote: It seems to me that the prescribed behaviour requires a keep constraint with force = always to be satisfied *always* :-), even if this would mean having some overflowing content. Obviously, we disagree here. I read it so

Re: keep...=always and Knuth penalties

2006-06-19 Thread Luca Furini
Manuel Mall wrote: What is still unclear to me is if it is worthwhile to implement this two pass approach, i.e. use INFINITE penalties first and relax later, or if it is good enough for 99.99% of cases just to start with INFINITE-1 penalties for mandatory keeps? I think the second pass is

Re: [GSoC] Wiki page for progress informations

2006-05-31 Thread Luca Furini
Jeremias Maerki wrote: did you already investigate how footnotes are implemented? Can you say anything about how similar the problem of footnotes is to before-floats? Just so you don't have to start from scratch while there may be something to build upon. After all, the footnotes also contain

Re: some footnotes not being displayed

2006-05-23 Thread Luca Furini
Jeremias Maerki wrote: No idea if anyone else has time to look into it. I don't think it's an easy fix, or at least easy to isolate, because footnote handling is not trivial. Having a good test case is instrumental in finding the problem quickly. Usually, this is step is 60% to fixing a bug.

Re: some footnotes not being displayed

2006-05-23 Thread Luca Furini
I've started looking at the patch attached at bug #37579, for the moment concentrating on footnotes inside lists. Concerning shortcoming 2) (from the bug comment): 2) Footnotes from list-item-body starts at the same position (from the starting edge) than the list-item-body itself and not at

Re: Generalized Knuth-Plass Linebreaking Algorithm

2006-04-04 Thread Luca Furini
Simon Pepping wrote: [...] See http://www.leverkruid.nl/GKPLinebreaking/index.html. Please, let me know what you think of it. I'm going to read it carefully, it seems very interesting! Regards Luca

Re: letter-spacing

2006-03-01 Thread Luca Furini
Jeremias Maerki wrote: Still trying to fix my problem with letter-spacing and fixed width spaces. Do I understand that correctly that XSL-FO's view of letter-spacing is different than, say, PDF's? PDF's character spacing (PDF 1.4, 5.2.1) is designed so it advances the cursor for each (!)

Re: letter-spacing

2006-03-01 Thread Luca Furini
Jeremias Maerki wrote: The recommendation states that The algorithm for resolving the adjusted values between word spacing and letter spacing is User Agent dependent. (7.17.2 in the candidate recommendation), so I think this is not a wrong behaviour: it just assumes that word spaces have

Re: white-space-collapse not working in trunk?

2006-02-14 Thread Luca Furini
(moved from fop-users as we are going into the implementation details) Manuel Mall wrote: the shorthand property white-space=pre should be used or its expanded equivalents: linefeed-treatment=preserve white-space-collapse=false white-space-treatment=preserve wrap-option=no-wrap

Re: DO NOT REPLY [Bug 38507] - Non-breaking space in PDF title output

2006-02-07 Thread Luca Furini
Manuel Mall wrote: 1. The suppress-at-line-break property can be applied to all characters. I would take the position at the moment that explicit specification of the suppress-at-line-break property is not supported and we worry about it at a later stage. I would certainly argue against just

Re: DO NOT REPLY [Bug 38507] - Non-breaking space in PDF title output

2006-02-06 Thread Luca Furini
Manuel Mall wrote: IMO nbsp (and any other Unicode special spaces) are outside the scope of XSL-FO whitespace handling. XSL-FO refers to whitespace as defined in XML. In XML only x#20, x#9, x#a, and x#d are considered whitespace. Therefore nbsp does not need to be considered when looking at

Re: DO NOT REPLY [Bug 38507] - Non-breaking space in PDF title output

2006-02-06 Thread Luca Furini
Manuel Mall wrote: This solves the first supposed problem (interaction between nbsp and pretty-printing spaces), but the second one is still open: what happens if we have someContentnbspspaceotherContent ? *IF* (and I'm not at all sure about this) there can be a break , then both spaces

Re: line breaking and whitespace handling

2006-02-02 Thread Luca Furini
Manuel Mall wrote: As far as I remember our last discussion was about who should generate the Knuth element lists: The individual layout managers or the Line layout manager. You argued in favour of retaining the current system and I tended to favour the moving it up the hierarchy to the line

Re: line breaking and whitespace handling

2006-02-02 Thread Luca Furini
Manuel Mall wrote: What about using the UnresolvedElements? Just as per the block-level space resolution, each inlineLM could append at the beginning and at the end of its element list an UnresolvedElement storing its border, padding and spacing information. I don't know anything about the

Off line for a week

2006-01-12 Thread Luca Furini
Hi all! I apologize for having been not very active for the last weeks, but at long last things should change: next week I will be in San Jose (California) attending a conference about digital publishing, and after that I should have some time to spend working on FOP (and I really can't wait

Re: Hyphetation broken with last commits

2005-12-17 Thread Luca Furini
Manuel Mall wrote: Luca, why does our line breaking algorithm insist on having at least one Box in a paragraph? Is that inherent in the Knuth algorithm, i.e. can't it deal with empty paragraphs, that is paragraphs containing only Glue/Pen elements? If I remember correctly, a sequence

Re: 4.3.2 Overconstrained space-specifiers

2005-12-09 Thread Luca Furini
Jeremias Maerki wrote: You will have seen that I've been working on overconstrained documents. 5.3.4 Overconstrained Geometry is more or less implemented, so now I need to have a look at 4.3.2 which proves quite difficult to understand. At least I can't make much sense of it ATM. [...] If

Re: Kerning

2005-12-09 Thread Luca Furini
Starting from your final summary: Manuel Mall wrote: IMO FOP should limit itself to: a) Use kerning only for consecutive characters within the same fo Ok, but more on this later in this message ... b) Limit itself to the kerning information in the font Ok c) Only apply kerning if the

Re: DO NOT REPLY [Bug 37743] - exception: border-style (shorthand)

2005-12-05 Thread Luca Furini
First of all, thanks for your comments: I really tend to forget in a short time all the details concerning white space! Manuel Mall wrote: Glyphs are only allowed to be merged if they carry the same / matching set of property values. Personally I would not be concerned if we therefore limit

Re: Indent Inheritance and Collapsing Border Model

2005-12-01 Thread Luca Furini
Jeremias Maerki wrote: The first concerns indent inheritance [...] So what I'd like to do is implement the alternative behaviour as a configurable option in the FO tree. The default would still be what the specification describes (see [1]), but users would be able to set a switch that would

Re: svn commit: r345909 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/fo/flow/ src/java/org/apache/fop/layoutmgr/ src/java/org/apache/fop/layoutmgr/inline/ test/java/org/apache/fop/

2005-11-21 Thread Luca Furini
I wrote: Implementation of hyphenation-ladder-count. Just a couple of annotations: - this implementation does not store any extra information inside the nodes: the algorithm checks wheter a break is ok or not using a for loop; if you prefer, I could change this so that the number of

Re: Hyphenation

2005-11-16 Thread Luca Furini
Manuel Mall wrote: Not sure what other committers and the PMC think but as a vote on the release has started I would suggest no further changes to the codebase unless agreed? What I am saying is - by all means do the development but don't put it back into svn until after the release. Ok,

Illegal property values

2005-11-16 Thread Luca Furini
While working on the implementation of hyphenation-ladder-count, I noticed that at the moment the property system can return illegal values coming from the fo file instead of the fallback value defined by the specs. There are significant differences in wording between XSL 1.0 and 1.1: for

Re: Hyphenation

2005-11-15 Thread Luca Furini
Manuel Mall wrote: Hmm, just changed the value to 3000 (I think that's the value suggested in the article) and there is no change in hyphenation behaviour with the above mentioned example. That makes me a bit suspicious... I traced the beheviour of the breaking algorithm applied to the first

Re: Leading/trailing space removal in LineLM

2005-11-02 Thread Luca Furini
Manuel Mall wrote: So we end up with only two cases to consider: preserve white space and remove white space around a line break created by the Knuth algorithm. 1. Preserve white space: IMO in this case the space itself is actually not a break opportunity but there are now two break

Re: Leading/trailing space removal in LineLM

2005-11-02 Thread Luca Furini
Manuel Mall wrote: Luca wrote a longer response to this but my mail reader doesn't like the character set (is that topical or what?). Sorry, it looks really horrible ... still don't know what went wrong, but I won't do it again! :-) Any way at end Luca ask the question about the UAX#14

Re: svn commit: r328381 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: area/inline/ layoutmgr/inline/ render/ render/pdf/ render/xml/

2005-10-28 Thread Luca Furini
Manuel Mall wrote: But we need to know which spaces can be adjusted, and which cannot. If we don't wont to duplicate the logic for the space recognition, the SpaceAreas must simply have a boolean value stating whether the space is adjustable, so that the renderers won't need to look at the

Re: White space handling Wiki page

2005-10-28 Thread Luca Furini
Manuel Mall wrote: Side note: FOP doesn't quite do the same internally, i.e. a character explicitly specified using fo:character.../ is handled separately from 'plain text'. If someone would write a style sheet which does a transform of every character into a fo:character / object and would

Re: svn commit: r328381 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: area/inline/ layoutmgr/inline/ render/ render/pdf/ render/xml/

2005-10-27 Thread Luca Furini
I wrote: Manuel Mall wrote: There is no need to expose creation of the Space/Word areas directly to TextLayoutManager either. TextArea could easily expose an addWord and an addSpace method instead of the monolithic setText. In the end it probably boils down to me arguing that the

Re: svn commit: r328381 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop: area/inline/ layoutmgr/inline/ render/ render/pdf/ render/xml/

2005-10-26 Thread Luca Furini
Manuel Mall wrote: I have a question on this. You break in TextArea the text into words based on CharUtilities.isAnySpace. Is this guaranteed to be consistent with the breaking and adjustment calculations in TextLayoutManager? I am concerned we may be using different rules for word breaking

Re: DO NOT REPLY [Bug 36238] - text-align=justify doesnt' work on custom fonts

2005-10-19 Thread Luca Furini
! :-) --- Additional Comment #8 From Luca Furini 2005-10-18 12:53 Quotation from the pdf reference, version 1.6, section 5.2.2 Word spacing: Word spacing is applied to every occurrence of the single-byte character code 32 in a string when using a simple font or a composite font

Re: svn commit: r321084 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/LineLayoutManager.java

2005-10-14 Thread Luca Furini
Fixing a ClassCastException due to the incorrect pattern of elements representing a space checked when there are inline borders and padding. The testcase inline_border_padding_block_nested_2.xml stil does not pass: there is a failing check concerning ipda. But at least there are no more

Re: Inline border / padding and nested blocks

2005-10-10 Thread Luca Furini
Manuel Mall wrote: inline_border_padding_block_nested.xml. If you run the test case as is you get a Expect inline sequence as first sequence when last paragraph is not null message. The first message refers to the first block in the testcase: I think this has something to do with the

Re: Inline border / padding and nested blocks

2005-10-10 Thread Luca Furini
Manuel Mall wrote: Is that actually conceptually the right thing to do, that is removing the trailing spaces before the end of a block as part of the Knuth handling? For leading spaces it is done somewhere completely different (and currently in the same piece of code it is done incorrectly

Re: Inline border / padding and nested blocks

2005-10-07 Thread Luca Furini
Manuel Mall I would appreciate if you could please have a look at test case inline_border_padding_block_nested.xml. If you run the test case as is you get a Expect inline sequence as first sequence when last paragraph is not null message. If you comment everything out and uncomment the last

Re: Knuth algorithm problem

2005-10-06 Thread Luca Furini
Jeremias Maerki wrote: I think I've just stumbled over a problem in the Knuth algorithm. I'm going to see what happens ... Regards Luca

Re: svn commit: r306656 - in /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr: BreakingAlgorithm.java PageBreakingAlgorithm.java

2005-10-06 Thread Luca Furini
Fixing a bug reported by Jeremias affecting the handling of glue and penalty elements after a break when the algorithm restarts. Now it should be ok. A nasty little bug, anyway ... Unfortunately, I had to duplicate a few lines (a for loop looking for glue elements after a feasible break): the

Re: Maintainability

2005-09-30 Thread Luca Furini
Peter B. West wrote: Thanks to Luca for his (perhaps entirely co-incidental) posting to the Wiki. Well, not entirely co-incidental! :-) I started writing the page some time ago, but never found the time to finish it: your message made me think I really couldn't put this off any longer, so

Re: Maintainability

2005-09-30 Thread Luca Furini
Peter B. West wrote: There seem to be some misapprehensions about what you are attempting; perhaps they are mine, so please clarify this. As I understand it, the mature, well-documented technology is the line-breaking, as in Breaking Lines Into Paragraphs. Using this model for page-breaking

Re: Another page-related question: page-position=last

2005-09-28 Thread Luca Furini
Jeremias Maerki wrote: What is the expected output? In this case it has to generate a blank page IMO. Oh, right, I did not think of an empty page! :-) The problem is with the page x of y hack that won't work like this if the last empty block ends up on the second-to-last page. [...] What

Re: Another page-related question: page-position=last

2005-09-27 Thread Luca Furini
Jeremias Maerki wrote: It's an interesting idea. However, I suspect this will probably not be necessary. We should be able to make the breaker clever enough to handle this particular case. When the page bpd depends on the page-masters, things becomes very strange. Not only it's difficult to

Re: Indefinite page-width / page-height

2005-09-26 Thread Luca Furini
Andreas L Delmelle wrote: Currently, I have solved this locally by creating the pageVP with the indefinite dimension set to Integer.MAX_VALUE. The only things I'm still looking for are ways to: a) retrieve the accumulated content-height/-width (or: the difference between the initial

Re: undefined page length

2005-09-20 Thread Luca Furini
Andreas L Delmelle wrote: BTW: Is it a correct assessment that implementing this should turn out to be far simpler than fixed page-sizes? IIC, theoretically, the whole page-breaking algorithm can be ignored for indefinite page-heights. getAvailableBPD() would always return, say,

Build error?

2005-09-19 Thread Luca Furini
Hi all. I'm noticing a strange problem: fop builds correctly, but then it seems it is not working at all. I'm using it from the command line under win xp, and even if I don't get any run time exception no output file is created. Launching fop with no parameters, or with wrong parameters

Re: wrap-option property

2005-09-16 Thread Luca Furini
Jeremias Maerki wrote: wrap-option is one of those few properties which work in 0.20.5 but are not yet available in FOP Trunk. Luca, what do you think how difficult it would be to implement it at least for, let's say, fo:block? I imagine it would suffice to trick the breaker into not choosing

Re: baseline-shift and KnuthInlineBoxes

2005-09-16 Thread Luca Furini
Manuel Mall wrote: if we have a baseline-shift, eg. some Xfo:inline font-size=smaller baseline-shift=super2/fo:inline ... how is that intended to be modelled with respect to the lead,height, and middle values to be stored in the created KnuthInlineBoxes for the fo:inline? I think that

Re: svn commit: r280854 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java

2005-09-14 Thread Luca Furini
I wrote: Correct handling of the combination of hyphenation and text-align = center, left or right. At the end, I found out that this was not the same problem as bug 36533, but another bug specifically concerning the elements created to represent hyphens. I think that Manuel has been the

Re: svn commit: r280520 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java

2005-09-13 Thread Luca Furini
I wrote: Factorized the creation of the elements in TextLM: now both getNextKE() and getChangedKE() call the same methods createElementsForASpace() and crateElementsForAWordFragment(). This should definitively solve bug 36533. Besides removing duplicated lines and inconsistencies, I hope

Re: fo:inline bpd

2005-09-12 Thread Luca Furini
Manuel Mall wrote: yes, that is an option. What I am unsure about here is that the children, typically text areas, do not take the line spacing into account when reporting their bpd, that is the usually 10% space above and below the character. So what is the correct bpd for an fo:inline

Re: Space-resolution doesn't work

2005-09-09 Thread Luca Furini
Jeremias Maerki wrote: I'll start from scratch to come up with a better strategy of implementing these rules. I'll probably start by documenting a few cases in the Wiki and try to develop the right element list for them. After that I'll try to find out who exactly to implement everything.

Re: svn commit: r279551 - in /xmlgraphics/fop/trunk: src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java test/layoutengine/testcases/wrapper_text-transform_1.xml

2005-09-08 Thread Luca Furini
Manuel Mall wrote: this is my code after integrating your patch to add the knuth elements for line end / start border/padding for the common justify=start or end case. What I am getting now is a space at the beginning of each line break!: if (lineStartBAP != 0 || lineEndBAP != 0) {

Re: e-g with padding and borders

2005-09-06 Thread Luca Furini
Manuel Mall wrote: Next problem: border conditionality - how do I model that with the Knuth approach? At the time I add the Border/Padding start/end boxes we don't have line breaks so they really only cover the .conditionality=discard case. How do I tell the algorithm to leave enough space at

Re: Line LM, Inline LM and LAST_AREA

2005-09-06 Thread Luca Furini
Manuel Mall wrote: But if we have a long fo:inline stretching multiple lines this seem to give the wrong results from the Inline LM perspective. For example if the fo:inline finishes in the middle of a line followed by more text the Line LM will not set the LAST_AREA flag when calling

Re: e-g with padding and borders

2005-09-06 Thread Luca Furini
Manuel Mall wrote: These two paragraphs confuse me - sorry. My understanding was: discard = start/end borders/padding only at the start and end of the whole fo:inline retain = as discard plus start/end borders/padding on the start and end of every line the fo:inline spans. Sorry, you are

Re: SVG Image cropping/positioning

2005-09-05 Thread Luca Furini
Richard W. wrote: I'm starting now. I've had to rename inline_block_nested_\#36248.xml to inline_block_nested_bug36248.xml to get the junit task to build. I had to rename that file too; I have win xp. Regards Luca

Re: [Xmlgraphics-fop Wiki] Update of ExtensionPoints by JeremiasMaerki

2005-09-02 Thread Luca Furini
Speaking of extensions, I'd like to resurrect the layout extensions that were part of the code used to start the Knuth branch, but I want to be sure I'm allowed to do it. The set of extensions (a couple of new properties, and some new value for an existing one) is aimed to give the user more

Re: FOP Visuals

2005-09-02 Thread Luca Furini
Jeremias Maerki wrote: For those who don't want to run BatchDiffer themselves, I've uploaded a ZIP full of PNGs, one per layout engine test case combined from output from the PDF, PS and Java2D renderers. Just an idea ... what about an option to have the output from two renderers and the XOR

Re: [Xmlgraphics-fop Wiki] Update of ReleasePlanFirstPR by ChrisBowditch

2005-08-31 Thread Luca Furini
Chris Bowditch wrote: + * Conditional space support, i.e. space-before.conditionality=retain Chris, doesn't this work already? As far as I can remember the correct space resolution is still missing, so for example the space-after of a block is not added to the space-after of the following

Re: [Xmlgraphics-fop Wiki] Update of ReleasePlanFirstPR by ChrisBowditch

2005-08-31 Thread Luca Furini
Chris Bowditch wrote: I just knocked up a small test case and although retain is honoured, discard is ignored. I knew it wasn't quite yet working but didn't realise retain was working :) I'll update the Wiki. Could you please also attach your file? I have tested a simple sequence of blocks

Re: [Xmlgraphics-fop Wiki] Update of ReleasePlanFirstPR by ChrisBowditch

2005-08-31 Thread Luca Furini
Chris Bowditch wrote: Here is the sample: Thanks! I have tested a simple sequence of blocks with conditional spaces and the output seems ok; the output of the testcase space-block2.xml seems correct too (I'm going to add checks). Not true, space-block2.xml does not work. On the second

Re: page-number and page-number-citation problem

2005-08-30 Thread Luca Furini
J.Pietschmann wrote: Maybe I'm wrong in trying to do so, but I'd like to handle both formatting objects in the same way. If page numbers can be resolved to strings early, it should be done. All the hassle for space readjusting, and perhaps reflowing content, should be reserved for forward

Re: page-number and page-number-citation problem

2005-08-29 Thread Luca Furini
J.Pietschmann wrote: In the maintenance branch, the formatted page number string was produced just as a new page was set up. I wonder whether the page sequence LM can put the current page number string into the layout context? This could work for page-numbers but not for

Re: page-number and page-number-citation problem

2005-08-29 Thread Luca Furini
Firstly, thank you all for your suggestions. All your interesting replies led me to this conclusion: - in most cases, it is enough to make some local adjustments in each line containing page-numbers or page-number-citations; - sometimes, when a particularly elegant output is needed, it would

page-number and page-number-citation problem

2005-08-26 Thread Luca Furini
There is a layout problem with fo:page-number and fo:page-number-citation, already pointed out but still unresolved. I think, these formatting objects are very similar, even if their actual handling is quite different: they both must be replaced by an information (a page number) that is (or

  1   2   >