[Freeciv-Dev] [bug #17265] Successful attacking diplomat does not get promotion.

2010-12-08 Thread George Koehler
Follow-up Comment #5, bug #17265 (project freeciv): I recall that I was able to promote my diplomats by bribing enemy units. The question is whether I can promote my diplomats by eliminating enemy diplomats in cities. I opened a game with S2_3 and used the editing mode to put diplomats. When I

[Freeciv-Dev] [bug #17193] in unquote_block() [savegame2.c::990]: assertion '1 == parsed' failed

2010-12-07 Thread George Koehler
Follow-up Comment #5, bug #17193 (project freeciv): I saw this bug with S2_3 r18705. I would like to thank you all for already reporting the bug and posting a fix. Pepeto's fix (comment #4) works for me. ___ Reply to this item at:

[Freeciv-Dev] [bug #17247] Wrong comment in server/prlhand.c split_player()

2010-12-06 Thread George Koehler
URL: http://gna.org/bugs/?17247 Summary: Wrong comment in server/prlhand.c split_player() Project: Freeciv Submitted by: kernigh Submitted on: Mon 06 Dec 2010 09:41:51 PM GMT Category: ai Severity: 2 -

[Freeciv-Dev] [bug #17201] Civil war rebels have no capital city

2010-11-29 Thread George Koehler
URL: http://gna.org/bugs/?17201 Summary: Civil war rebels have no capital city Project: Freeciv Submitted by: kernigh Submitted on: Monday 11/29/2010 at 21:16 Category: ai Severity: 2 - Minor

[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often

2010-10-13 Thread George Koehler
Follow-up Comment #5, bug #16717 (project freeciv): Uploading -v2 patches. They delete that FIXME comment, and also delete the 'redundant test?' comment, two lines down. The test '!is_wonder(wonder_city-production.value.building)' is not redundant, because city might build Barracks instead of

[Freeciv-Dev] [bug #16851] use after free by diplomat_bribe()

2010-10-10 Thread George Koehler
URL: http://gna.org/bugs/?16851 Summary: use after free by diplomat_bribe() Project: Freeciv Submitted by: kernigh Submitted on: Monday 10/11/2010 at 03:03 Category: None Severity: 2 - Minor

[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often

2010-10-07 Thread George Koehler
Follow-up Comment #3, bug #16717 (project freeciv): Attaching patches. * p22-keep-wonder-city.diff for S2_2 * ptrunk-keep-wonder-city.diff for trunk (file #10653, file #10654) ___ Additional Item Attachment: File name:

[Freeciv-Dev] [bug #13557] [RT #40412] AI stops building wonders after game load

2010-10-07 Thread George Koehler
Follow-up Comment #5, bug #13557 (project freeciv): Attaching * x-reverse-ineq-turn75.sav.bz2, a game to reproduce this bug * p22-aiwonder-v1.diff, a failed attempt to fix this bug Load this game with S2_2, take human player Philippe le Hardi, click 'Turn Done', then AIs stop building wonders.

[Freeciv-Dev] [bug #13557] [RT #40412] AI stops building wonders after game load

2010-10-06 Thread George Koehler
Follow-up Comment #4, bug #13557 (project freeciv): ai_manage_buildings() of ai/aicity.c is the function that chooses the wonder city. This is the server for Freeciv version 2.2.3+ You can learn a lot about Freeciv at http://www.freeciv.org/ 2: Loading rulesets Breakpoint 1,

[Freeciv-Dev] [bug #13557] [RT #40412] AI stops building wonders after game load

2010-10-05 Thread George Koehler
Follow-up Comment #3, bug #13557 (project freeciv): As the server loads the saved game, the AI seems to immediately abandon its wonder city. I have a patch (file #10375 of bug #16717) that logs the choice of wonder city. When I started my server: This is the server for Freeciv version 2.2.3+

[Freeciv-Dev] [bug #16717] AI chooses new wonder city too often

2010-10-05 Thread George Koehler
Follow-up Comment #1, bug #16717 (project freeciv): AI tries to pick a wonder city and build a wonder there. Today, the logic to stay with a wonder city is broken, only because the code has '=' instead of '=' at one place, so AI will never finish a wonder unless by luck AI chooses this same city

[Freeciv-Dev] [bug #16751] Joining localhost fails when IPv6 is disabled

2010-09-25 Thread George Koehler
Follow-up Comment #5, bug #16751 (project freeciv): I'd say that bug is not in Freeciv, but in the fact that /etc/hosts makes localhost to resolve as ::1 even though IPv6 is disabled in the system. I guess that this is bug in Freeciv. You can have localhost resolve to ::1, whether IPv6 is

[Freeciv-Dev] [bug #16509] Blank hostname

2010-09-22 Thread George Koehler
Follow-up Comment #5, bug #16509 (project freeciv): I found an Ubuntu getnameinfo(3) at http://manpages.ubuntu.com/manpages/maverick/en/man3/getnameinfo.3.html Further down, it says: NI_NUMERICHOST If set, then the numeric form of the hostname is returned.

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-21 Thread George Koehler
Follow-up Comment #30, bug #15559 (project freeciv): From x11_create_display_inet() of openssh-5.6p1/channels.c: for (ai = aitop; ai; ai = ai-ai_next) { if (ai-ai_family != AF_INET ai-ai_family != AF_INET6) continue;

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-20 Thread George Koehler
Follow-up Comment #28, bug #15559 (project freeciv): IPv4 bind failed: Address already in use Print that particular error message only if also IPv6 bind failed? To be exact, print no error messages if we can listen() to at least one socket? OpenBSD 'man getaddrinfo' shows an example of this:

[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service

2010-09-14 Thread George Koehler
Follow-up Comment #4, bug #16623 (project freeciv): I made a patch that replaces gethostbyname2() with getaddrinfo(). However, I run OpenBSD, so I cannot determine if this patch fixes this bug with Microsoft Windows. (I have a different reason to use getaddrinfo(): it helps fe80::/64 link-local

[Freeciv-Dev] [bug #16509] Blank hostname

2010-09-13 Thread George Koehler
Follow-up Comment #3, bug #16509 (project freeciv): I believe that file #10015, which adds NI_NAMEREQD to getnameinfo(), would not fix this bug. From OpenBSD 'man getnameinfo': NI_NAMEREQD A name is required. If the host name cannot be found in DNS and this

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-08 Thread George Koehler
Follow-up Comment #18, bug #15559 (project freeciv): I changed the error code in server/sernet.c to try to identify the socket that causes the error. I also remade the trunk patch, so now trunk seems to work. This is the *last* version of the patch from me, unless I discover that I made some

[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service

2010-09-05 Thread George Koehler
Follow-up Comment #3, bug #16623 (project freeciv): I found the reference. [url=http://tools.ietf.org/html/rfc3493]RFC 3493[/url], which defines IPv6 sockets, explains that 'The gethostbyname2() function was deprecated in RFC 2553 and is no longer part of the basic API.' I suppose that someone

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-09-03 Thread George Koehler
Follow-up Comment #17, bug #15559 (project freeciv): I made a trunk version of the patch, but it is broken. The client complains about unknown error 0 and the server says '2: Lost connection: c1 from localhost (connection incomplete).' I might have made a mistake in client/clinet.c; I need more

[Freeciv-Dev] [bug #16623] netintf.c gcc warnings in net_lookup_service

2010-09-03 Thread George Koehler
Follow-up Comment #1, bug #16623 (project freeciv): I guess that your libraries define gethostbyname2() but your header files fail to declare gethostbyname2(). Perhaps your netdb.h file is too old? The configure script only checks for gethostbyname2() in the libraries, not the header files.

[Freeciv-Dev] [bug #16596] Mark capital cities on map

2010-09-03 Thread George Koehler
Follow-up Comment #1, bug #16596 (project freeciv): The diplomacy dialog requires embassy or contact. If your embassy status is 'No Contact', then there is no diplomacy report and you need to middle-click cities. (This often happens where contactturns=0.) For a capital city, one might underline

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-08-28 Thread George Koehler
Follow-up Comment #16, bug #15559 (project freeciv): gcc gives the same warning to me. gcc notices that if name_count = 0, then we never enter the for loop to initialize 'sock'. I am attaching a -v4 patch that prevents the warning. The patch is for S2_2. I have never used trunk. I am now

[Freeciv-Dev] [bug #16556] Mac compatibility of the flag convert script

2010-08-28 Thread George Koehler
Follow-up Comment #4, bug #16556 (project freeciv): I run an old version of OpenBSD; I have the same problem with OpenBSD 'sed'. $ echo EXAMPLE.SVG | sed 's/.svg$//i' sed: 1: s/.svg$//i: bad flag in substitute command: 'i' $ echo EXAMPLE.SVG | sed 's/.[Ss][Vv][Gg]$//' EXAMPLE I never

[Freeciv-Dev] [bug #16567] modinst/download.c fails to compile

2010-08-28 Thread George Koehler
URL: http://gna.org/bugs/?16567 Summary: modinst/download.c fails to compile Project: Freeciv Submitted by: kernigh Submitted on: Saturday 08/28/2010 at 17:33 Category: None Severity: 3 - Normal

[Freeciv-Dev] [patch #1860] require gcc 3.4 for __attribute__((warn_unused_result))

2010-08-28 Thread George Koehler
Follow-up Comment #2, patch #1860 (project freeciv): Attaching patch for trunk r17877 (file #10053) ___ Additional Item Attachment: File name: ptrunk-less-warnings-v2.diff Size:2 KB

[Freeciv-Dev] [bug #16506] Non-military units belonging to a class without the ZOC class flag have a ZOC

2010-08-21 Thread George Koehler
Follow-up Comment #6, bug #16506 (project freeciv): The default units.ruleset explains ZOC unit class flag: ; ZOC = Unit is subject to ZOC rules. Unit type flag IgZOC can ; override this And IgZOC unit flag: ; IgZOC = ignore Zones of Control (ZOC) even if

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-08-20 Thread George Koehler
Follow-up Comment #13, bug #15559 (project freeciv): My -v2 patch (from S2_2 r17797) causes a merge conflict in server/sernet.c. I am attaching a new -v3 patch (from S2_2 r17820) to solve the conflict. If you already applied the -v2 patch, you might $ patch -R p22-plural-listen-v2.diff $ svn

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

2010-08-20 Thread George Koehler
Follow-up Comment #3, bug #16491 (project freeciv): Your patch (file #9933) fixes the map editor. I watched as the AI players killed most of the Prussian Warriors, without crashing the server. I will discuss the Longturn bug at its page. You found the page at http://redmine.pagema.net/issues/96

[Freeciv-Dev] [bug #16491] assertion fails in make_contact(), after using editor

2010-08-19 Thread George Koehler
URL: http://gna.org/bugs/?16491 Summary: assertion fails in make_contact(), after using editor Project: Freeciv Submitted by: kernigh Submitted on: Friday 08/20/2010 at 00:36 Category: editor Severity: 3

[Freeciv-Dev] [bug #16448] freeciv.org contact addresses bouncing

2010-08-16 Thread George Koehler
Follow-up Comment #1, bug #16448 (project freeciv): If these email addresses accepted mail, then users would can send email to ask for fix to bug #16338 (DNS problems with freeciv.org). ___ Reply to this item at:

[Freeciv-Dev] [bug #16458] configure fails to find AF_INET6 of OpenBSD

2010-08-16 Thread George Koehler
URL: http://gna.org/bugs/?16458 Summary: configure fails to find AF_INET6 of OpenBSD Project: Freeciv Submitted by: kernigh Submitted on: Monday 08/16/2010 at 21:49 Category: None Severity: 3 - Normal

[Freeciv-Dev] [bug #16454] suggestion about citymindist - only consider same team in calculation

2010-08-16 Thread George Koehler
Follow-up Comment #1, bug #16454 (project freeciv): If citymindist acts as you suggest: 0 You can break alliance, build city too close, then rejoin alliance. 0 You can build city too close (at distance 1) to enemy city. To reduce frustration with citymindist=4, you might want to try

[Freeciv-Dev] [bug #16461] server can exceed MAX_NUM_CONNECTIONS and leak sockets

2010-08-16 Thread George Koehler
URL: http://gna.org/bugs/?16461 Summary: server can exceed MAX_NUM_CONNECTIONS and leak sockets Project: Freeciv Submitted by: kernigh Submitted on: Tuesday 08/17/2010 at 00:02 Category: None Severity: 3

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-08-16 Thread George Koehler
Follow-up Comment #10, bug #15559 (project freeciv): AF_INET6 configure check is now bug #16458. Failure to close extra connections is now bug #16461. (I was wrong. This is not a new bug, because one socket is already enough to accept too many connections. I was idiot and forgot to read my

[Freeciv-Dev] [patch #1860] require gcc 3.4 for __attribute__((warn_unused_result))

2010-08-16 Thread George Koehler
URL: http://gna.org/patch/?1860 Summary: require gcc 3.4 for __attribute__((warn_unused_result)) Project: Freeciv Submitted by: kernigh Submitted on: Tuesday 08/17/2010 at 01:36 Category: general

[Freeciv-Dev] [bug #16442] Great Library should take in account teams, not players

2010-08-16 Thread George Koehler
Follow-up Comment #5, bug #16442 (project freeciv): Notice that file #9848, the S2_2 fix for bug #16442 (Great Library), also includes the fix for bug #16437 (voting bar). Apply one fix, get one fix free! ___ Reply to this item at:

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-08-15 Thread George Koehler
Follow-up Comment #8, bug #15559 (project freeciv): While I am using my patch (file #9838), './ser --bind ::' starts an IPv6-only server, './ser --bind 0.0.0.0' starts an IPv4-only server. If I run IPv4-only server, then my Freeciv client can connect to '127.0.0.1' but refuses to connect to

[Freeciv-Dev] [bug #15559] Client can't connect to its locally started server

2010-08-14 Thread George Koehler
Follow-up Comment #7, bug #15559 (project freeciv): I have a similar bug using OpenBSD. I am running an old snapshot of OpenBSD 4.5-current. My server (S2_2 r17748) accepted connections from localhost and from 127.0.0.1, but not from ::1. I found that my server had no IPv6 support, because

[Freeciv-Dev] [bug #16421] ./civ -a and NEW_PASSWORD_TYPE

2010-08-13 Thread George Koehler
URL: http://gna.org/bugs/?16421 Summary: ./civ -a and NEW_PASSWORD_TYPE Project: Freeciv Submitted by: kernigh Submitted on: Friday 08/13/2010 at 22:06 Category: client-gtk-2.0 Severity: 2 - Minor

[Freeciv-Dev] [bug #16419] Server will not start and cannot start new game

2010-08-13 Thread George Koehler
Follow-up Comment #1, bug #16419 (project freeciv): I tried to reproduce this bug. I installed SVN r17748 of S2_2 into /home/kernigh/prefix/x-freeciv-2.2 of my OpenBSD system, then started the client: $ prefix/x-freeciv-2.2/bin/freeciv-gtk2 The Start New Game button produced the same message:

[Freeciv-Dev] [bug #16308] Great Wall protects wrong units

2010-08-12 Thread George Koehler
Follow-up Comment #4, bug #16308 (project freeciv): Would it be possible to give this defense bonus to every unit placed inside your national borders? No. S2_2 has some requirement types that check tiles (like Special, Terrain, TerrainClass, Base, TerrainAlter, CityTile), but none of these can

[Freeciv-Dev] [bug #16387] attacker can abuse 'go to' to stop pillager

2010-08-09 Thread George Koehler
Follow-up Comment #3, bug #16387 (project freeciv): I expected the pillaging to complete before the pillager dies. I might have confusion about the 'goto' command: because the turn change refills the movement points of the attacker, I expected the attacker to move _after_ the turn change.

[Freeciv-Dev] [bug #16387] attacker can abuse 'go to' to stop pillager

2010-08-08 Thread George Koehler
URL: http://gna.org/bugs/?16387 Summary: attacker can abuse 'go to' to stop pillager Project: Freeciv Submitted by: kernigh Submitted on: Sunday 08/08/2010 at 20:32 Category: None Severity: 2 - Minor

[Freeciv-Dev] [bug #16311] ./civ -a fails to prompt for password

2010-08-06 Thread George Koehler
Follow-up Comment #6, bug #16311 (project freeciv): I wrongly fixed it. We must reject my patch (file #9708) because it adds a bug where the password prompt fails to grab focus when _not_ autoconnecting. ___ Reply to this item at:

[Freeciv-Dev] [bug #16339] The Allies Only button

2010-08-05 Thread George Koehler
Follow-up Comment #3, bug #16339 (project freeciv): This might want a checkbox instead of a button. ___ Reply to this item at: http://gna.org/bugs/?16339 ___ Message sent via/by Gna!

[Freeciv-Dev] [bug #16311] ./civ -a fails to prompt for password

2010-08-05 Thread George Koehler
Follow-up Comment #5, bug #16311 (project freeciv): I thank pepeto for mentioning g_idle_add(). Because g_idle_add() delays set_client_page(PAGE_NETWORK), Freeciv sets NEW_PASSWORD_TYPE or ENTER_PASSWORD_TYPE *before* entering the network page. The problem is that set_client_page(PAGE_NETWORK)

[Freeciv-Dev] [bug #16319] Game Crashes at End of Turn

2010-08-04 Thread George Koehler
Follow-up Comment #1, bug #16319 (project freeciv): I tried to reproduce this bug; I am running OpenBSD and my self-compiled S2_2 r17636 with the GTK client. I loaded file #9628, took the Bretons, moved all my units, and lastly moved the Trireme along the north pole, and then began the next

[Freeciv-Dev] [bug #16338] DNS problems with freeciv.org

2010-08-01 Thread George Koehler
Follow-up Comment #1, bug #16338 (project freeciv): I have the same problem. At 24 July 2010, I visited http://freeciv.org where I saw this error message: 'Wikia is sadly having problems. Our front end caches seem to have gone away. We are working to fix it as soon as possible.' This error was

[Freeciv-Dev] [bug #16296] gtk client fails to sort files in load-save dialog

2010-07-27 Thread George Koehler
Follow-up Comment #4, bug #16296 (project freeciv): I am now running S2_1 and S2_2 with your patches, file #9562 for S2_2 and file #9560 for S2_1. I confirm that they fix the bug. ___ Reply to this item at: http://gna.org/bugs/?16296

[Freeciv-Dev] [bug #16308] Great Wall protects wrong units

2010-07-26 Thread George Koehler
URL: http://gna.org/bugs/?16308 Summary: Great Wall protects wrong units Project: Freeciv Submitted by: kernigh Submitted on: Tuesday 07/27/2010 at 01:10 Category: rulesets Severity: 3 - Normal

[Freeciv-Dev] [bug #16296] gtk client fails to sort files in load-save dialog

2010-07-24 Thread George Koehler
URL: http://gna.org/bugs/?16296 Summary: gtk client fails to sort files in load-save dialog Project: Freeciv Submitted by: kernigh Submitted on: Sunday 07/25/2010 at 02:52 Category: client-gtk-2.0

[Freeciv-Dev] [patch #1710] settlers and workers can be veterans

2010-06-21 Thread George Koehler
Follow-up Comment #4, patch #1710 (project freeciv): I am against file #9348 because it adds a hardcoded exception for NonMil (F_CIVILIAN) units from the Veteran_Build effect. The default ruleset allows communist governments to build veteran Diplomats (or Spies): [effect_communism_0] name

[Freeciv-Dev] [patch #1710] settlers and workers can be veterans

2010-06-18 Thread George Koehler
Follow-up Comment #2, patch #1710 (project freeciv): This patch would only affect unit that have Settlers flag or Cities flag but lack NoVeteran flag. There are no such units in the default ruleset, because Workers, Engineers and Settlers have the NoVeteran flag. This patch would help custom

[Freeciv-Dev] [bug #15144] notradesize not honored for capital city

2010-01-19 Thread George Koehler
Follow-up Comment #5, bug #15144 (project freeciv): This bug happened because Freeciv used normal corruption for notradesize/fulltradesize. Improvements that reduce corruption (Courthouse and Palace) worked against notradesize/fulltradesize. I played a game with notradesize=2, fulltradesize=4.

[Freeciv-Dev] [bug #15030] 'show' command hates server options with underscores

2010-01-01 Thread George Koehler
URL: http://gna.org/bugs/?15030 Summary: 'show' command hates server options with underscores Project: Freeciv Submitted by: kernigh Submitted on: Friday 01/01/2010 at 20:03 Category: None Severity: 2 -

[Freeciv-Dev] [bug #15024] beta civserver crashes at startup

2009-12-31 Thread George Koehler
Follow-up Comment #3, bug #15024 (project freeciv): Yes, your fix (file #7562) works for me. I applied the patch to 2.2.0-beta1. Thank you! Now I can play local game instead of needing a public server. PowerPC likes to pass the first eight function arguments (excepting floating-point) through

[Freeciv-Dev] [bug #14751] configure fails to detect SDL_mixer

2009-11-12 Thread George Koehler
URL: http://gna.org/bugs/?14751 Summary: configure fails to detect SDL_mixer Project: Freeciv Submitted by: kernigh Submitted on: Thursday 11/12/2009 at 21:15 Category: client Severity: 2 - Minor