[Freeciv-Dev] (PR#40610) auto_arrange_workers: Assertion `cmr.found_a_valid' failed.

2008-12-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40610 [guest - Sat Dec 27 19:12:10 2008]: Compiling with -O0 (before was -O2) like: ./configure --prefix=/home/users/vip/freeciv --enable-debug CFLAGS=-O0 and server stopped hanging up while building cities. So, gcc bug? Yes, it is

[Freeciv-Dev] (PR#40611) default.serv sets startunits to cccwwx

2008-12-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40611 [bvanev...@gmail.com - Sat Dec 27 22:33:31 2008]: default.serv has a hack in it which sets startunits to cccwwx. This does not match the server's hardwired default value when starting a game of Freeciv from scratch. The hack is

[Freeciv-Dev] (PR#40610) auto_arrange_workers: Assertion `cmr.found_a_valid' failed.

2008-12-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40610 This was reported on the forums: http://forum.freeciv.org/viewtopic.php?t=5730 Server fails to autoarrange workers triggering the assertion in the subject line. The program version is 2.1.8, a fedora package. Server log also has: 3:

[Freeciv-Dev] (PR#40605) timer_list_size() crash

2008-12-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40605 [cazf...@gmail.com - Fri Dec 19 11:08:09 2008]: 2.1.8, using fantasy ruleset Program terminated with signal 11, Segmentation fault. [New process 20595] #0 0x0042a01b in genlist_size () (gdb) bt full #0

[Freeciv-Dev] (PR#40604) [Patch] Fix load command file name searching

2008-12-18 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40604 Attached patch cleans up the file path and extenstion checking code in the load_command() function. Also, the extensions .gz, .bz2, and .sav.bz2, are added to the searching code since it is a common enough occurrence that save files end

[Freeciv-Dev] (PR#40600) Bug with civserver.exe

2008-12-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40600 [arch.and...@mail.ru - Wed Dec 17 15:51:23 2008]: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40600 [arch.and...@mail.ru - Sun Dec 14 11:38:50 2008]: Good day! Today I'm upgraded to new version of freeciv

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [bvanev...@gmail.com - Wed Dec 17 21:30:18 2008]: On Wed, Dec 17, 2008 at 4:28 PM, Jordi Negrevernis i Font jnegrever...@jnfprogramari.com wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 I must say that

Re: [Freeciv-Dev] function genlist_size() causes game to crash after I've added new effect

2008-12-17 Thread Madeline Book
On 12/17/08, Yoav Luft yoav.l...@gmail.com wrote: Hi, I've written a little patch to the stable tree, as a way to acquaint myself with the code of freeciv. The patch adds the new functionality of plagues to game, which are determined randomly based on the size, pollution, improvements and

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [bvanev...@gmail.com - Wed Dec 17 23:43:51 2008]: On Wed, Dec 17, 2008 at 5:42 PM, Madeline Book madeline.b...@gmail.com wrote: This could be proven if you turn off the prompt for city name option and build a city

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [cproc - Thu Dec 18 04:42:10 2008]: The default Windows character set in western countries is CP1252: http://en.wikipedia.org/wiki/CP1252 Ah thanks for that, the last piece of the puzzle. ;) In this character set 0xA0 means

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [bvanev...@gmail.com - Thu Dec 18 04:26:29 2008]: On Wed, Dec 17, 2008 at 9:04 PM, Madeline Book madeline.b...@gmail.com wrote: When you start a client from a dos window, it should print a line like: Encodings: Data=UTF-8

[Freeciv-Dev] (PR#40598) Embassy lost over save/reload

2008-12-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40598 [book - Sun Dec 14 06:25:45 2008]: [chrisk - Sun Dec 14 05:58:11 2008]: Trunk Revision 15365 GTK All my embassies get lost when I save the game and reload it. Pretty new. Probably another case of players_iterate

[Freeciv-Dev] (PR#40594) Bug: blank (Research) tab causes crash

2008-12-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40594 [jesdisci...@gmail.com - Wed Dec 10 05:04:53 2008]: I was fairly late in a game yesterday and had noticed that the game slowed as its state got more complex. During the AI's turn, the window would gray to indicate such, and

[Freeciv-Dev] (PR#16243) Freeciv 2.1.0-beta1: trade routes

2008-12-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=16243 [guest - Mon Sep 04 13:56:42 2006]: A small comment concerning this pop-up window. It would be nice if it has a frame. Being of the same color as the main dialog, it creates the data overlap effect when activated. Attached patch

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [bvanev...@gmail.com - Mon Dec 15 02:25:20 2008]: In civclient 2.1.7, a random city name was generated, Perpiny[X]. The [X] stands for some weird graphic of a presumably unprintable character. Clicking on this city crashes both

[Freeciv-Dev] (PR#40601) bad char in city name crashes GTK civclient 2.1.7 and 2.1.8

2008-12-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40601 [bvanev...@gmail.com - Wed Dec 17 03:17:43 2008]: On Tue, Dec 16, 2008 at 8:25 PM, Madeline Book madeline.b...@gmail.com wrote: So my best guess is that somehow the contents of the save file got munged into the present state

[Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-12-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 [guest - Mon Dec 15 08:24:56 2008]: [book - Mo 10. Nov 2008, 01:16:10]: [guest - Sun Nov 09 12:02:10 2008]: This is still an issue. A lot of netbooks have a 1024x600 resolution on which freeciv is unplayable. Please

[Freeciv-Dev] (PR#40599) Total buy cost display update bug

2008-12-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40599 [chrisk - Sun Dec 14 06:54:21 2008]: Trunk Revision: 15365 GTK When selecting a set of cities with items to buy in the city report, the total buy costs are shown in the bottom of the report window. Now, when I change the

[Freeciv-Dev] (PR#40597) [Patch] Improved hash iteration

2008-12-13 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40597 [book - Thu Dec 11 06:52:46 2008]: Attached patch improves hash key/value iteration using the iterator interface in 40596. Here is the version using the second version of the iterator interface.

[Freeciv-Dev] (PR#17435) island generator connects continents

2008-12-13 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17435 [book - Thu Dec 11 23:56:50 2008]: I have confirmed that the island generator (gen 3) will sometimes place islands in a way that there is no ocean between them. I have also tested the patch and it solved the problem in all my

[Freeciv-Dev] (PR#15947) 2.1 - Island generator doesn't generate any rivers

2008-12-13 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=15947 [bjo...@gmail.com - Wed Oct 11 08:30:52 2006]: So I fixed fill_island_rivers(..) as best I could with my rusty programming skills. I tested your patch and it works well. In the attached patches I made some minor formatting and

[Freeciv-Dev] (PR#40598) Embassy lost over save/reload

2008-12-13 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40598 [chrisk - Sun Dec 14 05:58:11 2008]: Trunk Revision 15365 GTK All my embassies get lost when I save the game and reload it. Pretty new. Probably another case of players_iterate vs. player_slots_iterate. I'll check it out.

[Freeciv-Dev] (PR#40592) auth backend support

2008-12-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40592 [sch...@debian.org - Wed Dec 10 22:50:45 2008]: On Wed, Dec 10, 2008 at 01:57:51AM -0800, Jason Dorje Short wrote: GGZ provides all the same features as auth with multiple backends support. I'd see improving the GGZ support as

[Freeciv-Dev] (PR#40596) [Patch] Generic iterator interface

2008-12-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40596 [book - Thu Dec 11 06:36:54 2008]: Attached patch adds a generic iterator interface for implementing iteration macros. [...] Now while the 4 goals listed above should be satisfied by this framework, there are some

[Freeciv-Dev] (PR#17435) island generator connects continents

2008-12-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=17435 I have confirmed that the island generator (gen 3) will sometimes place islands in a way that there is no ocean between them. I have also tested the patch and it solved the problem in all my tests. Since the code looks fine I will commit

[Freeciv-Dev] (PR#40596) [Patch] Generic iterator interface

2008-12-10 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40596 Attached patch adds a generic iterator interface for implementing iteration macros. This framework serves the following purposes: 1. Hide specific container and iterator implementation details from other code modules, in particular

[Freeciv-Dev] (PR#40597) [Patch] Improved hash iteration

2008-12-10 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40597 Attached patch improves hash key/value iteration using the iterator interface in 40596. - For convenience three iterate macros are provided for hash tables: for iterating over keys, values, or both. - The implementation of the

[Freeciv-Dev] (PR#40593) [Editor] Cleanup editing allowed checks

2008-12-09 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40593 Attached patch reduces code duplication by moving the check whether a connection is allowed to edit out of every server edit handler and into server_packet_input() before the handlers are called.

[Freeciv-Dev] (PR#40595) Bug: crash causes loss of automatic movement deference

2008-12-09 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40595 [EMAIL PROTECTED] - Wed Dec 10 05:35:00 2008]: I'm running Ubuntu Linux; I installed Freeciv 2.1.5 as a (Debian, of course) binary. Since many critical bugs have been fixed since 2.1.5 I would suggest that you upgrade to the latest

[Freeciv-Dev] (PR#40591) [Patch] Make tired attack a ruleset option

2008-12-08 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40591 A number of players do not appreciate the removal of the tired attack penalty (units attack strength reduced if they attack with 1/3 or 2/3 moves left), including myself. When I brought this up on the longturn site,

[Freeciv-Dev] (PR#40592) auth backend support

2008-12-08 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40592 [EMAIL PROTECTED] - Tue Dec 09 00:24:30 2008]: auth support is tied to mysql, rather than a generic interface which could support another backend, such as sqlite or postgres. Yes, I agree, though this would be some work to cleanup

[Freeciv-Dev] (PR#40590) [Patch] Allow gtk2 gui to select road as pillage target

2008-12-04 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40590 If there is more than one pillage target on a tile the gtk2 gui prevents selecting a road as the target. This is because S_ROAD is equal to zero so it becomes NULL when casted to a pointer as a callback userdata argument, which is then

[Freeciv-Dev] (PR#40586) No fog of war after cancelling alliance

2008-12-03 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40586 [chrisk - Wed Dec 03 14:29:56 2008]: rev today trunk+fix-player-loading-patch GTK After cancelling an alliance with an ai player, I still can see into his territory, at least the fog of war is not shown on the map during the

[Freeciv-Dev] (PR#40585) [Patch] aifill in the middle of game loading?

2008-12-02 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40585 Attached patch makes the aifill call in load_ruleset only activated when it is actually needed, instead of being called all the time in the middle of game loads (etc.) where it stomps all over the server player state.

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-12-01 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 [pepeto - Mon Dec 01 22:45:49 2008]: [book - Mon Dec 01 22:15:19 2008]: [pepeto - Mon Dec 01 07:17:09 2008]: [book - Mon Dec 01 03:54:35 2008]: I also made some minor style changes (but I tested the above

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-30 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 [pepeto - Sat Nov 15 13:39:13 2008]: Feel free to modify the patch. Alright, finally I have time to get back to this. This time when testing I found that bombers when they have to wait at a tile before doing an attack (i.e. the

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Thu Nov 27 12:58:06 2008]: On Wed, 26 Nov 2008 11:34:07 +0900, Madeline Book [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Tue Nov 25 23:41:12 2008]: On Wed

[Freeciv-Dev] (PR#39131) Connection troubles

2008-11-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39131 [pepeto - Thu Nov 27 07:49:11 2008]: Unfortunately, this patch wouldn't remove the useless warning WARNING: trying to send data to the closed connection. It needs also to check after command_ok = handle_packet_input(pconn,

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Thu Nov 27 23:25:28 2008]: On Fri, 28 Nov 2008 07:33:23 +0900, Madeline Book [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Thu Nov 27 12:58:06 2008]: On Wed

[Freeciv-Dev] (PR#40479) Connection list does not update when command level changes.

2008-11-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40479 [book - Fri Sep 05 22:13:20 2008]: The connection list in the pregame page does not remove the '*' after a player's name when their command level changes from 'hack' to something less. Attached patch adds the required connection

[Freeciv-Dev] (PR#40582) GStreamer audio plugin

2008-11-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40582 [EMAIL PROTECTED] - Thu Nov 27 00:35:28 2008]: Hello all, I tried to make a GStreamer audio plugin for Freeciv. It's a work in progress but it already works well. It's my first contribution so, please let me know if there are

[Freeciv-Dev] (PR#40580) cut command problems

2008-11-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40580 [pepeto - Mon Nov 24 22:27:47 2008]: [book - Mon Nov 24 22:05:02 2008]: If a connection cuts itself, there is an error in the server: WARNING: trying to send data to the closed connection and it becomes impossible to

[Freeciv-Dev] (PR#39613) Left user in client connection list

2008-11-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39613 [pepeto - Sat Aug 25 15:15:14 2007]: When a user which is detached loses connection or leaves, the client is not informed of it. The connection is still in the visible connection list. I fixed this bug a long time ago for

[Freeciv-Dev] (PR#39131) Connection troubles

2008-11-26 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39131 [pepeto - Wed Jun 25 11:30:21 2008]: It actually occurs when the client connection is broken by the server whereas the server is reading a packet from. A simple example is when you attempt to cut yourself from the server. Then,

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Tue Nov 25 12:13:00 2008]: On Tue, 25 Nov 2008 09:56:59 +0900, Madeline Book [EMAIL PROTECTED] wrote: [...] If no problems are found with the patch I would suggest that server operators apply the patch

[Freeciv-Dev] (PR#40581) [RFC] Remove all request_id stuff

2008-11-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40581 [EMAIL PROTECTED] - Tue Nov 25 05:40:06 2008]: I thought the request_id was intended to associate a packet sent to the client with the particular request that the client had sent to the server. [...] Now at what point does the

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Tue Nov 25 23:41:12 2008]: On Wed, 26 Nov 2008 04:53:37 +0900, Madeline Book [EMAIL PROTECTED] wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [dmarks - Tue Nov 25 12:13:00 2008]: On Tue

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [EMAIL PROTECTED] - Mon Nov 24 18:57:36 2008]: From 2.1.7 server: Program terminated with signal 11, Segmentation fault. [New process 14692] #0 0x004c66b0 in server_player_init () (gdb) bt full #0 0x004c66b0

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40570 [EMAIL PROTECTED] - Fri Nov 21 07:07:26 2008]: Your no_fights appoach is nice but insufficent. 1) it doesn't work for non_allied_unit_tiles that have only allied units on them I may be mistaken but, do you mean that the

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40579 [EMAIL PROTECTED] - Mon Nov 24 23:50:05 2008]: 2008/11/24 Madeline Book: Do you know what you did to get the segfault? That core is from public server. From logs it seems that sequence has been: /set aifill 0

[Freeciv-Dev] (PR#40581) [RFC] Remove all request_id stuff

2008-11-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40581 I propose that all request_id related code be removed, since it unnecessarily complicates connection handling, causes side-effect bugs and desynchronization between the client and server (due to its state dependence), and generally does

[Freeciv-Dev] (PR#40429) Bug: [EMAIL PROTECTED] doesn't work

2008-11-23 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40429 [dmarks - Sun Nov 23 23:26:03 2008]: This is fixed now on server. The current bug report address should be showing on the RT dashboard and ticket view pages. Please verify! Confirmed that logging in as guest shows the correct

[Freeciv-Dev] (PR#40577) [Patch] load_auth_config is too untrusting

2008-11-23 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40577 Even though load_auth_config() is only ever called with a filename from the server command line, it uses is_safe_filename() to disallow .. in the path. This makes it rather annoying for testing. Since it is in all likelyhood fine to

[Freeciv-Dev] (PR#40578) [Patch] Fix buffer overrun in create_md5sum

2008-11-23 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40578 The call to sprintf in create_md5sum() writes the terminating '\0' past the end of the supplied output buffer if the buffer has exactly DIGEST_HEX_BYTES bytes. Attached patch makes the original buffer in authdb_check_password() large

[Freeciv-Dev] (PR#40539) Fortress cannot be pillaged

2008-11-20 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40539 [EMAIL PROTECTED] - Mon Oct 27 03:13:45 2008]: Currently fortress (and likely other bases) cannot be pillaged. Pillage command is not sensitive when tile has only fortress. Tested with gtk-client. Here's a minimal fix patch. All

[Freeciv-Dev] (PR#40574) [Patch] Fix trident fortress being drawn over units

2008-11-20 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40574 In the trident tiles.spec the fortress image is assinged to the tag fortress_fg. This causes it to be drawn in LAYER_SPECIAL3 which the drawing code assumes is to be drawn over units. Attached patch changes the tag to fortress_bg so

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-20 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40570 [EMAIL PROTECTED] - Thu Nov 20 21:19:18 2008]: In the attached game the only Columbian unit - if set to auto explore - tries to violate the peace treaty. Thanks for the savegame. I have confirmed that making the unit auto-explore

[Freeciv-Dev] (PR#40575) [Editor] Don't apply tool to selection when using shortcut key

2008-11-20 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40575 In practice I have found the behaviour of simultaneously switching to and applying the new tool to all selected tiles when pressing an editor tool shortcut key (e.g. 't') somewhat annoying. This patch removes that behaviour; the current

Re: [Freeciv-Dev] trunk doesn't compile

2008-11-19 Thread Madeline Book
On 11/19/08, Christian Knoke [EMAIL PROTECTED] wrote: Aktualisiert zu Revision 15316. edithand.c:39:22: error: edithand.h: Datei oder Verzeichnis nicht gefunden Sorry, my mistake. I forgot to add the new file in r15316. It should be there now. :|

[Freeciv-Dev] (PR#40571) Detected fatal error in nation.c line 262

2008-11-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40571 [chrisk - Wed Nov 19 20:14:53 2008]: with rev. 15317 trunk GTK the attached save game crashes when I start the game and press F3. This is same as 40565. Patch in that ticket should fix it.

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40570 [EMAIL PROTECTED] - Wed Nov 19 07:45:23 2008]: Marine explorers stop if they try to travel to or trhough a marine tile who's owner is at peace with the unit's owner. As a consequence the units are stoped and require player

[Freeciv-Dev] (PR#40573) [Editor] Tile bases property

2008-11-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40573 Attached patch implements a property for viewing and modifying bases on a tile in the property editor. Thus also copy/paste mode is made to work for the base tool. Hence the patch builds on the one in 40569. Incidentally, just for the

[Freeciv-Dev] (PR#40529) command /take - sends garbage text if it fails

2008-11-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40529 [book - Tue Oct 14 02:25:33 2008]: If a detached or observer connection does /take - when the game is running and there are no free players to attach to, instead of an error message the client receives invalid utf8 causing the

[Freeciv-Dev] (PR#40529) command /take - sends garbage text if it fails

2008-11-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40529 [book - Thu Nov 20 05:31:37 2008]: Attached patch fixes the is_allowed_to_take() function to always set the reason string when it returns FALSE so that the above sending of an uninitialized string does not occur. And here's the

[Freeciv-Dev] (PR#40567) [Patch] Some tile helper functions

2008-11-18 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40567 Some tile helper functions that I needed to add for cleaner virtual tile manipulation: void tile_set_specials(struct tile *ptile, bv_special specials); bv_bases tile_bases(const struct tile *ptile); void tile_set_bases(struct tile

[Freeciv-Dev] (PR#40568) [Editor] Copy and paste icons

2008-11-18 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40568 I fashioned two icons representing copy and paste out of one of pep's (!= pepeto) editor icons. Attached is the new editor.png and a patch to make the icons usable in the code. Also, I originally made a mistake in the spec file (off by

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40561 Version 3 fixes a mistake in edithand_init(). --- 見つけられますか? commit 84e305391f23dbaeafc8c4891e0ededba8ffa364 Author: Madeline Book [EMAIL PROTECTED] Date: Sun Nov 16

[Freeciv-Dev] (PR#40565) 0: nation_of_player() has NULL nation

2008-11-15 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40565 [pepeto - Sat Nov 15 14:08:13 2008]: Every time I reload a savegame with trunk/, I cannot open the nation page: 0: nation_of_player() has NULL nation 0: Detected fatal error in nation.c line 262: 0: bad nation Yep, confirmed.

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-14 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 Alright, with the patch in 40563 this new goto code works great, even better than the old warmap code. All I could find is a minor display annoyance in that if a fighter or bomber type unit has only 1 move left, then the turns to target

[Freeciv-Dev] (PR#40562) [Editor] Some more unit properties

2008-11-13 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40562 Attached patch implements unit properties 'fuel', 'moved' 'done_moving', 'hp' and 'veteran' for the property editor. --- 洗濯しなければ、あの委員会は来て服を押収するよ。 diff --git

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40561 Attached patch removes some struct fields in struct player and struct tile that were only used by the server for editor related support code. Instead, static data structures are added to edithand.c which keep track of the necessary

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40561 Forgot to include server/edithand.h in the last patch. --- どこへ行くつもりですか。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
。 commit 7060c10f42c18ed42b1c4292c08bbffad5b8f5e6 Author: Madeline Book [EMAIL PROTECTED] Date: Wed Nov 12 20:11:56 2008 -0500 no_server_editor_stuff_in_common_v2.patch --- common/map.c |1 - common/player.h|3 -- common/tile.h |3 -- server/Makefile.am |1

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-12 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 Hmm perhaps I spoke too soon about fighters in my last reply. Now it sometimes happens that a fighter with 2 or 3 moves left will wait in a city if the user does a goto 1 tile out of the city. It is very odd in that it appears to happen

[Freeciv-Dev] (PR#40559) [Patch] Fix quotes in take command string used by editor toolbar

2008-11-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40559 If a player name contained a single quote, the command string sent by the player-point-of-view combobox in the editor toolbar would be wrong and the server would not be able to parse the command correctly. The attached patch changes the

[Freeciv-Dev] (PR#40560) [Editor] Tile vision property

2008-11-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40560 Attached patch implements a tile vision property for the property editor. This property can be used to view the contents of the player bitvectors ptile-tile_known and ptile-tile_seen[v] (for each vision layer v). This is only really

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-11 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 [pepeto - Tue Nov 11 13:20:18 2008]: I changed completely my initial mind to fix the last strange behaviour I observed. I rewrote the nearly-whole path_finding.c file. Ah, the worst case scenario I was afraid of... but seems you

[Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-11-09 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=12825 [guest - Sun Nov 09 12:02:10 2008]: This is still an issue. A lot of netbooks have a 1024x600 resolution on which freeciv is unplayable. Please consider making the interface work on those screens. Could you be more specific about

[Freeciv-Dev] (PR#40556) Server crash (assertion failure) (v2.1.4)

2008-11-08 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40556 [EMAIL PROTECTED] - Sun Nov 09 03:10:54 2008]: The server crashes with the following message: civserver: unithand.c:362: real_unit_change_homecity: Assertion `!unit_alive || unit_owner(punit) == city_owner(new_pcity)' failed.

[Freeciv-Dev] (PR#40553) Trunk depends on gtk+ 2.8+

2008-11-07 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40553 Attached patch replaces the call to gtk_tree_row_reference_get_model by an equivalent expression. --- 暗黒時代にようこそ! diff --git a/client/gui-gtk-2.0/editprop.c

[Freeciv-Dev] (PR#40144) [Patch] Build multiple clients at once

2008-11-07 Thread Madeline Book
. If at least the double-compilation problem can be improved, I would consider committing this to trunk. --- 正義のために変身して団結せよ!! commit 582a7b9c10ccb8699d81cf5d1872d3d53371510d Author: Madeline Book [EMAIL PROTECTED] Date: Sat Nov 8 00:15

[Freeciv-Dev] (PR#40552) [Patch] Voting code cleanup

2008-11-06 Thread Madeline Book
c4c237468058e1b40f85af7c36139d10db2a5406 Author: Madeline Book [EMAIL PROTECTED] Date: Thu Nov 6 16:02:37 2008 -0500 Voting cleanup. --- server/Makefile.am |4 +- server/sernet.c|1 + server/srv_main.c |4 + server/stdinhand.c | 463 +++-- server/stdinhand.h |3

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-05 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 [pepeto - Wed Nov 05 17:14:11 2008]: I hope this version should work very better. This version is the best so far. I did find one strange thing though: take for example a fighter from Arnsberg and make a goto attack on Kranj. The

[Freeciv-Dev] (PR#40551) [Patch] Fix some more places assuming contiguous player numbers

2008-11-05 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40551 Attached patch fixes some more places in the code where player numbers were assumed to be in [0, player_count()). --- 虫を食うな! client/gui-gtk-2.0/plrdlg.c |4 ++--

[Freeciv-Dev] (PR#40548) civclient segv

2008-11-03 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40548 I was just fixing this bug. It is due to the fact that the function update_conn_list_dialog() assumes contiguous player numbers, which is no longer a valid assumption. I'll post the patch soon.

[Freeciv-Dev] (PR#40549) [Patch] Conn/player stdinhand tweaks

2008-11-03 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40549 I separated out the stdinhand part of 40534 and added some more fixes for bugs I found during testing: - Sometimes the observe command would not send player info. - The take command would not send player info about the other players

[Freeciv-Dev] (PR#40543) Farmland looks like Irrigation in amplio Tileset

2008-11-03 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40543 [book - Wed Oct 29 18:55:24 2008]: Maybe the fields of crops could be made less opaque [...] I meant to say more opaque, that is, less transparent. Sorry for the confusion. ;)

[Freeciv-Dev] (PR#40547) [Patch] Virtual tiles and is_virtual check functions

2008-10-31 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40547 Attached patch adds {create,destroy}_tile_virtual to allow the use of virtual tiles in the same manner as virtual units and cities. It also adds helper functions to check whether a given unit or city is virtual (i.e. is a valid pointer

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-10-30 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 [pepeto - Wed Oct 29 09:03:33 2008]: [book - Wed Oct 29 01:45:22 2008]: Good stuff. There remains only one weird thing that I could find: now when a figher or bomber is made to attack an enemy city or unit via goto, it

[Freeciv-Dev] (PR#40543) Farmland looks like Irrigation in amplio Tileset

2008-10-29 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40543 [EMAIL PROTECTED] - Tue Oct 28 18:06:54 2008]: I really enjoyed FreeCiv and I like the amplio tileset, but after a few hours of playing it began to bother me, that irrigation and farmland looks exactly the same! I edited the

[Freeciv-Dev] (PR#40545) [Patch] Remove old edit menu in player list dialog

2008-10-29 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40545 The property editor is now used to edit players, so the edit menu in the player dialog can be removed. --- 七日なのに、アイス屋さんが来なかった。凍え死んだかも。 diff --git

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-10-28 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40536 I tested the patch and it works fairly well. It is a big improvement over the current broken goto for air units, so I will test it some more and commit it soon if I do not find anything obviously bad. I found some strange things while

Re: [Freeciv-Dev] [Discussion] Trade routes and special resources

2008-10-28 Thread Madeline Book
On 10/27/08, Yoav Luft [EMAIL PROTECTED] wrote: I decided to add a more complex and interesting trade system for freeciv. Something much like Civ3 trade system with special resources that can be trade and are requisite for building certain buildings. I'm not quite sure how it should be done

[Freeciv-Dev] (PR#40524) [Patch] Server/client player handling cleanup

2008-10-27 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40524 [book - Sat Oct 11 05:09:08 2008]: Attached patch improves the player structure handling on the server and the client, along with the protocol the two use to communicate changes in player data. I have now commited this patch to

[Freeciv-Dev] (PR#40537) [Editor] Cleaner start position handling

2008-10-25 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40537 Attached patch cleans up the editor related start position handling code in the server and the client. The start positions are kept in a hash table in the 'map' structure. Common accessor functions map_{get,set,clear}_startpos are used

[Freeciv-Dev] (PR#40533) Autocenter on new turn option

2008-10-24 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40533 Attached patch makes the rather annoying automatic map recentering when a new turn starts an option, so that people can turn it off if desired. Also, moves some calls to functions that as far as I can see should only be called when

[Freeciv-Dev] (PR#40466) [Patch] Do not allow positive timeout less than 30

2008-10-19 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40466 Updated yet again, to apply cleanly to current codebase and with some minor style improvements. --- 濡れた衣装が体にくっついている彼女がいるパーティーもいいですか。 server/report.c|4 +++-

[Freeciv-Dev] (PR#40531) crash on editing borders

2008-10-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40531 [chrisk - Fri Oct 17 10:06:57 2008]: In the attempt to correct the borders wrong set as shown in http://bugs.freeciv.org/Ticket/Display.html?id=40526 I switched to edit mode and set the terrain ownership, in a reasonable

[Freeciv-Dev] (PR#39369) typing mistake in file data/stdsounds.soundspec

2008-10-17 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39369 [EMAIL PROTECTED] - Sat Oct 18 00:24:16 2008]: The same issue still applies to S2_1 and S2_2 -- any chance of porting the typo fix? Ok. --- 鋏は一番上の引き出しにあります。

[Freeciv-Dev] (PR#40530) Assertion failure during popup of marine captured city

2008-10-16 Thread Madeline Book
URL: http://bugs.freeciv.org/Ticket/Display.html?id=40530 Relaying a bug report posted to freeciv-dev: [Julian Marchant [EMAIL PROTECTED] - Wed, 15 Oct 2008 19:24:28 -0400]: I have encountered the same bug in the stable 2.1 version. I have attached a screenshot so you can see what it

<    1   2   3   4   5   6   7   >