[Freeciv-Dev] (PR#40510) Bug: ZOC for RIP players

2008-09-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40510 > > [EMAIL PROTECTED] - Tue Sep 30 14:06:10 2008]: > > I'm playing Freeciv 2.1.3, and I've noticed that territory > that belonged to a player who's now RIP still belongs to > that player. I had to 'cancel treaty' to move bombers > over that te

[Freeciv-Dev] (PR#40119) [PATCH] Gtk client: Airlift/Goto dialog resizes badly

2008-09-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40119 > > [EMAIL PROTECTED] - Sat Mar 01 13:02:02 2008]: > > In the Gtk2 client, if the Airlift/Goto dialog is resized vertically, > you don't actually get to see any more cities; the extra space is used > for padding. > > The attached trivial patc

[Freeciv-Dev] (PR#40508) Remove trunk

2008-09-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40508 > > [EMAIL PROTECTED] - Tue Sep 30 20:10:01 2008]: > > No objection from here. > > I spent a fair chunk of time comparing diffs from 2.2 and trunk to see > if the development branch had any patches that were missing from 2.2. > I found a few

[Freeciv-Dev] (PR#40511) [Editor] Property filter improvements

2008-10-01 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40511 > Attached patch improves the property name filter (previously called "quick find") for property pages in the property editor. Improvements: - The filter string can contain |, & and ! to indicate logical OR, AND, and NOT respectively. - The

[Freeciv-Dev] (PR#40512) [Editor] Tooltip and some widget layout cleanup

2008-10-02 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40512 > Attached patch greatly expands tooltips and fixes a few that were not being shown because their widget needed to be in an event box. Also, widget layout was improved in the property editor, and the close button was moved to the tab label (li

[Freeciv-Dev] (PR#40513) [Editor] Fix assertion failure when editing player nation

2008-10-02 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40513 > If a user tries to set a player's nation to one already assigned to a different player via the property editor, then an assertion fails in the server. Attached patch fixes this by disallowing setting of already assigned nations on the server

[Freeciv-Dev] (PR#40516) [Patch] Fix player assertion due to nation pick

2008-10-04 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40516 > It is possible to crash the client if a user detaches or observes then clicks on the "Take Player" button, selects a nation, and presses "Ok". Attached patch fixes this for S2_1. The S2_2/trunk version also fixes the conditions for picking a

[Freeciv-Dev] (PR#40466) [Patch] Do not allow positive timeout less than 30

2008-10-06 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40466 > Improved some formatting and fixed some calls to avoid the missing format string warning in 40504. --- 殺意がなくなりました。どういう意味ですか? diff --git a/server/report.c b/server/report.c

[Freeciv-Dev] (PR#40481) [Patch] Minor aifill fixes

2008-10-06 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40481 > > [book - Sat Sep 06 00:13:04 2008]: > > For some reason that is not apparent to me the aifill > function does nothing when the aifill amount is zero. > This is changed to allow setting aifill=0 and thus > removing all filled-in AIs. Obviou

[Freeciv-Dev] (PR#40521) server hang on completely unbuildable worklist

2008-10-08 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40521 > > [EMAIL PROTECTED] - Wed Oct 08 01:41:10 2008]: > > Build city, go to worklist tab, check "show future targets", add > something you can't build. Wait for the first (buildable) item to be > built, or buy it. Watch the server spin forever in

[Freeciv-Dev] (PR#40517) Can't load savegames in 2.2

2008-10-09 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40517 > > [EMAIL PROTECTED] - Thu Oct 09 16:02:18 2008]: > > On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote: > > On Thu, 9 Oct 2008 Egor Vyscrebentsov wrote: > > > > > Quickest (not the best) fix is > > > > > > - } else if (base_buf) { > > >

[Freeciv-Dev] (PR#40521) server hang on completely unbuildable worklist

2008-10-10 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40521 > > [book - Wed Oct 08 23:41:41 2008]: > > > [EMAIL PROTECTED] - Wed Oct 08 01:41:10 2008]: > > > > Build city, go to worklist tab, check "show future targets", add > > something you can't build. Wait for the first (buildable) item to be > >

[Freeciv-Dev] (PR#40523) core on game start

2008-10-10 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40523 > > [chrisk - Fri Oct 10 22:06:17 2008]: > > something's wrong with map generation in SVN 11 OCT 2008 23:30 > CEST 2.1.99 GTK2 This is 40453, and affects S2_1 as well. Since Marko has more fun things to do at the moment (:D) I'll try to fix t

[Freeciv-Dev] (PR#40517) Can't load savegames in 2.2

2008-10-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40517 > > [EMAIL PROTECTED] - Fri Oct 10 19:37:34 2008]: > > On Thu, 9 Oct 2008 Madeline Book wrote: > > > The missing '\0' at the end of base_buf seems to be the main > > bug; > > No, all chars afte

[Freeciv-Dev] (PR#40515) Windows Vista x64 running client 2.1.99 built on 25/09/2008 unable to load save file

2008-10-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40515 > > [EMAIL PROTECTED] - Tue Oct 07 01:59:00 2008]: > > 2008/10/5 Christian Prochaska: > > > > The problem is that send_chat_printf() cuts the /load message > > (and any other message) after 50 characters, so the path gets > > trunkated. > > W

[Freeciv-Dev] (PR#40453) Random assertion failures in map generation

2008-10-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40453 > So unfortunately it did end up being due to the patch in 40417 (separatepoles fix), in particular: land_fill = pick_terrain(MG_LAST, MG_LAST, MG_LAST); was being used to pick a "land" (i.e. non-ocean) terrain that was then used to fill i

[Freeciv-Dev] (PR#40528) Lake property_ocean_depth is zero, same as is if left unspecified?

2008-10-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40528 > In the terrain.ruleset file in the default ruleset the lake terrain type has the field property_ocean_depth = 0. Now when the ruleset is loaded, terrain types that do not specify this field have the value also set to zero, so the lake terrain

[Freeciv-Dev] (PR#40529) command "/take -" sends garbage text if it fails

2008-10-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40529 > If a detached or observer connection does "/take -" when the game is running and there are no free players to attach to, instead of an error message the client receives invalid utf8 causing the chatline to display a completely blank line and

[Freeciv-Dev] (PR#40503) Impossible to build trireme with map generator 3

2008-10-15 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40503 > Attached patch adds a function that recreates shallow coastal areas for generator 3 (the island generator). This at least makes triremes usable in the default ruleset. The method is to make a "depth map" and use the gaussian diffusion filter

[Freeciv-Dev] (PR#40530) Assertion failure during popup of marine captured city

2008-10-16 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40530 > Relaying a bug report posted to freeciv-dev: [Julian Marchant <[EMAIL PROTECTED]> - Wed, 15 Oct 2008 19:24:28 -0400]: > I have encountered the same bug in the stable 2.1 > version. I have attached a screenshot so you can see what > it looke

Re: [Freeciv-Dev] Annoying bug

2008-10-16 Thread Madeline Book
You should send bug reports to the address in the top left image on the bugs.freeciv.org page. That way they will be automatically added to the bug tracker. Anyway, I have added your report myself; it is under ticket 40530 (http://bugs.freeciv.org/Ticket/Display.html?id=40530). Use the guest login

[Freeciv-Dev] (PR#40531) crash on editing borders

2008-10-17 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40531 > > [chrisk - Fri Oct 17 10:06:57 2008]: > > > In the attempt to correct the borders wrong set as shown in > > http://bugs.freeciv.org/Ticket/Display.html?id=40526 > > I switched to edit mode and set the terrain ownership, > in a reasonable

[Freeciv-Dev] (PR#39369) typing mistake in file data/stdsounds.soundspec

2008-10-17 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39369 > > [EMAIL PROTECTED] - Sat Oct 18 00:24:16 2008]: > > The same issue still applies to S2_1 and S2_2 -- any chance of porting > the typo fix? Ok. --- 鋏は一番上の引き出しにあります。 _

[Freeciv-Dev] (PR#40466) [Patch] Do not allow positive timeout less than 30

2008-10-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40466 > Updated yet again, to apply cleanly to current codebase and with some minor style improvements. --- 濡れた衣装が体にくっついている彼女がいるパーティーもいいですか。 server/report.c|4 +++- server

[Freeciv-Dev] (PR#40533) Autocenter on new turn option

2008-10-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40533 > Attached patch makes the rather annoying automatic map recentering when a new turn starts an option, so that people can turn it off if desired. Also, moves some calls to functions that as far as I can see should only be called when entering

[Freeciv-Dev] (PR#40537) [Editor] Cleaner start position handling

2008-10-25 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40537 > Attached patch cleans up the editor related start position handling code in the server and the client. The start positions are kept in a hash table in the 'map' structure. Common accessor functions map_{get,set,clear}_startpos are used by th

[Freeciv-Dev] (PR#40524) [Patch] Server/client player handling cleanup

2008-10-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40524 > > [book - Sat Oct 11 05:09:08 2008]: > > Attached patch improves the player structure handling on the > server and the client, along with the protocol the two use to > communicate changes in player data. I have now commited this patch to tr

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-10-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > I tested the patch and it works fairly well. It is a big improvement over the current broken goto for air units, so I will test it some more and commit it soon if I do not find anything obviously bad. I found some strange things while testing

[Freeciv-Dev] (PR#40540) Fix forgotten sending of player info in pregame

2008-10-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40540 > Already a bug found from 40524. :) Anyway, the fix is easy enough. --- 二月二日普通の二日酔いだった。 diff --git a/server/connecthand.c b/server/connecthand.c index db3f987..b6072cd 1006

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-10-28 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > Good stuff. There remains only one weird thing that I could find: now when a figher or bomber is made to attack an enemy city or unit via goto, it first tries to go to a closer "safe" tile and only then make the attack approach. For example,

Re: [Freeciv-Dev] [Discussion] Trade routes and special resources

2008-10-28 Thread Madeline Book
On 10/27/08, Yoav Luft <[EMAIL PROTECTED]> wrote: > I decided to add a more complex and interesting trade > system for freeciv. Something much like Civ3 trade system > with special resources that can be trade and are requisite > for building certain buildings. I'm not quite sure how > it should be

[Freeciv-Dev] (PR#40543) Farmland looks like Irrigation in amplio Tileset

2008-10-29 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40543 > > [EMAIL PROTECTED] - Tue Oct 28 18:06:54 2008]: > > I really enjoyed FreeCiv and I like the amplio tileset, but > after a few hours of playing it began to bother me, that > irrigation and farmland looks exactly the same! I edited > the tile

[Freeciv-Dev] (PR#40545) [Patch] Remove old edit menu in player list dialog

2008-10-29 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40545 > The property editor is now used to edit players, so the edit menu in the player dialog can be removed. --- 七日なのに、アイス屋さんが来なかった。凍え死んだかも。 diff --git a/client/gui-gtk-2.0/plrdl

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-10-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > > [pepeto - Wed Oct 29 09:03:33 2008]: > > > [book - Wed Oct 29 01:45:22 2008]: > > > > Good stuff. There remains only one weird thing that I > > could find: now when a figher or bomber is made to > > attack an enemy city or unit via goto,

[Freeciv-Dev] (PR#40546) [Patch] genlist/speclist free cleanup

2008-10-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40546 > Attached patch makes genlist_free free all memory allocated by the list before freeing itself. Also, genlist_unlink_all is renamed to genlist_clear. The rest of the patch is a removal of all the *_unlink_all calls in places of the form fo

[Freeciv-Dev] (PR#40547) [Patch] Virtual tiles and is_virtual check functions

2008-10-31 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40547 > Attached patch adds {create,destroy}_tile_virtual to allow the use of virtual tiles in the same manner as virtual units and cities. It also adds helper functions to check whether a given unit or city is virtual (i.e. is a valid pointer but do

[Freeciv-Dev] (PR#40548) civclient segv

2008-11-03 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40548 > I was just fixing this bug. It is due to the fact that the function update_conn_list_dialog() assumes contiguous player numbers, which is no longer a valid assumption. I'll post the patch soon. --

[Freeciv-Dev] (PR#40549) [Patch] Conn/player stdinhand tweaks

2008-11-03 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40549 > I separated out the stdinhand part of 40534 and added some more fixes for bugs I found during testing: - Sometimes the observe command would not send player info. - The take command would not send player info about the other players whose

[Freeciv-Dev] (PR#40548) [Patch] Cleanup pregame connection list

2008-11-03 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40548 > The attached patch fixes the update_conn_list_dialog() function so that it works without assuming that player numbers are contiguous. Also, the code is greatly cleaned up and the style improved: - Global variables are removed except for the

[Freeciv-Dev] (PR#40543) Farmland looks like Irrigation in amplio Tileset

2008-11-03 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40543 > > [book - Wed Oct 29 18:55:24 2008]: > > Maybe the fields of crops could be made less opaque [...] I meant to say more opaque, that is, less transparent. Sorry for the confusion. ;) -

[Freeciv-Dev] (PR#40550) Turn done active after re-join

2008-11-04 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40550 > > [EMAIL PROTECTED] - Tue Nov 04 17:16:25 2008]: > > I noticed this with 2.1.6 GTK and have not tested it on > previous versions. I have confirmed this bug in S2_1 and trunk. > The thing is: on multiplayer (turn block) game, if a > player

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-05 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > > [pepeto - Wed Nov 05 17:14:11 2008]: > > I hope this version should work very better. This version is the best so far. I did find one strange thing though: take for example a fighter from Arnsberg and make a goto attack on Kranj. The path

[Freeciv-Dev] (PR#40551) [Patch] Fix some more places assuming contiguous player numbers

2008-11-05 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40551 > Attached patch fixes some more places in the code where player numbers were assumed to be in [0, player_count()). --- 虫を食うな! client/gui-gtk-2.0/plrdlg.c |4 ++-- clien

[Freeciv-Dev] (PR#40552) [Patch] Voting code cleanup

2008-11-06 Thread Madeline Book
406 Author: Madeline Book <[EMAIL PROTECTED]> Date: Thu Nov 6 16:02:37 2008 -0500 Voting cleanup. --- server/Makefile.am |4 +- server/sernet.c|1 + server/srv_main.c |4 + server/stdinhand.c | 463 +++-- server/stdinhand

[Freeciv-Dev] (PR#40553) Trunk depends on gtk+ 2.8+

2008-11-07 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40553 > Attached patch replaces the call to gtk_tree_row_reference_get_model by an equivalent expression. --- 暗黒時代にようこそ! diff --git a/client/gui-gtk-2.0/editprop.c b/client/gui-gt

[Freeciv-Dev] (PR#40144) [Patch] Build multiple clients at once

2008-11-07 Thread Madeline Book
eport any breakage due to changes in the configure script or makefiles. If at least the double-compilation problem can be improved, I would consider committing this to trunk. --- 正義のために変身して団結せよ!! commit 582a7b9c10ccb8699d81cf5d1872

[Freeciv-Dev] (PR#40556) Server crash (assertion failure) (v2.1.4)

2008-11-08 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40556 > > [EMAIL PROTECTED] - Sun Nov 09 03:10:54 2008]: > > The server crashes with the following message: > civserver: unithand.c:362: real_unit_change_homecity: Assertion > `!unit_alive || unit_owner(punit) == city_owner(new_pcity)' failed. > > L

[Freeciv-Dev] (PR#12825) freeciv doesn't work on small-resolution displays

2008-11-09 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=12825 > > [guest - Sun Nov 09 12:02:10 2008]: > > This is still an issue. A lot of netbooks have a 1024x600 > resolution on which freeciv is unplayable. Please consider > making the interface work on those screens. Could you be more specific about

[Freeciv-Dev] (PR#40559) [Patch] Fix quotes in take command string used by editor toolbar

2008-11-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40559 > If a player name contained a single quote, the command string sent by the player-point-of-view combobox in the editor toolbar would be wrong and the server would not be able to parse the command correctly. The attached patch changes the take

[Freeciv-Dev] (PR#40560) [Editor] Tile vision property

2008-11-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40560 > Attached patch implements a tile "vision" property for the property editor. This property can be used to view the contents of the player bitvectors ptile->tile_known and ptile->tile_seen[v] (for each vision layer v). This is only really usefu

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-11 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > > [pepeto - Tue Nov 11 13:20:18 2008]: > > I changed completely my initial mind to fix the last strange > behaviour I observed. I rewrote the nearly-whole path_finding.c > file. Ah, the worst case scenario I was afraid of... but seems you m

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > Fighter type units now pass all my tests, however there seems to be a problem with bomber type units. In certain situations the path finding code appears to get into an infinite loop (or take very very long; I left it for several minutes with

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40561 > Attached patch removes some struct fields in struct player and struct tile that were only used by the server for editor related support code. Instead, static data structures are added to edithand.c which keep track of the necessary informatio

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40561 > Forgot to include server/edithand.h in the last patch. --- どこへ行くつもりですか。 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https:/

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-12 Thread Madeline Book
外でただの散歩だけですよ。 commit 7060c10f42c18ed42b1c4292c08bbffad5b8f5e6 Author: Madeline Book <[EMAIL PROTECTED]> Date: Wed Nov 12 20:11:56 2008 -0500 no_server_editor_stuff_in_common_v2.patch --- common/map.c |1 - common/player.h|3 -- common/tile.h |3 -- server/

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-12 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > Hmm perhaps I spoke too soon about fighters in my last reply. Now it sometimes happens that a fighter with 2 or 3 moves left will wait in a city if the user does a goto 1 tile out of the city. It is very odd in that it appears to happen only

[Freeciv-Dev] (PR#40562) [Editor] Some more unit properties

2008-11-13 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40562 > Attached patch implements unit properties 'fuel', 'moved' 'done_moving', 'hp' and 'veteran' for the property editor. --- 洗濯しなければ、あの委員会は来て服を押収するよ。 diff --git a/client/gui-gt

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-14 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > Alright, with the patch in 40563 this new goto code works great, even better than the old warmap code. All I could find is a minor display annoyance in that if a fighter or bomber type unit has only 1 move left, then the "turns to target" la

[Freeciv-Dev] (PR#40565) 0: nation_of_player() has NULL nation

2008-11-15 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40565 > > [pepeto - Sat Nov 15 14:08:13 2008]: > > Every time I reload a savegame with trunk/, I cannot open the > nation page: > > 0: nation_of_player() has NULL nation > 0: Detected fatal error in nation.c line 262: > 0: bad nation Yep, confirme

[Freeciv-Dev] (PR#40566) [Patch] Clean up player list

2008-11-15 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40566 > Was originally for 40565, until I realized it did not solve the problem. ;) Anyway, attached patch greatly simplifies and cleans up some of the player list code. --- ピカピカに

[Freeciv-Dev] (PR#40561) [Editor] Remove server-only editor stuff from common/ files

2008-11-16 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40561 > Version 3 fixes a mistake in edithand_init(). --- 見つけられますか? commit 84e305391f23dbaeafc8c4891e0ededba8ffa364 Author: Madeline Book <[EMAIL PROTECTED]> Date: Sun

[Freeciv-Dev] (PR#40567) [Patch] Some tile helper functions

2008-11-18 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40567 > Some tile helper functions that I needed to add for cleaner virtual tile manipulation: void tile_set_specials(struct tile *ptile, bv_special specials); bv_bases tile_bases(const struct tile *ptile); void tile_set_bases(struct tile *ptile, bv

[Freeciv-Dev] (PR#40568) [Editor] Copy and paste icons

2008-11-18 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40568 > I fashioned two icons representing "copy" and "paste" out of one of pep's (!= pepeto) editor icons. Attached is the new editor.png and a patch to make the icons usable in the code. Also, I originally made a mistake in the spec file (off by 1

Re: [Freeciv-Dev] trunk doesn't compile

2008-11-19 Thread Madeline Book
On 11/19/08, Christian Knoke <[EMAIL PROTECTED]> wrote: > > Aktualisiert zu Revision 15316. > > edithand.c:39:22: error: edithand.h: Datei oder Verzeichnis nicht gefunden Sorry, my mistake. I forgot to add the new file in r15316. It should be there now. :| ---

[Freeciv-Dev] (PR#40571) Detected fatal error in nation.c line 262

2008-11-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40571 > > [chrisk - Wed Nov 19 20:14:53 2008]: > > > with rev. 15317 trunk GTK the attached save game crashes when > I start the game and press F3. This is same as 40565. Patch in that ticket should fix it. --

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40570 > > [EMAIL PROTECTED] - Wed Nov 19 07:45:23 2008]: > > Marine explorers stop if they try to travel to or trhough a marine > tile who's owner is at peace with the unit's owner. > > As a consequence the units are stoped and require player inte

[Freeciv-Dev] (PR#40573) [Editor] Tile bases property

2008-11-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40573 > Attached patch implements a property for viewing and modifying bases on a tile in the property editor. Thus also copy/paste mode is made to work for the base tool. Hence the patch builds on the one in 40569. Incidentally, just for the sake

[Freeciv-Dev] (PR#40529) command "/take -" sends garbage text if it fails

2008-11-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40529 > > [book - Tue Oct 14 02:25:33 2008]: > > If a detached or observer connection does "/take -" when the > game is running and there are no free players to attach to, > instead of an error message the client receives invalid utf8 > causing the

[Freeciv-Dev] (PR#40529) command "/take -" sends garbage text if it fails

2008-11-19 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40529 > > [book - Thu Nov 20 05:31:37 2008]: > > Attached patch fixes the is_allowed_to_take() function > to always set the reason string when it returns FALSE > so that the above sending of an uninitialized string > does not occur. And here's the

[Freeciv-Dev] (PR#40539) Fortress cannot be pillaged

2008-11-20 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40539 > > [EMAIL PROTECTED] - Mon Oct 27 03:13:45 2008]: > > Currently fortress (and likely other bases) cannot be pillaged. > Pillage command is not sensitive when tile has only fortress. > Tested with gtk-client. Here's a minimal fix patch. All t

[Freeciv-Dev] (PR#40574) [Patch] Fix trident fortress being drawn over units

2008-11-20 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40574 > In the trident tiles.spec the fortress image is assinged to the tag fortress_fg. This causes it to be drawn in LAYER_SPECIAL3 which the drawing code assumes is to be drawn over units. Attached patch changes the tag to fortress_bg so that uni

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-20 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40570 > > [EMAIL PROTECTED] - Thu Nov 20 21:19:18 2008]: > > In the attached game the only Columbian unit - if set to auto > explore - tries to violate the peace treaty. Thanks for the savegame. I have confirmed that making the unit auto-explore c

[Freeciv-Dev] (PR#40575) [Editor] Don't apply tool to selection when using shortcut key

2008-11-20 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40575 > In practice I have found the behaviour of simultaneously switching to and applying the new tool to all selected tiles when pressing an editor tool shortcut key (e.g. 't') somewhat annoying. This patch removes that behaviour; the current tool

[Freeciv-Dev] (PR#40429) Bug: [EMAIL PROTECTED] doesn't work

2008-11-23 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40429 > > [dmarks - Sun Nov 23 23:26:03 2008]: > > This is fixed now on server. The current bug report address should be > showing on the RT dashboard and ticket view pages. > > Please verify! Confirmed that logging in as guest shows the correct

[Freeciv-Dev] (PR#40577) [Patch] load_auth_config is too untrusting

2008-11-23 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40577 > Even though load_auth_config() is only ever called with a filename from the server command line, it uses is_safe_filename() to disallow ".." in the path. This makes it rather annoying for testing. Since it is in all likelyhood fine to trust

[Freeciv-Dev] (PR#40578) [Patch] Fix buffer overrun in create_md5sum

2008-11-23 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40578 > The call to sprintf in create_md5sum() writes the terminating '\0' past the end of the supplied output buffer if the buffer has exactly DIGEST_HEX_BYTES bytes. Attached patch makes the original buffer in authdb_check_password() large enough f

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [EMAIL PROTECTED] - Mon Nov 24 18:57:36 2008]: > > From 2.1.7 server: > > Program terminated with signal 11, Segmentation fault. > [New process 14692] > #0 0x004c66b0 in server_player_init () > (gdb) bt full > #0 0x004c

[Freeciv-Dev] (PR#40580) cut command problems

2008-11-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40580 > If a connection cuts itself, there is an error in the server: WARNING: trying to send data to the closed connection and it becomes impossible to use that connection "slot" to reconnect. The client just waits forever at the connect page, pre

[Freeciv-Dev] (PR#40570) [Patch] marine explorers try to violate peace treaties and thus are stoped

2008-11-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40570 > > [EMAIL PROTECTED] - Fri Nov 21 07:07:26 2008]: > > Your no_fights appoach is nice but insufficent. > > 1) it doesn't work for non_allied_unit_tiles that have only allied > units on them I may be mistaken but, do you mean that the explor

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [EMAIL PROTECTED] - Mon Nov 24 23:50:05 2008]: > > 2008/11/24 Madeline Book: > > > > Do you know what you did to get the segfault? > > That core is from public server. > > From logs it seems that se

[Freeciv-Dev] (PR#40581) [RFC] Remove all request_id stuff

2008-11-24 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40581 > I propose that all request_id related code be removed, since it unnecessarily complicates connection handling, causes side-effect bugs and desynchronization between the client and server (due to its state dependence), and generally does not h

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-25 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [dmarks - Tue Nov 25 12:13:00 2008]: > > On Tue, 25 Nov 2008 09:56:59 +0900, Madeline Book > <[EMAIL PROTECTED]> wrote: > > > > > [...] > > > > If no problems are found with the patch I w

[Freeciv-Dev] (PR#40581) [RFC] Remove all request_id stuff

2008-11-25 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40581 > > [EMAIL PROTECTED] - Tue Nov 25 05:40:06 2008]: > > I thought the request_id was intended to associate a packet sent to > the client with the particular request that the client had sent to the > server. > > [...] > > Now at what point does

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-25 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [dmarks - Tue Nov 25 23:41:12 2008]: > > On Wed, 26 Nov 2008 04:53:37 +0900, Madeline Book > <[EMAIL PROTECTED]> wrote: > > > > > http://bugs.freeciv.org/Ticket/Display.html?id=40579 > >

[Freeciv-Dev] (PR#40479) Connection list does not update when command level changes.

2008-11-26 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40479 > > [book - Fri Sep 05 22:13:20 2008]: > > The connection list in the pregame page does not > remove the '*' after a player's name when their > command level changes from 'hack' to something > less. Attached patch adds the required connection

[Freeciv-Dev] (PR#40582) GStreamer audio plugin

2008-11-26 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40582 > > [EMAIL PROTECTED] - Thu Nov 27 00:35:28 2008]: > > Hello all, > > I tried to make a GStreamer audio plugin for Freeciv. It's a work in > progress but it already works well. It's my first contribution so, > please let me know if there are

[Freeciv-Dev] (PR#40580) cut command problems

2008-11-26 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40580 > > [pepeto - Mon Nov 24 22:27:47 2008]: > > > [book - Mon Nov 24 22:05:02 2008]: > > > > If a connection cuts itself, there is an error in the server: > > > > WARNING: trying to send data to the closed connection > > > > and it becomes imp

[Freeciv-Dev] (PR#39613) Left user in client connection list

2008-11-26 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39613 > > [pepeto - Sat Aug 25 15:15:14 2007]: > > When a user which is detached loses connection or leaves, the > client is not informed of it. The connection is still in the > visible connection list. I fixed this bug a long time ago for > warserv

[Freeciv-Dev] (PR#39131) Connection troubles

2008-11-26 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39131 > > [pepeto - Wed Jun 25 11:30:21 2008]: > > It actually occurs when the client connection is broken by the server > whereas the server is reading a packet from. A simple example is when > you attempt to cut yourself from the server. Then, you

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [dmarks - Thu Nov 27 12:58:06 2008]: > > On Wed, 26 Nov 2008 11:34:07 +0900, Madeline Book > <[EMAIL PROTECTED]> wrote: > > > > > http://bugs.freeciv.org/Ticket/Display.html?id=40579 > >

[Freeciv-Dev] (PR#39131) Connection troubles

2008-11-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=39131 > > [pepeto - Thu Nov 27 07:49:11 2008]: > > Unfortunately, this patch wouldn't remove the useless > warning "WARNING: trying to send data to the closed connection". > > It needs also to check after "command_ok = handle_packet_input(pconn, >

[Freeciv-Dev] (PR#40579) server_player_init() crash

2008-11-27 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40579 > > [dmarks - Thu Nov 27 23:25:28 2008]: > > On Fri, 28 Nov 2008 07:33:23 +0900, Madeline Book > <[EMAIL PROTECTED]> wrote: > > > > > http://bugs.freeciv.org/Ticket/Display.html?id=40579 > >

[Freeciv-Dev] (PR#40583) Save files can't be loaded

2008-11-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40583 > > [EMAIL PROTECTED] - Sun Nov 30 21:51:29 2008]: > > While I was playing a freeciv game I noticed that I'm unable > to load the game again. Is this on trunk? I think I have noticed this before too, some save files do not work while others d

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-11-30 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > > [pepeto - Sat Nov 15 13:39:13 2008]: > > Feel free to modify the patch. Alright, finally I have time to get back to this. This time when testing I found that bombers when they have to wait at a tile before doing an attack (i.e. the attac

[Freeciv-Dev] (PR#40536) [Patch] Working air goto

2008-12-01 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40536 > > [pepeto - Mon Dec 01 22:45:49 2008]: > > > [book - Mon Dec 01 22:15:19 2008]: > > > > > [pepeto - Mon Dec 01 07:17:09 2008]: > > > > > > > [book - Mon Dec 01 03:54:35 2008]: > > > > > > > > I also made some minor style changes (but I te

[Freeciv-Dev] (PR#40585) [Patch] aifill in the middle of game loading?

2008-12-02 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40585 > Attached patch makes the aifill call in load_ruleset only activated when it is actually needed, instead of being called all the time in the middle of game loads (etc.) where it stomps all over the server player state. --

[Freeciv-Dev] (PR#40584) A Nation vanishes

2008-12-02 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40584 > > [chrisk - Mon Dec 01 18:55:21 2008]: > > Loading 1894m: Aztec nation missing is game, not listed in > civserver, city of Zinaparo shown but wiped off the map when > I fly along. There were two bugs in the loading code that the attached pa

[Freeciv-Dev] (PR#40586) No fog of war after cancelling alliance

2008-12-03 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40586 > > [chrisk - Wed Dec 03 14:29:56 2008]: > > > rev today trunk+fix-player-loading-patch GTK > > After cancelling an alliance with an ai player, I still > can see into his territory, at least the fog of war is > not shown on the map during th

[Freeciv-Dev] (PR#40588) Bug: Font too small

2008-12-04 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40588 > > [EMAIL PROTECTED] - Thu Dec 04 02:29:24 2008]: > > The font inside of the freeciv Help Browser is unreadable. > Since this might be hard to fix on just one OS, could you > add a plus/minus font size button(s)? There is a font changing int

[Freeciv-Dev] (PR#40590) [Patch] Allow gtk2 gui to select road as pillage target

2008-12-04 Thread Madeline Book
http://bugs.freeciv.org/Ticket/Display.html?id=40590 > If there is more than one pillage target on a tile the gtk2 gui prevents selecting a road as the target. This is because S_ROAD is equal to zero so it becomes NULL when casted to a pointer as a callback userdata argument, which is then ignore

<    1   2   3   4   5   6   7   8   >