Re: [HACKERS] Proposal:Use PGDLLEXPORT for libpq

2016-01-27 Thread Alvaro Herrera
Yury Zhuravlev wrote: > If so many problems with MSVC can discard his support of Postgres? That doesn't sound likely. Keep in mind that users might want to compile extension modules, and not everyone is going to use mingw for that. As far as I know, stuff compiled with MSVC is not compatible wi

Re: [HACKERS] [PATCH] we have added support for box type in SP-GiST index

2016-01-27 Thread Alvaro Herrera
Alexander Lebedev wrote: > Hello, Hacker. > > * [PATCH] add a box index to sp-gist I closed this patch as "returned with feedback" because the author didn't reply in three months. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Trai

Re: [HACKERS] Add numeric_trim(numeric)

2016-01-27 Thread Alvaro Herrera
Marko Tiikkaja wrote: > Hi, > > Here's a patch for the second function suggested in 5643125e.1030...@joh.to. I think this patch got useful feedback but we never saw a followup version posted. I closed it as returned-with-feedback. Feel free to submit a new version for the 2016-03 commitfest. -

Re: [HACKERS] Minor code improvements to create_foreignscan_plan/ExecInitForeignScan

2016-01-28 Thread Alvaro Herrera
Etsuro Fujita wrote: > On 2016/01/28 12:13, Robert Haas wrote: > >I don't think this is a good idea. Most of the time, no system > >columns will be present, and we'll just be scanning the Bitmapset > >twice rather than once. Sure, that doesn't take many extra cycles, > >but if the point of all t

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Alvaro Herrera
Bruce Momjian wrote: > There has been a request in the FOSDEM developers meeting that > committers use a more consistent format for commit messages. Let me point out that the reason this is being put forward is to make sure we have the reviewers listed for each patch, so that we can add a paragrap

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Alvaro Herrera
Magnus Hagander wrote: > They also had tested-by, it might be an idea to include that as well? How about User-Interface-Bikeshedded-By: ? -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hacke

Re: [HACKERS] Weighted Stats

2016-01-28 Thread Alvaro Herrera
I'm closing this for the current commitfest as returned-with-feedback. Please resubmit for the 2016-03 CF once you have it. Thanks! -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mail

Re: [HACKERS] dblink: add polymorphic functions.

2016-01-28 Thread Alvaro Herrera
Joe Conway wrote: > Ok, back to the drawing board. Thanks for the feedback. Closing this one as returned-with-feedback. Please do resubmit for CF 2016-03. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Se

Re: [HACKERS] POC, WIP: OR-clause support for indexes

2016-01-28 Thread Alvaro Herrera
I think this is very exciting stuff, but since you didn't submit an updated patch after David's review, I'm closing it for now as returned-with-feedback. Please submit a new version once you have it. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Suppor

Re: [HACKERS] [PROPOSAL] Improvements of Hunspell dictionaries support

2016-01-28 Thread Alvaro Herrera
Artur Zakirov wrote: > I undo the changes and the error will be raised. I will update the patch > soon. I don't think you ever did this. I'm closing it now, but it sounds useful stuff so please do resubmit for 2016-03. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Dev

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Alvaro Herrera
Robert Haas wrote: > On Thu, Jan 28, 2016 at 6:16 AM, Tomas Vondra > wrote: > >> How about > >> User-Interface-Bikeshedded-By: > >> ? > > > > +1 > > That's sort of implicitly pejorative. Maybe we could find another > way to phrase that, like "Design-suggestions-by" or maybe a more > general "Su

Re: [HACKERS] [PATCH] better systemd integration

2016-01-28 Thread Alvaro Herrera
I wonder if instead of HAVE_SYSTEMD at each callsite we shouldn't instead have a pg_sd_notify() call that's a no-op when not systemd. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mai

Re: [HACKERS] Template for commit messages

2016-01-28 Thread Alvaro Herrera
Stephen Frost wrote: > > OK, but keep in mind whatever script committers user should remove tags > > that are empty after exiting the editor. I can provide the grep regex > > in git somewhere too: > > > > egrep -v > > "^(Author|Reported-by|Bug|Reviewed-by|Tested-by|Backpatch-through): *$" >

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-01-29 Thread Alvaro Herrera
Artur Zakirov wrote: > What status of this patch? In commitfest it is "Needs review". "Needs review" means it needs a reviewer to go over it and, uh, review it. Did I send an email to you prodding you to review patches? I sent such an email to several people from PostgresPro, but I don't rememb

Re: [HACKERS] Sequence Access Method WIP

2016-01-29 Thread Alvaro Herrera
Petr Jelinek wrote: > On 18 January 2016 at 09:19, Craig Ringer wrote: > > Needs rework after the commit of https://commitfest.postgresql.org/8/336/ > > Here is version that applies to current master. There is some work to > do (mostly cleanup) and the DDL is missing, but that's because I want >

Re: [HACKERS] pgbench stats per script & other stuff

2016-01-29 Thread Alvaro Herrera
Fabien COELHO wrote: > The answer is essentially yes, the field is needed for the "aggregated" mode > where this specific behavior is used. OK, thanks, that looks better to me. Can you now appreciate why I asked for split patches? If I had to go over the big patch I probably wouldn't have been

Re: [HACKERS] Fuzzy substring searching with the pg_trgm extension

2016-01-29 Thread Alvaro Herrera
Teodor Sigaev wrote: > >The behavior of this function is surprising to me. > > > >select substring_similarity('dog' , 'hotdogpound') ; > > > > substring_similarity > >-- > > 0.25 > > > Substring search was desined to search similar word in string: > contrib_re

Re: [HACKERS] Sequence Access Method WIP

2016-01-29 Thread Alvaro Herrera
Petr Jelinek wrote: > On 29 January 2016 at 14:48, Tom Lane wrote: > > Alvaro Herrera writes: > > Uh, what? Surely we would provide a bespoke command for each possible > > sort of handler. As an example, CREATE INDEX ACCESS METHOD ought to check > > that the prov

Re: [HACKERS] Template for commit messages

2016-01-29 Thread Alvaro Herrera
Joshua D. Drake wrote: > I think the best question to ask is: > > "What is the problem we are trying to solve?" The problem is alluring more patch reviewers, beta testers and bug reporters. One of the offers is to credit them (I'm not exactly clear on what is the group to benefit from this, but

Re: [HACKERS] Template for commit messages

2016-01-30 Thread Alvaro Herrera
Robert Haas wrote: > On Fri, Jan 29, 2016 at 6:05 PM, Alvaro Herrera > wrote: > > Personally I don't see value in having the commit message follow a > > machine-parseable format; like if you say "Backpatch to" instead of > > "Backpatch-through:" m

Re: [HACKERS] PoC: Partial sort

2016-01-31 Thread Alvaro Herrera
Alexander Korotkov wrote: > I'm sorry that I didn't found time for this yet. I'm certainly planning to > get back to this in near future. The attached version is just rebased > without any optimization. Great to have a new version -- there seems to be a lot of interest in this patch. I'm moving

Re: [HACKERS] New gist vacuum.

2016-01-31 Thread Alvaro Herrera
Костя Кузнецов wrote: > Thank you, Jeff.I reworking patch now. All // warning will be > deleted.About memory consumption new version will control size of > stack and will operate with map of little size because i want delete old > style vacuum(now if maintenance_work_mem less than needed to buil

Re: [HACKERS] PATCH: track last known XLOG segment in control file

2016-01-31 Thread Alvaro Herrera
This hasn't been updated in a long time; I should have closed it earlier. Chatting with Tomas about it, he seemed inclined to just have the patch rejected because it's not terribly useful anyway. I'm marking it as rejected. Unless someone has a compelling use case for this feature that hasn't be

Re: [HACKERS] PATCH: index-only scans with partial indexes

2016-01-31 Thread Alvaro Herrera
Tomas Vondra wrote: > On 12/24/2015 04:05 AM, Michael Paquier wrote: > >Tomas, are you still working on that? This thread is stalling for 3 weeks. > > I haven't discovered anything interesting during the testing, so I guess the > "needs review" state is appropriate. Let's move the patch to the n

Re: [HACKERS] PATCH: use foreign keys to improve join estimates v1

2016-01-31 Thread Alvaro Herrera
David Rowley wrote: > I'm not sure that I agree with this being set to "Needs review". The last > progress that I see made on this was me hacking at the patch to remove some > equivalence class limitations. I think the logical next step would be for > you to look at these changes and either accep

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-01-31 Thread Alvaro Herrera
Ashutosh Bapat wrote: > Here's updated patch. I didn't use version numbers in file names in my > previous patches. I am starting from this onwards. Um, I tried this patch and it doesn't apply at all. There's a large number of conflicts. Please update it and resubmit to the next commitfest. --

Re: [HACKERS] PostgreSQL Audit Extension

2016-01-31 Thread Alvaro Herrera
David Steele wrote: > The attached patch implements audit logging for PostgreSQL as an > extension. I believe I have addressed the concerns that were raised at > the end of the 9.5 development cycle. This patch got no feedback at all during the commitfest. I think there is some interest on audit

Re: [HACKERS] On columnar storage (2)

2016-01-31 Thread Alvaro Herrera
So we discussed some of this stuff during the developer meeting in Brussels and the main conclusion is that we're going to split this up in multiple independently useful pieces, and write up the general roadmap in the wiki so that we can discuss in detail on-list. I'm marking this as Returned with

Re: [HACKERS] PATCH: index-only scans with partial indexes

2016-01-31 Thread Alvaro Herrera
Konstantin Knizhnik wrote: > I am very interested in this patch because it allows to use partial indexes > to ... speed up inserts. > I have implemented "ALTER INDEX ... WHERE ..." construction which allows to > change predicate of partial index without necessity to fully rebuild it. > So it is n

Re: [HACKERS] PostgreSQL Audit Extension

2016-01-31 Thread Alvaro Herrera
Joshua D. Drake wrote: > On 01/31/2016 05:07 AM, Alvaro Herrera wrote: > >David Steele wrote: > >>The attached patch implements audit logging for PostgreSQL as an > >>extension. I believe I have addressed the concerns that were raised at > >>the end of the 9.5

Re: [HACKERS] Template for commit messages

2016-01-31 Thread Alvaro Herrera
Joshua D. Drake wrote: > On 01/29/2016 03:05 PM, Alvaro Herrera wrote: > >Joshua D. Drake wrote: > > > >>I think the best question to ask is: > >> > >>"What is the problem we are trying to solve?" > > > >The problem is alluring mor

Re: [HACKERS] Template for commit messages

2016-02-01 Thread Alvaro Herrera
Joshua D. Drake wrote: > On 01/31/2016 04:34 PM, Michael Paquier wrote: > >This page would need a refresh IMO. I think it has not been touched > >for the last couple of years. > > No doubt but if we can't bother to keep that refreshed what makes us think > that a structured format in commit messa

Re: [HACKERS] How can I build OSSP UUID support on Windows to avoid duplicate UUIDs?

2016-02-01 Thread Alvaro Herrera
高增琦 wrote: > : ( > > still don't know how to build ossp-uuid on windows with MSVC. > Saito san's patch doesn't fix all errors during compiling... I don't understand why you want to build that specific module on Windows. Doesn't Windows have its own UUID generator that you can access, using a smal

Re: [HACKERS] Template for commit messages

2016-02-01 Thread Alvaro Herrera
Andres Freund wrote: > On 2016-02-01 12:56:21 +0100, Magnus Hagander wrote: > > Let's just assume that we can fix that part. As in, we can expose either an > > internal db id or a short hash or something, from the archives server. We > > could then have that visible/linkable directly on the archive

Re: [HACKERS] Transactions involving multiple postgres foreign servers

2016-02-01 Thread Alvaro Herrera
Alvaro Herrera wrote: > Ashutosh Bapat wrote: > > > Here's updated patch. I didn't use version numbers in file names in my > > previous patches. I am starting from this onwards. > > Um, I tried this patch and it doesn't apply at all. There's a large

Re: [HACKERS] silent data loss with ext4 / all current versions

2016-02-01 Thread Alvaro Herrera
Michael Paquier wrote: > On Mon, Jan 25, 2016 at 6:50 PM, Tomas Vondra > wrote: > > Seems OK to me. Thanks for the time and improvements! > > Thanks. Perhaps a committer could have a look then? I have switched > the patch as such in the CF app. Seeing the accumulated feedback > upthread that's so

Re: [HACKERS] PostgreSQL Audit Extension

2016-02-01 Thread Alvaro Herrera
David Steele wrote: > On 1/31/16 8:07 AM, Alvaro Herrera wrote: > > I'm giving > > this patch some more time by moving it to next commitfest instead. > > I was under the mistaken impression that the CF was two months long so I > appreciate getting a little more tim

Re: [HACKERS] WIP: Access method extendability

2016-02-01 Thread Alvaro Herrera
Alexander Korotkov wrote: > Hi! > > Patches was rebased against master. > > In the attached version of patch access methods get support of pg_dump. Thanks. This patch came in just as the commitfest was ending, so I'm moving it to the next one. -- Álvaro Herrerahttp://www.2ndQu

Re: [HACKERS] Spurious standby query cancellations

2016-02-01 Thread Alvaro Herrera
Simon Riggs wrote: > This looks good to me, apart from some WhitespaceCrime. > > Header split applied, will test and apply the main patch this week. Since the patch already appears to have a committer's attention, it's okay to move it to the next commitfest; if Simon happens to commit ahead of t

Re: [HACKERS] Move PinBuffer and UnpinBuffer to atomics

2016-02-01 Thread Alvaro Herrera
Alexander Korotkov wrote: > Attached patch is rebased and have better comments. > Also, there is one comment which survive since original version by Andres. > > /* Add exponential backoff? Should seldomly be contended tho. */ > > > Andres, did you mean we should twice the delay with each unsucc

Re: [HACKERS] pg_hba_lookup function to get all matching pg_hba.conf entries

2016-02-01 Thread Alvaro Herrera
Haribabu Kommi wrote: > Hi, Do you have any further comments on the patch that needs to be > taken care? I do. I think the jsonb functions you added should be added to one of the json .c files instead, since they seem of general applicability. But actually, I don't think you have ever replied to

Re: [HACKERS] [POC] FETCH limited by bytes.

2016-02-01 Thread Alvaro Herrera
Corey Huinker wrote: > Enjoy. Didn't actually look into the patch but looks like there's progress here and this might be heading for commit. Moving to next one. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Patch: Implement failover on libpq connect level.

2016-02-01 Thread Alvaro Herrera
Victor Wagner wrote: > On Fri, 22 Jan 2016 16:36:15 -0300 > Alvaro Herrera wrote: > > > You're editing the expected file for the libpq-regress thingy, but you > > haven't added any new lines to test the new capability. I think it'd > > be good to add so

Re: [HACKERS] snapshot too old, configured by time

2016-02-01 Thread Alvaro Herrera
Kevin Grittner wrote: > > There has been a review but no replies for more than 1 month. Returned > > with feedback? > > I do intend to post another version of the patch to tweak the > calculations again, after I can get a patch in to expand the > testing capabilities to allow an acceptable way to

Re: [HACKERS] [PROPOSAL] Client Log Output Filtering

2016-02-01 Thread Alvaro Herrera
David Steele wrote: > On 1/11/16 6:50 PM, Alvaro Herrera wrote: > >David Steele wrote: > >>The patch creates a new counter to separate the log filtering from the > >>authentication functionality. This makes it possible to get the same > >>filtering in ot

Re: [HACKERS] checkpointer continuous flushing

2016-02-01 Thread Alvaro Herrera
This patch got its fair share of reviewer attention this commitfest. Moving to the next one. Andres, if you want to commit ahead of time you're of course encouraged to do so. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training &

Re: [HACKERS] proposal: add 'waiting for replication' to pg_stat_activity.state

2016-02-01 Thread Alvaro Herrera
Thomas Munro wrote: > Thinking of other patches in flight, I think I'd want the proposed > N-sync standbys feature to be able to explain in more detail what it's > waiting for (and likewise my causal reads proposal which does that via > the process title), though I realise that the details of how/

Re: [HACKERS] Removing Functionally Dependent GROUP BY Columns

2016-02-01 Thread Alvaro Herrera
This patch got a good share of review, so it's fair to move it to the next commitfest. I marked it as ready-for-committer there which seems to be the right status. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services

Re: [HACKERS] Freeze avoidance of very large table.

2016-02-01 Thread Alvaro Herrera
Masahiko Sawada wrote: > Attached updated version patch. > Please review it. In pg_upgrade, the "page convert" functionality is there to abstract rewrites of pages being copied; your patch is circumventing it and AFAICS it makes the interface more complicated for no good reason. I think the real

Re: [HACKERS] Add links to commit fests to patch summary page

2016-02-01 Thread Alvaro Herrera
Jim Nasby wrote: > It would be nice if the patch summary page (ie, [1]) had links to the > relevant entry in that CF. The specific need I see is if you look up a patch > in the current CF and it's been moved to the next CF you have to manually go > to that CF and search for the patch. Agreed, I co

Re: [HACKERS] Freeze avoidance of very large table.

2016-02-02 Thread Alvaro Herrera
Masahiko Sawada wrote: > I misunderstood. Sorry for noise. > I agree with adding conversion method as a pageConverter routine. \o/ > This patch doesn't change page layout actually, but pageConverter > routine checks only the page layout. > And we have to plugin named convertLayout_X_to_Y. > > I

Re: [HACKERS] get current log file

2016-02-02 Thread Alvaro Herrera
Armor wrote: > Hello, > > > I find there is a new feature about getting current log file name on the > TODO list (for detail please check > http://www.postgresql.org/message-id/pine.gso.4.64.0811101325260.9...@westnet.com). > On the other side, we finish a ticket to this requirement for ou

Re: [HACKERS] [PATCH] Phrase search ported to 9.6

2016-02-02 Thread Alvaro Herrera
Andreas Joseph Krogh wrote:   > Which seems to indicate it has received a fair amount of testing and is quite > stable. > Hopefully it integrates into the 9.6 codebase without too much risk. Yes, yes, that's all very good, but we're nearing the closure of the 9.6 development cycle and we only ha

Re: [HACKERS] Way to check whether a particular block is on the shared_buffer?

2016-02-02 Thread Alvaro Herrera
Kouhei Kaigai wrote: > > On 1/31/16 7:38 PM, Kouhei Kaigai wrote: > > To answer your direct question, I'm no expert, but I haven't seen any > > functions that do exactly what you want. You'd have to pull relevant > > bits from ReadBuffer_*. Or maybe a better method would just be to call > > BufTab

Re: [HACKERS] Add links to commit fests to patch summary page

2016-02-02 Thread Alvaro Herrera
Magnus Hagander wrote: > On Tue, Feb 2, 2016 at 2:46 AM, Jim Nasby wrote: > > > On 2/1/16 6:15 PM, Alvaro Herrera wrote: > > > >> Jim Nasby wrote: > >> > >>> It would be nice if the patch summary page (ie, [1]) had links to the > >>>

Re: [HACKERS]WIP: Covering + unique indexes.

2016-02-02 Thread Alvaro Herrera
Anastasia Lubennikova wrote: > I just write here to say that I do not disappear and I do remember about the > issue. > But I'm very very busy this week. I'll send an updated patch next week as > soon as possible. That's great to know, thanks. I moved your patch to the next commitfest. Please do

Re: [HACKERS] Freeze avoidance of very large table.

2016-02-02 Thread Alvaro Herrera
This patch has gotten its fair share of feedback in this fest. I moved it to the next commitfest. Please do keep working on it and reviewers that have additional comments are welcome. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA,

Re: [HACKERS] [PATCH] Refactoring of LWLock tranches

2016-02-02 Thread Alvaro Herrera
Robert Haas wrote: > Overall, I think this is on the right track, but it still needs some > work to make it cleaner. We've committed a large number of patches in this item this cycle. I think it's fair to mark it as Committed. Can somebody submit a new one to the next commitfest? -- Álvaro He

Re: [HACKERS] Add links to commit fests to patch summary page

2016-02-02 Thread Alvaro Herrera
Magnus Hagander wrote: > So from https://commitfest.postgresql.org/9/353/, you'd want links to > /8/353/, /7/353/, /6/353/? Right. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mail

Re: [HACKERS] Relation extension scalability

2016-02-02 Thread Alvaro Herrera
Andres Freund wrote: > Could you also measure how this behaves for [...] While we're proposing benchmark cases -- I remember this being an issue with toast tables getting very large values of xml which causes multiple toast pages to be extended for each new value inserted. If there are multiple

Re: [HACKERS] Minor code improvements to create_foreignscan_plan/ExecInitForeignScan

2016-02-02 Thread Alvaro Herrera
Etsuro Fujita wrote: > Done. Attached is an updated version of the patch. Pushed, thanks. I kinda wonder why this struct member has a name that doesn't match the naming convention in the rest of the struct, and also why isn't it documented in the comment above the struct definition. But that's

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-02-02 Thread Alvaro Herrera
Robert Haas wrote: > The eventual committer is likely to be much happier with this patch if > you guys have achieved consensus among yourselves on the best > approach. > > (Disclaimer: The eventual committer won't be me. I'm not a Python > guy. But we try to proceed by consensus rather than com

Re: [HACKERS] Add links to commit fests to patch summary page

2016-02-02 Thread Alvaro Herrera
Magnus Hagander wrote: > On Tue, Feb 2, 2016 at 4:43 PM, Alvaro Herrera > wrote: > > > Magnus Hagander wrote: > > > > > So from https://commitfest.postgresql.org/9/353/, you'd want links to > > > /8/353/, /7/353/, /6/353/? > > > > Right. &

Re: [HACKERS] 2016-01 Commitfest

2016-02-03 Thread Alvaro Herrera
Hi, Status summary: Needs review: 7. Ready for Committer: 11. Committed: 28. Moved to next CF: 23. Rejected: 2. Returned with Feedback: 28. Total: 99. I just closed a large number of patches in the 2006-01 commitfest as "returned with feedback". The vast majority of those were in "waiting

Re: [HACKERS] Idle In Transaction Session Timeout, revived

2016-02-04 Thread Alvaro Herrera
David Steele wrote: > > <...> But what I think really happens is > > some badly-written Java application loses track of a connection > > someplace and just never finds it again. <...> I've seen that also, plenty of times. > That's what I've seen over and over again. And then sometimes it's not

Re: [HACKERS] UNIQUE capability to hash indexes

2016-02-04 Thread Alvaro Herrera
Tom Lane wrote: > Shubham Barai writes: > > I wanted to know if anyone is working on these projects from todo list. > > 1.Add UNIQUE capability to hash indexes > > 2.Allow multi-column hash indexes > > Not that I've heard of. It's very hard to muster any enthusiasm for > improving hash indexes u

Re: [HACKERS] Development with Eclipse - Wrong error messages in IDE

2016-02-04 Thread Alvaro Herrera
Peter Moser wrote: > I have some strange error message inside Eclipse, that some symbols cannot > be found. I work with version 9.6 currently. For instance, > > Symbol 'RM_HEAP_ID' could not be resolved > src/backend/access/heap/heapam.c > > It affects all occurrences of symbols that are defined

Re: [HACKERS] "using previous checkpoint record at" maybe not the greatest idea?

2016-02-04 Thread Alvaro Herrera
David G. Johnston wrote: > ​Learning by reading here... > > http://www.postgresql.org/docs/current/static/wal-internals.html > """ > ​After a checkpoint has been made and the log flushed, the checkpoint's > position is saved in the file pg_control. Therefore, at the start of > recovery, the serve

Re: [HACKERS] insufficient qualification of some objects in dump files

2016-02-04 Thread Alvaro Herrera
Peter Eisentraut wrote: > Some dump objects whose names are not unique on a schema level have > insufficient details in the dump TOC. For example, a column default > might have a TOC entry like this: > > 2153; 2604 39696 DEFAULT public a rolename > I think we should amend the archive tag for the

Re: [HACKERS] proposal: PL/Pythonu - function ereport

2016-02-08 Thread Alvaro Herrera
I don't think we need to preserve absolutely all the existing behavior to the letter. We do need to preserve the behavior for sensible cases that people might be reasonably be using currently; and if there's anything somewhat obscure but really useful that you currently get by using some clever tr

Re: [HACKERS] extend pgbench expressions with functions

2016-02-08 Thread Alvaro Herrera
Fabien COELHO wrote: > > Hello Michaël, > > v23 attached, which does not change the message but does the other fixes. This doesn't apply anymore -- please rebase and submit to the next CF. I closed it here as returned with feedback. Thanks! -- Álvaro Herrerahttp://www.2ndQuadr

Re: [HACKERS] pgbench stats per script & other stuff

2016-02-08 Thread Alvaro Herrera
I closed this one as "committed", since we pushed a bunch of parts. Please submit the two remaining ones to the next commitfest. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing

Re: [HACKERS] [PROPOSAL] VACUUM Progress Checker.

2016-02-08 Thread Alvaro Herrera
Since things are clearly still moving here, I closed it as returned-with-feedback. Please submit to the next CF so that we don't lose it. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hacker

Re: [HACKERS] Patch: fix lock contention for HASHHDR.mutex

2016-02-08 Thread Alvaro Herrera
I've closed this as returned-with-feedback. Please resubmit once you have found answers to the questions posed; from the submitted benchmark numbers this looks very exciting, but it needs a bit more work. You don't necessarily have to agree with everything Robert says, but you need to have well r

Re: [HACKERS] remove wal_level archive

2016-02-08 Thread Alvaro Herrera
Peter Eisentraut wrote: > On 1/26/16 10:56 AM, Simon Riggs wrote: > > Removing one of "archive" or "hot standby" will just cause confusion and > > breakage, so neither is a good choice for removal. > > > > What we should do is > > 1. Map "archive" and "hot_standby" to one level with a new name th

Re: [HACKERS] Multi-tenancy with RLS

2016-02-08 Thread Alvaro Herrera
I've closed this as returned-with-feedback. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To make changes to your subscription: http://www.

Re: [HACKERS] WIP: bloom filter in Hash Joins with batches

2016-02-08 Thread Alvaro Herrera
I'm closing this as returned-with-feedback; AFAICS even the last version submitted is still in research stage. Please resubmit once you make further progress. Thanks, -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Servic

Re: [HACKERS] extend pgbench expressions with functions

2016-02-08 Thread Alvaro Herrera
Fabien COELHO wrote: > > Hello, > > >>v23 attached, which does not change the message but does the other fixes. > > > >This doesn't apply anymore > > Indeed, but the latest version was really v25. > > >-- please rebase and submit to the next CF. > > I already provided it as v25 on Feb 1st. >

Re: [HACKERS] a raft of parallelism-related bug fixes

2016-02-08 Thread Alvaro Herrera
Robert Haas wrote: > Oh: another thing that I would like to do is commit the isolation > tests I wrote for the deadlock detector a while back, which nobody has > reviewed either, though Tom and Alvaro seemed reasonably positive > about the concept. Right now, the deadlock.c part of this patch isn

Re: [HACKERS] Tracing down buildfarm "postmaster does not shut down" failures

2016-02-08 Thread Alvaro Herrera
Tom Lane wrote: > Of late, by far the majority of the random-noise failures we see in the > buildfarm have come from failure to shut down the postmaster in a > reasonable timeframe. I noticed that. > An example is this current failure on hornet: > > http://buildfarm.postgresql.org/cgi-bin/show_s

Re: [HACKERS] Proposal: SET ROLE hook

2016-02-08 Thread Alvaro Herrera
Joe Conway wrote: > On 01/06/2016 10:36 AM, Tom Lane wrote: > > I think a design that was actually somewhat robust would require two > > hooks, one at check_role and one at assign_role, wherein the first one > > would do any potentially-failing work and package all required info into > > a blob tha

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-02-08 Thread Alvaro Herrera
Daniel Verite wrote: > Teodor Sigaev wrote: > > > Interesting feature, but it's not very obvious how to use it. I'd like to > > see some example(s) in documentation. > > I'm thinking of making a wiki page, because examples pretty much > require showing resultsets, and I'm not sure this wou

Re: [HACKERS] proposal: function parse_ident

2016-02-08 Thread Alvaro Herrera
Pavel Stehule wrote: > I am looking on it Thanks, closing as returned-with-feedback. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services -- Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org) To mak

Re: [HACKERS] 2016-01 Commitfest

2016-02-08 Thread Alvaro Herrera
Hi everybody, I just closed the last few remaining items in the commitfest. This is the final summary: Committed: 32. Moved to next CF: 32. Rejected: 2. Returned with Feedback: 33. Total: 99. I think we did a fairly decent job this time around: we only passed a third of the patches to the

Re: [HACKERS] [patch] Proposal for \crosstabview in psql

2016-02-08 Thread Alvaro Herrera
Pavel Stehule wrote: > > FWIW I think the general idea of this feature (client-side resultset > > "pivoting") is a good one, but I don't really have an opinion regarding > > your specific proposal. I think you should first seek some more > > consensus about the proposed design; in your original t

Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Alvaro Herrera
844887e170471f223ba100b3c17571 > Author: Alvaro Herrera > Date: Wed Jan 27 02:54:22 2016 +0100 > > pgbench: improve multi-script support > > > I wasn't able to figure out which email thread corresponds to this commit. Thanks for the report, will fix. -- Álvaro Herre

Re: [HACKERS] Seg fault in pgbench

2016-02-12 Thread Alvaro Herrera
Jeff Janes wrote: > If I give pgbench an empty file, I get a segfault. > > $ touch empty.sql > $ src/bin/pgbench/pgbench -T 60 -f empty.sql > starting vacuum...end. > Segmentation fault (core dumped) I fixed this by checking whether the first command is NULL; originally this case was handled by c

[HACKERS] innocuous: pgbench does FD_ISSET on invalid socket

2016-02-12 Thread Alvaro Herrera
I noticed that pgbench calls FD_ISSET on a socket returned by PQsocket() without first checking that it's not invalid. I don't think there's a real problem here because the socket was already checked a few lines above, but I think applying the same coding pattern to both places is cleaner. Any ob

Re: [HACKERS] Re: Reusing abbreviated keys during second pass of ordered [set] aggregates

2016-02-15 Thread Alvaro Herrera
Peter Geoghegan wrote: > Michael (the CF manager at the time) remembered to change the status > to "Ready for Committer" again; you see this entry immediately > afterwards: > > "New status: Ready for Committer" > > but I gather from the CF app history that Alvaro (the current CF > manager) did n

Re: [HACKERS] innocuous: pgbench does FD_ISSET on invalid socket

2016-02-15 Thread Alvaro Herrera
I noticed that strerror(errno) wasn't the most helpful error context ever, so I changed it to PQerrorMessage(). There may be room for additional improvement there. I also noticed that if one connection dies, we terminate the whole thread, and if the thread is serving multiple connections, the oth

Re: [HACKERS] [WIP] ALTER ... OWNER TO ... CASCADE

2016-02-16 Thread Alvaro Herrera
Vladimir Borodin wrote: > > Moreover, the use case you've sketched (ie, change ownership of all > > objects inside a database) doesn't actually have anything to do with > > following dependencies. It's a lot closer to REASSIGN OWNED ... in > > fact, it's not clear to me why REASSIGN OWNED doesn't

Re: [HACKERS] Small PATCH: check of 2 Perl modules

2016-02-16 Thread Alvaro Herrera
Victor Wagner wrote: > Not everyone have "standard perl installation" nowadays. Most Linux > users, for example, use Perl package from the distrubution, and > distributions love to strip down standard perl installation putting its > parts into separate packages, some of which might be optional. >

Re: [HACKERS] Freeze avoidance of very large table.

2016-02-16 Thread Alvaro Herrera
Masahiko Sawada wrote: > On Wed, Feb 17, 2016 at 12:02 AM, Bruce Momjian wrote: > > On Tue, Feb 16, 2016 at 11:56:25PM +0900, Masahiko Sawada wrote: > >> > I agreed on ripping out the converter plugin ability of pg_upgrade. > >> > Remember pg_upgrade was originally written by EnterpriseDB staff, a

Re: [HACKERS] auto_explain sample rate

2016-02-16 Thread Alvaro Herrera
Julien Rouhaud wrote: Hijacking this macro is just too obscure: > #define auto_explain_enabled() \ > (auto_explain_log_min_duration >= 0 && \ > - (nesting_level == 0 || auto_explain_log_nested_statements)) > + (nesting_level == 0 || auto_explain_log_nested_statements) && \ > +

Re: [HACKERS] Fix handling of invalid sockets returned by PQsocket()

2016-02-17 Thread Alvaro Herrera
Michael Paquier wrote: > Hi all, > > After looking at Alvaro's message mentioning the handling of > PQsocket() for invalid sockets, I just had a look by curiosity at > other calls of this routine, and found a couple of issues: > 1) In vacuumdb.c, init_slot() does not check for the return value of

Re: [HACKERS] pglogical - logical replication contrib module

2016-02-17 Thread Alvaro Herrera
Craig Ringer wrote: > Improving this probably needs DDL deparse to be smarter. Rather than just > emitting something that can be reconstructed into the SQL text of the DDL > it needs to emit one or more steps that are semantically the same but allow > us to skip the rewrite. Along the lines of: >

Re: [HACKERS] Figures in docs

2016-02-17 Thread Alvaro Herrera
Gavin Flower wrote: > On 18/02/16 10:38, Peter Eisentraut wrote: > >On 2/16/16 8:17 PM, Tatsuo Ishii wrote: > >>It seems there's no figures/diagrams in our docs. I vaguely recall that > >>we used to have a few diagrams in our docs. If so, was there any > >>technical reason to remove them? > >Becaus

Re: [HACKERS] Restructuring Paths to allow per-Path targetlist info

2016-02-19 Thread Alvaro Herrera
Tom Lane wrote: > So, the attached patch just bites the bullet and adds explicit output > tlist information to struct Path. I did set things up so that the cost > is only one pointer in each Path in the typical case where Paths emit > the set of Vars needed from their relation; in that case, they

Re: [HACKERS] PostgreSQL Audit Extension

2016-02-19 Thread Alvaro Herrera
Bruce Momjian wrote: > Understood. My point is that there is a short list of read events, and > many DDL events. We have already hesitated to record DDL changes for > logical replication because of the code size, maintenance overhead, and > testing required. DDL is already captured using the ev

Re: [HACKERS] about google summer of code 2016

2016-02-19 Thread Alvaro Herrera
Atri Sharma wrote: > I agree, there might be scope for non core projects and PL/Java sounds like > a good area. We've hosted MADlib-based projects in the past, so why not. -- Álvaro Herrerahttp://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Remote DBA, Training & S

<    1   2   3   4   5   6   7   8   9   10   >