Re: Can't add repository on development installation

2009-12-14 Thread Ryan Oblak
Yes, this is for the 1.1 development series. It's the HEAD from github. I tried running ./reviewboard/manage.py registerscmtools, but was met with this error: Unable to load SCMTool svn = reviewboard.scmtools.svn:SVNTool: (Djblets 0.5.6.dev (/home/rroblak/workspace/djblets), Requirement.parse

How to make forcing pre-commit review

2009-12-14 Thread JohnHenry
Hi,all, It seems that the ReviewBoard help Review code with a Human positive process, But somtimes a programmer may lazy to make code review process and commit his code directly. So is there any way to force all RB users in a ReviewGroup to make pre-commit review? say, If somebody write new

Re: How to make forcing pre-commit review

2009-12-14 Thread Scott Quesnelle
With CVS you can write pre-commit scripts. In our repository, we are required to input a valid defect ID as the first item in the commit log. CVS looks up that defect ID and checks for the results of a review request. Alternatively, you could require the developers to include the review id in the

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-14 Thread Christian Hammond
Which version of Review Board is this running right now? I've seen this recently on the 1.1 alpha nightlies. Also, what repository type is this? It could indicate a missing dependency. The error checking/reporting for that on 1.0.x is pretty bad, but improved in 1.1. Is this only happening to

Re: ReviewBoard using with WebUI, diff file is not recogonized.

2009-12-14 Thread Christian Hammond
You'll need cvs diff -uN. It's best just to use post-review though. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sun, Dec 13, 2009 at 7:18 PM, JohnHenry qhlonl...@163.com wrote: Hi, all, I tried

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread Christian Hammond
Hi, You will need cvs on the server, definitely. The 1.1 alpha series won't let you create a CVS repository without having it. You'll also need it on the client running post-review. The base path should be None in this case. It's really only needed for Subversion. Can you show me the Repository

Re: One or more fields had errors: fields: 'path': 'This field is required.'

2009-12-14 Thread Christian Hammond
It should just be the field constraints from those FileFields. We don't do any custom validation checks in those forms that I can see. It could potentially fail if the diff itself is empty, even though the name is populated. Are they uploading using post-review? Might be worth seeing what

Re: Installation problem

2009-12-14 Thread nshenry03
I am getting the same issue: r...@scubuntuvm1:~# python --version Python 2.5.2 r...@scubuntuvm1:~# lsb_release -a No LSB modules are available. Distributor ID: Ubuntu Description:Ubuntu 8.04.3 LTS Release:8.04 Codename: hardy r...@scubuntuvm1:~# uname -r 2.6.24-23-generic On

Re: Installation problem

2009-12-14 Thread Christian Hammond
From a python prompt, type: import PIL If that fails, then PIL is not installed on the system. If it does work, then we need to investigate why your Python isn't seeing it. I assume you've done a web server restart since installing Review Board? Christian -- Christian Hammond -

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
OK, I am using ReviewBoardV1.05 My Repository setting on Administrator UI is as follows: Name: NewProductCode Path: :perver:jo...@192.168.3.151:/export/home/ cvsroot Mirror Path: /cvs_gz/export/home/cvsroot Repository Type: CVS

Re: ReviewBoard using with WebUI, diff file is not recogonized.

2009-12-14 Thread JohnHenry
Thanks for reply, It works now. Best Regards! On Dec 15, 5:29 am, Christian Hammond chip...@chipx86.com wrote: You'll need cvs diff -uN. It's best just to use post-review though. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc.

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
With your help, I can use WebUI pre-commit review now. But why the post-review can't find Base Path of repository? Regards! On Dec 15, 5:35 am, Christian Hammond chip...@chipx86.com wrote: Hi,... read more You will need cvs on the server, definitely. The 1.1 alpha series won't let you

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
Another problem is When I am using CVS repository, the debug info report is : svn info On Dec 15, 5:35 am, Christian Hammond chip...@chipx86.com wrote: Hi,... read more You will need cvs on the server, definitely. The 1.1 alpha series won't let you create a CVS repository without having

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
Hi, Christian, I have changed the source of Postreview.py, and now the post- review can work fine. I found that in class CVSClient, the function get_repository_info, It use socket.getfqdn(host) to replace the host of repository_path; So I managed to keep the repository_path unchanged. Though

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread Christian Hammond
The getfqdn call essentially gets the fully-qualified domain (so, foo.example.com instead of just foo, for instance). We recently added support for Perforce to check against all aliases, including what's reported locally. We should add this for CVS as well. I don't really know what you mean by

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
Hi, Christian, Thanks for replay. I said rebuild because I am using the directly installed ReviewBoard, I don't know it's compiling form souce process. If I want to change some python source code of ReviewBoard, Then how to compile the ReviewBoard again, and do I need to reinstall the compile

Re: About the relationship between ReviewBoard Server and CVS

2009-12-14 Thread JohnHenry
Oh, I see. Thank you very much! Best Regards! On 12月15日, 下午2时13分, Christian Hammond chip...@chipx86.com wrote: Review Board is in Python, and doesn't actually need to be compiled. However, to do any real development (with the expectation of contributing back to the project) you'll need to

About Error occured when print view diff on User WebUI of ReviewBoard

2009-12-14 Thread JohnHenry
Hi, I have tried to post a review request and publish it using one User, But in the Reviewers' UI, when He cilck the view diff link on the top-right, There will be some error infomation: ** The patch to 'mySouceTest.c' didn't apply cleanly. The