[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Update of patch #2715 (project freeciv): Status: Ready For Test => Done Open/Closed:Open => Closed ___ Reply to this item at:

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Update of patch #2715 (project freeciv): Status: In Progress => Ready For Test ___ Follow-up Comment #59: - Removed parts handled in bug #18952 - fixed compilation errors and warnings when building a

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #58, patch #2715 (project freeciv): Please read through CodingStyle document, and check "final" versions of your patches, so I don't need to spend hours fixing simple style issues and obvious oversights with your future patches. - CodingStyle corrections - Renamed some variable

Re: [Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

On Mon, 2011-11-07 at 17:53 +0100, anonymous wrote: > Follow-up Comment #50, patch #2715 (project freeciv): > > After a bit checking, I came up with that better solution - if client can > change view, overview is invalidated on mapview scroll change. > > Implemented in this version. > > But I've

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #57, patch #2715 (project freeciv): Actually, I misspoke - there seem to be one more change that could be implemented, affected by this patch, though not strictly cairo related. It's just an idea, as I have yet to try to implement it, but it seems that both chatline and option

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #56, patch #2715 (project freeciv): This version should be more or less final as far as gtk2 goes - for gtk3 there's obviously much more on schedule (still, much of it already works there too). As for patch #3029, I've got mixed feelings - that way would be more consistent *acr

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #55, patch #2715 (project freeciv): Perhaps I'm not being explicit enough: "deselect" as in "after I select a unit, what do I need to do to have no unit selected (short of disbanding the unit or ending the turn)". ___ Rep

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #54, patch #2715 (project freeciv): > The question: how do I deselect a unit without canceling its orders ? If i remember correctly, you should be able to hit the space bar. This will go on to the next unit but not cancel what it is doing.

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #53, patch #2715 (project freeciv): > The other way around is also a no go, as there's no > release_overview_window counterpart of get_overview_window. Don't know if you are still interested with new developments you've done, but I had moment earlier today to write patch #3029

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #52, patch #2715 (project freeciv): Well, the problem is that menu is active only if a unit is selected, otherwise whole menu is inaccessible - that was the reason behind the request. I'm a bit surprised, that the question didn't have a trivial answer.

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #51, patch #2715 (project freeciv): > The question: how do I deselect a unit without canceling its > orders ? I do not know - as long as you have units which could be moved the next one is selected. > The request: it would be nice, if the option of activating unit > selection

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #50, patch #2715 (project freeciv): After a bit checking, I came up with that better solution - if client can change view, overview is invalidated on mapview scroll change. Implemented in this version. But I've got a silly question and a request. The question: how do I desele

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #49, patch #2715 (project freeciv): OK, I was wrong again - this version doesn't leak overview canvas. But there's a major catch - to do the above, I needed to effectively disable refresh_overview_from_canvas. That in turn made triggering the overview redraw tricky - I've mana

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #48, patch #2715 (project freeciv): Funny thing - actually the problem was that I didn't clip. In this version, it's correctly clipped. So, we're back to the overview problem - I think, that this must be solved on your side. (file #14461) _

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #47, patch #2715 (project freeciv): It's what I said in comment #35 - I seem to be getting the clip region wrong - simply commenting gdk_cairo_region call in science_diagram_update makes it work as before, but it would be nice to get the clip right (I am working on it, but today

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #46, patch #2715 (project freeciv): What dictates that background color of (gtk2) research dialog is now black? I mean, it's ok to have it that way for now if it's working as designed, and not unexplained bug. I'd like to do some cleanup before we decide that this is final vers

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #45, patch #2715 (project freeciv): Just a minor explanation: it's not that in gtk2 with that clip the lines aren't drawn - the problem is that they're drawn black-on-black (at least ones for already developed tech), which isn't exactly helpful.

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #44, patch #2715 (project freeciv): This version of the patch seems to have science_diagram working correctly in gtk3 (slight (likely theming related) warnings aside). As for gtk2, I'm beginning to think that I may simply be using incorrect clip - simply cause ev->region might

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #43, patch #2715 (project freeciv): I think I managed to get gtkpixcomms correctly in gtk3 - even simplified it significantly. Now, I either try to fix science_diagram_update problem (gtk3 is affected too, but in a different way) or try to figure out why text doesn't show up in

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #42, patch #2715 (project freeciv): OK, as the issue with server/client hang has been worked around (by reverting two patches), attaching the counterpart of the recent api patch (posted in patch #2997). gtk3 part of gtkpixcomm drawing is sprinkled liberally with printf statemen

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #41, patch #2715 (project freeciv): Minor comment about GdkWindow to cairo context move: in one specific case there's a "minor" catch about it: in case of get_overview_window, the context will leak, as each call creates a new context. I don't have a good idea how to go around it

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #40, patch #2715 (project freeciv): Well, I'm having a little problem here - not with the patch itself, as even unitselect.c changes weren't that extensive, but with the server. I've checked out r20415, as it's the last before branching (and I think I'll stick to the 2.4 branch

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #39, patch #2715 (project freeciv): This no longer applies cleanly on top of trunk + patch #2997. Note that #2997 itself was changed from version that was submitted to this ticket earlier as it didn't apply cleanly on latest unitselect.c

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #38, patch #2715 (project freeciv): I assume you are aware of this document, but posting link just in case: http://developer.gnome.org/gtk3/3.0/ch25s02.html#gtk-migrating-GtkStyleContext Switching to use gtk3 should be separate patch anyway (IIRC there's already one with the re

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #37, patch #2715 (project freeciv): That was true for earlier patches, but since comment #17, those two are against r20326 - as I said, first apply api, then cairo. Also, this version of the patch works now with gtk3, though: - I'm almost sure it leaks - gtkpixcomms aren't draw

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #36, patch #2715 (project freeciv): > One more little request - as I explained how to apply these two > patches, could one of you tell how they work for you ? > Cause that they seem to work for me, doesn't mean I didn't miss > something obvious - see the disclaimer in comment #

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #35, patch #2715 (project freeciv): OK, I've made some progress. After a trivial (a NULL check) change in themes.c, freeciv is not only able to build with gtk3, but it starts with it and even seems to display overview window correctly. No more than that, however, as as it gets

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #34, patch #2715 (project freeciv): OK, unless I'm missing something, this minor change in gui-gtk-3.0/spaceshipdlg.c will be the final change needed before I can begin turning .drawable into .context - AFAICT even gtk2 will benefit a little from making such change. I already

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #33, patch #2715 (project freeciv): Yet another minor improvement of the patch - as pixmap_put_sprite was duplicated and redundant in favor of canvas_put_sprite, switched mapview.c to simply use canvas_put_sprite. It seems it's just one of the many steps that could be made to f

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #32, patch #2715 (project freeciv): One more little request - as I explained how to apply these two patches, could one of you tell how they work for you ? Cause that they seem to work for me, doesn't mean I didn't miss something obvious - see the disclaimer in comment #6. _

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #31, patch #2715 (project freeciv): TBH, the real gtk3 client (not just gtk2-by-cairo) will require a bit of reworking this patch. While I haven't (yet) even tried to debug why does it crash upon start if built against gtk3, I can make a good guess: AFAICT, in gtk3 case, the co

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #30, patch #2715 (project freeciv): > To be honest, if these two patches were properly split, thre > might have been at least 4-5 of them: > - one for ggz_id > - one for not gdk drawing related deprecations > - one for GSEAL > - one for GDK_MULTIHEAD_SAFE > - one for cairo drawi

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #29, patch #2715 (project freeciv): Well, ggz_id problem was mentioned back in comment #6 already. To be honest, if these two patches were properly split, thre might have been at least 4-5 of them: - one for ggz_id - one for not gdk drawing related deprecations - one for GSEAL

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Update of patch #2715 (project freeciv): Planned Release: 2.4.0 => 2.4.0, 2.5.0 ___ Follow-up Comment #28: One shouldn't do multiple things in one ticket. I've now opened separate ticket, patch #2997

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Update of patch #2715 (project freeciv): Depends on: => patch #2997 ___ Reply to this item at: ___ Message se

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #27, patch #2715 (project freeciv): As I said in comment #17, patches apply *cleanly* against r20326 trunk - first apply api patch, then cairo. As for variable names, if I had to come up with new names, writing those patches would likely take up to three times as long - I prefe

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #26, patch #2715 (project freeciv): > Also, I wouldn't mind being CCed to this bug, so I wouldn't need > to recheck it manually. I don't know if gna tracker even makes it possible to setup that for single ticket (I don't see such field) and you have given no address to cc to; y

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #25, patch #2715 (project freeciv): OK, few things of note: - gtk_combo_box_text_new used in my patch means it requires gtk+-2.24 (well, the eventual aim of this patch is gtk+-3 and there's no gtk_combo_box_new_text there) - r20328 solves the problem with "Lua console" dialog:

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #24, patch #2715 (project freeciv): > and I had only 2.20 installed - found a new repo, installed the > packages and it compiles now ... the gtk2x client from trunk is working but this patch will push the limit to 2.4 (gtk_combo_box_new_with_model_and_entry() and gtk_combo_box_s

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #23, patch #2715 (project freeciv): First, oops, I've accidentally made the text always shadowed - I've fixed it now. Second, I've made that change in pixmap_put_overlay_tile_draw, I've mentioned earlier. I've also changed canvas_fog_sprite_area a bit. The longer I look at it,

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #22, patch #2715 (project freeciv): > with minimum requirement of gtk2 2.22.0 and I had only 2.20 installed - found a new repo, installed the packages and it compiles now ... ___ Reply to this item at:

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #21, patch #2715 (project freeciv): Oh, something else I should have mentioned - the fog. freeciv was a bit inconsistent in this regard - in one place it was using 0.5 brightness, in the other 0.65. I've made it 0.65 in both, but it seems it's a bit too bright. Should it be ba

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #20, patch #2715 (project freeciv): > I can't really test gtk3 as I do not have it on my computer What is your version of gtk2? As you remember gtk3-client is still gtk2-program in reality, with minimum requirement of gtk2 2.22.0 (compiling newer version of gtk should be quite

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #19, patch #2715 (project freeciv): > Also, the only result of choosing "Lua console" in the menu is > "Gtk-CRITICAL **: IA__gtk_widget_realize: assertion > `GTK_WIDGET_ANCHORED (widget) || GTK_IS_INVISIBLE (widget)' > failed", but that's regardless of my patches. OK, so the lu

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #18, patch #2715 (project freeciv): One important thing I forgot to mention: I'm not sure if I got button blinking right, as I'm not sure what would be the easiest way of triggering that. ___ Reply to this item at:

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #17, patch #2715 (project freeciv): Due to your comment following patches are a bit rushed - among other, I haven't checked it it still builds against gtk3. Patches are against trunk, r20326. I'm the guy from bug #18243 and bug #18607 (on that note: pretty please about the late

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #16, patch #2715 (project freeciv): Is there any real bugs remaining in current version? I would fix only those in this ticket, and to leave any improvements to future tickets. It would be nice to get cairo based drawing to gtk3-client in 2.4 already, and S2_4 branching 2-Nov is

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #15, patch #2715 (project freeciv): OK, what I thought was a bug in gtkpixcom, was actually an inconsistency in sizes of supported and present units pixcomm heights. Is there a reason why those are different ? Anyway, a few more code shifts plus a few changes aimed at making th

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #14, patch #2715 (project freeciv): Well, there's still a bit of cleanup to be done, but canvas are unified now - there's only CANVAS_PIXMAP. Dropping CANVAS_PIXBUF wasn't hard, CANVAS_PIXCOMM, on the other hand, was a pain. Eventually, I've decided to simply reimplement alike

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #13, patch #2715 (project freeciv): No new patch this time, just a couple thoughts and explanations. As you might noticed, as opposed to the upstream patch, I focused on drawing first, unifying canvas later. While gtk3-client is actually "gtk2 on cairo" ATM, I'm still trying to

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #12, patch #2715 (project freeciv): Well, I should have expected that - that corruption along shorelines came from me being cargo cultist. After a trivial adjustment, mask is drawn in the correct place, so the corruption is gone. Still working on the leaks. Made a change to a

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #11, patch #2715 (project freeciv): OK, in the hindsight, it was painfully obvious (and - in a way - already hinted at in comment 5). It's actually just 4 lines. When creating tmpsurf, between cairo_create and cairo_set_source_surface, put following: cairo_save(cr); cairo_

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #10, patch #2715 (project freeciv): It will likely sound obnoxious, but a bit of googling gave me a solution of the corruption problem - both the sprites in treeview and transparent cursors look correctly, It was just a matter of adding 5 short lines to surface_get_pixbuf (each

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #9, patch #2715 (project freeciv): In an attempt to find out where things go wrong, I've lobotomized much of old map redraw logic - I think I've managed to confine redraw to screen to the expose callback, rest just queries areas for redraw. I've also given GDK_MULTIHEAD_SAFE a

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #8, patch #2715 (project freeciv): I forgot to mention - I think I've dropped all of the GdkGC stuff - though selection rectangle was only done thanks to Company. ___ Reply to this item at:

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #7, patch #2715 (project freeciv): So, I took some code from comment #5 patches, added a bit of my own left some of the old (non-gdk_draw*) alone. First patch is mostly the old one + patch #2914, second has a bit of cleanup and new stuff (working fog - at least it seems to be w

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #6, patch #2715 (project freeciv): Being a bit curious, I've decided to give this topic a shot. But I've been toying with 2.3.0 tarball, not trunk. First patch touches just about everything but gdk_draw_*. On that note - trunk seems to have a bug in gui_main.c in regard of srv

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #5, patch #2715 (project freeciv): Found out interesting facts about GtkPixcomm implementation. Actual drawing when widget is exposed uses those data pointers that have been earlier passed to gtk_pixcomm_fill() and gtk_pixcomm_copyto(). This means that GtkPixcomm users must ensu

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #4, patch #2715 (project freeciv): - Implemented colorbox icons in chatline.c with cairo - Corrected GdkColor conversion to colors used by cairo - Use pango for text drawing, fixing font size bugs in process Buglist: - Unit sprites not shown at help dialog - GtkPixcomm backgrou

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #3, patch #2715 (project freeciv): - Converting sprites/canvases to pixbufs should work on big endian machines too - Sprite mask handling - Use cairo (indirectly through sprites and canvases) also in gtkpixcomm operation OP_FILL - Removed some dead code - Function header for cre

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #2, patch #2715 (project freeciv): - Updated against current svn - Scaling in city dialog works - Map cavas shown also on city dialog's happiness tab - Cleanup Main problems remaining: - No mask handling at all - Unit sprites not shown at help0 dialog - GtkPixcomm backgrounds o

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

Follow-up Comment #1, patch #2715 (project freeciv): I compiles! Does not work at all correctly yet. (file #13647) ___ Additional Item Attachment: File name: CairoTmp.diff.bz2 Size:13 KB

[Freeciv-Dev] [patch #2715] Use cairo in gtk3-client

URL: Summary: Use cairo in gtk3-client Project: Freeciv Submitted by: cazfi Submitted on: Wed 15 Jun 2011 04:53:43 PM EEST Category: client-gtk-3.0 Priority: 5 - Normal