[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: build-and-test.sh: fix TIDY build .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15445 To unsubscribe, visit

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. Patch Set 1: Verified+1 Code-Review+2 Overriding Jenkins, TSAN failure was

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15445 to review the following change. Change subject: build-and-test.sh: fix TIDY build .. build-and-test.sh:

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 1: (5 comments)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (1 comment)

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (5 comments)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. Patch Set 1: (1 comment)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 1: (1 comment)

[kudu-CR] [ranger] pass 'principal' and 'keytab' to the subprocess

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 ) Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess .. Patch Set 7: (3 comments)

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (2 comments)

[kudu-CR] [ranger] validate the JAR file path for the subprocess

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 ) Change subject: [ranger] validate the JAR file path for the subprocess .. Patch Set 4: (1 comment)

[kudu-CR] [java] use KuduTestHarness in TestNegotiation

2020-03-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15434 ) Change subject: [java] use KuduTestHarness in TestNegotiation .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [java] use KuduTestHarness in TestNegotiation

2020-03-14 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15434 ) Change subject: [java] use KuduTestHarness in TestNegotiation .. [java] use KuduTestHarness in TestNegotiation Change-Id:

[kudu-CR] [java] use KuduTestHarness in TestConnectionCache

2020-03-14 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15431 ) Change subject: [java] use KuduTestHarness in TestConnectionCache .. [java] use KuduTestHarness in TestConnectionCache

[kudu-CR] [java] use KuduTestHarness in TestConnectionCache

2020-03-14 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15431 ) Change subject: [java] use KuduTestHarness in TestConnectionCache .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format

2020-03-14 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15396 ) Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format .. [util] Changes to

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 2: (1 comment)

[kudu-CR] [java] Upgrade to Gradle 6.2.2

2020-03-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 ) Change subject: [java] Upgrade to Gradle 6.2.2 .. Patch Set 3: Code-Review+2 -- To view, visit http://gerrit.cloudera.org:8080/15430 To

[kudu-CR] [java] Upgrade to Gradle 6.2.2

2020-03-13 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15430 ) Change subject: [java] Upgrade to Gradle 6.2.2 .. Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/15430/1/java/gradlew

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 1: (2 comments)

[kudu-CR] [build] Fail the LINT build with Java static analysis issues

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 ) Change subject: [build] Fail the LINT build with Java static analysis issues .. Patch Set 7: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 ) Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64 .. Patch Set 1: (1 comment)

[kudu-CR] threadpool: simplify Submit API

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15401 ) Change subject: threadpool: simplify Submit API .. threadpool: simplify Submit API In an effort to modernize our codebase, I'm

[kudu-CR] KUDU-3064 Make libunwind symbols work for all platform

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15419 ) Change subject: KUDU-3064 Make libunwind symbols work for all platform .. KUDU-3064 Make libunwind symbols work for all platform

[kudu-CR] KUDU-3064 Make libunwind symbols work for all platform

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15419 ) Change subject: KUDU-3064 Make libunwind symbols work for all platform .. Removed reviewer Kudu Jenkins with the following votes:

[kudu-CR] KUDU-3064 Make libunwind symbols work for all platform

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15419 ) Change subject: KUDU-3064 Make libunwind symbols work for all platform .. Patch Set 1: Verified+1 Code-Review+2 Overriding Jenkins,

[kudu-CR] [java] fix Kudu Ranger plugin in a Kerberized env

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin in a Kerberized env .. Patch Set 2: (3 comments)

[kudu-CR] [ranger] fix the java binary path for the subprocess

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] fix the java binary path for the subprocess .. Patch Set 2: (2 comments)

[kudu-CR] [ranger] pass 'principal' and 'keytab' to the subprocess

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 ) Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess .. Patch Set 2: (2 comments)

[kudu-CR] threadpool: simplify Submit API

2020-03-12 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15401 to look at the new patch set (#5). Change subject: threadpool: simplify Submit API

[kudu-CR] threadpool: simplify Submit API

2020-03-12 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15401 ) Change subject: threadpool: simplify Submit API .. Patch Set 5: (1 comment)

[kudu-CR] threadpool: simplify Submit API

2020-03-11 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15401 to look at the new patch set (#4). Change subject: threadpool: simplify Submit API

[kudu-CR] threadpool: simplify Submit API

2020-03-11 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15401 to look at the new patch set (#3). Change subject: threadpool: simplify Submit API

[kudu-CR] threadpool: simplify Submit API

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15401 ) Change subject: threadpool: simplify Submit API .. Patch Set 2: (2 comments)

[kudu-CR] [java] Fix checkstyle and spotbugs issues

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15410 ) Change subject: [java] Fix checkstyle and spotbugs issues .. Patch Set 4: (1 comment)

[kudu-CR] [build] Fail the LINT build with Java static analysis issues

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 ) Change subject: [build] Fail the LINT build with Java static analysis issues .. Patch Set 6: (1 comment)

[kudu-CR] [build] Fail the LINT build with Java static analysis issues

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15409 ) Change subject: [build] Fail the LINT build with Java static analysis issues .. Patch Set 4: (1 comment)

[kudu-CR] [build] Fix the instance detector-test.cc license header

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15406 ) Change subject: [build] Fix the instance_detector-test.cc license header .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] threadpool: simplify Submit API

2020-03-11 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, Todd Lipcon, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15401 to look at the new patch set (#2). Change subject: threadpool: simplify Submit API

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 6: Code-Review+2 -- To view, visit

[kudu-CR] [ksck] report on misconfiguration for flag categories

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 ) Change subject: [ksck] report on misconfiguration for flag categories .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [build] Fix compilation when NO CHRONY is not defined

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15404 ) Change subject: [build] Fix compilation when NO_CHRONY is not defined .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [build] Fix relocate binaries for mini cluster.py on Python 3

2020-03-11 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15405 ) Change subject: [build] Fix relocate_binaries_for_mini_cluster.py on Python 3 .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] ranger: fix the expected main class for the subprocess

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15400 ) Change subject: ranger: fix the expected main class for the subprocess .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] subprocess: maintain a thread for fork/exec

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15398 ) Change subject: subprocess: maintain a thread for fork/exec .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] threadpool: simplify Submit API

2020-03-10 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, Todd Lipcon, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15401 to review the following change. Change subject: threadpool: simplify Submit API ..

[kudu-CR] KUDU-3063: Set a ratio as multiplication factor for memkind malloc usable size

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15313 ) Change subject: KUDU-3063: Set a ratio as multiplication factor for memkind_malloc_usable_size .. Patch Set 6: (2 comments)

[kudu-CR] subprocess: maintain a thread for fork/exec

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15398 ) Change subject: subprocess: maintain a thread for fork/exec .. Patch Set 1: (1 comment)

[kudu-CR] ranger: instantiate Ranger queue size metrics

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15399 ) Change subject: ranger: instantiate Ranger queue size metrics .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: > Patch Set 4: > > Might be

[kudu-CR] KUDU-3070 skip open block manager

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15380 ) Change subject: KUDU-3070 skip open block manager .. KUDU-3070 skip open block manager In some cli ops (e.g. local_replica cmeta

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. [util] Import "Or" function to BlockBloomFilter

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. [util] Add support for 32 & 64 byte alignment

[kudu-CR] [ksck] report on misconfiguration for flag categories

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 ) Change subject: [ksck] report on misconfiguration for flag categories .. Patch Set 3: (2 comments)

[kudu-CR] [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15396 ) Change subject: [util] Changes to allow serializing/de-serializing BlockBloomFilter to a custom format .. Patch Set 1: Code-Review+2

[kudu-CR] KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 4: (4 comments) Looks good overall; Alexey should also

[kudu-CR] [ksck] report on misconfiguration for flag categories

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15298 ) Change subject: [ksck] report on misconfiguration for flag categories .. Patch Set 2: (8 comments)

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15387 ) Change subject: replace gscoped_ptr with std::unique_ptr .. Patch Set 3: Verified+1 Overriding Jenkins, unrelated test failure. -- To

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15387 ) Change subject: replace gscoped_ptr with std::unique_ptr .. replace gscoped_ptr with std::unique_ptr The remaining usages are in

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: replace gscoped_ptr with std::unique_ptr .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15387 To unsubscribe, visit

[kudu-CR] WIP - KUDU-3050: recover from corrupt kerberos ccache

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15394 ) Change subject: WIP - KUDU-3050: recover from corrupt kerberos ccache .. Patch Set 3: (10 comments)

[kudu-CR] KUDU-3070 skip open block manager

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15380 ) Change subject: KUDU-3070 skip open block manager .. Patch Set 14: Code-Review+2 -- To view, visit

[kudu-CR] KUDU-3070 skip open block manager

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15380 ) Change subject: KUDU-3070 skip open block manager .. Patch Set 12: (4 comments)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 5: Code-Review+2 -- To view, visit

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-10 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 2: (1 comment)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 4: (1 comment)

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-09 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15387 to look at the new patch set (#3). Change subject: replace gscoped_ptr with std::unique_ptr

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-09 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15387 ) Change subject: replace gscoped_ptr with std::unique_ptr .. Patch Set 2: (3 comments)

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-09 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15387 to look at the new patch set (#2). Change subject: replace gscoped_ptr with std::unique_ptr

[kudu-CR] replace gscoped ptr with std::unique ptr

2020-03-09 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15387 to review the following change. Change subject: replace gscoped_ptr with std::unique_ptr .. replace

[kudu-CR] KUDU-3070 skip open block manager

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15380 ) Change subject: KUDU-3070 skip open block manager .. Patch Set 4: (3 comments)

[kudu-CR] [tserver] report the newly bootstrapped tablet after OpenTablet completes

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 ) Change subject: [tserver] report the newly bootstrapped tablet after OpenTablet completes .. Patch Set 15: Code-Review+2 -- To view,

[kudu-CR] master: plumb metric for master leadership

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15386 ) Change subject: master: plumb metric for master leadership .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-3070 allow rewrite raft config take multi tablet id as input

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15380 ) Change subject: KUDU-3070 allow rewrite_raft_config take multi tablet_id as input .. Patch Set 2: While reviewing this, I naturally

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 3: Code-Review+2 (1 comment)

[kudu-CR] [tserver] report the newly bootstrapped tablet after OpenTablet completes

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15307 ) Change subject: [tserver] report the newly bootstrapped tablet after OpenTablet completes .. Patch Set 14: (2 comments)

[kudu-CR] [test-util] set OpenSSL security level for kudu CLI

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15384 ) Change subject: [test-util] set OpenSSL security level for kudu CLI .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] common/tserver: replace gscoped ptr with unique ptr

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15379 ) Change subject: common/tserver: replace gscoped_ptr with unique_ptr .. Patch Set 3: (1 comment)

[kudu-CR] common/tserver: replace gscoped ptr with unique ptr

2020-03-08 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15379 ) Change subject: common/tserver: replace gscoped_ptr with unique_ptr .. common/tserver: replace gscoped_ptr with unique_ptr There

[kudu-CR] common/tserver: replace gscoped ptr with unique ptr

2020-03-06 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15379 to look at the new patch set (#2). Change subject: common/tserver: replace gscoped_ptr with unique_ptr

[kudu-CR] common/tserver: replace gscoped ptr with unique ptr

2020-03-06 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15379 to review the following change. Change subject: common/tserver: replace gscoped_ptr with unique_ptr ..

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: util: remove all gscoped_ptr .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15377 To unsubscribe, visit

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. util: remove all gscoped_ptr Except from callback_bind-test.cc, which tests

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 3: Verified+1 Overriding Jenkins, another dist-test temp dir issue. -- To

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15377 to look at the new patch set (#3). Change subject: util: remove all gscoped_ptr ..

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15377 to look at the new patch set (#2). Change subject: util: remove all gscoped_ptr ..

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15377 ) Change subject: util: remove all gscoped_ptr .. Patch Set 1: (3 comments)

[kudu-CR] util: remove all gscoped ptr

2020-03-05 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15377 to review the following change. Change subject: util: remove all gscoped_ptr .. util: remove all

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] subprocess: add server metric for queue size

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15375 ) Change subject: subprocess: add server metric for queue size .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] KUDU-2972 Add Ranger authorization provider

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15207 ) Change subject: KUDU-2972 Add Ranger authorization provider .. Patch Set 29: Code-Review+1 -- To view, visit

[kudu-CR] [util] Import "Or" function to BlockBloomFilter from Impala

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15373 ) Change subject: [util] Import "Or" function to BlockBloomFilter from Impala .. Patch Set 1: (3 comments)

[kudu-CR] [util] Add support for 32 & 64 byte alignment to Arena allocator

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15372 ) Change subject: [util] Add support for 32 & 64 byte alignment to Arena allocator .. Patch Set 1: (2 comments)

[kudu-CR] subprocess: add server-side metrics

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 ) Change subject: subprocess: add server-side metrics .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] Init kudu.write duration accumulator lazily

2020-03-05 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15368 ) Change subject: Init kudu.write_duration accumulator lazily .. Patch Set 1: I think Grant already addressed this issue within the

[kudu-CR] subprocess: add server-side metrics

2020-03-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15367 ) Change subject: subprocess: add server-side metrics .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] subprocess: report metrics even when calls fail

2020-03-04 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15366 ) Change subject: subprocess: report metrics even when calls fail .. Patch Set 4: Code-Review+2 -- To view, visit

<    1   2   3   4   5   6   7   8   9   10   >