[gem5-dev] Change in gem5/gem5[develop]: mem: Add a page_bytes parameter to the classic prefetcher.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6921943c49af19971b84225ecfd1127304363426 Gerrit-Change-Number: 50352 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email

[gem5-dev] Change in gem5/gem5[develop]: sim: Move the MemPools object out of System and into SEWorkload.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
ddress is within a range of a memory that @@ -593,10 +586,6 @@ public: -/// Allocate npages contiguous unused physical pages -/// @return Starting address of first page -Addr allocPhysPages(int npages, int poolID = 0); - void registerThreadContext( ThreadCon

[gem5-dev] Change in gem5/gem5[develop]: sim: Get rid of the now unused System::getPageShift() method.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I22e04b47d3932751e03efc0918d44fc1627833bd Gerrit-Change-Number: 50353 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list

[gem5-dev] Change in gem5/gem5[develop]: sim: Move System specific code out of MemPools.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
} void -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50350 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic23aeb959d6f666b655d010c8572c41c60

[gem5-dev] Change in gem5/gem5[develop]: base,python: Expand AddrRange exclude and add subtraction operators.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
m5-review.googlesource.com/c/public/gem5/+/50347 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic48f0c45a4809dbc51e1d3133e8319134aabe29e Gerrit-Change-Number: 50347 Gerr

[gem5-dev] Change in gem5/gem5[develop]: sim: Drop a hack from MemPools which reset the free page.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
c/gem5/+/50349 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I16e0d8835452df9c3e79738a1eed05b4cc9372b7 Gerrit-Change-Number: 50349 Gerrit-PatchSet: 1 Gerrit-Owner: G

[gem5-dev] Change in gem5/gem5[develop]: base: Fix some style problems in addr_range.hh.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ib55b86350c4bc3f1f44af996db25a1e44826d077 Gerrit-Change-Number: 50346 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange

[gem5-dev] Change in gem5/gem5[develop]: sim: Make the SEWorkload base class abstract.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
mber: 50345 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: misc: Use AddrRangeList more consistently in the AddrRange class.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
eSize", &RangeSize); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50344 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I1a03b25990025688aa760a67d3e7a2e8141384ce Gerrit-Change-Number: 50344 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Encapsulate MemPool related System stuff in a MemPools class.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
{ return physmem; } /** Amount of physical memory that is still free */ Addr freeMemSize(int poolID = 0) const; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50343 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/s

[gem5-dev] Change in gem5/gem5[develop]: misc: Move MemPool based calls to the SEWorkload.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
or now, assume the only type of events are system calls. void event(ThreadContext *tc) override { syscall(tc); } + +Addr allocPhysPages(int npages, int pool_id=0); +Addr memSize(int pool_id=0) const; +Addr freeMemSize(int pool_id=0) const; }; } // namespace gem5 -- To view, visit h

[gem5-dev] Change in gem5/gem5[develop]: sim: Move serialization logic for MemPools out of System.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
memPools.push_back(pool); +} // also unserialize the memories in the system physmem.unserializeSection(cp, "physmem"); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50340 To unsubscribe, or for help writing mail filters, visit https://gem5

[gem5-dev] Change in gem5/gem5[develop]: sim: Set up an SEWorkload pointer in the base Process class.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
urce.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I2cbddcabdf7264fde492b0566791d909ce2b10be Gerrit-Change-Number: 50341 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: base: Make the AddrRange::exclude method const.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
r: 50337 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: sim: Make the page shift a member of the MemPool class.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
izeSection(cp, "physmem"); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50339 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I059bcb

[gem5-dev] Change in gem5/gem5[develop]: sim: Exclude the m5opRange from the system mempools by construction.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
blic/gem5/+/50338 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0d88c1bc2f889f32b234073cff8988319fb36ea5 Gerrit-Change-Number: 50338 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black

[gem5-dev] Change in gem5/gem5[develop]: scons: Use tags to gate ISA files and not env['TARGET_ISA'].

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
Source('a9scu.cc') -Source('amba_device.cc') -Source('amba_fake.cc') -Source('base_gic.cc') -Source('display.cc') - Source('flash_device.cc') -Source('generic_timer.cc') -Source('gic_v2.cc'

[gem5-dev] Change in gem5/gem5[develop]: cpu: Stop excluding the protobuf tracer for x86.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
m/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I71d9eca4b13809273cdddf8ae175379e382ab9d7 Gerrit-Change-Number: 50332 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing l

[gem5-dev] Change in gem5/gem5[develop]: scons: Add tag support to GdbXml.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
ber: 50328 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons: Make the SimObject list from the 'gem5 lib' tag.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
hange-Id: I0aca1ef830bcc7beaee80c54d58ba8a188968491 Gerrit-Change-Number: 50331 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons: Make debug flags respect tags.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I16911252176a5a8df0e56c0e37a3c11b4cf1dd7b Gerrit-Change-Number: 50333 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: configs,dev: Rename the riscv version of VirtIOMMIO with a Riscv prefix.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
pace gem5 #endif // __DEV_ARM_VIO_MMIO_HH__ -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50335 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I558676b7d64cc68adb2

[gem5-dev] Change in gem5/gem5[develop]: arch: Consolidate common debug flags.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
ions/traps") DebugFlag('LocalApic', "Local APIC debugging") -DebugFlag('Decoder', "Decoder debug output") DebugFlag('X86', "Generic X86 ISA debugging") DebugFlag('ACPI', "ACPI debug

[gem5-dev] Change in gem5/gem5[develop]: scons,arch: Make the gem5 lib tag imply the current arch tag.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
it-Branch: develop Gerrit-Change-Id: Ia3a23860d2ee39ec6b32ee2195648b4d88564c83 Gerrit-Change-Number: 50330 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem

[gem5-dev] Change in gem5/gem5[develop]: scons: Add tag support to ISADesc.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
it-Change-Id: Icac027cc4df48d0a3c06911bd6fa0a8b5b72c60a Gerrit-Change-Number: 50329 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons: Move the source related helper classes out of src/SConscript.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
if not isinstance(tags, set): -tags = set(tags) - self.tags = tags - -if add_tags: - if isinstance(add_tags, str): -add_tags = { add_tags } -if not isinstance(add_tags, set): -add_tags = set(add_tags) -self

[gem5-dev] Change in gem5/gem5[develop]: scons: Build the source filter factories dict in SourceFilter.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
get(name, None) if not func: raise AttributeError -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48375 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch

[gem5-dev] Change in gem5/gem5[develop]: scons: Turn gem5_scons.builders from a module into a package.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
27;) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48374 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I3db2f2c87b39ed0d427a2e505c7c9152e47ee58b

[gem5-dev] Change in gem5/gem5[develop]: scons: Define the rules for building debug flag hdrs in place.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
ansform("TRACING", 0))) Source('debug/flags.cc', add_tags='gem5 trace') -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48372 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: p

[gem5-dev] Change in gem5/gem5[develop]: scons: Tidy up the definition of SourceFile slightly.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
Gabe Black Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Hoa Nguyen Gerrit-Reviewer: kokoro Gerrit-MessageType: merged ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(we

[gem5-dev] Change in gem5/gem5[develop]: scons: Generalize the Executable class to cover libraries too.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
# First make a library of everything but main() so other programs can -# link against m5. -static_lib = env.StaticLibrary(libname, static_objs) -shared_lib = env.SharedLibrary(libname, shared_objs) - -# Keep track of the object files generated so far so Executables can -# inclu

[gem5-dev] Change in gem5/gem5[develop]: scons: Add a pair of functions for working with Value nodes.

2021-09-14 Thread Gabe Black (Gerrit) via gem5-dev
ol', 'ToValue', 'FromValue'] -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48371 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-C

[gem5-dev] Change in gem5/gem5[develop]: arch: Eliminate the vecregs.hh switching header file.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
isit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic0089f83e83f76ad6308ecfb5007b5ef11e1d949 Gerrit-Change-Number: 50256 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: misc: Stop including arch/vecregs.hh and fix transitive includes.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
h index 0cf1b3b..7b98e4d 100644 --- a/src/sim/insttracer.hh +++ b/src/sim/insttracer.hh @@ -41,7 +41,6 @@ #ifndef __INSTRECORD_HH__ #define __INSTRECORD_HH__ -#include "arch/vecregs.hh" #include "base/types.hh" #include "cpu/inst_res.hh" #include "cpu/inst_seq.hh" -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50255 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I7854e77517f52b7c19cdb91c67016315391fd87f Gerrit-Change-Number: 50255 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu,sim: Store registers in InstRecord with InstResult.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
flags; } bool getMemValid() const { return mem_valid; } -uint64_t getIntData() const { return data.as_int; } -double getFloatData() const { return data.as_double; } -int getDataStatus() const { return data_status; } +uint64_t getIntData() const { return data.asInt; } +double get

[gem5-dev] Change in gem5/gem5[develop]: arch-arm,cpu: Simplify the RegClass constructor(s).

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
Branch: develop Gerrit-Change-Id: I8acb755eb28fc8474ec453c51ad205a52eed9a8e Gerrit-Change-Number: 50249 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an

[gem5-dev] Change in gem5/gem5[develop]: cpu: Simplify and revamp the InstResult class.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
al); } void setRegOperand(const StaticInst *si, int idx, const void *val) override { -cpu->setReg(regs.renamedDestIdx(idx), val); -//TODO setResult +const PhysRegIdPtr reg = regs.renamedDestIdx(idx); +

[gem5-dev] Change in gem5/gem5[develop]: cpu,arch: Put the name of the RegClass into the RegClass.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
ected: -static const char* regClassStrings[]; const RegClass *_regClass = nullptr; RegIndex regIdx; int numPinnedWrites; @@ -223,7 +224,7 @@ constexpr const char* className() const { - return regClassStrings[classVa

[gem5-dev] Change in gem5/gem5[develop]: cpu: Generalize how register files are serialized.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
te pcState; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/50252 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I61dbd7825ffe35c41e1b7c8317590

[gem5-dev] Change in gem5/gem5[develop]: arch-mips: Empty the locked_mem.hh header.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
/+/50247 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I72f89656c0bfeb4846af1be2c3146e25e992521f Gerrit-Change-Number: 50247 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Make getIsaPtr const.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
50250 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu-o3: Remove TheISA:: types from forwardOldRegs.

2021-09-11 Thread Gabe Black (Gerrit) via gem5-dev
visit https://gem5-review.googlesource.com/c/public/gem5/+/50248 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0426a606185edc0aabbf4b77c825b618b4640590 Gerrit-Change-Number: 5

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Modify the AAPCS32 ABI implementation to use VecElems.

2021-09-09 Thread Gabe Black (Gerrit) via gem5-dev
e, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ie8f17b764402a6331012f13b7605520512c2d5c9 Gerrit-Change-Number: 50207 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe B

[gem5-dev] Change in gem5/gem5[develop]: scons: Pull some python related mechanisms out of USE_PYTHON guards.

2021-09-09 Thread Gabe Black (Gerrit) via gem5-dev
for source in PySource.all: -marshal_env.Command(source.cpp, [ py_marshal, source.tnode ], -MakeAction(embedPyFile, Transform("EMBED PY"))) Source(source.cpp, tags=source.tags, add_tags='python') #

[gem5-dev] Change in gem5/gem5[develop]: scons: Change how the test object file suffix is applied.

2021-09-09 Thread Gabe Black (Gerrit) via gem5-dev
filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Id8c5f893413284868c2dc2a1a5e879b86790ed76 Gerrit-Change-Number: 50067 Gerrit-PatchSet: 2 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer:

[gem5-dev] Change in gem5/gem5[develop]: cpu: Generalize the vec reg types out of InstResult.

2021-09-09 Thread Gabe Black (Gerrit) via gem5-dev
er -asPred() const -{ -panic_if(!isPred(), "Converting scalar (or invalid) to predicate!!"); -return std::any_cast(result); +if (!is()) +return T{}; +return as(); } /** @} */ -- To view, visit https://gem5-review.googlesou

[gem5-dev] Change in gem5/gem5[develop]: scons: Change how the test object file suffix is applied.

2021-09-07 Thread Gabe Black (Gerrit) via gem5-dev
m5/+/50067 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Id8c5f893413284868c2dc2a1a5e879b86790ed76 Gerrit-Change-Number: 50067 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: scons,debug: Implement the "All" flag in C++ and not scons.

2021-09-05 Thread Gabe Black (Gerrit) via gem5-dev
ion; }) +.def("getAllFlagsVersion", + []() { return debug::AllFlagsFlag::version(); }) .def("allFlags", &debug::allFlags, py::return_value_policy::reference) .def("schedBreak", &schedBreak) -- To view, visit https:

[gem5-dev] Change in gem5/gem5[develop]: scons: Eliminate the "Arch" enum.

2021-09-05 Thread Gabe Black (Gerrit) via gem5-dev
rrit-Change-Id: I476d7c1ef1bc1e34cbf904fc33c6735038e999c9 Gerrit-Change-Number: 48712 Gerrit-PatchSet: 8 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travagl

[gem5-dev] Change in gem5/gem5[develop]: sim: Eliminate the now unused System::getArch().

2021-09-04 Thread Gabe Black (Gerrit) via gem5-dev
Gerrit-Change-Number: 48711 Gerrit-PatchSet: 7 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Bobby R. Bruce Gerrit-Reviewer: Daniel Carvalho Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Hoa Nguyen Gerrit-Reviewer: Jason Lowe-Power

[gem5-dev] Change in gem5/gem5[develop]: x86,mem: Replace the x86 StoreCheck flag with READ_MODIFY_WRITE.

2021-09-04 Thread Gabe Black (Gerrit) via gem5-dev
secondary_type = RubyRequestType_ST; } else { -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48710 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit

[gem5-dev] Change in gem5/gem5[develop]: scons,python,sim: Eliminate a redundant member of EmbeddedPython.

2021-09-04 Thread Gabe Black (Gerrit) via gem5-dev
; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48365 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I61b312f2c356045e03462159e3232ac717954669 Gerrit

[gem5-dev] Change in gem5/gem5[develop]: configs,python: Clean some cruft out of m5.objects.

2021-09-04 Thread Gabe Black (Gerrit) via gem5-dev
Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I3030c1eb261877fd9648c9d3d73b7dbbd4c24345 Gerrit-Change-Number: 48364 Gerrit-PatchSet: 11 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Revi

[gem5-dev] Change in gem5/gem5[develop]: scons: Update the special module importer API.

2021-09-04 Thread Gabe Black (Gerrit) via gem5-dev
'm5.objects.'): exec("from %s import *" % module) -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/48363 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Projec

[gem5-dev] Change in gem5/gem5[develop]: cpu: Switch std::variant out for std::any in IntResult.

2021-09-02 Thread Gabe Black (Gerrit) via gem5-dev
(result); } /** @} */ -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49130 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I43bf8d1866b1538db7d91c

[gem5-dev] Change in gem5/gem5[develop]: arch: Ensure using namespace * doesn't leak from generated ISA files.

2021-09-02 Thread Gabe Black (Gerrit) via gem5-dev
+{ using namespace X86ISA; +} // namespace gem5::X86ISAInst }}; - -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49887 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Iebf3c

[gem5-dev] Change in gem5/gem5[develop]: cpu-minor: Use the << operator in minorTraceInst.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
cpu.threads[0]->getIsaPtr()->regClasses()); +dyn_inst->staticInst->isMacroop()) { +dyn_inst->minorTraceInst(*this); } } -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49809 To unsub

[gem5-dev] Change in gem5/gem5[develop]: cpu: Revamp the RegId << operator.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
rrit-Branch: develop Gerrit-Change-Id: I00e93032ddea77e167ca13e54b370de7210f1a2b Gerrit-Change-Number: 49808 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-sparc: Remove unused fixed register operands.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
O3', 'IsInteger', 13), -'O4': IntReg('udw', 'INTREG_O4', 'IsInteger', 14), -'O5': IntReg('udw', 'INTREG_O5', 'IsInteger', 15), # Control registers 'Y'

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Remove pointless makeSPs and makeZeros around fixed idxs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
e.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I604f013430f180566e1cc44939b145bc5f45f637 Gerrit-Change-Number: 49763 Gerrit-PatchSet: 3 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Trava

[gem5-dev] Change in gem5/gem5[develop]: scons: Get rid of some unused or unnecessary PySource members.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
c/public/gem5/+/48139 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I738960cf0d84017ccc133428aef56701c1d40b03 Gerrit-Change-Number: 48139 Gerrit-PatchSet: 7 Gerrit-Owner: Gabe Black G

[gem5-dev] Change in gem5/gem5[develop]: util: Expand the valgrind suppressions file to the entire libpython.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
: I4869eeeb4aef5884ad52025b52c9616e0541f3e6 Gerrit-Change-Number: 49530 Gerrit-PatchSet: 2 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Bobby Bruce Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Jason Lowe-Power Gerrit-Reviewer: Jui-min Lee Gerrit

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: For semihosting, mask reg value and not index.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
m/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I66cb845d4e97b1895072bd98de709256625c8e3f Gerrit-Change-Number: 49762 Gerrit-PatchSet: 3 Gerrit-Owner: Gabe Black Gerrit-Reviewer: Andreas Sandberg Gerrit-Reviewer: Gabe Black Gerrit-Reviewer: Giacomo Travaglini Ger

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Eliminate the INTREG_DUMMY integer register.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
blic/gem5/+/49223 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ibdc488a2b55162a5f9e3d355126f6c48a99272a9 Gerrit-Change-Number: 49223 Gerrit-PatchSet: 3 Gerrit-Owner:

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Keep a RegClass pointer in RegId instead of a RegClassType.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
Id(type(), idx); + return RegId(*this, idx); } template @@ -331,14 +336,14 @@ bool pinned; public: -explicit PhysRegId() : RegId(InvalidRegClass, -1), flatIdx(-1), +explicit PhysRegId() : RegId(invalidRegClass, -1), flatIdx(-1), numPinnedWritesToComplete(0) {} /** Scalar PhysRegId constructor. */ -explicit PhysRegId(RegClassType _regClass, RegIndex _regIdx, +explicit PhysRegId(const RegClass ®_class, RegIndex _regIdx, RegIndex _flatIdx) -: RegId(_regClass, _regIdx), flatIdx(_flatIdx), +: RegId(reg_class, _regIdx), flatIdx(_flatIdx), numPinnedWritesToComplete(0), pinned(false) {} @@ -432,7 +437,7 @@ { // Extract unique integral values for the effective fields of a RegId. const size_t index = static_cast(reg_id.index()); -const size_t class_num = static_cast(reg_id.regClass); +const size_t class_num = static_cast(reg_id.classValue()); const size_t shifted_class_num = class_num << (sizeof(gem5::RegIndex) << 3); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49786 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I4cfff2069d63f3c1c3fb0fea5dee3baf357bd478 Gerrit-Change-Number: 49786 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Store pointers to RegClass-es instead of instances.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
ses(); -const size_t numFloats = regClasses.at(FloatRegClass).size(); +const size_t numFloats = regClasses.at(FloatRegClass)->size(); RegVal floatRegs[numFloats]; // This is a bit ugly, but needed to maintain backwards // compatibility. arrayParamIn(cp, "floatRegs.i", flo

[gem5-dev] Change in gem5/gem5[develop]: scons: Use unions to prevent debug flag destruction.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
(makeDebugFlagHH, Transform("TRACING", 0))) -env.Command('debug/flags.cc', Value(debug_flags), -MakeAction(makeDebugFlagCC, Transform("TRACING", 0))) -Source('debug/flags.cc', add_tags='gem5 trace') - # version tags tags = \ env.Command('sim/tags.cc', None, -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49783 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ia43111d938e7af7140b1c17dd68135f426d0a1e9 Gerrit-Change-Number: 49783 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Use range based for loops to iterate over RegClass-s.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
id, ccRegs[id.index()]); } TheISA::PCState pcState; -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49781 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ie42ad814a5a90cb635fb4f92d46c8a8c6abeb6a6 Gerrit-Change-Number: 49781 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Add a [] operator to the RegClass type.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I2c3e6859fce80ede5cdb70f85d881b514b6babb2 Gerrit-Change-Number: 49782 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange

[gem5-dev] Change in gem5/gem5[develop]: cpu: Add an iterator type to RegClass.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
em5 Gerrit-Branch: develop Gerrit-Change-Id: Ia3c2aa5cf4d842465bd0948d174f51a1b92e5e3f Gerrit-Change-Number: 49780 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe se

[gem5-dev] Change in gem5/gem5[develop]: cpu: Fix style in cpu/timing_expr.cc.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
rs, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ic3d9d870b2f7648fd8b215692c33580f05cdb364 Gerrit-Change-Number: 49775 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange __

[gem5-dev] Change in gem5/gem5[develop]: cpu: Stop using or providing legacy (read|set)Reg* accessors.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
-review.googlesource.com/c/public/gem5/+/49778 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I7d16d697ecfb813eb870068677f77636d41af28b Gerrit-Change-Number: 49778 Gerrit-Patch

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Keep track of the RegClassType of a RegClass.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
ublic/gem5/+/49779 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Ib7d7fa3e2d88a34d5b5681fcc4aab26696c71205 Gerrit-Change-Number: 49779 Gerrit-PatchSet: 1 G

[gem5-dev] Change in gem5/gem5[develop]: cpu: Merge TimingExprSrcReg and TimingExprReadIntReg.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
f.hh" #include "params/TimingExprSrcReg.hh" #include "params/TimingExprUn.hh" @@ -124,19 +123,6 @@ uint64_t eval(TimingExprEvalContext &context); }; -class TimingExprReadIntReg : public TimingExpr -{ - public: -TimingExpr *reg; - -TimingExprReadIntReg(const Ti

[gem5-dev] Change in gem5/gem5[develop]: cpu: Switch to the (get|set)Reg API in the checker CPU.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
rce.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I7ab1319ae6fc6d0d5bc62322fbe92c7131ce6403 Gerrit-Change-Number: 49777 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing l

[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: Revamp float regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
gem5-review.googlesource.com/c/public/gem5/+/49773 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6bb7a4f78e59082c3f783a5d4c2cb79f9c6df61f Gerrit-Change-Number: 49773 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch: Switch the generic register ABI over to use RegId.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
develop Gerrit-Change-Id: I4bbe884fe01fe14d7f18574f494a831dee2996d3 Gerrit-Change-Number: 49774 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-riscv: Revamp int regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
anch, and if that instruction's @@ -120,7 +120,7 @@ str << "?? (x" << reg.index() << ')'; return str.str(); } -return IntRegNames[reg.index()]; +return int_reg::RegNames[reg.index()]; } else { i

[gem5-dev] Change in gem5/gem5[develop]: arch-power: Revamp float regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
c/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I77a5a021da82c8528d092f7363a927dec224d5ac Gerrit-Change-Number: 49771 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-power: Revamp int registers.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
reg::NumArchRegs]; uint64_t fpr[NumFloatArchRegs]; uint32_t pc; uint32_t msr; @@ -85,7 +85,7 @@ private: struct GEM5_PACKED { -uint64_t gpr[NumIntArchRegs]; +uint64_t gpr[int_reg::NumArchRegs]; uin

[gem5-dev] Change in gem5/gem5[develop]: arch-sparc: Revamp the float registers.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
glesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: Iec52e15f1529319345795496a82a37e1f0aeebae Gerrit-Change-Number: 49769 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev ma

[gem5-dev] Change in gem5/gem5[develop]: arch-sparc: Revamp the int regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
ISCREG_CWP, CWP); // Do the stores -RegVal sp = tc->readIntReg(StackPointerReg); +RegVal sp = tc->getReg(StackPointerReg); Addr addr = is_64 ? sp + 2047 : sp; for (int index = 16; index < 32; index++) { + RegId reg(IntRegClass, index);

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Rework the condition code regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
0 @@ // the CC flags on top of the value if (regRelIdx == MISCREG_CPSR) { CPSR cpsr = thread->readMiscRegNoEffect(MISCREG_CPSR); -cpsr.nz = thread->readCCReg(CCREG_NZ); -cpsr.c = thread->readCCReg(CCREG_C); -cpsr.v = thread->readCCReg(CCREG_V)

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Switch from (set|read)Vec* to (get|set)Reg* accessors.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
umVecElemPerVecReg; j++, ei++) { RegId elem_id(VecElemClass, ei); -reg.as()[j] = tc->readVecElem(elem_id); +reg.as()[j] = tc->getReg(elem_id); } RegId reg_id(VecRegClass, ri); - tc->setVecReg(reg_id, reg); +

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Rework the int regs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I352e12d4742f0771859bdbf9634ac87e2c153427 Gerrit-Change-Number: 49764 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Remove pointless makeSPs and makeZeros around fixed idxs.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
ge-Id: I604f013430f180566e1cc44939b145bc5f45f637 Gerrit-Change-Number: 49763 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_pag

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: Fix up code related to the float reg file?

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
lesource.com/c/public/gem5/+/49767 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I6ed2ed9ae853fa4313294fdde4ce08d134fc12da Gerrit-Change-Number: 49767 Gerrit-PatchSet: 1 Ger

[gem5-dev] Change in gem5/gem5[develop]: arch-arm: For semihosting, mask reg value and not index.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
895072bd98de709256625c8e3f Gerrit-Change-Number: 49762 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Rework float regs for getReg and setReg.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
@ const double value(X86ISA::loadFloat80(fpu.fpr[i])); DPRINTF(KvmContext, "Setting gem5 FP reg %i (st[%i]) := %f\n", reg_idx, i, value); -tc->setFloatReg(FLOATREG_FPR(reg_idx), floatToBits64(value));

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Convert segment indices to fit the style guide.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
5Reg.mode != LongMode) { DPRINTF(TLB, "Not in long mode. Checking segment protection.\n"); // Check for a NULL segment selector. -if (!(seg == SEGMENT_REG_TSG || seg == SYS_SEGMENT_REG_IDTR || -

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Stop using (read|set)IntReg.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
mreg) FOREACH_IREG(); #undef APPLY_IREG @@ -979,7 +979,7 @@ X86KvmCPU::updateThreadContextRegs(const struct kvm_regs ®s, const struct kvm_sregs &sregs) { -#define APPLY_IREG(kreg, mreg) tc->setIntReg(mreg, regs.kreg) +#define APPLY_IREG(kreg, mreg) tc->setReg(mreg, regs.kreg) FOREACH_IREG(); -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49755 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I9e7551ed66a6979e83c745f2891c452ded1eff0e Gerrit-Change-Number: 49755 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Rework CCRegs for getReg, setReg.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
gMask); +tc->setReg(X86ISA::cc_reg::Cfof, val & CfofMask); +tc->setReg(X86ISA::cc_reg::Df, val & DFBit); // Internal microcode registers (ECF & EZF) -tc->setCCReg(X86ISA::CCREG_ECF, 0); -tc->setCCReg(X86ISA::CCREG_EZF, 0); +tc->setReg(X86ISA::cc_reg::Ecf, (RegVal)0); +tc

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Convert the int register constants from RegIndex to RegId.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
https://gem5-review.googlesource.com/c/public/gem5/+/49754 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I73fc9e55418ad3ab9e08406f0928aa4b1ef30a49 Gerrit-Change-Number: 49754 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: constexpr most of RegId's methods, and add a RegIndex operator.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I5fff224dce5e02959d5fc3e717014bf7eaa9c022 Gerrit-Change-Number: 49753 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType:

[gem5-dev] Change in gem5/gem5[develop]: arch-x86: Use a namespace for integer registers.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
p, r.esp); +context->setIntReg(int_reg::Rbp, r.ebp); +context->setIntReg(int_reg::Rsi, r.esi); +context->setIntReg(int_reg::Rdi, r.edi); context->pcState(r.eip); context->setMiscReg(MISCREG_RFLAGS, r.eflags); if (r.cs != context->readMiscRegNoEffec

[gem5-dev] Change in gem5/gem5[develop]: arch: Improve the regular expression that finds operands.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
om/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I0bd84b69b9dad278191831d82db762ae75ce4bf1 Gerrit-Change-Number: 49751 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list --

[gem5-dev] Change in gem5/gem5[develop]: arch: Remove plumbing for an op_idx value in ISA operands.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
PC state itself. -return '%s = xc->pcState();\n' % self.base_name +return f'{self.base_name} = xc->pcState();\n' -def makeWrite(self, op_idx): +def makeWrite(self): if self.reg_spec: # A component of the PC state. return '__parserAutoPCState.%s(%s);\n' % \ diff --git a/src/arch/x86/isa/operands.isa b/src/arch/x86/isa/operands.isa index 4e61011..677396d 100644 --- a/src/arch/x86/isa/operands.isa +++ b/src/arch/x86/isa/operands.isa @@ -66,9 +66,9 @@ class PickedReg(IntReg): @overrideInOperand -def makeRead(self, op_idx): +def makeRead(self): return f'{self.base_name} = pick(xc->getRegOperand(' \ -f'this, {op_idx}), {self.reg_spec}, ' \ +f'this, {self.src_reg_idx}), {self.reg_spec}, ' \ f'{self.data_size});\n' def __init__(self, idx, id, data_size='dataSize'): @@ -76,9 +76,9 @@ class SignedPickedReg(IntReg): @overrideInOperand -def makeRead(self, op_idx): +def makeRead(self): return f'{self.base_name} = signedPick(xc->getRegOperand(' \ -f'this, {op_idx}), {self.reg_spec}, ' \ +f'this, {self.src_reg_idx}), {self.reg_spec}, ' \ f'{self.data_size});\n' def __init__(self, idx, id, data_size='dataSize'): -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49750 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I37daeb646b85e050c4b832af28d054ecc3c338b1 Gerrit-Change-Number: 49750 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: arch,cpu: Remove the idea of a zero register.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
INTFV(reg_class.debug(), "Setting %s register %s (%d) to %#x.\n", @@ -488,7 +488,7 @@ auto ®_file = regFiles[reg.classValue()]; const auto ®_class = reg_file.regClass; -if (reg.index() == reg_class.zeroReg() || reg.is(InvalidRegClass)) +if (reg.is(In

[gem5-dev] Change in gem5/gem5[develop]: arch: Remove plumbing for operand predication.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
011 100644 --- a/src/arch/x86/isa/operands.isa +++ b/src/arch/x86/isa/operands.isa @@ -66,7 +66,7 @@ class PickedReg(IntReg): @overrideInOperand -def makeRead(self, predRead, op_idx): +def makeRead(self, op_idx): return f'{self.base_name} = pick(xc->getRegOperand(' \ f'this, {op_idx}), {self.reg_spec}, ' \ f'{self.data_size});\n' @@ -76,7 +76,7 @@ class SignedPickedReg(IntReg): @overrideInOperand -def makeRead(self, predRead, op_idx): +def makeRead(self, op_idx): return f'{self.base_name} = signedPick(xc->getRegOperand(' \ f'this, {op_idx}), {self.reg_spec}, ' \ f'{self.data_size});\n' -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49749 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-Project: public/gem5 Gerrit-Branch: develop Gerrit-Change-Id: I57e7aadb7a0d682c225f6a5fe673cba8ddf1c4f8 Gerrit-Change-Number: 49749 Gerrit-PatchSet: 1 Gerrit-Owner: Gabe Black Gerrit-MessageType: newchange ___ gem5-dev mailing list -- gem5-dev@gem5.org To unsubscribe send an email to gem5-dev-le...@gem5.org %(web_page_url)slistinfo%(cgiext)s/%(_internal_name)s

[gem5-dev] Change in gem5/gem5[develop]: cpu: Treat the InvalidRegClass like the zero register.

2021-08-31 Thread Gabe Black (Gerrit) via gem5-dev
return; DPRINTFV(reg_class.debug(), "Setting %s register %d to %#x.\n", -- To view, visit https://gem5-review.googlesource.com/c/public/gem5/+/49744 To unsubscribe, or for help writing mail filters, visit https://gem5-review.googlesource.com/settings Gerrit-

<    5   6   7   8   9   10   11   12   13   14   >