Re: submitter has left company; how to change

2015-05-22 Thread Scott Quesnelle
On my reviewboard instance, I just mark those review requests as discarded. Whoever is picking up this defect will then post a new review request with their diff. This accomplishes a few things: -keeps all the old history -is simple for me do -clear ownership of the change going forward Scott

Re: Change login page text?

2015-03-20 Thread Scott Quesnelle
Look under your reviewboard site-packages directory. reviewboard/templates/accounts File is called login.html This is the template file that is used to generate the html that is rendered. Recommend you do a quick read on django beofre editing, but its pretty self describing. Scott On Thu, Mar 1

Re: Workflow for use in programming courses, automated peer review assignment

2014-11-06 Thread Scott Quesnelle
Patric, I believe exposing students to code review is a very important skill for their future careers. Code review/reading is a skill just like code authoring, it only improves through use and education. Currently computer science is heavily skewed towards the authoring side with little to no revi

Re: e-mails not going from reviewboard

2014-02-25 Thread Scott Quesnelle
I installed postfix on the RB server and use it as a relay to the main mail server. On Feb 25, 2014 5:57 PM, "Allen" wrote: > How do you fixed this issue? I am encountering the same issue now. Thanks! > > On Wednesday, November 28, 2012 4:13:32 AM UTC-5, shaheer va wrote: >> >> I got it fixed by

Re: how do i reassign a review?

2013-07-17 Thread Scott Quesnelle
Is this the submitter that has left the company, or the reviewer? If its the submitter, then download the diff, and have the new submitter create a new review. If its a reviewer, then submitter can update the reviewers, as can the admin for the site. On 7/15/13, kegstand wrote: > How can I assi

Re: Email not getting to the users

2012-11-26 Thread Scott Quesnelle
Chuck, I had a similar issue, and my resolution was to use postfix on the ReviewBoard server as a relay. Our mail server can sometimes be slow to respond, but since it is outside the control of my group, I had no choice but to work around it. Relay setup of postfix is pretty straight forward, and

Re: Default reviewer list

2012-10-17 Thread Scott Quesnelle
u just need read-only (GET) access. > > -David > > > On Wed, Oct 17, 2012 at 9:43 AM, Scott Quesnelle > wrote: > > Hello, > > > > Just wanted to say thanks for the excellent tool. We have been using > > reviewboard for over 2 years now. One question though. We use def

Default reviewer list

2012-10-17 Thread Scott Quesnelle
Hello, Just wanted to say thanks for the excellent tool. We have been using reviewboard for over 2 years now. One question though. We use default reviewers, and associate them with review groups. This helps reduce the administration as users can join/leave groups as they see fit. We are using def

Re: Deploying reviewboard in virtualenv

2012-09-19 Thread Scott Quesnelle
We deploy our reviewboard server on a Vmware VM. Now it does have access to the internet. This is useful for downloading the various packages that are needed to do the install. It is possible to do it without, but is easier if you have access for the initial install/setup. Scott On Mon, Sep 17, 2

Re: RB archive?

2012-09-04 Thread scott . quesnelle
Why not use wget to retrieve all the reviews? The reviews are numbered sequentially, so start a 1 and go to the current number. You will the have the html representation of each of the review pages. To do this, you will need to use the cookie option on wget or curl. Scott Sent wirelessly from m

Re: Review entire file without a diff?

2012-08-21 Thread scott . quesnelle
If the file is already in the repository, the just add a single space to the start of every line. If it isn't in the repository, for cvs it is the the following two steps Cvs add the file Cvs diff -Nu Scott Sent wirelessly from my BlackBerry device on the Bell network. Envoyé sans fil par mon t

Re: New source files

2012-07-18 Thread scott . quesnelle
It depends on your SCM tool. With CVS, you do a cvs add on the new file, then cvs diff -N -u and it will include your new files in the diff. Scott Sent wirelessly from my BlackBerry device on the Bell network. Envoyé sans fil par mon terminal mobile BlackBerry sur le réseau de Bell. -Origin

Re: How to get people to close off reviews

2011-11-06 Thread Scott Quesnelle
this weekend, I'm going to work on automating "the > stick" portion. > > On Fri, Nov 4, 2011 at 3:55 PM, Scott Quesnelle > wrote: > > I personally do two things. One carrot, one stick. > > > > Stick first. I just sort reviews based on last updated time and

Re: How to get people to close off reviews

2011-11-04 Thread Scott Quesnelle
I personally do two things. One carrot, one stick. Stick first. I just sort reviews based on last updated time and look for anyone that has more then 2 or 3 reviews of more then a certain age. I then have a somewhat standard form letter that I mail them. It reminds them of the process needs of thi

Re: Reviewing diffs of large merges

2011-03-16 Thread Scott Quesnelle
Default reviewers helps with merges, the other one depending on the structure of the code is to divide the diff into multiple review requests. This allows reviewers to digest the change in a manageable piece. How you divide it would depend on the type of work, but we have done some where all the ma

Re: Finding review request id in UI

2011-02-02 Thread Scott Quesnelle
You can see the ReviewID on the dashboard if you add that column, at least in 1.0 you can. Scott On Tue, Feb 1, 2011 at 4:24 PM, Henry Yei wrote: > Hi, I'm starting to roll out ReviewBoard into our development process > and am considering forcing a valid completed reviewboard request > before a

Re: Review Request Number

2011-01-21 Thread Scott Quesnelle
James, On the dashboard, if you click the right hand column ... you can see the possible column headings that can be displayed. Review ID is one of those. We chose an alternative approach which is that we have a system by which we push 'finished' reviews back to the bug tracking system. That way

Re: Super noob question: memcached?

2010-11-17 Thread Scott Quesnelle
Admin interface, right hand side under server information should show server cache. Click it and it will show memcached stats. You should see a memcached if you do ps -ef Scott Quesnelle On Wed, Nov 17, 2010 at 4:30 PM, Ian wrote: > OK, I feel dumb even asking this, but how can I tell if

Re: keeping track of large number of files

2010-08-24 Thread Scott Quesnelle
John, This isn't a software answer, but if the changes is that large, then we encourage the author to try and split it into pieces which provide a part of the whole solution. I.e a review of the server side change, another with all the database related changes, and a last one with the client side

Re: Triggers

2010-08-20 Thread Scott Quesnelle
o long to back to you, got tied up on other stuff. > > Very nice. You modified the base code in some spot or is the review summary > generation already a part of RB 1.07? > > John > > > On Wed, Aug 18, 2010 at 2:22 PM, Scott Quesnelle < > scott.quesne...@gmail

Re: Triggers

2010-08-18 Thread Scott Quesnelle
John, I have an implementation in my deployment which generates a review summary when the review is closed, and it writes the summary to a file that is named based on the bugid(s) provided. A separate script runs and talks to the bug tracking system and updates the appropriate bug(s) with the revi

Re: Members of a review group

2010-05-26 Thread Scott Quesnelle
aybe even get something hacked up for 1.5, > but no promises there. > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Tue, May 25, 2010 at 3:15 PM, Scott Ques

Members of a review group

2010-05-25 Thread Scott Quesnelle
Hello, I am using default reviewers along with review groups for a large portion of our tree. I have had inquiry from users, that would like a way to know who is a member of a given review group, so that they can give them a prod about a review. I am running RB 1.0. Didn't see it listed in the ex

Re: SMTP support/debugging

2010-04-19 Thread Scott Quesnelle
Here is what I did with V 1.0 when I had an email issue, in reviewboard/reviews/email.py In function def send_review_mail(user, review_request, subject, in_reply_to, extra_recipients, template_name, context={}): I added the line: logging.info("Sending e-mail with subject

Re: Merging Two Separate ReviewBoard Instances

2010-04-08 Thread Scott Quesnelle
What about the possibility of having 2 instances of Reviewboard on the same server. Just have them run on separate ports and have separate databases. Then just tell users to not create new reviews in instance X? Scott On Thu, Apr 8, 2010 at 4:35 PM, David Trowbridge wrote: > Nobody has done thi

Re: Requesting ideas for Google Summer of Code

2010-03-22 Thread Scott Quesnelle
Reporting. The ability to see things like - how many review requests a given developer has open at the moment. - How many reviews and review requests a given developer has done in the last X days - Stats on review requests. Average length, Min/max. etc. We have also had the situation where with m

Re: How to make Dashboard more convinent for Reviewers

2010-03-22 Thread Scott Quesnelle
The only downside to the 'My comments' column is that it doesn't get reset if a new revision of a diff is posted. But it helps see if you have commented at all. A list of reviews that you haven't given a ship it to the current diff would be useful. Scott On Mon, Mar 22, 2010 at 12:41 AM, Christia

Re: About the "view diff" page of reviewboard

2010-01-28 Thread Scott Quesnelle
If you look into the scmtools directory you will see cvs.py All that occurs for diff viewing is the following. >From the diff, a list of files and revisions are extracted. Based on that list, a series of cvs checkouts are done look for cvs co -r in the file. It then uses the patch utility to g

Re: Unified diff view

2010-01-28 Thread Scott Quesnelle
Given that the diff that was uploaded was a unified diff, then you can just download the diff and view it on your laptop. Some of the developers here do this to supplement the side by side view. Sometimes problems are more evident when they view the proposed change in another form. The win of revie

Re: Will post-review generate ReviewRequest for CVS removed files?

2010-01-15 Thread Scott Quesnelle
The problem is the way that cvs generates the diff for removed files. It is the same as for a file which has just been added and as such they cannot checkout the file correctly. I am mulling over trying to fix this bug, by treating the file as a 'new' file since the diff shows every line removed.

Re: About BugTracker

2010-01-05 Thread Scott Quesnelle
The short answer is that you can embed a link in the review request which allows reviewers to easily read the bug. Long answer: When configuring a repository, you can include a URL that will be used to access the bug tracker. You include %s where the bugid needs to be substituted. for example htt

Re: Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-23 Thread Scott Quesnelle
; the reviewrequest process into the development process, All developers will > not find so much changes in there development process, Except that when they > received the Email of review notice, Then need to do the code review. > Best Regards! > > > 在2009-12-22,"Scott Qu

Re: About the idea of integrating the CVS and ReviewBoard into a development process

2009-12-21 Thread Scott Quesnelle
We are doing reviews prior to the changes being commited to CVS. To enforce this process, you can modify the CVS pre-commit script. This script can then check change for review approval. We currently require the bugid to be in the cvs commit log, as such we query the bug tracking system and check

Re: About the review to original edition of a file

2009-12-21 Thread Scott Quesnelle
Adding a file to CVS involves 2 steps. cvs add then cvs commit. If you do the cvs add, then generate the diff for review using 'cvs diff -u' you will end up the new file diff being included in your diff which can then be posted to reviewboard. Scott 2009/12/21 qhlonline > Hi,all. >I want

Re: How to make forcing pre-commit review

2009-12-14 Thread Scott Quesnelle
With CVS you can write pre-commit scripts. In our repository, we are required to input a valid defect ID as the first item in the commit log. CVS looks up that defect ID and checks for the results of a review request. Alternatively, you could require the developers to include the review id in the c

Re: About the relationship between ReviewBoard Server and CVS

2009-12-10 Thread Scott Quesnelle
The idea is that a diff only contains the lines that have changed. RB contacts cvs and checks out the file(s) that are changed, and then applies the diff to thos files. This allows you to see the file before and after the proposed changed. All of this is independent of the actual commit to CVS. Yo

Re: How to connect comments and changes?

2009-08-11 Thread Scott Quesnelle
Hey Philipp, When you post a comment, instead of clicking on a single line, you can click and drag over a group of lines, and then that whole set of lines shows up for extra context. We have found its useful to have that functionality since it allows the user to tailor the amount of context neces

Re: ReviewBoard Reports

2009-08-07 Thread Scott Quesnelle
ws.review-board.organd > we'll look. > > Thanks! > > Christian > > -- > Christian Hammond - chip...@chipx86.com > Review Board - http://www.review-board.org > VMware, Inc. - http://www.vmware.com > > > > On Thu, Aug 6, 2009 at 3:17 PM, Scott Quesnelle >

ReviewBoard Reports

2009-08-06 Thread Scott Quesnelle
Hello, Is anyone using the reports feature of reviewboard? I have noticed that there are a few things missing in it, and have done tidying up. I have added the period that the report covers to the title line, and also modified the template to properly deal with quotes and such. Both are minor ch

Mail features

2009-05-29 Thread Scott Quesnelle
have posted, and don't more mail that they need to filter off. This change would involved updating the accounts model, the 'My account' view and some of the code in email.py mostly get_email_address_for_user and send_review_mail Thoughts/comments always appreciat