[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Yifan Zhang (Code Review)
Yifan Zhang has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. [java] fix bug in getClosestServerInfo code When client handles

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Hello Andrew Wong, Grant Henke, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15445 to review the following change. Change subject: build-and-test.sh: fix TIDY build .. build-and-test.sh:

[kudu-CR] thread: simplify Thread::Create API

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15448 to review the following change. Change subject: thread: simplify Thread::Create API .. thread:

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15446 to review the following change. Change subject: BloomFileTestBase: refactor test fixture ..

[kudu-CR] remove kudu::Thread from tests

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15447 to review the following change. Change subject: remove kudu::Thread from tests .. remove kudu::Thread

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has removed a vote on this change. Change subject: build-and-test.sh: fix TIDY build .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15445 To unsubscribe, visit

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. build-and-test.sh: fix TIDY build The Jenkins job that runs the TIDY build

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. Patch Set 1: Verified+1 Code-Review+2 Overriding Jenkins, TSAN failure was

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-16 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15420 to look at the new patch set (#2). Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64

[kudu-CR] [ranger] validate the JAR file path for the subprocess

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15435 ) Change subject: [ranger] validate the JAR file path for the subprocess .. Patch Set 4: (1 comment)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (1 comment)

[kudu-CR] client: micro-optimizations to reduce CPU and allocations

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15439 ) Change subject: client: micro-optimizations to reduce CPU and allocations .. Patch Set 1: (5 comments)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Yifan Zhang (Code Review)
Yifan Zhang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15444 Change subject: [java] fix bug in getClosestServerInfo code .. [java] fix bug in getClosestServerInfo code When client handle tablet not

[kudu-CR] [ranger] pass 'principal' and 'keytab' to the subprocess

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15416 ) Change subject: [ranger] pass 'principal' and 'keytab' to the subprocess .. Patch Set 7: (3 comments)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 1: (1 comment)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. Patch Set 1: (1 comment)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Yifan Zhang (Code Review)
Yifan Zhang has posted comments on this change. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. Patch Set 2: (1 comment)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Yifan Zhang (Code Review)
Hello Kudu Jenkins, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15444 to look at the new patch set (#2). Change subject: [java] fix bug in getClosestServerInfo code ..

[kudu-CR] [ranger] fix incorrect authz enforcement in Ranger authz provider

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15436 ) Change subject: [ranger] fix incorrect authz enforcement in Ranger authz provider .. Patch Set 5: (2 comments)

[kudu-CR] rpc: use a lighter weight completion for sync RPCs

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15441 ) Change subject: rpc: use a lighter weight completion for sync RPCs .. Patch Set 1: (5 comments)

[kudu-CR] rpc: reduce context switches and receive calls

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15440 ) Change subject: rpc: reduce context switches and receive calls .. Patch Set 1: (1 comment)

[kudu-CR] [java] fix bug in getClosestServerInfo code

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15444 ) Change subject: [java] fix bug in getClosestServerInfo code .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (1 comment)

[kudu-CR] [ranger] parameterize the Java binary path for the subprocess

2020-03-16 Thread Attila Bukor (Code Review)
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/15415 ) Change subject: [ranger] parameterize the Java binary path for the subprocess .. Patch Set 6: (1 comment)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#3). Change subject: [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 2: (1 comment)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 1: (2 comments)

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 ) Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64 .. Patch Set 2: Verified+1 Code-Review+2 > @Grant Henke > I

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15450 Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. [util] Minor changes in BlockBloomFilter requested by

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 3: (1 comment)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (1 comment)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (2 comments)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 3: (1 comment)

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15424 to look at the new patch set (#4). Change subject: [client] Add C++ API to accept BlockBloomFilter directly

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Hello Thomas Tauber-Marshall, Kudu Jenkins, Adar Dembo, Wenzhe Zhou, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15450 to look at the new patch set (#2). Change subject: [util] Minor changes in BlockBloomFilter requested by Impala

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15438 to look at the new patch set (#4). Change subject: [subprocess] copy subprocess JAR to be next to the master binary

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 3: (2 comments)

[kudu-CR] [spark] improve log message to warn users to pass keytab/principal

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/9730 ) Change subject: [spark] improve log message to warn users to pass keytab/principal .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/9730

[kudu-CR] [hms] disable direct SQL in MiniHms

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/11198 ) Change subject: [hms] disable direct SQL in MiniHms .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/11198 To unsubscribe, visit

[kudu-CR] [spark] add 'local-cluster' mode for unit test

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has abandoned this change. ( http://gerrit.cloudera.org:8080/8585 ) Change subject: [spark] add 'local-cluster' mode for unit test .. Abandoned -- To view, visit http://gerrit.cloudera.org:8080/8585 To unsubscribe,

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 4: (2 comments)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15414 to look at the new patch set (#5). Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 5: Code-Review+1 (3 comments)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 4: Verified+1 -- To view, visit

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has removed a vote on this change. Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15438 To

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 4: Unrelated flaky tests. -- To view, visit

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 4: (1 comment) > Patch Set 4: Code-Review+1

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 4: Code-Review+2 (1 comment)

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. Patch Set 4: (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has removed a vote on this change. Change subject: [build] address compilation warnings from GCC 8.3.1 .. Removed Verified-1 by Kudu Jenkins (120) -- To view, visit http://gerrit.cloudera.org:8080/15437 To

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 2: Verified+1 Unrelated test failure in Java test

[kudu-CR] [build] Disable parallel Gradle builds in pre-commit.

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15453 ) Change subject: [build] Disable parallel Gradle builds in pre-commit. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (3 comments)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Hao Hao (Code Review)
Hello Attila Bukor, Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15414 to look at the new patch set (#6). Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized

[kudu-CR] [subprocess] copy subprocess JAR to be next to the master binary

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15438 ) Change subject: [subprocess] copy subprocess JAR to be next to the master binary .. [subprocess] copy subprocess JAR to be next to

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. BloomFileTestBase: refactor test fixture clang-tidy flags the gflag

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Bankim Bhavsar (Code Review)
Bankim Bhavsar has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: (3 comments)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Hao Hao (Code Review)
Hao Hao has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (2 comments)

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (2 comments)

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: Verified+1 (1 comment) Overriding Jenkins,

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. [util] Minor changes in BlockBloomFilter

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Removed reviewer Kudu Jenkins with the following

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (1 comment)

[kudu-CR] WIP [release notes] supported NTP servers and new time source

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15456 ) Change subject: WIP [release notes] supported NTP servers and new time source .. Patch Set 1: (4 comments)

[kudu-CR] thread: simplify Thread::Create API

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15448 to look at the new patch set (#3). Change subject: thread: simplify Thread::Create API

[kudu-CR] remove kudu::Thread from tests

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#3). Change subject: remove kudu::Thread from tests ..

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-16 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 ) Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64 .. Patch Set 2: Sure, I will add the link.

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15420 ) Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64 .. Patch Set 3: Code-Review+2 -- To view, visit

[kudu-CR] [java] fix Kudu Ranger plugin when Ranger is Kerberized

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15414 ) Change subject: [java] fix Kudu Ranger plugin when Ranger is Kerberized .. Patch Set 6: (2 comments)

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

2020-03-16 Thread Anonymous Coward (Code Review)
huangtianhua...@gmail.com has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15455 Change subject: KUDU-3068 Add atomic operations for aarch64 .. KUDU-3068 Add atomic operations for aarch64 This patch adds

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-16 Thread Hannah Nguyen (Code Review)
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/14177 to look at the new patch set (#24). Change subject: KUDU-2780: create thread for auto-rebalancing

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-16 Thread Hannah Nguyen (Code Review)
Hannah Nguyen has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 24: (4 comments)

[kudu-CR] KUDU-3072 Add glog patch to support stacktrace for aarch64

2020-03-16 Thread Anonymous Coward (Code Review)
Hello Kudu Jenkins, Adar Dembo, Grant Henke, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15420 to look at the new patch set (#3). Change subject: KUDU-3072 Add glog patch to support stacktrace for aarch64

[kudu-CR] WIP [release notes] supported NTP servers and new time source

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15456 Change subject: WIP [release notes] supported NTP servers and new time source .. WIP [release notes] supported NTP servers and new time

[kudu-CR] KUDU-3068 Add atomic operations for aarch64

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15455 ) Change subject: KUDU-3068 Add atomic operations for aarch64 .. Patch Set 1: (1 comment)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 23: (3 comments)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 23: (2 comments)

[kudu-CR] KUDU-2780: create thread for auto-rebalancing

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/14177 ) Change subject: KUDU-2780: create thread for auto-rebalancing .. Patch Set 23: (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 1: (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 1: (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15437 to look at the new patch set (#2). Change subject: [build] address compilation warnings from GCC 8.3.1

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Grant Henke (Code Review)
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/15445/2//COMMIT_MSG

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 1: Code-Review+2 (1 comment)

[kudu-CR] build-and-test.sh: fix TIDY build

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15445 ) Change subject: build-and-test.sh: fix TIDY build .. Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/15445/2//COMMIT_MSG

[kudu-CR] [client] Add C++ API to accept BlockBloomFilter directly

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15424 ) Change subject: [client] Add C++ API to accept BlockBloomFilter directly .. Patch Set 4: Code-Review+2 -- To view, visit

[kudu-CR] [util] Minor changes in BlockBloomFilter requested by Impala

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15450 ) Change subject: [util] Minor changes in BlockBloomFilter requested by Impala .. Patch Set 2: (3 comments)

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

2020-03-16 Thread Andrew Wong (Code Review)
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/15452 ) Change subject: build-and-test.sh: address follow-up feedback from Andrew .. Patch Set 1: Code-Review+2 Thanks for addressing this!

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 2: Code-Review+2 (1 comment)

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. [build] address compilation warnings from GCC 8.3.1

[kudu-CR] [build] address compilation warnings from GCC 8.3.1

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15437 ) Change subject: [build] address compilation warnings from GCC 8.3.1 .. Patch Set 1: (1 comment)

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 1: (1 comment)

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15446 to look at the new patch set (#2). Change subject: BloomFileTestBase: refactor test fixture

[kudu-CR] remove kudu::Thread from tests

2020-03-16 Thread Adar Dembo (Code Review)
Hello Alexey Serbin, Kudu Jenkins, Andrew Wong, I'd like you to reexamine a change. Please visit http://gerrit.cloudera.org:8080/15447 to look at the new patch set (#2). Change subject: remove kudu::Thread from tests ..

[kudu-CR] build-and-test.sh: address follow-up feedback from Andrew

2020-03-16 Thread Adar Dembo (Code Review)
Hello Andrew Wong, I'd like you to do a code review. Please visit http://gerrit.cloudera.org:8080/15452 to review the following change. Change subject: build-and-test.sh: address follow-up feedback from Andrew ..

[kudu-CR] [build] Disable parallel Gradle builds in pre-commit.

2020-03-16 Thread Adar Dembo (Code Review)
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/15453 ) Change subject: [build] Disable parallel Gradle builds in pre-commit. .. Patch Set 1: Code-Review+2 -- To view, visit

[kudu-CR] BloomFileTestBase: refactor test fixture

2020-03-16 Thread Alexey Serbin (Code Review)
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/15446 ) Change subject: BloomFileTestBase: refactor test fixture .. Patch Set 2: Code-Review+2 -- To view, visit

[kudu-CR] [build] Disable parallel Gradle builds in pre-commit.

2020-03-16 Thread Grant Henke (Code Review)
Grant Henke has uploaded this change for review. ( http://gerrit.cloudera.org:8080/15453 Change subject: [build] Disable parallel Gradle builds in pre-commit. .. [build] Disable parallel Gradle builds in pre-commit. I have

  1   2   >