Follow-up Comment #11, bug #16383 (project freeciv):
Would you be OK with some way of specifying in the ruleset
whether a given kind of non-native unit requires present or
merely adjacent native terrain to a city? (I haven't even begun
to think about what that might look like, but it should
to rejected at once
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
On Mon, Sep 12, 2011 at 5:10 PM, Marko Lindqvist cazf...@gmail.com wrote:
I don't have time for in-depth analysis aty the moment, but here are
some quick clarifications
Thank you. The fact that being marked as an AI and using the AI
interface is two distinct things helped a lot.
With same
On Mon, Sep 12, 2011 at 7:11 PM, Matthias Pfafferodt
matthias.pfaffer...@mapfa.de wrote:
Hello Sveinung,
Hello Matthias,
I do try at the moment to get a lua AI to work. It is not as easy as it may
look. More information, especially about the different types of AIs you can
find at the ticket:
Thank you for your feed back so far. I got some new options based on it:
I understand that in order to record I need to change the server -
either to make it record a game it self or to send the information to
something else that will record it. Would it be much work for me to
add a recording
URL:
http://gna.org/patch/?2979
Summary: Add 4 custom effects for rule set authors to use
via Lua
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 30 Sep 2011 01:46:30 PM GMT
Category: None
Hi,
Is it correct to assume that a type alias must be defined before it's
used? Is my understanding of the documentation correct if I interpret
it to say that it's OK to directly use a basic type (instead of a type
alias) in a field in a packet? I've found no basic type use in packets
and no type
URL:
http://gna.org/patch/?3080
Summary: Remove unused field types from packets.def
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 02 Jan 2012 01:06:12 AM GMT
Category: None
Priority: 5 -
/srv_main_gen.c
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
URL:
http://gna.org/patch/?3345
Summary: View units in foreign cities
Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 26 Jun 2012 10:44:01 PM GMT
Category: None
Priority: 5 - Normal
URL:
http://gna.org/bugs/?19868
Summary: Network protocol documentation
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 29 Jun 2012 09:02:23 AM GMT
Category: None
Severity: 1 - Wish
Follow-up Comment #1, patch #3345 (project freeciv):
Rename and base on current trunk.
(file #15924)
___
Additional Item Attachment:
File name: see_city_units.patch Size:1 KB
Follow-up Comment #3, patch #3345 (project freeciv):
Thank you for the tip. I'll send an updated patch after I have tested it.
___
Reply to this item at:
http://gna.org/patch/?3345
___
Follow-up Comment #6, patch #3345 (project freeciv):
Good catch. I looked at the compilation output again and found the mentioned
warning now. I overlooked it among the information from make, translations,
etc. (I don't have much experience concerning developing in C.) Seems like I
(re)read the
Follow-up Comment #7, patch #3015 (project freeciv):
How about using a term like cultural identity? Rules ranging from no
assimilation at all to quick assimilation can all use that term without
becoming unrealistic.
___
Reply to this item
Follow-up Comment #8, patch #3345 (project freeciv):
New version. Tests:
* Compiles using ./autogen.sh --enable-debug make
* Auto game when map and game seed is the same (the effect isn't active):
same as trunk (except time)
* Auto game when map and game seed is the same (the effect is active
Follow-up Comment #9, patch #3345 (project freeciv):
Found a bug in my patch (unless its a consequence of me using the editor to
test various scenarios): after invading a city containing a wonder granting
this effect foreign cities not under fog of war at the time of the invasion
appear empty.
Follow-up Comment #2, bug #19868 (project freeciv):
On Thu, Jul 5, 2012 at 6:38 PM, Marko Lindqvist wrote:
Can you send your current patch as an reference what kind of results we are
talking here?
Hopefully the patch will get uploaded to Gna for real this time. This is the
patch that I
On Thu, Jul 5, 2012 at 10:38 PM, Gilles J. Seguin se...@videotron.ca wrote:
* Some recursive dependencies are ignored
what is recursive ? nothing
can you provide examples.
My mistake. Should have been transitive dependencies. (Dependency of dependency)
While the generated Java code
therefore can't
tell if this is a side effect of my configuration or a bug triggered
by it.
--
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
Follow-up Comment #1, patch #3675 (project freeciv):
Had a look. Setting the rivers to non pillageable was forgotten.
PS! Thanks for publishing this patch and therefore making it less time
consuming to try river as road before it's done
URL:
http://gna.org/patch/?3698
Summary: Corrections to docs/README.delta
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 13 Feb 2013 12:24:59 PM GMT
Category: None
Priority: 5 - Normal
Follow-up Comment #1, patch #3698 (project freeciv):
The values of the unchanged fields will be filled in from an old version at
the receiving side. could use a clarification. I had a look at the generated
code when delta is enabled. If it is as simple as it appears, and keys etc
aren't taken
Follow-up Comment #3, patch #3698 (project freeciv):
Maybe further clarifications would be welcome to determine how those bytes
are used.
Good idea. I added (See HACKING to learn how to understand the packet
header) (avoids duplication) to the attached update.
Also, I proposed a change in the
Follow-up Comment #4, patch #3698 (project freeciv):
My new understanding: Packets without a key will use the previous packet of
the same kind. Packets with one key will use the previous packet of the same
kind that had the same key. Packets with two keys will use the previous packet
of the same
Follow-up Comment #6, patch #3698 (project freeciv):
Thank you for your help, Per. I have attached a new version adding the
following explanation: The old version filled in from is the previous packet
of the same kind that has the same value in each key field. (If the packet's
kind don't have any
Follow-up Comment #4, bug #19868 (project freeciv):
Could you update this patch against current trunk and avoid usage of
C++-style comments //?
Yes. No C++-style comments. As the editing of text currently is done manually
I want to be sure I don't do it wrong: Should I merge the information
Follow-up Comment #6, bug #19868 (project freeciv):
Attached is a version of the patch updated to svn trunk revision 22384 and a
file containing the data it is based on.
Should a multi line comment end in a blank line ( * last linen */)? Should
comments I only change a part of be updated to the
Follow-up Comment #7, bug #19868 (project freeciv):
Warning: The attached patch breaks building when delta and bool folding is
turned off.
I suspect #define NAME VALUE /* start of commentn * next line */ may be
involved (if NAME is replaced using VALUE /* start of comment but not the
line that
Follow-up Comment #9, bug #19868 (project freeciv):
False alarm. Turns out that unless delta is enabled building using Werror will
fail no matter if the patch is applied or not.
___
Reply to this item at:
http://gna.org/bugs/?19868
Follow-up Comment #10, bug #19868 (project freeciv):
I would suggest for multi-line comment to move the comment before the
macro.
Thank you for your suggestion. I had to rework the original comments a bit
since they now are above and need context.
(file #17275)
150 effort and doing it locally cost 100
effort but someone else is willing to do 50% of it if its done in
Freeciv you will still save effort by doing it in Freeciv.
--
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
URL:
http://gna.org/bugs/?20666
Summary: Disaster flood requires river special
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 27 Mar 2013 02:03:51 PM GMT
Category: None
Severity: 3 - Normal
Follow-up Comment #1, bug #20666 (project freeciv):
Updated patch because of changes to trunk
(file #17710)
___
Additional Item Attachment:
File name: floodRoad.patchSize:0 KB
it.
--
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv-dev mailing list
Freeciv-dev@gna.org
https://mail.gna.org/listinfo/freeciv-dev
it is uploaded fixing the 2.4
issues will hopefully make it accessible to those that don't want to
compile Freeciv them self.
* that I'll keep secret for now as there are enough vaporware out there already
--
Sincerely
Sveinung Kvilhaugsvik
___
Freeciv
On 4/30/13, Sveinung Kvilhaugsvik sveinun...@users.sourceforge.net wrote:
A source
tarball containing the source code of Freeciv and the source code of
my system is coming. I just want to fix some issues I imagine may
scare testers away for good first. After it is uploaded fixing the 2.4
URL:
http://gna.org/bugs/?20781
Summary: Freeciv server segmentation fault on amd64
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 03 May 2013 06:17:09 PM GMT
Category: None
Severity: 3 - Normal
Follow-up Comment #1, bug #20781 (project freeciv):
and by the email I just sent I mean
http://marc.info/?l=freeciv-devm=136760487023896w=2
___
Reply to this item at:
http://gna.org/bugs/?20781
Follow-up Comment #2, bug #20781 (project freeciv):
I did some more testing. The bug is a lot more general than I believed. It can
be reproduced by connecting two gtk2 Freeciv clients to the same local server,
click observe in one client and pressing start in the other.
URL:
http://gna.org/patch/?3911
Summary: Improve protocol documentation
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 13 May 2013 11:10:23 PM GMT
Category: None
Priority: 5 - Normal
server (by using /quit) before
disconnecting the last client the recorder may not exit.
* The capability support is limited. Programs that understand the
packets, like inspectTrace, will error out on variants. The recorder
don't understand anything by default.
--
Sincerely
Sveinung Kvilhaugsvik
On Thu, May 16, 2013 at 8:21 AM, Chaitanya Sharma gopi.dai...@gmail.com wrote:
Hi Everyone,
Hi Chaitanya,
I'm new to the freeciv development community., and just began setting up the
dev environment for freeciv web on my local box here.
Can someone point me to the bug tracker, that I can
Follow-up Comment #3, bug #20837 (project freeciv):
Seems like the issue in bug #20781 (Marko's patch solves it)
___
Reply to this item at:
http://gna.org/bugs/?20837
___
Message sent
a time out during a game but don't record time
information the recording will be useless.
* The Windows implementation of the Freeciv hack protocol may use a
different location than Freeciv use on some set ups.
--
Sincerely
Sveinung Kvilhaugsvik
URL:
http://gna.org/patch/?3966
Summary: documentation: Terrain flags aren't unit type flags
Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 02 Jul 2013 02:24:46 PM GMT
Category: None
Priority: 5
URL:
http://gna.org/patch/?3974
Summary: Replace terrain.ruleset's
(pollution|fallout)_(food|shield|trade)_penalty with yet another output effect
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 05 Jul 2013 06:45:01 PM GMT
Follow-up Comment #2, patch #3974 (project freeciv):
On the contrary, this is needed as part of generic extras to get rid of the
way pollution is hardcoded to be S_POLLUTION S_FALLOUT.
Good. I hoped that would be the case.
I saw only one coding style issue: output was declared in the middle
URL:
http://gna.org/bugs/?20952
Summary: asserion failed in aidata.c's dai_plr_data_get()
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 08 Jul 2013 03:41:33 PM GMT
Category: None
Severity: 3 -
Follow-up Comment #2, patch #3976 (project freeciv):
Unfortunately we cannot obsolete the effects either. As we cannot have OR
requirements in extra requirement list, one cannot make irrigation possible
from nearby Ocean OR River OR Irrigation.
Possible solution: Separate the action of building
Follow-up Comment #5, patch #3976 (project freeciv):
Isn't current model (that has the problem of being somewhat overlapping)
about just what you propose.
Yes. It is a generalization of it. Only some extras have an effect. There is
an Irrig_Possible but no Maglev_Possible. What I suggest is
Follow-up Comment #1, patch #4004 (project freeciv):
I wonder if we could tie that actions stuff to causes I've partly
implemented.
One possibility is to have all actions cause EC_PLAYER_ACTION. Another is to
make player actions a subset of causes.
URL:
http://gna.org/patch/?4042
Summary: Improve Output_Tile_Punish_Pct documentation
Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 25 Jul 2013 06:23:27 PM GMT
Category: None
Priority: 5 -
URL:
http://gna.org/patch/?4051
Summary: Diplomatic relation requirement type
Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 30 Jul 2013 06:43:22 PM GMT
Category: None
Priority: 5 - Normal
URL:
http://gna.org/patch/?4053
Summary: Use SPECENUM_COUNT for EFT_LAST
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 31 Jul 2013 11:29:29 PM GMT
Category: None
Priority: 5 - Normal
Follow-up Comment #2, patch #4004 (project freeciv):
A suggested approach. It separates the concept action from the concept
action enabler. An action is something a player can do. Examples of actions
include building a road, building a rail road and inciting a city to revolt.
It may be random if
URL:
http://gna.org/patch/?4077
Summary: action enablers + move the Spy unit flag
requirement for the spy actions Poison city and Sabotage unit
Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 08 Aug 2013 07:45:19 PM GMT
URL:
http://gna.org/patch/?4078
Summary: read the action enablers from the rule set (and send
them to the client)
Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 08 Aug 2013 07:51:04 PM GMT
Category: None
URL:
http://gna.org/patch/?4079
Summary: Minimum size requirement of Poison city to action
enablers
Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 08 Aug 2013 07:53:36 PM GMT
Category: None
Follow-up Comment #4, patch #4004 (project freeciv):
As for the rest, I want to see some code before judging the design for
performance etc.
A snapshot of my progress is found in patch #4077, patch #4078 and patch
#4079. Please let me know if it still is to early to judge.
Follow-up Comment #1, patch #4077 (project freeciv):
Forgot to mention: the changes to the Xaw isn't tested as it compiles but
won't start (no matter if this patch is applied or not).
___
Reply to this item at:
URL:
http://gna.org/bugs/?21011
Summary: Xaw compiles but won't start
Project: Freeciv
Submitted by: sveinung
Submitted on: Thu 08 Aug 2013 08:40:19 PM GMT
Category: None
Severity: 3 - Normal
Follow-up Comment #3, patch #4077 (project freeciv):
Actually, our commit rules wouldn't require us to make changes to secondary
clients even to keep them compiling.
Is untested code preferred over ignoring the secondary clients?
___
Follow-up Comment #1, patch #4051 (project freeciv):
No longer just a request for comments. Applies on top of trunk SVN revision
23201. Among the changes are the addition of the relation real embassy
(to/from) and renaming of the requirement type from DiplRelation to DiplRel.
(file #18674)
Follow-up Comment #1, patch #4078 (project freeciv):
Updated to apply on top of trunk svn revision 16510 and patch #4077.
(file #18675)
___
Additional Item Attachment:
File name: action_enablers_ruleset_2.patch Size:19 KB
Follow-up Comment #3, patch #4051 (project freeciv):
DRA_RECIEVES_SHARED_VISION - recEIves
Thank you. Fixed.
Can diplstate_type_by_name() return DS_LAST?
No. It is pure paranoia about what someone may change in the future. Changed
to an assert for now. The code that follow it is also pure
Follow-up Comment #4, patch #4051 (project freeciv):
Forgot to change the name in README.effects
(file #18677)
___
Additional Item Attachment:
File name: diplrel.patch Size:17 KB
URL:
http://gna.org/patch/?4091
Summary: Add a local range to diplomatic relation requirement
type
Project: Freeciv
Submitted by: sveinung
Submitted on: Wed 14 Aug 2013 08:24:09 PM GMT
Category: None
Follow-up Comment #6, patch #4051 (project freeciv):
Assuming this one goes in, I will be requesting follow-up patch to make
diplstate_text() to use names of the states from the diplstate_type specenum
instead of defining (identical) strings itself.
Just to be clear before I start writing it: Do
Follow-up Comment #6, patch #4004 (project freeciv):
I'll go through your patches within a week (sorry for the delay, but I have
limited time) for at least commenting them.
Great. Hints when you read them:
* As there currently only are two supported actions I have left them in an
enum for now.
Follow-up Comment #1, patch #4091 (project freeciv):
update to new version of patch #4051.
(file #18684)
___
Additional Item Attachment:
File name: diplrel_local.patchSize:29 KB
Follow-up Comment #8, patch #4051 (project freeciv):
In our naming conventions, is for boolean functions is usually placed in
the beginning. is_diplrel_between() and is_diplrel_to_other().
Changed.
(file #18687)
___
Additional Item
Follow-up Comment #2, patch #4091 (project freeciv):
update to new version of patch #4051.
(file #18688)
___
Additional Item Attachment:
File name: diplrel_local.patchSize:29 KB
Follow-up Comment #2, patch #4079 (project freeciv):
Thank you. Fixed.
(file #18696)
___
Additional Item Attachment:
File name: poison_size_req.patch Size:11 KB
___
Reply
Follow-up Comment #2, bug #21011 (project freeciv):
I realized I didn't have to test Xaw so I didn't investigate this bug more.
Sorry about that.
Have you tested that?
Yes. It didn't work.
You don't have suitable font in your system?
That was the case. I tried adding a lot of xfonts.
Follow-up Comment #7, patch #4077 (project freeciv):
Read the pathc, not tested yet.
Thank you for your reviews. (I see that I need to work more on my ability to
spot spelling mistakes and style mistakes)
Looks promising
I'm glad to hear it.
I found some nitpicking
I probably won't be able
Follow-up Comment #1, bug #21037 (project freeciv):
But meeting dialog did not open once I had /taken the AI.
Did you turn of AI mode after you took it?
___
Reply to this item at:
http://gna.org/bugs/?21037
URL:
http://gna.org/patch/?4097
Summary: Kill diplstate_text(), use diplstate_type_name()
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 19 Aug 2013 02:17:45 PM GMT
Category: None
Priority: 5 -
URL:
http://gna.org/patch/?4098
Summary: Rename Xaw's actions.(c|h)
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 19 Aug 2013 03:55:57 PM GMT
Category: None
Priority: 5 - Normal
Follow-up Comment #8, patch #4077 (project freeciv):
Address review comments.
(file #18713)
___
Additional Item Attachment:
File name: action_enablers.patch Size:46 KB
___
Follow-up Comment #2, patch #4078 (project freeciv):
Update to apply on top of patch #4077
(file #18714)
___
Additional Item Attachment:
File name: action_enablers_ruleset.patch Size:19 KB
Follow-up Comment #3, patch #4079 (project freeciv):
Update to apply on top of patch #4078
(file #18715)
___
Additional Item Attachment:
File name: poison_size_req.patch Size:11 KB
Follow-up Comment #9, patch #4077 (project freeciv):
I just uploaded the wrong patch. Here is the correct one.
(file #18716)
___
Additional Item Attachment:
File name: action_enablers.patch Size:28 KB
Follow-up Comment #10, patch #4077 (project freeciv):
Update to compile on top of current SVN.
(file #18719)
___
Additional Item Attachment:
File name: action_enablers_base.patch Size:28 KB
Follow-up Comment #2, patch #4098 (project freeciv):
You should change also multiple-inclusion-guard on xaw_actions.h.
Thank you. Fixed.
(file #18720)
___
Additional Item Attachment:
File name: xawActionsRename.patch Size:1 KB
Follow-up Comment #8, bug #20886 (project freeciv):
Attached patch is 100% rule set based. It is primarily intended as a
contribution to the discussion.
* Transfer of ownership to border owner isn't addressed. (It may be possible
to create an effect or requirement vector on the extra to trigger
URL:
http://gna.org/patch/?4100
Summary: Move the war requirement for spy actions to rule set
Project: Freeciv
Submitted by: sveinung
Submitted on: Tue 20 Aug 2013 09:11:54 PM GMT
Category: None
Priority:
Follow-up Comment #1, patch #3412 (project freeciv):
Implemented in attached patch. Possible issues:
The AI code is currently protected behind experimental. There are two reasons
for this. The first is to make it easy to test that auto games (not involving
the experimental AI) have the same
Follow-up Comment #3, patch #3412 (project freeciv):
Thanks for the information, Marko. Removed experimental guard. Halved in
value.
(file #18728)
___
Additional Item Attachment:
File name: unit_bribe_cost.patch Size:9 KB
Follow-up Comment #3, patch #4078 (project freeciv):
Add comment
(file #18735)
___
Additional Item Attachment:
File name: action_enablers_ruleset.patch Size:20 KB
___
Reply to
Follow-up Comment #1, patch #4100 (project freeciv):
Letting rule set authors permit sabotage of allied units could be done with
a lot of extra effort.
Do the extra effort, but only for the gtk clients.
(file #18736)
___
Additional Item
Follow-up Comment #1, patch #4103 (project freeciv):
Had a look. In extras.h' extra_flag_id: Tile with this road is considered
native road - extra
So now it's possible that irrigation etc make tile native for a unit.
Being able to do this for pollution opens some interesting possibilities.
Follow-up Comment #2, patch #4100 (project freeciv):
* Added support for the qt client, the sdl client and (untested) support for
the sdl2 client.
* Change capability string since new data is put in the value field on
DIPLOMAT_MOVE. (Wondering if I in stead should add a new field)
(file
URL:
http://gna.org/patch/?4104
Summary: Don't hard code pollution/fallout specials for
global warming/cooling
Project: Freeciv
Submitted by: sveinung
Submitted on: Fri 23 Aug 2013 03:18:14 PM GMT
Category: None
Follow-up Comment #1, patch #4106 (project freeciv):
Did you intentionally leave out the rule set changes (to avoid the noise)?
___
Reply to this item at:
http://gna.org/patch/?4106
___
Follow-up Comment #10, bug #20886 (project freeciv):
There's also the question if whatever limitations we implement should apply
to beginning of the building, finishing of the building, or both.
I see that tech loss and terrain change (caused by climate change) will check
if unit activities can
URL:
http://gna.org/bugs/?21064
Summary: Default AI checks for No_Incite when bribing a unit
Project: Freeciv
Submitted by: sveinung
Submitted on: Sun 25 Aug 2013 08:34:10 PM GMT
Category: None
Severity: 3
Follow-up Comment #5, patch #4078 (project freeciv):
Remove action enabler requirements that aren't moved to the rule set yet.
(file #18764)
___
Additional Item Attachment:
File name: action_enablers_ruleset.patch Size:18 KB
Follow-up Comment #3, patch #4100 (project freeciv):
Based on the new patch #4079
* Add xaw client support (only compile tested)
* Clean up a bit
(file #18766)
___
Additional Item Attachment:
File name: spy_actions_diplrel.patch
URL:
http://gna.org/patch/?4107
Summary: Add detailed documentation for requirement type
DiplRel
Project: Freeciv
Submitted by: sveinung
Submitted on: Mon 26 Aug 2013 08:43:28 PM GMT
Category: None
1 - 100 of 3648 matches
Mail list logo
