API for submission description
Is there an API available to retrieve the 'Describe the submission (optional)' field in submitted reviews? I couldn't find it anywhere in the API documentation. Also, I'm not sure if this is a bug or feature, but it appears that this field is distinct depending upon whether you are viewing the review or diff. Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
Ah, I suspected that it might be in the database. Thanks, Dan On May 11, 2:54 pm, Christian Hammond chip...@chipx86.com wrote: It fixes all future ones going forward. We need to reset the broken 1.6 beta 1 counts, which I'm still trying to figure out the best way to do. It'll happen by the next beta, unless there's some emergency that forces us to put the beta out sooner than planned. We have a Review Board instance with negative counts too. I'm keeping it that way as a reminder :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, May 11, 2011 at 10:59 AM, Dan Savilonis d...@n-cube.org wrote: Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp:// www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp:// groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New RB API - GSoC project
Hi Alexander, I read your proposal and I found it to be a bit vague. After I searched for your previous proposal message, I found you were discussing a new version of post-review, so I assume that that is still within the scope of this project? When you talk about new commands, can you cite some examples of currently-lacking functionality? While it's good to improve the internals of Review Board, I think it's most important to provide an improved experience for users. What will the new API allow that post-review doesn't now? Something like a GUI interface, while convenient (to some), doesn't provide a lot of value if it doesn't enhance the process for submitting and maintaining code reviews. So, I'd be most interested in hearing some specific examples of how the functionality will be improved, not just the interfaces themselves. Please do commit your changes as they are in progress to your own repository or branch. There is no harm in doing this, but every benefit for people to see the progress being made before it is finished. Dan On Apr 26, 2:41 am, Alexander Solovets asolov...@gmail.com wrote: Hello, Review Board members! My name is Alexander and I will work on my project about enhancing RB API during GSoC'11. You may look through my proposal on GSoC official site. So far I had conversation only with Christian Hammond and would like to meet with the rest team. I already have a humble experience in contributing to the open-source projects and I know that each of them has its own mini-culture, so I'd like to know yours. I've already read Getting started wiki section and wondering whether you have some sort of informal guidelines about coding style, commit messages, etc. It was unusual that nobody comment my proposal during the application review period. So I greatly appreciate if you do it now (of course if there is something to say). Also I'd like to hear your wishes about the final result. At last, I should know how can I present my work. I can either work with cloned repo and post the changes from time to time or commit directly to main repo. Thank you all for chosen me and for such exciting opportunity to work with you! Review Board rocks! -- Sincerely, Alexander -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Using post-review in git's bare repository
Hi Jan, The intent of the post-review default behavior is to attempt to automatically produce a diff of the user's current work. So, it will look for commits not merged into the tracking branch for the current branch. For a bare repository, this no longer makes sense. I would think only the explicit revision range option would make sense in this context. There is no need for a working copy to perform a git on arbitrary revisions in git. However, if you just type git diff, you'll get an error because it will try to perform a diff on the working copy (which doesn't exist). For example: Doesn't work: $ git clone https://github.com/reviewboard/reviewboard.git; cd reviewboard.git $ git diff Works: $ git clone https://github.com/reviewboard/reviewboard.git; cd reviewboard.git $ git diff HEAD^..HEAD Dan On Mar 25, 2:20 am, Christian Hammond chip...@chipx86.com wrote: Really? I'm curious about this because I couldn't even generate a diff in a bare repository, and from a google search, it seemed other people were also under the impression that you needed an actual checkout. If it can be made to work, I'm definitely all for including it. That'd be much better than needing a full checkout. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Mar 24, 2011 at 11:08 PM, Jan Koprowski jan.koprow...@gmail.comwrote: Isn't true. I already wrote little (3 lines?) patch which allow generate diffs for parent branch from bare-repo but I want to test it in fire of war before I send code to review. Everything looks good so it is possible. Will be good in future if post-review will be tested and modified to work also with bare-repositories. This will allow to use post-review inside git hooks on central repo. Regards, On Thu, Mar 24, 2011 at 9:25 PM, Christian Hammond chip...@chipx86.com wrote: Hi Jan, post-review needs to generate diffs from code in the tree. If it's a bare tree, there's not really much to generate. It doesn't have the objects for which to generate those diffs. If you try to run 'git diff', I think you'll hit the same problems. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Mar 23, 2011 at 10:05 AM, Jan Koprowski jan.koprow...@gmail.com wrote: Hi! Because I must figure out how use post-review with git bare repositories I start working on it. Running post-review inside bare-repository ands with: $post-review -n -d --parent b --serverhttp://localhost:8080/ svn info git rev-parse --git-dir git symbolic-ref -q HEAD Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] fatal: Not a git repository (or any of the parent directories): .git But strange thing is I can run git symbolic-ref -q HEAD without error. $git symbolic-ref -q HEAD refs/heads/master Any ideas? Regards, Jan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: AD authentication w/SSPI NTLM integration
This is not implemented. However, Django supports this kind of authentication, so I imagine you could add support for it. Looking at the docs, it seems really simple, though I've never found anything with single-sign-on to be simple... http://docs.djangoproject.com/en/dev/howto/auth-remote-user/ Dan On Oct 13, 1:00 pm, Ian Battersby ian.batter...@gmail.com wrote: Hi all, We're running ReviewBoard 1.5 and have AD authentication working via the Python ldap module but wondered if there might be a way to authenticate the user via NTLM and Apache so they don't have to log in at all? I've installed the SSPI module for Apache 2.2 and added the relevant lines to httpd.conf but it doesn't appear that ReviewBoard is picking this up and carrying it through login. Is this not yet support or have I missed something? If anyone else has this working I'd be grateful to know what SSPI settings you have in httpd.conf. Many thanks :) Ian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review diff upload error on windows XP
Is your server running Linux? I've only tested Clearcase support using
a Windows RB server. Take a look at line 83 of clearcase.py:
http://github.com/reviewboard/reviewboard/blob/master/reviewboard/scmtools/clearcase.py
You're likely going to need to do some editing here. I don't know
anything about how Clearcase works on Linux, but I'm guessing the
assumption that all vobs are mounted under vobs/ might not be true...
Dan
On Aug 10, 6:47 am, Chetan chetan@gmail.com wrote:
As suggested by you i enabled logging to debug clearcase error. I
given the log information when i execute post-review for clearcase
below.
###
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 1070
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-08-10 03:39:32,065 - ERROR - Error uploading new diff: substring
not found
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/reviews/forms.py, line 234, in create
history)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 149, in _process
_files
not tool.file_exists(filename, revision))):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 45, in get_fil
e
return self.client.cat_file(self.adjust_path(path), revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 83, in adjust_
path
elem_path = elem_path[elem_path.rindex(vobs/)+5:]
ValueError: substring not found
###
On Aug 10, 11:15 am, Chetan chetan@gmail.com wrote:
I wanted execute svn diff recursively but found could not generate
one. But now I found if i run svn diff from the svn root directory it
handles all changes recursively.
On Aug 9, 12:24 pm, Christian Hammond chip...@chipx86.com wrote:
I'm not sure what you mean exactly. Is it not generating a diff with all
files recursively, or is there some reason why doing it recursively isn't
good enough?...
read more »
Are you using the post-review tool?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 9, 2010 at 12:21 AM, Chetan chetan@gmail.com wrote:
I got reviewboard working for subversion including https.
In svn diff we cannot generate recursive diff coz of which we may have
to generate folder specific diffs. Is there a way around this?
Thanks for the support.
On Aug 5, 11:55 am, Christian Hammond chip...@chipx86.com wrote:
As long as you have the $sitedir/data directory writable by the web
server's
user, you should be able to get https working. If you already had the
repository entry in there from RB 1.0.x, go back to that repository
and
save
it again. It should attempt to verify the certificate and then ask you
for
confirmation. If that data directory is writable, it will store it
there
and
it should just work from then on
read more »
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 4, 2010 at 10:28 PM, Chetan chetan@gmail.com wrote:
Thank a ton.
Review board with svn is working for me. svn project is using just
local protocol authentication like svn://prj and not on https. I
still
get errors for https projects.
What are the steps to configure reviewboard to use with https
configured svn projects?
Once i have completed svn configiration will start to work on
clearcase issue.
You asked me to enable logging to debug clearcase issue, wer shud i
enable it. Is it the same one under reviewboard- settinges-
logging -
enable logging option?
On Aug 4, 9:33 am, Christian Hammond chip...@chipx86.com wrote:
You'll need to use svn diff. TortoiseSVN's diffs aren't
compatible
read more »
I strongly recommend using our post-review tool (part of RBTools)
Re: Post-commit review with Bazaar branches
There's no amount of options that will help you here since there's no support in post-review for bazaar at all :) If you're interested in adding support, you could start by making a copy of the MercurialClient in postreview.py. Bazaar ought to be extremely similar. Does uploading a diff via the web work correctly for Bazaar (I haven't tested Bazaar support)? You'll want to make sure that's in good shape before starting down this road. Dan On Aug 16, 4:47 am, Gustavo Narea gna...@tech.2degreesnetwork.com wrote: Anyone? :/ On Aug 11, 5:14 pm, Gustavo Narea gna...@tech.2degreesnetwork.com wrote: Hello, How can I use post-review with Bazaar? I know it's not supported out- of-the-box [1], but is there anything I could to to create review requests automatically for a Bazaar branch? I have tried the following: $ bzr diff -r 2037..2036 /tmp/2037-2036.diff $ /srv/dev/review-board/virtualenv/bin/post-review --diff-filename=/ tmp/2037-2036.diff --server=https://dev.example.org/reviews/-d-- repository-url=/srv/repositories/twod/trunk svn info /srv/repositories/twod/trunk git rev-parse --git-dir hg root No supported repository could be access at the supplied url. Should I pass more options so that it won't complaint? I didn't find the answer with --help. Basically, I just want to send review requests for every revision and I don't mind having to pass many arguments to post-review because of the lack of Bazaar support. Thanks in advance. [1]http://code.google.com/p/reviewboard/issues/detail?id=773 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review with clearcase
Can you check the mailing lists and reviews.reviewboard.org? This
sounds like something that came up before. Unfortunately post-review
and Clearcase support are not in particularly good shape in the
released version. It really needs to have some newer patches merged in
to get things working more sensibly.
Dan
On Aug 9, 11:06 am, Shambhu shambhu.1...@gmail.com wrote:
Hi,
After making some minor modification to resolve below error,
post-review script is able to proceed further. But now it hangs at
diff upload. It is not showing any error or warning. I tried to upload
diff generated by post-review through webui, but it hangs there also
without any error msg, it just shows 'Loading' and nothing happens.
Here is the debug message where it stucks:
Looking for 'reviewboard.test.com /' cookie in C:\Documents and
Settings\shambhu\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on K for None
HTTP POSTing
tohttp://bnrpcwl0203.bnr.st.com/api/json/reviewrequests/new/:{'repository_path':
'K'}
Review request created
Uploading diff, size: 620
HTTP POSTing
tohttp://bnrpcwl0203.bnr.st.com/api/json/reviewrequests/16/diff/new/:{'basedir':
'K'}
And nothing happens after this. I checked server log and there also
nothing is mentioned. Here it is:
20:23:53 DEBUG DiffParser.parse: Beginning parse of diff, size =
621
20:23:53 DEBUG DiffParser.parse: Finished parsing diff.
20:24:41 DEBUG DiffParser.parse: Beginning parse of diff, size = 620
20:24:41 DEBUG DiffParser.parse: Finished parsing diff.
I didn't find any error or info in apache log also. Just to verify
whether i have correct directory permission of media directory, i
tried to upload screenshot, and that worked fine.
Please suggest how to fix this and let me know if more info needed. I
think i am just one step away from using it, and it annoying me. :(
Regards,
Shambhu.
On Aug 9, 12:41 pm, Shambhu shambhu.1...@gmail.com wrote:
Hi,
After checking with python-list i found that i was
misinterpreting the output error message. The actual problem is post-
review script is not able to access file c:\docume~1\shambhu
\locals~1\temp\4e0c6ccee4b4ee199cc18529c0bbf8c4 if this file is
already present if there is failure in previous run.
Now i am stuck again in function do_diff in post-review script. Here
is piece of code:
for filenam in (onam, mnam) :
if cpath.exists(filenam) and self.viewtype ==
dynamic:
debug(Dynamic view Type)
do_rem = False
fn = filenam
elif len(filenam) 254 or self.viewtype ==
snapshot:
debug(Snapshot View Type)
fn = self.get_filename_hash(filenam)
debug(FileName_Hash: %s % fn)
fn = cpath.join(tempfile.gettempdir(), fn)
debug(TempFileTempdir: %s % fn)
do_rem = True
fd = open(cpath.normpath(fn))
fdata = fd.readlines()
fd.close()
file_data.append(fdata)
# If the file was temp, it should be removed.
if do_rem:
os.remove(filenam)
Here i am getting error at last line os.remove(filenam), because
filenam contains version extended path name and hence it is not able
to access/remove windows command.
WindowsError: [Error 206] The filename or extension is too long: 'K:\
\SHAMBHU_XXX\\YY\\@@\\main\\2\\abcabcabc\\@@\\main\
\abcabcabc\\abcabcabc_r1\\xyzxyz\\1\\hello\\@@\\main\\abcabcabc\
\abcabcabc_r1\\xyzxyz\\1\\hello.c@@\\@@\\main\\abcabcabc\\abcabcabc_r1\
\xyzxyz\\xyzxyzxyz_1\\0'
Regards,
Shambhu.
On Aug 7, 3:43 pm, Shambhu shambhu.1...@gmail.com wrote:
Hi,
This time I tried post-review with checkedout file. I ran
command $post-review -d checkedout_Filename
But even with checkedout file it is failing. Here is trace log:
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.2.1alpha0.dev', 'console_scripts',
'post-review')()
File build\bdist.win32\egg\rbtools\postreview.py, line 2993, in
main
File build\bdist.win32\egg\rbtools\postreview.py, line 1041, in
diff
File build\bdist.win32\egg\rbtools\postreview.py, line 999, in
get_extended_namespace
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\shambhu\
\locals~1\\temp\\4e0c6ccee4b4ee199cc18529c0bbf8c4'
After looking into postreview.py, i found that it is failing at
os.unlink(tf) line. While executing os.unlink(tf), it is adding
additional backslash \ with the pathname and which is causing the
problem. I am able to access file 'c:\docume~1\shambhu\locals~1\temp
Re: Help with git configuration
Hi Yang, This actually brings up a good point. I don't think there currently is a 'better' solution. I hope Christian can perhaps chime in on this, since RB is using git itself. The conventional way to set this up is to configure the mirror url, but this assumes that the client fetch from a remote with the exact same path. This doesn't work well for a number of reasons since it might not even be cloned from the same server, or it might use implicit vs explicit ssh notation, or use a non-fqdn, etc. I think we need to address this somehow. On the post-review side, my thought was to add an option for .reviewboardrc to specify the 'repository url'. However, there clearly should be some improvement on the server side as well, as a fixed 'mirror' field just isn't good enough to comprehensively match a repository. Any thoughts on what we could do there? As for your second problem, post-review requires a non-bare repository as it tries to automatically determine the diff of your current work. You may want to try the revision-range option to explicitly set the revision range. I haven't confirmed that this will work in a bare repository, but it should be easy to make it if it doesn't. Dan On Aug 6, 5:48 pm, Yang Zhang yanghates...@gmail.com wrote: I'm trying to automate post-review to run on a git repository -- ideally on each commit (on the client side), but on each push (on the central repo) would do too if necessary. In both the following I ran git config reviewboard.urlhttps://dev/review/;. First I tried post-review on a client repo (also tried specifying --repository-url=/var/git/web.git, which is the local URL that the reviewboard web app knows): ~~~ $ post-review --revision-range=9405af7d9a75c17 03b88924021fc9f2677c4776b == HTTP Authentication Required Enter username and password for dev at dev Username: yang Password: There was an error creating this review request. The repository path ssh://dev/var/git/web.git is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please readhttp://www.reviewboard.org/docs/manual/dev/admin/management/repositor... ~~~ I thought about trying to set up a mirror URL in the reviewboard web app, but the URL might look different to each client. On the server, the repository is headless, resulting in this error: ~~~ $ post-review Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] fatal: Not a git repository (or any of the parent directories): .git ~~~ After Googling I foundhttp://gitorious.org/reviewboard/rbtools/blobs/master/scripts/git-pos... but it's broken out of date. There are more hacks I can try (e.g. having the post-commit hook temporarily munge the remote origin URL, or having the post-receive hook clone the git repository so that it has a head, then post-review-ing that), but surely there's a better way. Thanks in advance for any hints. -- Yang Zhanghttp://yz.mit.edu/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Handling non-linear DVCS histories (git)
My general workflow is to create a topic branch tracking one of the official branches on a remote server and let post-review detect the merge base. This generates a diff between the last state of that branch and my changes. I don't use RB for merge reviews. It would be good if we got an update on the GSOC git project. I thought the students were required to show progress... If it doesn't go anywhere, we definitely need to add some better handling for more distributed workflows. Dan On Aug 10, 7:59 am, Stephen Gallagher step...@gallagherhome.com wrote: On 08/09/2010 02:32 PM, Yang Zhang wrote: I'm using reviewboard with git projects, and I'm interested in hearing how other folks are handling non-linear DVCS histories. Each commit may have one or two parents - for those with two, how does one generate a patch from that (if you do at all)? Thanks. I wrote a patch for git patchsets in post-review a long while ago:http://reviews.reviewboard.org/r/1472/ It got two ShipIt replies, but Christian opted not to push it upstream. I'm told there's a Google Summer of Code student working on improving the DVCS support, but I'm still using my patch for my project. Basically, my approach to git is to create a new branch from the upstream master and then cherry-pick commits onto it. Then I run my modified post-review command which auto-generates a separate review for each patch. It constructs the parent diff for each one after the first in the branch. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review diff upload error on windows XP
The documentation and clearcase support in rbtools is rather outdated.
I believe Jan has an improvement so you don't need to use my cleartool
lsco hack among other things.
There are a large number of patches in the queue on
reviews.reviewboard.org but they don't appear to be going anywhere.
Nonetheless it would be better to start with these changes as a
baseline rather than debugging the existing broken code. Jan will need
to comment if he's interested in doing this. I can't do it easily
myself since RB doesn't upload full git patches right now...
Dan
On Jul 19, 8:06 am, Chetan chetan@gmail.com wrote:
Hello..
Do anyone have a hint on this issue? i have searched the forum but
could not find any solution.
On Jul 15, 11:44 am, Chetan chetan@gmail.com wrote:
Hello All,
I have facing problem in uploading the clearcase diff in review
request using post-review script.
command used: cleartool lsco -cview -me -recurse -short | sed s//
\//g | xargs post-review -d --diff-only --target-people=chetan.d --
summary=test2_by_chetan --description test2_by_chetan --submit-
as=admin --server=http://.xxx.net/xxx/;
When i use -n option i get the diff on the prompt.
Error are as below:
HTTP POSTing
tohttp://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/16/draft...{'description':
'VIEW: chetan.d_sdaf_2_int\nVIEWTYPE: dynamic\ntest2_by_chetan'}
Uploading diff, size: 1017
HTTP POSTing
tohttp://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/16/diff/...{'basedir':
'M:/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'substring not found']}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code':
105}}
Your review request still exists, but the diff is not attached.
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Request some help in getting this error fixed.
Thnks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: post-review not working with ClearCase - RB1.5B2 on Windows
It would probably be useful to publish a branch on github since there are a lot of patches and the diff download on RB doesn't include the git patch header. We should probably update the docs too to at least indicate the instructions may be out of date until these get merged into rbtools master. Dan On Jun 11, 1:03 pm, Jan Koprowski jan.koprow...@gmail.com wrote: When I told this I meanhttp://www.reviewboard.org/docs/codebase/dev/getting-started/#getting... On Jun 11, 4:37 pm, Jan Koprowski jan.koprow...@gmail.com wrote: Read this. All what You need is download raw diff and use patch On Jun 11, 2:05 pm, Cássio Fernando Berra martel...@gmail.com wrote: Awesome, thanks Jan! Unfortunately I’ve no background in Python, so if you don’t mind, let me know how do I apply those patches. Thanks again! Martelo 2010/6/10 Jan Koprowski jan.koprow...@gmail.com Hi! I made some patches to ClearCase. Please look at patches http://reviews.reviewboard.org/users/jan.koprowski/Especiallythis onehttp://reviews.reviewboard.org/r/1505/. I don't know when this fixes will be put on RBTools repository. If You use ClearCase ClearQuest integration You can use http://reviews.reviewboard.org/r/1500/thisoptionto public changes. I use some CQPERL wrote wrapper around post-review which get informations from CQ and post-review to ReviewBoard. There is more patches to clearcase (almost all wrote for me). You must look them and choose what You need. On Jun 9, 9:32 pm, Martelo martel...@gmail.com wrote: What I've Done: win #01 (RB server) 1 - Set up a new dynamic view (just one vob mounted) in Z:/ drive 2 - Create a new Repository as follows: Name: RepoCC Path: Z:/ win #02 (Client) 1 - Install python 2.5 + SetupTools + DiffUtills + FindUtiils + sed + RBTools 2 - Set up a new dynamic view (same one vob mounted) in Z:/ drive 3 - Checkout one file. Change and save it 4 - Create a new file .reviewboardrc in the users appdata pointing to RB server 5 - Run cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs post-review -- username=user --password=12345 The error is: --- --- There was an error creating this review request. The repository path /view/reviewboard.diffview/vobs/ is not in the list of known repositories on the server. --- --- How do I set what repository should be used??? What I've done wrong or missed? Thanks, Martelo. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Syntax highlighting
I've added support for changing the syntax highlighting scheme, if that will help with your disappointment in the highlighting. It's working, but it needs some better integration for installation. Right now you have to hack up the pygments generated styles with a script. http://github.com/djs/reviewboard/tree/pygments For the Obj-C issue, RB is currently using get_lexer_for_filename, but there is also a guess_lexer API that presumably would yield better results... Dan On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tim, We use a Python module called Pygments (http://www.pygments.org/) for the syntax highlighting, so we basically support whatever they do. The lack of Obj-C highlighting is certainly an annoyance that I've dealt with too. It's due to Pygments giving preference to I think Matlab files or something, over Obj-C. This is something I'd love to see them fix. There's a chance we may get support down the road for adding customizable highlighting (as in, being able to say that this file extension will use that type of highlighter). You wouldn't be able to add new syntax highlighting rules with this, but it's something at least, and would fix the Obj-C situation. However, I think the person who was working on this support has been too busy to finish it up, so I'm not sure which release will end up with it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth timhollingswo...@gmail.com wrote: Hello, Firstly I just started using Review Board and have had a very positive experience so far, thanks! Is there some place to find out what syntax highlighting is available? Is it pluggable or standardized? I'm using C++ and objective-c. The C++ has some highlighting, but not very meaningful - it colors comments and import statements differently but no real highlighting in the code. In objective-c there is not highlighting at all. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Strange ClearCase revision version path while making review
Unfortunately I don't think the original author monitors the mailing
list, so we'll need to do some experimentation on our own. I can try
to help, but I don't keep a Clearcase RB setup active so I can't
easily test things out.
Dan
On Mar 11, 1:10 am, Jan Koprowski jan.koprow...@gmail.com wrote:
Ok :) So question to authors.
How this should looks like?
On Mar 10, 10:26 pm, Dan Savilonis d...@n-cube.org wrote:
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it might think that is the
previous version. I don't really understand the logic used to find
previous revisions in ClearCaseClient methods, but it appears able to
generate this kind of path. I also remember the original review for
this change had screenshots of extended paths and an option to shorten
then, so he seemed to expect this kind of craziness.
Dan
On Mar 10, 12:33 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
Hi !
I'am back to testing reviewboard with clearcase. Now I see that
after post-review there is strange revision version path is send:
post-review -d index.wsgi --serverhttp://gklab-62-060/ svn info
git rev-parse --git-dir
cleartool pwv -short
repository info: Path: /view/reviewboard_scmtools/vobs/SCM_tools,
Base path: /view/reviewboard_scmtools/vobs/SCM_tools, Supports
changesets: False
cleartool desc -pre
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot
Looking for 'gklab-62-060 /' cookie in
/user/jkoprows/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://gklab-62-060/
Username: admin
Password: Logging in with username admin
HTTP POSTing
tohttp://gklab-62-060/api/json/accounts/login/:{'username': 'admin',
'password': '**'}
Logged in.
Attempting to create review request on
/view/reviewboard_scmtools/vobs/SCM_tools for None
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/new/:{'repository_path':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Review request created
Attempting to set field 'description' to 'reviewboard_scmtools
VIEWTYPE: dynamic
' for review request '3' HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/draft/set/:{'description':
'reviewboard_scmtools\nVIEWTYPE: dynamic\n'}
Uploading diff, size: 436
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/diff/new/:{'basedir':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['cat:
/view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/scripts/@@/ma
in/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8: No such file or
directory\n']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
had errors', 'code': 105}}
Error uploading diff: One or more fields had errors (HTTP 200, API
Error 105)
Your review request still exists, but the diff is not attached.
part: /view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/
scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8 doesn't
have any sens. There should be only one version. What was happend?
I made dynamic view.
Checkout file
Make changes
Run post-review as You see below
Greetings From Poland!
--
Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Strange ClearCase revision version path while making review
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it might think that is the
previous version. I don't really understand the logic used to find
previous revisions in ClearCaseClient methods, but it appears able to
generate this kind of path. I also remember the original review for
this change had screenshots of extended paths and an option to shorten
then, so he seemed to expect this kind of craziness.
Dan
On Mar 10, 12:33 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
Hi !
I'am back to testing reviewboard with clearcase. Now I see that
after post-review there is strange revision version path is send:
post-review -d index.wsgi --serverhttp://gklab-62-060/ svn info
git rev-parse --git-dir
cleartool pwv -short
repository info: Path: /view/reviewboard_scmtools/vobs/SCM_tools, Base
path: /view/reviewboard_scmtools/vobs/SCM_tools, Supports changesets:
False
cleartool desc -pre
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools/scripts
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot
Looking for 'gklab-62-060 /' cookie in
/user/jkoprows/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://gklab-62-060/
Username: admin
Password: Logging in with username admin
HTTP POSTing tohttp://gklab-62-060/api/json/accounts/login/:{'username':
'admin', 'password': '**'}
Logged in.
Attempting to create review request on
/view/reviewboard_scmtools/vobs/SCM_tools for None
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/new/:{'repository_path':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Review request created
Attempting to set field 'description' to 'reviewboard_scmtools
VIEWTYPE: dynamic
' for review request '3' HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/draft/set/:{'description':
'reviewboard_scmtools\nVIEWTYPE: dynamic\n'}
Uploading diff, size: 436
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/diff/new/:{'basedir':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['cat:
/view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8:
No such file or directory\n']}, 'stat': 'fail', 'err': {'msg': 'One or
more fields had errors', 'code': 105}}
Error uploading diff: One or more fields had errors (HTTP 200, API
Error 105)
Your review request still exists, but the diff is not attached.
part: /view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/
scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8 doesn't
have any sens. There should be only one version. What was happend?
I made dynamic view.
Checkout file
Make changes
Run post-review as You see below
Greetings From Poland!
--
Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I would generalize Stephen's idea and just call it general support for distributed vcs workflow since RB isn't really built around that model and we're kind of stuffing it in after the fact. I'd also love to see performance improvements. I haven't done any real comparisons, but Rietveld and Gerrit just seem much more lightweight and snappy. Dan On Mar 9, 10:03 pm, Stephen Gallagher step...@gallagherhome.com wrote: It was discussed in another thread, but I think it would be great to improve the git support by handling patch-sets in post-review. The idea would be to support the following workflow: Create a branch based on the upstream master (the repository that RB is storing). Apply several patches on that branch, each dependent on the others. post-review should be capable of automatically generating a review (using --guess-summary and --guess-description) for every patch since the divergence from upstream, properly handling the linking to a parent diff. On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond chip...@chipx86.comwrote: Hi everyone, We've signed up again this year to take part in Google's Summer of Code. We're still awaiting acceptance, but want to brainstorm some ideas that students can work on. First of all, for those who aren't familiar with this, Google Summer of Code is a yearly program from Google where students from around the world are paid to work on open source projects. We participated as an organization last year and received some awesome features (some of which are going in to 1.5, some of which are going into 1.6). We're hoping for 3 or 4 students this year. We have a list of ideas ( http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like feedback on. If you have something you think would be generally useful to Review Board users that you'd like to see on this list and think would be a good project, please tell us! Also, if you're someone with a fair amount of experience with the Review Board codebase, let us know if you'd be interested in helping mentor a student this year. It's purely volunteer work, and can be time-consuming, but it's also an excellent way to help out the project and get some cool new features in the codebase. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I think it's just a general performance comparison, though initial diff loading is particularly slow. I haven't profiled it, but if you compare loading reviews.reviewboard.org dashboard to review.source.android.com, or one of the diffs, the latter just feels much more instantaneous. I don't know how much of that is due to caching, network latency, javascript, server-side, etc but faster is always better :) So one part of this is just gathering some profiling data and comparing. On Mar 10, 4:37 pm, Christian Hammond chip...@chipx86.com wrote: Agreed on both parts. There's a bit more that Review Board does than Gerrit and Rietveld under the hood, but we should certainly strive to make things faster. Is there a specific area where Review Board feels slower to you? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis d...@n-cube.org wrote: I would generalize Stephen's idea and just call it general support for distributed vcs workflow since RB isn't really built around that model and we're kind of stuffing it in after the fact. I'd also love to see performance improvements. I haven't done any real comparisons, but Rietveld and Gerrit just seem much more lightweight and snappy. Dan On Mar 9, 10:03 pm, Stephen Gallagher step...@gallagherhome.com wrote: It was discussed in another thread, but I think it would be great to improve the git support by handling patch-sets in post-review. The idea would be to support the following workflow: Create a branch based on the upstream master (the repository that RB is storing). Apply several patches on that branch, each dependent on the others. post-review should be capable of automatically generating a review (using --guess-summary and --guess-description) for every patch since the divergence from upstream, properly handling the linking to a parent diff. On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond chip...@chipx86.com wrote: Hi everyone, We've signed up again this year to take part in Google's Summer of Code. We're still awaiting acceptance, but want to brainstorm some ideas that students can work on. First of all, for those who aren't familiar with this, Google Summer of Code is a yearly program from Google where students from around the world are paid to work on open source projects. We participated as an organization last year and received some awesome features (some of which are going in to 1.5, some of which are going into 1.6). We're hoping for 3 or 4 students this year. We have a list of ideas ( http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like feedback on. If you have something you think would be generally useful to Review Board users that you'd like to see on this list and think would be a good project, please tell us! Also, if you're someone with a fair amount of experience with the Review Board codebase, let us know if you'd be interested in helping mentor a student this year. It's purely volunteer work, and can be time-consuming, but it's also an excellent way to help out the project and get some cool new features in the codebase. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@goo glegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email toreviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
How do you have the server configured? The server needs to point to a
dynamic view where it will be able to access the file revisions
specified via extended path notation.
Dan
On Feb 17, 10:15 am, eeiths eei...@gmail.com wrote:
Ok, i got to spend a little time at this today.
looks like postreview has support for clearcase on windows without
cygwin.
Ans so the posted diff looks fine.
Sorry my mistake.
But thats not the case on the server side.
It fails on the file_exists and then trying to view the diff it
uses a different clearcaseclient than postreview.
Now the next question is there a way to plug in a postreview like
clearcaseclient on the server side that can fetch the proper versions
using cleartool
and thus apply the patch..?
sorry for my previous posts if they were a bit naive but I didnt get
much time
to study the code.
If i get time I might have a go at this.
On Feb 16, 10:55 am, eeiths eei...@gmail.com wrote:
i've got a bit further with this...it looks like the
tool.file_exists(filename, revision) on the server side fails
It tries to parse a file name form the clearcase extended name i.e.
the one with the versions and @@ char sequences
included in the path. e.g Y:/wran_cm_cms/@@/main/22/src/@@/main/3/com/
@@/main/1/..etc
There is a comment on the post-review.py
class ClearCaseClient(SCMClient):
A wrapper around the clearcase tool that fetches repository
information and generates compatible diffs.
This client assumes that cygwin is installed on windows.
I'm not sure then if the post-review worked as expected .
What exactly is cygwin's role in this process.
I do'nt have it installed ...do I need it.
I think I'm almost there ..!
Thanks
T
On Feb 12, 12:19 pm, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/ cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in
C:\Users\etomhar\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/new/:{'repository_path':
'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:{'description':
'** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:{'basedir':
'X:/'}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One
or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. I would contend that you can already do essentially what you are proposing, albeit not particularly elegantly. There is no way to group a set of reviews together currently. Also, see issue 1229 for some explanation on how RB currently handles diffs and why it doesn't fit perfectly with git patchsets. Dan On Feb 3, 4:36 pm, Stephen Gallagher karrde...@gmail.com wrote: Reviewboard is a great tool, but it's lacking in a couple places regarding Git. Right now, ReviewBoard only supports submitting a single patch generated from the head of a particular branch. In post-review, this means that it performs a 'git diff HEAD origin/master' and transmits the output to the server as a single patch. Unfortunately, this is not how git is used in many cases. Many developers (myself included) prefer to work in patchsets, where individual steps can be developed and tested separately. These patches will build on each other, and should be individually reviewable, but may not have any value separate from each other. What I am proposing is that is should be possible for a single review request to contain multiple, ordered patches. When performing a review, it should be possible to select any of these patches individually and review them. Behind the scenes, I envision reviewboard creating a Review-specific branch onto which it applies each of the patches in the set, so context information will be correctly available during the review. With this functionality in place, it would then be possible to modify the JSON API (and the post-review tool) to enable submitting a branch, complete with commit attribution and comments. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RBTools Repository
http://github.com/reviewboard/rbtools You can submit reviews against rbtools in the same location as reviewboard reviews. Dan On Feb 4, 9:57 am, Stephen Gallagher karrde...@gmail.com wrote: Where can the RBTools source be checked out? I have a few contributions I'd like to make. Also, is there a repository set up in the test instance of ReviewBoard to submit RBTools patches? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
See the Distributed Version Control Systems section of: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ It's definitely available, and I believe it should work with git in 1.0.5.1, but TBH I've never run the stable version of RB. In a 3 patch series, for example, you'd submit the first patch directly, then the second patch with a parent diff of the first patch, then the third patch with a parent diff of the sum of the first two patches. Dan On Feb 4, 10:33 am, Stephen Gallagher karrde...@gmail.com wrote: On Feb 4, 10:20 am, Dan Savilonis d...@n-cube.org wrote: post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. Can you point me at some documentation for the parent diff mode? I'd like to understand more about this. Is it available in the stable 1.0.5.1, or does it require the 1.1 alpha? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
I don't know how similarly people use Clearcase, but I am fairly certain that the way my organization uses it is very non-standard. The typical review scenario would be to review modified code in a view, not checked in code. Fitting Clearcase's model into Reviewboard is a bit of square in round hole problem, though at the most basic level you can do the same thing that's done for other SCM systems: provide a base revision set and diff against it. Some of the stuff you mentioned is all possible, though it doesn't fit nicely into the ReviewBoard model as-is. Feel free to start up a thread in the dev mailing list and I'll help with whatever I can. However, I personally think your time might be better spent getting rid of Clearcase from your organization :) Christian, you'd likely need a mighty generous donor to get a Clearcase license. You'll also probably regret it once you try to set the beast up... On Jan 15, 8:02 pm, Sassan sassan...@verifone.com wrote: At least for ClearCase, most places have a standard naming convention for their views and/or config specs. Either way all it takes is for the client to prompt for and pass two view tags (strings) or config specs (small ascii files) in order for the web server to start the before and after views of the change locally on the server host and generate the diff... no file copy will be needed. This might be easier than dealing with verson extended pathnames. Dealing with directory changes (moving files from one place to another / renaming the files) is more difficult and we will need to use the ClearCase Object ID strings instead of file path names. On Jan 15, 5:51 pm, Chris Clark chris.cl...@ingres.com wrote: Thilo-Alexander Ginkel wrote: On Friday 15 January 2010 23:20:32 Sassan wrote: I am also thinking it might be a good idea to add a repository independent base functionality to the post-review script where it is handed the root directory of two source trees, before and after the change and it will then just compare the files and post a review. This way anyone with any source repository can just create the before and after soure trees outside RB and pass the roots of the source trees to the post-review script for posting. This won't work as Review Board needs to be able to access the respective SCM repository from the server-side to apply the posted diff to the base revision. For the server this is true. RE the client,http://reviews.reviewboard.org/r/1197/sortof does this. It allows any diff to be sent to reviewboard but it had better be a valid diff :-) Chris- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
Hi Sassan,
The latest docs have some instructions on how to use post-review with
Clearcase. In fact, it's the only way to post a review with Clearcase.
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
I wrote it using some unix-ish examples, but I actually tested the
instructions under Windows. post-review's Clearcase support is fairly
crude, but it will work for reviewing modified code in a view that has
not been checked in.
Note that you actually need to modify post-review.py to make it work
in your environment, so I recommend pulling it from git and running
setup.py develop. If someone wants to just add these hard-coded values
as options, this won't be necessary anymore.
Dan
On Jan 14, 7:07 pm, Sassan sassan...@verifone.com wrote:
Does anyone know what is and is not currently supported for ClearCase
as an SCM tool on Windows?
For example I see instructions for posting commited code reviews using
post-review.exe under ClearCase section
inhttp://www.reviewboard.org/docs/manual/1.0/users/tools/post-review/
Does the Todo mean it is only on the wish list and not yet
implemented?
I also see a --label=LABEL under ClearCase options for post-
review.exe but I am not clear as to how a single label can designate a
diff of two distinct revisions.
I tried this anyway and I got::
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module load_entry_point('RBTools==0.2beta2', 'console_scripts',
'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2509, in main
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 954, in diff_label
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 947, in diff
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 811, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 790, in get_previous_version
ValueError: too many values to unpack
Do you know how I get to the postreview.py script inside the rbtools
egg to modify it?
On the other hand it is easy enough for me to generate the diffs
myself out of ClearCase, but is there any way for me post these
directly into the RB server ?
Maybe by passing them to post-review.exe but only to be posted to the
RB server ?
Thanks,
Sassan
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Clearcase Integration
Hi Nitin, There are some instructions in the documentation on setting up Review Board for ClearCase which you should start with, as well as various threads you can search for in the mailing list. However, I'd recommend you find someone who is comfortable with ClearCase and cleartool to set it up. The process is not as smooth or flexible as with other VCS. ClearCase does not fit well into the Review Board model and though there seem to be a number of users out there, I haven't seen a lot of feedback on how well it works for them. Dan On Dec 15, 3:06 am, Nitin GUpta nit...@gmail.com wrote: My company is using Clear Case for repository, I have very little understanding of clearcase. While searching i found that clearcase could be supported by Review Board. So we installed Review Board. But unable to configure the clearcase settings. Could anyone of you please help me to setup Review Board for Clearcase. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to get post-review to work w/ http://reviews.reviewboard.org (to request reviews for RB changes)
You can run post-review with the -d option to see what it is trying to do. I suspect the git get_repository_info() check is failing. It will start by running: $ git rev-parse --git-dir and then a few more commands, which will all be listed with the -d option. Once you see where it fails, you can try running the commands manually. Dan On Nov 7, 2:30 pm, Pv p...@swooby.com wrote: I would like to request a review for a change to ReviewBoard and am absorbing the two wiki pages: http://www.reviewboard.org/docs/codebase/dev/getting-started/ http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ I'm a noob to git, but I pulled down a git enlistment and can run a dev server with my changes just fine. git diff --cached shows my changes. I set my git config reviewboard.url as follows: git config reviewboard.urlhttp://reviews.reviewboard.org The property takes fine (get config -l shows the value). I then post-review from the directory of my changes (webapi), and I get the following error: The current directory does not contain a checkout from a supported source code repository. I am running post-review v0.8: post-review --version post-review-script.py 0.8 This looks to be the one installed following this step: http://www.reviewboard.org/docs/codebase/dev/getting-started/#rbtools Any idea what my my malfunction is? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: git and diffs against branches
Lobby for http://reviews.reviewboard.org/r/1144/ to get committed and
you should be all set. :) For now, the only options are to use the web
form or specify a revision range manually.
Can you explain more about the error with the web form? You mentioned
git diff, and if you meant that literally, that would end up diffing
your working copy changes against whatever is your HEAD. If your HEAD
is not a revision in the remote repository, RB won't understand what
you are diffing against.
Dan
On Oct 23, 2:10 pm, Chris Clark chris.cl...@ingres.com wrote:
Whilst I use other distributed SCM's I've only just started with git (as
ReviewBoard uses it) and I think I'm having some trouble understanding
git (and reviewboard).
What I'd like to do is post for review changes/diffs against a branch
(not master/bleeding edge).
E.g.
git clone git://github.com/reviewboard/reviewboard.git
git checkout release-1.0.5.1
## hack on stuff, e.g. git add myfile
postreview.py --server=http://reviews.reviewboard.org/ --debug
Here is my output (note headrevs of rbtools and this is actually posted
explictly with -r1177):
svn info
git rev-parse --git-dir
git svn info
git svn --version
git config --get svn-remote.svn.url
git remote show origin
repository info: Path:
git://github.com/reviewboard/reviewboard.git, Base path: , Supports
changesets: False
git diff --no-color --full-index master
Looking for 'reviews.reviewboard.org /' cookie in
/home/ingres/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting api/json/reviewrequests/1177/
Uploading diff, size: 467617
HTTP POSTing
tohttp://reviews.reviewboard.org/api/json/reviewrequests/1177/diff/new/:{}
Error uploading diff: One or more fields had errors (105)
{u'fields': {u'path': [u'int argument required']}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
From the instructions near the end
ofhttp://www.reviewboard.org/docs/codebase/dev/getting-started/#getting...
(Posting Changes for Review) I get the impression this is not allowed?
The checkout is based on master but it is a different branch,
I guess this maybe a bug report too as it fails to post but does create
an empty review without printing out the review number. I ended up
browsinghttp://reviews.reviewboard.org/r/and looking at the top to
work out it had created one. Similar behavior if I just do a git diff
and try and use the web interface (i.e. get int arg required error).
Help!
Chris
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Apache hangs upon post-review
There was a problem like this with git support a long time ago. Can
you add use the diff only option and make sure the diff it generates
looks somewhat reasonable?
Dan
On Oct 23, 11:22 am, James jimspe...@gmail.com wrote:
Per an earlier thread I'm trying to get Review Board working on a
Windows machine
with ClearCase integration. I've gotten earlier road blocks and now
post-review runs
but it only gets so far and then the Apache server goes to 99% CPU
utilization and
post-review process hangs until I restart Apache server. Here is
output from a debug
post-review run. Any ideas?
snip HTTP POSTing
tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/set/:{'de
scription': 'sperry_releaseboard\nVIEWTYPE: dynamic\n'} HTTP POSTing
tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/save/:{}
Review request draft saved
Uploading diff, size: 4635
HTTP POSTing tohttp://ndm-xp-vm1/api/json/reviewrequests/4/diff/new/:{'bas
edir': 's:\\'}
^C
S:\softdbTraceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.2beta2', 'console_scripts', 'post-
review')()
File build\bdist.win32\egg\rbtools\postreview.py, line 2522, in
main
File build\bdist.win32\egg\rbtools\postreview.py, line 2254, in
tempt_fate
File build\bdist.win32\egg\rbtools\postreview.py, line 463, in
upload_diff
File build\bdist.win32\egg\rbtools\postreview.py, line 575, in
api_post
File build\bdist.win32\egg\rbtools\postreview.py, line 556, in
http_post
File C:\Python25\lib\urllib2.py, line 124, in urlopen
return _opener.open(url, data)
File C:\Python25\lib\urllib2.py, line 381, in open
response = self._open(req, data)
File C:\Python25\lib\urllib2.py, line 399, in _open
'_open', req)
File C:\Python25\lib\urllib2.py, line 360, in _call_chain
result = func(*args)
File C:\Python25\lib\urllib2.py, line 1107, in http_open
return self.do_open(httplib.HTTPConnection, req)
File C:\Python25\lib\urllib2.py, line 1080, in do_open
r = h.getresponse()
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Managing many review requests - Queued Workflow
I agree these could be useful features, but you have to be careful not to delve into the 'policy' realm which will make everyone despise the tool. We also use CodeCollaborator where I work and no one wants to use it for small reviews because it's a waste of time. It implements this ping-pong model to the extreme. Every time you finish the review, you mark it complete. If a single person makes another comment, all completed reviews are now uncompleted and every other reviewer must go back and mark the new comment as read, and sign off again. It might ultimately be most useful to add customizable user fields to reviews, instead of something like 'severity' which inevitably won't meet someone's needs. Dan On Oct 10, 7:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Thanks for your feedback. Comments inline. On Tue, Oct 6, 2009 at 8:17 AM, Biking4Fun govo0...@gmail.com wrote: Only show requests that need your action - Tennis Ball model --- - Currently, a review stays in everyone's view until the requester has marked it submitted, etc. This tends to clutter one's view and makes it unclear what you need to act upon. It would be better if ReviewBoard implemented a tennis / ping pong model. What I mean by that is the review should only be in someone's view when they need to act on the review. Once the reviewer has commented and/or marked it Ship It, that is like hitting the ball back to the requester's court. It should no longer appear in that particular reviewer's view, because they have already acted upon it. It should now show up in the requester's view, because someone has commented and perhaps found a problem. There's a lot of value in this model, but we'd have to be careful with how we implement it. It's not always ideal to only see review requests you haven't commented on. There are times when I've only been able to review part of a very large change, made that review public, and then went back to it later to review more of it. In cases like these, I'd certainly want to see the review request still. I think what we could do is add a form of filtering to the dashboard, so you could show or hide review requests you've already looked at that haven't been updated since you last saw it. I don't know that anything needs to be done in the requester's view. A person generally only has a few review requests out at any given point in time. The above filter could just apply to this view as well if it's really needed. Feel free to file a feature request on this, so we can track it for future releases. Request Priority Some code changes are for future releases, a lower priority. Others are for a critical fix, or trying to make a code freeze deadline- a higher priority. There currently isn't a way for a requester to indicate that a particular review is important and needs to be looked at quickly. We've discussed adding some sort of severity indicator to a review request. Maybe we will eventually, but we're not set on it yet for a couple of reasons. 1) Severity levels can (and will) be abused. Everyone thinks their review request is important and unless you're working with Git or something similar, you're often blocked until your change goes in. If we give the ability to indicate low, medium and high priorities, then most people will probably pick high, in order to get their change looked at. Review requests with lower priorities will probably just end up being ignored, as there will always be higher priority review requests. In the end, this won't do anyone any good. 2) Severity levels set by the person posting the review request makes sense in corporate environments but often don't in open source projects. If someone is submitting a patch to Review Board, for instance, I really don't want them to decide that it's critical to get it in. It makes a lot more sense for myself as the developer to decide the priority of it. But then, that doesn't really help us any, because if we consider it critical to get in now, we should just review it now. 3) Severity levels don't communicate *why* it's important. Is it because there's a beta coming up that needs that change? Is it blocking the person? Is it blocking somebody else? Is it some emergency security fix? Build breakage? I don't think a severity level communicates enough here. 4) There's already a mechanism for communicating that something is important and needs to be done for some deadline or milestone. Put it in the summary. At VMware, for example, people will sometimes prefix a summary with [Beta 1 fix] and everyone working on the product will know that beta 1 is coming up and that that needs to take priority. No need for any special fields in the database, special UI, or anything. We may reconsider it sometime, but our design philosophy so far has
Re: Review Board 1.0.3 released
Yes, I realized this after I posted. I had accidentally pulled in a nightly build at one point due to my .pydistutils.cfg, but I had since downgraded to 1.0.1. Is there any way to get rid of the issue, or am I stuck with the warning forever? :) Dan On Sep 17, 3:44 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, Were you at any point running a 1.1 nightly or out of a Git tree? This is a field introduced in the 1.1 branch, so I don't know why you would see this in 1.0.x. It doesn't appear that the 1.0.x releases mention this at all in the codebase. If you went from a 1.1 to a 1.0.3, then you would definitely hit this error, as the field would be introduced and then removed without an evolution rule. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Thu, Sep 17, 2009 at 8:52 AM, Dan Savilonis d...@n-cube.org wrote: I got the following error during the evolution: # rb-site upgrade /home/reviewboard_head Rebuilding directory structure Updating database. This may take a while. There are unapplied evolutions for diffviewer. Project signature has changed - an evolution is required /usr/lib/python2.5/site-packages/ReviewBoard-1.0.3-py2.5.egg/ reviewboard/scmtools/bzr.py:6: ImportWarning: Not importing directory '/usr/lib/python2.5/site-packages/bzrlib': missing __init__.py from bzrlib import bzrdir, revisionspec The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: Field 'raw_file_url' has been deleted It appears to be working okay, though. Other thing I noticed is that the admin dashboard has CSS applied but appears very basic and has no images. Other pages look okay, and the same as they used to. Dan On Sep 16, 8:38 pm, Christian Hammond chip...@chipx86.com wrote: Last night's 1.0.2 release was pretty broken in two major ways. The web server configuration templates were no longer bundled in the package, due to a change in the structure of our code tree, and users using Django 1.0.2 would hit a bug, as we needed functionality only present in 1.0.3 and higher. The new 1.0.3 release should address these problems. If you've been bitten by 1.0.2 (our deepest apologies), please give this release a try and let us know how it works. Full release notes are available athttp:// www.review-board.org/docs/releasenotes/dev/reviewboard/1.0.3/ Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard and Clearcase Integration
If you search the mailing list archives, you should see several threads on the subject, including one where I described my process of setting up Clearcase support and the limitations we've seen. Dan On Sep 17, 5:52 am, irshad irshada...@gmail.com wrote: Hi All, Review Board 1.0 Release Notes says that ClearCase support is provided as a new Features. But there is no documentation for ReviewBoard Installation with ClearCase as repository. Can anybody help me from where I can get the documentation when repository is ClearCase. Regards, Irshad --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review board automated with git
Hi Marek, Have you tried the parent diff option? This is designed for distributed version control and allows you to specify a base 'parent' diff, based off of a known revision in the remote repository on the reviewboard server, and the main diff can then be based off of the parent diff. There are some enhancements to git support in post-review under review now that will hopefully make it more flexible. Dan On Aug 28, 8:30 am, Marek slogt...@gmail.com wrote: More in detail, what we do is: 1. Write some code 2. Do the commit 3. Post a review to a system 4. push 5. Go to 1. and it works! but if we do: 1. Write some code 2. Do the commit 3. Post a review to a system 4. Go to 1 Then posting review for the second time will show sth like file not found in the repository. (both by post-review and via web). On 27 Sie, 12:16, Marek slogt...@gmail.com wrote: We are trying for a while now to introduce Board Review in our company. We are using git. We tried simple flow: 1. git commit 2. post-review but it only works when we do the push after every single commit. Doesn't make a lot of seans to us. (It seem that board review requires one commit back version of your files to apply the diff on) The next step would be to do automated review requests anyway. This first issue makes it impossible to work with simple git pre-commit hooks. Is there any other way? Is there any recommended way to use git with board review, ommiting one-push-per-commit problem. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: cat: /usr/cc_storage/unix_STREAM/.../myjava.sql@@/main/STREAM/2: No such file or directory\n
From the documentation, it looks like ccrt has the same command line
interface as cleartool, so as I understand it the problem is just that
it is a snapshot view. We need to fix snapshot view functionality for
regular clearcase anyway, so it should be possible to support both
tools.
Dan
On Aug 18, 10:55 am, MiZhKa miz...@gmail.com wrote:
Hi, Dan,
CCRC is Java standalone GUI application to work with views based on
Eclipse platform. The installation doesn't contain cleartool. It's
completely different interface. Something about it locates here:
https://publib.boulder.ibm.com/infocenter/cchelp/v7r1m0/index.jsp?top...
http://www.samecs.com/how_do_i/ClearCase%20Remote%20Client%20and%20we...
CCRC doesn't require additional server. In our company the only
ClearCase server is used by developer. We use snapshot views. I've
discussed with other developers this topic and found out that CCRC can
be used for views created by cleartool and otherwise. CCRC is
alternative for cleartool.
Now we're testing approach when diff file are generated by
reviewboard, not by post-review.
Michael.
On Aug 18, 5:40 pm, Dan Savilonis d...@n-cube.org wrote:
The clearcase support relies on the extended path notation through the
clearcase filesystem and uses cleartool to query the view. I'd never
heard of CCRC before, but anything involving Clearcase and the word
'remote' can't possibly be a good thing. Do you have any more details
on how this tools works? Does it ultimately provide an interface to
cleartool, or is it a completely different, incompatible interface?
Christian: FYI, Clearcase doesn't really have any concept of a remote
server, akin to svn et al. You have your machine configured on a local
network with a clearcase server, and you have one or more 'VOBs' that
are basically repositories. You create a snapshot or dynamic 'view'
locally that presents the file tree in a directory. You can't really
just switch to another clearcase server, if there are multiple ones on
your network. And the only easy way to access different versions of a
file is through a weird extension to the filesystem where you can
specify the version as a path (e.g. foo/bar.c@@\main\branch\37)
Dan
On Aug 17, 10:57 am, MiZhKa miz...@gmail.com wrote:
Hi, Christian,
Recently I found out that a lot of developers use CCRC (ClearCase
Remote Client) and don't have cleartool. I'm sorry for long delay,
because I had limit of time to make Review Board be working with CCRC.
The only solution not required high redevelopment was creating page
for creating of review requests by repository and activity ID. Diff is
generated according to activity ID. Today the solution has been given
to developers. Now I'm waiting for first comments. After that, I will
post corrections.
Sincerely yours,
Michael,
On Aug 13, 10:26 pm, Christian Hammond chip...@chipx86.com wrote:
Yes, either upload it through the web UI or use post-review in an SVN
checkout (which is much easier).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Thu, Aug 13, 2009 at 8:17 AM, MiZhKa miz...@gmail.com wrote:
Now it works.
How can I send fix? To review.review-board.org?
Thank you,
On Aug 13, 8:06 am, MiZhKa miz...@gmail.com wrote:
Christian,
Thank you for your answer! I'll try to fix it. I think fix is easy,
Michael.
On 13 авг, 00:34, Christian Hammond chip...@chipx86.com wrote:
I think the person who contributed ClearCase support on the server
expected
that the repository would be locally checked out with the path
given.
We'll
certainly take a patch to use cleartool to fix this.
We don't have access to ClearCase, so we can't do a lot of testing
ourselves.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 12, 2009 at 10:56 AM, MiZhKa miz...@gmail.com wrote:
Hi,
I wonder how reviewboard fetches file versions from ClearCase.
Now I
have strange error from /api/json/reviewrequests/74/diff/new/:
{fields: {path: [cat: cat: /usr/cc_storage/unix_STREAM/.../
myjava.sql@@/main/STREAM/2: No such file or directory\n]},
stat:
fail, err: {msg: One or more fields had errors, code:
105}}
It seems that reviewboard (on server side) doesn't use
cleartool to
fetch version of file. This can be seen from
scmtools/clearcase.py:
class ClearCaseClient:
def __init__(self, path):
self.path = path
def cat_file(self, filename, revision):
p = subprocess.Popen(
['cat', filename
Re: cat: /usr/cc_storage/unix_STREAM/.../myjava.sql@@/main/STREAM/2: No such file or directory\n
The clearcase support relies on the extended path notation through the
clearcase filesystem and uses cleartool to query the view. I'd never
heard of CCRC before, but anything involving Clearcase and the word
'remote' can't possibly be a good thing. Do you have any more details
on how this tools works? Does it ultimately provide an interface to
cleartool, or is it a completely different, incompatible interface?
Christian: FYI, Clearcase doesn't really have any concept of a remote
server, akin to svn et al. You have your machine configured on a local
network with a clearcase server, and you have one or more 'VOBs' that
are basically repositories. You create a snapshot or dynamic 'view'
locally that presents the file tree in a directory. You can't really
just switch to another clearcase server, if there are multiple ones on
your network. And the only easy way to access different versions of a
file is through a weird extension to the filesystem where you can
specify the version as a path (e.g. foo/bar.c@@\main\branch\37)
Dan
On Aug 17, 10:57 am, MiZhKa miz...@gmail.com wrote:
Hi, Christian,
Recently I found out that a lot of developers use CCRC (ClearCase
Remote Client) and don't have cleartool. I'm sorry for long delay,
because I had limit of time to make Review Board be working with CCRC.
The only solution not required high redevelopment was creating page
for creating of review requests by repository and activity ID. Diff is
generated according to activity ID. Today the solution has been given
to developers. Now I'm waiting for first comments. After that, I will
post corrections.
Sincerely yours,
Michael,
On Aug 13, 10:26 pm, Christian Hammond chip...@chipx86.com wrote:
Yes, either upload it through the web UI or use post-review in an SVN
checkout (which is much easier).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Thu, Aug 13, 2009 at 8:17 AM, MiZhKa miz...@gmail.com wrote:
Now it works.
How can I send fix? To review.review-board.org?
Thank you,
On Aug 13, 8:06 am, MiZhKa miz...@gmail.com wrote:
Christian,
Thank you for your answer! I'll try to fix it. I think fix is easy,
Michael.
On 13 авг, 00:34, Christian Hammond chip...@chipx86.com wrote:
I think the person who contributed ClearCase support on the server
expected
that the repository would be locally checked out with the path given.
We'll
certainly take a patch to use cleartool to fix this.
We don't have access to ClearCase, so we can't do a lot of testing
ourselves.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 12, 2009 at 10:56 AM, MiZhKa miz...@gmail.com wrote:
Hi,
I wonder how reviewboard fetches file versions from ClearCase. Now I
have strange error from /api/json/reviewrequests/74/diff/new/:
{fields: {path: [cat: cat: /usr/cc_storage/unix_STREAM/.../
myjava.sql@@/main/STREAM/2: No such file or directory\n]}, stat:
fail, err: {msg: One or more fields had errors, code:
105}}
It seems that reviewboard (on server side) doesn't use cleartool to
fetch version of file. This can be seen from scmtools/clearcase.py:
class ClearCaseClient:
def __init__(self, path):
self.path = path
def cat_file(self, filename, revision):
p = subprocess.Popen(
['cat', filename],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if not failure:
return contents
if errmsg.startswith(fatal: Not a valid object name):
raise FileNotFoundError(filename)
else:
raise SCMError(errmsg)
Is it mistake or my misunderstanding?
Thank you for your help!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: substring not found
Could you explain your workaround?
Are you using a snapshot view for post-review, the server, or both?
I've found that snapshot views don't work correctly with post-review,
and haven't tested with a snapshot view on the server side.
Dan
On Aug 6, 12:49 pm, MiZhKa miz...@gmail.com wrote:
3) WA was found and now request is created.
Diff:
--- c:\\vobs\Component_Name\source\org\buba\myjava.java 2002-02-21
23:30:39.942229878 -0800
+++ c:\\vobs\Component_Name\source\org\buba\myjava.java 2002-02-21
23:30:50.442260588 -0800
@@ -26,6 +26,7 @@
throws RemoteException, CreateException,
ServiceProvisioningException
{
//TODO: may be isn't use
+ // My face comment
}
@Override
Michael
On Aug 6, 7:50 pm, MiZhKa miz...@gmail.com wrote:
I've tried. Patch is useful. But I have several problems with snapshot
views:
1) To create diff CHECKEDOUT file should be copied to temp folder
2) I've set temp folder to C:\temp because error was occurred with C:
\Documents and Settings\\Temp
3) Now I have problem with uploading of file to server. Server
invalidates diff with error:
cat: /mnt/ftpit/Stream_Name/Component_name/@@/main/0//
@@..myfile.java@@/@@/main/Stream_name/8: No such file or directory\n
I am diving deeper.
On Aug 5, 3:27 am, Dan Savilonis d...@n-cube.org wrote:
Clearcase support only officially works through post-review since it
needs to do some tricks to generate the diff. How did you create this
fake diff? Can you try following the steps I provided in this thread
and see if you are able to get it to
work?http://groups.google.com/group/reviewboard/browse_thread/thread/1a612...
Dan
On Aug 4, 4:07 pm, Christian Hammond chip...@chipx86.com wrote:
Can you provide more information? I need to see the full error log.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Tue, Aug 4, 2009 at 9:34 AM, MiZhKa miz...@gmail.com wrote:
Hi,
I've installed Review Board 1.0.1 and added ClearCase repository. To
test Review Board, I've prepared fake diff file:
Index: configurations/demo/toolbox.jsp
===
--- configurations/demo/toolbox.jsp (label )
+++ configurations/demo/toolbox.jsp (label copy)
@@ -4,6 +4,7 @@
org.buba.ejb.session.custom.CustomXMLizerHome,
org.buba.ejb.session.custom.CustomXMLizer,
org.buba.ejb.framework.*,
+ java.math.BigInteger,
org.buba.ejb.session.common.CommonService,
org.buba.ejb.session.common.CommonServiceHome,
java.util.Collection,
As result the following error occurred: substring not found.
What can I do to resolve this problem?
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: ClearCase and Reviewboard setup Continues...
Jianquan, You can follow the link in the windows installation instructions here: http://review-board.org/docs/manual/dev/admin/installation/windows/ Dan On Aug 5, 11:07 pm, jianquan bianjianq...@gmail.com wrote: hi Karthik where can i download the GNU-Patch.exe file? I meet the same issue as you. On Jul 22, 10:43 pm, Karthik karthikeyan1...@gmail.com wrote: ( I was not able to post it in the same thread, it always error encountered). Hi, I could post the diff into the review board server. It is no more hanging after considering Dan's suggestion(Changing the repository path to the drive). I was facing another issue after this. When I click to see the view-diff in the review request, I was getting following error. [Errno 2] No such file or directory: 'd:\\temp\\reviewboard.7px08a\ \tmpgjsi_l-new' Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 131, in patch f = open(newfile, r) IOError: [Errno 2] No such file or directory: 'd:\\temp\\reviewboard. 7px08a\\tmpgjsi_l-ne I had to install the GNU-Patch.exe and put it under apache webserver bin path to solve this issue. As of now, everything seems to be going fine till now!! :) Thanks, Karthik --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Stripping comments from patches -- not so good
Hi Joyjit, Are you talking about comments that precede the actual diff in the patch? This is a problem for git patches, and a bug 1229 is open for it. I looked into the issue a bit and I think it can be resolved by maintaining the extra info as part of the diff set. Right now, RB splits the diff into separate file diffs which are then concatenated together for downloading the full diff. I'm interested in this change, so I'll look into modifying the code when I have a chance. Dan On Jul 29, 6:11 pm, joyjit joy...@gmail.com wrote: When one submits a patch file (in unified diff format), reviewboard seems to throw away the comments that are embedded in the patch file. This is not good. It would be nice to have reviewboard accept those comments and add it to the Description field. And it would also be nice for reviewboard to preserve the patch in its entirety when one chooses Download Diff from the web gui.. Thanks Joyjit --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Setting up problem on windows XP sp3
Check that your pythonXX/Scripts directory is in your path. This is not added by default. Dan On Aug 4, 4:24 am, Christian Hammond chip...@chipx86.com wrote: How did you install Review Board on that system? Can you list the steps you performed? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Aug 4, 2009 at 1:00 AM, dmpub...@gmail.com dmpub...@gmail.comwrote: Hi I have a problem with reviewboard setting up on windows XP sp3. When i try to create site with the command rb-site install, it says rb- site' is not recognized as an internal or external command, operable program or batch file. (I didnt find any rb-site.exe in any of the folders in the machine ) .But i could mange to install reviewboard on windows 2003 and i follow the same approache for XP also.Please some help help me to find the problem with the setting up. Thanks. Pubudu. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: substring not found
Clearcase support only officially works through post-review since it needs to do some tricks to generate the diff. How did you create this fake diff? Can you try following the steps I provided in this thread and see if you are able to get it to work? http://groups.google.com/group/reviewboard/browse_thread/thread/1a6124f46fd926a Dan On Aug 4, 4:07 pm, Christian Hammond chip...@chipx86.com wrote: Can you provide more information? I need to see the full error log. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Aug 4, 2009 at 9:34 AM, MiZhKa miz...@gmail.com wrote: Hi, I've installed Review Board 1.0.1 and added ClearCase repository. To test Review Board, I've prepared fake diff file: Index: configurations/demo/toolbox.jsp === --- configurations/demo/toolbox.jsp (label ) +++ configurations/demo/toolbox.jsp (label copy) @@ -4,6 +4,7 @@ org.buba.ejb.session.custom.CustomXMLizerHome, org.buba.ejb.session.custom.CustomXMLizer, org.buba.ejb.framework.*, + java.math.BigInteger, org.buba.ejb.session.common.CommonService, org.buba.ejb.session.common.CommonServiceHome, java.util.Collection, As result the following error occurred: substring not found. What can I do to resolve this problem? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ClearCase and Reviewboard setup Continues...
I've only deployed RB with Clearcase for local testing, but the base path should just point to the server's view. It doesn't matter locally that that drive may or may not exist. Clearcase doesn't really fit into the model of the other supported scms where you can query it to find out the 'remote' repository. We could add an option to post- review to accept this path on the command line so it doesn't need to be hard-coded. I don't know if there's any way it could actually be stored as metadata in your view, like we do with other scms, though. Another thought -- maybe you could fill in the 'mirror path' in your configuration with a bogus name that's more user-friendly than 'y:/', like 'cc_vob_foo' and then specify that with post-review instead of 'y:/'. Dan On Jul 23, 1:47 am, Karthik karthikeyan1...@gmail.com wrote: Hi Dan, We have given the view drive (Y:/) as a base path directory in the post-review script and in the review board admin location. Does it hold good if we are going to run the common centralized review board server which will be used by group of people? What is the base path we can give in that situation? Because the drive letter is just the mapping or mounting of the view for a single user. Please let me know if you have any thoughts on this. Thanks, Karthik On Jul 23, 10:43 am, Karthik karthikeyan1...@gmail.com wrote: ( I was not able to post it in the same thread, it always error encountered). Hi, I could post the diff into the review board server. It is no more hanging after considering Dan's suggestion(Changing the repository path to the drive). I was facing another issue after this. When I click to see the view-diff in the review request, I was getting following error. [Errno 2] No such file or directory: 'd:\\temp\\reviewboard.7px08a\ \tmpgjsi_l-new' Traceback (most recent call last): File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\views.py, line 152, in view_diff interdiffset, highlighting, True) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 623, in get_diff_files large_data=True) File c:\python25\lib\site-packages\Djblets-0.5-py2.5.egg\djblets \util\misc.py, line 143, in cache_memoize data = lookup_callable() File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 622, in lambda enable_syntax_highlighting), File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 345, in get_chunks new = get_patched_file(old, filediff) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 261, in get_patched_file return patch(filediff.diff, buffer, filediff.dest_file) File c:\python25\lib\site-packages\ReviewBoard-1.0-py2.5.egg \reviewboard\diffviewer\diffutils.py, line 131, in patch f = open(newfile, r) IOError: [Errno 2] No such file or directory: 'd:\\temp\\reviewboard. 7px08a\\tmpgjsi_l-ne I had to install the GNU-Patch.exe and put it under apache webserver bin path to solve this issue. As of now, everything seems to be going fine till now!! :) Thanks, Karthik --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: About post-review and mercurial
Hmm, well the original debug output you posted indicated that it never
even got far enough to try to contact the server. If the mercurial
extension is now working, that's great, but it would be good to know
the post-review script is working as well.
Dan
On Jul 23, 3:20 pm, frankabel frank.abel...@gmail.com wrote:
On Jul 20, 12:59 pm, Dan Savilonis d...@n-cube.org wrote:
Friendly reminder: please don't post passwords or other sensitive
information on the mailing list.
Thanks, but is just a test server and an inutile pass, strong? yes,
seem that my finger can't type a weak pass :)
What's happening is that it's falling through mercurial detection into
clearcase, and it fails to detect any vcs. It will test for a
mercurial-svn repository first, so you should expect that to fail
before it tries to detect a pure mercurial repo.
One thing to check:
run hg svn info
Does the response start with 'abort:'? If not, the script is looking
for this, and will assume it IS an hg-svn repo otherwise. This
actually looks like the only codepath that is possible (that I see)
given the debug trace you provided.
Dan
I'm don't know what happened and don't understand to much what you
said. I really want uses a mercurial extension(http://bitbucket.org/
ccaughie/mercurial-reviewboard/wiki/Home) instead of this review board
command, cause is more smooth. I'm reply this message because I'm
pretty sure that the solution(http://groups.google.com/group/
mercurial_general/t/b53558ae8182ba8c) that fix my problem using the
extension is the same that can be solve this problem and alway can
someone have the same problem:
In resume, I think that review board don't handle api request on an
installation with a root path different to '/' cause I reinstall
review board without any root path, I mean using '/' root path and all
work fine.
Thanks a lot for your reply Dan
Frank Abel
On Jul 20, 7:34 am, frankabel frank.abel...@gmail.com wrote:
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
revision-range=35:38 hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version
and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command
it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com
wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages
Re: ClearCase and Reviewboard setup.
Well, it looks like you are having the same problem as in another
thread, however both have Clearcase in common. Everything is working
okay in the post-review half of things, so my guess is something is
going wrong trying to access the base files from Clearcase on the
server side.
It looks like you are running Windows, but your basedir and
repository_path are '/sw0' which looks unix-like. Are you sure you
have the repository path configured correctly on the server? If it's a
dynamic view, it ought to just be a root drive letter like X:/.
Dan
On Jul 20, 6:37 am, Karthik karthikeyan1...@gmail.com wrote:
Hi Dan,
I have done the changes to make it work with Clearcase. I have
followed all the steps you have mentioned. I am using dynamic
clearcase view only. When I run the post-review script, it hangs when
it tries to post the diff content. But I can see the diff content if I
use output-diff option for post-review. Following are the output taken
from post-review script.
karthik-wx ct lsco -cview -me -short -rec | sed s//\//g | xargs
python C:/Python25/Scripts/post-review --server=http://localhost:
8082 --submit-as=karthik --password=mywork –d
C:\Python25\lib\site-packages\rbtools-0.2beta1-py2.5.egg\EGG-INFO
\scripts\post-review cleartool pwv -short
repository info: Path: /sw0, Base path: /sw0, Supports changesets: False
cleartool desc -pre K:\sw0\software\code\include\techMgr.h
Looking for 'localhost /' cookie in C:\Documents and
Settings\karthik\Local Settings\Application Data\.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://localhost:8082/
Logging in with username karthik
HTTP POSTing
tohttp://localhost:8082/api/json/accounts/login/:{'username': 'karthik',
'password': '**'}
Logged in.
Attempting to create review request for None
Submitting the review request as karthik
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/new/:{'repository_path':
'/sw0',
'submit_as': 'karthik'} Review request created
Attempting to set field 'description' to 'karthik_view_9.0BugFix
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/draft/set/:{'description':
'karthik_view_9.0BugFix\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 548
HTTP POSTing
tohttp://localhost:8082/api/json/reviewrequests/6/diff/new/:{'basedir':
'/sw0'}
It hangs after this line ---
Please let me know If I miss any configuration or something.
Thanks,
Karthik
On Jul 18, 6:05 am, Dan Savilonis d...@n-cube.org wrote:
The requirements to use post-review with clearcase are the same as
with any other version control system. The only difference is you pass
a list of filenames as arguments to the script that you want to
review:
python post-review --server=http://example.com/file1.cfile2.c
file3.c
If post-review doesn't work, easy_install rbtools should install the
python dependencies.
Dan
On Jul 17, 8:11 pm, 吴开春 wukaic...@gmail.com wrote:
请教一下，你装起来用了没有？
On Jul 17, 10:23 pm, Dan Savilonis d...@n-cube.org wrote:
It is not required. post-review simply includes support for cygwin
(i.e. path translation since cleartool does not understand cygwin
paths). My example used sed and xargs to make it easier, so that's the
only reason I suggested having the tools in your path. This feature
can eventually be added to post-review to automatically collect
checked out files.
Dan
On Jul 17, 6:50 am, 夏勇杰 notox...@gmail.com wrote:
Hi Dan,
I have some questions about post review.
Should we install cygwin for post-review in order to make it work with
Clearcase?
On Jul 17, 9:32 am, Dan Savilonis d...@n-cube.org wrote:
I went through a fresh installation of reviewboard withClearcase
today and recorded the steps.
Here's what you need to do to get up and running. For the purpose of
this test, I used a dynamic view and was running the server on the
same machine as I had the view and did a review of checked out
files.
1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin
interface (Home Scmtools Tools), if using ReviewBoard 1.0. This
step is not necessary if you're running svn revision = r2041.
2) Add aClearCaserepository via the admin interface, and specify a
path to your view (I used the top of the view, not the vob).
3) Apply the patch fromhttp://reviews.review-board.org/r/906/toyour
post-review script.
4) Edit post-review ClearCaseClient class. Change cc_rootpath to be
identical to what you typed into the admin interface, change
viewtype
to 'dynamic' (if you're trying this with a dynamic
Re: About post-review and mercurial
Friendly reminder: please don't post passwords or other sensitive
information on the mailing list.
What's happening is that it's falling through mercurial detection into
clearcase, and it fails to detect any vcs. It will test for a
mercurial-svn repository first, so you should expect that to fail
before it tries to detect a pure mercurial repo.
One thing to check:
run hg svn info
Does the response start with 'abort:'? If not, the script is looking
for this, and will assume it IS an hg-svn repo otherwise. This
actually looks like the only codepath that is possible (that I see)
given the debug trace you provided.
Dan
On Jul 20, 7:34 am, frankabel frank.abel...@gmail.com wrote:
Hi Christian!
First at all thanks for your reply.
Here the command with --debug and yes, hg is in my path, I type hg
and all if fine(I have hg installed using distro binaries, ubuntu 9.04
in my case), I even type hg root and all is fine, but what I see is
that svn(see below) isn't a hg command and not have idea of what is
cleartool pwv -short.
revision-range=35:38 hg root
hg svn info
cleartool pwv -short
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
Cheers
Frank Abel
On Jul 20, 2:57 am, Christian Hammond chip...@chipx86.com wrote:
Hi Frank,
It seems the line numbers have changed quite a bit between that version and
SVN HEAD, but the first thing to check is that hg is in your path.
If you run with --debug, you'll get more information about what command it's
trying to execute.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Sun, Jul 19, 2009 at 12:07 PM, frankabel frank.abel...@gmail.com wrote:
Hi all,
Here what I get while trying uses post-review command inside a
mercurial repo:
$ post-review --server=https://frankabel.cujae.edu.cu/reviewboard/
reviewboard/
https://frankabel.cujae.edu.cu/reviewboard/%0Areviewboard/--username=frankabel
--password=PpMeOv606 --revision-
range=35:38
Traceback (most recent call last):
File /usr/local/bin/post-review, line 5, in module
pkg_resources.run_script('RBTools==0.2beta1', 'post-review')
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 448,
in run_script
self.require(requires)[0].run_script(script_name, ns)
File /usr/lib/python2.6/dist-packages/pkg_resources.py, line 1173,
in run_script
exec script_code in namespace, namespace
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2313, in module
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2254, in main
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 2206, in
determine_client
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 744, in
get_repository_info
File /usr/local/lib/python2.6/dist-packages/RBTools-0.2beta1-
py2.6.egg/EGG-INFO/scripts/post-review, line 1898, in execute
File /usr/lib/python2.6/subprocess.py, line 595, in __init__
errread, errwrite)
File /usr/lib/python2.6/subprocess.py, line 1092, in
_execute_child
raise child_exception
OSError: [Errno 2] No such file or directory
$
Any help? What I'm doing wrong? If anybody have experience with
reviewboard and mercurial, would be nice see what about http://
groups.google.com/group/mercurial_general/browse_thread/thread/
b53558ae8182ba8chttp://groups.google.com/group/mercurial_general/browse_thread/thread...
Re: ClearCase and Reviewboard setup.
It is not required. post-review simply includes support for cygwin (i.e. path translation since cleartool does not understand cygwin paths). My example used sed and xargs to make it easier, so that's the only reason I suggested having the tools in your path. This feature can eventually be added to post-review to automatically collect checked out files. Dan On Jul 17, 6:50 am, 夏勇杰 notox...@gmail.com wrote: Hi Dan, I have some questions about post review. Should we install cygwin for post-review in order to make it work with Clearcase? On Jul 17, 9:32 am, Dan Savilonis d...@n-cube.org wrote: I went through a fresh installation of reviewboard with Clearcase today and recorded the steps. Here's what you need to do to get up and running. For the purpose of this test, I used a dynamic view and was running the server on the same machine as I had the view and did a review of checked out files. 1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin interface (Home Scmtools Tools), if using ReviewBoard 1.0. This step is not necessary if you're running svn revision = r2041. 2) Add a ClearCase repository via the admin interface, and specify a path to your view (I used the top of the view, not the vob). 3) Apply the patch fromhttp://reviews.review-board.org/r/906/toyour post-review script. 4) Edit post-review ClearCaseClient class. Change cc_rootpath to be identical to what you typed into the admin interface, change viewtype to 'dynamic' (if you're trying this with a dynamic view, of course) 4) Check out a file in the view and make a change 4) Run post-review in your view and pass a list of the files that you've checked out after the options. Alternatively if you're lazy like me, you can do something like (on windows, with cygwin, msys, etc, in your vob directory): cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs python post-review --server=http://example.com/ I tried using a snapshot view but it didn't work immediately for me and I haven't debugged it. It looked like it was trying to use a clearcase extended path. I assumed you could only use that notation within a dynamic view, but I'm probably wrong. Dan On Jul 10, 5:38 pm, Dan Savilonis d...@n-cube.org wrote: I will try to write up my experience as I can. (Un)fortunately, we're not using RB with Clearcase right now, as I run a rogue Clearcase-to- git system, and use RB with git :) At minimum right now, we need to get the the line from Bartek's patch to add split_line=TRUE committed or post-review will just fail for end users. If you can get the Clearcase SCMTool to be added to the list of scmtools by default, that would be great, too. I have no idea how to do that, though. Dan On Jul 10, 3:29 pm, Christian Hammond chip...@chipx86.com wrote: Hi djs, Since David and I have no ClearCase support or really test infrastructure, would I be able to convince you to write some entries for our docs on setting it up and using it? Nothing major, but it would be good if people were able to get it working easier than they are. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 10, 2009 at 7:22 AM, djs d...@n-cube.org wrote: Hi Oliver, Yes, Clearcase is in fact supported. We have tested out setting it up running on Windows here and were able to get it to working. The path should be the location of a dynamic view and you don't need cygwin to use it. There is code in post-review to support using cygwin or the regular cmd.exe on Windows. We did have to modify one line of code in post-review to get it to run successfully, at which point we were able to run post-review and pass a list of files are arguments. This uploaded a diff of the checked out files against their base revisions. I believe you also need to modify the hard-coded location in the post-review script for it to work. I will try to submit a patch in a few days to fix post-review. Let me know if you have any luck setting it up. Dan On Jul 10, 1:24 am, Oliver Jones orjo...@gmail.com wrote: According to the ReviewBoard 1.0 release notes ReviewBoard is supposed to support ClearCase out of the box. However once I had ReviewBoard 1.0 installed on my Windows server the config section's Scmtools area didn't mention ClearCase. After a little Googling I found that you need to add the ClearCase SCMTool manually into the DB. That I have done. Now I assume I need to add a repository. However I have no idea what to enter into the Path configuration item when adding the repo. This page contains info on determining the path with SVN, Git, etc, but not ClearCase: http://www.review
Re: ClearCase and Reviewboard setup.
The requirements to use post-review with clearcase are the same as with any other version control system. The only difference is you pass a list of filenames as arguments to the script that you want to review: python post-review --server=http://example.com/ file1.c file2.c file3.c If post-review doesn't work, easy_install rbtools should install the python dependencies. Dan On Jul 17, 8:11 pm, 吴开春 wukaic...@gmail.com wrote: 请教一下，你装起来用了没有？ On Jul 17, 10:23 pm, Dan Savilonis d...@n-cube.org wrote: It is not required. post-review simply includes support for cygwin (i.e. path translation since cleartool does not understand cygwin paths). My example used sed and xargs to make it easier, so that's the only reason I suggested having the tools in your path. This feature can eventually be added to post-review to automatically collect checked out files. Dan On Jul 17, 6:50 am, 夏勇杰 notox...@gmail.com wrote: Hi Dan, I have some questions about post review. Should we install cygwin for post-review in order to make it work with Clearcase? On Jul 17, 9:32 am, Dan Savilonis d...@n-cube.org wrote: I went through a fresh installation of reviewboard withClearcase today and recorded the steps. Here's what you need to do to get up and running. For the purpose of this test, I used a dynamic view and was running the server on the same machine as I had the view and did a review of checked out files. 1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin interface (Home Scmtools Tools), if using ReviewBoard 1.0. This step is not necessary if you're running svn revision = r2041. 2) Add aClearCaserepository via the admin interface, and specify a path to your view (I used the top of the view, not the vob). 3) Apply the patch fromhttp://reviews.review-board.org/r/906/toyour post-review script. 4) Edit post-review ClearCaseClient class. Change cc_rootpath to be identical to what you typed into the admin interface, change viewtype to 'dynamic' (if you're trying this with a dynamic view, of course) 4) Check out a file in the view and make a change 4) Run post-review in your view and pass a list of the files that you've checked out after the options. Alternatively if you're lazy like me, you can do something like (on windows, with cygwin, msys, etc, in your vob directory): cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs python post-review --server=http://example.com/ I tried using a snapshot view but it didn't work immediately for me and I haven't debugged it. It looked like it was trying to use a clearcaseextended path. I assumed you could only use that notation within a dynamic view, but I'm probably wrong. Dan On Jul 10, 5:38 pm, Dan Savilonis d...@n-cube.org wrote: I will try to write up my experience as I can. (Un)fortunately, we're not using RB withClearcaseright now, as I run a rogueClearcase-to- git system, and use RB with git :) At minimum right now, we need to get the the line from Bartek's patch to add split_line=TRUE committed or post-review will just fail for end users. If you can get theClearcaseSCMTool to be added to the list of scmtools by default, that would be great, too. I have no idea how to do that, though. Dan On Jul 10, 3:29 pm, Christian Hammond chip...@chipx86.com wrote: Hi djs, Since David and I have noClearCasesupport or really test infrastructure, would I be able to convince you to write some entries for our docs on setting it up and using it? Nothing major, but it would be good if people were able to get it working easier than they are. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 10, 2009 at 7:22 AM, djs d...@n-cube.org wrote: Hi Oliver, Yes,Clearcaseis in fact supported. We have tested out setting it up running on Windows here and were able to get it to working. The path should be the location of a dynamic view and you don't need cygwin to use it. There is code in post-review to support using cygwin or the regular cmd.exe on Windows. We did have to modify one line of code in post-review to get it to run successfully, at which point we were able to run post-review and pass a list of files are arguments. This uploaded a diff of the checked out files against their base revisions. I believe you also need to modify the hard-coded location in the post-review script for it to work. I will try to submit a patch in a few days to fix post-review. Let me know if you have any luck setting it up. Dan On Jul
Re: ClearCase and Reviewboard setup.
I went through a fresh installation of reviewboard with Clearcase today and recorded the steps. Here's what you need to do to get up and running. For the purpose of this test, I used a dynamic view and was running the server on the same machine as I had the view and did a review of checked out files. 1) Add reviewboard.scmtools.clearcase.ClearCaseTool in the admin interface (Home Scmtools Tools), if using ReviewBoard 1.0. This step is not necessary if you're running svn revision = r2041. 2) Add a ClearCase repository via the admin interface, and specify a path to your view (I used the top of the view, not the vob). 3) Apply the patch from http://reviews.review-board.org/r/906/ to your post-review script. 4) Edit post-review ClearCaseClient class. Change cc_rootpath to be identical to what you typed into the admin interface, change viewtype to 'dynamic' (if you're trying this with a dynamic view, of course) 4) Check out a file in the view and make a change 4) Run post-review in your view and pass a list of the files that you've checked out after the options. Alternatively if you're lazy like me, you can do something like (on windows, with cygwin, msys, etc, in your vob directory): cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs python post-review --server=http://example.com/ I tried using a snapshot view but it didn't work immediately for me and I haven't debugged it. It looked like it was trying to use a clearcase extended path. I assumed you could only use that notation within a dynamic view, but I'm probably wrong. Dan On Jul 10, 5:38 pm, Dan Savilonis d...@n-cube.org wrote: I will try to write up my experience as I can. (Un)fortunately, we're not using RB with Clearcase right now, as I run a rogue Clearcase-to- git system, and use RB with git :) At minimum right now, we need to get the the line from Bartek's patch to add split_line=TRUE committed or post-review will just fail for end users. If you can get the Clearcase SCMTool to be added to the list of scmtools by default, that would be great, too. I have no idea how to do that, though. Dan On Jul 10, 3:29 pm, Christian Hammond chip...@chipx86.com wrote: Hi djs, Since David and I have no ClearCase support or really test infrastructure, would I be able to convince you to write some entries for our docs on setting it up and using it? Nothing major, but it would be good if people were able to get it working easier than they are. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 10, 2009 at 7:22 AM, djs d...@n-cube.org wrote: Hi Oliver, Yes, Clearcase is in fact supported. We have tested out setting it up running on Windows here and were able to get it to working. The path should be the location of a dynamic view and you don't need cygwin to use it. There is code in post-review to support using cygwin or the regular cmd.exe on Windows. We did have to modify one line of code in post-review to get it to run successfully, at which point we were able to run post-review and pass a list of files are arguments. This uploaded a diff of the checked out files against their base revisions. I believe you also need to modify the hard-coded location in the post-review script for it to work. I will try to submit a patch in a few days to fix post-review. Let me know if you have any luck setting it up. Dan On Jul 10, 1:24 am, Oliver Jones orjo...@gmail.com wrote: According to the ReviewBoard 1.0 release notes ReviewBoard is supposed to support ClearCase out of the box. However once I had ReviewBoard 1.0 installed on my Windows server the config section's Scmtools area didn't mention ClearCase. After a little Googling I found that you need to add the ClearCase SCMTool manually into the DB. That I have done. Now I assume I need to add a repository. However I have no idea what to enter into the Path configuration item when adding the repo. This page contains info on determining the path with SVN, Git, etc, but not ClearCase: http://www.review-board.org/docs/manual/dev/admin/management/reposito... Is ClearCase actually supported?? Reading the post-review script it also appears that the clearcase code assumes you're using Cygwin. We do not have Cygwin installed here. And getting it installed could be difficult. It also seems to hard code the vob location. Can someone who has actually gotten ClearCase and ReviewBoard to play nice with each other in a Windows (non-Cygwin) environment help me out here. Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard
Re: ClearCase and Reviewboard setup.
I will try to write up my experience as I can. (Un)fortunately, we're not using RB with Clearcase right now, as I run a rogue Clearcase-to- git system, and use RB with git :) At minimum right now, we need to get the the line from Bartek's patch to add split_line=TRUE committed or post-review will just fail for end users. If you can get the Clearcase SCMTool to be added to the list of scmtools by default, that would be great, too. I have no idea how to do that, though. Dan On Jul 10, 3:29 pm, Christian Hammond chip...@chipx86.com wrote: Hi djs, Since David and I have no ClearCase support or really test infrastructure, would I be able to convince you to write some entries for our docs on setting it up and using it? Nothing major, but it would be good if people were able to get it working easier than they are. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Fri, Jul 10, 2009 at 7:22 AM, djs d...@n-cube.org wrote: Hi Oliver, Yes, Clearcase is in fact supported. We have tested out setting it up running on Windows here and were able to get it to working. The path should be the location of a dynamic view and you don't need cygwin to use it. There is code in post-review to support using cygwin or the regular cmd.exe on Windows. We did have to modify one line of code in post-review to get it to run successfully, at which point we were able to run post-review and pass a list of files are arguments. This uploaded a diff of the checked out files against their base revisions. I believe you also need to modify the hard-coded location in the post-review script for it to work. I will try to submit a patch in a few days to fix post-review. Let me know if you have any luck setting it up. Dan On Jul 10, 1:24 am, Oliver Jones orjo...@gmail.com wrote: According to the ReviewBoard 1.0 release notes ReviewBoard is supposed to support ClearCase out of the box. However once I had ReviewBoard 1.0 installed on my Windows server the config section's Scmtools area didn't mention ClearCase. After a little Googling I found that you need to add the ClearCase SCMTool manually into the DB. That I have done. Now I assume I need to add a repository. However I have no idea what to enter into the Path configuration item when adding the repo. This page contains info on determining the path with SVN, Git, etc, but not ClearCase: http://www.review-board.org/docs/manual/dev/admin/management/reposito... Is ClearCase actually supported?? Reading the post-review script it also appears that the clearcase code assumes you're using Cygwin. We do not have Cygwin installed here. And getting it installed could be difficult. It also seems to hard code the vob location. Can someone who has actually gotten ClearCase and ReviewBoard to play nice with each other in a Windows (non-Cygwin) environment help me out here. Thanks --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: 'git svn info' when using post-review and git?
Are you using post-review on a regular git repository? The check is there to determine if it is a git-svn repository (git repository that synchronizes with svn). I think it needs to come first because you can't directly check that a repository is pure git. Since git-svn is a perl script, I imagine that is part of the performance penalty. We could probably change it to do a more direct check, such as looking for the .git/svn directory. We'd need some git-svn users to test it out, though. Dan On Jul 8, 8:52 am, Petter Måhlén pettermah...@gmail.com wrote: Hi, Using post-review feels like it is a bit slower than necessary, and when using the --debug flag, it seems as if one of the main culprits is the execution of 'git svn info'. It takes several seconds to run for me. I am guessing it is used for 'git on top of SVN'? Would it be possible/reasonable to disable that check (and the other git svn commands, perhaps) if SVN is not relevant? Cheers, Petter --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Evolution failed during upgrade
I don't think I modified anything intentionally. I just copied the sqlite3 database file to the new location. The hint wasn't particularly helpful, it just stated 'field_type'. I wasn't aware that there was even anything in ReviewBoard about a bug tracker. I did build the install from the debian source package which has a few minor modifications, but it shouldn't affect this. The schema for the table is: CREATE TABLE scmtools_repository ( id integer NOT NULL PRIMARY KEY, name varchar(64) NOT NULL UNIQUE, path varchar(128) NOT NULL UNIQUE, mirror_path varchar(128) NOT NULL, username varchar(32) NOT NULL, password varchar(128) NOT NULL, tool_id integer NOT NULL REFERENCES scmtools_tool (id), bug_tracker varchar(200) NOT NULL, encoding varchar(32) NOT NULL ); CREATE INDEX scmtools_repository_tool_id ON scmtools_repository (tool_id); I tried changing it as well as dropping the table altogether and it still gives me the same error. Dan On Jan 19, 4:54 pm, Christian Hammond chip...@chipx86.com wrote: You can use: rb-site manage /path/to/site evolve -- --hint (note the -- before any parameters passed to manage) Did you at any point modify your models.py by hand? You shouldn't really be seeing this error. When you copied the database over, was this through a file copy or a database dump? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 8:40 AM, Dan Savilonis d...@n-cube.org wrote: I've run rb-site upgrade to try to upgrade an older ~svn1520 installation database. I have the a fresh easy_install installation from yesterday and copied the old database over, but I ran into the issue below. How do I get manage.py to run now that I'm on an egg installation toi debug this? I can't get it to find settings_local.py. Rebuilding directory structure Updating database There are unapplied evolutions for reviews. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Project signature has changed - an evolution is required Installing json fixture 'initial_data' from '/usr/lib/python2.5/site- packages/ReviewBoard-0.9.dev_20090118-py2.5.egg/reviewboard/scmtools/ fixtures'. Installed 6 object(s) from 1 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: In field 'bug_tracker': Property 'field_type' has changed Thanks, Dan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Evolution failed during upgrade
That did it. I just started over fresh with a new site directory, copied the database over and it went flawlessly. I had a debian package installed for django-evolution that was older so easy_install didn't install it as a dependency. Thanks, Dan On Jan 20, 4:18 pm, Christian Hammond chip...@chipx86.com wrote: I think the problem may be your version of django-evolution. Try to: 1) Remove the django_evolution* files/directories in /usr/lib/python2.5/site-packages (or python2.4, depending on the version you're using) 2) easy_install --upgrade django_evolution I think you just have an out-of-date version of this. Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Tue, Jan 20, 2009 at 8:42 AM, Dan Savilonis d...@n-cube.org wrote: I don't think I modified anything intentionally. I just copied the sqlite3 database file to the new location. The hint wasn't particularly helpful, it just stated 'field_type'. I wasn't aware that there was even anything in ReviewBoard about a bug tracker. I did build the install from the debian source package which has a few minor modifications, but it shouldn't affect this. The schema for the table is: CREATE TABLE scmtools_repository ( id integer NOT NULL PRIMARY KEY, name varchar(64) NOT NULL UNIQUE, path varchar(128) NOT NULL UNIQUE, mirror_path varchar(128) NOT NULL, username varchar(32) NOT NULL, password varchar(128) NOT NULL, tool_id integer NOT NULL REFERENCES scmtools_tool (id), bug_tracker varchar(200) NOT NULL, encoding varchar(32) NOT NULL ); CREATE INDEX scmtools_repository_tool_id ON scmtools_repository (tool_id); I tried changing it as well as dropping the table altogether and it still gives me the same error. Dan On Jan 19, 4:54 pm, Christian Hammond chip...@chipx86.com wrote: You can use: rb-site manage /path/to/site evolve -- --hint (note the -- before any parameters passed to manage) Did you at any point modify your models.py by hand? You shouldn't really be seeing this error. When you copied the database over, was this through a file copy or a database dump? Christian -- Christian Hammond - chip...@chipx86.com VMware, Inc. On Mon, Jan 19, 2009 at 8:40 AM, Dan Savilonis d...@n-cube.org wrote: I've run rb-site upgrade to try to upgrade an older ~svn1520 installation database. I have the a fresh easy_install installation from yesterday and copied the old database over, but I ran into the issue below. How do I get manage.py to run now that I'm on an egg installation toi debug this? I can't get it to find settings_local.py. Rebuilding directory structure Updating database There are unapplied evolutions for reviews. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required Project signature has changed - an evolution is required Installing json fixture 'initial_data' from '/usr/lib/python2.5/site- packages/ReviewBoard-0.9.dev_20090118-py2.5.egg/reviewboard/scmtools/ fixtures'. Installed 6 object(s) from 1 fixture(s) The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: In field 'bug_tracker': Property 'field_type' has changed Thanks, Dan --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
