Re: feature request: ability to suspend a review request
On Wednesday, August 29, 2018 at 6:29:43 PM UTC-4, Christian Hammond wrote: > > Hi James, > > I think this is an interesting idea. We'd need to talk about it more, see > how it'd fit into things, but it might be worth putting together. Either > natively or as an extension. > > A quicker option for now is to make use of the Note To Reviewers > extension, which gives you a text field below Testing Done that you can > populate with whatever information you want to communicate to reviewers. > The advantage of this is that the history of notes is recorded, just like > any other field, so people can see when the change was "suspended" and when > it was made available again for review. > Thanks for the quick reply. Yes, that would do as a work-around. It's pretty much equivalent to what I'm doing now. The downside is that it doesn't show up in the dashboard for the affected review, so if reviewers look there (rather than just clicking on email links), then the status is less clear. -- James Carlson 42.703N 71.076W -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
feature request: ability to suspend a review request
Every now and then, I need to tell my reviewers that there's a serious issue that makes their current review efforts moot. Sometimes it's a large change in the source repository, and I'd like to merge (and possibly redesign) before continuing. Sometimes it's due to someone's comment that sends me in a different direction. Sometimes it's due to late test results that show an issue that wasn't caught by the initial tests. Whatever the cause, I'd like to be able to "suspend" a review. I don't want to lose the existing review discussion, and I don't want to tell reviewers that I'm just going away, so Close->Discarded doesn't feel right. And there's no good way to just add a comment to the top of the review. Usually, I end up modifying the review "Description" or "Testing Done" field to indicate what's going on, but that seems less than adequate. Could we please have an "Update->Suspend" or something like that? The work flow would be relatively simple: the request stays suspended until a new diff or file is added, and then it goes back to normal. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: RBTools Ticket #4628: rbt patch --print cannot be run outside of a source tree
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4628/ -- New update by alexander For Beanbag, Inc. > RBTools > Ticket #4628 Reply: I'll look into this -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4581: Make it easier to generate links to specific comments
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4581/ -- New ticket #4581 by jameslin For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Enhancement -- Make it easier to generate links to specific comments == # What version are you running? 2.0.20, but I also checked demo.reviewboard.org (3.0 beta 2) # What's the URL of the page this enhancement relates to, if any? # Describe the enhancement and the motivation for it. I would like to be able to generate links to individual comments on a review request. Currently I do this by viewing the page source, finding the comment ID myself, and manually constructing an URL like http://demo.reviewboard.org/r/728/#comment_rcbt-1566 . Ideally the comment timestamp would be a link to that URL, which is what Facebook, Twitter, YouTube, Disqus, Socialcast, etc. do. # What operating system are you using? What browser? Firefox 55.0.2 on Windows 7 x64 SP1 # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4568: There is no way to discard changes to fields when discarding a review request
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4568/ -- New ticket #4568 by jameslin For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect -- There is no way to discard changes to fields when discarding a review request == # What version are you running? 2.0.20 # What's the URL of the page containing the problem? # What steps will reproduce the problem? 1. Publish a review request. 2. Discard the review request. 3. Reopen the review request. 4. Edit the description. Accept the change. 5. Click "Discard review request". # What is the expected output? What do you see instead? I expect that any changes I make are publicly visible only if I explicitly choose to a "publish" action. However, the changes to the description get saved even though I tried to discard them. I ran into this because I accidentally used post-review (I do not expect rbt to be different) to post a different change for review but accidentally reused the wrong review ID, thereby accidentally updating a discarded review request. I then tried to discard my update, but doing so committed the new change description. (Also of note is that the changes to the description do not appear in the "Review request changed" update.) # What operating system are you using? What browser? Firefox 55.0b13 x64, Windows 7 SP1 x64 # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Slack integration questions with Review Board
Greetings, I work for an enterprise customer of Review Board and we use it heavily as our de facto application for code reviews. We also rely upon Slack as our primarily line of real-time communication in engineering. I am aware that Review Board provides integrations for Slack. My main questions are: - Can the integration be configured to notify a user when they have been added to a new RB? - Can the user be reminded after a certain amount of time that they need to address an RB? Because we have multiple ACLs set up for a large codebase (100+ developers), its hard to keep track of how long an RB has been out and they often get lost in the mix of chat messages. Email is so common that it is hard to keep track of and requires individual configurations of inboxes. Thanks, James -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "reviewboard" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: Review Board Ticket #169: It'd be nice if comments showed an absolute timestamp too
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/169/ -- New update by jameslin For Beanbag, Inc. > Review Board > Ticket #169 Reply: Huh. So it does. (I could have sworn that I tried it before making comment #4...) IGNORE ME. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4492: "submitted TIME ago" message is wrong when comments are added to submitted review requests
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4492/ -- New ticket #4492 by jameslin For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect -- "submitted TIME ago" message is wrong when comments are added to submitted review requests == # What version are you running? 2.0.20, but I have confirmed that this bug still exists on demo.reviewboard.org (running 3.0 alpha 0 (dev)). # What's the URL of the page containing the problem? http://demo.reviewboard.org/r/69/ # What steps will reproduce the problem? 1. Create a review request. 2. Mark the review request as submitted. 3. Wait some amount of time. 4. Add a comment to the review request. # What is the expected output? What do you see instead? At the top of the review request originally was a message that looked like: Review Request #69 - Created Oct. 10, 2016 and submitted 3 weeks ago After adding a comment, the message looks like: Review Request #69 - Created Oct. 10, 2016 and submitted 0 minutes ago This is wrong. The message either should say "updated" instead of "submitted" or it should use the proper submit time rather than the update time. # What operating system are you using? What browser? Windows 7 Enterprise x64 SP1, Firefox 50.0.1 (32-bit) # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Review Board Ticket #4436: When only adding reviewers, can only those reviewers be emailed?
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4436/ -- New ticket #4436 by jameslin For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Enhancement -- When only adding reviewers, can only those reviewers be emailed? == # What version are you running? 2.0.20 # What's the URL of the page this enhancement relates to, if any? N/A # Describe the enhancement and the motivation for it. When publishing an edit to a review request, if the only thing that changed was the addition of new reviewers, could Review Board email only those people instead of emailing all reviewers? I wouldn't expect existing reviewers to care about being notified when other reviewers are added, and this would reduce some of the email that Review Board generates. # What operating system are you using? What browser? N/A # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: Happy Review Board user?
Hello, I can't say I'm a happy user yet since I haven't yet figured out how to make a simple alias to do the few things I want (we use post-commit review in feature branches) on the command line (read: Vim): 1) Starting from a feature branch for which I've posted review requests, get the full list of comments and unresolved issues, as text from standard out. 2) Starting from just a branch as above and providing a file name, get the full list of comments and unresolved issues for that file, as text from standard out. Assume for the moment that this isn't an unhelpful deluge of information in my use case. This would go 95% of the way towards making me a very happy user by allowing me to set it up so that I can quickly bring up other people's relevant comments while editing in Vim. My dream features, that would take me to 110% satisfaction: 3) Get the output from (2) in the format of the original text file with the comments interspersed in the correct locations, delineated using something like Git merge markers. This would let me open the file and deal with the comments one by one, while seeing them in the right place -- again, in my chosen editor, without opening a browser window, and without looking up manually in which review id the comments reside, etc. For long comment chains I could figure out folding, but this doesn't really happen to me. I could implement this myself if I can get the comments and issues along with the tagged line numbers. 4) It would be great to close issues individually, from Vim (or, again, whatever editor), as I fix them. If the ouput from (3) included an identifier for each issue, and if the API allowed one to close issues, this could easily become a single keypress while editing, rather than a trip to a new program. And of course ideally: 5) A proper Vim plugin to prevent me ever opening a browser window for Review Board. For this one, you're mostly off the hook of course; it's only your responsibility to make sure the API doesn't get in the way of a powerful plugin. That said, there aren't any maintained Vim plugins for RB, so I'm not sure that it is easy. I would love to figure this stuff out and try to offer you our endorsement/logo! Thanks for listening, and sorry if I have missed obvious solutions to the above... Cheers, James Blau tresata.com P.S. I don't speak for the whole company, the others I think are happy to use the web interface for all of this. On Thursday, September 18, 2014 at 8:30:24 PM UTC-4, Christian Hammond wrote: Hi everyone, Every so often, I like to poll the list and get a sense of who's using Review Board and how it's working out for you. It's been a while since I've last done this (I try not to make it a frequent thing). We have a Happy Users page (https://www.reviewboard.org/users/) where we list companies who are both happy with their experience with Review Board and are willing to let us list them publicly. This time around, we're hoping to get permission to show off some company logos, which may appear on the front page ofreviewboard.org. We'll be unveiling a whole new site design soon that will include some of these prominently, linking back to your company's site. So: 1) How's Review Board working out for you? 2) Can we list you on the site? If not, we'd still like to hear from you! 3) If we can list you, we'd love to include your logo. Who in your organization can we talk to about this? Feel free to reply privately or publicly! And thanks! Christian -- Christian Hammond -chri...@beanbaginc.com Review Board -https://www.reviewboard.org Beanbag, Inc. -https://www.beanbaginc.com -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
Repository options are configured as follows:
- Hosting Service: None - Custom Repository
- Repository Type: Git
- Path: git@myserver:mygroup/myproject.git
- Raw file URL
mask: http://myserver/mygroup/myproject/raw/develop/filename
For our repository:
- GitLab (7.4.3)
- The project as a develop branch.
- The project has deploy keys setup for our ReviewBoard server.
I'm not sure how this information could help (unless I'm missing
something). Just to make sure I've explained the scenario correctly:
- I have multiple commits in a local repository that have not been
pushed up into the repository ReviewBoard is tracking.
- I desire to add reviews to ReviewBoard based on my local commits so
they can be reviewed before I push it to the remote repository.
For example:
{ReviewBoard}
/\
||
\/
{Local} {Remote}
Commit 3
|
Commit 2
| Commit G
Commit 1/
| /
Commit F Commit F
| |
Commit E Commit E
In this example, I want to add Commit 1, 2 and 3 to ReviewBoard.
- I can add Commit 1 by uploading the patch to ReviewBoard.
- I can add Commit 2 by uploading the patch to ReviewBoard only when I
also provide the parent patch for Commit 1.
- ReviewBoard understands the base of Commit 2 since the Git full
index chain is completed (Commit F - Commit 1 - Commit 2)
- I *cannot* add Commit 3 since by uploading the patch to ReviewBoard
I cannot provided the parent patch of Commit 1 and Commit 2.
- ReviewBoard cannot interpret the chain of commits from Commit F
to Commit 3.
- If I upload Commit 3 and parent Commit 1, the missing index
is: Commit F - Commit 1 - ? - Commit 3
- If I upload Commit 3 and parent Commit 2, the missing index
is: Commit F - ? - Commit 2 - Commit 3
On Wednesday, April 22, 2015 at 6:03:48 PM UTC-4, David Trowbridge wrote:
How have you configured the repository on Review Board?
-David
On Wed, Apr 22, 2015 at 1:50 PM James Knight james.d...@live.com
javascript: wrote:
So I wasn't using RBTools but I figured I'd try it first to see a working
solution with rbt rather than using the web interface.
After installing and invoking `rbt`, the first commit of ten (10) created
my first review for me. As soon as I try performing an `rbt posh
full_commit_index` on the second or greater commits they fail. The
specific error for my case was:
$ rbt post 2c6346ea50d25a974f4819a372f252d34d35d0da
ERROR: Error validating diff
my_file: The file was not found in the repository.
I assume this is a valid error message since the file is created in the
first commit and ReviewBoard cannot interpret the parent state of the newer
commit(s). After looking at the documentation, I don't see a way to provide
a list of local parent commits which ReviewBoard can interpret the chain of
changes. I assume the only work around I can do is actually push up the
changes on the remote on a branch (something I wanted to avoid) and
reference the branch in rbt's `--parent` parameter when generating a review
for each pending commit.
On Thursday, April 16, 2015 at 2:37:30 PM UTC-4, Stephen Gallagher wrote:
On Thu, 2015-04-16 at 09:07 -0700, James Knight wrote:
I have the following scenario, I have a remote Git repository (powered
by GitLab) configured and working as expected with ReviewBoard (2.0.15). In
my local repository (cloned), I have a series of ten (10) commits I'm about
to push to the origin. Before I do this, I generate a (full indexed;
unified) patch for the respective commits and I want to put them into
ReviewBoard. Uploading the patches, I proceed as follows:
1. Make a new review. Select the first patch and upload to
ReviewBoard. The review is created.
2. Make a second review. Select the second patch and attempt to
upload to ReviewBoard. ReviewBoard complains the parent hash doesn't
exist.
I then upload my second patch with my first patch as a parent diff. The
review is created.
3. Attempt to make a third review. Select the third patch to upload
but find no way to upload since I cannot complete the parent chain of
diffs. Full stop.
The exact error message is as follows:
The file file (revision hash) was not found in the repository
Is there a way I can append multiple parent diff's for a review? My
attempts were to merge append patch 1 and 2 together, with no luck. Or,
am I attempting to use ReviewBoard in an incorrect way?
The only work around I see is waiting until I commit the new patches
into the remote repository before adding the other patches, for example:
1. Add patches 1 and 2 to respective reviews.
2. Reviews approved and patches committed.
3. Add patches 3
Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
First of all, thanks for the replies; I appreciate the help.
@Stephen Gallagher
I think this is were I am failing to communicate. I'm not trying to have my
Git repository or web viewer to represent the file hashes as I haven't
pushed anything to a remote Git repository. I'm hoping to avoid this by
providing raw patches with full Git indexes to fill in the gap.
I'm going off the concept I see here
https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/diff-list/
.
A parent diff can be uploaded along with the main diff. A parent diff is a
diff based on an existing commit in the repository, which will be applied
before the main diff. The parent diff will not be included in the diff
viewer. It’s useful when developing a change based on a branch that is not
yet committed. In this case, a parent diff of the parent branch would be
provided along with the diff of the new commit, and only the new commit
will be shown.
I'm assuming that ReviewBoard just doesn't support multiple parent diffs.
My current work around is to squash the series of parent commits for a
given patch and add rebase my commits off their respective squashed
parents. This will provide me with both my diff to review and a parent diff
that I can submit to ReviewBoard. For example:
{Local}
Commit 4
|
Commit 3
|
Commit 2 Commit 3b Commit 4b
| | |
Commit 1 Squash Commit 1-2 Squash Commit 1-3
| | |
|-|
|
Commit F
|
Commit E
-
- Make review 1 with `Commit 1` patch.
- Make review 2 with `Commit 2` patch with parent `Commit 1` patch.
- Make review 3 with `Commit 3b` patch with parent `Squash Commit 1-2`
patch.
- Make review 4 with `Commit 4b` patch with parent `Squash Commit 1-3`
patch.
Again, I know this isn't ideal but it works for now.
@David Trowbridge
I can't use the GitLab optional since it requires (to my knowledge) it's
either for online GitLab hosting (which it not what I'm using; using a
local GitLab CE installation) or requires an account setup on the GitLab
server (which again, will not for us since we use LDAP and favor deployment
keys). Unless there's another option I'm missing?
On Thursday, April 23, 2015 at 4:03:59 PM UTC-4, David Trowbridge wrote:
Yeah, the raw file URL needs to have the revision in there somewhere.
Since you're using GitLab, you should just choose GitLab instead of None
- Custom Repository
-David
On Thu, Apr 23, 2015 at 10:52 AM Stephen Gallagher
ste...@gallagherhome.com javascript: wrote:
On Thu, Apr 23, 2015 at 11:49 AM James Knight james.d...@live.com
javascript: wrote:
Repository options are configured as follows:
- Hosting Service: None - Custom Repository
- Repository Type: Git
- Path: git@myserver:mygroup/myproject.git
- Raw file URL mask: http://myserver/mygroup/myproject/raw/develop/
filename
This isn't going to work if you don't have a way to represent the
individual file hashes. That's why it can't find them to compare. What tool
are you using to view the files via the web? Generally, cgit and gitweb
work best.
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/d/optout.
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
Sorry, I don't understand.
My root patch has an addressable hash from the repository. When I initially
showed the following diagram, the intent was to show that my local and
ReviewBoard-watched remote repository are in sync.
{ReviewBoard}
/\
||
\/
{Local} {Remote}
Commit F Commit F
| |
Commit E Commit E
If I then make a commit in my local repository, generate a patch, I can
submit it successfully to ReviewBoard since all file indexes are
addressable:
/- (patch) - {ReviewBoard}
/ /\
/ ||
| \/
\ {Local} {Remote}
\
Commit 1
|
Commit F Commit F
| |
Commit E Commit E
The patch changes to existing file indexes will all exist in Commit F
(which ReviewBoard can handle) and any new files will have a zeroed-file
index. If I introduce a new file in commit 1, I'll have an entry in my diff
as follows:
diff --git a/newfile b/newfile
new file mode 100644
index
..E0C9035898DD52FC65C41454CEC9C4D2611BFB37
--- /dev/null
+++ b/newfile
Now, if I have a second commit which modifies the file
(E0C9035898DD52FC65C41454CEC9C4D2611BFB37) I've introduced in Commit 1,
ReviewBoard will not accept the patch since it cannot find the
E0C9035898DD52FC65C41454CEC9C4D2611BFB37 object.
/- (patch) - {ReviewBoard}-- Will fail.
/ /\
/ ||
| \/
\ {Local} {Remote}
\
Commit 2
|
Commit 1
|
Commit F Commit F
| |
Commit E Commit E
Luckily, ReviewBoard supports uploading parent DIFF's so I can bridge the
gap. By uploading my Commit 2 DIFF with a parent Commit 1 DIFF, ReviewBoard
accepts the patch with no issues. I assume that this is the case since
ReviewBoard has a list of all file indexes from Commit F and an overlay of
file indexes from the parent DIFF provided. Therefore, if my Commit 2 has
the following:
diff --git a/newfile b/newfile
new file mode 100644
index
E0C9035898DD52FC65C41454CEC9C4D2611BFB37..7E240DE74FB1ED08FA08D38063F6A6A91462A815
+++ a/newfile
+++ b/newfile
ReviewBoard can establish following:
-
E0C9035898DD52FC65C41454CEC9C4D2611BFB37 -
7E240DE74FB1ED08FA08D38063F6A6A91462A815
And the following will work:
/--- (parent patch) \
/\/
/ /- (patch) - {ReviewBoard}-- Will work.
/ / /\
/ / ||
| | \/
| \ {Local} {Remote}
\ \
\ Commit 2
\|
Commit 1
|
Commit F Commit F
| |
Commit E Commit E
This leads back to the initial question. If I had a third commit (or more),
how can I get ReviewBoard to interpret the changes? From what it looks
like, it doesn't seem possible. For example, if Commit 3 had the following:
diff --git a/newfile b/newfile
new file mode 100644
index
7E240DE74FB1ED08FA08D38063F6A6A91462A815..70C881D4A26984DDCE795F6F71817C9CF4480E79
+++ a/newfile
+++ b/newfile
There is no means which I can provide all three (3) DIFFs to ReviewBoard to
establish this chain:
-
E0C9035898DD52FC65C41454CEC9C4D2611BFB37 -
7E240DE74FB1ED08FA08D38063F6A6A91462A815 -
70C881D4A26984DDCE795F6F71817C9CF4480E79
I don't know how to explain it more than that. :(
On Thursday, April 23, 2015 at 6:09:41 PM UTC-4, Stephen Gallagher wrote:
You're missing the point though. You still have to have an addressable
hash from the repo in order to establish a baseline or else none of the
parent diffs will have anything to compare against.
On Thu, Apr 23, 2015 at 5:23 PM James Knight james.d...@live.com
javascript: wrote:
First of all, thanks for the replies; I appreciate the help.
@Stephen Gallagher
I think this is were I am failing to communicate. I'm not trying to have
my Git repository or web viewer to represent the file hashes as I haven't
pushed anything to a remote Git repository. I'm hoping to avoid this by
providing raw patches with full Git indexes to fill in the gap.
I'm going off the concept I see here
https://www.reviewboard.org/docs/manual/2.0/webapi/2.0/resources/diff-list/
.
A parent diff can be uploaded along with the main diff. A parent diff is
a diff based on an existing commit in the repository, which will be applied
before the main diff. The parent diff will not be included in the diff
viewer. It’s useful when developing a change based on a branch that is not
yet committed. In this case, a parent diff of the parent branch would be
provided along with the diff of the new commit, and only the new commit
will be shown.
I'm assuming that ReviewBoard just doesn't support multiple
Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
Ah, completely understand now. Sorry for the trouble folks.
Thanks Christian (and of course David and Stephen as well).
On Thursday, April 23, 2015 at 8:22:42 PM UTC-4, Christian Hammond wrote:
Hey James,
The problem really has to do with the limitations we're under when talking
to a Git repository. Let me go into that and then I'll go into how that
relates to what you're dealing with.
The reason that raw file URL field exists is because, with Git, it's not
possible to request a given file at a given SHA. You can clone the whole
repository, but that's not something Review Board can sanely do for every
change.
So, what we do instead is we build a URL, based off the mask provided,
that can give us the raw contents of a file, given a file path and a blob
SHA1.
We need this so that we have a source file to apply a patch on top of.
Without that, we can't show a side-by-side diff.
Some services provide such a URL. GitWeb, for instance, has one. GitLab
does not. For GitLab, we have to instead query their API to get the data we
need. That requires such things as API tokens and other IDs, which Review
Board has special code to deal with, but that only works when selecting
GitLab as a hosting service.
Without either a selected (compatible) hosting service or a suitable Raw
File URL, we just have no ability to get the data needed in order to render
a change consistently.
If you have such a URL but without the field for the SHA, and you're only
ever dealing with reviewing changes on top of the very latest revision in
the repository, it will work, but that's going to fail the very moment
someone puts something up for review that is based on an older commit (and
this will happen in real usage all the time), or on top of a commit in a
branch other than 'master'.
Now, as for the analysis you've done, and the need for a third file, the
reason this is at all a problem is because you don't have the above setup,
so you're having to play games with your repository in a way that just
doesn't work.
If you did have such a setup, what you'd do is generate a diff between the
latest upstream commit and the commit just before the one you want to post
for review. That diff may cover a whole number of commits, but it doesn't
matter. That's the parent diff. Once we fetch the proper source file from
the repository (using the hosting service or the raw file URL), we apply
the parent diff, and treat that as the base for the diff being reviewed.
Then, we apply the diff representing the commit(s) you want to actually
review.
RBTools takes care of all this automatically, letting you just do:
$ rbt post mysha
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Thu, Apr 23, 2015 at 4:16 PM, James Knight james.d...@live.com
javascript: wrote:
Sorry, I don't understand.
My root patch has an addressable hash from the repository. When I
initially showed the following diagram, the intent was to show that my
local and ReviewBoard-watched remote repository are in sync.
{ReviewBoard}
/\
||
\/
{Local} {Remote}
Commit F Commit F
| |
Commit E Commit E
If I then make a commit in my local repository, generate a patch, I can
submit it successfully to ReviewBoard since all file indexes are
addressable:
/- (patch) - {ReviewBoard}
/ /\
/ ||
| \/
\ {Local} {Remote}
\
Commit 1
|
Commit F Commit F
| |
Commit E Commit E
The patch changes to existing file indexes will all exist in Commit F
(which ReviewBoard can handle) and any new files will have a zeroed-file
index. If I introduce a new file in commit 1, I'll have an entry in my diff
as follows:
diff --git a/newfile b/newfile
new file mode 100644
index
..E0C9035898DD52FC65C41454CEC9C4D2611BFB37
--- /dev/null
+++ b/newfile
Now, if I have a second commit which modifies the file
(E0C9035898DD52FC65C41454CEC9C4D2611BFB37) I've introduced in Commit 1,
ReviewBoard will not accept the patch since it cannot find the
E0C9035898DD52FC65C41454CEC9C4D2611BFB37 object.
/- (patch) - {ReviewBoard}-- Will fail.
/ /\
/ ||
| \/
\ {Local} {Remote}
\
Commit 2
|
Commit 1
|
Commit F Commit F
| |
Commit E Commit E
Luckily, ReviewBoard supports uploading parent DIFF's so I can bridge the
gap. By uploading my Commit 2 DIFF with a parent Commit 1 DIFF, ReviewBoard
accepts the patch with no issues. I assume
Re: What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
So I wasn't using RBTools but I figured I'd try it first to see a working solution with rbt rather than using the web interface. After installing and invoking `rbt`, the first commit of ten (10) created my first review for me. As soon as I try performing an `rbt posh full_commit_index` on the second or greater commits they fail. The specific error for my case was: $ rbt post 2c6346ea50d25a974f4819a372f252d34d35d0da ERROR: Error validating diff my_file: The file was not found in the repository. I assume this is a valid error message since the file is created in the first commit and ReviewBoard cannot interpret the parent state of the newer commit(s). After looking at the documentation, I don't see a way to provide a list of local parent commits which ReviewBoard can interpret the chain of changes. I assume the only work around I can do is actually push up the changes on the remote on a branch (something I wanted to avoid) and reference the branch in rbt's `--parent` parameter when generating a review for each pending commit. On Thursday, April 16, 2015 at 2:37:30 PM UTC-4, Stephen Gallagher wrote: On Thu, 2015-04-16 at 09:07 -0700, James Knight wrote: I have the following scenario, I have a remote Git repository (powered by GitLab) configured and working as expected with ReviewBoard (2.0.15). In my local repository (cloned), I have a series of ten (10) commits I'm about to push to the origin. Before I do this, I generate a (full indexed; unified) patch for the respective commits and I want to put them into ReviewBoard. Uploading the patches, I proceed as follows: 1. Make a new review. Select the first patch and upload to ReviewBoard. The review is created. 2. Make a second review. Select the second patch and attempt to upload to ReviewBoard. ReviewBoard complains the parent hash doesn't exist. I then upload my second patch with my first patch as a parent diff. The review is created. 3. Attempt to make a third review. Select the third patch to upload but find no way to upload since I cannot complete the parent chain of diffs. Full stop. The exact error message is as follows: The file file (revision hash) was not found in the repository Is there a way I can append multiple parent diff's for a review? My attempts were to merge append patch 1 and 2 together, with no luck. Or, am I attempting to use ReviewBoard in an incorrect way? The only work around I see is waiting until I commit the new patches into the remote repository before adding the other patches, for example: 1. Add patches 1 and 2 to respective reviews. 2. Reviews approved and patches committed. 3. Add patches 3 and 4 to respective reviews. 4. Reviews approved and patches committed. 5. ~keep repeating until final patch is committed~ Any help would be appreciated. Try doing this: rbt post commit_id One at a time, from the oldest to the newest. Use *exactly* the commit ID as shown by 'git log'. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
What is the correct approach when attempting to add multiple pre-commit diff files? (Multiple Parent Diffs)
I have the following scenario, I have a remote Git repository (powered by GitLab) configured and working as expected with ReviewBoard (2.0.15). In my local repository (cloned), I have a series of ten (10) commits I'm about to push to the origin. Before I do this, I generate a (full indexed; unified) patch for the respective commits and I want to put them into ReviewBoard. Uploading the patches, I proceed as follows: 1. Make a new review. Select the first patch and upload to ReviewBoard. The review is created. 2. Make a second review. Select the second patch and attempt to upload to ReviewBoard. ReviewBoard complains the parent hash doesn't exist. I then upload my second patch with my first patch as a parent diff. The review is created. 3. Attempt to make a third review. Select the third patch to upload but find no way to upload since I cannot complete the parent chain of diffs. Full stop. The exact error message is as follows: The file file (revision hash) was not found in the repository Is there a way I can append multiple parent diff's for a review? My attempts were to merge append patch 1 and 2 together, with no luck. Or, am I attempting to use ReviewBoard in an incorrect way? The only work around I see is waiting until I commit the new patches into the remote repository before adding the other patches, for example: 1. Add patches 1 and 2 to respective reviews. 2. Reviews approved and patches committed. 3. Add patches 3 and 4 to respective reviews. 4. Reviews approved and patches committed. 5. ~keep repeating until final patch is committed~ Any help would be appreciated. -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: post-review: failed to execute command: svn diff
Hi Christian, We've upgrade one of our source repositories from CVS to SVN. I'm trying to post to reviewboard and am getting a similar issue as what is stated in this thread. I'm hoping you might be able to give me some suggestions. I've posted the question to stack overflow too. I'm trying to use reviewboard with SVN. Others in the office have got their system setup and are able to post (copies of a VM that got it working the first time). I've compared my system setup against theirs and things look the same, as far as I can tell. When I run the rbt post command I get: Failed to execute command: ['svn', 'diff', '--diff-cmd=diff', '--notice-ancestry ', '-r', 'BASE'] ['Index: main.cpp\n', '= ==\n', 'Usage: diff [OPTIONS] \n', '\n', 'Display the dif ferences between and in unified diff\n', format. OPTIONS are d iff extensions as described by 'svn help diff'.\n, Use '--' alone to indicate that no more options follow.\n, svn: E200012: 'diff' returned 2\n] I've made my svn client and gnu diff the first two things in my system path: C:\Program Files (x86)\GnuWin32\bin;C:\Program Files (x86)\CollabNet I'm running Windows 8 machine. Some detail. svn --version gives: svn, version 1.8.9 (r1591380) compiled Jun 6 2014, 03:53:07 on x86-microsoft-windows5.1.2600 Copyright (C) 2014 The Apache Software Foundation. This software consists of contributions made by many people; see the NOTICE file for more information. Subversion is open source software, see http://subversion.apache.org/ The following repository access (RA) modules are available: - ra_svn : Module for accessing a repository using the svn network protocol. - with Cyrus SASL authentication - handles 'svn' scheme - ra_local : Module for accessing a repository on local disk. - handles 'file' scheme - ra_serf : Module for accessing a repository via WebDAV protocol using serf. - using serf 1.3.4 - handles 'http' scheme - handles 'https' scheme diff --version gives: diff (GNU diffutils) 2.8.7 Written by Paul Eggert, Mike Haertel, David Hayes, Richard Stallman, and Len Tower. Copyright (C) 2004 Free Software Foundation, Inc. This is free software; see the source for copying conditions. There is NO warranty; not even for MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. Any thoughts or ideas on what I should check or what I'm missing? I'm going to post to the google group too to see if they have any ideas, if they have a solution I'll update this post too. Thanks, James On Tuesday, November 13, 2012 12:03:38 PM UTC-8, Christian Hammond wrote: It's just possible svn diff no longer supports the --diff option. I'm not at a computer right now, but does it appear at all in the help output? Christian On Nov 13, 2012, at 11:40, rb revie...@srmstar.net javascript: wrote: We have another user with this strange svn diff issue with post-review. I somehow got past this issue, completely by accident. Any help on resolution would be appreciated. Mark On Tue, October 30, 2012 9:49 am, rb wrote: On Tue, October 30, 2012 3:40 am, Christian Hammond wrote: What happens if you run: svn diff --diff-cmd=diff directly? Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com Christian, It is the same as the output from post-review debug. If I remove GNU diff from first in the path, post-review complains about not having GNU diff. Mark +++= C:\workareas\svn\test\rb-test svn up Updating '.': At revision 83. C:\workareas\svn\test\rb-test svn stat -u M 83 test.txt Status against revision: 83 C:\workareas\svn\test\rb-test svn diff test.txt Index: test.txt === --- test.txt(revision 83) +++ test.txt(working copy) @@ -1,3 +1,4 @@ +test test save this cahnge nire owewew C:\workareas\svn\test\rb-test post-review --debug RBTools 0.4.2 Python 2.7.3 (default, Apr 10 2012, 23:31:26) [MSC v.1500 32 bit (Intel)] Running on Windows-7-6.1.7601-SP1 Home = C:\Users\user1\AppData\Roaming Current Directory = C:\workareas\svn\test\rb-test Checking the repository type. Errors shown below are mostly harmless. DEBUG:root:Checking for a CVS repository... DEBUG:root:Checking for a ClearCase repository... DEBUG:root:Checking for a Git repository... DEBUG:root:Checking for a Mercurial repository... DEBUG:root:Checking for a Perforce repository... DEBUG:root:Checking for a Plastic repository... DEBUG:root:Checking for a Subversion
Re: post-review does not upload diff after upgrade from 1.6.5 to 1.7.21
Hi, I have problems after I did an upgrade from 1.6.5 to 1.7.21: 1. the new request no longer shows in my request, i have to point directly to the /r/123/ 2. the diff is not uploaded, but post-review didn't say anything wrong. where should i look at to trouble shoot these problems ? please help. thank you very much. James -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: post-review does not upload diff after upgrade from 1.6.5 to 1.7.21
Sorry I figured out that I screwed up the hostname in .reviewboradrc. All works fine now. Cheers James On Mon, Jan 27, 2014 at 10:07 AM, James Wang jwang@gmail.com wrote: Hi, I have problems after I did an upgrade from 1.6.5 to 1.7.21: 1. the new request no longer shows in my request, i have to point directly to the /r/123/ 2. the diff is not uploaded, but post-review didn't say anything wrong. where should i look at to trouble shoot these problems ? please help. thank you very much. James -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
What is the upgrade path from RB 1.6.5 to 1.7.21
hi, there: I would like to upgrade a RB 1.6.5 installation on CentOS 6.2 to 1.7.21, what is the recommended upgrade path ? Can i just upgrade directly as to run easy_install -U ReviewBoard? also I found the python version is 2.6.6 on the machine , do I need to upgrade the python? when add subversion repository in RB it complains pysvn is not installed. thank you very much for your help. Cheers James -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Reset review database?
Is there a way to reset the reviews in the database to 'state zero'? I just setup our reviewboard and I've been doing a lot of testing using RBT to establish our teams workflow and I just want to wipe out all those fake reviews/comments/diffs/attachements and start from scratch with a new counter (next review being #1) but not start the database over and have to reconfigure everything. Is there a way to do that with rb-site manage? Thanks -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Email not working on fresh 1.7.19 install
I figured it out, it was selinux. On Tuesday, December 3, 2013 1:41:51 PM UTC-5, Raja wrote: Can you check if the options in Admin--Review Emails--Email Settings are all checked? Regards Raja On Tue, Dec 3, 2013 at 7:36 PM, James Short sho...@gmail.comjavascript: wrote: I just setup reviewboard yesterday and everything is working except for email. I configured postfix minimally to just send emails and tested using the mail cli and it works fine from there, but reviewboard is not sending emails on closing requests etc. Is there additional config that I need to do? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Email not working on fresh 1.7.19 install
Also, now that emails are sending, when a new user is created, the email I get is from r...@domain.com where domain.com is not the correct domain. Also, the Sender field does not have the correct domain either. It is also nore...@domain.com where in the email configuration I have nore...@other.parts.of.the.domain.com. Any ideas on this? Thanks On Tuesday, December 3, 2013 3:27:53 PM UTC-5, Stephen Gallagher wrote: On 12/03/2013 03:18 PM, James Short wrote: I figured it out, it was selinux. If you are using the ReviewBoard RPMs from Fedora or EPEL, would you please file a Bugzilla ticket at https://bugzilla.redhat.com so we can get the policy corrected? -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Re: Authentication Failure with post-review
Thank you for your comments. I only put them there when the system would
not prompt me as I expected. I am aware that having them there is a bad
thing. If I could get post-review to run and prompt me for them as
expected, they would be gone.
I added an rc file to the repository root folder setitng only the
reviewboard_url property and it is still happening.
On Tuesday, July 23, 2013 1:19:18 PM UTC-5, Christian Hammond wrote:
Hi James,
While I'm not sure why it's not using what's in PASSWORD, I can say that
I would never recommend putting it there.
post-review will ask you for a password once and store a cookie. You
should just let it do that and use it. Otherwise, you're opening
yourself up to security risks.
You should have one .reviewboardrc, and it should live in the
repository. If you have that one there already, then post-review will
not see your own .reviewboardrc. In general, there's very few reasons to
have your own.
Christian
James Rivord wrote:
I am just getting ReviewBoard setup at my company, and the server works
fine. I can post a review using the web site and a diff file. The
problem is running the post-review tool. The server is running on Linux,
and the client is running on Windows. Installed all the Python tools as
directed. I created a .reviewboardrc file in my home folder with the
following.
REVIEWBOARD_URL = http://___;
USERNAME = ___
PASSWORD = ___
HTTP_USERNAME = ___
HTTP_PASSWORD = ___
I have configured it to use active directory.
Here is the error I get.
Traceback (most recent call last):
File C:\Program Files\Python33\Scripts\post-review-script.py, line 9,
in module
load_entry_point('rbtools==0.5.1', 'console_scripts', 'post-review')()
File C:\Program
Files\Python33\lib\site-packages\setuptools-0.9.6-py3.3.egg\pkg_resources.py,
line 378, in load_entry_point
File C:\Program
Files\Python33\lib\site-packages\setuptools-0.9.6-py3.3.egg\pkg_resources.py,
line 2566, in load_entry_point
File C:\Program
Files\Python33\lib\site-packages\setuptools-0.9.6-py3.3.egg\pkg_resources.py,
line 2260, in load
File frozen importlib._bootstrap, line 1567, in _find_and_load
File frozen importlib._bootstrap, line 1534, in
_find_and_load_unlocked
File C:\Program
Files\Python33\lib\site-packages\rbtools-0.5.1-py3.3.egg\rbtools\postreview.py,
line 164
print == HTTP Authentication Required
I know it says that authentication is required, but I have put the
authentication in the rc file, I have also tried specifying it on the
command line just in case. I have searched on everything that I can
think of and have not discovered what I am doing wrong. Any help would
be greatly appreciated.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard...@googlegroups.com javascript:
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/groups/opt_out.
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: Post-review thinks CVS diff file is empty
Hi Christian,
Did you guys ever figure out the issue with this? I'm receiving the same
errors both on the client and server side. Any help would be greatly
appreciated.
Thanks,
James
On Monday, September 26, 2011 4:59:39 PM UTC-7, Christian Hammond wrote:
Hi Matthew,
So I've seen this issue mentioned before with Review Board, but also with
CVS in general. It's possible it's us. Can you perhaps privately e-mail me
with the Path and Mirror Path field info on your Repository entry?
Here's a link to someone who's hit it with just plain ol' CVS and has some
workaround (though it's not very detailed):
http://devnet.jetbrains.net/thread/158342
Christian
--
Christian Hammond - chi...@chipx86.com javascript:
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Sep 26, 2011 at 4:26 PM, Matthew matt...@gmail.com
javascript:wrote:
I appreciate the quick help.
After enabling logging and running the commands again I get the output
below. I notice the absolute module reference points into the cvs
repository. After checking in the repository, there is no
Version.java, although there is Version.java,v. I don't know if
it's significant that this repository is a new import of the WorldWind
code for Review Board testing purposes, the only file that has ever
been checked out is Version.java, and it has never been checked back
in.
Matt (log follows)
[lihm@rbvm3 WorldWind]$ more /var/www/myserver.com/logs/
reviewboard.log
2011-09-26 16:12:33,711 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 2741
2011-09-26 16:12:33,712 - DEBUG - DiffParser.parse: Finished parsing
diff.
2011-09-26 16:12:33,832 - ERROR - Error uploading new diff: cvs
[checkout aborted]: Absolute module reference invalid: `/usr/local/c
vsroot/WorldWind/src/gov/nasa/worldwind/Version.java'
Traceback (most recent call last):
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/webapi/resources.py, line 1478, in create
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/reviews/forms.py, line 286, in create
history)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/diffviewer/forms.py, line 62, in create
files = list(self._process_files(
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/diffviewer/forms.py, line 144, in _process_files
if (revision != PRE_CREATION and
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/scmtools/core.py, line 70, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/scmtools/cvs.py, line 48, in get_file
return self.client.cat_file(path, revision)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/scmtools/cvs.py, line 248, in cat_file
return self._cat_specific_file(filename, revision)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.6.1-py2.4.egg/
reviewboard/scmtools/cvs.py, line 299, in _cat_specific_file
raise SCMError(errmsg)
SCMError: cvs [checkout aborted]: Absolute module reference invalid: `/
usr/local/cvsroot/WorldWind/src/gov/nasa/worldwind/Version.ja
va'
On Sep 26, 4:05 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Matthew,
It's entirely possible that that error is misleading. Looking at the
code,
it's possible that the same error code could be generated when there's
also
an unexpected error on Review Board's end.
If you have access to the reviewboard server logs, look for a line
starting
with Error uploading new diff:
That might give a better idea as to what's going on. Let me know what it
says.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Sep 26, 2011 at 3:57 PM, Matthew matt@gmail.com wrote:
The cvs command issued by post-review executes, but post-review
doesn't seem to think there are any diffs to upload. I'll include the
result of post-review --output-diff --debug at the end of this message
Although I have a software background it has been a long time since
I've done any sort of sysadmin work, and I'm not familiar with cvs or
python. So please use small words.
Any help would be appreciated.
Matt (post-review session below, had to change the server name, but
everything else is copied from xterm)
[lihm@rbvm3 WorldWind]$ post-review --output-diff --debug
RBTools 0.3.3
Home = /home/lihm
svn info
repository info: Path: myserver.com:8080/usr/local/cvsroot, Base
path:
None, Supports changesets: False
HTTP GETting api/
HTTP GETtinghttp://myserver.com/rbmain/api/info/
Using the new web API
cvs diff -uN
cvs diff: Diffing .
cvs diff: Diffing src
cvs
Re: Trouble installing Review Board offline
Thanks for your reply. That worked out great!
On Thursday, April 18, 2013 10:55:51 AM UTC-4, James Rice wrote:
In order to try out the product I need to set it up in a VM with no
external network connectivity (Don't ask.)
Using Ubuntu 12.04. I installed everything required and recommended on
this page
http://www.reviewboard.org/docs/manual/1.7/admin/installation/linux/
Then downloaded the tarball for 1.7.6. When I tried to install, it was
clear I needed Djblets, so I downloaded the 0.7.10 of that, and get the
following errors attempting to install. I then installed the
python-django-pipeline but it didn't make any difference. Can anyone point
me in the right direction? Thanks!
running install
Checking .pth file support in /usr/local/lib/python2.7/dist-packages/
/usr/bin/python -E -c pass
TEST PASSED: /usr/local/lib/python2.7/dist-packages/ appears to support
.pth files
running bdist_egg
running egg_info
running build_media
Traceback (most recent call last):
File ./contrib/internal/build-media.py, line 18, in module
ret = call_command('collectstatic', interactive=False, verbosity=2)
File
/usr/lib/python2.7/dist-packages/django/core/management/__init__.py, line
153, in call_command
klass = load_command_class(app_name, name)
File
/usr/lib/python2.7/dist-packages/django/core/management/__init__.py, line
68, in load_command_class
return module.Command()
File
/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py,
line 41, in __init__
self.storage = get_storage_class(settings.STATICFILES_STORAGE)()
File /usr/lib/python2.7/dist-packages/django/core/files/storage.py,
line 265, in get_storage_class
raise ImproperlyConfigured('Error importing storage module %s: %s' %
(module, e))
django.core.exceptions.ImproperlyConfigured: Error importing storage
module pipeline.storage: cannot import name CachedFilesMixin
Traceback (most recent call last):
File ./setup.py, line 125, in module
Topic :: Software Development :: Libraries :: Python Modules,
File /usr/lib/python2.7/distutils/core.py, line 152, in setup
dist.run_commands()
File /usr/lib/python2.7/distutils/dist.py, line 953, in run_commands
self.run_command(cmd)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File /usr/lib/python2.7/dist-packages/setuptools/command/install.py,
line 73, in run
self.do_egg_install()
File /usr/lib/python2.7/dist-packages/setuptools/command/install.py,
line 93, in do_egg_install
self.run_command('bdist_egg')
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File /usr/lib/python2.7/dist-packages/setuptools/command/bdist_egg.py,
line 172, in run
self.run_command(egg_info)
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File ./setup.py, line 47, in run
self.run_command('build_media')
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File ./setup.py, line 65, in run
raise RuntimeError('Failed to build media files')
RuntimeError: Failed to build media files
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Setting up a local git repository
Ok, maybe I am totally missing something, but bear with me. Went through the docs a couple of times, and searched through this group for the answer. I am only evaluating review board for my organization right now. We do not use a git server or gitweb or the like. We simply have a cm controlled git repository, and a local developer git repository cloned from CM The developer creates branches based on a change, and currently we use meld combined with a perl script for code review like git meld master...dev_branch. Perhaps this is a barbaric way to use git, we just transitioned recently, this is simple, and it works. So, is there a way to use Review board in this manner, with only a local repo? From the docs, from what I can see, if I do not have any hosting service, the only requirement to add a Git repository is a Name, Repository type, and Path, which should be the path containing the .git directory. If I do this, it states Unable to retrieve information for local Git repository. I have made sure the repo, including the .git objects are world readable. Any help would be appreciated. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
Trouble installing Review Board offline
In order to try out the product I need to set it up in a VM with no
external network connectivity (Don't ask.)
Using Ubuntu 12.04. I installed everything required and recommended on
this page
http://www.reviewboard.org/docs/manual/1.7/admin/installation/linux/
Then downloaded the tarball for 1.7.6. When I tried to install, it was
clear I needed Djblets, so I downloaded the 0.7.10 of that, and get the
following errors attempting to install. I then installed the
python-django-pipeline but it didn't make any difference. Can anyone point
me in the right direction? Thanks!
running install
Checking .pth file support in /usr/local/lib/python2.7/dist-packages/
/usr/bin/python -E -c pass
TEST PASSED: /usr/local/lib/python2.7/dist-packages/ appears to support
.pth files
running bdist_egg
running egg_info
running build_media
Traceback (most recent call last):
File ./contrib/internal/build-media.py, line 18, in module
ret = call_command('collectstatic', interactive=False, verbosity=2)
File
/usr/lib/python2.7/dist-packages/django/core/management/__init__.py, line
153, in call_command
klass = load_command_class(app_name, name)
File
/usr/lib/python2.7/dist-packages/django/core/management/__init__.py, line
68, in load_command_class
return module.Command()
File
/usr/lib/python2.7/dist-packages/django/contrib/staticfiles/management/commands/collectstatic.py,
line 41, in __init__
self.storage = get_storage_class(settings.STATICFILES_STORAGE)()
File /usr/lib/python2.7/dist-packages/django/core/files/storage.py,
line 265, in get_storage_class
raise ImproperlyConfigured('Error importing storage module %s: %s' %
(module, e))
django.core.exceptions.ImproperlyConfigured: Error importing storage module
pipeline.storage: cannot import name CachedFilesMixin
Traceback (most recent call last):
File ./setup.py, line 125, in module
Topic :: Software Development :: Libraries :: Python Modules,
File /usr/lib/python2.7/distutils/core.py, line 152, in setup
dist.run_commands()
File /usr/lib/python2.7/distutils/dist.py, line 953, in run_commands
self.run_command(cmd)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File /usr/lib/python2.7/dist-packages/setuptools/command/install.py,
line 73, in run
self.do_egg_install()
File /usr/lib/python2.7/dist-packages/setuptools/command/install.py,
line 93, in do_egg_install
self.run_command('bdist_egg')
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File /usr/lib/python2.7/dist-packages/setuptools/command/bdist_egg.py,
line 172, in run
self.run_command(egg_info)
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File ./setup.py, line 47, in run
self.run_command('build_media')
File /usr/lib/python2.7/distutils/cmd.py, line 326, in run_command
self.distribution.run_command(command)
File /usr/lib/python2.7/distutils/dist.py, line 972, in run_command
cmd_obj.run()
File ./setup.py, line 65, in run
raise RuntimeError('Failed to build media files')
RuntimeError: Failed to build media files
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
Re: rb-site install failed - ImportError: Entry point ('console_scripts', 'rb-site') not found
Nelson, May I ask what version of Django you were on, and what version you upgraded to? I'm getting the same error on CentOS 5 with EPEL, using ReviewBoard from yum. Thanks, - James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error of post-review: The current directory does not contain a checkout from a supported source code repository.
Haa, I found the problem caused by svn client. I use TortoiseSVN as my svn client in Windows, but it seems post-review could not communicate with svn server through TortoiseSVN. I installed command line svn, the problem solved. Thanks for you help! On Sep 28, 1:46 pm, Christian Hammond chip...@chipx86.com wrote: To determine if you're in a valid checkout, we run svn info and look for the text Repository Root. What do you see when you type that? If the output is localized, that's the problem, though we already try to force it to be English. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com 2011/9/27 James Tang tzl...@gmail.com But the problem is I already tried post-review in checkout svn directory(which contains a .svn folder), it still give me same words. How to solve this? Isn't post-review support windows7? On 9月27日, 下午4时24分, Christian Hammond chip...@chipx86.com wrote: Home has nothing to do with the checks. That's just for our own usage. You need to run post-review from within an SVN, CVS, Git, etc. checkout directory. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 26, 2011 at 10:52 PM, James Tang tzl...@gmail.com wrote: I run post-review in command line in Windows, below is the result: C:\Users\XXXpost-review -d RBTools 0.3.3 Home = C:\Users\Tang\AppData\Roaming The current directory does not contain a checkout from a supported source code repository. It seems post-review will search the user data folder for the checkout source code directory. How to change the Home setting? Or how to solve the problem if I put the checkout source code under C:\Users \XXX? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Can I do post-commite review on the website (without post-review tool)?
I think the post-review tool is a very nice tool for pre-commite reivew with reviewboard. But if I just want to do a post-commite review on my PC, where doesn't install svn client, what should I do? I ask so because I ever seen such a system, so I think I should not be a technical problem, right? Best regards. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Error of post-review: The current directory does not contain a checkout from a supported source code repository.
But the problem is I already tried post-review in checkout svn directory(which contains a .svn folder), it still give me same words. How to solve this? Isn't post-review support windows7? On 9月27日, 下午4时24分, Christian Hammond chip...@chipx86.com wrote: Home has nothing to do with the checks. That's just for our own usage. You need to run post-review from within an SVN, CVS, Git, etc. checkout directory. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 26, 2011 at 10:52 PM, James Tang tzl...@gmail.com wrote: I run post-review in command line in Windows, below is the result: C:\Users\XXXpost-review -d RBTools 0.3.3 Home = C:\Users\Tang\AppData\Roaming The current directory does not contain a checkout from a supported source code repository. It seems post-review will search the user data folder for the checkout source code directory. How to change the Home setting? Or how to solve the problem if I put the checkout source code under C:\Users \XXX? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
How to retrive the subversion's check in list from reviewboard when create a new request?
Hi, I'm new to reviewboard, and I build a reviewboard server on my host. Can you tell me how to retrive the subversion's check in list when I create a new request? Does the post-review tools necessary? I committed my source code with visual studio. Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Error of post-review: The current directory does not contain a checkout from a supported source code repository.
I run post-review in command line in Windows, below is the result: C:\Users\XXXpost-review -d RBTools 0.3.3 Home = C:\Users\Tang\AppData\Roaming The current directory does not contain a checkout from a supported source code repository. It seems post-review will search the user data folder for the checkout source code directory. How to change the Home setting? Or how to solve the problem if I put the checkout source code under C:\Users \XXX? Thanks. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Preventing commits from going through if status is still in review stage
Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james ja...@jenkins.sm.kernelfire.com Date: Mon Sep 12 11:50:22 2011 -0700 slim down repo --- SNIPPET --- Couldn't I then use the commit hash to identify the review request along with the git commit changeset? On Sep 12, 11:59 am, Christian Hammond chip...@chipx86.com wrote: There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Preventing commits from going through if status is still in review stage
On Sep 12, 12:35 pm, Christian Hammond chip...@chipx86.com wrote: No, not necessarily. When you post a diff, it generates a squashed diff, whichay mean the SHA1 will differ. Ah. Got it. We also just have no mechanism today to look up a review request by this sort of info. Yeah. This was more of a wishful feature request for a later release or something. Right now it seems like it's just an auto incremented review id. Christian On Monday, September 12, 2011, james james.ngu...@gmail.com wrote: The Python API or even a Restful call to the reviewboard would be nice. Then I could probably call reviewboard from a curl and check on the changeset status. For instance this is my git log: --- SNIPPET --- commit 08c36a414d56a7e1db26bfd7f5fabe2cb9d0aff7 Author: james ja...@jenkins.sm.kernelfire.com Date: Mon Sep 12 11:50:22 2011 -0700 slim down repo --- SNIPPET --- Couldn't I then use the commit hash to identify the review request along with the git commit changeset? On Sep 12, 11:59 am, Christian Hammond chip...@chipx86.com wrote: There's nothing we provide, as it varies quite a bit between installs, repository types, etc. Right now anything you do requires a fair bit of custom code. We're working on a formal Python API for Review Board, which will make this easier from a development standpoint. From a workflow standpoint, the difficulty is in identifying which commits are tied with which review requests. This is easier on a system like Subversion. Just have some field identifying the review request in the commit message. With Git, you'd have to be careful to have it in the commit message for a single commit, or in the message for a merge, in order for that to work the same. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Sep 12, 2011 at 11:36 AM, james james.ngu...@gmail.com wrote: Is there documentation on how to set this up with post-commit or pre- commit hooks where a user can't push changes into the repository unless the changeset has been reviewed and approved? I'm using git as our repo and so far I've gotten as far as being able to use post-review to submit a review request. Not I need to figure out a way to lock users from pushing to the central repo until their changeset has been reviewed and approved. Is there a workflow for this scenario? James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Need help on setup email?
hi, Christian: I have double checkd Pylucene is installed in python 2.6, but RB is using 2.7? how do I make RB can use the Pylucene or what should I install? and in the Admin page, I tried to use Active Directory as Authenticaion Method, but the lower portion of AD configuration are disabled/blocked, any idea what is missing? it's RB 1.5.6. thank you very much. cheers James On Tue, Aug 30, 2011 at 5:43 PM, Christian Hammond chip...@chipx86.comwrote: Hi James, On Tue, Aug 30, 2011 at 5:27 PM, James Wang jwang@gmail.com wrote: Hi, Christian: more questions: Enable Search box is always disabled, with Pylucene( with JCC ) is required to enable search. ' but i installed both already on this Ubuntu server. Try restarting the server to make sure that that check wasn't just cached. It very well may be that PyLucene wasn't installed in a place where RB could see it, though. Make sure they're using the same Python version. Is there a way to configure an(or a list of) email address to be always in the CC of all outgoing messages from RB? or at BCC? so that he is invisible from the eamil recipients? No. You'd have to modify Review Board to do this. And I found RB does not check in the code when the reviewer click 'Ship It'. It's not supposed to, nor could we guarantee that would work. The requirements to check in code varies between various types of repositories. We'd need the user's credentials, or maybe even a private SSH key. We'd likely need a checkout of the code, per-user, which could potentially be gigabytes each. We'd potentially conflict with their own commit, which may span multiple commits (think Git) and have carefully worded commit messages. And we'd need to somehow work with any other access control policies or other restrictions set up on the repositories. On top of that, we'd have to completely change how Ship It works. Who has the final say about a Ship It? How many Ship-Its constitutes a check-in? Does someone have more say than someone else? How do you handle that when code touches parts of a codebase for which different teams are responsible? Basically, it's not something we plan to do. Instead, we've chosen to keep Review Board simple, make it a tool about reviewing code and other files, and leaving the actual check-in process to the user, who is likely already set up for this. We get to keep the product simpler, reduce the amount of testing that has to be performed (thereby reducing the number of bugs), and we don't enforce policy on Ship Its. How does it possible to enforce a pre-commit review process so that reviewboard does the check-in after review process finished? is there a hook on ship it' or 'submitted' I have to configure? I believe some companies may have custom code that intercepts a commit before it happens, looks for a review request ID or URL in the commit message, checks with Review Board to see if it had permission to ship, and then decides whether to allow it. Again, that will vary greatly based on repository type and policy, so we don't have anything we can provide for it out of the box. I find that it's more effective to handle this outside the tool. Make this the policy in your organization. If people are committing code without getting it sufficiently reviewed, talk to them, or their manager. Some companies have pre-commit checks to look for a Reviewed by field containing a list of usernames, which I think helps people to be more honest about who actually reviewed it (and it's easy to call them out if there's no proof those people did review it). I know those aren't the answers you wanted, but I hope that helps in some way. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Need help on setup email?
Hi, Christian: more questions: Enable Search box is always disabled, with Pylucene( with JCC ) is required to enable search. ' but i installed both already on this Ubuntu server. Is there a way to configure an(or a list of) email address to be always in the CC of all outgoing messages from RB? or at BCC? so that he is invisible from the eamil recipients? And I found RB does not check in the code when the reviewer click 'Ship It'. How does it possible to enforce a pre-commit review process so that reviewboard does the check-in after review process finished? is there a hook on ship it' or 'submitted' I have to configure? tia cheers James On Mon, Aug 29, 2011 at 4:45 PM, James Wang jwang@gmail.com wrote: Hi, Christian: Thank you so much for such quick response. I did apt-get install python-imaging that fixed the issue. I'm running a Ubuntu 11.04 server. on client mostly windows/IE, some MacOSX/Safari will try the 1.6 later when it become stable, right now 1.5.6 seems working. Cheers James On Mon, Aug 29, 2011 at 4:21 PM, Christian Hammond chip...@chipx86.comwrote: Hi James, What browser are you using? You may have been bit by a bug that's been fixed since RC2, if using IE. That's a good reason to downgrade (or use our nightlies). E-mail should work if that option is disabled. As for the PIL issue, what system is this installed on? Most Linux distros provide a packaged version of PIL that handle all the image formats you'd care about. You probably want to just install that. On Ubuntu/Debian, this is python-imaging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 4:17 PM, James Wang jwang@gmail.comwrote: Hi, christian: no, many are not functioning in 1.6RC. for instance it kept saying 'draft cannot without summary' but i put text in the summary already thus i couldn't publish any request. Email is not working at all because of the error i reported. now i downgraded to 1.5.6, seems somehow start working. except this: I couldn't upload any screenshot, no matter .jpg or .png files, RB just says: Upload a valid image. The file you uploaded was either not an image or a corrupted image. i googled this and found that you mentioned in one post: PNG is supported, but it's possible that you (or your admin) compiled PIL (Python Imaging Library) and didn't have png development headers installed. could you please tell me how to install this png development header ? I also need the jpg file been supported too. tia cheers James On Mon, Aug 29, 2011 at 10:15 AM, Christian Hammond chip...@chipx86.com wrote: You'll need to hand-remove the package for 1.6RC2. It'll be in your Python's site-packages directory. You can search the filesystem for a ReviewBoard-1.6rc2*.egg directory. After that, just do a standard upgrade on the ReviewBoard package. Then you should be able to do an upgrade of your site directory. If that fails (we don't officially support downgrades), you may need to erase it and start over. However, if this is the only thing in 1.6 RC2 that you're having problems with, I don't suggest downgrading. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 10:10 AM, James Wang jwang@gmail.comwrote: hi, Christian: Thanks for the reply, I would like to re-install from scratch of 1.5.6. I did a easy_install -U ReviewBoard==1.5.6 early this morning, I think it screwed up the installation since there are more errors showing in the reviewboard.log. How do I un-install the existing ReviewBoard and back to the point that I can do a fresh re-instll 1.5.6? tia cheers James On Mon, Aug 29, 2011 at 9:45 AM, Christian Hammond chip...@chipx86.com wrote: Hi James, This is a problem specific to the 1.6 betas/RCs. It's a new feature that you won't find in older releases. It'll be fixed for 1.6 final (which I'm shooting for this weekend). Latest is generally the bust, but remember that 1.6 is not a finalized release. Given that this is a new feature, and likely hasn't had a lot of real-world testing due to 1.6 being in the beta state, some bugs are expected. You can't downgrade a 1.6 install to 1.5.x. You'd have to reinstall from scratch. For now, just disable that option. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 9:31 AM, James Wang jwang@gmail.comwrote: Is this problem related to 1.6RC2 specificly? I installed this version thought the latest is the best version. How do i un-install ReviewBoard so that i can re-install from fresh? or is there a way to downgrade from 1.6RC2 to 1.5.6? TIA cheers James On Fri, Aug 26
Re: Need help on setup email?
Is this problem related to 1.6RC2 specificly? I installed this version thought the latest is the best version. How do i un-install ReviewBoard so that i can re-install from fresh? or is there a way to downgrade from 1.6RC2 to 1.5.6? TIA cheers James On Fri, Aug 26, 2011 at 2:24 PM, James Wang jwang@gmail.com wrote: hi, I put my exchange server name in the 'Mail Server:' and port set to 25, leave username and password empty. I checked 'send email when new users register an account' box. Following is the log message after i create a user. is it something wrong in the code? 2011-08-26 14:16:22,706 - ERROR - Error sending e-mail notification with subject 'New Review Board user registration for test1' on behalf of 'test james jw...@company.com' to admin: sequence item 0: expected string, tuple found Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 376, in mail_new_user message.send() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 251, in send return self.get_connection(fail_silently).send_messages([self]) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 86, in send_messages sent = self._send(message) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 104, in _send email_message.message().as_string()) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 137, in message msg = super(SpiffyEmailMessage, self).message() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 221, in message msg['To'] = ', '.join(self.to) TypeError: sequence item 0: expected string, tuple found On Fri, Aug 26, 2011 at 11:53 AM, Christian Hammond chip...@chipx86.com wrote: Local sendmail is not supported today. You'll need an SMTP server. Christian On Friday, August 26, 2011, Kannaiyan Natesan gbpnk...@gmail.com wrote: Admin Settings Email Takes me to configure SMTP Settings. Not sure whether local sendmail is supported. On Fri, Aug 26, 2011 at 10:53 AM, James Wang jwang@gmail.com wrote: Hi, there: I'm new to linux, I followed installation document on administrator's guide, installed RB on a brand new installed Ubuntu Server 11.04. The RB site is up and running and I can create users, but no email was sent out. Actually I didn't find any instruction on configure email in the guide, Am I missing something? How does RB send out email and where to configure that? The ubuntu server can send out email relay to the exchange server I tried using mutt on that server machine to send a email and received from outlook on windows. so must be some configuration is missing in RB. please help. thanks in advance. Cheers James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- +1-650-605-3290 tel:%2B1-650-605-3290 The best things in life are free -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Need help on setup email?
Hi, christian: no, many are not functioning in 1.6RC. for instance it kept saying 'draft cannot without summary' but i put text in the summary already thus i couldn't publish any request. Email is not working at all because of the error i reported. now i downgraded to 1.5.6, seems somehow start working. except this: I couldn't upload any screenshot, no matter .jpg or .png files, RB just says: Upload a valid image. The file you uploaded was either not an image or a corrupted image. i googled this and found that you mentioned in one post: PNG is supported, but it's possible that you (or your admin) compiled PIL (Python Imaging Library) and didn't have png development headers installed. could you please tell me how to install this png development header ? I also need the jpg file been supported too. tia cheers James On Mon, Aug 29, 2011 at 10:15 AM, Christian Hammond chip...@chipx86.comwrote: You'll need to hand-remove the package for 1.6RC2. It'll be in your Python's site-packages directory. You can search the filesystem for a ReviewBoard-1.6rc2*.egg directory. After that, just do a standard upgrade on the ReviewBoard package. Then you should be able to do an upgrade of your site directory. If that fails (we don't officially support downgrades), you may need to erase it and start over. However, if this is the only thing in 1.6 RC2 that you're having problems with, I don't suggest downgrading. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 10:10 AM, James Wang jwang@gmail.comwrote: hi, Christian: Thanks for the reply, I would like to re-install from scratch of 1.5.6. I did a easy_install -U ReviewBoard==1.5.6 early this morning, I think it screwed up the installation since there are more errors showing in the reviewboard.log. How do I un-install the existing ReviewBoard and back to the point that I can do a fresh re-instll 1.5.6? tia cheers James On Mon, Aug 29, 2011 at 9:45 AM, Christian Hammond chip...@chipx86.com wrote: Hi James, This is a problem specific to the 1.6 betas/RCs. It's a new feature that you won't find in older releases. It'll be fixed for 1.6 final (which I'm shooting for this weekend). Latest is generally the bust, but remember that 1.6 is not a finalized release. Given that this is a new feature, and likely hasn't had a lot of real-world testing due to 1.6 being in the beta state, some bugs are expected. You can't downgrade a 1.6 install to 1.5.x. You'd have to reinstall from scratch. For now, just disable that option. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 9:31 AM, James Wang jwang@gmail.comwrote: Is this problem related to 1.6RC2 specificly? I installed this version thought the latest is the best version. How do i un-install ReviewBoard so that i can re-install from fresh? or is there a way to downgrade from 1.6RC2 to 1.5.6? TIA cheers James On Fri, Aug 26, 2011 at 2:24 PM, James Wang jwang@gmail.comwrote: hi, I put my exchange server name in the 'Mail Server:' and port set to 25, leave username and password empty. I checked 'send email when new users register an account' box. Following is the log message after i create a user. is it something wrong in the code? 2011-08-26 14:16:22,706 - ERROR - Error sending e-mail notification with subject 'New Review Board user registration for test1' on behalf of 'test james jw...@company.com' to admin: sequence item 0: expected string, tuple found Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 376, in mail_new_user message.send() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 251, in send return self.get_connection(fail_silently).send_messages([self]) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 86, in send_messages sent = self._send(message) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 104, in _send email_message.message().as_string()) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 137, in message msg = super(SpiffyEmailMessage, self).message() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 221, in message msg['To'] = ', '.join(self.to) TypeError: sequence item 0: expected string, tuple found On Fri, Aug 26, 2011 at 11:53 AM, Christian Hammond chip...@chipx86.com wrote: Local sendmail is not supported today. You'll need an SMTP server
Re: Need help on setup email?
Hi, Christian: Thank you so much for such quick response. I did apt-get install python-imaging that fixed the issue. I'm running a Ubuntu 11.04 server. on client mostly windows/IE, some MacOSX/Safari will try the 1.6 later when it become stable, right now 1.5.6 seems working. Cheers James On Mon, Aug 29, 2011 at 4:21 PM, Christian Hammond chip...@chipx86.comwrote: Hi James, What browser are you using? You may have been bit by a bug that's been fixed since RC2, if using IE. That's a good reason to downgrade (or use our nightlies). E-mail should work if that option is disabled. As for the PIL issue, what system is this installed on? Most Linux distros provide a packaged version of PIL that handle all the image formats you'd care about. You probably want to just install that. On Ubuntu/Debian, this is python-imaging. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 4:17 PM, James Wang jwang@gmail.com wrote: Hi, christian: no, many are not functioning in 1.6RC. for instance it kept saying 'draft cannot without summary' but i put text in the summary already thus i couldn't publish any request. Email is not working at all because of the error i reported. now i downgraded to 1.5.6, seems somehow start working. except this: I couldn't upload any screenshot, no matter .jpg or .png files, RB just says: Upload a valid image. The file you uploaded was either not an image or a corrupted image. i googled this and found that you mentioned in one post: PNG is supported, but it's possible that you (or your admin) compiled PIL (Python Imaging Library) and didn't have png development headers installed. could you please tell me how to install this png development header ? I also need the jpg file been supported too. tia cheers James On Mon, Aug 29, 2011 at 10:15 AM, Christian Hammond chip...@chipx86.comwrote: You'll need to hand-remove the package for 1.6RC2. It'll be in your Python's site-packages directory. You can search the filesystem for a ReviewBoard-1.6rc2*.egg directory. After that, just do a standard upgrade on the ReviewBoard package. Then you should be able to do an upgrade of your site directory. If that fails (we don't officially support downgrades), you may need to erase it and start over. However, if this is the only thing in 1.6 RC2 that you're having problems with, I don't suggest downgrading. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 10:10 AM, James Wang jwang@gmail.comwrote: hi, Christian: Thanks for the reply, I would like to re-install from scratch of 1.5.6. I did a easy_install -U ReviewBoard==1.5.6 early this morning, I think it screwed up the installation since there are more errors showing in the reviewboard.log. How do I un-install the existing ReviewBoard and back to the point that I can do a fresh re-instll 1.5.6? tia cheers James On Mon, Aug 29, 2011 at 9:45 AM, Christian Hammond chip...@chipx86.com wrote: Hi James, This is a problem specific to the 1.6 betas/RCs. It's a new feature that you won't find in older releases. It'll be fixed for 1.6 final (which I'm shooting for this weekend). Latest is generally the bust, but remember that 1.6 is not a finalized release. Given that this is a new feature, and likely hasn't had a lot of real-world testing due to 1.6 being in the beta state, some bugs are expected. You can't downgrade a 1.6 install to 1.5.x. You'd have to reinstall from scratch. For now, just disable that option. Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Mon, Aug 29, 2011 at 9:31 AM, James Wang jwang@gmail.comwrote: Is this problem related to 1.6RC2 specificly? I installed this version thought the latest is the best version. How do i un-install ReviewBoard so that i can re-install from fresh? or is there a way to downgrade from 1.6RC2 to 1.5.6? TIA cheers James On Fri, Aug 26, 2011 at 2:24 PM, James Wang jwang@gmail.comwrote: hi, I put my exchange server name in the 'Mail Server:' and port set to 25, leave username and password empty. I checked 'send email when new users register an account' box. Following is the log message after i create a user. is it something wrong in the code? 2011-08-26 14:16:22,706 - ERROR - Error sending e-mail notification with subject 'New Review Board user registration for test1' on behalf of 'test james jw...@company.com' to admin: sequence item 0: expected string, tuple found Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 376, in mail_new_user
Need help on setup email?
Hi, there: I'm new to linux, I followed installation document on administrator's guide, installed RB on a brand new installed Ubuntu Server 11.04. The RB site is up and running and I can create users, but no email was sent out. Actually I didn't find any instruction on configure email in the guide, Am I missing something? How does RB send out email and where to configure that? The ubuntu server can send out email relay to the exchange server I tried using mutt on that server machine to send a email and received from outlook on windows. so must be some configuration is missing in RB. please help. thanks in advance. Cheers James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Need help on setup email?
hi, I put my exchange server name in the 'Mail Server:' and port set to 25, leave username and password empty. I checked 'send email when new users register an account' box. Following is the log message after i create a user. is it something wrong in the code? 2011-08-26 14:16:22,706 - ERROR - Error sending e-mail notification with subject 'New Review Board user registration for test1' on behalf of 'test james jw...@company.com' to admin: sequence item 0: expected string, tuple found Traceback (most recent call last): File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 376, in mail_new_user message.send() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 251, in send return self.get_connection(fail_silently).send_messages([self]) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 86, in send_messages sent = self._send(message) File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/backends/smtp.py, line 104, in _send email_message.message().as_string()) File /usr/local/lib/python2.7/dist-packages/ReviewBoard-1.6rc2-py2.7.egg/reviewboard/notifications/email.py, line 137, in message msg = super(SpiffyEmailMessage, self).message() File /usr/local/lib/python2.7/dist-packages/Django-1.3-py2.7.egg/django/core/mail/message.py, line 221, in message msg['To'] = ', '.join(self.to) TypeError: sequence item 0: expected string, tuple found On Fri, Aug 26, 2011 at 11:53 AM, Christian Hammond chip...@chipx86.comwrote: Local sendmail is not supported today. You'll need an SMTP server. Christian On Friday, August 26, 2011, Kannaiyan Natesan gbpnk...@gmail.com wrote: Admin Settings Email Takes me to configure SMTP Settings. Not sure whether local sendmail is supported. On Fri, Aug 26, 2011 at 10:53 AM, James Wang jwang@gmail.com wrote: Hi, there: I'm new to linux, I followed installation document on administrator's guide, installed RB on a brand new installed Ubuntu Server 11.04. The RB site is up and running and I can create users, but no email was sent out. Actually I didn't find any instruction on configure email in the guide, Am I missing something? How does RB send out email and where to configure that? The ubuntu server can send out email relay to the exchange server I tried using mutt on that server machine to send a email and received from outlook on windows. so must be some configuration is missing in RB. please help. thanks in advance. Cheers James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- +1-650-605-3290 tel:%2B1-650-605-3290 The best things in life are free -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Can I install reviewboard on a ubuntu server separate from the SVN server?
hi, I didn't find this in the FAQ so i post the question here, Does Reviewboard must be installed on the same machine where the SVN server resides? I want to use reviewboard but I don't have root access to the SVN server, is it possible to install it on a seperate ubuntu server that i have root access? will this affect any feature of RB not working properly? thanks in advance? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Review Request Number
Hello, First I would like to say that you have created a very helpful tool. Thank you for your hard work. I have a simple request/question. I know when you use post-review to create a review, it will give you the review request number for your newly created request. This number can then be used again by post- review for updating the diff on that review. My question is how do you find this review request number within the ReviewBoard application? Why I ask is because our company is thinking about integrating reviewboard into our project release process, but we need a way to refer back to previous code reviews so that if the code gets audited we can prove that the code review took place. Providing the review request number on the dashboard and providing a way for searching reviews using this request number would greatly help. If there is an easy way to display this or (if not) can this be placed in a future release. Thanks you in advance for your reply! James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Hi Christian,
Did you get that URL I sent you? Did it look strange in any way?
I've also been experimenting with git-svn + post-review, hoping that
might work better. Unfortunately, it doesn't, but at least it's a
different problem:
$ post-review -dn
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info: Path: http://svn.company.net/svn/repositories/company,
Base path: /Project/trunk, Supports changesets: False
git merge-base master refs/heads/reviewboard-test
git diff --no-color --no-prefix -r -u
f58148b4094952c076861bcf4a9714ed7093d9ad..refs/heads/reviewboard-test
git svn find-rev f58148b4094952c076861bcf4a9714ed7093d9ad
None
The issue is that git svn find-rev returns nothing when passed a git
revision. It works when passed a subversion revision number, though.
Have you seen that before? Google didn't turn up anything.
-James
On Oct 20, 8:12 am, James jbaldass...@gmail.com wrote:
Sure, I'll send you the URL. Thanks for looking into it.
-James
On Oct 19, 8:09 pm, Christian Hammond chip...@chipx86.com wrote:
Hi James,
That is indeed strange. Without seeing the URL, it's hard to say. Is this
indeed a fully-qualified domain?
Just as a sanity check, would you feel comfortable e-mailing me privately
the full path?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Oct 19, 2010 at 4:26 PM, James jbaldass...@gmail.com wrote:
Hi,
I seem to be having the same problem as is described in this post:
http://groups.google.com/group/reviewboard/browse_thread/thread/96cc5...
On the client (post-review) side I see this:
---
Enter username and password for Please Enter Your [DOMAIN] LDAP
Credentials at reviewboard.domain.net
Username: user
Password:
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this
repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this
repository.', u'code': 210}}
Attempting to create review request on
http://svn.domain.net/svn/repositories/repoforNone
HTTP POSTing to
http://reviewboard.domain.net/api/json/reviewrequests/new/:
{'repository_path': 'http://svn.domain.net/svn/repositories/repo'}
Review request created
Uploading diff, size: 18990
HTTP POSTing to
http://reviewboard.domain.net/api/json/reviewrequests/31/diff/new/:
{'basedir': '/dir1/trunk'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [uURL '
http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'is
malformed or the scheme or host or path is missing]}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105},
u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
---
On the server side i see this:
---
2010-10-19 19:07:20,764 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 18990
2010-10-19 19:07:20,766 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-10-19 19:07:20,767 - ERROR - Error uploading new diff: URL
'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'
is malformed or the scheme or host or path is missing
Traceback (most recent call last):
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/reviews/forms.py, line 249, in create
history)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py, line 62, in create
files = list(self._process_files(
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py, line 144, in _process_files
if (revision != PRE_CREATION and
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/svn.py, line 144, in get_file
raise SCMError(e)
SCMError: URL 'http
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Well I figured out one issue. There was some problem with my git
repository. I did a fresh git svn clone, and I didn't have that find-
rev problem any more. However, now I'm back to the original SCMError
saying that the URL is malformed or the scheme or host or path is
missing on the ReviewBoard server.
-James
On Oct 21, 3:00 pm, James jbaldass...@gmail.com wrote:
Hi Christian,
Did you get that URL I sent you? Did it look strange in any way?
I've also been experimenting with git-svn + post-review, hoping that
might work better. Unfortunately, it doesn't, but at least it's a
different problem:
$ post-review -dn svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info: Path:http://svn.company.net/svn/repositories/company,
Base path: /Project/trunk, Supports changesets: False
git merge-base master refs/heads/reviewboard-test
git diff --no-color --no-prefix -r -u
f58148b4094952c076861bcf4a9714ed7093d9ad..refs/heads/reviewboard-test
git svn find-rev f58148b4094952c076861bcf4a9714ed7093d9ad
None
The issue is that git svn find-rev returns nothing when passed a git
revision. It works when passed a subversion revision number, though.
Have you seen that before? Google didn't turn up anything.
-James
On Oct 20, 8:12 am, James jbaldass...@gmail.com wrote:
Sure, I'll send you the URL. Thanks for looking into it.
-James
On Oct 19, 8:09 pm, Christian Hammond chip...@chipx86.com wrote:
Hi James,
That is indeed strange. Without seeing the URL, it's hard to say. Is this
indeed a fully-qualified domain?
Just as a sanity check, would you feel comfortable e-mailing me privately
the full path?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Tue, Oct 19, 2010 at 4:26 PM, James jbaldass...@gmail.com wrote:
Hi,
I seem to be having the same problem as is described in this post:
http://groups.google.com/group/reviewboard/browse_thread/thread/96cc5...
On the client (post-review) side I see this:
---
Enter username and password for Please Enter Your [DOMAIN] LDAP
Credentials at reviewboard.domain.net
Username: user
Password:
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat':
u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this
repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching
extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat':
u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this
repository.', u'code': 210}}
Attempting to create review request on
http://svn.domain.net/svn/repositories/repoforNone
HTTP POSTing to
http://reviewboard.domain.net/api/json/reviewrequests/new/:
{'repository_path': 'http://svn.domain.net/svn/repositories/repo'}
Review request created
Uploading diff, size: 18990
HTTP POSTing to
http://reviewboard.domain.net/api/json/reviewrequests/31/diff/new/:
{'basedir': '/dir1/trunk'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [uURL '
http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'is
malformed or the scheme or host or path is missing]}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105},
u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
---
On the server side i see this:
---
2010-10-19 19:07:20,764 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 18990
2010-10-19 19:07:20,766 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-10-19 19:07:20,767 - ERROR - Error uploading new diff: URL
'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'
is malformed or the scheme or host or path is missing
Traceback (most recent call last):
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/reviews/forms.py, line 249, in create
history)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py, line 62, in create
files = list(self._process_files(
File /usr/lib
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
I traced the problem to line 287 in svn.py:
try:
info = client.info2(path, recurse=False)
logging.debug('SVN: Got repository information for %s: %s' %
(path, info))
except ClientError, e:
...
raise RepositoryNotFoundError()
I fired up a python shell and can now reproduce the error:
pysvn._pysvn_2_4.ClientError: URL 'http://svn.company.net/svn/
repositories/company' is malformed or the scheme or host or path is
missing
I guess that's a good first step. It seems like this must be some
problem with pysvn, the svn client/libraries, the neon library
(LD_LIBRARY_PATH?), or the configuration of our svn server. I'm not
really sure where to start looking next, though. Maybe I'll try
installing ReviewBoard on my laptop and have it point to our SVN
server. That might at least tell me if it's the client or server.
-James
On Oct 21, 7:00 pm, James jbaldass...@gmail.com wrote:
I went into the admin UI, removed the SVN repository, and then tried
to add it back in, but it keeps failing. In the server logs I see:
ERROR - SVN: Failed to get repository information
forhttp://svn.company.net/svn/repositories/company/:URL 'http://
svn.company.net/svn/repositories/company' is malformed or the scheme
or host or path is missing
On the machine where ReviewBoard is running (which also happens to be
where SVN is running) I did the following to make sure that it can
talk to SVN, resolve hostnames, etc.:
svn cohttp://svn.company.net/svn/repositories/company/project/trunk
project
This worked fine, so I guess SVN is working ok. Here's the output of
svn --version in case that helps:
--
svn, version 1.6.11 (r934486)
compiled Apr 20 2010, 00:24:22
Copyright (C) 2000-2009 CollabNet.
Subversion is open source software, seehttp://subversion.tigris.org/
This product includes software developed by CollabNet
(http://www.Collab.Net/).
The following repository access (RA) modules are available:
* ra_neon : Module for accessing a repository via WebDAV protocol
using Neon.
- handles 'http' scheme
- handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network
protocol.
- with Cyrus SASL authentication
- handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
- handles 'file' scheme
--
I wonder if something with the basic auth on the SVN DAV server is
causing problems? Does RB/SVN need to do an HTTP PROPFIND or OPTIONS
without authenticating?
-James
On Oct 21, 5:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
Yeah, got the URL, but nothing stands out as being wrong. That's very
strange.
Can you go into the admin UI, click on Repositories - your SVN repository,
and resave it? That should re-check the server for validity. If that fails,
we know something is definitely wrong there with the repository path.
Is the path set to the root of the SVN repository, or some location within
it?
I haven't seen that problem with git svn find-rev. What version of git are
you using? I know other people (ourselves included at one point) were using
git-svn locally, with Review Board hosted in SVN.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Oct 21, 2010 at 12:00 PM, James jbaldass...@gmail.com wrote:
Hi Christian,
Did you get that URL I sent you? Did it look strange in any way?
I've also been experimenting with git-svn + post-review, hoping that
might work better. Unfortunately, it doesn't, but at least it's a
different problem:
$ post-review -dn
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info: Path:http://svn.company.net/svn/repositories/company,
Base path: /Project/trunk, Supports changesets: False
git merge-base master refs/heads/reviewboard-test
git diff --no-color --no-prefix -r -u
f58148b4094952c076861bcf4a9714ed7093d9ad..refs/heads/reviewboard-test
git svn find-rev f58148b4094952c076861bcf4a9714ed7093d9ad
None
The issue is that git svn find-rev returns nothing when passed a git
revision. It works when passed a subversion revision number, though.
Have you seen that before? Google didn't turn up anything.
-James
On Oct 20, 8:12 am, James jbaldass...@gmail.com wrote:
Sure, I'll send you the URL. Thanks for looking into it.
-James
On Oct 19, 8:09 pm, Christian Hammond chip...@chipx86.com wrote:
Hi James,
That is indeed strange. Without seeing the URL, it's hard to say. Is
this
indeed a fully-qualified domain?
Just as a sanity check, would you feel comfortable e-mailing me
privately
the full path?
Christian
--
Christian Hammond - chip...@chipx86.com
Review
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
I installed RB on my laptop, pointed it at the same SVN server, and it
works fine. There must be something wrong with the SVN client,
libraries, or pysvn on that server. I'm not sure what the problem is
there, but I'll either try a clean install on that machine or just
install it on a different server.
Thanks,
James
On Oct 21, 7:42 pm, James jbaldass...@gmail.com wrote:
I traced the problem to line 287 in svn.py:
try:
info = client.info2(path, recurse=False)
logging.debug('SVN: Got repository information for %s: %s' %
(path, info))
except ClientError, e:
...
raise RepositoryNotFoundError()
I fired up a python shell and can now reproduce the error:
pysvn._pysvn_2_4.ClientError: URL 'http://svn.company.net/svn/
repositories/company' is malformed or the scheme or host or path is
missing
I guess that's a good first step. It seems like this must be some
problem with pysvn, the svn client/libraries, the neon library
(LD_LIBRARY_PATH?), or the configuration of our svn server. I'm not
really sure where to start looking next, though. Maybe I'll try
installing ReviewBoard on my laptop and have it point to our SVN
server. That might at least tell me if it's the client or server.
-James
On Oct 21, 7:00 pm, James jbaldass...@gmail.com wrote:
I went into the admin UI, removed the SVN repository, and then tried
to add it back in, but it keeps failing. In the server logs I see:
ERROR - SVN: Failed to get repository information
forhttp://svn.company.net/svn/repositories/company/:URL'http://
svn.company.net/svn/repositories/company' is malformed or the scheme
or host or path is missing
On the machine where ReviewBoard is running (which also happens to be
where SVN is running) I did the following to make sure that it can
talk to SVN, resolve hostnames, etc.:
svn cohttp://svn.company.net/svn/repositories/company/project/trunk
project
This worked fine, so I guess SVN is working ok. Here's the output of
svn --version in case that helps:
--
svn, version 1.6.11 (r934486)
compiled Apr 20 2010, 00:24:22
Copyright (C) 2000-2009 CollabNet.
Subversion is open source software, seehttp://subversion.tigris.org/
This product includes software developed by CollabNet
(http://www.Collab.Net/).
The following repository access (RA) modules are available:
* ra_neon : Module for accessing a repository via WebDAV protocol
using Neon.
- handles 'http' scheme
- handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network
protocol.
- with Cyrus SASL authentication
- handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
- handles 'file' scheme
--
I wonder if something with the basic auth on the SVN DAV server is
causing problems? Does RB/SVN need to do an HTTP PROPFIND or OPTIONS
without authenticating?
-James
On Oct 21, 5:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
Yeah, got the URL, but nothing stands out as being wrong. That's very
strange.
Can you go into the admin UI, click on Repositories - your SVN
repository,
and resave it? That should re-check the server for validity. If that
fails,
we know something is definitely wrong there with the repository path.
Is the path set to the root of the SVN repository, or some location within
it?
I haven't seen that problem with git svn find-rev. What version of git are
you using? I know other people (ourselves included at one point) were
using
git-svn locally, with Review Board hosted in SVN.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Oct 21, 2010 at 12:00 PM, James jbaldass...@gmail.com wrote:
Hi Christian,
Did you get that URL I sent you? Did it look strange in any way?
I've also been experimenting with git-svn + post-review, hoping that
might work better. Unfortunately, it doesn't, but at least it's a
different problem:
$ post-review -dn
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info:
Path:http://svn.company.net/svn/repositories/company,
Base path: /Project/trunk, Supports changesets: False
git merge-base master refs/heads/reviewboard-test
git diff --no-color --no-prefix -r -u
f58148b4094952c076861bcf4a9714ed7093d9ad..refs/heads/reviewboard-test
git svn find-rev f58148b4094952c076861bcf4a9714ed7093d9ad
None
The issue is that git svn find-rev returns nothing when passed a git
revision. It works when passed a subversion revision number, though.
Have you seen that before? Google didn't turn up anything.
-James
On Oct 20, 8:12 am, James
Re: SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Well I finally got it working. After narrowing down the problem to
pysvn I checked out the pysvn shared library with ldd and noticed that
it was linked against two different versions of libneon. I removed
the conflicting version of the libneon library, recompiled pysvn, and
now everything is working!
-James
On Oct 21, 8:45 pm, James jbaldass...@gmail.com wrote:
I installed RB on my laptop, pointed it at the same SVN server, and it
works fine. There must be something wrong with the SVN client,
libraries, or pysvn on that server. I'm not sure what the problem is
there, but I'll either try a clean install on that machine or just
install it on a different server.
Thanks,
James
On Oct 21, 7:42 pm, James jbaldass...@gmail.com wrote:
I traced the problem to line 287 in svn.py:
try:
info = client.info2(path, recurse=False)
logging.debug('SVN: Got repository information for %s: %s' %
(path, info))
except ClientError, e:
...
raise RepositoryNotFoundError()
I fired up a python shell and can now reproduce the error:
pysvn._pysvn_2_4.ClientError: URL 'http://svn.company.net/svn/
repositories/company' is malformed or the scheme or host or path is
missing
I guess that's a good first step. It seems like this must be some
problem with pysvn, the svn client/libraries, the neon library
(LD_LIBRARY_PATH?), or the configuration of our svn server. I'm not
really sure where to start looking next, though. Maybe I'll try
installing ReviewBoard on my laptop and have it point to our SVN
server. That might at least tell me if it's the client or server.
-James
On Oct 21, 7:00 pm, James jbaldass...@gmail.com wrote:
I went into the admin UI, removed the SVN repository, and then tried
to add it back in, but it keeps failing. In the server logs I see:
ERROR - SVN: Failed to get repository information
forhttp://svn.company.net/svn/repositories/company/:URL'http://
svn.company.net/svn/repositories/company' is malformed or the scheme
or host or path is missing
On the machine where ReviewBoard is running (which also happens to be
where SVN is running) I did the following to make sure that it can
talk to SVN, resolve hostnames, etc.:
svn cohttp://svn.company.net/svn/repositories/company/project/trunk
project
This worked fine, so I guess SVN is working ok. Here's the output of
svn --version in case that helps:
--
svn, version 1.6.11 (r934486)
compiled Apr 20 2010, 00:24:22
Copyright (C) 2000-2009 CollabNet.
Subversion is open source software, seehttp://subversion.tigris.org/
This product includes software developed by CollabNet
(http://www.Collab.Net/).
The following repository access (RA) modules are available:
* ra_neon : Module for accessing a repository via WebDAV protocol
using Neon.
- handles 'http' scheme
- handles 'https' scheme
* ra_svn : Module for accessing a repository using the svn network
protocol.
- with Cyrus SASL authentication
- handles 'svn' scheme
* ra_local : Module for accessing a repository on local disk.
- handles 'file' scheme
--
I wonder if something with the basic auth on the SVN DAV server is
causing problems? Does RB/SVN need to do an HTTP PROPFIND or OPTIONS
without authenticating?
-James
On Oct 21, 5:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi,
Yeah, got the URL, but nothing stands out as being wrong. That's very
strange.
Can you go into the admin UI, click on Repositories - your SVN
repository,
and resave it? That should re-check the server for validity. If that
fails,
we know something is definitely wrong there with the repository path.
Is the path set to the root of the SVN repository, or some location
within
it?
I haven't seen that problem with git svn find-rev. What version of git
are
you using? I know other people (ourselves included at one point) were
using
git-svn locally, with Review Board hosted in SVN.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Oct 21, 2010 at 12:00 PM, James jbaldass...@gmail.com wrote:
Hi Christian,
Did you get that URL I sent you? Did it look strange in any way?
I've also been experimenting with git-svn + post-review, hoping that
might work better. Unfortunately, it doesn't, but at least it's a
different problem:
$ post-review -dn
svn info
git rev-parse --git-dir
git symbolic-ref -q HEAD
git svn info
repository info:
Path:http://svn.company.net/svn/repositories/company,
Base path: /Project/trunk, Supports changesets: False
git merge-base
SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is malformed or the scheme or host or path is missing
Hi,
I seem to be having the same problem as is described in this post:
http://groups.google.com/group/reviewboard/browse_thread/thread/96cc585e78b71033/904fb717a35f9f2c
On the client (post-review) side I see this:
---
Enter username and password for Please Enter Your [DOMAIN] LDAP
Credentials at reviewboard.domain.net
Username: user
Password:
HTTP GETting /api/json/repositories/1/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this repository.', u'code': 210}}
HTTP GETting /api/json/repositories/4/info/
Got API Error 210 (HTTP code 200): There was an error fetching extended
information for this repository.
Error data: {u'deprecated': {u'in_version': u'1.5'}, u'stat': u'fail',
u'err': {u'msg': u'There was an error fetching extended information for
this repository.', u'code': 210}}
Attempting to create review request on
http://svn.domain.net/svn/repositories/repo for None
HTTP POSTing to http://reviewboard.domain.net/api/json/reviewrequests/new/:
{'repository_path': 'http://svn.domain.net/svn/repositories/repo'}
Review request created
Uploading diff, size: 18990
HTTP POSTing to
http://reviewboard.domain.net/api/json/reviewrequests/31/diff/new/:
{'basedir': '/dir1/trunk'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [uURL
'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml' is
malformed or the scheme or host or path is missing]}, u'stat': u'fail',
u'err': {u'msg': u'One or more fields had errors', u'code': 105},
u'deprecated': {u'in_version': u'1.5'}}
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
---
On the server side i see this:
---
2010-10-19 19:07:20,764 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 18990
2010-10-19 19:07:20,766 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-10-19 19:07:20,767 - ERROR - Error uploading new diff: URL
'http://svn.domain.net/svn/repositories/repo/dir1/trunk/dir2/file.xml'
is malformed or the scheme or host or path is missing
Traceback (most recent call last):
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/reviews/forms.py, line 249, in create
history)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py, line 62, in create
files = list(self._process_files(
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/diffviewer/forms.py, line 144, in _process_files
if (revision != PRE_CREATION and
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.4/site-packages/ReviewBoard-1.5-py2.4.egg/
reviewboard/scmtools/svn.py, line 144, in get_file
raise SCMError(e)
SCMError: URL 'http://svn.domain.net/svn/repositories/repo/dir1/trunk/
dir2/file.xml' is malformed or the scheme or host or path is missing
---
I didn't find much after googling around for a while. Most of the
other people who encountered this error had spaces in their URLs or
something weird like that. My URLs look correct/normal, so I don't
know what's causing this error. Also, if I do svn info on that exact
URL (or open it in my browser), it works fine. I did get one review
to actually post correctly (with an almost identical URL), so it has
worked at least once. Does anyone have any ideas what might be wrong?
Thanks,
James
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
post-review for Perforce
Hi Guys, I am trying to use perforce + reviewboard to setup a server at my company. I have used reviewboard with mercurial earlier with no issues. Issue-desc: read diff I want to submit @@ -2,3 +2,4 @@ #dude doesn't use Rules.mak (yet). However, some of the newer additions # to dude use tools/Rules.mak, and some rules in tools/Rules.mak have # dependencies on it. This dummy file is here until we have time to convert +#tets how is this working $:~/ReviewBoard$ cat .reviewboardrc # Default Review Board Server REVIEWBOARD_URL = 'http://dude.xcsd.com/reviews/' DIFF = /usr/bin/diff.exe When I try do a dry run, it shows this: $ post-review -d --summary=check this out-III, just diff file -- description=third,I would expect a one line change in my diff file // user/reviewboard/components/dude/mainline/Rules.mak -n git rev-parse --git-dir hg root p4 info repository info: Path: ccs.xcsd.com:1666, Base path: None, Supports changesets: True Writing //user/reviewboard/components/dude/mainline/Rules.mak#1 to /tmp/tmpryM2hQ p4 print -o /tmp/tmpryM2hQ -q //user/reviewboard/components/dude/mainline/Rules.mak#1 diff -urNp /tmp/tmp5G6dK9 /tmp/tmpryM2hQ --- //user/reviewboard/components/dude/mainline/Rules.mak //user/ reviewboard/components/dude/mainline/Rules.mak#0 +++ //user/reviewboard/components/dude/mainline/Rules.mak 2010-08-06 12:15:52 @@ -0,0 +1,4 @@ +#dude doesn't use Rules.mak (yet). However, some of the newer additions +# to dude use tools/Rules.mak, and some rules in tools/Rules.mak have +# dependencies on it. This dummy file is here until we have time to convert +# the rest of dude to truly use the common rules in tools/Rules.mak. I don't know how /tmp/tmp5G6dK9 file is generated. Atleast from the logs it looks like this file is not even attempted to be created. If I skip the '-n' and run it, I dont see the real diff, rather I see a complete file. Has anyone seen the same issue. Any help is appropriated. am I missing something. Thanks, Krish James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Three questions for using Review Board 1.0.6
Hi, all, My team now is using the ReviewBoard-1.0.6 which is running on the Cent-OS server. And this is really fantastic software which help us a lot for code review. However, we also found some troubles when doing review. First, In our project, we need to update the code in more than one components (java project), so we may generate several diff files for one main function. And we find that it is impossible (or it is possible but we did not find that?) to upload these diff files in the same review request. Then we have to create several review requests for the same main function. So, I send this email and hope to know what is others' way for this problem? I think this may be a common case. Second, for some case, we may need to change the same class for two main functions at the same period (during the week by different team members), so how to generate diff file and create the review request for this case? (Our review request is created base on main function changes, and for this case, one review request will contain the changes for other main function, there may be some confusing). I know this might not be in the scope of this mail list, but still hope to get some useful suggestion. Third, we are using svn as the repository. And we want to know that when we can simply input the revision numbers in the web GUI for creating a review request without uploading the diff file. :-) Many Thanks BR// -- Best Regards! James.Tong 童熙 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Is there any flexibility to change the diff format for a review?
Thank you all - some useful ideas in there which I'll discuss my end. James On Mar 22, 9:46 pm, Christian Hammond chip...@chipx86.com wrote: It depends on the type of repository and the authentication mechanism. For Git, for example, you may not be able to easily do this. Having Review Board proxy this is probably ideal, and keeps the details of the repository away from the caller. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Mar 22, 2010 at 2:40 PM, Noah Campbell noahcampb...@gmail.comwrote: Can't you use the URLs from RB and your SCM (assuming you have the web access available?) -Noah On Mon, Mar 22, 2010 at 2:35 PM, Christian Hammond chip...@chipx86.com wrote: It's very likely that we'll have an API function in 1.5 for downloading a full file. No UI, at least for 1.5, but if someone really wanted a script that ran the diff through some external tool, it could use the API. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Mar 22, 2010 at 2:33 PM, Dana Lacoste dlaco...@aperio.com wrote: I think that, perhaps, a better approach to this would be to allow the user to download the full modified file (not the patch) so they can use their own diff tool. For example, before I first started with ReviewBoard, I worked with a small internal tool (Python script) which would take a (Perforce) changelist and copy it to a network share in a /changelist/1 folder, copy the “base” Perforce revision to /changelist/base, and prepare an XML file which specified the share location and share number (named something other than .xml so Windows users could associate a command with it) and email that file to interested users. The user would then run a Python script which would read the file and run Araxis Merge (or Beyond Compare or WinDiff or…) against the relevant files. I think this kind of structure would be quite easy to mimic with ReviewBoard if we could simply download the full file, and then users could use any tool they desire to view the diffs (and, for the most part, the RB built in diff is 1239781092378912% easier to use for small changes anyways J ) Dana Lacoste PS: I know that “download the full file” is a feature on the backlog for some future release J From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com ] On Behalf Of Christian Hammond Sent: Monday, March 22, 2010 12:00 PM To: reviewboard@googlegroups.com Subject: Re: Is there any flexibility to change the diff format for a review? Right, we have our own pretty specific diff viewer. It's very much a side-by-side viewer right now and it would take a lot of work to change that. It's not a priority given other work and not likely to happen in the near future. Especially not before 2.0. In theory, after 2.0 someone could write a replacement diff viewer that does a more WinDiff-style view. It'll be a while before 2.0 is out, though. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+ unsubscribegooglegroups.com
Is there any flexibility to change the diff format for a review?
We have previously been using WinDiff (see http://en.wikipedia.org/wiki/File:WinDiff_demonstration.png for example of output) and I have had several folk asking if there are alternatives to the side-by-side approach taken by ReviewBoard - specifically the format used by WinDiff. It's not clear to me how customisable this kind of output is or whether the review function is totally tied to the existing layout. Thanks -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en To unsubscribe from this group, send email to reviewboard+unsubscribegooglegroups.com or reply to this email with the words REMOVE ME as the subject.
Locked out from RB Admin!
Bottom line is that I no longer appear to have an administrative account and I am looking for a way to get myself back in again. Sequence that got me to this was as follows. - I set up accounts using the local user account system - end-user accounts, a master admin account and a Submit-As account for post review - I then switched over to use Active Directory thinking the admin account would be preserved. - I could still use the admin account _UNTIL_ I restarted the httpd server. Since then, having created the equivalent AD account, I have only been able to login as a normal user. Is there any way of patching admin privileges in through MySQL or am I hosed? Thanks for any help! James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Locked out from RB Admin!
Christian, When we switched over to AD, the end-user accounts did exist on AD but when they logged in for the first time against AD it appeared that their account was reset, with existing reviews lost. That was not an issue at the time. The Master account (my admin ID) did continue to work until this morning but without there being an equivalent AD account. (Contrary to my original post, I'm thinking that I must have restarted the server since the switchover without losing Admin rights.) When I could not login this morning, the Apache error_log showed the following - no references to any other Apache logs. error_log:WARNING:root:Active Directory: Failed login for user master I then added master to our AD and that error no longer appears, but I can only log in as a normal user now. Are there other logs I should be running with in general? If so then how do I enable them please? UPDATE - I've just found the following in the Admin Guide but not tried it. Is this what I need? Creating a Super User¶ It is possible to create a new super user account without using the website. This can be important if the main super user account is for whatever reason disabled or if the login information is lost. To create a new super user account, run: $ rb-site manage /path/to/site createsuperuser This will prompt for the username and password of the account. You must specify a user that doesn’t already exist in the database. Once this is finished, you should be able to log in under the new account and fix any problems you have. On Mar 5, 10:36 am, Christian Hammond chip...@chipx86.com wrote: Hi James, Was the username you used also an account on the Active Directory server? Does anything appear in the log files? (Assuming logging was turned on before this happened). Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Mar 5, 2010 at 2:30 AM, James McDougall jamesmcdoug...@gmail.comwrote: Bottom line is that I no longer appear to have an administrative account and I am looking for a way to get myself back in again. Sequence that got me to this was as follows. - I set up accounts using the local user account system - end-user accounts, a master admin account and a Submit-As account for post review - I then switched over to use Active Directory thinking the admin account would be preserved. - I could still use the admin account _UNTIL_ I restarted the httpd server. Since then, having created the equivalent AD account, I have only been able to login as a normal user. Is there any way of patching admin privileges in through MySQL or am I hosed? Thanks for any help! James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Locked out from RB Admin!
Fantastic - worked a treat! Can I help by raising an Issue with the details of the original problem? Thanks. On Mar 5, 11:00 am, Christian Hammond chip...@chipx86.com wrote: Hi James, It tried to authenticate against AD, but given that it didn't find it, it should have fallen back to the built-in list of users in the database. The fact that it didn't is concerning, but we can look into it once we get your system back up and running. That method for creating a super user should work for making a new admin user, but we can also set your user to have superuser status again. Do the following: $ rb-site manage /path/to/your/site shell from django.contrib.auth.models import User u = User.objects.get(username=master) u.is_superuser = True u.is_staff = True u.save() That should reset it and give you access to the admin UI again. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Mar 5, 2010 at 2:51 AM, James McDougall jamesmcdoug...@gmail.comwrote: Christian, When we switched over to AD, the end-user accounts did exist on AD but when they logged in for the first time against AD it appeared that their account was reset, with existing reviews lost. That was not an issue at the time. The Master account (my admin ID) did continue to work until this morning but without there being an equivalent AD account. (Contrary to my original post, I'm thinking that I must have restarted the server since the switchover without losing Admin rights.) When I could not login this morning, the Apache error_log showed the following - no references to any other Apache logs. error_log:WARNING:root:Active Directory: Failed login for user master I then added master to our AD and that error no longer appears, but I can only log in as a normal user now. Are there other logs I should be running with in general? If so then how do I enable them please? UPDATE - I've just found the following in the Admin Guide but not tried it. Is this what I need? Creating a Super User¶ It is possible to create a new super user account without using the website. This can be important if the main super user account is for whatever reason disabled or if the login information is lost. To create a new super user account, run: $ rb-site manage /path/to/site createsuperuser This will prompt for the username and password of the account. You must specify a user that doesn’t already exist in the database. Once this is finished, you should be able to log in under the new account and fix any problems you have. On Mar 5, 10:36 am, Christian Hammond chip...@chipx86.com wrote: Hi James, Was the username you used also an account on the Active Directory server? Does anything appear in the log files? (Assuming logging was turned on before this happened). Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Fri, Mar 5, 2010 at 2:30 AM, James McDougall jamesmcdoug...@gmail.comwrote: Bottom line is that I no longer appear to have an administrative account and I am looking for a way to get myself back in again. Sequence that got me to this was as follows. - I set up accounts using the local user account system - end-user accounts, a master admin account and a Submit-As account for post review - I then switched over to use Active Directory thinking the admin account would be preserved. - I could still use the admin account _UNTIL_ I restarted the httpd server. Since then, having created the equivalent AD account, I have only been able to login as a normal user. Is there any way of patching admin privileges in through MySQL or am I hosed? Thanks for any help! James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project
Setting up ReviewBoard to work over HTTPS
We have ReviewBoard set up with ActiveDirectory but users are uncomfortable with their passwords being snoopable on the wire. I therefore want to make it fully supported over HTTPS - all web access is through https, the email notifications have https links in them etc. Is there any existing procedure for setting this up following a standard install? Is it just a case of getting Apache configured correctly and everything else will fall into place? Thanks James -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problems installing Review Board on RHEL v5.1
Hi, A couple of points I failed to raise earlier. If anyone can help point me in the right direction, I would appreciate it. - I _have_ installed psycopg2 for Postgres access. easy_install confirms this. - I have _not_ (and don't intend to) install the sqlite3 or MySQL support because I am not using their databases. Two questions. - Do I need all three or is the installer just making sure I've got at least one? The error message is not very clear. - If just the one, then how is it checking to see if psycopg2 is installed? Thanks James On Feb 8, 6:32 pm, James McDougall jamesmcdoug...@gmail.com wrote: Hi, I am attempting to set up Review Board for the first time on RHEL V5.1 following the Admin docs. I'm using Apache and Postgresql. Everything appears to be going fine until I run rb-site install which bombs out with missing modules (below). How can I find out what is missing? I've tried --debug and --console but am not seeing any further debug info. Thanks James [r...@mrbump ] /tmp rb-site --debug install /var/www/ reviews.example.com snip * Required modules are missing. You are missing Python modules that are needed before the installation process. You will need to install the necessary modules and restart the install. Databases (required): * sqlite3 (pysqlite2, sqlite3) * MySQL (MySQLdb) * PostgreSQL (psycopg2) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Problems installing Review Board on RHEL v5.1
Hi, I am attempting to set up Review Board for the first time on RHEL V5.1 following the Admin docs. I'm using Apache and Postgresql. Everything appears to be going fine until I run rb-site install which bombs out with missing modules (below). How can I find out what is missing? I've tried --debug and --console but am not seeing any further debug info. Thanks James [r...@mrbump ] /tmp rb-site --debug install /var/www/ reviews.example.com snip * Required modules are missing. You are missing Python modules that are needed before the installation process. You will need to install the necessary modules and restart the install. Databases (required): * sqlite3 (pysqlite2, sqlite3) * MySQL (MySQLdb) * PostgreSQL (psycopg2) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Apache hangs upon post-review
Per an earlier thread I'm trying to get Review Board working on a
Windows machine
with ClearCase integration. I've gotten earlier road blocks and now
post-review runs
but it only gets so far and then the Apache server goes to 99% CPU
utilization and
post-review process hangs until I restart Apache server. Here is
output from a debug
post-review run. Any ideas?
snip
HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/draft/set/: {'de
scription': 'sperry_releaseboard\nVIEWTYPE: dynamic\n'}
HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/draft/save/: {}
Review request draft saved
Uploading diff, size: 4635
HTTP POSTing to http://ndm-xp-vm1/api/json/reviewrequests/4/diff/new/: {'bas
edir': 's:\\'}
^C
S:\softdbTraceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.2beta2', 'console_scripts', 'post-
review')()
File build\bdist.win32\egg\rbtools\postreview.py, line 2522, in
main
File build\bdist.win32\egg\rbtools\postreview.py, line 2254, in
tempt_fate
File build\bdist.win32\egg\rbtools\postreview.py, line 463, in
upload_diff
File build\bdist.win32\egg\rbtools\postreview.py, line 575, in
api_post
File build\bdist.win32\egg\rbtools\postreview.py, line 556, in
http_post
File C:\Python25\lib\urllib2.py, line 124, in urlopen
return _opener.open(url, data)
File C:\Python25\lib\urllib2.py, line 381, in open
response = self._open(req, data)
File C:\Python25\lib\urllib2.py, line 399, in _open
'_open', req)
File C:\Python25\lib\urllib2.py, line 360, in _call_chain
result = func(*args)
File C:\Python25\lib\urllib2.py, line 1107, in http_open
return self.do_open(httplib.HTTPConnection, req)
File C:\Python25\lib\urllib2.py, line 1080, in do_open
r = h.getresponse()
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
ClearCase integration
Hi, I'm trying to setup Review Board with ClearCase on a Windows machine. As I understand it, the only way to create new ClearCase review requests is using post-review tool. In the post-review doc, there are instructions about editing cc_rootpath and changing viewtype. I presume this use to occur in post-review.py script but the most recent releases of RBTools (.2 beta 2) ships as .exe so not sure where these modifications are made? Thanks for any help/guidance in getting RB setup with ClearCase! -James --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Reviewboard API examples
Hi all Does anyone have examples of using the Reviewboard API? Especially if it's in Ruby... :) I'm hoping some people have got some code I can steal/adapt rather than write from scratch. Google hasn't shown much up. Thanks James Turnbull --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: value error: year out of range
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Christian Hammond wrote: Hmm, well, somehow, that review request has a date of 743-28-27, which is quite clearly invalid no matter which way you look at it. Which is the year? Which is the month? None of those are valid months or years. The time is also invalid. Question is, how did this happen? The date seems to be our last_activity_timestamp, which should be either the review request's last_updated timestamp or the most recent review's timestamp. So I don't know how this would happen. Was this a brand new upgrade, or was this working for a while before now? Brand new install. I just handed it over to a developer who started testing by adding some reviews. After he added one or two reviews I got the 500 error. I'm working to fully rewrite the last_activity_timestamp generation, which should definitely fix this. I hope to get it into a nightly release in the next couple of days, followed by RC3. Thanks! I presume upgrades are easy? Regards James Turnbull - -- Author of: * Pro Linux Systems Administration (http://www.amazon.com/gp/product/1430219122/) * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/159059/) -BEGIN PGP SIGNATURE- Version: GnuPG v1.4.7 (Darwin) Comment: Using GnuPG with Mozilla - http://enigmail.mozdev.org iD8DBQFKIjOD9hTGvAxC30ARAg9wAJ4242aLtU0DlbWIHaqIHFV7nzpepACgqiaO fdcTvhkbOhq0peRbYBn4d7k= =CIE1 -END PGP SIGNATURE- --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: How do I delete discarded draft changes?
Christian Hammond wrote: We don't delete anything permanently in Review Board. Usually it's best not to, as it's still part of the history of the development process. We also don't want discarding to be a dangerous operation so it just marks a review request such that we can hide it. Sure - understand that concept. If you truly want to delete it, you'll need to be set as an administrator. There would then be a Close - Delete Permanently. It can also be done through the admin UI. However, it's not something we recommend, and not something that will be made available to non-admin users. The issue is that Review Requests (non-draft) can be deleted via the Close tab. Review requests (Draft) cannot. Via admin or not. The Close tab does not appear. Thanks James Turnbull -- Author of: * Pro Linux Systems Administration (http://www.amazon.com/gp/product/1430219122/) * Pulling Strings with Puppet (http://www.amazon.com/gp/product/1590599780/) * Pro Nagios 2.0 (http://www.amazon.com/gp/product/1590596099/) * Hardening Linux (http://www.amazon.com/gp/product/159059/) signature.asc Description: OpenPGP digital signature
Webservice::rveviewboard CPAN module
Hi Is anyone using this module? I note the publish() and discard request methods don't work. Does anyone have a fix for this before I go digging into the code? Regards James Turnbull http://www.james-turnbull.net --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
