[Freeciv-Dev] changing RT user

2007-05-05 Thread William Allen Simpson
In 1995, somebody added me to the RT users. I've changed email, and my subscription to this list was updated (last year), but it doesn't seem to have updated the RT entry. Could somebody fix it? ___ Freeciv-dev mailing list Freeciv-dev@gna.org

Re: [Freeciv-Dev] (PR#14236) Error: choose_random_tech

2007-05-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=14236 This can probably be closed. The message is gone from the source, and all the places the function is called check for A_UNSET now. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#39364) 2.1.0b4 crash on opening scenarios screen

2007-05-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39364 Recently compiled on iMacG5 with MacOS 10.3.9 and MacPorts. export LDFLAGS=-L/opt/local/lib export CPPFLAGS=-I/opt/local/include export CC=gcc -no-cpp-precomp ./configure --disable-nls --enable-client=gtk2

[Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Recent (2006 May 2) MacOS compile of freeciv-2.1.0-beta4.tar.bz2. This is a very obscure error, and likely not worth fixing before release, unless a new beta is produced. It should be fixed in any subsequent 2.1.n release. Reproduce

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Daniel Doran wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 I have never experienced any other behavior from Freeciv. freeciv-1.x versions on Win and Linux exhibited the precise behavior described. Never is an

[Freeciv-Dev] (PR#39367) 2.1.0b4 nation trivial errors

2007-05-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39367 So, in debugging my other recent reports, I tried verbose logging, and found a fair number of things were logged. Here's a sampling, most seem to be spelling or capitalization errors. 3: Civil war nation aborigines for nation

Re: [Freeciv-Dev] changing RT user

2007-05-11 Thread William Allen Simpson
William Allen Simpson wrote: In 1995, somebody added me to the RT users. I've changed email, and my subscription to this list was updated (last year), but it doesn't seem to have updated the RT entry. Could somebody fix it? I've finally been able to login and change the password (something

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Jason Dorje Short wrote: There is a whole sequence of tickets devoted to this bug. It is a well-known bug but no progress toward fixing it has been made in quite some time. The problem is the sequence of random calls in the reload

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 I ended up with even more random debugging (attached patch), and solved the problems, or at least several of them. Also found an uninitialized founder_boat along the way. My solution to the problems is entirely in savegame.c, saving

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Those patches were against the 2.1.0b4 source, here's the savegame.c patch against current revision 12954. Untested. It compiles. --- ../savegame.c Thu May 3 12:42:30 2007 +++ server/savegame.c Sun May 13 16:17:45 2007 @@

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Those patches were against the 2.1.0b4 source, here's the rand.c patch against current revision 12954, better conforming to your recent formatting. --- ../rand.c Sun May 13 16:05:47 2007 +++ utility/rand.c Sun May 13 16:33:20

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not saved correctly

2007-05-13 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Those patches were against the 2.1.0b4 source, here's the city.c patch against current revision 12954 (single line added). I didn't realize how much has been added since 2.1.0! Hopefully, 2.1.0 can be laid to bed soon ---

Re: [Freeciv-Dev] Ogre3D UI?

2007-05-16 Thread William Allen Simpson
James Supancic wrote: I am thinking about working on an Ogre3D GUI for freeciv. I've been looking over the code in freeciv/freeciv/client/gui-* and think I might be able to develop something nice. This would be wonderful! I actually looked at doing it 18+ months ago, but decided it would be

Re: [Freeciv-Dev] (PR#39342) 2.1.0-beta4 border vs. fog of war

2007-05-16 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39342 Per I. Mathisen wrote: Given how much FoW you usually have, this will make your real borders really hard to visualize and plan with respect to. I do not really see a good and simple fix to this issue. We need to change the way

[Freeciv-Dev] (PR#39372) 2.1.0b4 default cities.ruleset celebrate_size_limit mismatch ruleset.c celebratesize

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39372 or vice versa. I think that the celebrate_size is a better name for both. Currently, the code is: /* City Parameters */ game.info.celebratesize = secfile_lookup_int_default(file, GAME_DEFAULT_CELEBRATESIZE,

Re: [Freeciv-Dev] (PR#39370) 2.1.0b4 city vision radius too small

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39370 Per I. Mathisen wrote: Yes. Patch to change this most welcome. Apparently, it was a conscious decision by some prior developer. There is a documented vision parameter that is only FALSE for cities. Therefore, I propose a

Re: [Freeciv-Dev] (PR#39342) 2.1.0-beta4 border vs. fog of war

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39342 Per Inge Mathisen wrote: So this is like today, only that you forget borders after a turn if you do not see the border source? It is actually rather complicated, and it does not answer my worry above that it will make borders hard to

Re: [Freeciv-Dev] (PR#39370) 2.1.0b4 city vision radius too small

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39370 Oh bother, I see that while I was poking at keeping things backward compatible, you made a sweeping change. Ah well, here's my 2.1.0b4 proposal as applied to trunk Mix and match?

Re: [Freeciv-Dev] (PR#8398) Re: Bug: cease-fires can't be extended

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=8398 Per I. Mathisen wrote: I think the proper solution to this problem is that ceasefires do not count down, but can be broken at any time by any government without penalty. I disagree. The count down is an essential game function. And

Re: [Freeciv-Dev] (PR#39372) 2.1.0b4 default cities.ruleset celebrate_size_limit mismatch ruleset.c celebratesize

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39372 Here's the simplest possible patches for 2.1.0b4 and trunk. --- ../ruleset.cSun Feb 18 23:01:46 2007 +++ server/ruleset.cThu May 17 17:12:28 2007 @@ -2313,12 +2313,13 @@ game.info.celebratesize =

[Freeciv-Dev] (PR#39373) abandoned city bounce

2007-05-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39373 I just had the oddest thing happen: when I created a settler (from a badly placed hut city), the settler bounced to my nearest city. That's certainly not how I remember Civ1 or Civ2 or Civ3 working! Of course, I want it to stay in

Re: [Freeciv-Dev] (PR#39367) 2.1.0b4 nation trivial errors

2007-05-18 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39367 William Allen Simpson wrote: 3: Unused entries in file data/default/nations.ruleset: 3: unused entry: nation_barbarian.is_observer 3: unused entry: nation_bosnia.ciwilwar_nations 3: unused entry: nation_bosnia.ciwilwar_nations

Re: [Freeciv-Dev] svn problems [was (PR#39367) 2.1.0b4 nation trivial errors]

2007-05-19 Thread William Allen Simpson
Per Inge Mathisen wrote: On 5/18/07, William Allen Simpson [EMAIL PROTECTED] wrote: Here's the first installment on trivial nation fixes for 2.1.0b4 and trunk. Most of the S2_1 changes were already done (please 'svn up' before making the patch), and the rest would invalidate

Re: [Freeciv-Dev] (PR#39370) 2.1.0b4 city vision radius too small

2007-05-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39370 Per I. Mathisen wrote: I do not see why we should worry about that. It is nice that people can play mods that feel like Civ1/2 with Freeciv, but we do not need to support all kinds of small oddball configurations and/or bugs that

[Freeciv-Dev] current trunk compile failure(s)

2007-05-19 Thread William Allen Simpson
I've been waiting around several days to see whether somebody fixes this? registry.c: In function `section_file_save': registry.c:816: error: `BUG_URL' undeclared (first use in this function) registry.c:816: error: (Each undeclared identifier is reported only once registry.c:816: error: for each

[Freeciv-Dev] (PR#39378) RFE hut dynamic rules

2007-05-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39378 The hut rules are currently static in unittools.c unit_enter_hut(). The rules should vary for civ1, 2, 3 4. For civ3 4, huts should respond more favorably to a scout, and very favorably within a national boundary.

[Freeciv-Dev] (PR#39379) RFE civ3+ terrain support

2007-05-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39379 There is greater variety in civ3 (and other) terrain. Hills can be dry, grassy, and/or forested. Mountains can be dry, wet, icy, or volcanos. Oceans have several depths, with ridges, trenches, and vents/volcanos. Of course, not every

[Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 With so many previous attempts, it seemed prudent to split off my effort for water into a separate ticket, so that they can cross reference. This is a more extensive consolidation. water (formerly ' '): + fresh lake (higher

Re: [Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 Patch data/default/terrain.ruleset Index: data/default/terrain.ruleset === --- data/default/terrain.ruleset(revision 12965) +++ data/default/terrain.ruleset

Re: [Freeciv-Dev] (PR#39379) RFE civ3+ terrain support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39379 Second draft, with minor corrections reconciling earlier attempts: land: a ice (arctic, glacier) A ice + hills t tundra T tundra + hills d desert D desert + hills p plain P plain + hills + evergreen q plain

Re: [Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 Sadly, Ocean is more embedded in everything than I'd thought Patch data/default/terrain.ruleset with smaller baby step. Index: data/default/terrain.ruleset === ---

Re: [Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 I've discovered that the current state of the trunk is inconsistent. There appear to be parts of several patches from different PRs. As soon as the deep tiles are referenced, the client will not start. The current amplio terrain2.spec

Re: [Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-25 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 Here is my first pass at the reintegrated patches. It runs. Not yet extensively tested. My new code will take an old savefile and add four kinds of water: lake, coast, shelf, and floor. Shelf and floor only display as deep (so far).

Re: [Freeciv-Dev] (PR#39381) RFE civ3+ water support

2007-05-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39381 Here is my second pass at the code. Amplio is ready, but everything else is broken. Have to keep the name Ocean for various nations to work, so that is assigned to Coast, as differentiated from Lake and Sea. Of course, this doesn't

[Freeciv-Dev] (PR#39382) civ1 and civ2 rulesets crash, no sea barbarians, bad tech Never

2007-05-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39382 Tried testing my civ3 oceans against civ2 and civ1, just to make sure my code is behaving -- lo and behold, they already crash the server -- without my help civ2 2: Loading rulesets 1: No sea barbarian nation defined. At least one

Re: [Freeciv-Dev] (PR#34095) [Patch] Nation sanity checking

2007-05-27 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=34095 Was this a testing process that is over now? For 2.1.0b4, I'd been testing rulesets and such by good ol' fashioned ./ser and load from the command line. Aborts now in trunk. === load ../D-4000 2: Loading rulesets 1: Failed sanity

[Freeciv-Dev] (PR#39383) BUG: terrain and resource name translation

2007-06-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39383 While trying to debug some of my terrain changes, it was frustrating that some error messages had empty (missing/blank) fields. Numerous messages tried to insert a translated name into log messages that are not translated. (I'm running

Re: [Freeciv-Dev] (PR#39383) BUG: terrain and resource name translation

2007-06-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39383 In this version, I moved the translation into the accessor functions, as this seemed to be better than spread around in 3 places, especially as the other places in the code forgot to test for NULL and '\0' (empty string). Comments in the

Re: [Freeciv-Dev] (PR#39386) cleanup tilespec.c

2007-06-06 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39386 Committed trunk revision 12976. Note that this makes it obvious that the code does not even come close to the doc/README.graphics documentation! (Very confusing to new coders.) Moreover, the match_type = full requires the cell_type =

[Freeciv-Dev] (PR#39387) replace match_type = full with pair

2007-06-06 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39387 match_type = full -- as it exists -- has a number of problems. It requires the cell_type = rect, then actually operates on a cellgroup -- AFAICT a whole tile! It conflicts (or at least the documentation says it does) with all other

Re: [Freeciv-Dev] Bug in windows client sdl 2.1.0 beta 4

2007-06-07 Thread William Allen Simpson
Keguji Ves Zavrey wrote: If there is any way I can help more to remove this bug, then please e-mail me. Could you attach the savegame? ps. I tried to send this email to [EMAIL PROTECTED] but I get undelivery bounces... Yes, that address died from spam overload, try [EMAIL PROTECTED]

Re: [Freeciv-Dev] (PR#39385) suggestion: Buy column on Cities report preliminary patch

2007-06-07 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 It is a patch to client/cityrepdata.c in the S2_1 branch and it builds fine and seems to work Of course, since this is an enhancement (not a bug fix, and especially one that adds new translation), it would be for trunk first, and

Re: [Freeciv-Dev] (PR#39385) suggestion: Buy column on Cities report preliminary patch

2007-06-07 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 I've a different patch against trunk. The documentation in comments on how to add are wrong. I shuffled the fields a bit. To make up for the extra space, I turned off the governor field default. This doesn't show costs larger than

Re: [Freeciv-Dev] You can't alter const objects?

2007-06-08 Thread William Allen Simpson
James Supancic wrote: In resource_name_translation, in terrain.c you are altering the value of a const parameter. This is not allowed, and gcc 4.1 tells us this with: terrain.c: In function 'resource_name_translation': terrain.c:244: error: assignment of read-only location I'm not sure how

Re: [Freeciv-Dev] (PR#39383) BUG: terrain and resource name translation

2007-06-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39383 William Allen Simpson wrote: There's a warning, because the current resource list is const, and this modifies the pointer. Updating the const can happen later. trunk revision 12977 S2_1 revision 12978 Remaining const struct

Re: [Freeciv-Dev] (PR#39385) RFE: Buy column on Cities report

2007-06-08 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Ulrik Sverdrup wrote: I did this with the field width wrong as well, but I think we should reserve a width up to 5 for build costs. I can imagine wonders costing more than 1 if you buy them from scratch in the derfault ruleset.

Re: [Freeciv-Dev] (PR#39389) BUG: technology/advance name translation

2007-06-09 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39389 Per I. Mathisen wrote: All LOG_ERROR, LOG_VERBOSE and LOG_FATAL messages should be without translation. To summarize, only LOG_NORMAL should be translated, because those are displayed to the user. I am not sure if this is written

Re: [Freeciv-Dev] (PR#39390) S2_1: SDL client compile fails

2007-06-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39390 This is definitely odd. The history shows that's been around a very long time S2_1/ChangeLog:30707: Thu Jun 17 13:07:54 1999 Nicolas Brunel [EMAIL PROTECTED]: * acconfig.h, config.h.in, configure.in, client/civclient.c,

Re: [Freeciv-Dev] (PR#39391) Warnings in lua code

2007-06-10 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39391 I don't get those warnings/errors, either. Of course, I'm running gcc 3.3 on a G5 -- gcc 4.1 itself won't even compile on this system, something wrong with the register assignment last time I checked (months ago). But since getting

Re: [Freeciv-Dev] (PR#39385) RFE: Buy column on Cities report

2007-06-11 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 And now the debate: Could this be pulled up into 2.1 at this late date? It was a more of a bug fix than a mere enhancement, and on that basis alone, I'm in favor. It is missing one new (rarely seen) menu translation. How do I know

Re: [Freeciv-Dev] (PR#39385) RFE: Buy column on Cities report

2007-06-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Per I. Mathisen wrote: The question is, does it change translations? If so, I'd say no. It is frozen for new features and translation string changes now. We need to get it out soon... :/ Soon, as in 15 months ago? There are still

Re: [Freeciv-Dev] (PR#39385) RFE: Buy column on Cities report

2007-06-12 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39385 Committed S2_1 revision 12989. Committed trunk revision 12990. At this point, both should function exactly the same. Except Russian. I was surprised to discover that there were quite a few conflicts with S2_1, because folks have been

[Freeciv-Dev] (PR#39396) BUG: 2.1.0b4 section_file_load_section

2007-06-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39396 This code has *never* worked: PR#14243 committed in revision 11100 (Sun, 09 Oct 2005) 20 months ago. It is called in only one place, client/gui-gtk-2.0/pages.c update_scenario_page, that crashes! (PR#39364) Its parameter, const char

Re: [Freeciv-Dev] (PR#39364) 2.1.0b4 crash on opening scenarios screen

2007-06-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39364 The problem was not in the translation routines. It had other causes. This code has *never* worked: PR#14243 committed in revision 11100 (Sun, 09 Oct 2005) 20 months ago. The primary cause is that code freed the section file data

Re: [Freeciv-Dev] (PR#39396) BUG: 2.1.0b4 section_file_load_section

2007-06-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39396 S2_1 revision 12993 trunk revision 12994 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39364) 2.1.0b4 crash on opening scenarios screen

2007-06-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39364 S2_1 revision 12993 trunk revision 12994 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

Re: [Freeciv-Dev] (PR#39394) Rigid border rules in S2_1

2007-06-15 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39394 Per I. Mathisen wrote: Any replacement rule for borders has to not just generate nicer borders, but be simple to understand as well. I have yet to find any such replacement rule. If you have any, feel free to post it. Just saying no

Re: [Freeciv-Dev] (PR#39397) Freeciv 2.1 Beta crashes on New Game or Load Game

2007-06-16 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 Christian Knoke wrote: 3: Don't have graphics tags or for tech_type Nichts ... 0: Don't have graphics tags t.ocean1 or for base terrain Ocean This looks like the same kind of thing reported in PR#39388. But I've had absolutely

Re: [Freeciv-Dev] (PR#39397) Freeciv 2.1 Beta crashes on New Game or Load Game

2007-06-16 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 Christian Knoke wrote: 3: Don't have graphics tags or for tech_type Nichts Forgot to mention that there are longstanding bugs searching tech based on translated names instead of ruleset names, and I'm already working on that in

Re: [Freeciv-Dev] (PR#39389) BUG: technology/advance name translation

2007-06-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39389 Per I. Mathisen wrote: I do not really have much of an opinion on whether LOG_FATAL or LOG_ERROR should be translated or not. However, LOG_VERBOSE and LOG_DEBUG should never be translated - they are not meant for public consumption,

Re: [Freeciv-Dev] (PR#39401) r12999 trunk compile fails with new tolua

2007-06-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39401 Per I. Mathisen wrote: URL: http://bugs.freeciv.org/Ticket/Display.html?id=39401 On Sun, 17 Jun 2007, William Allen Simpson wrote: api_gen.c:11:21: tolua++.h: No such file or directory I think I fixed this now. Please test again

Re: [Freeciv-Dev] (PR#39386) cleanup tilespec.c

2007-06-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39386 The rather different code in S2_1 was difficult to compare without straightening it, too. This makes the differences more apparent, and hopefully will assist debugging recent reports of load failures in certain configurations.

Re: [Freeciv-Dev] (PR#39389) BUG: technology/advance name translation

2007-06-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39389 Combined with (PR#39386) cleanup tilespec.c in hopes of debugging recent reports of tile load failures in certain configurations. The freelog removal of translation (in most cases) should clarify the file and rule names as they are

Re: [Freeciv-Dev] trunk lua mess

2007-06-17 Thread William Allen Simpson
Per Inge Mathisen wrote: I tried unsucessfully to update trunk to latest lua and tolua versions. For some reasons I could not figure out, tolua generated a bad api_gen.c, and the makefile did not regenerate this file for me and thus alert me to the problems before I had already committed

Re: [Freeciv-Dev] (PR#39397) Freeciv 2.1 Beta crashes on New Game or Load Game

2007-06-17 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 Christian Knoke wrote: svn update ./autogen.sh make su -c make install civclient ~$ which civclient /usr/local/bin/civclient Thank you, very helpful. The major difference between your test and my test: I'm running in the

Re: [Freeciv-Dev] trunk lua mess

2007-06-18 Thread William Allen Simpson
William Allen Simpson wrote: Per Inge Mathisen wrote: Also, while on the topic of api_gen.c|h, I do not see why these automatically generated source files are in the repository? All the tools required to generate them are already in the repository. I agree. And there was a part of a bug

Re: [Freeciv-Dev] trunk lua mess

2007-06-18 Thread William Allen Simpson
William Allen Simpson wrote: AFAIK, all that needs to be done is svn delete them, and they should go away. Somebody must have deliberately added them in the past? Yes, for cross compiling from linux to windows in: http://bugs.freeciv.org/Ticket/Display.html?id=13571 There is a better way

Re: [Freeciv-Dev] trunk lua mess

2007-06-18 Thread William Allen Simpson
Question: is tolua used for anything other than pre-compilation? That is, AFAICT tolua is only used to build api_gen.* Therefore, tolua would never be anything other than natively compiled, and would not be distributed in a binary distribution? Only lua would be generated for the target

Re: [Freeciv-Dev] trunk lua mess

2007-06-18 Thread William Allen Simpson
Per I. Mathisen wrote: On Mon, 18 Jun 2007, William Allen Simpson wrote: My observation is that the main problem we experienced was trying to change from tolua++.h to tolua.h. No, that was just an amusing side-show. The problem was that tolua++ generated a faulty api_gen.c file. OK, my

Re: [Freeciv-Dev] trunk lua mess

2007-06-18 Thread William Allen Simpson
Per Inge Mathisen wrote: On 6/18/07, William Allen Simpson [EMAIL PROTECTED] wrote: 1) install the latest lua. Make sure it works. Surely the latest lua will still work with the older tolua! No, tolua 5.0 does not work with lua 5.1, unfortunately. And there is no more recent version

[Freeciv-Dev] (PR#39403) BUG: 2.1.0b4 MacOSX 3.9 fails to find libintl.h

2007-06-18 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39403 Apparently not using the CPPFLAGS? === export LDFLAGS=-L/opt/local/lib export CPPFLAGS=-I/opt/local/include export CC=gcc -no-cpp-precomp ./autogen.sh --enable-nls --enable-client=gtk2 --prefix=/Users/wastrel/freeciv-i18n ... +

Re: [Freeciv-Dev] (PR#39403) BUG: 2.1.0b4 CPPFLAGS ignored and other makefile oddities

2007-06-18 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39403 Must be using old instructions. Found some newer ones at: http://freeciv.wikia.com/wiki/Install-MacOSX There, it specifies putting them all in the CC variable: export CC=gcc -no-cpp-precomp -I/opt/local/include -L/opt/local/lib

Re: [Freeciv-Dev] trunk lua mess

2007-06-19 Thread William Allen Simpson
Per I. Mathisen wrote: BTW, the sources need some changes to work with new lua and tolua versions, as you can see in r12995-9, and I am not sure if those changes are compatible with older lua versions. Well, I expect to find out over the next couple of days :-) I'm putting the tolua++

Re: [Freeciv-Dev] (PR#39406) Is S2_1 clients compilation broken?

2007-06-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39406 Egor Vyscrebentsov wrote: svn branches/S2_1 rev 13004. gui-xaw and gui-gtk-2.0 do not compiled on my machine with following error: freeciv-s2_1/client/packhand.c: In function ‘handle_ruleset_building’

Re: [Freeciv-Dev] (PR#39388) S2_1 trident missing t.ocean1

2007-06-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39388 Daniel Markstedt wrote: On 6/10/07, William Allen Simpson [EMAIL PROTECTED] wrote: What tileset? Any. Using my improved error logging (most recently r13003 for S2_1), we discovered that this was not accurate. As I mentioned

Re: [Freeciv-Dev] (PR#39397) 2.1.0 Beta missing graphics for trident Ocean and tech Nichts

2007-06-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 As I was looking for similar reports, I discovered that you've been reporting the same Ocean problem since beta 1 #16078: Beta1: civclient crash on game load http://bugs.freeciv.org/Ticket/Display.html?id=16078 SVN 2.1 22

Re: [Freeciv-Dev] (PR#39388) S2_1 trident missing t.ocean1

2007-06-19 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39388 The ancient bug had been fixed in trunk months ago. Tested against all 5 tilesets. Committed S2_1 revision 13006. Index: client/tilespec.c === --- client/tilespec.c

Re: [Freeciv-Dev] trunk lua mess

2007-06-20 Thread William Allen Simpson
It appears that tolua++ is a dead end. It hasn't had any fixes for over a year, and the version 1.0.92 doesn't compile as distributed. I have no confidence in a coder that accidentally deleted the include of the primary header file. Clearly somebody that doesn't compile before commit (and has

Re: [Freeciv-Dev] (PR#39411) [patch] gov icons in tech tree show up misaligned

2007-06-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39411 Excellent catch! (Also, fixed some indentation here.) Committed S2_1 revision 13012, trunk revision 13013. ___ Freeciv-dev mailing list Freeciv-dev@gna.org

[Freeciv-Dev] (PR#39414) tolua, tolua++, toluaxx

2007-06-23 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39414 The included tolua is not compatible with improvements in lua 5.1, suffers from some bugs, pointers are identical to unsigned integers, and the code has not been updated in a long time. The next incarnation, called tolua++, has

[Freeciv-Dev] (PR#39416) externalize lua, toluaxx

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39416 After my travails trying to integrate toluaxx, I'm back to my original thought that (like gettext) lua should *optionally* be included for systems that don't already have a lua package (--with-included-lua). That is, for cross-building

Re: [Freeciv-Dev] (PR#39409) Technology tree (reqtree.c) edge colors

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39409 Thank you! Since I was the last to touch this code, I've handled it (again), although it's not my usual bailiwick. Also, found that a bug fix had been applied to trunk and not to S2_1, so that's added, too Committed trunk revision

Re: [Freeciv-Dev] (PR#39409) Technology tree (reqtree.c) edge colors

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39409 As I was testing the patch, I noticed that there were 6 available node colors. Not all make sense for edges, but flagging those currently reachable and researching might be visually helpful on long lines. I also noticed the .h comments

Re: [Freeciv-Dev] (PR#39409) Technology tree (reqtree.c) edge colors

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39409 Forgot to send the patch, same for both commits. Index: client/reqtree.c === --- client/reqtree.c(revision 13016) +++ client/reqtree.c(working copy) @@ -107,8

Re: [Freeciv-Dev] (PR#37378) Tech tree color revisions

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=37378 Looking through related reports, this is the only remaining open I've linked these reports a bit. Any others? Now that there are colored links in the tech tree, it might be a good time to revisit the color selection. For example,

[Freeciv-Dev] (PR#11533) Colour highlighting of important messages?

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=11533 While searching for color reports, found these two and linked them http://bugs.freeciv.org/Ticket/Display.html?id=2771 I'm replying on the more recent one, currently client-gtk-2.0, the older is currently client (generic).

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not restored correctly

2007-06-24 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 For the past month, I've been testing various fixes to this problem. However inelegant, these patches are required in 2.1.0b4 to allow reproducible savegames. I'm not sure I've found everything in trunk yet. Committed trunk revision

Re: [Freeciv-Dev] (PR#39397) 2.1.0 Beta missing graphics for trident Ocean and tech Nichts

2007-06-26 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39397 Christian Knoke wrote: Now, with Revision 13020, the ocean tiles problem seems gone, Yes, there were two t.ocean1 reports. Sadly, you'd neglected to mention that you are/were using trident tileset, not default amplio. Made it hard

Re: [Freeciv-Dev] (PR#39365) 2.1.0b4 random number seed not restored correctly

2007-06-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39365 Marko Lindqvist wrote: See #2346 and #11348 Actually there is a lot of stuff like #11348 in AI code. Thanks, I've added some links in RT for future reference. ___ Freeciv-dev mailing

[Freeciv-Dev] (PR#11348) Bug: ai.building_want is not saved

2007-06-29 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=11348 building want is still not saved, but I've saved the next_recalc time in PR#39365, as that random turn was kicking the random state. I'm not sure I agree about building want. As long as it is entirely predictable, it should simply be

Re: [Freeciv-Dev] (PR#39405) S2_1 compile fails in diplodlg.c

2007-06-30 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39405 Daniel Markstedt wrote: As of r13028, build fails in citydlg.c instead: citydlg.c: In function `units_orders_city_dlg_callback': citydlg.c:416: error: structure has no member named `type' citydlg.c:419: warning: implicit

Re: [Freeciv-Dev] (PR#39405) S2_1 compile fails in diplodlg.c

2007-07-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39405 Daniel Markstedt wrote: I have some kind of header problem here. Despite this, gettext seems to work. Reported it two years ago (see the latter part of the ticket at http://rt.freeciv.org/Ticket/Display.html?id=13287 ) I'm running

[Freeciv-Dev] (PR#39426) BUG: government/nation name translation

2007-07-01 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39426 These seem inextricably combined. This patch gets my verbose log down to only 57 lines! Considering that the first verbose logs I made (May 10) had 728 lines, and probably twice that with the many: 3: last message repeated 2 times

Re: [Freeciv-Dev] (PR#39426) BUG: government/nation name translation

2007-07-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39426 Committed trunk revision 13038. Surprisingly few differences from S2_1. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39427) BUG: city_style unit_class name translation

2007-07-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39427 This is the last of the translate_data_names() fixes. To quote the FIXME: FIXME: Because of the way translate_data_names works, ruleset names aren't normally translated at the client until the game starts. Obviously this is

Re: [Freeciv-Dev] (PR#39405) S2_1 compile fails in gui-sdl

2007-07-02 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39405 That turned out to be relatively easy to fix. Send more reports! Committed S2_1 release 13041. Index: client/gui-xaw/repodlgs.c === --- client/gui-xaw/repodlgs.c

Re: [Freeciv-Dev] (PR#39405) S2_1 compile fails in gui-sdl

2007-07-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39405 Christian Prochaska wrote: Some pointer-to-integer conversion warnings are left. Patch attached. Looks good to me by visual inspection. Committed S2_1 revision 13043. ___ Freeciv-dev

[Freeciv-Dev] (PR#39433) cleanup name translation

2007-07-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39433 Now, I've come full circle to the terrain name translation that started me down this path a month ago! This patch renames some of the terrain functions to match similar functions in other headers. terrain_by_identifier

Re: [Freeciv-Dev] [Freeciv-i18n] .po entry makes trouble (PR#39425)

2007-07-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39425 That's a fine patch, but Per fixed the same thing in trunk long ago. Could Per please take a look about applying the same thing to S2_1? r11988 | per | 2006-05-20

Re: [Freeciv-Dev] [Freeciv-i18n] .po entry makes trouble (PR#39425)

2007-07-03 Thread William Allen Simpson
URL: http://bugs.freeciv.org/Ticket/Display.html?id=39425 I did commit the patch in revision 13045, but forgot to mention it in the log. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

  1   2   3   4   5   6   7   8   >