[Freeciv-Dev] (PR#40430) Bug: Incorrect check for libggz in 2.1.6

2008-08-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40430 > This is an error in ggz.m4 but I don't know quite where. The intended behavior is: * libggz and ggzcore and ggzmod >= 0.0.14 are required for client support. If --with-ggz-client=yes is given, configure exits if they are not found; otherwi

[Freeciv-Dev] (PR#40401) consistent segfault

2008-07-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40401 > Just on a hunch, try running it without sound: civclient -P none I believe it is. Also, you showed the behavior of the program in gdb but not a backtrace. After it crashes type "bt full" and send the output from that. Thirdly, you're runni

[Freeciv-Dev] (PR#40316) enemy cities not shown in fogged tiles

2008-07-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40316 > As madeline points out, your patch is not right at all. But it does make the problem clear: the "dumb city" information is being sent to the client but ptile->city is not being set correctly there. The error most likely resides in handle_ci

[Freeciv-Dev] (PR#40144) [Patch] Build multiple clients at once

2008-07-22 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40144 > For the record I think this is a great idea. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40317) ggz savegame support

2008-07-03 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40317 > New patch. Some version checks will be necessary as only newer ggzd versions have savegame support. And it's still not quite working. -jason Index: configure.ac === --- confi

[Freeciv-Dev] (PR#39568) cannot sell an improvement

2008-06-28 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39568 > > [pepeto - Mon Oct 15 17:07:29 2007]: > > Isn't this ticket resolved? Or does it need some more improvement? What about 2.0? Is it still broken there? -jason ___ Freeciv-dev mailing list Freec

[Freeciv-Dev] (PR#40319) Removing a player causes client disonnection

2008-06-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40319 > Indeed, the same bug was present before but the symptoms were not as harsh. After the "fix" game.players[-1] gets entirely overwritten; before only some of it did, when game.nplayers dropped to negative in the client. The error seems to be

[Freeciv-Dev] (PR#39358) vote in pregame

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39358 > A 5-minute fix for this is to stick the votes into the player structure. This is easy enough but as the vote records are still in an array inside the vote structures themselves player reordering will change everyone's vote around. Which bas

[Freeciv-Dev] (PR#39745) [Bug] 2.0 removing player should reset his team

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39745 > Seems this exact fix was already done for 2.1 and 2.2. Should work fine for 2.0 also. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39745) [Bug] 2.0 removing player should reset his team

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39745 > Kinda strange, if you remove then create a player the team gets reset but if you disconnect then a new player connects, it does not get reset. But I wonder if this bug could hit other fields in the player structure too. What about re-initti

[Freeciv-Dev] (PR#39131) Connection troubles

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39131 > I frankly have no idea if this change is correct. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#38354) Autoconnect can't handle password

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=38354 > Any idea if this is present on 2.1/2.2/trunk? How do I set up a server with authentication anyway? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-d

[Freeciv-Dev] (PR#12472) abusable bug: team research

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=12472 > Good patch. This variant turns it into a function and sync's the whole research structure. I'll commit shortly. -jason Index: server/plrhand.c === --- server/plrhand.c (revis

[Freeciv-Dev] (PR#40124) Server option to disable hack challenge

2008-06-23 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40124 > Seems reasonable. However the hack request packet needs to be discarded too. I also think the GGZ case should be explicit, rather than requiring GGZ to call --no-hack. -jason ___ Freeciv-dev ma

[Freeciv-Dev] (PR#39472) Bug in v2.08 & 2.09 - Crash

2008-06-22 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39472 > map.num_continents is never actually sent to the client - the client just deduces it from the continent numbers of each tile. So when new terrain is revealed, which can happen mid-turn, the num_continents can rise (packhand.c:2039 in S2_0).

[Freeciv-Dev] (PR#40303) [Patch] Fix Global Observer crash in connectdlg

2008-06-22 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40303 > > [EMAIL PROTECTED] - Sun Jun 22 07:01:15 2008]: > > Marko Lindqvist wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=40303 > > > > > $subject > > > > To be committed soon. > > if (game.player_ptr) { > char *text; >

[Freeciv-Dev] (PR#40227) Invalid string conversion from UTF-8 to ISO-8859-1

2008-05-07 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40227 > > [EMAIL PROTECTED] - Sun May 04 09:50:59 2008]: > > 2008/5/4 Jason Dorje Short: > > > > This is not a bug in freeciv. If you use a non-universal character set > > on your command line then freeciv will simply be unable to display some >

[Freeciv-Dev] (PR#40094) Wrong choice of defender

2008-02-12 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40094 > It may be a foolish or misplaced bit of "intelligence", but I'm pretty sure the reason for this is that when you attack with the howitzer the game judges the battle unwinnable and thus defends with the cheaper unit. -jason

[Freeciv-Dev] (PR#39563) [Bug] AI doesn't want to build anything in trunk / default.ruleset

2008-02-12 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39563 > > [EMAIL PROTECTED] - Tue Feb 12 22:42:03 2008]: > > /** > -... > -**/ > -void copy_if_better_ch

[Freeciv-Dev] (PR#40085) add maxconnectionsperhost option

2008-02-06 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40085 > For reasons that should be apparent to anyone familiar with internet security, a maxconnectionsperhost option or similar connection-throttling feature would be desirable. I believe such a feature exists in the warclient; would one of the war

[Freeciv-Dev] (PR#40080) replace city id with tile pointer or index

2008-02-05 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40080 > > [wsimpson - Tue Feb 05 13:29:46 2008]: > I've found a serious overflow bug already. The ids are unsigned short, the > range is 65536 numbers, but ai/aidata.c allocates all players arrays with: > > /* max size of a short */ > #define MAX_

[Freeciv-Dev] (PR#40068) client gtk_progress_set_percentage() assertion

2008-02-04 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40068 > > [wsimpson - Sun Feb 03 12:30:40 2008]: > > Jason Short wrote: > > Saving and loading doesn't generally give identical AI behavior so if > > this is caused by AI units moving or something then you won't

[Freeciv-Dev] (PR#40070) Server crash 3

2008-02-03 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40070 > get_city_bonus is passing in a NULL city. This is allowed according to the effects interface (undocumented of course) but because it calls city_owner that function now segfaults on it. I have no definite opinion on whether NULL targets are

[Freeciv-Dev] (PR#40068) server crash

2008-02-03 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40068 > > [wsimpson - Sat Feb 02 23:07:04 2008]: > > Jason Short wrote: > > Looks to me like this means dsite->location is invalid. I have no > > familiarity with this code however. > > > That's (my) very

[Freeciv-Dev] (PR#40069) server crash 2

2008-02-03 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40069 > Looks identical (or at least indistinguishable) from PR#40068. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40068) server crash

2008-02-02 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40068 > > [chrisk - Sat Feb 02 12:25:18 2008]: > > > SVN S2_2 rev 14375 02 FEB 2008 GTK2 > > Unreproducible server crash. I think I was moving a trireme. Previous > savegame attached. Core file available on request. Backtrace follows. tile0 is be

[Freeciv-Dev] (PR#40060) civserver core dump on debug command

2008-01-31 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40060 > This doesn't reliably crash for me either. But the memory error is obvious enough from the backtrace and shows up in valgrind. This will cause arbitrary memory reads every time /debug is done with no parameters. Looks like this affects onl

[Freeciv-Dev] (PR#40064) Server crash

2008-01-30 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40064 > Looks like this is cause by 40063. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40057) strerror->mystrerror

2008-01-30 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40057 > Committed. S2_1, 14357 S2_2, 14358 trunk, 14359 ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#40058) mystrerror() and local encoding

2008-01-28 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40058 > Patch is fine but the comment is a bit misleading - generally the returned value is passed off to GTK which wants it in UTF-8 (aka the internal encoding). When used in the server this may not be the case. A similar patch should then work fo

[Freeciv-Dev] (PR#40028) gtk/pango invalid UTF-8 warning, fix documentation

2008-01-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > Here is a quick and partial fix. I assume that strerror() is one of the most common offending functions, so I quickly went through and converted all mystrerror users in client/ and server/ directories to use the newly-written L_(). The only

[Freeciv-Dev] (PR#40020) Segfault in server aiunit.c ai_manage_units => plrhand.c maybe_make_contact()

2008-01-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40020 > I just ran it under S2_1 as: $ ./ser -f ~/-0200x.sav -p 5557 ... > set timeout 1 > start ... > civserver: player.c:246: player_index: Assertion `pplayer' failed. Aborted (core dumped) Then the same under valgrind: ==5035== Invalid read of

[Freeciv-Dev] (PR#40028) gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-26 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > > [wsimpson - Sat Jan 26 10:38:42 2008]: > > Jason Short wrote: > >> Madeline Book wrote: > >>> Oh wow, it really was trivial! But certainly not obvious > >>> for the likes of me :(. Once I ra

[Freeciv-Dev] (PR#40028) gtk/pango invalid utf8 warning for LANG=fr_FR

2008-01-25 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40028 > > [wsimpson - Mon Jan 21 09:51:15 2008]: > > Madeline Book wrote: > > Oh wow, it really was trivial! But certainly not obvious > > for the likes of me :(. Once I ran the client with LANG= > > fr_FR.UTF-8 the libc messages displayed correctly

[Freeciv-Dev] (PR#39792) explore server assert

2008-01-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > > [wsimpson - Tue Jan 15 17:28:03 2008]: > > Jason Short wrote: > > I'd really like a savegame from which this can be reproduced. > > > What's wrong with the two existing savegames they've alr

[Freeciv-Dev] (PR#40016) 2.1.2 assert - message pane after turn done

2008-01-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40016 > This is the same as 39991 which explains the cause. The message click is being dequeued after the next turn has started, meaning the message list was already reset. So it tries to activate message 5 (say) but the message list is of length 0

[Freeciv-Dev] (PR#39991) 2.1.1 GTK assert message pane after turn done + SDL future tech

2008-01-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39991 > I think neither of these bugs may be easy to solve. > [EMAIL PROTECTED] - Sat Dec 29 03:13:49 2007]: > > Version: Freeciv 2.1.1 > > Client crash bug 1: (SDL AND GTK) >During the end-of-turn processing, you can still click on things on

[Freeciv-Dev] (PR#40006) Placeholder strings like %d for gold amount isn't replaced

2008-01-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40006 > #: server/unittools.c:2143 #, c-format msgid "You found %d gold." msgstr "金%dを見つけました。" static void hut_get_gold(struct unit *punit, int cred) { struct player *pplayer = unit_owner(punit); notify_player(pplayer, punit->tile, E_HUT_GOLD,

[Freeciv-Dev] (PR#40007) Crash when upgrading unit using Japanese language

2008-01-14 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40007 > > [wsimpson - Mon Jan 14 05:22:11 2008]: > > Was finally able to get some labels showing in Japanese (mostly _Quit, > _Cancel, but hardly any other buttons) -- the upgrade dialog showed English, > and it didn't crash That means that the

[Freeciv-Dev] (PR#39792) explore server assert

2008-01-14 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39792 > I'm pretty sure the bug here is more than just removing the assert. In the examples given, there WAS more to explore. Yet exploration stopped, and (presumably) inside the explore code the unit was turned off of explore mode, which isn't sup

[Freeciv-Dev] (PR#40008) Server sends message using inappropriate language

2008-01-14 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=40008 > > [wsimpson - Fri Jan 11 18:48:25 2008]: > > Agro Rachmatullah wrote: > > However, the server sends Japanese message to all players (e.g., turn > > X starts)! Which means it will irritate people that can't understand > > Japanese. > > I al

[Freeciv-Dev] (PR#39970) BUG: makes fuzzy msgstr with c-format, when the msgid doesn't have any

2007-12-18 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39970 > Ugly problem. Isn't there a po-check script that compares printf arguments in the po files? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39954) Savegame got corrupted - Bug? Cannot Meet with nations any longer.

2007-12-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39954 > I should add, as a quick workaround you can just aitoggle yourself. Type /aitoggle in the command line. This is a significant bug though that should be a priority for the next 2.1 release. > [guest - Thu Dec 13 03:29:53 2007]: > I still

[Freeciv-Dev] (PR#39961) Open diplomacy tabs from previous turns have wrong data during current turns

2007-12-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39961 > I agree that these dialogs should be automatically closed on turn end, and that it's a bug that they aren't updated. But there's more to the problem than just closing them. Cities, gold, and treaty status can change mid-turn and it is a bug

[Freeciv-Dev] (PR#39957) multiple bugs in HACK handling

2007-12-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39957 > > [book - Mon Dec 10 16:22:28 2007]: > We ameliorated this situation somewhat for warserver by > introducing/modifying the cmdlevels to: [...] What's the difference between ADMIN and CTRL access levels? -jason __

[Freeciv-Dev] (PR#39959) SaveGame compression level changes when Leaving & (re)Loading savegames!

2007-12-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39959 > Not sure how you could get the idea this was caused by the rulesets... The bug is simple; compress_level (and in the development version, compress_type) are not saved in the savegame. Attached are some quick patches to fix it. This should

[Freeciv-Dev] (PR#39961) Open trading tabs from previous turns have wrong data during current trading...

2007-12-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39961 > > [EMAIL PROTECTED] - Mon Dec 10 23:16:18 2007]: > > Any open trading tabs from previous turns have wrong data during >current trading because there is no refresh. For example, Gold >data is not refreshed and a NEW trading tab is no

[Freeciv-Dev] (PR#39954) Savegame got corrupted - Bug? Cannot Meet with nations any longer.

2007-12-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39954 > This is a reintroduction of an old, oft-fixed, and apparently under 2.1 oft-reported bug. Namely, the save (autosave) is being created with the human player toggled to AI. On load the AI flag is not unset. This happened in the past when th

[Freeciv-Dev] (PR#8737) mapview centering error caused by panel resize

2007-12-09 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=8737 > > [wsimpson - Fri Dec 07 10:58:13 2007]: > > Christian Knoke wrote: > > A vertical resize could be avoided if you move the minimap to the top. > > > I don't understand this comment. The minimap is already on the top here. True, though that

[Freeciv-Dev] (PR#39798) cheat using goto to explore

2007-12-01 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39798 > > [wsimpson - Sat Nov 17 15:47:54 2007]: > As I reported, "folks are trying to use goto to explore." That is, they > *want* to cheat. I included specific references. Please read and think > before pontificating. Okay, although you specif

[Freeciv-Dev] (PR#30483) 2.1.0b2/Windows Mouse goto with Air units causes client crash

2007-12-01 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=30483 > Is this still a problem? Or have these goto bugs been fixed? -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39602) quickselect doesn't like the selection of many units

2007-12-01 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39602 > Your last patch looks like it does what it says it does. And I agree the current code is broken (modifying a unit list inside the list iterator is a no-no, that's what iterate_safe is for, but even with iterate_safe the behavior is broken as

[Freeciv-Dev] (PR#39937) [wishlist] civil war message takes you to capital

2007-12-01 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39937 > > [EMAIL PROTECTED] - Sat Dec 01 05:12:21 2007]: > > when a country is split by civil war (after you capture their capital), > you are given a message in the 'messages' tab. it would be great if > clicking this took you to the capital you ju

[Freeciv-Dev] (PR#39909) BUG: leader gender ignored in diplomat/spy dialog

2007-11-28 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39909 > > [wsimpson - Sun Nov 25 18:14:27 2007]: > > "Sir, the diplomat is waiting for your command" > "Sir, the spy is waiting for your command" Problematic. Using Sir and Ma'am does not jive well with all governments. But there is no form-of-ad

[Freeciv-Dev] (PR#39747) translation comment syntax bug

2007-11-28 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39747 > > [chrisk - Thu Oct 04 06:42:32 2007]: > > > SVN 04 OCT 2007 V2_1 > > server/auth.c > >if (show_source == SST_DEFAULT) { > /* TRANS: After 'Auth option "user":'. Option value may have > been inserted > * between

[Freeciv-Dev] (PR#39808) Use $sysconfdir for ggz config dirs in relevant Makefiles.

2007-11-28 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39808 > I'm pretty sure this patch is correct from freeciv's end but the ggz.m4 file may still need some tweaking. I'm not sure if the ggzdconfdir that it sets should use ${sysconfdir} (allowing a make-time override, which would be rather bad in mos

[Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > Oops. Your AC_GNU_SOURCE macro works and compiles fine but some time later I notice the cryptic warning + running aclocal ... configure.ac:168: warning: AC_COMPILE_IFELSE was called before AC_GNU_SOURCE ../../lib/autoconf/specific.m4:331: A

[Freeciv-Dev] (PR#39917) Diplomacy model bug: War as default relation for (previously) uncontacted allies of allies

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39917 > > [per - Tue Nov 27 07:08:39 2007]: > There are two ways to fix this: > - When you first meet an ally of your ally, the default state is > cease-fire (brokered by your ally), and perhaps an offer of peace. > - Or, when your ally allies som

[Freeciv-Dev] (PR#39849) strcasestr warning

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39849 > > [EMAIL PROTECTED] - Tue Nov 27 17:48:50 2007]: > > On 27/11/2007, Marko Lindqvist wrote: > > Now I got this same error in Ubuntu system. > > > > It seems that user has to define "_GNU_SOURCE" for "__USE_GNU" to > be defined. > > > > No

[Freeciv-Dev] (PR#39919) freeze on Haiku (formaly openbeos)

2007-11-27 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39919 > Can you kill it with a SEGV and get a backtrace? Or run within gdb? And yeah, disabling sound might be wise...sound really shouldn't crash though. -jason ___ Freeciv-dev mailing list Freeciv-de

[Freeciv-Dev] (PR#39722) gcc-4.2 -O2 compile fails as predicted

2007-11-26 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39722 > Indeed, this is officially a gcc bug, explained in 39459 in more detail. https://bugzilla.novell.com/show_bug.cgi?id=300410 Nonetheless I see no problem with working around it (as 39459 did). In general we should strive to remove pointer-t

[Freeciv-Dev] (PR#39914) Freeciv Crash

2007-11-26 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39914 > > [guest - Mon Nov 26 16:13:28 2007]: > > hi, > freeciv client crashes too often after about 5-6 turns. sometimes says > connection to server lost on a localhost game. Attached a bug report. > thanks What platform are you using? What versi

[Freeciv-Dev] (PR#39808) Use $sysconfdir in relevant Makefiles.

2007-11-26 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39808 > > [jordi - Mon Oct 29 11:17:56 2007]: > > data/Makefile.am installs GGZ stuff in the wrong place. > > Attached patch should fix it. > Actually it should be installed in $ggzdconfdir which is provided by AC_GGZ_SERVER (which isn't, but sho

[Freeciv-Dev] (PR#39883) Gtk2 client tends to flake out after a while

2007-11-25 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39883 > > [EMAIL PROTECTED] - Sun Nov 25 23:36:16 2007]: > OK, I've done this and I think there is a clue here. Everything here looks consistent with memory leaks or other memory errors (buffer overwriting). -jason __

[Freeciv-Dev] (PR#39722) Change CMA by F1 panel don't work (gcc-4.2 specific bug)

2007-11-25 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39722 > I'm going to commit a fix for this (why not) but I'd like more details. What platform are you using? Are you really saying that GINT_TO_POINTER is not reversible for negative numbers on your platform? If that's the case we need to audit a

[Freeciv-Dev] (PR#39837) Happiness in big empires

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39837 > > [guest - Mon Nov 05 15:18:53 2007]: > > Hi Freeciv Team > > I'm just wondering if it is a feature or really a bug. Plying freeciv > 2.1 for some days and found a difference in the happiness to the > previous encountered game behavior. > R

[Freeciv-Dev] (PR#39885) Picks same nation twice from civil war list from same host nation

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39885 > It doesn't look the same as 17436. >From split_player() player_set_nation(cplayer, pick_a_nation(civilwar_nations, TRUE, FALSE, NOT_A_BARBARIAN)); The FALSE indicates that the is_available flag

[Freeciv-Dev] (PR#39897) Suggestion: geographic location of cities

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39897 > > [guest - Fri Nov 23 18:43:31 2007]: > > Right now the city naming depends on the city placement, e.g. are there > rivers or mountains or cost fields nearby. > I have a new idea. How about attaching to each possible city name two > numbers

[Freeciv-Dev] (PR#39883) Gtk2 client tends to flake out after a while

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39883 > > [EMAIL PROTECTED] - Thu Nov 22 18:54:08 Playing a full game through with a memory leak program enabled (valgrind works here but is too slow for a full game) would be very revealing I think. > There is a fair amount of error reportage o

[Freeciv-Dev] (PR#39880) Right click GUI and Lepoard

2007-11-24 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39880 > > [EMAIL PROTECTED] - Thu Nov 22 12:32:32 2007]: > > On Nov 22, 2007 12:54 PM, Daniel Markstedt <[EMAIL PROTECTED]> wrote: > > > I have been running the game in OS X and on BootCamp Windows XP. In > > > Leopard it first has to run X11 (whi

[Freeciv-Dev] (PR#16162) 2.1.0b1: help call crashes civclient

2007-11-21 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=16162 > Great if this is fixed now but it is possible this is a tileset issue. Some tilesets are missing some graphics; the corresponding query calls return NULL for the sprite but some code will then crash on a NULL sprite. What tileset did you or

[Freeciv-Dev] (PR#39875) default theme scroll bar thumbs are hard to see

2007-11-21 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39875 > >From being too small? They should be remade as SVG and rendered at a couple different sizes. -jason ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#39748) elephant help text

2007-11-21 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39748 > > [dmarks - Tue Nov 20 22:15:22 2007]: > > On 11/20/07, William Allen Simpson <[EMAIL PROTECTED]> wrote: > > > > http://bugs.freeciv.org/Ticket/Display.html?id=39748 > > > > > Erik Johansson wrote: > > > Elephants are towering animals traine

[Freeciv-Dev] (PR#39838) Dollar symbol

2007-11-21 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39838 > > [dmarks - Mon Nov 19 22:13:55 2007]: > > Replaces dollar symbol in economy icon with gold coin symbol borrowed from > gui-sdl theme Human by Hogne Hasjkold. Aren't these small graphics all mapped from SVG files? It should be easy enough

[Freeciv-Dev] (PR#39870) unithand routines misnamed handle_* and real_*

2007-11-18 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39870 > > [wsimpson - Sun Nov 18 01:56:44 2007]: > > Whether by history or mistake, some functions have a leading handle_ that > are not actually network packet routines. Another has leading real_ > > This makes reading the code more difficult, as

[Freeciv-Dev] (PR#39818) 2.1.0 multiple bugs from same savegame, plus suggestions

2007-11-18 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39818 > > [wsimpson - Sat Nov 17 14:58:40 2007]: > > Daniel Markstedt wrote: > > The crash caused by this bug is resolved, but the city still stayed > > behind when I last tested. See #39830 > > > As he would have known had he actually read the thr

[Freeciv-Dev] (PR#39801) harmonize goto_map_list with focus_units

2007-11-16 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39801 > This appears to be applied so I'm closing it. ___ Freeciv-dev mailing list Freeciv-dev@gna.org https://mail.gna.org/listinfo/freeciv-dev

[Freeciv-Dev] (PR#13348) goto units move before workers finish roads

2007-11-16 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=13348 > > [bhudson - Mon Jun 27 00:31:12 2005]: > > Look at the caravan halfway between Munster and Stuttgart. The next two > tiles have engineers/workers almost done building rails, but the caravan > moves before they finish, so it ends up in Stut

[Freeciv-Dev] (PR#15629) 'g' goto with triremes into unknown waters cheat

2007-11-16 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=15629 > This is not a "cheat". It's not possible for client goto to cheat since it knows nothing more than what the player knows. What actually happens is that a goto that ends in a dangerous tile is disallowed by the "clever" dangerous-tile pathfi

[Freeciv-Dev] (PR#39798) cheat using goto to explore

2007-11-16 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39798 > > [wsimpson - Sat Oct 27 09:22:54 2007]: > > I'm trying to understand the goto problem reports, and one common thread > seems to be that folks are trying to use goto to explore. Then, they > complain that it won't goto an unknown location (

[Freeciv-Dev] (PR#39818) 2.1.0 multiple bugs from same savegame, plus suggestions

2007-11-16 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39818 > > [EMAIL PROTECTED] - Thu Nov 01 13:27:58 2007]: > > Ok, I made that one reproducable, too. > > End turn > Save Game > Leave > Load last saved game > Open city dialog of Ibadan -> crash > > Thats really easy to follow. You will see immedia

[Freeciv-Dev] (PR#39867) freeciv 2.1.0 crashes when I conquer a city with paratroopers.

2007-11-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39867 > > [guest - Thu Nov 15 10:24:17 2007]: > > Hi, > > When I conquer a city using the "Q" option of my paratrooper, freeciv > crashes :/ > > It doesn't If I simply go into the city with my para. What client are you using? Can you provide (at

[Freeciv-Dev] (PR#39858) middle click on unexplored territory causes SDL crash

2007-11-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39858 > You're overreacting. > [wsimpson - Wed Nov 14 23:58:10 2007]: > > Jason Dorje Short wrote: > > SDL client, but it probably happens on any client. If the text.c > > function gets called for an unknown tile then ptile->terrain is NULL. > >

[Freeciv-Dev] (PR#39858) middle click for terrain info on unexplored territory causes crash

2007-11-14 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39858 > > [wsimpson - Wed Nov 14 11:28:11 2007]: > In GTK2 for 2.1 -- just tested (again) -- the unknown tile does *not* > popup > the info box. That's the correct solution! It's a client problem This patch fixes text.c to give a better info

[Freeciv-Dev] (PR#39858) middle click for terrain info on unexplored territory causes crash

2007-11-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39858 > > [guest - Mon Nov 12 11:35:46 2007]: > > If I middle click for terrain info on unexplored territory it causes a crash > (gdb) bt #0 0x080f4ecd in terrain_name_translation (pterrain=0x0) at terrain.c:131 #1 0x080f6a1c in tile_get_info_te

[Freeciv-Dev] (PR#39857) attempt to bribe barbarian causes crash

2007-11-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39857 > > [guest - Mon Nov 12 11:30:43 2007]: > > > If the diplomat in the city attempts to subvert the barbarian legion > with a bribe of 100 gold the game will crash. #0 0x0812f8b2 in diplomat_bribe_yes_callback (pWidget=0x93ee968) at diplo

Re: [Freeciv-Dev] (PR#39391) Warnings in lua code

2007-06-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39391 > On 6/10/07, Per I. Mathisen <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39391 > > > cc1: warnings being treated as errors > ltable.c: In function ‘luaH_mainposition’: > ltable.c:108: warning: cast from po

[Freeciv-Dev] (PR#39357) 2.1.0b4: CRASH when trying to edit global worklists

2007-05-05 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39357 > > [s1kevin - Wed Apr 25 02:43:53 2007]: > > Freeciv crashed when I tried to create a worklist. I had just loaded a > saved game from 2.1.0b3, attempted to add a worklist (knowing that there > were none), then FC crashed. Without a backtrac

[Freeciv-Dev] (PR#39360) 2.1.0b4 civclient usability changed for worse

2007-05-05 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39360 > > [s1kevin - Fri Apr 27 03:19:38 2007]: > > Usability dramatically decreased with 2.1.0b4. After creating a new > game, I changed the worklist immediately to settlers, settlers, > settlers, settlers, warriors, settlers, warriors, coinage.

[Freeciv-Dev] (PR#39363) Another fix for PR#12232

2007-05-05 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39363 > Try this one. It uses more direct logic and removes the (quite unnecessary) assertion. -jason Index: common/player.c === --- common/player.c (revision 12929) +++ common/player

[Freeciv-Dev] (PR#39143) 2.0.9 income and AI control bugs

2007-04-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39143 > > [EMAIL PROTECTED] - Wed Mar 28 19:43:50 2007]: > > Hi! > > During the last game session with the 2.0.9 standard version two bugs > were discovered: > > A) At some point my income was fixed to nine and payment to zero. Changing > the tax

[Freeciv-Dev] (PR#39330) Crash When Sharing Vision By Treaty (SVN Head)

2007-04-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39330 > This is a tough bug. Looks to me like this is at the heart of a deeper problem where shared vision does not correctly handle vision layers or seen_count. Perhaps someday it would be appropriate to go through and rewrite shared vision so tha

[Freeciv-Dev] (PR#39328) Reproducible Crash When Changing Tech Goal (2.1.0-b4 and SVN Head)

2007-04-15 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39328 > The current code is clearly wrong. The va_arg may be implemented as a pointer rather than an inline array and so passing it multiple times to vsnprintf will generate garbage results on some platforms while working on others. Nothing I've re

Re: [Freeciv-Dev] (PR#39342) 2.1.0-beta4 border vs. fog of war

2007-04-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39342 > Not drawing borders under FOW is an interesting solution. If someone will make a patch for it we can test it out and see if it's playable. That would mean owner information for fogged tiles would not be sent to the client (probably in mapha

Re: [Freeciv-Dev] (PR#39340) 2.1.0-beta3 - connected islands

2007-04-13 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39340 > Send us one or more rc files (particularly mapseed but also number of players) to reproduce it. Delving into the mapgen code is a very tricky business however. -jason ___ Freeciv-dev mailing li

Re: [Freeciv-Dev] (PR#39330) Re: (PR#39335) Re: Fix for PR#39330

2007-04-11 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39330 > On 4/11/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39330 > > > Jason Short wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39330 > > &

Re: [Freeciv-Dev] (PR#39330) Re: (PR#39335) Re: Fix for PR#39330

2007-04-11 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39330 > On 4/11/07, [EMAIL PROTECTED] <[EMAIL PROTECTED]> wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39330 > > > Jason Short wrote: > > http://bugs.freeciv.org/Ticket/Display.html?id=39335 > > &

[Freeciv-Dev] (PR#39328) Reproducible Crash When Changing Tech Goal (2.1.0-b4 and SVN Head)

2007-04-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39328 > I don't get it. The args parameter is being modified inside the vsnprintf function? I had always thought it was the other way around - va_start could only be called once per function but once called the vargs list was safe to be passed

[Freeciv-Dev] (PR#39334) Assertion Failure During Tile Update (GTK Client; SVN Head)

2007-04-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39334 > Very likely related to 39330. Whatever you are doing with treaties is unusual and is triggering some little-used code path that reveals bugs. -jason ___ Freeciv-dev mailing list Freeciv-dev@gn

[Freeciv-Dev] (PR#39335) Re: Fix for PR#39330

2007-04-10 Thread Jason Short
http://bugs.freeciv.org/Ticket/Display.html?id=39335 > On 4/10/07, Eric McDonald <[EMAIL PROTECTED]> wrote: > Hi, > >Attached to this message is a patch to fix the issue reported in > PR#39330. Basically, the problem seems to be that cities can see unknown > terrain, and this is considered ac

  1   2   >