Re: [OT] paranoid

2008-03-04 Thread Tom Schneider
LOL Oh, I didn't tell you, the JUEL plugin has some experimental psychic code in it. Part of the Apache 'I know what you did last summer!' project. :) Tom Musachy Barroso wrote: I was playing around with JUEL plugin last night, and while running the example I saw the first input on the form

Re: Thoughts on JSPs and OGNL

2008-01-27 Thread Tom Schneider
Brian, I worked on Unfied EL a bit towards the end of last year: http://cwiki.apache.org/S2PLUGINS/unified-el-plugin.html I was able to get it working for basic expressions, but it is nowhere near ready for production. It would need a lot more coding/testing before it would even be

Re: Thoughts on JSPs and OGNL

2008-01-27 Thread Tom Schneider
Unfortunately, I haven't had much (any) time to work on s2 at all since December. Feel free to poke around and see how far you can get. Tom Brian Pontarelli wrote: Tom Schneider wrote: Brian, I worked on Unfied EL a bit towards the end of last year: http://cwiki.apache.org/S2PLUGINS/unified

Re: Struts 2.1.1 Release Planning

2008-01-14 Thread Tom Schneider
+1 for ditching JDK 1.4 on the Struts 2.1.x series. Struts 2.0.x should be a reasonable transition for those still on JDK 1.4. Tom On Jan 14, 2008 10:37 AM, Ted Husted [EMAIL PROTECTED] wrote: Works for me. It has to happen sometime. On Jan 14, 2008 11:27 AM, Al Sutton [EMAIL PROTECTED]

Re: [S2] Libraries in JDK 1.4 distribution

2008-01-12 Thread Tom Schneider
I disagree, I think there is a support cost. If users are having issues with the 1.4 stuff, (which happens more often than not) then we're obligated to assist that user. If we dropped the 1.4 stuff, maybe for Struts 2.1, then we would no longer have that obligation. Long term I think we

Re: Destroy Of Interceptor

2007-12-14 Thread Tom Schneider
You know, I think you're right! I searched the entire codebase (both xwork and struts) and I have found nowhere where we call destroy() on the interceptors. I guess that hasn't been an issue because if the destroy isn't being called, no big deal because your usually shutting down anyway. If we

Re: web-beans ?

2007-12-14 Thread Tom Schneider
Actually, we've done a little more work on the scope plugin since we took it out of the sandbox: http://cwiki.apache.org/S2PLUGINS/scope-plugin.html Originally we took most of our API from Seam, but I think we'll be diverging from Seam a bit since it will make things easier for s2 users. My

Re: In regards to Struts 2 Validation.

2007-12-12 Thread Tom Schneider
I have plenty of examples from our application. The first is a case where the user must enter at least one phone number and if the type of phone is selected, then the user must enter a phone number. The validation code is as follows: if(!hasFieldErrors(exampleData.phoneNumber1)

Re: [s2] Allowed methods next step

2007-12-09 Thread Tom Schneider
CMA = container managed authentication for those who haven't memorized every three letter acronym under the sun. What about using an s2 interceptor to enforce role security? That way you could have an implementation for whatever security mechanism your using and it's not tied to the struts

Re: In regards to Struts 2 Validation.

2007-12-08 Thread Tom Schneider
additional ideas/suggestions would be greatly appreciated. Tom rburton wrote: Tom Schneider and a few other folks have been talking about validation in Struts 2 and how it can be improved. I figured it would be useful to spawn a thread in order to stir up some idea’s that may help inspire us. I

Re: JSP EL in struts2 tags

2007-12-03 Thread Tom Schneider
cycle. I'm guessing I'll probably start on it sometime this month and finish whenever. . Tom Schneider wrote: I was working on a proof of concept for Unified EL: http://cwiki.apache.org/S2PLUGINS/unified-el-plugin.html I had a basic value stack up and running, however, I never took it any

Re: JSP EL in struts2 tags

2007-12-02 Thread Tom Schneider
I was working on a proof of concept for Unified EL: http://cwiki.apache.org/S2PLUGINS/unified-el-plugin.html I had a basic value stack up and running, however, I never took it any farther than that. Richard Burton is planning on implemented an MVEL stack in the near future, but he's waiting

JRuby in Struts 2

2007-12-02 Thread Tom Schneider
These last 2 weeks, Richard Burton and I have been working on adding JRuby support to S2. We've been successful in getting a very basic action up and running, but we're running into something of an impedance mismatch between S2 and Ruby. Some of the issues we've run into: 1. Ruby's object

Re: JSP EL in struts2 tags

2007-12-02 Thread Tom Schneider
it, and therefore S2 doesn't allow EL. It seems the ideal solution is to offer the option of either EL or OGNL, with only a change in one configuration option needed to specify which. Tom Schneider on 02/12/07 19:34, wrote: I was working on a proof of concept for Unified EL: http://cwiki.apache.org

Re: JRuby in Struts 2

2007-12-02 Thread Tom Schneider
I agree, I think it would be interesting to create a plugin that gives us a seamless full stack: Struts2/Spring/JPA or Struts2/Guice/JPA. However, one of the advantages of Groovy/Ruby is the fact that the classes can be updated just by reloading the page and new language features, such as

Re: REST Plugin and auto-generated XHTML Views

2007-12-01 Thread Tom Schneider
Personally, I !!HATE!! writing xsl. I try to avoid it at all costs, but maybe others might feel differently. Is the idea here that the action would output XML then let the xsl processor on the client convert it to html? If so, would you expect the domain model to be automatically serialized

Re: Googlecode Maven Repository for External Struts 2 Plugins

2007-11-27 Thread Tom Schneider
still have a select group of owners that could remove someone who joined and then turned out to be a troll. -Ted. On Nov 25, 2007 10:12 AM, Tom Schneider [EMAIL PROTECTED] wrote: Hey all, I finally figured out a way to host a maven repository on googlecode. This should greatly simplify using

Re: Googlecode Maven Repository for External Struts 2 Plugins

2007-11-27 Thread Tom Schneider
. Any suggestions would be greatly appreciated. Tom On Nov 27, 2007 11:04 AM, Wendy Smoak [EMAIL PROTECTED] wrote: On 11/25/07, Tom Schneider [EMAIL PROTECTED] wrote: Hey all, I finally figured out a way to host a maven repository on googlecode. This should greatly simplify using googlecode

Did I break bamboo or is bamboo broken?

2007-11-24 Thread Tom Schneider
I checked in a very minor change for WW-2328 and now the Struts2PortletTest is failing in both the java5 and java6 bamboo builds--but with different exceptions. I have a clean checkout of struts2 and everything builds fine locally with a mvn -Pall build. So is this a case of gremlins in the

Googlecode Maven Repository for External Struts 2 Plugins

2007-11-24 Thread Tom Schneider
Hey all, I finally figured out a way to host a maven repository on googlecode. This should greatly simplify using googlecode hosted plugins in Struts 2. For me, it's also much nicer to use maven to deploy than trying to get a jar manually uploaded into the central repository. Instructions

Re: JPA in mailreader

2007-11-21 Thread Tom Schneider
Ted, I finally had a chance to look at your JPA mailreader. I know this was in the original, but I really don't like the way that they have most of the functionality for the actions is in a superclass. To me, that's hiding functionality. (Especially when the domain model is in the super

Re: Struts 2 Plugin for Grails?

2007-11-19 Thread Tom Schneider
together would be awesome. Looking forward to see where this goes. On Nov 13, 2007 9:00 AM, Tom Schneider [EMAIL PROTECTED] wrote: Just for completeness I'd think we'd want a GSPResult. Just because it's slow now, doesn't mean it will be slow in the future. (Look at how slow freemarker

Re: JPA in mailreader

2007-11-15 Thread Tom Schneider
Are you worried about optimistic locking at all? (I'm guessing not for this simple example) Although I think your technique is clever, in a situation where optimistic locking is used, you should really be editing the object that was originally read from the database. Might I suggest the scope

Re: Confluence Rate Plugin for the Plugin Registry

2007-11-14 Thread Tom Schneider
votes Still, I think it is better than nothing, so vote away. Don On 11/11/07, Tom Schneider [EMAIL PROTECTED] wrote: I know I've mentioned this before, but I was wondering if we could use this plugin: http://www.atlassian.com/software/confluence/plugins/rate.jsp To provide user

Re: Struts 2 Plugin for Grails?

2007-11-13 Thread Tom Schneider
Just for completeness I'd think we'd want a GSPResult. Just because it's slow now, doesn't mean it will be slow in the future. (Look at how slow freemarker was before we tweaked it) Also, for those looking to migrate over, if GSP isn't supported, that might be a issue for existing grails

Re: JPA in mailreader

2007-11-12 Thread Tom Schneider
because they indicate that it only exists to help people used to HibernateTemplate / JdoTemplate. -Wes On 11/12/07, Tom Schneider [EMAIL PROTECTED] wrote: My vote is to just use spring, for both EntityManagerFactory injection and Transaction Management. As Richard and I were discussing

Confluence Rate Plugin for the Plugin Registry

2007-11-11 Thread Tom Schneider
I know I've mentioned this before, but I was wondering if we could use this plugin: http://www.atlassian.com/software/confluence/plugins/rate.jsp To provide user rating capabilities for the plugin registry. As more and more of the core functionality becomes plugins, I think it makes sense

Re: Struts 2 Plugin for Grails?

2007-11-11 Thread Tom Schneider
didn't have a ModelAndView for the template to run against) Tom Mark Menard wrote: On 11/7/07 2:58 PM, Tom Schneider [EMAIL PROTECTED] wrote: They are very similar. The difference used to be that s2ss did not require Spring, or didn't support it. I don't exactly recall. Groovy Works requires

Re: Struts 2 Plugin for Grails?

2007-11-11 Thread Tom Schneider
See my comments below: Mark Menard wrote: On 11/11/07 5:07 PM, Tom Schneider [EMAIL PROTECTED] wrote I will agree with you, and I've decided I'm done reinventing wheels. So, I'm game. I'm very pressed for time, but I'm definitely interested in this. I think a bridge from Java based Struts 2

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-07 Thread Tom Schneider
this work, and it wasn't my intent to put down the effort. I guess I was just trying to preempt given some of the OGNL threads. /Ian Tom Schneider wrote: LOL, I didn't know my efforts were going to cause such a raucous. :) Ted is correct--I started this on Saturday on a whim. At this point

Re: Struts 2 Plugin for Grails?

2007-11-07 Thread Tom Schneider
Interesting idea! Another plug-in idea would be to see if there was a way to integrate grails flow: http://www.jcatalog.com/oss/grailsflow/whygrailsflow.html I've been considering ways to make the Spring Webflow Plugin easier. (We all know how much you like that plugin, Matt) There's just too

Re: Struts 2 Plugin for Grails?

2007-11-07 Thread Tom Schneider
How are http://code.google.com/p/s2ss/ and http://code.google.com/p/groovyworks/ different? Looking at the code they look very similar. I've been trying to make sure the Plugin Registry is up to date and has all the plugins that are available, so I'm wondering if these are 2 separate entries, or

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-07 Thread Tom Schneider
a '#' in it. This mean we can never support deferred expressions such as #{exampleBean.exampleProperty}. My fix for this was to all anything that starts with '#{'. On 11/7/07, Brian Pontarelli [EMAIL PROTECTED] wrote: Tom Schneider wrote: On 11/6/07, Don Brown [EMAIL PROTECTED] wrote: Type

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-07 Thread Tom Schneider
Well, Richard Burton is supposed to be working on an MVEL value stack, so hopefully we'll be able to pit them all against each other. :) Tom On 11/7/07, Chris Brock [EMAIL PROTECTED] wrote: For the record, I still maintain that it's better :) Tom Schneider wrote: Putting down my work

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-06 Thread Tom Schneider
LOL, I didn't know my efforts were going to cause such a raucous. :) Ted is correct--I started this on Saturday on a whim. At this point it is completely experimental--we have a long ways to go before it is even close to usable. However, I was able to execute a simple expression using my value

Re: [s2] extras-lib (was JUEL plugin (was Roadmap for the core taglib))

2007-11-06 Thread Tom Schneider
On 11/6/07, Don Brown [EMAIL PROTECTED] wrote: Type conversion isn't tied to OGNL in 2.1. XWork has a new API (copied from OGNL) to abstract type conversion. Of course not all EL's support type conversion in the same way, so there may be issues down the road. i18N isn't tied at all to OGNL,

Re: [S2] Taglib Exercises Appilcation and ShowCase Expectations

2007-11-04 Thread Tom Schneider
I'm not sure it is practical for a junit test to test all the variations of the tags. Just setting up the expected output would be very tedious. I like the idea of having a taglib showcase to test all the tags--I looked at showcase the other day to see if it had this and it didn't. Also,

[s2] Roadmap for the core taglib

2007-11-04 Thread Tom Schneider
Speaking of the core taglib, what ARE we going to do with it. There's been talk of moving them to a separate plugin, reimplementing them in a java, etc. It would be nice to know from a roadmap prespective about where the core taglib is headed--I have several plugins that would be affected by

Re: [s2] Roadmap for the core taglib

2007-11-04 Thread Tom Schneider
Ted Husted wrote: Don's also been doing some preliminary refactoring in XWork so that the expression language can be made pluggable, meaning we would also be able to plugin something else instead of OGNL. -Ted. You mean like JUEL?

Re: [s2] JUEL plugin (was Roadmap for the core taglib)

2007-11-04 Thread Tom Schneider
Isn't that what Ted wanted? A new plug-in a day for 60 days. :) I have one lined up for tomorrow. Tom Don Brown wrote: Whoa, where did that one come from? I was just begging for such a plugin yesterday on #struts from Richard Burton, who is working on an MVEL one. I could see Struts 3 ==

Re: [PROPOSAL] Merge Able/Code Behind/Zero-Config/SmartURLs into view-behind specification

2007-11-01 Thread Tom Schneider
Looks good to me. I was going to suggest putting this on the wiki, but a googlecode project is even better. So would the code for this new struts2 plugin live here or in the struts codebase? On 11/1/07, Ted Husted [EMAIL PROTECTED] wrote: Just to followup, I setup a Google Code site as a place

Re: [S2] Plugins gone wild!

2007-10-22 Thread Tom Schneider
On 10/22/07, Frank W. Zammetti [EMAIL PROTECTED] wrote: I'm still not 100% convinced there's a ton of benefit to this plugin frankly, other than perhaps visibility, but it's there now in any case. That how I feel too with most of the plugins I've written. I wish we could add a plugin

Re: A session value is overwrited by demanding a browser.

2007-10-17 Thread Tom Schneider
No because OGNL can access the private Session variable directly. (I noticed this behavior when I was fixing a race condition) It first tries to call the getproperty(), if that fails, then it will turn on reflection accessibility and access the variable directly. On 10/17/07, Jim Cushing [EMAIL

Re: [PROPOSAL] Merge Able/Code Behind/Zero-Config/SmartURLs into view-behind specification

2007-10-17 Thread Tom Schneider
First of all, I think Ted did a good job of getting a start on this. His proposal is a great start that would unify several misc things that really needed to be unified. (Especially for 2.1.x where it would be nice to have a unified approach to these things) Secondly, our company does the exact

Re: Source and test maven artifacts for struts2

2007-10-08 Thread Tom Schneider
My apologies, I've located https://issues.apache.org/struts/browse/WW-2028 which addresses this issue, please disregard my original email. I'll take a look at this issue today since I've setup builds that have included source. Tom On 10/7/07, Tom Schneider [EMAIL PROTECTED] wrote

Re: [s2] Goal - no experimental code in core for 2.1

2007-10-07 Thread Tom Schneider
+1 for anything that makes configuration easier Don Brown wrote: With the latest refactorings in XWork that allow plugins to provide code that load Packages, I'd like to suggest that we make it a key design feature of Struts 2.1 that Core includes no code labeled experimental. Here is what I

Source and test maven artifacts for struts2

2007-10-07 Thread Tom Schneider
Is there anyplace where the source and test jars are deployed as part of a release? Looking in the central maven repository and on http://people.apache.org/repo/m2-ibiblio-rsync-repository, I only see the bin artifact. I ran into an issue with needing the test artifact because I extend a

Re: WW-1399 - converting mailreader to hsqldb

2007-10-05 Thread Tom Schneider
http://openjpa.apache.org/ is an option too. Seems logical since it is an apache project. On 10/5/07, Ted Husted [EMAIL PROTECTED] wrote: On 10/5/07, Wes Wannemacher [EMAIL PROTECTED] wrote: I am poking around for things I can help with. I came across WW-1399 and I remember some discussion

Re: [s2] The death of the .action extension

2007-09-08 Thread Tom Schneider
What kind of strange new world will it be without .action? I've grown so used to it I can't imagine not using it. So you're saying you would have the same url without the .action part? Now that we have all these options for mapping url's to actions/parameters, is there a new recommended

Re: [s2] The death of the .action extension

2007-09-08 Thread Tom Schneider
Don Brown wrote: Right, and that's why I didn't move to kill it off for 2.1. Give it some time, let the feature get some exercise, then if all agree, we could change the default later. As with any new feature, I'd put it in a sort of experimental category for at least one major release. So,

Re: [s2] Painless migration with WebWork 2 plugin

2007-09-03 Thread Tom Schneider
Nice work Don! I attempted this a while back, but ran into some issues that I couldn't reconcile. I'll definitely be trying this on our app. Tom Don Brown wrote: I've completed a spike on a Struts 2 plugin for WebWork 2, providing a drop-in replacement with no code or configuration file

Re: [S2] Struts tags for generating html, head and body

2007-08-24 Thread Tom Schneider
I already created a body tag on our webwork project at work (we needed the onload event hook) +1 from me. Tom Ted Husted wrote: Another good use for head or body tags might be to generate a JavaScript hook. A head tag could also inject the doctype redtape, that we might otherwise paste into

Re: Struts 2.0.10 versus 2.1.0

2007-08-22 Thread Tom Schneider
I could see 2 ways of handling this and you'll have to provide your input as to which makes more sense: 1. Treat the compressed javascript as a maven artifact and create a custom maven mojo and artifact type to handle it. 2. Use the maven antrun plugin or the assembly plugin to create the

Re: Struts 2.0.10 versus 2.1.0

2007-08-22 Thread Tom Schneider
. Create a profile (it is already done) 3. Execute Dojo's build script with some parameters (pointing to our profile) 4. Rename the 2 main js files and copy them into the plugin musachy On 8/22/07, Tom Schneider [EMAIL PROTECTED] wrote: I could see 2 ways of handling this and you'll have

Re: [S2] [2.1.x] Bundled Plugins

2007-08-19 Thread Tom Schneider
I disagree with moving the Spring plugin outside of the core set of plugins. I think a lot of people use Spring and it would be a shame to not have it as a core feature. Keep in mind that I think we run a huge risk (IMO) of plugins being unmaintained if we set them free, however, I'm more

Re: Struts 1/2 and Logging

2007-07-08 Thread Tom Schneider
So what determines what should be an instance logger and what should be a static logger? From the original article, they recommend creating the loggers as needed when logging in a static context. To me, that implies only instance level loggers are allowed globally to a class. In static

Re: [S2] Heads Up: possible DOS problem

2007-07-05 Thread Tom Schneider
ww:property value=[EMAIL PROTECTED]@currentTimeMillis()}/ works for me, so I think a remote execution is definitely possible. (Something like Runtime.exec would probably cause a lot of problems) Do we need to filter certain classes/methods? I'm not sure how else we would solve this--this could

Re: Portlet plugin

2007-06-11 Thread Tom Schneider
Nils, This is a great start. I had wanted to do this myself, but I never found the time. I only took a brief look at the patch, but a few things jumped out at me: 1. I'm not sure the UrlRendererFactory is needed. I believe the whole purpose of guice is to not have anymore factories

Re: Table Tag With Freemarker Templates

2007-05-31 Thread Tom Schneider
The current version of table tags does use freemarker templates when rendering a table. Tom On 5/31/07, André Faria [EMAIL PROTECTED] wrote: Hi All, I am interested in Table Tags Project to apply it resources in a project with Struts 2, but I'd like to know if you are planning to implement

Re: [S2] Where's Waldo?

2007-05-18 Thread Tom Schneider
I'm here, I've just been insanely busy with other things for the last 2 months. Can you believe they actually want me to write non-open-source business code at work? Absolutely ridiculous. :) I'm hoping things will slow down a bit now, but I can't make any promises. Tom Philip Luppens

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Tom Schneider
I wrote a struts2 caching implementation of the freemarker templates: https://issues.apache.org/struts/browse/WW-1661 Freemarker wouldn't know how to cache the templates as well as struts2 does since we know how the templates are being used and whether or not it is safe to cache them. Tom

Re: OGNL performance detrimental to Struts 2

2007-03-24 Thread Tom Schneider
of 2.1? musachy On 3/24/07, Tom Schneider [EMAIL PROTECTED] wrote: I wrote a struts2 caching implementation of the freemarker templates: https://issues.apache.org/struts/browse/WW-1661 Freemarker wouldn't know how to cache the templates as well as struts2 does since we know how the templates

Re: Spring Web Flow Plugin in Maven Repo?

2007-03-14 Thread Tom Schneider
No, you're not missing anything. I never got around to creating an upload request. Feel free to submit it. :-) I should have some time this weekend to roll another release (with SWF 1.0.1) and upload it to maven. Tom mraible wrote: The Spring Web Flow plugin looks like it's in the form of

Re: Enhancement to Zero Config: Default Success Result

2007-02-28 Thread Tom Schneider
See http://struts.apache.org/2.x/docs/codebehind-plugin.html The very first line from the docs are: * Default results* - The purpose of most Actions is to execute code to prepare the data for a specific page. The name of this page is often the same as the Action itself. Is this not what your

Re: [s2] Enhancement to Zero Config: Default Success Result

2007-02-28 Thread Tom Schneider
Guys, I think the codebehind plugin already supports all this. (The codebehind plugin consists of 1 whole java file!!) The property for default location of jsp's is: struts.codebehind.pathPrefix The docs just need to be updated. Looking at the code, it looks like it also supports all

Re: Guice 1.0rc2

2007-02-26 Thread Tom Schneider
There is no pico/nanocontainer support in struts2 at the moment. (I don't think it made it over in the merger) IMO this is best implemented as an external plugin anyhow. All external plugins thus far have used googlecode to host their projects. If you do create this plugin, please register

Re: Guice 1.0rc2

2007-02-26 Thread Tom Schneider
The architecture between webwork and struts2 has changed. Every other project that provides the same functionality, (e.g. Plexus, Spring, etc.) was written as a plugin in Struts2. Technically it is possible to use the object factories, interceptors, etc. without using the plugin architecture

Re: [s2] Struts 2.0.7 Status

2007-02-25 Thread Tom Schneider
Core Plugins This is more of a 2.1.x status item, but looking forward, do we want to bundle so many plugins with the core, or do we want to try and cut some of these loose somehow? Of course, there is also something to be said for letting sleeping dogs lie. I think we should cut some of them

Re: [s2] Development Infrastructure (Re: [s2] Struts 2.0.7 Status)

2007-02-25 Thread Tom Schneider
There's a few parts of GoogleCode that are still quirky. I'm disappointed that the Subversion alerts do not include the DIFFs. We've had to resort to posting our own daily DIFFs. The immutable issue descriptions is also awkward. But, the other sites also have their own quirks too. It does seem

Nightly build script needs updating

2007-02-25 Thread Tom Schneider
The nightly scripts seem to be out of date for struts2. The 2.0.x build is currently building trunk and there is no nightly build for 2.0.x: http://svn.apache.org/repos/asf/struts/maven/trunk/scripts/nightly/nightly-2.0.x.sh I'd be happy to update the scripts if someone could enlighten me on

Re: Struts 1.4 2.1 sharing localization code

2007-02-22 Thread Tom Schneider
Actually I think the xwork2 i18n code is pretty good. I would probably look at that code as the basis--or at least make sure that we don't loose any functionality. Although there's some areas that need work--(hint validators), I thought webwork had pretty good i18n support. Far more

I need struts2 documation wiki karma

2007-02-18 Thread Tom Schneider
Hi, my name is Earl...I need karma. I have some updates to the struts2 documentation--can someone grant me some karma to do so? Thanks, Tom - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL

Re: [ANN] New Struts Committers: Musachy Barroso, Philip Luppens, Tom Schneider, Henri Yandell

2007-02-18 Thread Tom Schneider
I went to an engineering school, we didn't have a school song. :-) Musachy Barroso wrote: bring it on Tom :) musachy On 2/18/07, Paul Benedict [EMAIL PROTECTED] wrote: All new committers must sing their alma mater. Who wants to be first?

Re: Users guide

2007-02-12 Thread Tom Schneider
Just to add my 2 cents... I agree with Ted that the wiki is a bad place to do long cohesive documents. Would a PDF format be a better choice? With webwork, what most users had was Jason's/Pat's 'Webwork in Action' in combination with the online documentation. This was a really good

Re: [s2] Pluggable URL building proposal

2007-02-11 Thread Tom Schneider
appreciate any feedback. Once we've worked out all the kinks, we can look at integrating into the full struts2 codebase. Tom Tom Schneider wrote: I am very ashamed to report that I didn't get very far. (too much snow to shovel last weekend) I was able to analyze what each type of url would need

Re: [VOTE] Struts 2.0.5 Quality

2007-02-10 Thread Tom Schneider
Umm, it looks like the spring plugin jar isn't included. Someone on #struts mentioned this and I confirmed it by downloading struts-2.0.5-all.zip from the website and it's not in the lib directory. (All the other plugins are there) Am I crazy or is it really missing? Tom Ted Husted wrote:

Re: {VOTE] Struts Annotations 1.0.1 Quality

2007-02-09 Thread Tom Schneider
Ted Husted wrote: [ ] Leave at test build [ ] Alpha [ ] Beta [ X ] General Availability (GA) - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Branch 2.0.x and label head 2.1.0(was Re: Struts Release Process (again))

2007-02-07 Thread Tom Schneider
I would argue also that a lot of fixes going into struts 2.0.x haven't made it back into webwork. Several issues I resolved in Webwork this weekend were already fixed in Struts 2.0.x. Tom On 2/7/07, Don Brown [EMAIL PROTECTED] wrote: I'm fine with branching now, but it means that we need to

Re: Branch 2.0.x and label head 2.1.0(was Re: Struts Release Process (again))

2007-02-07 Thread Tom Schneider
On 2/7/07, Ted Husted [EMAIL PROTECTED] wrote: Phillip filed a number of tickets regarding WebWork fixes, so what we haven't applied may just be pending. I know there are a couple of WW patches slated for 2.0.6 (thanks Tom!). And as soon as my apache account is created, I'll be committing

Re: [s2] Pluggable URL building proposal

2007-02-05 Thread Tom Schneider
process. See how the TagLibrary or TemplateEngine classes are discovered for examples. Don Tom Schneider wrote: Ok, I had a little time tonight to put together a preliminary design for the URLBuilder. Here's what I have so far for the interface: URLBuilder +buildURL(CustomAttributes

Re: [s2] Pluggable URL building proposal

2007-02-01 Thread Tom Schneider
Ok, I had a little time tonight to put together a preliminary design for the URLBuilder. Here's what I have so far for the interface: URLBuilder +buildURL(CustomAttributes, ActionMapping) // this method is for when an action, namespace, method, etc. is supplied +buildURL(CustomAttributes,

Re: [s2] Pluggable URL building proposal

2007-01-31 Thread Tom Schneider
Hey Patrick, Haven't had time to look at this any further. Yes, I definitely would build on top of the ActionMapper stuff--that's already abstracted out so nicely I didn't even mention it. :) I might have some time this weekend to dig into this further. (I was too busy releasing the first

Re: [VOTE] Struts 2.0.4 Quality

2007-01-30 Thread Tom Schneider
I agree with Phil--we need an updated version of OGNL. Last week I was able to reproduce the OGNL race condition under JBoss on windows with JDK 1.5. If it was strictly limited to Websphere 5.1 under Linux/Windows, I wouldn't be pushing so hard. However, it looks like it's more widespread

Re: Fast ValueStack

2007-01-27 Thread Tom Schneider
on larger forms. Tom Schneider wrote: Well, I guess I was feeling more ambitious than I thought. I wrote a simple junit test (below) that tests the 2 techniques for retrieving I18N text. My numbers for 100 iterations were: Using OGNL expression: 476 ms Explicitly calling getText: 0 ms Yikes

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
('')}) - this results in a 1100-1200ms/request gain (an average of about 100ms per method invocation) and drops my total request time to well under a second. That's why I'm thinking about looking at method processing. What did you find to be your culprit? Anything ww/struts related? David Tom Schneider

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
David H. DeWolf wrote: Tom Schneider wrote: David, See https://issues.apache.org/struts/browse/WW-1661 and http://wiki.opensymphony.com/display/WW/Performance+Tuning (particularly the freemarker entries) By just adding the freemarker.properties and copying all the templates to the webapp

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
From UIBean.java: if (this.key != null) { if(this.name == null) { this.name = key; } if(this.label == null) { this.label = %{getText('+ key +')}; } } Looks like it's doing exactly the same thing. :( Even

Re: Fast ValueStack

2007-01-26 Thread Tom Schneider
Well, I guess I was feeling more ambitious than I thought. I wrote a simple junit test (below) that tests the 2 techniques for retrieving I18N text. My numbers for 100 iterations were: Using OGNL expression: 476 ms Explicitly calling getText: 0 ms Yikes!!! There is quite a difference between

Re: [s2] Pluggable URL building proposal

2007-01-23 Thread Tom Schneider
know what you find. Don Tom Schneider wrote: Based on the portlet plugin proposal and some work I've been doing with the table tags, I thought I would propose a refactor of the URL building for struts2. Right now, struts2 has great support for taking on incoming request and mapping

Re: Feature to manage conversational state

2007-01-22 Thread Tom Schneider
Actually http://cwiki.apache.org/S2PLUGINS/spring-webflow-plugin.html is the latest and greatest with regard to SWF integration. Also, if you're looking for session type managment, checkout the scope plugin: http://cwiki.apache.org/S2PLUGINS/scope-plugin.html. (This is in the sandbox, I haven't

[s2] Pluggable URL building proposal

2007-01-21 Thread Tom Schneider
Based on the portlet plugin proposal and some work I've been doing with the table tags, I thought I would propose a refactor of the URL building for struts2. Right now, struts2 has great support for taking on incoming request and mapping it to the core elements of the framework (i.e.

Re: [S2] Freemarker Confusion

2007-01-20 Thread Tom Schneider
Joe, ${error} being null would imply that you have an item in the action errors Collection that is null. (e.g. {Error1, Error2, null, Error4}) It seems like that would be an issue that occurs as the errors are being populated. (I can't think of a valid use case where you would have a null

Re: [S2] Freemarker Confusion

2007-01-20 Thread Tom Schneider
in Freemarker 2.3.7 http://freemarker.sourceforge.net/docs/versions_2_3_7.html Now... is an empty string the right result? maybe ${error?default(!-- null error --)} ? is that overkill? Joe On 1/20/07, Tom Schneider [EMAIL PROTECTED] wrote: Joe, ${error} being null would imply that you have an item

Re: Struts 2.0 Performance

2007-01-19 Thread Tom Schneider
Obviously you picked up on my probing questions on the chat. :) Yes--we use JSP's with FTL templates for the tags. It only recently occurred to me that the caching would need to be different for the FTL tag templates vs. FTL results. I like this proposal--it would keep the user from having

Re: Struts 2.0 Performance

2007-01-19 Thread Tom Schneider
the templates for every request! (assuming it works the same as the UI tags) Tom Philip Luppens wrote: On 1/19/07, Tom Schneider [EMAIL PROTECTED] wrote: Obviously you picked up on my probing questions on the chat. :) Yes--we use JSP's with FTL templates for the tags. It only recently occurred

Re: Struts 2.0 Performance

2007-01-18 Thread Tom Schneider
One of the possibilities I was discussing with Phil yesterday was to implement freemarker caching on the WW side of things--just like we do with OGNL. In WW if we're not in devMode, then I think its safe to say that we can read the template once and never reread it. This would eliminate the

Re: Struts 2.0.3 status

2007-01-17 Thread Tom Schneider
Someone wasn't paying attention. :) If we need to do bug fixes on 2.0.3, we'll branch off the tag--otherwise we won't create the branch. Trunk became 2.1.x after the 2.0.3 tag. Tom Don Brown wrote: I didn't see a branch for 2.0.x Are we going to create it right before we commit big 2.1.x

Re: Struts 2.0 Performance

2007-01-17 Thread Tom Schneider
The performance of OGNL is not nearly as bad as we had originally thought. I've been doing some performance testing in Webwork (which S2 is based on) this week and most of the OGNL calls are not measurable. (1ms) The biggest issue I've had is making sure freemarker templates are getting

Re: JSTL functions in *struts* JSP tags

2007-01-14 Thread Tom Schneider
+1 for having a seperate key attribute that automatically does a getText() lookup for the label. This was one thing that is annoying in WW since we tried to I18Nize our whole app. The url thing didn't bother me as much, but I'm all for a shorthand notation if it makes sense. (Url/Button

Re: [S2] Experimental Features

2007-01-14 Thread Tom Schneider
Ted Husted wrote: It would be great if there were a portlet plugin. I have no idea how the support is implemented, but I expect it would not be that easy. :) Well, the PortletDispatcher (Jsr168Dispatcher.java) and related portlet request support classes would probably be easy to separate out.

  1   2   >