Re: Review Board Ticket #4987: Asana integration always reports "Authentication failed"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4987/ -- New update by dan For Beanbag, Inc. > Review Board > Ticket #4987 Reply: Correction sorry, the API token is 51 characters long - not 50. -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20221214151826.20172.85174%40ip-10-1-54-209.ec2.internal.
Review Board Ticket #4987: Asana integration always reports "Authentication failed"
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4987/ -- New ticket #4987 by dan For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Defect -- Asana integration always reports "Authentication failed" == # What version are you running? 5.0.1 # What's the URL of the page containing the problem? /admin/integrations/rbintegrations.asana.integration.AsanaIntegration/configs/add # What steps will reproduce the problem? 1. Navigate to the above URL 2. Paste a newly generated Asana Personal Access Token into the relevant input 3. Switch focus from the input # What is the expected output? What do you see instead? The expected output is that the "Asana Workspace" dropdown will be populated. Instead, I see the "Authentication failed" error message. # What operating system are you using? What browser? Arch Linux, Firefox. # Please provide any additional information below. The input field for the access token is limited to 34 characters. The API token generated in Asana is 50 characters long. I believe this truncation is the cause of the issue. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard-issues/20221214151553.20177.7387%40ip-10-1-54-209.ec2.internal.
Re: CRITICAL: This ValidateDiffCommitResource does not have an attribute "validation_info".
5531dc880a..aedede227a33ade45d447f06f8984a3818141c
>>> Running: git -c core.quotepath=false -c diff.noprefix=false diff
--no-color --full-index --ignore-submodules --find-renames --no-ext-diff
aedede227a33ade45d447f06f8984a3818141c44..ca5d63d501fc8a37f6cdb139022379985c9249
>>> Making HTTP GET request to
http://review.[redacted].com/api/validation/commits/
>>> HTTP GET request to
http://review.[redacted].com/api/validation/commits/ cannot be cached
Validating commits...
[0/2]>>> Making HTTP POST request to
http://review.[redacted].com/api/validation/commits/
Validating commits...
[0/2]
Traceback (most recent call last):
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/api/resource.py",
line 856, in __getattr__
field_payload = self._fields[name]
KeyError: 'validation_info'
During handling of the above exception, another exception occurred:
Traceback (most recent call last):
File "/home/dmn/.local/bin/rbt", line 8, in
sys.exit(main())
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/commands/main.py",
line 207, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/commands/__init__.py",
line 1119, in run_from_argv
exit_code = self.main(*args) or 0
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/commands/post.py",
line 959, in main
diff_history = self._validate_diff_history(diff_history)
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/commands/post.py",
line 1596, in _validate_diff_history
validation_info = validation_rsp.validation_info
File
"/home/dmn/.local/lib/python3.10/site-packages/rbtools/api/resource.py",
line 858, in __getattr__
raise AttributeError('This %s does not have an attribute "%s".'
AttributeError: This ValidateDiffCommitResource does not have an attribute
"validation_info".
Any support you can provide would be great, just let me know if you need
any more information.
Thanks,
Dan
On Monday, 28 November 2022 at 01:03:23 UTC Christian Hammond wrote:
> Hi Szymon,
>
> I'm sure it's nothing you did wrong. We may have a bug in RBTools.
>
> Can you run the same command but with the --debug argument, and paste the
> full results? That can help me to figure out what it's trying to do and
> where it's going wrong.
>
> Thanks,
>
> Christian
>
> On Sat, Nov 26, 2022 at 2:56 PM Szymon Niemiec
> wrote:
>
>> Hello everyone,
>>
>> Today I wanted to setup ReviewBoard version 5.0.1 for some of my Git
>> repositories.
>> Web application is working fine.
>> I've added first repository from the admin area and pointed Path: setting
>> to local directory, where the repo resides. (I was using this guide
>> https://www.reviewboard.org/docs/manual/dev/admin/configuration/repositories/git/#using-a-local-clone)
>>
>>
>>
>> It seem to be configured fine.
>> However, when I made example change and try to use `rbt post`, it fails:
>>
>> ```
>> root@reviewboard:/home/www-data/repos/myrepo# rbt post
>> Validating commits...
>> [0/1]
>> CRITICAL: This ValidateDiffCommitResource does not have an attribute
>> "validation_info".
>> ```
>>
>> I don't understand the error message. What is validation_info? What did I
>> misconfigure?
>>
>> Thank you for any help!
>> Best regards,
>> Szymon
>>
>> --
>> Supercharge your Review Board with Power Pack:
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons:
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> ---
>> You received this message because you are subscribed to the Google Groups
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an
>> email to reviewboard...@googlegroups.com.
>> To view this discussion on the web visit
>> https://groups.google.com/d/msgid/reviewboard/cf94a93f-34e8-4ff4-b9bd-6ec6b1b0e210n%40googlegroups.com
>>
>> <https://groups.google.com/d/msgid/reviewboard/cf94a93f-34e8-4ff4-b9bd-6ec6b1b0e210n%40googlegroups.com?utm_medium=email_source=footer>
>> .
>>
>
>
> --
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
--
Supercharge your Review Board with Power Pack:
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons:
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit
https://groups.google.com/d/msgid/reviewboard/73799b61-8dc9-4688-bf03-abc3d82f3520n%40googlegroups.com.
Re: Unexpected error loading command post: name 'platform_system' is not defined
#> /usr/bin/rbt post --debug Unexpected error loading command post: name 'platform_system' is not defined On Thursday, January 20, 2022 at 9:14:07 AM UTC+2 David Trowbridge wrote: > Can you run with --debug and send the output? > > David > > On Wed, Jan 19, 2022 at 7:34 PM Dan Beygelman wrote: > >> Hi, >> i get this error when i run rbt post command >> #> /usr/bin/rbt post >> Unexpected error loading command post: name 'platform_system' is not >> defined >> >> #> /usr/bin/rbt --versio >> RBTools 2.0.1 (Python 2.7.5) >> >> pip --version >> pip 10.0.1 from /usr/lib/python2.7/site-packages/pip (python 2.7) >> >> Please help >> >> -Dan >> >> -- >> Supercharge your Review Board with Power Pack: >> https://www.reviewboard.org/powerpack/ >> Want us to host Review Board for you? Check out RBCommons: >> https://rbcommons.com/ >> Happy user? Let us know! https://www.reviewboard.org/users/ >> --- >> You received this message because you are subscribed to the Google Groups >> "Review Board Community" group. >> To unsubscribe from this group and stop receiving emails from it, send an >> email to reviewboard...@googlegroups.com. >> To view this discussion on the web visit >> https://groups.google.com/d/msgid/reviewboard/148887a2-9afd-48c5-bb7b-695fb37f515bn%40googlegroups.com >> >> <https://groups.google.com/d/msgid/reviewboard/148887a2-9afd-48c5-bb7b-695fb37f515bn%40googlegroups.com?utm_medium=email_source=footer> >> . >> > -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/dec5ff3d-1ec5-44f9-bf3d-d4e7699987f6n%40googlegroups.com.
Unexpected error loading command post: name 'platform_system' is not defined
Hi, i get this error when i run rbt post command #> /usr/bin/rbt post Unexpected error loading command post: name 'platform_system' is not defined #> /usr/bin/rbt --versio RBTools 2.0.1 (Python 2.7.5) pip --version pip 10.0.1 from /usr/lib/python2.7/site-packages/pip (python 2.7) Please help -Dan -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups "Review Board Community" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. To view this discussion on the web visit https://groups.google.com/d/msgid/reviewboard/148887a2-9afd-48c5-bb7b-695fb37f515bn%40googlegroups.com.
Review Board Ticket #4495: Add diff view that only shows the new version.
-- To reply, visit https://hellosplat.com/s/beanbag/tickets/4495/ -- New ticket #4495 by dbw For Beanbag, Inc. > Review Board Status: New Tags: Priority:Medium, Type:Enhancement -- Add diff view that only shows the new version. == # What version are you running? 2.5.6.1 # What's the URL of the page this enhancement relates to, if any? <>/r//diff/1 # Describe the enhancement and the motivation for it. Sometimes a user posts a review that is a large refactor, with code blocks moving around quite a bit. In these cases, it is hard to understand the new code by looking at the diff. I'd rather just see the new code (without reference to the old code). This sounds like I should just download and apply the diff, however there are two killer features of RB that I would like to have available. I'd like to see only the modified lines, and I'd like to be able to comment on the code. # What operating system are you using? What browser? Linux, MacOS. Chrome. # Please provide any additional information below. -- -- You received this message because you are subscribed to the Google Groups "reviewboard-issues" group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard-issues+unsubscr...@googlegroups.com. To post to this group, send email to reviewboard-issues@googlegroups.com. Visit this group at https://groups.google.com/group/reviewboard-issues. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
subvertpy. felt like the instructions favored that one. On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge wrote: Are you using the pysvn or subvertpy backend? -David On Tue, Nov 25, 2014 at 9:19 AM, Dan Holmes dnh...@gmail.com javascript: wrote: I switched to Ubuntu but am still having SVN connection problems. I went back over the installation for SVN python tools and it said it was all installed. What am i missing? from the apache error.log [Tue Nov 25 17:14:27.246518 2014] [:error] [pid 8713] ERROR:root:SVN: Failed to get repository information for https://10.7.0.1:8443/svn/RouteMatch/: (Unable to connect to a repository at URL 'https://10.7.0.1:8443/svn/RouteMatch', 230001) however both svn and curl will return without problem. notroot@RMDevTools01:~$ svn info https://10.7.0.1:8443/svn/RouteMatch/ Path: RouteMatch URL: https://10.7.0.1:8443/svn/RouteMatch Relative URL: ^/ Repository Root: https://10.7.0.1:8443/svn/RouteMatch Repository UUID: 34830635-b4d3-f84e-9563-fed92939f730 Revision: 61143 Node Kind: directory Last Changed Author: Last Changed Rev: 61143 Last Changed Date: 2014-11-25 12:11:56 -0500 (Tue, 25 Nov 2014) notroot@RMDevTools01:~$ curl https://10.7.0.1:8443/svn/RouteMatch/ --insecure -u xx ?xml version=1.0? ?xml-stylesheet type=text/xsl href=/svnindex.xsl? !DOCTYPE svn [ !ELEMENT svn (index) !ATTLIST svn version CDATA #REQUIRED hrefCDATA #REQUIRED !ELEMENT index (updir?, (file | dir)*) !ATTLIST index nameCDATA #IMPLIED pathCDATA #IMPLIED rev CDATA #IMPLIED baseCDATA #IMPLIED !ELEMENT updir EMPTY !ATTLIST updir hrefCDATA #REQUIRED !ELEMENT file EMPTY !ATTLIST file nameCDATA #REQUIRED hrefCDATA #REQUIRED !ELEMENT dir EMPTY !ATTLIST dir nameCDATA #REQUIRED hrefCDATA #REQUIRED ] svn version=1.7.5 (r1336830) href=http://subversion.apache.org/; index rev=61143 path=/ base=RouteMatch ... /index /svn -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
do i have to uninstall subvertpy? how does RB know to use one or the other? is there a config switch? On Wednesday, November 26, 2014 8:34:38 AM UTC-5, Stephen Gallagher wrote: On Wed, 2014-11-26 at 05:31 -0800, Dan Holmes wrote: subvertpy. felt like the instructions favored that one. On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge wrote: Are you using the pysvn or subvertpy backend? In my experience (on Fedora), I've found that the pysvn option is the better one. As I understand it, subvertpy is mainly there because it can be installed with easy_install, but it's not nearly as mature as pysvn. Since your operating system includes a pysvn package, it would probably be best to install that using apt and try again. If that works, then there's a bug in the subvertpy support somewhere that can be looked into, but you'll be up and running in the meantime. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: SVN connection failure
so i tried it and I've found that the pysvn option is the better one appears to be true (this is Ubunutu). now i get the same error i had on the windows server. I don't get prompted to accept. how do i get this resolved? I already saved the cert with curl and svn cmds but those apparently didn't store them in the right place. Unable to connect to a repository at URL 'https://rmfile02.routematch.local:8443/svn/RouteMatch' Server SSL certificate verification failed: issuer is not trusted On Wednesday, November 26, 2014 8:43:33 AM UTC-5, Dan Holmes wrote: do i have to uninstall subvertpy? how does RB know to use one or the other? is there a config switch? On Wednesday, November 26, 2014 8:34:38 AM UTC-5, Stephen Gallagher wrote: On Wed, 2014-11-26 at 05:31 -0800, Dan Holmes wrote: subvertpy. felt like the instructions favored that one. On Tuesday, November 25, 2014 6:21:26 PM UTC-5, David Trowbridge wrote: Are you using the pysvn or subvertpy backend? In my experience (on Fedora), I've found that the pysvn option is the better one. As I understand it, subvertpy is mainly there because it can be installed with easy_install, but it's not nearly as mature as pysvn. Since your operating system includes a pysvn package, it would probably be best to install that using apt and try again. If that works, then there's a bug in the subvertpy support somewhere that can be looked into, but you'll be up and running in the meantime. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
easy_install errors - i don't know if these are bad but i thought i would share
On Ubuntu 14.04.01 server, following the instructions i get the following
error(s) when i run the easy_install ReviewBoard command. I haven't yet
tried to run it yet so i don't know if this is fatal but i thought i would
throw this out here before i lost the error messages.
Installing pilprint.py script to /usr/local/bin
Installed
/usr/local/lib/python2.7/dist-packages/Pillow-2.6.1-py2.7-linux-x86_64.egg
Searching for futures=2.1.3
Reading https://pypi.python.org/simple/futures/
Exception in thread Thread-1:
Traceback (most recent call last):
File /usr/lib/python2.7/threading.py, line 810, in __bootstrap_inner
self.run()
File /usr/lib/python2.7/threading.py, line 763, in run
self.__target(*self.__args, **self.__kwargs)
File /usr/lib/python2.7/multiprocessing/pool.py, line 330, in
_handle_workers
debug('worker handler exiting')
TypeError: 'NoneType' object is not callable
Exception in thread Thread-2:
Traceback (most recent call last):
File /usr/lib/python2.7/threading.py, line 810, in __bootstrap_inner
self.run()
File /usr/lib/python2.7/threading.py, line 763, in run
self.__target(*self.__args, **self.__kwargs)
File /usr/lib/python2.7/multiprocessing/pool.py, line 357, in
_handle_tasks
debug('task handler got sentinel')
TypeError: 'NoneType' object is not callable
Best match: futures 2.2.0
Downloading
https://pypi.python.org/packages/source/f/futures/futures-2.2.0.tar.gz#md5=310e446de8609ddb59d0886e35edb534
Processing futures-2.2.0.tar.gz
Writing /tmp/easy_install-pWNWPg/futures-2.2.0/setup.cfg
Running futures-2.2.0/setup.py -q bdist_egg --dist-dir
/tmp/easy_install-pWNWPg/futures-2.2.0/egg-dist-tmp-S1hA5L
Adding futures 2.2.0 to easy-install.pth file
Installed /usr/local/lib/python2.7/dist-packages/futures-2.2.0-py2.7.egg
Finished processing dependencies for ReviewBoard
Exception TypeError: TypeError('NoneType' object does not support item
deletion,) in Finalize object, dead ignored
notroot@RMDevTools01:~$
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
SVN connection failure
I switched to Ubuntu but am still having SVN connection problems. I went back over the installation for SVN python tools and it said it was all installed. What am i missing? from the apache error.log [Tue Nov 25 17:14:27.246518 2014] [:error] [pid 8713] ERROR:root:SVN: Failed to get repository information for https://10.7.0.1:8443/svn/RouteMatch/: (Unable to connect to a repository at URL 'https://10.7.0.1:8443/svn/RouteMatch', 230001) however both svn and curl will return without problem. notroot@RMDevTools01:~$ svn info https://10.7.0.1:8443/svn/RouteMatch/ Path: RouteMatch URL: https://10.7.0.1:8443/svn/RouteMatch Relative URL: ^/ Repository Root: https://10.7.0.1:8443/svn/RouteMatch Repository UUID: 34830635-b4d3-f84e-9563-fed92939f730 Revision: 61143 Node Kind: directory Last Changed Author: Last Changed Rev: 61143 Last Changed Date: 2014-11-25 12:11:56 -0500 (Tue, 25 Nov 2014) notroot@RMDevTools01:~$ curl https://10.7.0.1:8443/svn/RouteMatch/ --insecure -u xx ?xml version=1.0? ?xml-stylesheet type=text/xsl href=/svnindex.xsl? !DOCTYPE svn [ !ELEMENT svn (index) !ATTLIST svn version CDATA #REQUIRED hrefCDATA #REQUIRED !ELEMENT index (updir?, (file | dir)*) !ATTLIST index nameCDATA #IMPLIED pathCDATA #IMPLIED rev CDATA #IMPLIED baseCDATA #IMPLIED !ELEMENT updir EMPTY !ATTLIST updir hrefCDATA #REQUIRED !ELEMENT file EMPTY !ATTLIST file nameCDATA #REQUIRED hrefCDATA #REQUIRED !ELEMENT dir EMPTY !ATTLIST dir nameCDATA #REQUIRED hrefCDATA #REQUIRED ] svn version=1.7.5 (r1336830) href=http://subversion.apache.org/; index rev=61143 path=/ base=RouteMatch ... /index /svn -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Windows based SVN failes the Reviewboard repository config for certificate trust issues
This is ReviewBoard 2.0.11 on Widows 2008 as installed by bitnami. I get the following: Server certificate verification failed: issuer is not trusted I am not prompted to accept the cert. I have tried the cmd line tools to cache the certificate locally first but that hasn't worked. I have read what i can find on this and it seems to have been fixed. I don't know what to try next. Anyone know what i can try next? thanks dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
diff viewer tab size
We use a coding style where we use tabs, and tab size is 4 spaces. How do I get RB to use that scheme on tabs (it shows 8 spaces for tabs now). I'm using RB 1.7.1.6 Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
posting reviews that span multiple repos
Hi there, Is there a way to post a single review request that spans multiple repos (using git)? I.e. one review request that contains relevant changes for 2+ repos instead of one separate review board request for each respective repo. Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: posting reviews that span multiple repos
Ah ok. We'll use the Depends On link. Thanks Christian! Dan On Thursday, June 26, 2014 11:50:43 AM UTC-7, Christian Hammond wrote: Hi Dan, Sorry, there’s no way to do this. A lot would need to change to allow it to happen. What I’d recommend is just having two (or more) review requests, and using Depends On to relate them. Christian -- Christian Hammond - chri...@beanbaginc.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On June 26, 2014 at 11:49:11 AM, Dan Tehranian (tehr...@gmail.com javascript:) wrote: Hi there, Is there a way to post a single review request that spans multiple repos (using git)? I.e. one review request that contains relevant changes for 2+ repos instead of one separate review board request for each respective repo. Thanks, Dan -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard...@googlegroups.com javascript:. For more options, visit https://groups.google.com/d/optout. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/d/optout.
Re: ReviewBoard 2.0.1 and Subversion - API Error 207
In addition to this, I added some extra debugging to the get_file() method.
Printing the SubversionException that's returned from self.client.cat shows:
Unable to connect to a repository at URL
'http://dev1:9880/company_name/Product/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs'
Hope this helps.
On Wednesday, 4 June 2014 14:30:14 UTC+1, Dan Jackson wrote:
Christian,
Thanks for your help. I'm running Subvertpy on Lighttpd.
Adding that line to subvert.py and then restarting the server results in
the following in the ReviewBoard.log:
2014-06-04 13:24:40,067 - INFO - - repopath =
http://dev1:9880/company_name;, path =
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs,
revision= 7134
Taking those fields, and then running the following on the server:
svn cat
http://dev1:9880/company_name/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs@7134
...cats out the expected contents of the file.
I'd appreciate any other suggestions you might have.
On Tuesday, 3 June 2014 19:58:08 UTC+1, Christian Hammond wrote:
Hi Dan,
Are you using PySVN on the server, or Subvertpy?
Internally, we're running the equivalent of:
$ svn cat base_repo_pathpath_from_diff@7134
It should be possible to run that and get the output.
99 times out of 100, when this happens, it's due to the resulting path
being invalid. You can sanity-check the path by editing
reviewboard/scmtools/svn/pysvn.py (if using PySVN, subvert.py otherwise),
finding the 'get_file' function, and adding this as the first statement:
logging.info('repopath = %s, path = %s, revision = %s' %
(self.repopath, path, revision))
Restart Apache, try again, and see if that looks like what you expect.
Christian
--
Christian Hammond - chi...@chipx86.com
Review Board - http://www.reviewboard.org
Beanbag, Inc. - http://www.beanbaginc.com
On Tue, Jun 3, 2014 at 3:33 AM, Dan Jackson danjac...@googlemail.com
wrote:
I'm trying to setup ReviewBoard 2.0.1 for the first time. Mostly it
seems okay - I can get into the administration screen and add
users/repos/etc - but I'm failing at the last hurdle. I can't get it to
integrate properly with our Subversion server.
In the Change Repository screen, I've picked Custom Repository,
Subversion, and my path is set to the root of the repository. (
http://dev1:9980/company_name;) I have a valid username and password
entered (because the SVN server doesn't allow anonymous access.)
RBT setup-repo sees the ReviewBoard repository, and asks if I want to
use it (I do). It then generates the following .reviewboardrc:
REVIEWBOARD_URL = http://review.board.com;
REPOSITORY = CompanyName
RBT can generate a valid diff (content removed but...)
Index:
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
===
---
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
(revision
7134)
+++
/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
(working
copy)
@@ -40,7 +40,7 @@
However, when I run rbt post --debug I get:
RBTools 0.6
Python 2.7.5 (default, Mar 9 2014, 22:15:05)
[GCC 4.2.1 Compatible Apple LLVM 5.0 (clang-500.0.68)]
Running on Darwin-13.2.0-x86_64-i386-64bit
Home = /Users/dan
Current directory = /Volumes/Data/Work/PRODUCT/Trunk
Checking for a Subversion repository...
Running: svn info --non-interactive
Running: diff --version
repository info: Path: http://dev1:9880/company_name, Base path:
/PRODUCT/Code/Trunk, Supports changesets: False
Making HTTP GET request to http://review.board.com/api/
Running: svn info --non-interactive
Running: diff --version
repository info: Path: http://dev1:9880/company_name, Base path:
/PRODUCT/Code/Trunk, Supports changesets: False
Running: svn status --ignore-externals
Running: svn diff --diff-cmd=diff --notice-ancestry -r BASE
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info Server/PRODUCTServer/MacServer
Running: svn info Server/PRODUCTServer
Running: svn info Server
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Running: svn info
Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Making HTTP GET request to
http://review.board.com/api/review-requests/
Making HTTP POST request to
http://review.board.com/api/review-requests/
Making HTTP GET request to
http://review.board.com/api/review-requests/23/diffs/
Making HTTP POST request to
http://review.board.com/api/review-requests/23/diffs/
Got API Error 207 (HTTP code 400): The file was not found in the
repository.
Error data: {u'stat': u'fail', u'file':
u'/PRODUCT/Code/Trunk/Server/PRODUCTServer/MacServer/NativeMacUsbInterface.cs
Re: Can't authenticate Review Board w/Atlassian Stash via SSH
Hi Christian, I've confirmed that Review Board is not respecting the port number in my Git URL string and using the default port 22 instead. In real-time I can see the relevant log output for sshd running on port 22 when I try to add a repo to Review Board with the URL: g...@vi-stash.lab.vi.local:7999/do/tools.git. From /var/log/auth.log on my Stash server: root@vi-git-stash1:/var/log# tail -f auth.log ... Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Invalid user git from 10.10.77.65 Apr 29 13:52:10 vi-git-stash1 sshd[4200]: input_userauth_request: invalid user git [preauth] Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Failed none for invalid user git from 10.10.77.65 port 34312 ssh2 Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Connection closed by 10.10.77.65 [preauth] ... Meanwhile the logs for the Stash app that I'm also tailing don't show any connection attempt being to port 7999. Shall I file a bug? Thanks, Dan On Tuesday, April 29, 2014 12:25:26 PM UTC-7, Christian Hammond wrote: Hi Dan, We don't use OpenSSH for talking to the repository. We use our rbssh instead. This shouldn't end up using the SSH key in ~/.ssh, but rather should be using the SSH key configured in Review Board instead, which will live in $sitedir/data/.ssh instead of /var/www/.ssh. Is the SSH key shown in Review Board matching exactly the key configured on the repository's side? It is possible that there's an issue with the port. I'd have to see your repository configuration and play around with stuff to know more. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Apr 29, 2014 at 11:23 AM, Dan Tehranian tehr...@gmail.comjavascript: wrote: We're moving our git server to Atlassian Stash and I'm unable to hook our existing Review Board instance up with the repos we've moved to Stash. The error from the Admin UI is: Unable to authenticate against this repository using one of the supported authentication types. From /var/log/reviewboard/reviewboard.log: 2014-04-29 18:04:49,684 - DEBUG - - GitTool: Attempting ssh connection with host: vi-stash.lab.vi.local, username: git 2014-04-29 18:04:49,688 - DEBUG - - starting thread (client mode): 0xb7fe712cL 2014-04-29 18:04:49,697 - INFO - - Connected (version 2.0, client OpenSSH_5.9p1) 2014-04-29 18:04:49,698 - DEBUG - - kex algos:['ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521', 'diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijnda...@lysator.liu.sejavascript:'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijnda...@lysator.liu.sejavascript:'] client mac:['hmac-md5', 'hmac-sha1', 'uma...@openssh.com javascript:', 'hmac-sha2-256', 'hmac-sha2-256-96', 'hmac-sha2-512', 'hmac-sha2-512-96', 'hmac-ripemd160', 'hmac-ri...@openssh.com javascript:', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', ' uma...@openssh.com javascript:', 'hmac-sha2-256', 'hmac-sha2-256-96', 'hmac-sha2-512', 'hmac-sha2-512-96', 'hmac-ripemd160', ' hmac-ri...@openssh.com javascript:', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'zl...@openssh.com javascript:'] server compress:['none', 'zl...@openssh.com javascript:'] client lang:[''] server lang:[''] kex follows?False 2014-04-29 18:04:49,698 - DEBUG - - Ciphers agreed: local=aes128-ctr, remote=aes128-ctr 2014-04-29 18:04:49,698 - DEBUG - - using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 2014-04-29 18:04:49,742 - DEBUG - - Switch to new keys ... 2014-04-29 18:04:49,773 - DEBUG - - Trying SSH key *baac4e3fe8a0e255a59160d00707093b* 2014-04-29 18:04:49,778 - DEBUG - - userauth is OK 2014-04-29 18:04:49,812 - INFO - - Authentication (publickey) failed. 2014-04-29 18:04:49,823 - DEBUG - - Trying discovered key *baac4e3fe8a0e255a59160d00707093b* in /var/www/vi-reviewboard/data/.ssh/id_rsa 2014-04-29 18:04:49,824 - DEBUG - - userauth is OK 2014-04-29 18:04:49,845 - INFO - - Authentication (publickey) failed. 2014-04-29 18:04:49,847 - DEBUG - - userauth is OK 2014-04-29 18:04:49,847 - INFO - - Authentication (password) failed. 2014-04-29 18:04:49,948 - DEBUG - - EOF in transport thread But I'm otherwise able to clone repos as the www-data user from the CLI. Ex: www-data@vi-reviewboard:~/tmp$ git clone
Re: Can't authenticate Review Board w/Atlassian Stash via SSH
Hi Ken, Yea, I'd originally tried with the ssh:// pre-pended since that seems like the proper format of a URL, but the error I got from the Admin UI in that case was: [Errno -2] Name or service not known so that seemed to be even less promising. Now that I look again more closely, I see something interesting in the log... A) It shoes the proper port #. B) There's an entry that indicates that there was a connection and the remote daemon clearly identifies itself as Atlassian. Some exchanges happen, then everything just ends abruptly. See: 2014-04-29 21:22:29,981 - DEBUG - - GitTool: Attempting ssh connection with host: vi-stash.lab.vi.local:7999, username: git 2014-04-29 21:22:29,988 - DEBUG - - starting thread (client mode): 0xb7fb8e4cL *2014-04-29 21:22:29,989 - INFO - - Connected (version 2.0, client SSHD-CORE-0.9.0-ATLASSIAN-1)* 2014-04-29 21:22:29,991 - DEBUG - - kex algos:['diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa'] client encrypt:['aes128-ctr', 'aes256-ctr', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'aes192-cbc', 'aes256-cbc'] server encrypt:['aes128-ctr', 'aes256-ctr', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'aes192-cbc', 'aes256-cbc'] client mac:['hmac-md5', 'hmac-sha1', 'hmac-md5-96', 'hmac-sha1-96'] server mac:['hmac-md5', 'hmac-sha1', 'hmac-md5-96', 'hmac-sha1-96'] client compress:['none'] server compress:['none'] client lang:[''] server lang:[''] kex follows?False *2014-04-29 21:22:29,992 - DEBUG - - Ciphers agreed: local=aes128-ctr, remote=aes128-ctr* 2014-04-29 21:22:29,992 - DEBUG - - using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 2014-04-29 21:22:30,090 - DEBUG - - Switch to new keys ... 2014-04-29 21:22:30,192 - DEBUG - - EOF in transport thread Dan On Tuesday, April 29, 2014 2:18:47 PM UTC-7, Ken Rachynski wrote: You'll need to change your URL format. user@server:repo implies SSH and uses the colon to separate server from repo. This is likely why your port usage is disappearing. Use ssh://user@server:port/repo instead. Ken On Tuesday, April 29, 2014 2:59:04 PM UTC-6, Dan Tehranian wrote: Hi Christian, I've confirmed that Review Board is not respecting the port number in my Git URL string and using the default port 22 instead. In real-time I can see the relevant log output for sshd running on port 22 when I try to add a repo to Review Board with the URL: g...@vi-stash.lab.vi.local:7999/do/tools.git. From /var/log/auth.log on my Stash server: root@vi-git-stash1:/var/log# tail -f auth.log ... Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Invalid user git from 10.10.77.65 Apr 29 13:52:10 vi-git-stash1 sshd[4200]: input_userauth_request: invalid user git [preauth] Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Failed none for invalid user git from 10.10.77.65 port 34312 ssh2 Apr 29 13:52:10 vi-git-stash1 sshd[4200]: Connection closed by 10.10.77.65 [preauth] ... Meanwhile the logs for the Stash app that I'm also tailing don't show any connection attempt being to port 7999. Shall I file a bug? Thanks, Dan On Tuesday, April 29, 2014 12:25:26 PM UTC-7, Christian Hammond wrote: Hi Dan, We don't use OpenSSH for talking to the repository. We use our rbssh instead. This shouldn't end up using the SSH key in ~/.ssh, but rather should be using the SSH key configured in Review Board instead, which will live in $sitedir/data/.ssh instead of /var/www/.ssh. Is the SSH key shown in Review Board matching exactly the key configured on the repository's side? It is possible that there's an issue with the port. I'd have to see your repository configuration and play around with stuff to know more. Christian -- Christian Hammond - chi...@chipx86.com Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Apr 29, 2014 at 11:23 AM, Dan Tehranian tehr...@gmail.comwrote: We're moving our git server to Atlassian Stash and I'm unable to hook our existing Review Board instance up with the repos we've moved to Stash. The error from the Admin UI is: Unable to authenticate against this repository using one of the supported authentication types. From /var/log/reviewboard/reviewboard.log: 2014-04-29 18:04:49,684 - DEBUG - - GitTool: Attempting ssh connection with host: vi-stash.lab.vi.local, username: git 2014-04-29 18:04:49,688 - DEBUG - - starting thread (client mode): 0xb7fe712cL 2014-04-29 18:04:49,697 - INFO - - Connected (version 2.0, client OpenSSH_5.9p1) 2014-04-29 18:04:49,698 - DEBUG - - kex algos:['ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521', 'diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt
Re: Can't authenticate Review Board w/Atlassian Stash via SSH
Hi Christian, re: rbssh - If I try to invoke rbssh directly it seems to connect to the sshd on port 22 of the remote host even though I'm telling it to use port 7999. Ex: rbssh vi-stash.lab.vi.local -l git -p 7999 -s ssh Is there any way to better debug what rbssh is doing? Thanks, Dan On Tuesday, April 29, 2014 12:25:26 PM UTC-7, Christian Hammond wrote: Hi Dan, We don't use OpenSSH for talking to the repository. We use our rbssh instead. This shouldn't end up using the SSH key in ~/.ssh, but rather should be using the SSH key configured in Review Board instead, which will live in $sitedir/data/.ssh instead of /var/www/.ssh. Is the SSH key shown in Review Board matching exactly the key configured on the repository's side? It is possible that there's an issue with the port. I'd have to see your repository configuration and play around with stuff to know more. Christian -- Christian Hammond - chi...@chipx86.com javascript: Review Board - http://www.reviewboard.org Beanbag, Inc. - http://www.beanbaginc.com On Tue, Apr 29, 2014 at 11:23 AM, Dan Tehranian tehr...@gmail.comjavascript: wrote: We're moving our git server to Atlassian Stash and I'm unable to hook our existing Review Board instance up with the repos we've moved to Stash. The error from the Admin UI is: Unable to authenticate against this repository using one of the supported authentication types. From /var/log/reviewboard/reviewboard.log: 2014-04-29 18:04:49,684 - DEBUG - - GitTool: Attempting ssh connection with host: vi-stash.lab.vi.local, username: git 2014-04-29 18:04:49,688 - DEBUG - - starting thread (client mode): 0xb7fe712cL 2014-04-29 18:04:49,697 - INFO - - Connected (version 2.0, client OpenSSH_5.9p1) 2014-04-29 18:04:49,698 - DEBUG - - kex algos:['ecdh-sha2-nistp256', 'ecdh-sha2-nistp384', 'ecdh-sha2-nistp521', 'diffie-hellman-group-exchange-sha256', 'diffie-hellman-group-exchange-sha1', 'diffie-hellman-group14-sha1', 'diffie-hellman-group1-sha1'] server key:['ssh-rsa', 'ssh-dss'] client encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijnda...@lysator.liu.sejavascript:'] server encrypt:['aes128-ctr', 'aes192-ctr', 'aes256-ctr', 'arcfour256', 'arcfour128', 'aes128-cbc', '3des-cbc', 'blowfish-cbc', 'cast128-cbc', 'aes192-cbc', 'aes256-cbc', 'arcfour', 'rijnda...@lysator.liu.sejavascript:'] client mac:['hmac-md5', 'hmac-sha1', 'uma...@openssh.com javascript:', 'hmac-sha2-256', 'hmac-sha2-256-96', 'hmac-sha2-512', 'hmac-sha2-512-96', 'hmac-ripemd160', 'hmac-ri...@openssh.com javascript:', 'hmac-sha1-96', 'hmac-md5-96'] server mac:['hmac-md5', 'hmac-sha1', ' uma...@openssh.com javascript:', 'hmac-sha2-256', 'hmac-sha2-256-96', 'hmac-sha2-512', 'hmac-sha2-512-96', 'hmac-ripemd160', ' hmac-ri...@openssh.com javascript:', 'hmac-sha1-96', 'hmac-md5-96'] client compress:['none', 'zl...@openssh.com javascript:'] server compress:['none', 'zl...@openssh.com javascript:'] client lang:[''] server lang:[''] kex follows?False 2014-04-29 18:04:49,698 - DEBUG - - Ciphers agreed: local=aes128-ctr, remote=aes128-ctr 2014-04-29 18:04:49,698 - DEBUG - - using kex diffie-hellman-group1-sha1; server key type ssh-rsa; cipher: local aes128-ctr, remote aes128-ctr; mac: local hmac-sha1, remote hmac-sha1; compression: local none, remote none 2014-04-29 18:04:49,742 - DEBUG - - Switch to new keys ... 2014-04-29 18:04:49,773 - DEBUG - - Trying SSH key *baac4e3fe8a0e255a59160d00707093b* 2014-04-29 18:04:49,778 - DEBUG - - userauth is OK 2014-04-29 18:04:49,812 - INFO - - Authentication (publickey) failed. 2014-04-29 18:04:49,823 - DEBUG - - Trying discovered key *baac4e3fe8a0e255a59160d00707093b* in /var/www/vi-reviewboard/data/.ssh/id_rsa 2014-04-29 18:04:49,824 - DEBUG - - userauth is OK 2014-04-29 18:04:49,845 - INFO - - Authentication (publickey) failed. 2014-04-29 18:04:49,847 - DEBUG - - userauth is OK 2014-04-29 18:04:49,847 - INFO - - Authentication (password) failed. 2014-04-29 18:04:49,948 - DEBUG - - EOF in transport thread But I'm otherwise able to clone repos as the www-data user from the CLI. Ex: www-data@vi-reviewboard:~/tmp$ git clone ssh://g...@vi-stash.lab.vi.local:7999/do/tools.git Cloning into 'tools'... remote: Counting objects: 2271, done. remote: Compressing objects: 100% (954/954), done. remote: Total 2271 (delta 1468), reused 2004 (delta 1260) Receiving objects: 100% (2271/2271), 294.32 KiB, done. Resolving deltas: 100% (1468/1468), done. Even more confusing, when I successfully ssh w/--verbose from the CLI, I can see the fingerprint of the private key matches the fingerprint of the private key used by Review Board. Ex: www-data@vi-reviewboard:~/tmp$ ssh -vv g...@vi-stash.lab.vi.local -p 7999 OpenSSH_5.9p1 Debian-5ubuntu1.1, OpenSSL 1.0.1 14
Re: rbt and perforce 2005.1.PATCH configuration issues
I must be missing something then. I have a local copy of the
perforce tree that has all the files in the change list I want to
create, and rbt isn't finding it.
$ rbt setup-repo
Enter the Review Board server URL: http://172.16.149.128/reviewboard/r/
CRITICAL: 'Namespace' object has no attribute 'p4_client'
which looks like the same p4_client attribute error I get when
doing rbt list-repo-types
It may be something goofy on OSX with my python (it's a 2.6.1
and seems to have P4 and P4API installed) and installed with
easy_install as per
http://www.reviewboard.org/docs/rbtools/dev/#installation
Any help diagnosing/resolving/bypassing this would be outstanding.
(a sample .reveiwboardrc that works with p4 might help if somebody
has one laying about.)
I'll put the ticket request but can get by posting review requests from
a directory with the p4 client files in it as well.
Dan S.
On Wednesday, April 23, 2014 5:58:37 PM UTC-4, David Trowbridge wrote:
Right now, rbtools is not well suited to posting review requests for
submitted changes without a working directory. This should work fine if you
create a p4 client and run rbt from within that directory.
We should improve that, however. Can you file a bug about this?
-David
On Tue, Apr 22, 2014 at 7:46 PM, Dan Schmitt dan.s...@gmail.comjavascript:
wrote:
I can get the reviewboard web interface to see my p4 repository (and it
finds
the change descriptions if I try to create a a new review request.)
I'm seeing:
Traceback (most recent call last):
File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/__init__.py,
line 422, in run_from_argv
exit_code = self.main(*args) or 0
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/list_repo_types.py,
line 12, in main
print_clients(self.options)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/__init__.py,
line 356, in print_clients
repository_info = tool.get_repository_info()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 183, in get_repository_info
p4_info = self.p4.info()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 73, in info
split_lines=True)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 101, in run_p4
if self.options.p4_client:
AttributeError: 'Namespace' object has no attribute 'p4_client'
from rbt list-repo-types.
I don't have permission to make counters (which seems to be a suggested
work around for getting rbt post to work.)
rbt diff -d change number that worked in the web interface
rbt post -d change number that worked in the web interface
says:
ERROR: The current directory does not contain a checkout from a supported
source code repository.
I know the old p4 server means I don't have the shelve option. We are
currently pushing changes
to a development branch then merging that into a release branch. Is
there some trick I'm missing
for getting the rbt to build a diff for an already submitted p4 change?
Dan S.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an
email to reviewboard...@googlegroups.com javascript:.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: rbt and perforce 2005.1.PATCH configuration issues
In addition to that, the version string:
P4D/LINUX26AMD64/2005.1.PATCH/99707 (2006/05/16)
is failing in the perforce.py match (the .PATCH is throwing it off.)
m = re.search(r'[^ ]*/([0-9]+)\.([0-9]+)/[0-9]+ .*$',
server_version, re.M)
if m:
self.p4d_version = int(m.group(1)), int(m.group(2))
else:
# Gracefully bail if we don't get a match
return None
I'm slowly making progress (commented out the attempts to
use self.p4_client self.p4_port self.p4_passwd as options
to the p4 command (and just counting on having a logged
in instance.)
On Wednesday, April 23, 2014 6:28:19 PM UTC-4, David Trowbridge wrote:
I think the issues with setup-repo and list-repo-types are just a simple
bug with our command-line handling.
-David
On Wed, Apr 23, 2014 at 3:16 PM, Dan Schmitt dan.s...@gmail.comjavascript:
wrote:
I must be missing something then. I have a local copy of the
perforce tree that has all the files in the change list I want to
create, and rbt isn't finding it.
$ rbt setup-repo
Enter the Review Board server URL: http://172.16.149.128/reviewboard/r/
CRITICAL: 'Namespace' object has no attribute 'p4_client'
which looks like the same p4_client attribute error I get when
doing rbt list-repo-types
It may be something goofy on OSX with my python (it's a 2.6.1
and seems to have P4 and P4API installed) and installed with
easy_install as per
http://www.reviewboard.org/docs/rbtools/dev/#installation
Any help diagnosing/resolving/bypassing this would be outstanding.
(a sample .reveiwboardrc that works with p4 might help if somebody
has one laying about.)
I'll put the ticket request but can get by posting review requests from
a directory with the p4 client files in it as well.
Dan S.
On Wednesday, April 23, 2014 5:58:37 PM UTC-4, David Trowbridge wrote:
Right now, rbtools is not well suited to posting review requests for
submitted changes without a working directory. This should work fine if you
create a p4 client and run rbt from within that directory.
We should improve that, however. Can you file a bug about this?
-David
On Tue, Apr 22, 2014 at 7:46 PM, Dan Schmitt dan.s...@gmail.com wrote:
I can get the reviewboard web interface to see my p4 repository (and it
finds
the change descriptions if I try to create a a new review request.)
I'm seeing:
Traceback (most recent call last):
File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/commands/__init__.py, line 422, in run_from_argv
exit_code = self.main(*args) or 0
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/commands/list_repo_types.py, line 12, in main
print_clients(self.options)
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/clients/__init__.py, line 356, in print_clients
repository_info = tool.get_repository_info()
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/clients/perforce.py, line 183, in get_repository_info
p4_info = self.p4.info()
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/clients/perforce.py, line 73, in info
split_lines=True)
File /Library/Python/2.6/site-packages/RBTools-0.6-py2.6.
egg/rbtools/clients/perforce.py, line 101, in run_p4
if self.options.p4_client:
AttributeError: 'Namespace' object has no attribute 'p4_client'
from rbt list-repo-types.
I don't have permission to make counters (which seems to be a suggested
work around for getting rbt post to work.)
rbt diff -d change number that worked in the web interface
rbt post -d change number that worked in the web interface
says:
ERROR: The current directory does not contain a checkout from a
supported source code repository.
I know the old p4 server means I don't have the shelve option. We are
currently pushing changes
to a development branch then merging that into a release branch. Is
there some trick I'm missing
for getting the rbt to build a diff for an already submitted p4 change?
Dan S.
--
Get the Review Board Power Pack at http://www.reviewboard.org/
powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google
Groups reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send
an email to reviewboard...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
--
Get the Review Board Power Pack at http://www.reviewboard.org
rbt and perforce 2005.1.PATCH configuration issues
I can get the reviewboard web interface to see my p4 repository (and it
finds
the change descriptions if I try to create a a new review request.)
I'm seeing:
Traceback (most recent call last):
File /usr/local/bin/rbt, line 8, in module
load_entry_point('RBTools==0.6', 'console_scripts', 'rbt')()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/main.py,
line 134, in main
command.run_from_argv([RB_MAIN, command_name] + args)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/__init__.py,
line 422, in run_from_argv
exit_code = self.main(*args) or 0
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/commands/list_repo_types.py,
line 12, in main
print_clients(self.options)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/__init__.py,
line 356, in print_clients
repository_info = tool.get_repository_info()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 183, in get_repository_info
p4_info = self.p4.info()
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 73, in info
split_lines=True)
File
/Library/Python/2.6/site-packages/RBTools-0.6-py2.6.egg/rbtools/clients/perforce.py,
line 101, in run_p4
if self.options.p4_client:
AttributeError: 'Namespace' object has no attribute 'p4_client'
from rbt list-repo-types.
I don't have permission to make counters (which seems to be a suggested
work around for getting rbt post to work.)
rbt diff -d change number that worked in the web interface
rbt post -d change number that worked in the web interface
says:
ERROR: The current directory does not contain a checkout from a supported
source code repository.
I know the old p4 server means I don't have the shelve option. We are
currently pushing changes
to a development branch then merging that into a release branch. Is there
some trick I'm missing
for getting the rbt to build a diff for an already submitted p4 change?
Dan S.
--
Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/
---
Sign up for Review Board hosting at RBCommons: https://rbcommons.com/
---
Happy user? Let us know at http://www.reviewboard.org/users/
---
You received this message because you are subscribed to the Google Groups
reviewboard group.
To unsubscribe from this group and stop receiving emails from it, send an email
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
Re: epel 5.4 missing reviewboard package
@Stephen: My own version did not have this patch. Newer RBTools (as you mentioned) tries the system copy first. However the company wouldn't use it unless it had that patch included. Something like.. don't fix it if it's not broken ;) On 12 November 2013 13:35, Stephen Gallagher step...@gallagherhome.comwrote: On 11/11/2013 07:21 AM, Dan Porter wrote: For those wanting to run RBTools under EL5 (which is unfortunately our main production environment still), attached is an unofficial package we use at our company. It's built from standard sources and contains a minor patch. No post 0.5.2 updates/patches have been applied. Link to Gist if you wish to build this yourself: https://gist.github.com/Stealthii/7412376 On reviewboard itself I can confirm there are issues running this on RHEL5. Strongly recommend 6.2+. On Monday, November 4, 2013 11:35:43 PM UTC, Stephen Gallagher wrote: On 11/04/2013 01:28 PM, Adrien Rochereau wrote: Hi, I did an install two weeks ago on a centos 5.4 without any issues, This week, trying to do the same thing on RHEL 5.4 and yum kept returining not found, if you go to the package browser on fedora's website, you cannot find RB anymore under 5/i386. Is this because of an update or are you pulling the support of EPEL5? Yes, I sent out an announcement quite a while ago. RHEL/CentOS 4 is too old and cannot support ReviewBoard any longer without significant effort in porting all of its dependencies to the python26 toolchain in EPEL. Given that RHEL 5 is very old and in maintenance mode, I reasoned that people would generally accept running a RHEL 6 VM to power ReviewBoard if they wanted to. Oops! Thanks for pointing this out to me. I thought I had released an RBTools 0.5.2 package for EPEL 5, but it looks like I must have forgotten to. It's now built and on the way to the EPEL 5 updates-testing repository. I retired the Review Board server from EPEL 5, but it makes sense to maintain the client. I've created the package now: https://admin.fedoraproject.org/updates/RBTools-0.5.2-1.el5 It should get into the epel-testing repo within 48 hours. You can also download the RPM directly from the link above. Dan: I don't understand the point of the patch in your gist. It looks like a variant of an old one I had created, but it's no longer necessary. I got a better version upstreamed so that it will try to use the system copy before it resorts to ez_setup. Your patch doesn't really hurt anything, but it's unnecessary. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to a topic in the Google Groups reviewboard group. To unsubscribe from this topic, visit https://groups.google.com/d/topic/reviewboard/IrRmY0OsdnM/unsubscribe. To unsubscribe from this group and all its topics, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out. -- Get the Review Board Power Pack at http://www.reviewboard.org/powerpack/ --- Sign up for Review Board hosting at RBCommons: https://rbcommons.com/ --- Happy user? Let us know at http://www.reviewboard.org/users/ --- You received this message because you are subscribed to the Google Groups reviewboard group. To unsubscribe from this group and stop receiving emails from it, send an email to reviewboard+unsubscr...@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.
API for submission description
Is there an API available to retrieve the 'Describe the submission (optional)' field in submitted reviews? I couldn't find it anywhere in the API documentation. Also, I'm not sure if this is a bug or feature, but it appears that this field is distinct depending upon whether you are viewing the review or diff. Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
SVN: Repository not found error
Hey All, I'm on ReviewBoard 1.6.7.1 and having issues creating a new SVN repository when using the svn:// protocol. The SVN repository is accessible via http, https and svn and I have been able to create repositories already for the other two. But when I specify the svn://repository.example.com/ URI it says: - A repository was not found at the specified path. In /var/log/messages I see: Aug 17 08:56:17 mojo httpd: GSSAPI Error: Unspecified GSS failure. Minor code may provide more information (No credentials cache found) Aug 17 08:56:17 mojo httpd: No worthy mechs found However if I do an svn info from the reviewboard host it responds properly. Any ideas on what I'm missing here? Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Yes. And I agree. :)
- sent from my Galaxy Nexus Android phone.
On Jun 18, 2012 3:23 PM, Christian Hammond chip...@chipx86.com wrote:
Ah, that makes sense.
Was that the only option you needed then? It'd be nice to have some docs
on this somewhere.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Mon, Jun 18, 2012 at 4:51 AM, Dan Dumont ddum...@gmail.com wrote:
I set https, but it never seemed to stick.
Not sure if you've ever tested this deployment, but our server sits
behind a reverse proxy and ssl is terminated at the proxy, so the review
site machine never gets requests in on https.
It always sees http, and I think that's what's confusing whatever is
building the urls.
On Mon, Jun 18, 2012 at 5:49 AM, Christian Hammond
chip...@chipx86.comwrote:
Hi Dan,
Glad you got it working. I haven't really been available much this
weekend.
Thanks for the bug report. Should be an easy fix. However, I haven't
seen that or the need for the SetEnv come up yet. Does your Server URL in
the admin settings page use https or http? Setting that to https *should*
do the right thing.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board - http://www.reviewboard.org
VMware, Inc. - http://www.vmware.com
On Sat, Jun 16, 2012 at 9:15 PM, Dan Dumont ddum...@gmail.com wrote:
SetEnv HTTPS on
In the apache config worked like a charm though.
I did end up filing this issue
http://code.google.com/p/reviewboard/issues/detail?id=2639
I'm not sure yet if this will cause problems now that I've solved the
redirect https issues.
On Sat, Jun 16, 2012 at 11:56 PM, Dan Dumont ddum...@gmail.com wrote:
I found
https://groups.google.com/forum/?fromgroups#!topic/reviewboard/yIOamU1uvIY
But I tried setting
os.environ['HTTPS'] = on
In the reviewboard.wsgi file, but no dice. I'm pretty sure we have a
reverse proxy of some sort in front of us terminating SSL at the the
border.
Would be nice if you guys could just return protocol relative urls //
reviewboard.apache.org/etc...
Any advice on where to stick that config setting to force https urls?
On Saturday, June 16, 2012 11:16:27 PM UTC-4, Dan Dumont wrote:
Request URL:
https://reviews.apache.org/**api/review-requests/5345/?api_**
format=jsonhttps://reviews.apache.org/api/review-requests/5345/?api_format=json
responds:
1. review_request: {status:**pending, last_updated:2012-06-17
02:58:20, description:,…}
1. branch:
2. bugs_closed: []
3. changenum: null
4. description:
5. id: 5345
6. last_updated: 2012-06-17 02:58:20
7. links: {diffs:{href:http://**reviews.apache.org/api/review-*
*requests/5345/diffs/http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET},…}
1. changes: {href:http://reviews.**apache.org/api/review-**
requests/5345/changes/http://reviews.apache.org/api/review-requests/5345/changes/,
method:GET}
1. href: http://reviews.apache.**
org/api/review-requests/5345/**changes/http://reviews.apache.org/api/review-requests/5345/changes/
2. method: GET
2. delete: {href:http://reviews.**apache.org/api/review-**
requests/5345/http://reviews.apache.org/api/review-requests/5345/,
method:DELETE}
1. href: http://reviews.apache.**
org/api/review-requests/5345/http://reviews.apache.org/api/review-requests/5345/
2. method: DELETE
3. diffs: {href:http://reviews.**apache.org/api/review-**
requests/5345/diffs/http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET}
1. href: http://reviews.apache.**
org/api/review-requests/5345/**diffs/http://reviews.apache.org/api/review-requests/5345/diffs/
2. method: GET
4. draft: {href:http://reviews.**apache.org/api/review-**
requests/5345/draft/http://reviews.apache.org/api/review-requests/5345/draft/,
method:GET}
1. href: http://reviews.apache.**
org/api/review-requests/5345/**draft/http://reviews.apache.org/api/review-requests/5345/draft/
2. method: GET
5. file_attachments: {href:http:/**/reviews.apache.org/api/*
*review-requests/5345/file-**attachments/http://reviews.apache.org/api/review-requests/5345/file-attachments/,
method:GET}
1. href: http://reviews.apache.**
org/api/review-requests/5345/**file-attachments/http://reviews.apache.org/api/review-requests/5345/file-attachments/
2. method: GET
6. last_update: {href:http://**
reviews.apache.org/api/review-**requests/5345/last-update/http://reviews.apache.org/api/review-requests/5345
Re: Upgraded OS , then ReviewBoard failed upgrade
Didn't touch the apache config. It's a http - https redirect (no idea why the browser isn't simply following it, do ajax requests eat the 301 errors? I can't remember). This is a brand new draft. On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote: Hi Dan, It looks like it's redirecting to the URL it's already at? Is that right? Do any URLs but that cause a redirect? Was this an existing draft in the database, or a brand new one? And also, did you have to reconfigure the settings/Apache configuration at all, or is that all the same from before? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 16, 2012 at 4:53 PM, Dan Dumont ddum...@gmail.com wrote: Hi Christian, I got things mostly up and running again by reconstructing the sql tables in a new 1.5.5 install and then upgrading that. Having some difficulty at the site though. Many different api problems it looks like. I can't publish drafts, getting a 301: OPTIONS /api/review-requests/5335/draft/ HTTP/1.1 Host: reviews.apache.org Connection: keep-alive Access-Control-Request-Method: PUT Origin: https://reviews.apache.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.34 Safari/536.11 Access-Control-Request-Headers: origin, x-requested-with, content-type, accept Accept: */* Accept-Encoding: gzip,deflate,sdch Accept-Language: en-US,en;q=0.8 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 - HTTP/1.1 301 Moved Permanently Date: Sat, 16 Jun 2012 23:51:28 GMT Server: Apache/2.2.20 (Ubuntu) Location: https://reviews.apache.org/api/review-requests/5335/draft/ Vary: Accept-Encoding Content-Encoding: gzip Content-Length: 263 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: text/html; charset=iso-8859-1 Can you help me troubleshoot this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Ahh ok. So a bit more info: http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest If the origin of the URL conveyed by the Location header is same origin with the XMLHttpRequest origin and the redirect does not violate infinite loop precautions, transparently follow the redirect while observing the same-origin request event rules. I'm assuming origin here works the same as normal SOP browser stuff, so http - https will break. How are you crafting the api url for the post (not all the api calls fail, some of them are flaky occasionally though). Do you use a protocol relative url? //reviews.apache.org/path/to/api or do you build it off of some variable in the config? On Saturday, June 16, 2012 9:37:11 PM UTC-4, Dan Dumont wrote: Didn't touch the apache config. It's a http - https redirect (no idea why the browser isn't simply following it, do ajax requests eat the 301 errors? I can't remember). This is a brand new draft. On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote: Hi Dan, It looks like it's redirecting to the URL it's already at? Is that right? Do any URLs but that cause a redirect? Was this an existing draft in the database, or a brand new one? And also, did you have to reconfigure the settings/Apache configuration at all, or is that all the same from before? Christian -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com On Sat, Jun 16, 2012 at 4:53 PM, Dan Dumont ddum...@gmail.com wrote: Hi Christian, I got things mostly up and running again by reconstructing the sql tables in a new 1.5.5 install and then upgrading that. Having some difficulty at the site though. Many different api problems it looks like. I can't publish drafts, getting a 301: OPTIONS /api/review-requests/5335/draft/ HTTP/1.1 Host: reviews.apache.org Connection: keep-alive Access-Control-Request-Method: PUT Origin: https://reviews.apache.org User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64) AppleWebKit/536.11 (KHTML, like Gecko) Chrome/20.0.1132.34 Safari/536.11 Access-Control-Request-Headers: origin, x-requested-with, content-type, accept Accept: */* Accept-Encoding: gzip,deflate,sdch Accept-Language: en-US,en;q=0.8 Accept-Charset: ISO-8859-1,utf-8;q=0.7,*;q=0.3 - HTTP/1.1 301 Moved Permanently Date: Sat, 16 Jun 2012 23:51:28 GMT Server: Apache/2.2.20 (Ubuntu) Location: https://reviews.apache.org/api/review-requests/5335/draft/ Vary: Accept-Encoding Content-Encoding: gzip Content-Length: 263 Keep-Alive: timeout=5, max=100 Connection: Keep-Alive Content-Type: text/html; charset=iso-8859-1 Can you help me troubleshoot this? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Upgraded OS , then ReviewBoard failed upgrade
Request URL:
https://reviews.apache.org/api/review-requests/5345/?api_format=json
responds:
1. review_request: {status:pending, last_updated:2012-06-17 02:58:20,
description:,…}
1. branch:
2. bugs_closed: []
3. changenum: null
4. description:
5. id: 5345
6. last_updated: 2012-06-17 02:58:20
7. links:
{diffs:{href:http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET},…}
1. changes:
{href:http://reviews.apache.org/api/review-requests/5345/changes/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/changes/;
2. method: GET
2. delete: {href:http://reviews.apache.org/api/review-requests/5345/,
method:DELETE}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: DELETE
3. diffs:
{href:http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/diffs/;
2. method: GET
4. draft:
{href:http://reviews.apache.org/api/review-requests/5345/draft/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/draft/;
2. method: GET
5. file_attachments:
{href:http://reviews.apache.org/api/review-requests/5345/file-attachments/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/;
2. method: GET
6. last_update:
{href:http://reviews.apache.org/api/review-requests/5345/last-update/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/last-update/;
2. method: GET
7. repository: {href:http://reviews.apache.org/api/repositories/11/,
method:GET, title:shindig}
1. href: http://reviews.apache.org/api/repositories/11/;
2. method: GET
3. title: shindig
8. reviews:
{href:http://reviews.apache.org/api/review-requests/5345/reviews/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/reviews/;
2. method: GET
9. screenshots:
{href:http://reviews.apache.org/api/review-requests/5345/screenshots/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/screenshots/;
2. method: GET
10. self: {href:http://reviews.apache.org/api/review-requests/5345/,
method:GET}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: GET
11. submitter: {href:http://reviews.apache.org/api/users/ddumont/,
method:GET, title:ddumont}
1. href: http://reviews.apache.org/api/users/ddumont/;
2. method: GET
3. title: ddumont
12. update: {href:http://reviews.apache.org/api/review-requests/5345/,
method:PUT}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: PUT
8. public: false
9. status: pending
10. summary:
11. target_groups: []
12. target_people: []
13. testing_done:
14. time_added: 2012-06-17 02:58:19
2. stat: ok
Is there a setting I'm missing that controls the protocol?
On Saturday, June 16, 2012 9:50:36 PM UTC-4, Dan Dumont wrote:
Ahh ok. So a bit more info:
http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest
If the origin of the URL conveyed by the Location header is same
origin with the XMLHttpRequest origin and the redirect does not
violate infinite loop precautions, transparently follow the
redirect while observing the same-origin request event rules.
I'm assuming origin here works the same as normal SOP browser stuff, so
http - https will break.
How are you crafting the api url for the post (not all the api calls fail,
some of them are flaky occasionally though). Do you use a protocol
relative url? //reviews.apache.org/path/to/api
or do you build it off of some variable in the config?
On Saturday, June 16, 2012 9:37:11 PM UTC-4, Dan Dumont wrote:
Didn't touch the apache config.
It's a http - https redirect (no idea why the browser isn't simply
following it, do ajax requests eat the 301 errors? I can't remember).
This is a brand new draft.
On Saturday, June 16, 2012 9:31:26 PM UTC-4, Christian Hammond wrote:
Hi Dan,
It looks like it's redirecting to the URL it's already at? Is that right?
Do any URLs but that cause a redirect?
Was this an existing draft in the database, or a brand new one?
And also, did you have to reconfigure the settings/Apache configuration
at all, or is that all the same from before?
Christian
--
Christian Hammond - chip...@chipx86.com
Review
Re: Upgraded OS , then ReviewBoard failed upgrade
I found
https://groups.google.com/forum/?fromgroups#!topic/reviewboard/yIOamU1uvIY
But I tried setting
os.environ['HTTPS'] = on
In the reviewboard.wsgi file, but no dice. I'm pretty sure we have a
reverse proxy of some sort in front of us terminating SSL at the the border.
Would be nice if you guys could just return protocol relative urls
//reviewboard.apache.org/etc...
Any advice on where to stick that config setting to force https urls?
On Saturday, June 16, 2012 11:16:27 PM UTC-4, Dan Dumont wrote:
Request URL:
https://reviews.apache.org/api/review-requests/5345/?api_format=json
responds:
1. review_request: {status:pending, last_updated:2012-06-17 02:58:20,
description:,…}
1. branch:
2. bugs_closed: []
3. changenum: null
4. description:
5. id: 5345
6. last_updated: 2012-06-17 02:58:20
7. links: {diffs:{href:
http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET},…}
1. changes: {href:
http://reviews.apache.org/api/review-requests/5345/changes/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/changes/;
2. method: GET
2. delete: {href:
http://reviews.apache.org/api/review-requests/5345/,
method:DELETE}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: DELETE
3. diffs: {href:
http://reviews.apache.org/api/review-requests/5345/diffs/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/diffs/;
2. method: GET
4. draft: {href:
http://reviews.apache.org/api/review-requests/5345/draft/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/draft/;
2. method: GET
5. file_attachments: {href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/file-attachments/
2. method: GET
6. last_update: {href:
http://reviews.apache.org/api/review-requests/5345/last-update/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/last-update/
2. method: GET
7. repository: {href:
http://reviews.apache.org/api/repositories/11/, method:GET,
title:shindig}
1. href: http://reviews.apache.org/api/repositories/11/;
2. method: GET
3. title: shindig
8. reviews: {href:
http://reviews.apache.org/api/review-requests/5345/reviews/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/reviews/;
2. method: GET
9. screenshots: {href:
http://reviews.apache.org/api/review-requests/5345/screenshots/,
method:GET}
1. href:
http://reviews.apache.org/api/review-requests/5345/screenshots/
2. method: GET
10. self: {href:
http://reviews.apache.org/api/review-requests/5345/, method:GET}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: GET
11. submitter: {href:http://reviews.apache.org/api/users/ddumont/,
method:GET, title:ddumont}
1. href: http://reviews.apache.org/api/users/ddumont/;
2. method: GET
3. title: ddumont
12. update: {href:
http://reviews.apache.org/api/review-requests/5345/, method:PUT}
1. href: http://reviews.apache.org/api/review-requests/5345/;
2. method: PUT
8. public: false
9. status: pending
10. summary:
11. target_groups: []
12. target_people: []
13. testing_done:
14. time_added: 2012-06-17 02:58:19
2. stat: ok
Is there a setting I'm missing that controls the protocol?
On Saturday, June 16, 2012 9:50:36 PM UTC-4, Dan Dumont wrote:
Ahh ok. So a bit more info:
http://stackoverflow.com/questions/228225/prevent-redirection-of-xmlhttprequest
If the origin of the URL conveyed by the Location header is same
origin with the XMLHttpRequest origin and the redirect does not
violate infinite loop precautions, transparently follow the
redirect while observing the same-origin request event rules.
I'm assuming origin here works the same as normal SOP browser stuff, so
http - https will break.
How are you crafting the api url for the post (not all the api calls
fail, some of them are flaky occasionally though). Do you use a protocol
relative url? //reviews.apache.org/path/to/api
or do you build it off of some
Re: Add Repository UI Dropdown list for Repository Type empty
Thanks for the help Christian. I had an ah-ha moment during the reinstall. I didn't notice an error with the .python-eggs directory creation (not sure how i missed this the first time, it was pretty obvious). The basic problem was that i was doing sudo -s and then installing rb from that shell. My home directory was pointing to my original login account and root didn't have access to create a .python-eggs directory under my $HOME. This was causing issues setting up the SCMTools. Once I set my home appropriately, blew away my database and reinstalled, I now see these repositories populated. Thanks again! Dan On Jun 11, 2:41 pm, Christian Hammond chip...@gmail.com wrote: It looks like either there was a problem syncing the database initially or the database was wiped. Assuming you don't have anything of value in there yet, try nuking the database and starting over. Pay close attention to any errors shown in the terminal during rb-site install. Christian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Add Repository UI Dropdown list for Repository Type empty
# rb-site manage /var/www/reviews/ shell Python 2.4.3 (#1, Feb 24 2012, 13:04:26) [GCC 4.1.2 20080704 (Red Hat 4.1.2-50)] on linux2 Type help, copyright, credits or license for more information. (InteractiveConsole) from reviewboard.scmtools.models import Tool Tool.objects.all() [] Regarding Chris Tooley's comment: I had to manually install the pysvn package, and I put the files I built at the following: drwxr-xr-x 2 root root 4096 Jun 6 07:24 /usr/lib/python2.4/site- packages/pysvn I did make it owned by root but I think it should be accessible to the apache user The files I put inside the directory are: -rw-r--r-- 1 root root 12219 Jun 6 07:24 __init__.py -rw-r--r-- 1 root root 15044 Jun 6 07:24 __init__.pyc -rwxr-xr-x 1 root root 2806058 Jun 6 07:24 _pysvn_2_4.so Dan On Jun 11, 5:23 am, Christian Hammond chip...@chipx86.com wrote: Can you try running: $ rb-site manage /path/to/site/dir shell from reviewboard.scmtools.models import Tool Tool.objects.all() And paste the results? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jun 11, 2012 at 2:34 AM, Dan Miller email.mille...@gmail.comwrote: Restarted the webserver and nothing changed there. No Javascript errors are coming in the UI In Authentication I see: Standard Registration Active Directory LDAP NIS X.509 Public Key Legacy Authentication Module Dan On Jun 7, 9:42 pm, Christian Hammond chip...@chipx86.com wrote: You shouldn't need to reinstall or anything if you fix PySVN. Maybe just restart the web server. The JavaScript errors would be in your browser when you reach the page. It's possible that's causing it, but my guess would be it's some issue with how what's called Python entrypoints are registered. Actually, let's check that. Can you also go into the Authentication Settings and see if NIS, LDAP, and ActiveDirectory are options? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Jun 7, 2012 at 4:49 AM, Dan Miller email.mille...@gmail.com wrote: Understood about OEL support. I kind of assumed it would work the same as RHEL but that might be true Where can I check for the JavaScript errors? I don't remember seeing any during installation, were they logged anywhere? I installed RB 1.6.7.1. I thought I may have messed up the pysvn installation part. Assuming I have corrected it now, do I just need to create a new ReviewBoard site via rb-site install /var/www/newsite? Would that populate the dropdown list correctly? Dan On Jun 6, 1:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, This sounds like the installation once again partially failed. The list of repository types is populated during install, and should be available in that dropdown, but that may not be happening. Just to check, can you see if there are any JavaScript errors? If not, then it was the installation. I should point out that we don't officially support Oracle Enterprise. Given your previous e-mail and this one, it sounds like there may be some issues... What version of Review Board did you install? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Jun 6, 2012 at 10:08 AM, Dan Miller email.mille...@gmail.com wrote: So I gave up on my previous installation that just wasn't returning my web requests. No idea what was going on there, but I switched to a new machine running Oracle Enterprise Linux 5 this time. I have RB up now and the web requests are working fine. My problem now is that when I go to setup my source control repository the Add repository page has a blank Repository Type dropdown list. I'm using subversion so my guess is that there is some problem with my pysvn installation. I wasn't able to find an rpm package for my distro so I built it manually. I downloaded 1.7.6 from http://pysvn.tigris.org/project_downloads.htmlandfollowedthe instructions there. The tests that I built seem to work so I'm not sure what could be wrong. Does anyone have ideas about how I can troubleshoot this. Am I on the right track that it's my pysvn installation that is the problem or is there some other cause of having an empty dropdown list there? Thanks! Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe
Re: Add Repository UI Dropdown list for Repository Type empty
Understood about OEL support. I kind of assumed it would work the same as RHEL but that might be true Where can I check for the JavaScript errors? I don't remember seeing any during installation, were they logged anywhere? I installed RB 1.6.7.1. I thought I may have messed up the pysvn installation part. Assuming I have corrected it now, do I just need to create a new ReviewBoard site via rb-site install /var/www/newsite? Would that populate the dropdown list correctly? Dan On Jun 6, 1:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, This sounds like the installation once again partially failed. The list of repository types is populated during install, and should be available in that dropdown, but that may not be happening. Just to check, can you see if there are any JavaScript errors? If not, then it was the installation. I should point out that we don't officially support Oracle Enterprise. Given your previous e-mail and this one, it sounds like there may be some issues... What version of Review Board did you install? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Jun 6, 2012 at 10:08 AM, Dan Miller email.mille...@gmail.comwrote: So I gave up on my previous installation that just wasn't returning my web requests. No idea what was going on there, but I switched to a new machine running Oracle Enterprise Linux 5 this time. I have RB up now and the web requests are working fine. My problem now is that when I go to setup my source control repository the Add repository page has a blank Repository Type dropdown list. I'm using subversion so my guess is that there is some problem with my pysvn installation. I wasn't able to find an rpm package for my distro so I built it manually. I downloaded 1.7.6 from http://pysvn.tigris.org/project_downloads.htmland followed the instructions there. The tests that I built seem to work so I'm not sure what could be wrong. Does anyone have ideas about how I can troubleshoot this. Am I on the right track that it's my pysvn installation that is the problem or is there some other cause of having an empty dropdown list there? Thanks! Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Add Repository UI Dropdown list for Repository Type empty
So I gave up on my previous installation that just wasn't returning my web requests. No idea what was going on there, but I switched to a new machine running Oracle Enterprise Linux 5 this time. I have RB up now and the web requests are working fine. My problem now is that when I go to setup my source control repository the Add repository page has a blank Repository Type dropdown list. I'm using subversion so my guess is that there is some problem with my pysvn installation. I wasn't able to find an rpm package for my distro so I built it manually. I downloaded 1.7.6 from http://pysvn.tigris.org/project_downloads.html and followed the instructions there. The tests that I built seem to work so I'm not sure what could be wrong. Does anyone have ideas about how I can troubleshoot this. Am I on the right track that it's my pysvn installation that is the problem or is there some other cause of having an empty dropdown list there? Thanks! Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New RB site setup issues with apache
Still hung here, anyone have any ideas? On May 30, 12:05 pm, Dan Miller email.mille...@gmail.com wrote: I'm having issues getting my ReviewBoard site up and running and wanted to see if anyone has encountered this before or has ideas on what I can try to resolve it. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New RB site setup issues with apache
This is Oracle Enterprise Linux 6: # uname -a Linux slc01ozq 2.6.32-100.28.5.el6.x86_64 #1 SMP Wed Feb 2 18:40:23 EST 2011 x86_64 x86_64 x86_64 GNU/Linux On Jun 4, 3:59 am, Christian Hammond chip...@chipx86.com wrote: Hi Dan, That's a new one. It's hard to tell from those logs what exactly is failing, and I suspect without access to the system I wouldn't be able to really determine why it's broken. What distro is this on? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Mon, Jun 4, 2012 at 1:46 AM, Dan Miller email.mille...@gmail.com wrote: Still hung here, anyone have any ideas? On May 30, 12:05 pm, Dan Miller email.mille...@gmail.com wrote: I'm having issues getting my ReviewBoard site up and running and wanted to see if anyone has encountered this before or has ideas on what I can try to resolve it. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
New RB site setup issues with apache
I'm having issues getting my ReviewBoard site up and running and wanted to see if anyone has encountered this before or has ideas on what I can try to resolve it. After installing all the dependencies (i'm pretty sure I got them all), I installed ReviewBoard via easy_install. I then ran rb-site install /var/www/reviews to install my RB site - accepting mostly the defaults. I then edited my apache http.conf file to include the apache-wsgi.conf and restarted the httpd. But now when I access the server via a browser it doesn't load my RB site. I see a HTTP 301 response code in my access.log, but the browser never redirects anywhere. I have tried this on Firefox 3.6 and IE 8 and both behave the same. 10.x.x.x - - [30/May/2012:02:56:18 -0700] GET / HTTP/1.1 301 - - Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 5.1; Trident/4.0; .NET CLR 2.0.50727; .NET CLR 1.1.4322; .NET CLR 3.0.4506.2152; .NET CLR 3.5.30729; .NET4.0C; .NET4.0E) The httpd error_log shows the following on startup: [Wed May 30 03:00:13 2012] [notice] suEXEC mechanism enabled (wrapper: /usr/sbin/suexec) [Wed May 30 03:00:13 2012] [notice] Digest: generating secret for digest authentication ... [Wed May 30 03:00:13 2012] [notice] Digest: done [Wed May 30 03:00:13 2012] [warn] mod_wsgi: Compiled for Python/2.6.2. [Wed May 30 03:00:13 2012] [warn] mod_wsgi: Runtime using Python/ 2.6.6. [Wed May 30 03:00:13 2012] [notice] Apache/2.2.15 (Unix) DAV/2 mod_auth_kerb/5.4 mod_auth_pgsql/2.0.3 mod_nss/2.2.15 NSS/3.12.6.2 PHP/ 5.3.2 mod_ssl/2.2.15 OpenSSL/1.0.0-fips SVN/1.6.11 mod_wsgi/3.2 Python/ 2.6.6 mod_perl/2.0.4 Perl/v5.10.1 configured -- resuming normal operations I'm not sure if the warn in the mod_wsgi compiled/runtime discrepancy is causing some issues? Then when accessing the site I get a security warning in the httpd error_log: [Wed May 30 03:01:55 2012] [error] /usr/lib/python2.6/site-packages/ pycrypto-2.6-py2.6-linux-x86_64.egg/Crypto/Util/number.py:57: PowmInsecureWarning: Not using mpz_powm_sec. You should rebuild using libgmp = 5 to avoid timing attack vulnerability. [Wed May 30 03:01:55 2012] [error] _warn(Not using mpz_powm_sec. You should rebuild using libgmp = 5 to avoid timing attack vulnerability., PowmInsecureWarning) Any ideas on what I've done wrong and how I can resolve these issues? Thanks! Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem installing ReviewBoard (www.djangoproject.com)
Thanks for the tip. It was definitely a connection issue. Turns out I had set http_proxy but the URL http://www.django.project.com/ is redirecting to use HTTPS. And I had not set https_proxy so my system was not able to use our proxy to access it. Once the https_proxy was set the installation continued smoothly. Dan On May 24, 2:40 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, It is looking for 1.3.1 specifically. RB 1.6.x won't work with Django 1.4. This looks like some temporary downtime issue with their server. I can accesswww.djangoproject.comnow. Can you try again? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Problem installing ReviewBoard (www.djangoproject.com)
My installation was crusing along until it got to www.djangoproject.com. I'm not sure if it's that easy_install is looking for version 1.3.1 and the latest version is 1.4 (perhaps something moved - I'm not very familiar with how the internals work here). Anyways, any ideas of how I can move past this? I tried downloading and installing Django 1.3.1 manually but when I go back to easy_install ReviewBoard it still hangs at the same point. Thanks! Logs below: [root@slc01ozq reviewboard]# easy_install ReviewBoard Searching for ReviewBoard Reading http://pypi.python.org/simple/ReviewBoard/ Reading http://www.reviewboard.org/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.5/ Reading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ Reading http://www.review-board.org/ Reading http://downloads.review-board.org/releases/ReviewBoard/1.0/ Reading http://downloads.review-board.org/releases/ Best match: ReviewBoard 1.6.6 Downloading http://downloads.reviewboard.org/releases/ReviewBoard/1.6/ReviewBoard-1.6.6-py2.6.egg Processing ReviewBoard-1.6.6-py2.6.egg creating /usr/lib/python2.6/site-packages/ReviewBoard-1.6.6-py2.6.egg Extracting ReviewBoard-1.6.6-py2.6.egg to /usr/lib/python2.6/site- packages Adding ReviewBoard 1.6.6 to easy-install.pth file Installing rb-site script to /usr/bin Installing rbssh script to /usr/bin Installed /usr/lib/python2.6/site-packages/ReviewBoard-1.6.6-py2.6.egg Reading http://downloads.reviewboard.org/mirror/ Processing dependencies for ReviewBoard Searching for recaptcha-client Reading http://pypi.python.org/simple/recaptcha-client/ Reading http://recaptcha.net Reading http://recaptcha.net/ Best match: recaptcha-client 1.0.6 Downloading http://pypi.python.org/packages/source/r/recaptcha-client/recaptcha-client-1.0.6.tar.gz#md5=74228180f7e1fb76c4d7089160b0d919 Processing recaptcha-client-1.0.6.tar.gz Running recaptcha-client-1.0.6/setup.py -q bdist_egg --dist-dir /tmp/ easy_install-rf3kyM/recaptcha-client-1.0.6/egg-dist-tmp-_mGYsF zip_safe flag not set; analyzing archive contents... Adding recaptcha-client 1.0.6 to easy-install.pth file Installed /usr/lib/python2.6/site-packages/recaptcha_client-1.0.6- py2.6.egg Searching for python-dateutil==1.5 Reading http://pypi.python.org/simple/python-dateutil/ Reading http://labix.org/python-dateutil Best match: python-dateutil 1.5 Downloading http://labix.org/download/python-dateutil/python-dateutil-1.5.tar.gz Processing python-dateutil-1.5.tar.gz Running python-dateutil-1.5/setup.py -q bdist_egg --dist-dir /tmp/ easy_install-3TzSuV/python-dateutil-1.5/egg-dist-tmp-7ucK_1 Adding python-dateutil 1.5 to easy-install.pth file Installed /usr/lib/python2.6/site-packages/python_dateutil-1.5- py2.6.egg Searching for paramiko=1.7.6 Reading http://pypi.python.org/simple/paramiko/ Reading http://www.lag.net/~robey/paramiko/ Reading http://www.lag.net/paramiko/ Best match: paramiko 1.7.7.2 Downloading http://pypi.python.org/packages/source/p/paramiko/paramiko-1.7.7.2.zip#md5=f6b2dc341ee62c30574570182b7a5744 Processing paramiko-1.7.7.2.zip Running paramiko-1.7.7.2/setup.py -q bdist_egg --dist-dir /tmp/ easy_install-AP3ptH/paramiko-1.7.7.2/egg-dist-tmp-SIxEiP zip_safe flag not set; analyzing archive contents... Adding paramiko 1.7.7.2 to easy-install.pth file Installed /usr/lib/python2.6/site-packages/paramiko-1.7.7.2-py2.6.egg Searching for flup Reading http://pypi.python.org/simple/flup/ Reading http://www.saddi.com/software/flup/ Best match: flup 1.0.3.dev-20110405 Downloading http://pypi.python.org/packages/2.6/f/flup/flup-1.0.3.dev_20110405-py2.6.egg#md5=78e71f7a440ebaea55187caf8825c111 Processing flup-1.0.3.dev_20110405-py2.6.egg creating /usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405- py2.6.egg Extracting flup-1.0.3.dev_20110405-py2.6.egg to /usr/lib/python2.6/ site-packages Adding flup 1.0.3.dev-20110405 to easy-install.pth file Installed /usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405- py2.6.egg Searching for Pygments=1.4 Reading http://pypi.python.org/simple/Pygments/ Reading http://pygments.org/ Reading http://pygments.pocoo.org/ Best match: Pygments 1.5 Downloading http://pypi.python.org/packages/2.6/P/Pygments/Pygments-1.5-py2.6.egg#md5=359d667ed004b6d1bee20917a7d06a7b Processing Pygments-1.5-py2.6.egg creating /usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg Extracting Pygments-1.5-py2.6.egg to /usr/lib/python2.6/site-packages Adding Pygments 1.5 to easy-install.pth file Installing pygmentize script to /usr/bin Installed /usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg Searching for Djblets==0.6.16 Reading http://pypi.python.org/simple/Djblets/ Reading http://www.review-board.org/wiki/Djblets Reading http://downloads.review-board.org/releases/Djblets/0.5/ Reading http://downloads.review-board.org/releases/Djblets/0.6/ Reading http://www.reviewboard.org/wiki/Djblets Best match: Djblets 0.6.16 Downloading
Re: Having trouble setting up a GitHub (Private Organization) repository
I finally got a response from GitHub. Here is it: The API Token has been removed. We encourage all third party applications to migrate to API v3. Please check our latest blog post for more details: https://github.com/blog/1090-github-api-moving-on; Pretty much, they've said, We're shutting down the v1 and v2 APIs on May 1. Oh, and if you don't already have an API Token, then I guess for you, the APIs are shut down now. Brilliant. -- Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: After installation, I see The page you were looking for does not exist.
I have the same problem that only if setting reviewboard as root it works, otherwise (set it in sub directory) it says The page you were looking for does not exist. On 9月14日, 上午9时08分, Den Mark huawen@gmail.com wrote: That's right. The problem is fixed by setting it to root. But I would disable that configuration to avoid confusion . On Sep 13, 5:43 am, Nicolas VINOT ae...@imirhil.fr wrote: Hi, Doyouinstall RB in a directory andnotat the root of your virtualhost ? Seems the same problem here :https://groups.google.com/forum/#!topic/reviewboard/cOP9dePrAuI -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Problem encountered during site upgrade from 1.5 to 1.5.5
The problem at hand is this error when upgrading a site: $ sudo rb-site upgrade /path/to/site Rebuilding directory structure Updating database. This may take a while. There are unapplied evolutions for diffviewer. There are unapplied evolutions for reviews. There are unapplied evolutions for scmtools. Project signature has changed - an evolution is required No fixtures found. /usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-i686.egg/ Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This application uses RandomPool, which is BROKEN in older releases. See http://www.pycrypto.org/randpool-broken Error: Error applying evolution: column basedir of relation diffviewer_diffset already exists I had already updated ReviewBoard with easy_install from 1.5 to 1.5.3 and then 1.5.3 to 1.5.5 (IIRC) but had forgotten to upgrade the site during those updates which I suspect is the cause of the problem. Doing the naive thing and dropping the diffviewer_diffset.basedir column results in this error: Error: Error applying evolution: cannot ALTER TABLE diffviewer_diffset because it has pending trigger events So I feel like I'm rather stuck between a rock and a hard place of my own making. Any advice on how I might proceed would be very much appreciated. Cheers, Dan Brook -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Problem encountered during site upgrade from 1.5 to 1.5.5
On Fri, Jul 8, 2011 at 8:03 PM, Christian Hammond chip...@chipx86.com wrote: Did you back up before dropping the table? Indeed, that was the first thing I did before touching the DB. If you have a backup to come back to, then one thing to try first is to upgrade django_evolution using easy_install -U. Then try the upgrade again. I gave that a try and django_evolution was upgraded from 0.6.2 - 0.6.4 but to no avail unfortunately - I'm still seeing the same error on rb-site upgrade: column basedir of relation diffviewer_diffset already exists. Any other suggestions? :) Cheers, Dan Brook -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Review Board 1.6 beta 2 - For real this time!
Ah, I suspected that it might be in the database. Thanks, Dan On May 11, 2:54 pm, Christian Hammond chip...@chipx86.com wrote: It fixes all future ones going forward. We need to reset the broken 1.6 beta 1 counts, which I'm still trying to figure out the best way to do. It'll happen by the next beta, unless there's some emergency that forces us to put the beta out sooner than planned. We have a Review Board instance with negative counts too. I'm keeping it that way as a reminder :) Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, May 11, 2011 at 10:59 AM, Dan Savilonis d...@n-cube.org wrote: Upgrade to 1.6 beta 2 went fine for me. However, I noticed there are a couple lines in the release note indicating some fixes for incoming review and starred review request counts. This doesn't seem to have fixed the counts for me. I currently have -15 incoming reviews and -1 outgoing reviews. I've noticed it slowly decrementing since we installed 1.6 beta 1 :) Dan On May 10, 3:03 am, Ashithraj Shetty asithraj.she...@gmail.com wrote: Upgraded to the latest release. Big bad box is not seen anymore J -Ashith From: reviewboard@googlegroups.com [mailto:reviewboard@googlegroups.com] On Behalf Of Christian Hammond Sent: Tuesday, May 10, 2011 11:37 AM To: reviewboard@googlegroups.com Subject: Review Board 1.6 beta 2 - For real this time! Let's try this again. 1.6 beta 2 is out! It should work with PostgreSQL and shouldn't have a giant box at the bottom of every page. Give it a try! Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today athttp:// www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp:// groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: New RB API - GSoC project
Hi Alexander, I read your proposal and I found it to be a bit vague. After I searched for your previous proposal message, I found you were discussing a new version of post-review, so I assume that that is still within the scope of this project? When you talk about new commands, can you cite some examples of currently-lacking functionality? While it's good to improve the internals of Review Board, I think it's most important to provide an improved experience for users. What will the new API allow that post-review doesn't now? Something like a GUI interface, while convenient (to some), doesn't provide a lot of value if it doesn't enhance the process for submitting and maintaining code reviews. So, I'd be most interested in hearing some specific examples of how the functionality will be improved, not just the interfaces themselves. Please do commit your changes as they are in progress to your own repository or branch. There is no harm in doing this, but every benefit for people to see the progress being made before it is finished. Dan On Apr 26, 2:41 am, Alexander Solovets asolov...@gmail.com wrote: Hello, Review Board members! My name is Alexander and I will work on my project about enhancing RB API during GSoC'11. You may look through my proposal on GSoC official site. So far I had conversation only with Christian Hammond and would like to meet with the rest team. I already have a humble experience in contributing to the open-source projects and I know that each of them has its own mini-culture, so I'd like to know yours. I've already read Getting started wiki section and wondering whether you have some sort of informal guidelines about coding style, commit messages, etc. It was unusual that nobody comment my proposal during the application review period. So I greatly appreciate if you do it now (of course if there is something to say). Also I'd like to hear your wishes about the final result. At last, I should know how can I present my work. I can either work with cloned repo and post the changes from time to time or commit directly to main repo. Thank you all for chosen me and for such exciting opportunity to work with you! Review Board rocks! -- Sincerely, Alexander -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Using post-review in git's bare repository
Hi Jan, The intent of the post-review default behavior is to attempt to automatically produce a diff of the user's current work. So, it will look for commits not merged into the tracking branch for the current branch. For a bare repository, this no longer makes sense. I would think only the explicit revision range option would make sense in this context. There is no need for a working copy to perform a git on arbitrary revisions in git. However, if you just type git diff, you'll get an error because it will try to perform a diff on the working copy (which doesn't exist). For example: Doesn't work: $ git clone https://github.com/reviewboard/reviewboard.git; cd reviewboard.git $ git diff Works: $ git clone https://github.com/reviewboard/reviewboard.git; cd reviewboard.git $ git diff HEAD^..HEAD Dan On Mar 25, 2:20 am, Christian Hammond chip...@chipx86.com wrote: Really? I'm curious about this because I couldn't even generate a diff in a bare repository, and from a google search, it seemed other people were also under the impression that you needed an actual checkout. If it can be made to work, I'm definitely all for including it. That'd be much better than needing a full checkout. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Thu, Mar 24, 2011 at 11:08 PM, Jan Koprowski jan.koprow...@gmail.comwrote: Isn't true. I already wrote little (3 lines?) patch which allow generate diffs for parent branch from bare-repo but I want to test it in fire of war before I send code to review. Everything looks good so it is possible. Will be good in future if post-review will be tested and modified to work also with bare-repositories. This will allow to use post-review inside git hooks on central repo. Regards, On Thu, Mar 24, 2011 at 9:25 PM, Christian Hammond chip...@chipx86.com wrote: Hi Jan, post-review needs to generate diffs from code in the tree. If it's a bare tree, there's not really much to generate. It doesn't have the objects for which to generate those diffs. If you try to run 'git diff', I think you'll hit the same problems. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Mar 23, 2011 at 10:05 AM, Jan Koprowski jan.koprow...@gmail.com wrote: Hi! Because I must figure out how use post-review with git bare repositories I start working on it. Running post-review inside bare-repository ands with: $post-review -n -d --parent b --serverhttp://localhost:8080/ svn info git rev-parse --git-dir git symbolic-ref -q HEAD Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] fatal: Not a git repository (or any of the parent directories): .git But strange thing is I can run git symbolic-ref -q HEAD without error. $git symbolic-ref -q HEAD refs/heads/master Any ideas? Regards, Jan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Jan Koprowski -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP setup with 1.5.4
On Fri, Mar 25, 2011 at 9:35 AM, storms v...@sendmail.com wrote: I have defined the following in Authentication Settings page: LDAP Server: ldap://server:389 LDAP BaseDN: dc=sendmail,dc=com User Mask: ((objectClass=User) (mailNickname=%s)) ...snip... WARNING:root:LDAP error: The specified object does not exist in the Directory: ((objectClass=User) (mailNickname=admin)) Try (assuming you have openldap-clients installed): ldapsearch -x -h server -b dc=sendmail,dc=com \ '((objectClass=User) (mailNickname=foo))' where 'foo' is the username you're trying to log in with. You'll want to examine your LDAP object to make sure it has objectClass=User and mailNickname=foo, of course. -- Dan Young dyo...@mesd.k12.or.us Multnomah ESD - Technology Services 503-257-1562 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: LDAP configuration
On Thu, Jan 27, 2011 at 11:47 PM, David courn...@gmail.com wrote: FWIW, I could not make it work using the python ldap library either: l = ldap.open(x.x.x.x:389) username = cn=admin,dc=x,dc=y,dc=z password = x l.simple_bind(username, password) # fails with (2, 'No such file or directory') Specifying a port in open() uses a kword argument, rather than :portnum, i.e.: l = ldap.open(x.x.x.x, port=389) The default is 389, so you can also omit that entirely, and just: l = ldap.open(x.x.x.x) Also, FWIW, the open() function is deprecated in favor of initialize(), which uses the LDAP URL syntax where the port number _is_ set using a colon trailing the hostname, like this: l = ldap.initialize(ldap://x.x.x.x:389/dc=example,dc=org;) For reference: http://www.python-ldap.org/doc/html/ldap.html#functions -- Dan Young dyo...@mesd.k12.or.us Multnomah ESD - Technology Services 503-257-1562 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Hi Christian,
You mean post a review request to http://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Yes, it works well on my side, tested on 2 machines.
I will go to post a review.
As for the change description, is some recent change on rb server side
break it? If so, which change is it?
On Jan 13, 7:15 pm, Christian Hammond chip...@chipx86.com wrote:
Yeah, though I just committed the fix. Can you make sure it works
correctly on your end?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Thu, Jan 13, 2011 at 12:29 AM, Dan birb...@gmail.com wrote:
Hi Christian,
You mean post a review request tohttp://reviews.reviewboard.org/?
On Jan 13, 1:33 pm, Christian Hammond chip...@chipx86.com wrote:
Hi Dan,
You're correct, this is a bug, and your fix looks fine. We'll have to
get that fix in. Want to post a review request?
Christian
On Wednesday, January 12, 2011, Dan birb...@gmail.com wrote:
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
--
Want to help the Review Board project? Donate today
athttp://www.reviewboard.org/donate/
Happy user? Let us know athttp://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
athttp://groups.google.com/group/reviewboard?hl=en
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group
Re: Question about postreview.py get_repository_info
Here is a more accurate description:
In ReviewBoardServer.get_repository_info, it calls
ReviewBoardServer.api_get to fetch the repository info from sever,
from my debug, it show the return json is something like (if the
repository is svn)
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET
},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method:
GET
}
},
name: local-android
}
}
from the data structure of the json, we can see that use url =
rsp['links']['info']['href'] of course will get a array key
exception.
should use url = rsp['repository']['links']['info']['href'].
Is this a bug?
On Jan 11, 9:24 pm, Dan birb...@gmail.com wrote:
Hi
Here I have a problem with postreview.py when publish a review
request, could anyone please have a look?
My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py
fromhttps://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa03...,
and configed the constants necessary.
When I run postreivew, it throws a array index exception at line 677:
url = rsp['links']['info']['href'], The whole piece of code is
def get_repository_info(self, rid):
Returns detailed information about a specific repository.
if self.deprecated_api:
url = 'api/json/repositories/%s/info/' % rid
else:
rsp = self.api_get(
'%s%s/' % (self.root_resource['links']['repositories']
['href'],
rid))
url = rsp['links']['info']['href']
rsp = self.api_get(url)
return rsp['info']
I added debug info for rep, it did not contain the links index
indeed, but it contained a repository index.
Then I manually went to check the xml from reviewboard server, and
found the structure of the xml is like this
rsp
repository
links
info
href
so I changed line 677 to url = rsp[repository]['links']['info']
['href'], finally it worked.
Though it worked, I still did not know the reason and whether my
change is right or wrong. I think it is unlike to be a bug of
reviewboard, but I am too lazy to read all the code :-) so, could
anyone kindly tell me that what the real problem is and what should I
do?
Any help will be highly appreciated!
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Question about postreview.py get_repository_info
A more correct and readable json than last post, the indent for name
in the last post is wrong.
{
stat: ok,
repository: {
path: http://192.168.1.131/svn/Android;,
tool: Subversion,
id: 2,
links: {
info: {
href: http://192.168.1.131:81/api/repositories/2/
info/,
method: GET},
self: {
href: http://192.168.1.131:81/api/repositories/
2/,
method: GET}},
name: local-android}
}
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Question about postreview.py get_repository_info
Hi Here I have a problem with postreview.py when publish a review request, could anyone please have a look? My enviroment is Reviewboard 1.5.1 and SVN. I downloaded postreview.py from https://github.com/reviewboard/rbtools/blob/184334a7a5ddc24172ae2aa0364f13aabe037470/rbtools/postreview.py, and configed the constants necessary. When I run postreivew, it throws a array index exception at line 677: url = rsp['links']['info']['href'], The whole piece of code is def get_repository_info(self, rid): Returns detailed information about a specific repository. if self.deprecated_api: url = 'api/json/repositories/%s/info/' % rid else: rsp = self.api_get( '%s%s/' % (self.root_resource['links']['repositories'] ['href'], rid)) url = rsp['links']['info']['href'] rsp = self.api_get(url) return rsp['info'] I added debug info for rep, it did not contain the links index indeed, but it contained a repository index. Then I manually went to check the xml from reviewboard server, and found the structure of the xml is like this rsp repository links info href so I changed line 677 to url = rsp[repository]['links']['info'] ['href'], finally it worked. Though it worked, I still did not know the reason and whether my change is right or wrong. I think it is unlike to be a bug of reviewboard, but I am too lazy to read all the code :-) so, could anyone kindly tell me that what the real problem is and what should I do? Any help will be highly appreciated! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Manual Update told Unable to read settings_local.py
Hi All, Following the guide of http://www.reviewboard.org/docs/manual/1.5/admin/installation/windows/, I installed the reviewboard and created a site. But when I access the site, it said Manual server updates required, and ask me visit http://code.google.com/p/reviewboard/wiki/RequiredServerUpdates. It ask me run the command manage.py syncdb, I did it, however, got a message Unable to read settings_local.py. The manage.py is in the reviewboard directory, and the settings_local.py is in the conf directory of site. Then I am lost... Could anyone tell me how to make it work, any help will be highly appreciated! -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.
Have you found a solution to this problem?
I have the same problem too. :-(
Could someone give some hints?
Any help will be highly appreciated!
On Dec 1, 3:59 am, Travis dahlke.tra...@gmail.com wrote:
Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: ImproperlyConfigured: Error importing middleware reviewboard.admin.middleware: DLL load failed: The specified module could not be found.
Have you found solution to this problem,
I have the same problem now.
Could anyone give some hints?
Any help will be highly appreciated.
On Dec 1, 3:59 am, Travis dahlke.tra...@gmail.com wrote:
Trying to install Reviewboard 1.5.1 on Windows XP SP3 with Apache 2.2
and mod_wsgi. Below is my apache error log. In my browser I get stuck
on Review Board is taking a nap. Any idea what's going on? How do I
tell which DLL failed?
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] mod_wsgi
(pid=14184): Exception occurred processing WSGI script 'C:/reviewboard/
htdocs/reviewboard.wsgi'.
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] Traceback (most
recent call last):
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\wsgi.py, line 230, in __call__
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
self.load_middleware()
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] File C:\
\Python27\\lib\\site-packages\\django-1.2.3-py2.7.egg\\django\\core\
\handlers\\base.py, line 42, in load_middleware
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1] raise
exceptions.ImproperlyConfigured('Error importing middleware %s: %s'
% (mw_module, e))
[Tue Nov 30 13:40:12 2010] [error] [client 127.0.0.1]
ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: DLL load failed: The specified module
could not be found.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: AD authentication w/SSPI NTLM integration
This is not implemented. However, Django supports this kind of authentication, so I imagine you could add support for it. Looking at the docs, it seems really simple, though I've never found anything with single-sign-on to be simple... http://docs.djangoproject.com/en/dev/howto/auth-remote-user/ Dan On Oct 13, 1:00 pm, Ian Battersby ian.batter...@gmail.com wrote: Hi all, We're running ReviewBoard 1.5 and have AD authentication working via the Python ldap module but wondered if there might be a way to authenticate the user via NTLM and Apache so they don't have to log in at all? I've installed the SSPI module for Apache 2.2 and added the relevant lines to httpd.conf but it doesn't appear that ReviewBoard is picking this up and carrying it through login. Is this not yet support or have I missed something? If anyone else has this working I'd be grateful to know what SSPI settings you have in httpd.conf. Many thanks :) Ian -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
api error - 1L is not XML serializable
hi, we're getting the error below when trying to access api url's (the repository listing in particular). we installed RB 1.5 on an ubuntu 10.04 server. Any clues as to what i did wrong? Thanks, Dan Exception thrown for user USERNAME at https://localhost/api/json/repositories/ 1L is not XML serializable Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/core/handlers/base.py, line 100, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/views/decorators/cache.py, line 70, in _wrapped_view_func add_never_cache_headers(response) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/utils/cache.py, line 116, in add_never_cache_headers patch_response_headers(response, cache_timeout=-1) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/utils/cache.py, line 105, in patch_response_headers response['ETag'] = '%s' % md5_constructor(response.content).hexdigest() File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 273, in _get_content content = adapter.encode(self.api_data, request=self.request) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 119, in encode self.__encode(o, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 136, in __encode self.__encode(value, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 164, in __encode return self.__encode(result, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 143, in __encode self.__encode(i, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 164, in __encode return self.__encode(result, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 136, in __encode self.__encode(value, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 162, in __encode raise TypeError(%r is not XML serializable % (o,)) TypeError: 1L is not XML serializable -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: api error - 1L is not XML serializable
silly follow up, but how do you apply that upgrade? thanks On Oct 6, 1:45 pm, Christian Hammond chip...@chipx86.com wrote: Upgrade to the latest Djblets nightly. This has been fixes but didn't make the release. We'll have a fix out soon. Christian On Wednesday, October 6, 2010, Dan castelha...@emigrant.com wrote: hi, we're getting the error below when trying to access api url's (the repository listing in particular). we installed RB 1.5 on an ubuntu 10.04 server. Any clues as to what i did wrong? Thanks, Dan Exception thrown for user USERNAME athttps://localhost/api/json/repositories/ 1L is not XML serializable Traceback (most recent call last): File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/core/handlers/base.py, line 100, in get_response response = callback(request, *callback_args, **callback_kwargs) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/views/decorators/cache.py, line 70, in _wrapped_view_func add_never_cache_headers(response) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/utils/cache.py, line 116, in add_never_cache_headers patch_response_headers(response, cache_timeout=-1) File /usr/local/lib/python2.6/dist-packages/Django-1.2.3-py2.6.egg/ django/utils/cache.py, line 105, in patch_response_headers response['ETag'] = '%s' % md5_constructor(response.content).hexdigest() File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 273, in _get_content content = adapter.encode(self.api_data, request=self.request) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 119, in encode self.__encode(o, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 136, in __encode self.__encode(value, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 164, in __encode return self.__encode(result, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 143, in __encode self.__encode(i, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 164, in __encode return self.__encode(result, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 136, in __encode self.__encode(value, *args, **kwargs) File /usr/local/lib/python2.6/dist-packages/Djblets-0.6.4-py2.6.egg/ djblets/webapi/core.py, line 162, in __encode raise TypeError(%r is not XML serializable % (o,)) TypeError: 1L is not XML serializable -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: keeping track of large number of files
turtle :) I can handle these by imposing rules on the developers, but having a tool guide the process is much much better. John (PS the explicit evidence is for the FDA and our internal quality folks but is applicable to any regulated environment, e.g. FAA, DOD, others?) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en FWIW, something like what's described here is the most frequently requested feature from folks at my workplace w.r.t. RB. If chipx86 and trowbrds are okay with exploring the idea, I'd be willing to help with design and implementation. -- ~Dan signature.asc Description: Digital signature
Re: post-review diff upload error on windows XP
Is your server running Linux? I've only tested Clearcase support using
a Windows RB server. Take a look at line 83 of clearcase.py:
http://github.com/reviewboard/reviewboard/blob/master/reviewboard/scmtools/clearcase.py
You're likely going to need to do some editing here. I don't know
anything about how Clearcase works on Linux, but I'm guessing the
assumption that all vobs are mounted under vobs/ might not be true...
Dan
On Aug 10, 6:47 am, Chetan chetan@gmail.com wrote:
As suggested by you i enabled logging to debug clearcase error. I
given the log information when i execute post-review for clearcase
below.
###
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Beginning parse of
diff, size = 1070
2010-08-10 03:39:32,064 - DEBUG - DiffParser.parse: Finished parsing
diff.
2010-08-10 03:39:32,065 - ERROR - Error uploading new diff: substring
not found
Traceback (most recent call last):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/webapi/json.py, line 1169, in new_diff
request.FILES.get('parent_diff_path'))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/reviews/forms.py, line 234, in create
history)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 63, in create
diff_file, basedir, check_existance=(not parent_diff_file)))
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/diffviewer/forms.py, line 149, in _process
_files
not tool.file_exists(filename, revision))):
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/core.py, line 68, in file_exists
self.get_file(path, revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 45, in get_fil
e
return self.client.cat_file(self.adjust_path(path), revision)
File /usr/lib/python2.5/site-packages/ReviewBoard-1.5rc1-py2.5.egg/
reviewboard/scmtools/clearcase.py, line 83, in adjust_
path
elem_path = elem_path[elem_path.rindex(vobs/)+5:]
ValueError: substring not found
###
On Aug 10, 11:15 am, Chetan chetan@gmail.com wrote:
I wanted execute svn diff recursively but found could not generate
one. But now I found if i run svn diff from the svn root directory it
handles all changes recursively.
On Aug 9, 12:24 pm, Christian Hammond chip...@chipx86.com wrote:
I'm not sure what you mean exactly. Is it not generating a diff with all
files recursively, or is there some reason why doing it recursively isn't
good enough?...
read more »
Are you using the post-review tool?
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Mon, Aug 9, 2010 at 12:21 AM, Chetan chetan@gmail.com wrote:
I got reviewboard working for subversion including https.
In svn diff we cannot generate recursive diff coz of which we may have
to generate folder specific diffs. Is there a way around this?
Thanks for the support.
On Aug 5, 11:55 am, Christian Hammond chip...@chipx86.com wrote:
As long as you have the $sitedir/data directory writable by the web
server's
user, you should be able to get https working. If you already had the
repository entry in there from RB 1.0.x, go back to that repository
and
save
it again. It should attempt to verify the certificate and then ask you
for
confirmation. If that data directory is writable, it will store it
there
and
it should just work from then on
read more »
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.reviewboard.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 4, 2010 at 10:28 PM, Chetan chetan@gmail.com wrote:
Thank a ton.
Review board with svn is working for me. svn project is using just
local protocol authentication like svn://prj and not on https. I
still
get errors for https projects.
What are the steps to configure reviewboard to use with https
configured svn projects?
Once i have completed svn configiration will start to work on
clearcase issue.
You asked me to enable logging to debug clearcase issue, wer shud i
enable it. Is it the same one under reviewboard- settinges-
logging -
enable logging option?
On Aug 4, 9:33 am, Christian Hammond chip...@chipx86.com wrote:
You'll need to use svn diff. TortoiseSVN's diffs aren't
compatible
read more »
I strongly recommend using our post-review tool (part of RBTools
Re: Post-commit review with Bazaar branches
There's no amount of options that will help you here since there's no support in post-review for bazaar at all :) If you're interested in adding support, you could start by making a copy of the MercurialClient in postreview.py. Bazaar ought to be extremely similar. Does uploading a diff via the web work correctly for Bazaar (I haven't tested Bazaar support)? You'll want to make sure that's in good shape before starting down this road. Dan On Aug 16, 4:47 am, Gustavo Narea gna...@tech.2degreesnetwork.com wrote: Anyone? :/ On Aug 11, 5:14 pm, Gustavo Narea gna...@tech.2degreesnetwork.com wrote: Hello, How can I use post-review with Bazaar? I know it's not supported out- of-the-box [1], but is there anything I could to to create review requests automatically for a Bazaar branch? I have tried the following: $ bzr diff -r 2037..2036 /tmp/2037-2036.diff $ /srv/dev/review-board/virtualenv/bin/post-review --diff-filename=/ tmp/2037-2036.diff --server=https://dev.example.org/reviews/-d-- repository-url=/srv/repositories/twod/trunk svn info /srv/repositories/twod/trunk git rev-parse --git-dir hg root No supported repository could be access at the supplied url. Should I pass more options so that it won't complaint? I didn't find the answer with --help. Basically, I just want to send review requests for every revision and I don't mind having to pass many arguments to post-review because of the lack of Bazaar support. Thanks in advance. [1]http://code.google.com/p/reviewboard/issues/detail?id=773 -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review with clearcase
Can you check the mailing lists and reviews.reviewboard.org? This
sounds like something that came up before. Unfortunately post-review
and Clearcase support are not in particularly good shape in the
released version. It really needs to have some newer patches merged in
to get things working more sensibly.
Dan
On Aug 9, 11:06 am, Shambhu shambhu.1...@gmail.com wrote:
Hi,
After making some minor modification to resolve below error,
post-review script is able to proceed further. But now it hangs at
diff upload. It is not showing any error or warning. I tried to upload
diff generated by post-review through webui, but it hangs there also
without any error msg, it just shows 'Loading' and nothing happens.
Here is the debug message where it stucks:
Looking for 'reviewboard.test.com /' cookie in C:\Documents and
Settings\shambhu\Application Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request on K for None
HTTP POSTing
tohttp://bnrpcwl0203.bnr.st.com/api/json/reviewrequests/new/:{'repository_path':
'K'}
Review request created
Uploading diff, size: 620
HTTP POSTing
tohttp://bnrpcwl0203.bnr.st.com/api/json/reviewrequests/16/diff/new/:{'basedir':
'K'}
And nothing happens after this. I checked server log and there also
nothing is mentioned. Here it is:
20:23:53 DEBUG DiffParser.parse: Beginning parse of diff, size =
621
20:23:53 DEBUG DiffParser.parse: Finished parsing diff.
20:24:41 DEBUG DiffParser.parse: Beginning parse of diff, size = 620
20:24:41 DEBUG DiffParser.parse: Finished parsing diff.
I didn't find any error or info in apache log also. Just to verify
whether i have correct directory permission of media directory, i
tried to upload screenshot, and that worked fine.
Please suggest how to fix this and let me know if more info needed. I
think i am just one step away from using it, and it annoying me. :(
Regards,
Shambhu.
On Aug 9, 12:41 pm, Shambhu shambhu.1...@gmail.com wrote:
Hi,
After checking with python-list i found that i was
misinterpreting the output error message. The actual problem is post-
review script is not able to access file c:\docume~1\shambhu
\locals~1\temp\4e0c6ccee4b4ee199cc18529c0bbf8c4 if this file is
already present if there is failure in previous run.
Now i am stuck again in function do_diff in post-review script. Here
is piece of code:
for filenam in (onam, mnam) :
if cpath.exists(filenam) and self.viewtype ==
dynamic:
debug(Dynamic view Type)
do_rem = False
fn = filenam
elif len(filenam) 254 or self.viewtype ==
snapshot:
debug(Snapshot View Type)
fn = self.get_filename_hash(filenam)
debug(FileName_Hash: %s % fn)
fn = cpath.join(tempfile.gettempdir(), fn)
debug(TempFileTempdir: %s % fn)
do_rem = True
fd = open(cpath.normpath(fn))
fdata = fd.readlines()
fd.close()
file_data.append(fdata)
# If the file was temp, it should be removed.
if do_rem:
os.remove(filenam)
Here i am getting error at last line os.remove(filenam), because
filenam contains version extended path name and hence it is not able
to access/remove windows command.
WindowsError: [Error 206] The filename or extension is too long: 'K:\
\SHAMBHU_XXX\\YY\\@@\\main\\2\\abcabcabc\\@@\\main\
\abcabcabc\\abcabcabc_r1\\xyzxyz\\1\\hello\\@@\\main\\abcabcabc\
\abcabcabc_r1\\xyzxyz\\1\\hello.c@@\\@@\\main\\abcabcabc\\abcabcabc_r1\
\xyzxyz\\xyzxyzxyz_1\\0'
Regards,
Shambhu.
On Aug 7, 3:43 pm, Shambhu shambhu.1...@gmail.com wrote:
Hi,
This time I tried post-review with checkedout file. I ran
command $post-review -d checkedout_Filename
But even with checkedout file it is failing. Here is trace log:
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.2.1alpha0.dev', 'console_scripts',
'post-review')()
File build\bdist.win32\egg\rbtools\postreview.py, line 2993, in
main
File build\bdist.win32\egg\rbtools\postreview.py, line 1041, in
diff
File build\bdist.win32\egg\rbtools\postreview.py, line 999, in
get_extended_namespace
WindowsError: [Error 5] Access is denied: 'c:\\docume~1\\shambhu\
\locals~1\\temp\\4e0c6ccee4b4ee199cc18529c0bbf8c4'
After looking into postreview.py, i found that it is failing at
os.unlink(tf) line. While executing os.unlink(tf), it is adding
additional backslash \ with the pathname and which is causing the
problem. I am able to access file 'c:\docume~1\shambhu\locals~1\temp
Re: Help with git configuration
Hi Yang, This actually brings up a good point. I don't think there currently is a 'better' solution. I hope Christian can perhaps chime in on this, since RB is using git itself. The conventional way to set this up is to configure the mirror url, but this assumes that the client fetch from a remote with the exact same path. This doesn't work well for a number of reasons since it might not even be cloned from the same server, or it might use implicit vs explicit ssh notation, or use a non-fqdn, etc. I think we need to address this somehow. On the post-review side, my thought was to add an option for .reviewboardrc to specify the 'repository url'. However, there clearly should be some improvement on the server side as well, as a fixed 'mirror' field just isn't good enough to comprehensively match a repository. Any thoughts on what we could do there? As for your second problem, post-review requires a non-bare repository as it tries to automatically determine the diff of your current work. You may want to try the revision-range option to explicitly set the revision range. I haven't confirmed that this will work in a bare repository, but it should be easy to make it if it doesn't. Dan On Aug 6, 5:48 pm, Yang Zhang yanghates...@gmail.com wrote: I'm trying to automate post-review to run on a git repository -- ideally on each commit (on the client side), but on each push (on the central repo) would do too if necessary. In both the following I ran git config reviewboard.urlhttps://dev/review/;. First I tried post-review on a client repo (also tried specifying --repository-url=/var/git/web.git, which is the local URL that the reviewboard web app knows): ~~~ $ post-review --revision-range=9405af7d9a75c17 03b88924021fc9f2677c4776b == HTTP Authentication Required Enter username and password for dev at dev Username: yang Password: There was an error creating this review request. The repository path ssh://dev/var/git/web.git is not in the list of known repositories on the server. Ask the administrator to add this repository to the Review Board server. For information on adding repositories, please readhttp://www.reviewboard.org/docs/manual/dev/admin/management/repositor... ~~~ I thought about trying to set up a mirror URL in the reviewboard web app, but the URL might look different to each client. On the server, the repository is headless, resulting in this error: ~~~ $ post-review Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] fatal: Not a git repository (or any of the parent directories): .git ~~~ After Googling I foundhttp://gitorious.org/reviewboard/rbtools/blobs/master/scripts/git-pos... but it's broken out of date. There are more hacks I can try (e.g. having the post-commit hook temporarily munge the remote origin URL, or having the post-receive hook clone the git repository so that it has a head, then post-review-ing that), but surely there's a better way. Thanks in advance for any hints. -- Yang Zhanghttp://yz.mit.edu/ -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Handling non-linear DVCS histories (git)
My general workflow is to create a topic branch tracking one of the official branches on a remote server and let post-review detect the merge base. This generates a diff between the last state of that branch and my changes. I don't use RB for merge reviews. It would be good if we got an update on the GSOC git project. I thought the students were required to show progress... If it doesn't go anywhere, we definitely need to add some better handling for more distributed workflows. Dan On Aug 10, 7:59 am, Stephen Gallagher step...@gallagherhome.com wrote: On 08/09/2010 02:32 PM, Yang Zhang wrote: I'm using reviewboard with git projects, and I'm interested in hearing how other folks are handling non-linear DVCS histories. Each commit may have one or two parents - for those with two, how does one generate a patch from that (if you do at all)? Thanks. I wrote a patch for git patchsets in post-review a long while ago:http://reviews.reviewboard.org/r/1472/ It got two ShipIt replies, but Christian opted not to push it upstream. I'm told there's a Google Summer of Code student working on improving the DVCS support, but I'm still using my patch for my project. Basically, my approach to git is to create a new branch from the upstream master and then cherry-pick commits onto it. Then I run my modified post-review command which auto-generates a separate review for each patch. It constructs the parent diff for each one after the first in the branch. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: post-review diff upload error on windows XP
The documentation and clearcase support in rbtools is rather outdated.
I believe Jan has an improvement so you don't need to use my cleartool
lsco hack among other things.
There are a large number of patches in the queue on
reviews.reviewboard.org but they don't appear to be going anywhere.
Nonetheless it would be better to start with these changes as a
baseline rather than debugging the existing broken code. Jan will need
to comment if he's interested in doing this. I can't do it easily
myself since RB doesn't upload full git patches right now...
Dan
On Jul 19, 8:06 am, Chetan chetan@gmail.com wrote:
Hello..
Do anyone have a hint on this issue? i have searched the forum but
could not find any solution.
On Jul 15, 11:44 am, Chetan chetan@gmail.com wrote:
Hello All,
I have facing problem in uploading the clearcase diff in review
request using post-review script.
command used: cleartool lsco -cview -me -recurse -short | sed s//
\//g | xargs post-review -d --diff-only --target-people=chetan.d --
summary=test2_by_chetan --description test2_by_chetan --submit-
as=admin --server=http://.xxx.net/xxx/;
When i use -n option i get the diff on the prompt.
Error are as below:
HTTP POSTing
tohttp://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/16/draft...{'description':
'VIEW: chetan.d_sdaf_2_int\nVIEWTYPE: dynamic\ntest2_by_chetan'}
Uploading diff, size: 1017
HTTP POSTing
tohttp://172.24.1.107/reviewboard_lgsi/api/json/reviewrequests/16/diff/...{'basedir':
'M:/'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {u'fields': {u'path': [u'substring not found']}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code':
105}}
Your review request still exists, but the diff is not attached.
Error uploading diff
The generated diff file was empty. This usually means no files were
modified in this change.
Try running with --output-diff and --debug for more information.
Request some help in getting this error fixed.
Thnks
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: remote Mercurial repo support?
On Thu, Jul 01, 2010 at 01:54:54PM -0700, Gordon Morehouse wrote: Thanks both of you. I see the patch has been added as of RBTools 0.2.1 alpha 0, which I'm now using. Might want to take a peek at http://code.google.com/p/reviewboard/issues/detail?id=1708 though ;) Clearly the Mercurial features still need ... more work ;) /me invokes patches welcome, runs away -- ~Dan -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en pgprCHIQKG3wD.pgp Description: PGP signature
Re: remote Mercurial repo support?
On Sat, Jun 26, 2010 at 09:17:48PM -0700, Christian Hammond wrote: Not bitter at all! ;) Sadly, this is what happens when $DAYJOB and real life get in the way for a little while. I'll be doing a new RBTools release with those fixes very soon. Objectively Awesome! I can relate wrt ye olde $DAYJOB. I speak for my coworkers when I say that the many hours you've sunk into ReviewBoard and RBTools are very much appreciated. Cheers and thanks again, -- ~Dan Christian On Saturday, June 26, 2010, Dan Buch daniel.b...@gmail.com wrote: On Fri, Jun 25, 2010 at 09:41:02AM -0700, Gordon Morehouse wrote: On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. ...Unbelievable. Banging my head for days over a single slash (and no documentation of the issue anywhere). Thank goodness there's a patch in. I've submitted a documentation bug about this: http://code.google.com/p/reviewboard/issues/detail?id=1699 My prior solution had been to mount the repo itself from our repo server via sshfs, but after putting the HTTPS URL back in minus the trailing slash it still worked. Thanks for that, because an automounted sshfs was not exactly the greatest 'solution.' If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Thanks! I will investigate that. Any idea if it will be accepted upstream? It has! It *only* took 3 months! ;-) http://reviews.reviewboard.org/r/1464/ I'm not bitter. I swear. When it will actually ship with canonical RBTools? not sure... chipx86 or trowbrds willing to weigh in? :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ~Dan -- -- Christian Hammond - chip...@chipx86.com Review Board - http://www.reviewboard.org VMware, Inc. - http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en pgp2JCf1X6JRU.pgp Description: PGP signature
Re: remote Mercurial repo support?
On Fri, Jun 25, 2010 at 09:41:02AM -0700, Gordon Morehouse wrote: On Jun 24, 9:12 pm, Dan Buch daniel.b...@gmail.com wrote: IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. ...Unbelievable. Banging my head for days over a single slash (and no documentation of the issue anywhere). Thank goodness there's a patch in. I've submitted a documentation bug about this: http://code.google.com/p/reviewboard/issues/detail?id=1699 My prior solution had been to mount the repo itself from our repo server via sshfs, but after putting the HTTPS URL back in minus the trailing slash it still worked. Thanks for that, because an automounted sshfs was not exactly the greatest 'solution.' If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Thanks! I will investigate that. Any idea if it will be accepted upstream? It has! It *only* took 3 months! ;-) http://reviews.reviewboard.org/r/1464/ I'm not bitter. I swear. When it will actually ship with canonical RBTools? not sure... chipx86 or trowbrds willing to weigh in? :) -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- ~Dan pgp8SHnjWClK9.pgp Description: PGP signature
Re: remote Mercurial repo support?
IIRC there's some naive logic in the remote Mercurial repo client inside Reviewboard that screws up the number/presence of some '/' chars. I think a recently accepted patch fixed the logic, but you can get it working with older versions of ReviewBoard by doing something like this: for the Path value: http://example.com/hgweb/AwesomeTown for the Mirror path value: http://example.com/hgweb/AwesomeTown/ And yes, it really is the trailing slash. No, this is not 1994. If you haven't already tried, I can warn you that the current public release of RBTools doesn't *actually* support plain ol' Mercurial usage, although it *does* have good support for hgsubversion. Another recently-accepted patch fixes this (for the most part,) and a dist which includes it is available here: http://github.com/meatballhat/rbtools/downloads Cheers, -- ~Dan On Thu, Jun 24, 2010 at 02:06:08PM -0700, Gordon Morehouse wrote: Hello, The manual page about repositories contains no information whatsoever about Mercurial. Is it possible to configure a remote Mercurial repo either via HTTP(S) or SSH, or does Review Board require disk access to the repository? If it's possible via HTTP, what is the path to use? The path to the human-browseable repo results in Review Board failing to apply diffs because it's attempting to apply them to HTML output from the browseable repository. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en pgpprfG3YMtVe.pgp Description: PGP signature
Re: post-review not working with ClearCase - RB1.5B2 on Windows
It would probably be useful to publish a branch on github since there are a lot of patches and the diff download on RB doesn't include the git patch header. We should probably update the docs too to at least indicate the instructions may be out of date until these get merged into rbtools master. Dan On Jun 11, 1:03 pm, Jan Koprowski jan.koprow...@gmail.com wrote: When I told this I meanhttp://www.reviewboard.org/docs/codebase/dev/getting-started/#getting... On Jun 11, 4:37 pm, Jan Koprowski jan.koprow...@gmail.com wrote: Read this. All what You need is download raw diff and use patch On Jun 11, 2:05 pm, Cássio Fernando Berra martel...@gmail.com wrote: Awesome, thanks Jan! Unfortunately I’ve no background in Python, so if you don’t mind, let me know how do I apply those patches. Thanks again! Martelo 2010/6/10 Jan Koprowski jan.koprow...@gmail.com Hi! I made some patches to ClearCase. Please look at patches http://reviews.reviewboard.org/users/jan.koprowski/Especiallythis onehttp://reviews.reviewboard.org/r/1505/. I don't know when this fixes will be put on RBTools repository. If You use ClearCase ClearQuest integration You can use http://reviews.reviewboard.org/r/1500/thisoptionto public changes. I use some CQPERL wrote wrapper around post-review which get informations from CQ and post-review to ReviewBoard. There is more patches to clearcase (almost all wrote for me). You must look them and choose what You need. On Jun 9, 9:32 pm, Martelo martel...@gmail.com wrote: What I've Done: win #01 (RB server) 1 - Set up a new dynamic view (just one vob mounted) in Z:/ drive 2 - Create a new Repository as follows: Name: RepoCC Path: Z:/ win #02 (Client) 1 - Install python 2.5 + SetupTools + DiffUtills + FindUtiils + sed + RBTools 2 - Set up a new dynamic view (same one vob mounted) in Z:/ drive 3 - Checkout one file. Change and save it 4 - Create a new file .reviewboardrc in the users appdata pointing to RB server 5 - Run cleartool lsco -cview -me -recurse -short | sed s//\//g | xargs post-review -- username=user --password=12345 The error is: --- --- There was an error creating this review request. The repository path /view/reviewboard.diffview/vobs/ is not in the list of known repositories on the server. --- --- How do I set what repository should be used??? What I've done wrong or missed? Thanks, Martelo. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Which Mercurial version to target?
Howdy all, I'm working on this patch: http://reviews.reviewboard.org/r/1464/ chipx86 recommended I post to the group about which version of Mercurial I should target. Thoughts? Cheers, -- ~Dan pgpjsInCwnJdI.pgp Description: PGP signature
Re: Syntax highlighting
I've added support for changing the syntax highlighting scheme, if that will help with your disappointment in the highlighting. It's working, but it needs some better integration for installation. Right now you have to hack up the pygments generated styles with a script. http://github.com/djs/reviewboard/tree/pygments For the Obj-C issue, RB is currently using get_lexer_for_filename, but there is also a guess_lexer API that presumably would yield better results... Dan On Apr 20, 3:41 pm, Christian Hammond chip...@chipx86.com wrote: Hi Tim, We use a Python module called Pygments (http://www.pygments.org/) for the syntax highlighting, so we basically support whatever they do. The lack of Obj-C highlighting is certainly an annoyance that I've dealt with too. It's due to Pygments giving preference to I think Matlab files or something, over Obj-C. This is something I'd love to see them fix. There's a chance we may get support down the road for adding customizable highlighting (as in, being able to say that this file extension will use that type of highlighter). You wouldn't be able to add new syntax highlighting rules with this, but it's something at least, and would fix the Obj-C situation. However, I think the person who was working on this support has been too busy to finish it up, so I'm not sure which release will end up with it. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Tue, Apr 20, 2010 at 12:33 PM, Tim Hollingsworth timhollingswo...@gmail.com wrote: Hello, Firstly I just started using Review Board and have had a very positive experience so far, thanks! Is there some place to find out what syntax highlighting is available? Is it pluggable or standardized? I'm using C++ and objective-c. The C++ has some highlighting, but not very meaningful - it colors comments and import statements differently but no real highlighting in the code. In objective-c there is not highlighting at all. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today athttp://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group athttp://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Strange ClearCase revision version path while making review
Unfortunately I don't think the original author monitors the mailing
list, so we'll need to do some experimentation on our own. I can try
to help, but I don't keep a Clearcase RB setup active so I can't
easily test things out.
Dan
On Mar 11, 1:10 am, Jan Koprowski jan.koprow...@gmail.com wrote:
Ok :) So question to authors.
How this should looks like?
On Mar 10, 10:26 pm, Dan Savilonis d...@n-cube.org wrote:
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it might think that is the
previous version. I don't really understand the logic used to find
previous revisions in ClearCaseClient methods, but it appears able to
generate this kind of path. I also remember the original review for
this change had screenshots of extended paths and an option to shorten
then, so he seemed to expect this kind of craziness.
Dan
On Mar 10, 12:33 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
Hi !
I'am back to testing reviewboard with clearcase. Now I see that
after post-review there is strange revision version path is send:
post-review -d index.wsgi --serverhttp://gklab-62-060/ svn info
git rev-parse --git-dir
cleartool pwv -short
repository info: Path: /view/reviewboard_scmtools/vobs/SCM_tools,
Base path: /view/reviewboard_scmtools/vobs/SCM_tools, Supports
changesets: False
cleartool desc -pre
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot
Looking for 'gklab-62-060 /' cookie in
/user/jkoprows/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://gklab-62-060/
Username: admin
Password: Logging in with username admin
HTTP POSTing
tohttp://gklab-62-060/api/json/accounts/login/:{'username': 'admin',
'password': '**'}
Logged in.
Attempting to create review request on
/view/reviewboard_scmtools/vobs/SCM_tools for None
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/new/:{'repository_path':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Review request created
Attempting to set field 'description' to 'reviewboard_scmtools
VIEWTYPE: dynamic
' for review request '3' HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/draft/set/:{'description':
'reviewboard_scmtools\nVIEWTYPE: dynamic\n'}
Uploading diff, size: 436
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/diff/new/:{'basedir':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['cat:
/view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/scripts/@@/ma
in/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8: No such file or
directory\n']}, 'stat': 'fail', 'err': {'msg': 'One or more fields
had errors', 'code': 105}}
Error uploading diff: One or more fields had errors (HTTP 200, API
Error 105)
Your review request still exists, but the diff is not attached.
part: /view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/
scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8 doesn't
have any sens. There should be only one version. What was happend?
I made dynamic view.
Checkout file
Make changes
Run post-review as You see below
Greetings From Poland!
--
Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Strange ClearCase revision version path while making review
I think Clearcase can be used in a way where that type of extended
path is valid. You should double check if you can open that file path
directly yourself and perhaps see why it might think that is the
previous version. I don't really understand the logic used to find
previous revisions in ClearCaseClient methods, but it appears able to
generate this kind of path. I also remember the original review for
this change had screenshots of extended paths and an option to shorten
then, so he seemed to expect this kind of craziness.
Dan
On Mar 10, 12:33 pm, Jan Koprowski jan.koprow...@gmail.com wrote:
Hi !
I'am back to testing reviewboard with clearcase. Now I see that
after post-review there is strange revision version path is send:
post-review -d index.wsgi --serverhttp://gklab-62-060/ svn info
git rev-parse --git-dir
cleartool pwv -short
repository info: Path: /view/reviewboard_scmtools/vobs/SCM_tools, Base
path: /view/reviewboard_scmtools/vobs/SCM_tools, Supports changesets:
False
cleartool desc -pre
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot/index.wsgi
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools
cleartool desc -fmt %Vn /view/reviewboard_scmtools/vobs/SCM_tools/scripts
cleartool desc -fmt %Vn
/view/reviewboard_scmtools/vobs/SCM_tools/scripts/ReleaseRobot
Looking for 'gklab-62-060 /' cookie in
/user/jkoprows/.post-review-cookies.txt
Cookie file loaded, but no cookie for this server
== Review Board Login Required
Enter username and password for Review Board athttp://gklab-62-060/
Username: admin
Password: Logging in with username admin
HTTP POSTing tohttp://gklab-62-060/api/json/accounts/login/:{'username':
'admin', 'password': '**'}
Logged in.
Attempting to create review request on
/view/reviewboard_scmtools/vobs/SCM_tools for None
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/new/:{'repository_path':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Review request created
Attempting to set field 'description' to 'reviewboard_scmtools
VIEWTYPE: dynamic
' for review request '3' HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/draft/set/:{'description':
'reviewboard_scmtools\nVIEWTYPE: dynamic\n'}
Uploading diff, size: 436
HTTP POSTing
tohttp://gklab-62-060/api/json/reviewrequests/3/diff/new/:{'basedir':
'/view/reviewboard_scmtools/vobs/SCM_tools'}
Got API Error 105 (HTTP code 200): One or more fields had errors
Error data: {'fields': {'path': ['cat:
/view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8:
No such file or directory\n']}, 'stat': 'fail', 'err': {'msg': 'One or
more fields had errors', 'code': 105}}
Error uploading diff: One or more fields had errors (HTTP 200, API
Error 105)
Your review request still exists, but the diff is not attached.
part: /view/reviewboard_scmtools/vobs/SCM_tools/SCM_tools/@@/main/6/
scripts/@@/main/6/ReleaseRobot/@@/main/3/index.wsgi/@@/main/8 doesn't
have any sens. There should be only one version. What was happend?
I made dynamic view.
Checkout file
Make changes
Run post-review as You see below
Greetings From Poland!
--
Jan Koprowski
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I would generalize Stephen's idea and just call it general support for distributed vcs workflow since RB isn't really built around that model and we're kind of stuffing it in after the fact. I'd also love to see performance improvements. I haven't done any real comparisons, but Rietveld and Gerrit just seem much more lightweight and snappy. Dan On Mar 9, 10:03 pm, Stephen Gallagher step...@gallagherhome.com wrote: It was discussed in another thread, but I think it would be great to improve the git support by handling patch-sets in post-review. The idea would be to support the following workflow: Create a branch based on the upstream master (the repository that RB is storing). Apply several patches on that branch, each dependent on the others. post-review should be capable of automatically generating a review (using --guess-summary and --guess-description) for every patch since the divergence from upstream, properly handling the linking to a parent diff. On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond chip...@chipx86.comwrote: Hi everyone, We've signed up again this year to take part in Google's Summer of Code. We're still awaiting acceptance, but want to brainstorm some ideas that students can work on. First of all, for those who aren't familiar with this, Google Summer of Code is a yearly program from Google where students from around the world are paid to work on open source projects. We participated as an organization last year and received some awesome features (some of which are going in to 1.5, some of which are going into 1.6). We're hoping for 3 or 4 students this year. We have a list of ideas ( http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like feedback on. If you have something you think would be generally useful to Review Board users that you'd like to see on this list and think would be a good project, please tell us! Also, if you're someone with a fair amount of experience with the Review Board codebase, let us know if you'd be interested in helping mentor a student this year. It's purely volunteer work, and can be time-consuming, but it's also an excellent way to help out the project and get some cool new features in the codebase. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Requesting ideas for Google Summer of Code
I think it's just a general performance comparison, though initial diff loading is particularly slow. I haven't profiled it, but if you compare loading reviews.reviewboard.org dashboard to review.source.android.com, or one of the diffs, the latter just feels much more instantaneous. I don't know how much of that is due to caching, network latency, javascript, server-side, etc but faster is always better :) So one part of this is just gathering some profiling data and comparing. On Mar 10, 4:37 pm, Christian Hammond chip...@chipx86.com wrote: Agreed on both parts. There's a bit more that Review Board does than Gerrit and Rietveld under the hood, but we should certainly strive to make things faster. Is there a specific area where Review Board feels slower to you? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com On Wed, Mar 10, 2010 at 1:32 PM, Dan Savilonis d...@n-cube.org wrote: I would generalize Stephen's idea and just call it general support for distributed vcs workflow since RB isn't really built around that model and we're kind of stuffing it in after the fact. I'd also love to see performance improvements. I haven't done any real comparisons, but Rietveld and Gerrit just seem much more lightweight and snappy. Dan On Mar 9, 10:03 pm, Stephen Gallagher step...@gallagherhome.com wrote: It was discussed in another thread, but I think it would be great to improve the git support by handling patch-sets in post-review. The idea would be to support the following workflow: Create a branch based on the upstream master (the repository that RB is storing). Apply several patches on that branch, each dependent on the others. post-review should be capable of automatically generating a review (using --guess-summary and --guess-description) for every patch since the divergence from upstream, properly handling the linking to a parent diff. On Tue, Mar 9, 2010 at 4:44 PM, Christian Hammond chip...@chipx86.com wrote: Hi everyone, We've signed up again this year to take part in Google's Summer of Code. We're still awaiting acceptance, but want to brainstorm some ideas that students can work on. First of all, for those who aren't familiar with this, Google Summer of Code is a yearly program from Google where students from around the world are paid to work on open source projects. We participated as an organization last year and received some awesome features (some of which are going in to 1.5, some of which are going into 1.6). We're hoping for 3 or 4 students this year. We have a list of ideas ( http://www.reviewboard.org/wiki/Summer_of_Code_Ideas/) that we'd like feedback on. If you have something you think would be generally useful to Review Board users that you'd like to see on this list and think would be a good project, please tell us! Also, if you're someone with a fair amount of experience with the Review Board codebase, let us know if you'd be interested in helping mentor a student this year. It's purely volunteer work, and can be time-consuming, but it's also an excellent way to help out the project and get some cool new features in the codebase. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.reviewboard.org VMware, Inc. -http://www.vmware.com -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com reviewboard%2bunsubscr...@googlegroups.comreviewboard%252bunsubscr...@goo glegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know athttp://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email toreviewboard+unsubscr...@googlegroups.comreviewboard%2bunsubscr...@googlegr oups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: reviewboard and clearcase problem
How do you have the server configured? The server needs to point to a
dynamic view where it will be able to access the file revisions
specified via extended path notation.
Dan
On Feb 17, 10:15 am, eeiths eei...@gmail.com wrote:
Ok, i got to spend a little time at this today.
looks like postreview has support for clearcase on windows without
cygwin.
Ans so the posted diff looks fine.
Sorry my mistake.
But thats not the case on the server side.
It fails on the file_exists and then trying to view the diff it
uses a different clearcaseclient than postreview.
Now the next question is there a way to plug in a postreview like
clearcaseclient on the server side that can fetch the proper versions
using cleartool
and thus apply the patch..?
sorry for my previous posts if they were a bit naive but I didnt get
much time
to study the code.
If i get time I might have a go at this.
On Feb 16, 10:55 am, eeiths eei...@gmail.com wrote:
i've got a bit further with this...it looks like the
tool.file_exists(filename, revision) on the server side fails
It tries to parse a file name form the clearcase extended name i.e.
the one with the versions and @@ char sequences
included in the path. e.g Y:/wran_cm_cms/@@/main/22/src/@@/main/3/com/
@@/main/1/..etc
There is a comment on the post-review.py
class ClearCaseClient(SCMClient):
A wrapper around the clearcase tool that fetches repository
information and generates compatible diffs.
This client assumes that cygwin is installed on windows.
I'm not sure then if the post-review worked as expected .
What exactly is cygwin's role in this process.
I do'nt have it installed ...do I need it.
I think I'm almost there ..!
Thanks
T
On Feb 12, 12:19 pm, eeiths eei...@gmail.com wrote:
I'm trying the post-review tool on windows env but i get the following
error ...wondering is this a clearcase issue or reviewboard.
is the a command to create the diff in isolation ..so I can see or
upload it via the GUI.
How can i debug the server side ..?
Any help appreciated .
C:\python25\Scriptscleartool lsco -me -cview -recurse -short X:\ |
sed s/\\/\//g | xargs post-review -d
--server=http://ev001f29a331be/ cleartool pwv -short
repository info: Path: X:/, Base path: X:/, Supports changesets: False
cleartool desc -pre X:\wran_cm_cms\PlannedAreaUpdator.java
cleartool desc -fmt %Vn X:\
cleartool desc -fmt %Vn X:\wran_cm_cms
:
:
cleartool get -to
c:\users\etomhar\appdata\local\temp\ae893516429051478f79222898e00140
X:\wran_cm_cms\PlannedAreaUpdator.java@@\main\at_ossrc_dev\at_ossrc_r7_inc70.26\4
Looking for 'ev001f29a331be /reviews/' cookie in
C:\Users\etomhar\Local Settings\Application
Data\.post-review-cookies.txt
Loaded valid cookie -- no login required
Attempting to create review request for None
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/new/:{'repository_path':
'X:/'}
Review request created
Attempting to set field 'description' to '** NONE **
VIEWTYPE: dynamic
' for review request '6' HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/set/:{'description':
'** NONE **\nVIEWTYPE: dynamic\n'}
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/draft/save/:{}
Review request draft saved
Uploading diff, size: 29
HTTP POSTing
tohttp://ev001f29a331be/reviews/api/json/reviewrequests/6/diff/new/:{'basedir':
'X:/'}
Error uploading diff: One or more fields had errors (105) {'fields':
{'path': ['The diff file is empty']}, 'stat': 'fail', 'err': {'msg': 'One
or more fields had errors', 'code': 105}}
Your review request still exists, but the diff is not attached.
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. I would contend that you can already do essentially what you are proposing, albeit not particularly elegantly. There is no way to group a set of reviews together currently. Also, see issue 1229 for some explanation on how RB currently handles diffs and why it doesn't fit perfectly with git patchsets. Dan On Feb 3, 4:36 pm, Stephen Gallagher karrde...@gmail.com wrote: Reviewboard is a great tool, but it's lacking in a couple places regarding Git. Right now, ReviewBoard only supports submitting a single patch generated from the head of a particular branch. In post-review, this means that it performs a 'git diff HEAD origin/master' and transmits the output to the server as a single patch. Unfortunately, this is not how git is used in many cases. Many developers (myself included) prefer to work in patchsets, where individual steps can be developed and tested separately. These patches will build on each other, and should be individually reviewable, but may not have any value separate from each other. What I am proposing is that is should be possible for a single review request to contain multiple, ordered patches. When performing a review, it should be possible to select any of these patches individually and review them. Behind the scenes, I envision reviewboard creating a Review-specific branch onto which it applies each of the patches in the set, so context information will be correctly available during the review. With this functionality in place, it would then be possible to modify the JSON API (and the post-review tool) to enable submitting a branch, complete with commit attribution and comments. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: RBTools Repository
http://github.com/reviewboard/rbtools You can submit reviews against rbtools in the same location as reviewboard reviews. Dan On Feb 4, 9:57 am, Stephen Gallagher karrde...@gmail.com wrote: Where can the RBTools source be checked out? I have a few contributions I'd like to make. Also, is there a repository set up in the test instance of ReviewBoard to submit RBTools patches? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: Git patchsets
See the Distributed Version Control Systems section of: http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ It's definitely available, and I believe it should work with git in 1.0.5.1, but TBH I've never run the stable version of RB. In a 3 patch series, for example, you'd submit the first patch directly, then the second patch with a parent diff of the first patch, then the third patch with a parent diff of the sum of the first two patches. Dan On Feb 4, 10:33 am, Stephen Gallagher karrde...@gmail.com wrote: On Feb 4, 10:20 am, Dan Savilonis d...@n-cube.org wrote: post-review can actually generate any arbitrary diff, not just a diff against HEAD. Make sure you're using the latest nightly build of rbtools for this functionality. It also supports a 'parent diff' mode where you can specify a parent of your diff set such that if you are submitting a series of patches not available in the server's repo, RB will still be able to understand how to generate the side-by-side diff. Can you point me at some documentation for the parent diff mode? I'd like to understand more about this. Is it available in the stable 1.0.5.1, or does it require the 1.1 alpha? -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
I don't know how similarly people use Clearcase, but I am fairly certain that the way my organization uses it is very non-standard. The typical review scenario would be to review modified code in a view, not checked in code. Fitting Clearcase's model into Reviewboard is a bit of square in round hole problem, though at the most basic level you can do the same thing that's done for other SCM systems: provide a base revision set and diff against it. Some of the stuff you mentioned is all possible, though it doesn't fit nicely into the ReviewBoard model as-is. Feel free to start up a thread in the dev mailing list and I'll help with whatever I can. However, I personally think your time might be better spent getting rid of Clearcase from your organization :) Christian, you'd likely need a mighty generous donor to get a Clearcase license. You'll also probably regret it once you try to set the beast up... On Jan 15, 8:02 pm, Sassan sassan...@verifone.com wrote: At least for ClearCase, most places have a standard naming convention for their views and/or config specs. Either way all it takes is for the client to prompt for and pass two view tags (strings) or config specs (small ascii files) in order for the web server to start the before and after views of the change locally on the server host and generate the diff... no file copy will be needed. This might be easier than dealing with verson extended pathnames. Dealing with directory changes (moving files from one place to another / renaming the files) is more difficult and we will need to use the ClearCase Object ID strings instead of file path names. On Jan 15, 5:51 pm, Chris Clark chris.cl...@ingres.com wrote: Thilo-Alexander Ginkel wrote: On Friday 15 January 2010 23:20:32 Sassan wrote: I am also thinking it might be a good idea to add a repository independent base functionality to the post-review script where it is handed the root directory of two source trees, before and after the change and it will then just compare the files and post a review. This way anyone with any source repository can just create the before and after soure trees outside RB and pass the roots of the source trees to the post-review script for posting. This won't work as Review Board needs to be able to access the respective SCM repository from the server-side to apply the posted diff to the base revision. For the server this is true. RE the client,http://reviews.reviewboard.org/r/1197/sortof does this. It allows any diff to be sent to reviewboard but it had better be a valid diff :-) Chris- Hide quoted text - - Show quoted text - -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: What is the status of ClearCase integration on Windows?
Hi Sassan,
The latest docs have some instructions on how to use post-review with
Clearcase. In fact, it's the only way to post a review with Clearcase.
http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/
I wrote it using some unix-ish examples, but I actually tested the
instructions under Windows. post-review's Clearcase support is fairly
crude, but it will work for reviewing modified code in a view that has
not been checked in.
Note that you actually need to modify post-review.py to make it work
in your environment, so I recommend pulling it from git and running
setup.py develop. If someone wants to just add these hard-coded values
as options, this won't be necessary anymore.
Dan
On Jan 14, 7:07 pm, Sassan sassan...@verifone.com wrote:
Does anyone know what is and is not currently supported for ClearCase
as an SCM tool on Windows?
For example I see instructions for posting commited code reviews using
post-review.exe under ClearCase section
inhttp://www.reviewboard.org/docs/manual/1.0/users/tools/post-review/
Does the Todo mean it is only on the wish list and not yet
implemented?
I also see a --label=LABEL under ClearCase options for post-
review.exe but I am not clear as to how a single label can designate a
diff of two distinct revisions.
I tried this anyway and I got::
Traceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module load_entry_point('RBTools==0.2beta2', 'console_scripts',
'post-review')()
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 2509, in main
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 954, in diff_label
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 947, in diff
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 811, in get_extended_namespace
File C:\Python25\lib\site-packages\rbtools-0.2beta2-py2.5.egg
\rbtools\postreview.py, line 790, in get_previous_version
ValueError: too many values to unpack
Do you know how I get to the postreview.py script inside the rbtools
egg to modify it?
On the other hand it is easy enough for me to generate the diffs
myself out of ClearCase, but is there any way for me post these
directly into the RB server ?
Maybe by passing them to post-review.exe but only to be posted to the
RB server ?
Thanks,
Sassan
--
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
Re: Clearcase Integration
Hi Nitin, There are some instructions in the documentation on setting up Review Board for ClearCase which you should start with, as well as various threads you can search for in the mailing list. However, I'd recommend you find someone who is comfortable with ClearCase and cleartool to set it up. The process is not as smooth or flexible as with other VCS. ClearCase does not fit well into the Review Board model and though there seem to be a number of users out there, I haven't seen a lot of feedback on how well it works for them. Dan On Dec 15, 3:06 am, Nitin GUpta nit...@gmail.com wrote: My company is using Clear Case for repository, I have very little understanding of clearcase. While searching i found that clearcase could be supported by Review Board. So we installed Review Board. But unable to configure the clearcase settings. Could anyone of you please help me to setup Review Board for Clearcase. -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en
Re: How to get post-review to work w/ http://reviews.reviewboard.org (to request reviews for RB changes)
You can run post-review with the -d option to see what it is trying to do. I suspect the git get_repository_info() check is failing. It will start by running: $ git rev-parse --git-dir and then a few more commands, which will all be listed with the -d option. Once you see where it fails, you can try running the commands manually. Dan On Nov 7, 2:30 pm, Pv p...@swooby.com wrote: I would like to request a review for a change to ReviewBoard and am absorbing the two wiki pages: http://www.reviewboard.org/docs/codebase/dev/getting-started/ http://www.reviewboard.org/docs/manual/dev/users/tools/post-review/ I'm a noob to git, but I pulled down a git enlistment and can run a dev server with my changes just fine. git diff --cached shows my changes. I set my git config reviewboard.url as follows: git config reviewboard.urlhttp://reviews.reviewboard.org The property takes fine (get config -l shows the value). I then post-review from the directory of my changes (webapi), and I get the following error: The current directory does not contain a checkout from a supported source code repository. I am running post-review v0.8: post-review --version post-review-script.py 0.8 This looks to be the one installed following this step: http://www.reviewboard.org/docs/codebase/dev/getting-started/#rbtools Any idea what my my malfunction is? Pv --~--~-~--~~~---~--~~ Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: git and diffs against branches
Lobby for http://reviews.reviewboard.org/r/1144/ to get committed and
you should be all set. :) For now, the only options are to use the web
form or specify a revision range manually.
Can you explain more about the error with the web form? You mentioned
git diff, and if you meant that literally, that would end up diffing
your working copy changes against whatever is your HEAD. If your HEAD
is not a revision in the remote repository, RB won't understand what
you are diffing against.
Dan
On Oct 23, 2:10 pm, Chris Clark chris.cl...@ingres.com wrote:
Whilst I use other distributed SCM's I've only just started with git (as
ReviewBoard uses it) and I think I'm having some trouble understanding
git (and reviewboard).
What I'd like to do is post for review changes/diffs against a branch
(not master/bleeding edge).
E.g.
git clone git://github.com/reviewboard/reviewboard.git
git checkout release-1.0.5.1
## hack on stuff, e.g. git add myfile
postreview.py --server=http://reviews.reviewboard.org/ --debug
Here is my output (note headrevs of rbtools and this is actually posted
explictly with -r1177):
svn info
git rev-parse --git-dir
git svn info
git svn --version
git config --get svn-remote.svn.url
git remote show origin
repository info: Path:
git://github.com/reviewboard/reviewboard.git, Base path: , Supports
changesets: False
git diff --no-color --full-index master
Looking for 'reviews.reviewboard.org /' cookie in
/home/ingres/.post-review-cookies.txt
Loaded valid cookie -- no login required
HTTP GETting api/json/reviewrequests/1177/
Uploading diff, size: 467617
HTTP POSTing
tohttp://reviews.reviewboard.org/api/json/reviewrequests/1177/diff/new/:{}
Error uploading diff: One or more fields had errors (105)
{u'fields': {u'path': [u'int argument required']}, u'stat':
u'fail', u'err': {u'msg': u'One or more fields had errors', u'code': 105}}
Your review request still exists, but the diff is not attached.
From the instructions near the end
ofhttp://www.reviewboard.org/docs/codebase/dev/getting-started/#getting...
(Posting Changes for Review) I get the impression this is not allowed?
The checkout is based on master but it is a different branch,
I guess this maybe a bug report too as it fails to post but does create
an empty review without printing out the review number. I ended up
browsinghttp://reviews.reviewboard.org/r/and looking at the top to
work out it had created one. Similar behavior if I just do a git diff
and try and use the web interface (i.e. get int arg required error).
Help!
Chris
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Apache hangs upon post-review
There was a problem like this with git support a long time ago. Can
you add use the diff only option and make sure the diff it generates
looks somewhat reasonable?
Dan
On Oct 23, 11:22 am, James jimspe...@gmail.com wrote:
Per an earlier thread I'm trying to get Review Board working on a
Windows machine
with ClearCase integration. I've gotten earlier road blocks and now
post-review runs
but it only gets so far and then the Apache server goes to 99% CPU
utilization and
post-review process hangs until I restart Apache server. Here is
output from a debug
post-review run. Any ideas?
snip HTTP POSTing
tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/set/:{'de
scription': 'sperry_releaseboard\nVIEWTYPE: dynamic\n'} HTTP POSTing
tohttp://ndm-xp-vm1/api/json/reviewrequests/4/draft/save/:{}
Review request draft saved
Uploading diff, size: 4635
HTTP POSTing tohttp://ndm-xp-vm1/api/json/reviewrequests/4/diff/new/:{'bas
edir': 's:\\'}
^C
S:\softdbTraceback (most recent call last):
File C:\Python25\Scripts\post-review-script.py, line 8, in
module
load_entry_point('rbtools==0.2beta2', 'console_scripts', 'post-
review')()
File build\bdist.win32\egg\rbtools\postreview.py, line 2522, in
main
File build\bdist.win32\egg\rbtools\postreview.py, line 2254, in
tempt_fate
File build\bdist.win32\egg\rbtools\postreview.py, line 463, in
upload_diff
File build\bdist.win32\egg\rbtools\postreview.py, line 575, in
api_post
File build\bdist.win32\egg\rbtools\postreview.py, line 556, in
http_post
File C:\Python25\lib\urllib2.py, line 124, in urlopen
return _opener.open(url, data)
File C:\Python25\lib\urllib2.py, line 381, in open
response = self._open(req, data)
File C:\Python25\lib\urllib2.py, line 399, in _open
'_open', req)
File C:\Python25\lib\urllib2.py, line 360, in _call_chain
result = func(*args)
File C:\Python25\lib\urllib2.py, line 1107, in http_open
return self.do_open(httplib.HTTPConnection, req)
File C:\Python25\lib\urllib2.py, line 1080, in do_open
r = h.getresponse()
--~--~-~--~~~---~--~~
Want to help the Review Board project? Donate today at
http://www.reviewboard.org/donate/
Happy user? Let us know at
http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
Re: Managing many review requests - Queued Workflow
I agree these could be useful features, but you have to be careful not to delve into the 'policy' realm which will make everyone despise the tool. We also use CodeCollaborator where I work and no one wants to use it for small reviews because it's a waste of time. It implements this ping-pong model to the extreme. Every time you finish the review, you mark it complete. If a single person makes another comment, all completed reviews are now uncompleted and every other reviewer must go back and mark the new comment as read, and sign off again. It might ultimately be most useful to add customizable user fields to reviews, instead of something like 'severity' which inevitably won't meet someone's needs. Dan On Oct 10, 7:53 pm, Christian Hammond chip...@chipx86.com wrote: Hi, Thanks for your feedback. Comments inline. On Tue, Oct 6, 2009 at 8:17 AM, Biking4Fun govo0...@gmail.com wrote: Only show requests that need your action - Tennis Ball model --- - Currently, a review stays in everyone's view until the requester has marked it submitted, etc. This tends to clutter one's view and makes it unclear what you need to act upon. It would be better if ReviewBoard implemented a tennis / ping pong model. What I mean by that is the review should only be in someone's view when they need to act on the review. Once the reviewer has commented and/or marked it Ship It, that is like hitting the ball back to the requester's court. It should no longer appear in that particular reviewer's view, because they have already acted upon it. It should now show up in the requester's view, because someone has commented and perhaps found a problem. There's a lot of value in this model, but we'd have to be careful with how we implement it. It's not always ideal to only see review requests you haven't commented on. There are times when I've only been able to review part of a very large change, made that review public, and then went back to it later to review more of it. In cases like these, I'd certainly want to see the review request still. I think what we could do is add a form of filtering to the dashboard, so you could show or hide review requests you've already looked at that haven't been updated since you last saw it. I don't know that anything needs to be done in the requester's view. A person generally only has a few review requests out at any given point in time. The above filter could just apply to this view as well if it's really needed. Feel free to file a feature request on this, so we can track it for future releases. Request Priority Some code changes are for future releases, a lower priority. Others are for a critical fix, or trying to make a code freeze deadline- a higher priority. There currently isn't a way for a requester to indicate that a particular review is important and needs to be looked at quickly. We've discussed adding some sort of severity indicator to a review request. Maybe we will eventually, but we're not set on it yet for a couple of reasons. 1) Severity levels can (and will) be abused. Everyone thinks their review request is important and unless you're working with Git or something similar, you're often blocked until your change goes in. If we give the ability to indicate low, medium and high priorities, then most people will probably pick high, in order to get their change looked at. Review requests with lower priorities will probably just end up being ignored, as there will always be higher priority review requests. In the end, this won't do anyone any good. 2) Severity levels set by the person posting the review request makes sense in corporate environments but often don't in open source projects. If someone is submitting a patch to Review Board, for instance, I really don't want them to decide that it's critical to get it in. It makes a lot more sense for myself as the developer to decide the priority of it. But then, that doesn't really help us any, because if we consider it critical to get in now, we should just review it now. 3) Severity levels don't communicate *why* it's important. Is it because there's a beta coming up that needs that change? Is it blocking the person? Is it blocking somebody else? Is it some emergency security fix? Build breakage? I don't think a severity level communicates enough here. 4) There's already a mechanism for communicating that something is important and needs to be done for some deadline or milestone. Put it in the summary. At VMware, for example, people will sometimes prefix a summary with [Beta 1 fix] and everyone working on the product will know that beta 1 is coming up and that that needs to take priority. No need for any special fields in the database, special UI, or anything. We may reconsider it sometime, but our design philosophy so far has
Re: Review Board 1.0.3 released
Yes, I realized this after I posted. I had accidentally pulled in a nightly build at one point due to my .pydistutils.cfg, but I had since downgraded to 1.0.1. Is there any way to get rid of the issue, or am I stuck with the warning forever? :) Dan On Sep 17, 3:44 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, Were you at any point running a 1.1 nightly or out of a Git tree? This is a field introduced in the 1.1 branch, so I don't know why you would see this in 1.0.x. It doesn't appear that the 1.0.x releases mention this at all in the codebase. If you went from a 1.1 to a 1.0.3, then you would definitely hit this error, as the field would be introduced and then removed without an evolution rule. Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Thu, Sep 17, 2009 at 8:52 AM, Dan Savilonis d...@n-cube.org wrote: I got the following error during the evolution: # rb-site upgrade /home/reviewboard_head Rebuilding directory structure Updating database. This may take a while. There are unapplied evolutions for diffviewer. Project signature has changed - an evolution is required /usr/lib/python2.5/site-packages/ReviewBoard-1.0.3-py2.5.egg/ reviewboard/scmtools/bzr.py:6: ImportWarning: Not importing directory '/usr/lib/python2.5/site-packages/bzrlib': missing __init__.py from bzrlib import bzrdir, revisionspec The stored evolutions do not completely resolve all model changes. Run `./manage.py evolve --hint` to see a suggestion for the changes required. The following are the changes that could not be resolved: In model scmtools.Repository: Field 'raw_file_url' has been deleted It appears to be working okay, though. Other thing I noticed is that the admin dashboard has CSS applied but appears very basic and has no images. Other pages look okay, and the same as they used to. Dan On Sep 16, 8:38 pm, Christian Hammond chip...@chipx86.com wrote: Last night's 1.0.2 release was pretty broken in two major ways. The web server configuration templates were no longer bundled in the package, due to a change in the structure of our code tree, and users using Django 1.0.2 would hit a bug, as we needed functionality only present in 1.0.3 and higher. The new 1.0.3 release should address these problems. If you've been bitten by 1.0.2 (our deepest apologies), please give this release a try and let us know how it works. Full release notes are available athttp:// www.review-board.org/docs/releasenotes/dev/reviewboard/1.0.3/ Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: ReviewBoard and Clearcase Integration
If you search the mailing list archives, you should see several threads on the subject, including one where I described my process of setting up Clearcase support and the limitations we've seen. Dan On Sep 17, 5:52 am, irshad irshada...@gmail.com wrote: Hi All, Review Board 1.0 Release Notes says that ClearCase support is provided as a new Features. But there is no documentation for ReviewBoard Installation with ClearCase as repository. Can anybody help me from where I can get the documentation when repository is ClearCase. Regards, Irshad --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: email settings for gmail SMTP?
We actually got it working. To make a long story short, I was using the wrong gmail smtp port (587 good, 465 bad). I'm putting our full thought process down just in case it might be useful. No proxy in our network. The host has a direct route out. Clients accessing it directly also have no machinery between it. on the email settings tab we got: server: smtp.gmail.com port: 465 username: rev...@dimagi.com password:blahblah use TLS is checked. When i ran the command (which is send_review_mail, not send_review_email as i have in error in the original post), here's the traceback: Traceback (most recent call last): File console, line 1, in module File /usr/local/lib/python2.6/dist-packages/ReviewBoard-1.0.1- py2.6.egg/reviewboard/reviews/email.py, line 114, in send_review_mail message.send() File /usr/local/lib/python2.6/dist-packages/Django-1.0.2_final- py2.6.egg/django/core/mail.py, line 271, in send return self.get_connection(fail_silently).send_messages([self]) File /usr/local/lib/python2.6/dist-packages/Django-1.0.2_final- py2.6.egg/django/core/mail.py, line 166, in send_messages new_conn_created = self.open() File /usr/local/lib/python2.6/dist-packages/Django-1.0.2_final- py2.6.egg/django/core/mail.py, line 131, in open local_hostname=DNS_NAME.get_fqdn()) File /usr/lib/python2.6/smtplib.py, line 239, in __init__ (code, msg) = self.connect(host, port) File /usr/lib/python2.6/smtplib.py, line 295, in connect self.sock = self._get_socket(host, port, self.timeout) File /usr/lib/python2.6/smtplib.py, line 273, in _get_socket return socket.create_connection((port, host), timeout) File /usr/lib/python2.6/socket.py, line 512, in create_connection raise error, msg error: [Errno 111] Connection refused Upon testing some more, I was actually able to get it working actually. Turns out port 465 was the culprit actually for the hanging loading on the web interface. My command line testing with the local_settings.py worked fine with port 587, and I didn't bother to test 465 from the command line, which reproduced a hanging state from the command line. So, I cleared the settings.EMAIL_* properties to let reviewboard work as native, and the web interface worked as expected. I then tried the command line email again, and was able to reproduce the same exception. How are the email settings loaded when an email is initiated from the web interface, as it differs from the command line. We are interested in this because we'd like some additional emails to go out on comments and such, and thought we might just run the email code ourselves via some signal or something. Thanks, Dan On Sep 8, 7:09 pm, Christian Hammond chip...@chipx86.com wrote: Hi Dan, Are you guys behind a proxy server, by any chance? I could see that potentially causing this to fail. What do you have listed in your e-mail settings for Review Board? Christian -- Christian Hammond - chip...@chipx86.com Review Board -http://www.review-board.org VMware, Inc. -http://www.vmware.com On Tue, Sep 8, 2009 at 8:13 AM, Dan Myung dmy...@dimagi.com wrote: I've got 1.0.1 setup on my Ubuntu box, and seem to have trouble with the email settings. I've input all the TLS settings for gmail smtp using a email in our hosted account, setup all the TLS and ports for it. However, whenever we try to submit/publish a new review request, the publish spinny just spins indefinitely. For kicks, I tried to run the email code from the command line: from reviewboard.reviews import email from reviewboard.reviews.models import * from django.contrib.auth.models import User #our admin user with a valid email address email.send_review_email(User.objects.all()[0], ReviewRequest.objects.all()[0], 'test email from command line','@emaildomain.com', [], 'reviews/review_request_email.txt') When I first ran it, it would fail because it would be trying to find email login/server information from the django settings, which is consistent with the EMAIL_* settings builtin to django (http:// docs.djangoproject.com/en/dev/ref/settings/#email-host) that the standard email API will try to call. Because those settings don't exist in the settings, it tries to default use localhost smtp which is not installed on the box. What confuses me is why the settings I just set in the review admin is completely ignored. Seeking a workaround, I manually set all the django EMAIL_* settings and the above command line code worked to send an email out. Once the settings were manually set, I went back to the web interface to try a new submit, but I got the same spinning Loading indicator that spins indefinitely. So far, we've never gotten a single review request submission ever to email out from the web interface. Any suggestions on how to get our email alerts going out? --~--~-~--~~~---~--~~ You received this message because you
email settings for gmail SMTP?
I've got 1.0.1 setup on my Ubuntu box, and seem to have trouble with the email settings. I've input all the TLS settings for gmail smtp using a email in our hosted account, setup all the TLS and ports for it. However, whenever we try to submit/publish a new review request, the publish spinny just spins indefinitely. For kicks, I tried to run the email code from the command line: from reviewboard.reviews import email from reviewboard.reviews.models import * from django.contrib.auth.models import User #our admin user with a valid email address email.send_review_email(User.objects.all()[0], ReviewRequest.objects.all()[0], 'test email from command line','m...@emaildomain.com', [], 'reviews/review_request_email.txt') When I first ran it, it would fail because it would be trying to find email login/server information from the django settings, which is consistent with the EMAIL_* settings builtin to django (http:// docs.djangoproject.com/en/dev/ref/settings/#email-host) that the standard email API will try to call. Because those settings don't exist in the settings, it tries to default use localhost smtp which is not installed on the box. What confuses me is why the settings I just set in the review admin is completely ignored. Seeking a workaround, I manually set all the django EMAIL_* settings and the above command line code worked to send an email out. Once the settings were manually set, I went back to the web interface to try a new submit, but I got the same spinning Loading indicator that spins indefinitely. So far, we've never gotten a single review request submission ever to email out from the web interface. Any suggestions on how to get our email alerts going out? --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: Review board automated with git
Hi Marek, Have you tried the parent diff option? This is designed for distributed version control and allows you to specify a base 'parent' diff, based off of a known revision in the remote repository on the reviewboard server, and the main diff can then be based off of the parent diff. There are some enhancements to git support in post-review under review now that will hopefully make it more flexible. Dan On Aug 28, 8:30 am, Marek slogt...@gmail.com wrote: More in detail, what we do is: 1. Write some code 2. Do the commit 3. Post a review to a system 4. push 5. Go to 1. and it works! but if we do: 1. Write some code 2. Do the commit 3. Post a review to a system 4. Go to 1 Then posting review for the second time will show sth like file not found in the repository. (both by post-review and via web). On 27 Sie, 12:16, Marek slogt...@gmail.com wrote: We are trying for a while now to introduce Board Review in our company. We are using git. We tried simple flow: 1. git commit 2. post-review but it only works when we do the push after every single commit. Doesn't make a lot of seans to us. (It seem that board review requires one commit back version of your files to apply the diff on) The next step would be to do automated review requests anyway. This first issue makes it impossible to work with simple git pre-commit hooks. Is there any other way? Is there any recommended way to use git with board review, ommiting one-push-per-commit problem. --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups reviewboard group. To post to this group, send email to reviewboard@googlegroups.com To unsubscribe from this group, send email to reviewboard+unsubscr...@googlegroups.com For more options, visit this group at http://groups.google.com/group/reviewboard?hl=en -~--~~~~--~~--~--~---
Re: cat: /usr/cc_storage/unix_STREAM/.../myjava.sql@@/main/STREAM/2: No such file or directory\n
From the documentation, it looks like ccrt has the same command line
interface as cleartool, so as I understand it the problem is just that
it is a snapshot view. We need to fix snapshot view functionality for
regular clearcase anyway, so it should be possible to support both
tools.
Dan
On Aug 18, 10:55 am, MiZhKa miz...@gmail.com wrote:
Hi, Dan,
CCRC is Java standalone GUI application to work with views based on
Eclipse platform. The installation doesn't contain cleartool. It's
completely different interface. Something about it locates here:
https://publib.boulder.ibm.com/infocenter/cchelp/v7r1m0/index.jsp?top...
http://www.samecs.com/how_do_i/ClearCase%20Remote%20Client%20and%20we...
CCRC doesn't require additional server. In our company the only
ClearCase server is used by developer. We use snapshot views. I've
discussed with other developers this topic and found out that CCRC can
be used for views created by cleartool and otherwise. CCRC is
alternative for cleartool.
Now we're testing approach when diff file are generated by
reviewboard, not by post-review.
Michael.
On Aug 18, 5:40 pm, Dan Savilonis d...@n-cube.org wrote:
The clearcase support relies on the extended path notation through the
clearcase filesystem and uses cleartool to query the view. I'd never
heard of CCRC before, but anything involving Clearcase and the word
'remote' can't possibly be a good thing. Do you have any more details
on how this tools works? Does it ultimately provide an interface to
cleartool, or is it a completely different, incompatible interface?
Christian: FYI, Clearcase doesn't really have any concept of a remote
server, akin to svn et al. You have your machine configured on a local
network with a clearcase server, and you have one or more 'VOBs' that
are basically repositories. You create a snapshot or dynamic 'view'
locally that presents the file tree in a directory. You can't really
just switch to another clearcase server, if there are multiple ones on
your network. And the only easy way to access different versions of a
file is through a weird extension to the filesystem where you can
specify the version as a path (e.g. foo/bar.c@@\main\branch\37)
Dan
On Aug 17, 10:57 am, MiZhKa miz...@gmail.com wrote:
Hi, Christian,
Recently I found out that a lot of developers use CCRC (ClearCase
Remote Client) and don't have cleartool. I'm sorry for long delay,
because I had limit of time to make Review Board be working with CCRC.
The only solution not required high redevelopment was creating page
for creating of review requests by repository and activity ID. Diff is
generated according to activity ID. Today the solution has been given
to developers. Now I'm waiting for first comments. After that, I will
post corrections.
Sincerely yours,
Michael,
On Aug 13, 10:26 pm, Christian Hammond chip...@chipx86.com wrote:
Yes, either upload it through the web UI or use post-review in an SVN
checkout (which is much easier).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Thu, Aug 13, 2009 at 8:17 AM, MiZhKa miz...@gmail.com wrote:
Now it works.
How can I send fix? To review.review-board.org?
Thank you,
On Aug 13, 8:06 am, MiZhKa miz...@gmail.com wrote:
Christian,
Thank you for your answer! I'll try to fix it. I think fix is easy,
Michael.
On 13 авг, 00:34, Christian Hammond chip...@chipx86.com wrote:
I think the person who contributed ClearCase support on the server
expected
that the repository would be locally checked out with the path
given.
We'll
certainly take a patch to use cleartool to fix this.
We don't have access to ClearCase, so we can't do a lot of testing
ourselves.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 12, 2009 at 10:56 AM, MiZhKa miz...@gmail.com wrote:
Hi,
I wonder how reviewboard fetches file versions from ClearCase.
Now I
have strange error from /api/json/reviewrequests/74/diff/new/:
{fields: {path: [cat: cat: /usr/cc_storage/unix_STREAM/.../
myjava.sql@@/main/STREAM/2: No such file or directory\n]},
stat:
fail, err: {msg: One or more fields had errors, code:
105}}
It seems that reviewboard (on server side) doesn't use
cleartool to
fetch version of file. This can be seen from
scmtools/clearcase.py:
class ClearCaseClient:
def __init__(self, path):
self.path = path
def cat_file(self, filename, revision):
p = subprocess.Popen(
['cat', filename
Re: cat: /usr/cc_storage/unix_STREAM/.../myjava.sql@@/main/STREAM/2: No such file or directory\n
The clearcase support relies on the extended path notation through the
clearcase filesystem and uses cleartool to query the view. I'd never
heard of CCRC before, but anything involving Clearcase and the word
'remote' can't possibly be a good thing. Do you have any more details
on how this tools works? Does it ultimately provide an interface to
cleartool, or is it a completely different, incompatible interface?
Christian: FYI, Clearcase doesn't really have any concept of a remote
server, akin to svn et al. You have your machine configured on a local
network with a clearcase server, and you have one or more 'VOBs' that
are basically repositories. You create a snapshot or dynamic 'view'
locally that presents the file tree in a directory. You can't really
just switch to another clearcase server, if there are multiple ones on
your network. And the only easy way to access different versions of a
file is through a weird extension to the filesystem where you can
specify the version as a path (e.g. foo/bar.c@@\main\branch\37)
Dan
On Aug 17, 10:57 am, MiZhKa miz...@gmail.com wrote:
Hi, Christian,
Recently I found out that a lot of developers use CCRC (ClearCase
Remote Client) and don't have cleartool. I'm sorry for long delay,
because I had limit of time to make Review Board be working with CCRC.
The only solution not required high redevelopment was creating page
for creating of review requests by repository and activity ID. Diff is
generated according to activity ID. Today the solution has been given
to developers. Now I'm waiting for first comments. After that, I will
post corrections.
Sincerely yours,
Michael,
On Aug 13, 10:26 pm, Christian Hammond chip...@chipx86.com wrote:
Yes, either upload it through the web UI or use post-review in an SVN
checkout (which is much easier).
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Thu, Aug 13, 2009 at 8:17 AM, MiZhKa miz...@gmail.com wrote:
Now it works.
How can I send fix? To review.review-board.org?
Thank you,
On Aug 13, 8:06 am, MiZhKa miz...@gmail.com wrote:
Christian,
Thank you for your answer! I'll try to fix it. I think fix is easy,
Michael.
On 13 авг, 00:34, Christian Hammond chip...@chipx86.com wrote:
I think the person who contributed ClearCase support on the server
expected
that the repository would be locally checked out with the path given.
We'll
certainly take a patch to use cleartool to fix this.
We don't have access to ClearCase, so we can't do a lot of testing
ourselves.
Christian
--
Christian Hammond - chip...@chipx86.com
Review Board -http://www.review-board.org
VMware, Inc. -http://www.vmware.com
On Wed, Aug 12, 2009 at 10:56 AM, MiZhKa miz...@gmail.com wrote:
Hi,
I wonder how reviewboard fetches file versions from ClearCase. Now I
have strange error from /api/json/reviewrequests/74/diff/new/:
{fields: {path: [cat: cat: /usr/cc_storage/unix_STREAM/.../
myjava.sql@@/main/STREAM/2: No such file or directory\n]}, stat:
fail, err: {msg: One or more fields had errors, code:
105}}
It seems that reviewboard (on server side) doesn't use cleartool to
fetch version of file. This can be seen from scmtools/clearcase.py:
class ClearCaseClient:
def __init__(self, path):
self.path = path
def cat_file(self, filename, revision):
p = subprocess.Popen(
['cat', filename],
stderr=subprocess.PIPE,
stdout=subprocess.PIPE,
close_fds=(os.name != 'nt')
)
contents = p.stdout.read()
errmsg = p.stderr.read()
failure = p.wait()
if not failure:
return contents
if errmsg.startswith(fatal: Not a valid object name):
raise FileNotFoundError(filename)
else:
raise SCMError(errmsg)
Is it mistake or my misunderstanding?
Thank you for your help!
--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups
reviewboard group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---
