Post-review report script erro

[Steve]

Hi All
When i use post-review post my code review quest to review board.
there have some error as follow:
==
D:\Tools\Review Board Set>post-review 237965 --server=http://it:8002/
sa/ --
username=steve --password=XXX --summary=Test  --description=test  -p -
d

>>> svn info
>>> p4 info
>>> repository info: Path: SSS-XXX.com:1666, Base path: None, Su
pports changesets: True
>>> Generating diff for changenum 237965
>>> p4 describe -s 237965
>>> Processing branch of //depot/Compliance/Main/Copy
Script/Copy.bat
>>> Writing "//depot/Compliance/Main/Copy Script/Copy.
bat" to "c:\docume~1\slin\locals~1\temp\tmphyez3-"
>>> p4 print -q "//depot/Compliance/Main/Copy Script/C
opy.bat"
>>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3 c:\docume~1\slin\locals~
1\temp\tmphyez3-
>>> Processing branch of //depot/Compliance/Main/Copy
Script/excludecopy.txt
>>> Writing "//depot/Compliance/Main/Copy Script/exclu
decopy.txt" to "c:\docume~1\slin\locals~1\temp\tmphyez3-"
>>> p4 print -q "//depot/Compliance/Main/Copy Script/e
xcludecopy.txt"
>>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3 c:\docume~1\slin\locals~
1\temp\tmphyez3-
>>> Processing branch of //depot/Compliance/Main/DCT/Bpm.dll
>>> Writing "//depot/Compliance/Main/DCT/Bpm.dll" to 
>>> "c:\docume~1\slin\locals~1\temp\tmphyez3-"
>>> p4 print -q //depot/Compliance/Main/DCT/Bpm.dll
>>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3 c:\docume~1\slin\locals~
1\temp\tmphyez3-
Traceback (most recent call last):
  File "post-review.py", line 2300, in 
  File "post-review.py", line 2271, in main
  File "post-review.py", line 1479, in diff
IndexError: list index out of range
==
who have suggestion for this error?

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Re: Post-review report script erro

[Steve]

Thanks. i had download the new version. This problem had solved.
thanks.

On Jul 28, 3:25 pm, Christian Hammond  wrote:
> If you grab the latest nightly for RBTools 
> (http://downloads.review-board.org/nightlies/), I believe this is fixed.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.review-board.org
> VMware, Inc. -http://www.vmware.com
>
>
>
> On Tue, Jul 28, 2009 at 12:15 AM, Steve  wrote:
>
> > Hi All
> > When i use post-review post my code review quest to review board.
> > there have some error as follow:
> > ==
> > D:\Tools\Review Board Set>post-review 237965 --server=http://it:8002/
> > sa/ <http://it:8002/%0Asa/> --
> > username=steve --password=XXX --summary=Test  --description=test  -p -
> > d
>
> > >>> svn info
> > >>> p4 info
> > >>> repository info: Path: SSS-XXX.com:1666, Base path: None, Su
> > pports changesets: True
> > >>> Generating diff for changenum 237965
> > >>> p4 describe -s 237965
> > >>> Processing branch of //depot/Compliance/Main/Copy
> > Script/Copy.bat
> > >>> Writing "//depot/Compliance/Main/Copy Script/Copy.
> > bat" to "c:\docume~1\slin\locals~1\temp\tmphyez3-"
> > >>> p4 print -q "//depot/Compliance/Main/Copy Script/C
> > opy.bat"
> > >>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3
> > c:\docume~1\slin\locals~
> > 1\temp\tmphyez3-
> > >>> Processing branch of //depot/Compliance/Main/Copy
> > Script/excludecopy.txt
> > >>> Writing "//depot/Compliance/Main/Copy Script/exclu
> > decopy.txt" to "c:\docume~1\slin\locals~1\temp\tmphyez3-"
> > >>> p4 print -q "//depot/Compliance/Main/Copy Script/e
> > xcludecopy.txt"
> > >>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3
> > c:\docume~1\slin\locals~
> > 1\temp\tmphyez3-
> > >>> Processing branch of //depot/Compliance/Main/DCT/Bpm.dll
> > >>> Writing "//depot/Compliance/Main/DCT/Bpm.dll" to
> > "c:\docume~1\slin\locals~1\temp\tmphyez3-"
> > >>> p4 print -q //depot/Compliance/Main/DCT/Bpm.dll
> > >>> diff -urNp c:\docume~1\slin\locals~1\temp\tmpxezja3
> > c:\docume~1\slin\locals~
> > 1\temp\tmphyez3-
> > Traceback (most recent call last):
> >  File "post-review.py", line 2300, in 
> >  File "post-review.py", line 2271, in main
> >  File "post-review.py", line 1479, in diff
> > IndexError: list index out of range
> > ==
> > who have suggestion for this error?- Hide quoted text -
>
> - Show quoted text -

--~--~-~--~~~---~--~~
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To post to this group, send email to reviewboard@googlegroups.com
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
-~--~~~~--~~--~--~---

Upgrading from 1.0.8 - rb-site upgrade evolution errors

[Steve]

I have reviewboard 1.0.8 running and I'm trying to move to 1.5.5. I
installed reviewboard 1.5.5 on the new CentOS 5 box, and then imported
the data from the 1.0.8 mysql database. After importing the data, I
ran rb-site upgrade:

# rb-site  upgrade /var/www/reviewboard
Rebuilding directory structure
Updating database. This may take a while.
Upgrading Review Board from 1.0.8 to 1.5.5
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Project signature has changed - an evolution is required
No fixtures found.
/usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-x86_64.egg/
Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This
application uses RandomPool, which is BROKEN in older releases.
See http://www.pycrypto.org/randpool-broken
Error: Error applying evolution: (1050, "Table
'reviews_defaultreviewer_repository' already exists")

To troubleshoot, I ran rb-site manage:

# rb-site manage /var/www/reviewboard evolve -- --hint
#- Evolution for diffviewer
from django_evolution.mutations import *
from django.db import models

MUTATIONS = [
AddField('DiffSet', 'basedir', models.CharField, initial=u'',
max_length=256),
AddField('FileDiff', 'status', models.CharField, initial=<>, max_length=1)
]
#--
#- Evolution for reviews
from django_evolution.mutations import *
from django.db import models

MUTATIONS = [
AddField('DefaultReviewer', 'repository', models.ManyToManyField,
related_model='scmtools.Repository'),
ChangeField('ReviewRequest', 'repository', initial=None,
null=True)
]
#--
#- Evolution for scmtools
from django_evolution.mutations import *
from django.db import models

MUTATIONS = [
AddField('Repository', 'visible', models.BooleanField,
initial=True),
AddField('Repository', 'raw_file_url', models.CharField,
initial='', max_length=255),
ChangeField('Repository', 'path', initial=None, max_length=255),
ChangeField('Repository', 'mirror_path', initial=None,
max_length=255)
]
#--
Trial evolution successful.
Run './manage.py evolve --hint --execute' to apply evolution.


Also, I see these evolutions in admin/db/django_evolution/evolution:


Evolution
Evolution filediff_filenames_1024_chars, applied to diffviewer
Evolution shipit_count, applied to reviews
Evolution last_review_timestamp, applied to reviews
Evolution bugzilla_url_charfield, applied to scmtools
    Evolution change_descriptions, applied to reviews
Evolution add_parent_diffs, applied to diffviewer
6 evolutions

I don't have a real good understanding of how evolutions work, so I'm
not sure what to try next.

--
-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Upgrading from 1.0.8 - rb-site upgrade evolution errors

[Steve]

That was it. I dropped the database, re-imported the 1.0.8 data and
then the rb-site upgrade succeeded.

Thanks!

--
-- Steve


On Mar 29, 11:48 am, Christian Hammond  wrote:
> Hi,
>
> When you say you installed and imported the data, did you first create a
> database with 1.5.5 and then try copying over the database? It looks like
> the database schema you're trying to evolve is actually 1.5.5, but with a
> database evolution history from 1.0.8. You need to wipe the database, copy
> over the entire database from 1.0.8 in its entirety (without anything
> generated yet from 1.5.5) and then do the upgrade.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
>
>
>
>
>
>
> On Tue, Mar 29, 2011 at 8:30 AM, Steve  wrote:
> > I have reviewboard 1.0.8 running and I'm trying to move to 1.5.5. I
> > installed reviewboard 1.5.5 on the new CentOS 5 box, and then imported
> > the data from the 1.0.8 mysql database. After importing the data, I
> > ran rb-site upgrade:
>
> > # rb-site  upgrade /var/www/reviewboard
> > Rebuilding directory structure
> > Updating database. This may take a while.
> > Upgrading Review Board from 1.0.8 to 1.5.5
> > There are unapplied evolutions for diffviewer.
> > There are unapplied evolutions for reviews.
> > There are unapplied evolutions for scmtools.
> > Project signature has changed - an evolution is required
> > No fixtures found.
> > /usr/lib/python2.4/site-packages/pycrypto-2.3-py2.4-linux-x86_64.egg/
> > Crypto/Util/randpool.py:40: RandomPool_DeprecationWarning: This
> > application uses RandomPool, which is BROKEN in older releases.
> > Seehttp://www.pycrypto.org/randpool-broken
> > Error: Error applying evolution: (1050, "Table
> > 'reviews_defaultreviewer_repository' already exists")
>
> > To troubleshoot, I ran rb-site manage:
>
> > # rb-site manage /var/www/reviewboard evolve -- --hint
> > #- Evolution for diffviewer
> > from django_evolution.mutations import *
> > from django.db import models
>
> > MUTATIONS = [
> >    AddField('DiffSet', 'basedir', models.CharField, initial=u'',
> > max_length=256),
> >    AddField('FileDiff', 'status', models.CharField, initial=< > VALUE REQUIRED>>, max_length=1)
> > ]
> > #--
> > #- Evolution for reviews
> > from django_evolution.mutations import *
> > from django.db import models
>
> > MUTATIONS = [
> >    AddField('DefaultReviewer', 'repository', models.ManyToManyField,
> > related_model='scmtools.Repository'),
> >    ChangeField('ReviewRequest', 'repository', initial=None,
> > null=True)
> > ]
> > #--
> > #- Evolution for scmtools
> > from django_evolution.mutations import *
> > from django.db import models
>
> > MUTATIONS = [
> >    AddField('Repository', 'visible', models.BooleanField,
> > initial=True),
> >    AddField('Repository', 'raw_file_url', models.CharField,
> > initial='', max_length=255),
> >    ChangeField('Repository', 'path', initial=None, max_length=255),
> >    ChangeField('Repository', 'mirror_path', initial=None,
> > max_length=255)
> > ]
> > #--
> > Trial evolution successful.
> > Run './manage.py evolve --hint --execute' to apply evolution.
>
> > Also, I see these evolutions in admin/db/django_evolution/evolution:
>
> > Evolution
> >        Evolution filediff_filenames_1024_chars, applied to diffviewer
> >        Evolution shipit_count, applied to reviews
> >        Evolution last_review_timestamp, applied to reviews
> >        Evolution bugzilla_url_charfield, applied to scmtools
> >        Evolution change_descriptions, applied to reviews
> >        Evolution add_parent_diffs, applied to diffviewer
> > 6 evolutions
>
> > I don't have a real good understanding of how evolutions work, so I'm
> > not sure what to try next.
>
> > --
> > -- Steve
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Mod_python error with brand new RB 1.6 installation

[Steve]

I have a new CentOS 5.6 box on which I've installed RB 1.6.  When I
try to access the site for the first time, I get this error:

Mod_python error: "PythonHandler django.core.handlers.modpython"

Traceback (most recent call last):

  File "/usr/lib64/python2.4/site-packages/mod_python/apache.py", line
299, in HandlerDispatch
result = object(req)

  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/handlers/modpython.py", line 213, in handler
return ModPythonHandler()(req)

  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/handlers/modpython.py", line 174, in __call__
self.load_middleware()

  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/handlers/base.py", line 47, in load_middleware
raise exceptions.ImproperlyConfigured('Error importing middleware
%s: "%s"' % (mw_module, e))

ImproperlyConfigured: Error importing middleware
reviewboard.admin.middleware: "cannot import name
get_registered_auth_backends"


My current configuration is:

- Python 2.4.3
- MySQL 5.0.77
- Apache 2
- mod_python-3.2.8-3.1.x86_64
- patch 2.5.4
- python-devel-2.4.3-44.el5
- MySQL-python-1.2.1-1.x86_64 base, then upgraded to
MySQL_python-1.2.3


Do I need a newer mod_python?  If not, can someone suggest what is
ImproperlyConfigured?

Thanks!

-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

I'm thinking it might be better for me to install RB 1.5.5 via yum.
Assuming that goes well, I'd then have the option of upgrading to 1.6
using easy_install.


On Sep 9, 8:27 am, Steve  wrote:
> I have a new CentOS 5.6 box on which I've installed RB 1.6.  When I
> try to access the site for the first time, I get this error:
>
> Mod_python error: "PythonHandler django.core.handlers.modpython"
>
> Traceback (most recent call last):
>
>   File "/usr/lib64/python2.4/site-packages/mod_python/apache.py", line
> 299, in HandlerDispatch
>     result = object(req)
>
>   File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> core/handlers/modpython.py", line 213, in handler
>     return ModPythonHandler()(req)
>
>   File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> core/handlers/modpython.py", line 174, in __call__
>     self.load_middleware()
>
>   File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> core/handlers/base.py", line 47, in load_middleware
>     raise exceptions.ImproperlyConfigured('Error importing middleware
> %s: "%s"' % (mw_module, e))
>
> ImproperlyConfigured: Error importing middleware
> reviewboard.admin.middleware: "cannot import name
> get_registered_auth_backends"
>
> My current configuration is:
>
> - Python 2.4.3
> - MySQL 5.0.77
> - Apache 2
> - mod_python-3.2.8-3.1.x86_64
> - patch 2.5.4
> - python-devel-2.4.3-44.el5
> - MySQL-python-1.2.1-1.x86_64 base, then upgraded to
> MySQL_python-1.2.3
>
> Do I need a newer mod_python?  If not, can someone suggest what is
> ImproperlyConfigured?
>
> Thanks!
>
> -- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

Your use of the word installed suggest where I may have gone wrong.  I
have RB 1.0.9  installed on another machine in production.  The goal
here was to migrate that over to this machine.  So I never  ran rb-
site install, I just installed all the software and then untar'ed the
old site in place.  Maybe that's the source of my problem.

Here's the output of the commands you gave me:

$ rb-site manage /var/www/reviewboard shell
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/
__init__.py:19: DeprecationWarning: settings.DATABASE_* is deprecated;
use settings.DATABASES instead.
  DeprecationWarning
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/
__init__.py:60: DeprecationWarning: Short names for ENGINE in database
configurations are deprecated. Prepend default.ENGINE with
'django.db.backends.'
  DeprecationWarning
Python 2.4.3 (#1, May  5 2011, 16:39:10)
[GCC 4.1.2 20080704 (Red Hat 4.1.2-50)] on linux2
Type "help", "copyright", "credits" or "license" for more information.
(InteractiveConsole)
>>> import reviewboard
>>> print reviewboard.VERSION
(1, 6, 0, 0, 'final', 0, True)
>>> from reviewboard.admin.middleware import get_registered_auth_backends
Traceback (most recent call last):
  File "", line 1, in ?
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/admin/middleware.py", line 21, in ?
from reviewboard.admin.siteconfig import load_site_config
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/admin/siteconfig.py", line 43, in ?
from reviewboard.accounts.backends import
get_registered_auth_backends
ImportError: cannot import name get_registered_auth_backends


--Steve


On Sep 9, 11:11 am, Christian Hammond  wrote:
> This sounds like Review Board may not have been properly installed.
>
> Try running: rb-site manage /path/to/site shell
>
> And then:
>
>     import reviewboard
>     print reviewboard.VERSION
>     from reviewboard.admin.middleware import get_registered_auth_backends
>
> And paste the results
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Fri, Sep 9, 2011 at 8:27 AM, Steve  wrote:
> > I have a new CentOS 5.6 box on which I've installed RB 1.6.  When I
> > try to access the site for the first time, I get this error:
>
> > Mod_python error: "PythonHandler django.core.handlers.modpython"
>
> > Traceback (most recent call last):
>
> >  File "/usr/lib64/python2.4/site-packages/mod_python/apache.py", line
> > 299, in HandlerDispatch
> >    result = object(req)
>
> >  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> > core/handlers/modpython.py", line 213, in handler
> >    return ModPythonHandler()(req)
>
> >  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> > core/handlers/modpython.py", line 174, in __call__
> >    self.load_middleware()
>
> >  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
> > core/handlers/base.py", line 47, in load_middleware
> >    raise exceptions.ImproperlyConfigured('Error importing middleware
> > %s: "%s"' % (mw_module, e))
>
> > ImproperlyConfigured: Error importing middleware
> > reviewboard.admin.middleware: "cannot import name
> > get_registered_auth_backends"
>
> > My current configuration is:
>
> > - Python 2.4.3
> > - MySQL 5.0.77
> > - Apache 2
> > - mod_python-3.2.8-3.1.x86_64
> > - patch 2.5.4
> > - python-devel-2.4.3-44.el5
> > - MySQL-python-1.2.1-1.x86_64 base, then upgraded to
> > MySQL_python-1.2.3
>
> > Do I need a newer mod_python?  If not, can someone suggest what is
> > ImproperlyConfigured?
>
> > Thanks!
>
> > -- Steve
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

I didn't run upgrade on it yet - I just wanted to see if I could
access the site to make sure my config settings were right.  Here's
what I see when I run the commands below:

>>> from reviewboard.accounts import backends
>>> print backends.__file__
/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/reviewboard/
accounts/backends.py
>>> print backends.get_registered_auth_backends
Traceback (most recent call last):
  File "", line 1, in ?
AttributeError: 'module' object has no attribute
'get_registered_auth_backends'
>>> print backends.get_registered_auth_backends
Traceback (most recent call last):
  File "", line 1, in ?
AttributeError: 'module' object has no attribute
'get_registered_auth_backends'


Since you said 'so long as you did rb-site upgrade', I gave that a try
next and got:

$ rb-site upgrade /var/www/reviewboard
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/
__init__.py:19: DeprecationWarning: settings.DATABASE_* is deprecated;
use settings.DATABASES instead.
  DeprecationWarning
/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/db/
__init__.py:60: DeprecationWarning: Short names for ENGINE in database
configurations are deprecated. Prepend default.ENGINE with
'django.db.backends.'
  DeprecationWarning
Rebuilding directory structure
Upgrading site settings_local.py
Updating database. This may take a while.

[!] Unable to execute the manager command syncdb: cannot import name
get_registered_auth_backends
Registering new SCM Tool Plastic SCM
(reviewboard.scmtools.plastic.PlasticTool) in database
Traceback (most recent call last):
  File "/usr/bin/rb-site", line 7, in ?
sys.exit(
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/cmdline/rbsite.py", line 1747, in main
command.run()
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/cmdline/rbsite.py", line 1645, in run
site.migrate_database()
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/cmdline/rbsite.py", line 353, in migrate_database
self.run_manage_command("evolve", ["--noinput", "--execute"])
  File "/usr/lib/python2.4/site-packages/ReviewBoard-1.6-py2.4.egg/
reviewboard/cmdline/rbsite.py", line 472, in run_manage_command
execute_manager(reviewboard.settings, [__file__, cmd] + params)
  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/management/__init__.py", line 438, in execute_manager
utility.execute()
  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/management/__init__.py", line 379, in execute
self.fetch_command(subcommand).run_from_argv(self.argv)
  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/management/base.py", line 191, in run_from_argv
self.execute(*args, **options.__dict__)
  File "/usr/lib/python2.4/site-packages/Django-1.3-py2.4.egg/django/
core/management/base.py", line 220, in execute
output = self.handle(*args, **options)
  File "/usr/lib/python2.4/site-packages/django_evolution-0.6.5-
py2.4.egg/django_evolution/management/commands/evolve.py", line 60, in
handle
self.evolve(*app_labels, **options)
  File "/usr/lib/python2.4/site-packages/django_evolution-0.6.5-
py2.4.egg/django_evolution/management/commands/evolve.py", line 140,
in evolve
database))
  File "/usr/lib/python2.4/site-packages/django_evolution-0.6.5-
py2.4.egg/django_evolution/mutations.py", line 418, in mutate
return self.add_column(app_label, proj_sig, database)
  File "/usr/lib/python2.4/site-packages/django_evolution-0.6.5-
py2.4.egg/django_evolution/mutations.py", line 426, in add_column
self.field_attrs, model)
  File "/usr/lib/python2.4/site-packages/django_evolution-0.6.5-
py2.4.egg/django_evolution/mutations.py", line 33, in create_field
related_model_sig = proj_sig[related_app_name][related_model_name]
KeyError: 'site'

I notice 'upgrade' ported my settings_local.py file, so skipping that
step was definitely not a good idea.  It appears I've made quite a
mess of things!  I have a backup of my site-packages from before I ran
easy_install ReviewBoard so if need by, I can start over.


On Sep 9, 2:04 pm, Christian Hammond  wrote:
> Untarring the site should be fine, so long as you did a 'rb-site upgrade' on
> it.
>
> This is strange. It's definitely using RB 1.6, but somehow it's failing to
> import that function. This certainly seems like an issue local to your
> setup, so we'll need to tack it down. Run the shell again and do:
>
>     from reviewboard.accounts import backends
>     print backends.__file__
>     print back

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

On Sep 9, 3:35 pm, Christian Hammond  wrote:
> Can you attach that backends.py file? Something seems very fishy.

I'm using a customized backends.py file. Maybe it's incompatible with
1.6?  I successfully set up a 1.5 installation several months ago
using the same configuration.  Here's the backend:

= backends.py ==

from django.conf import settings
from django.contrib.auth.models import User, Permission,
check_password, Group, UserManager
from djblets.util.misc import get_object_or_none
import crypt
import nis
import ldap
import P4

class NISBackend:
"""
Authenticate against a user on an NIS server.
"""

def authenticate(self, username, password):
try:
passwd = nis.match(username, 'passwd').split(':')
original_crypted = passwd[1]
new_crypted = crypt.crypt(password, original_crypted[:2])

if original_crypted == new_crypted:
return self.get_or_create_user(username, passwd)
except nis.error:
# FIXME I'm not sure under what situations this would fail
(maybe if
# their NIS server is down), but it'd be nice to inform
the user.
pass

def get_or_create_user(self, username, passwd=None):
try:
user = User.objects.get(username=username)
except User.DoesNotExist:
try:
if not passwd:
passwd = nis.match(username, 'passwd').split(':')

names = passwd[4].split(' ', 1)
first_name = names[0]
last_name = None
if len(names) > 1:
  last_name = names[1]

email = u'%s@%s' % (username,
settings.NIS_EMAIL_DOMAIN)

user = User(username=username,
password='',
first_name=first_name,
last_name=last_name or '',
email=email)
user.is_staff = False
user.is_superuser = False
user.save()
except nis.error:
pass
return user

def get_user(self, user_id):
return get_object_or_none(User, pk=user_id)


class LDAPBackend:
"""
Authenticate against a user on an LDAP server.
"""

def authenticate(self, username, password):
try:
import ldap
ldapo = ldap.initialize(settings.LDAP_URI)
ldapo.set_option(ldap.OPT_PROTOCOL_VERSION, 3)
if settings.LDAP_TLS:
ldapo.start_tls_s()
ldapo.simple_bind_s(settings.LDAP_UID_MASK % username,
password)

return self.get_or_create_user(username)

except ImportError:
pass
except ldap.INVALID_CREDENTIALS:
pass

def get_or_create_user(self, username):
try:
user = User.objects.get(username=username)
except User.DoesNotExist:
try:
import ldap
ldapo = ldap.initialize(settings.LDAP_URI)
ldapo.set_option(ldap.OPT_PROTOCOL_VERSION, 3)
if settings.LDAP_TLS:
ldapo.start_tls_s()
ldapo.simple_bind_s(settings.LDAP_ANON_BIND_UID,
settings.LDAP_ANON_BIND_PASSWD)

passwd = ldapo.search_s(settings.LDAP_UID_MASK %
username,
ldap.SCOPE_SUBTREE,
"objectclass=*")

first_name, last_name = passwd[0][1]['cn'][0].split('
', 1)
email = u'%s@%s' % (username,
settings.LDAP_EMAIL_DOMAIN)

user = User(username=username,
password='',
first_name=first_name,
last_name=last_name,
email=email)
user.is_staff = False
user.is_superuser = False
user.save()
except ImportError:
pass
except ldap.INVALID_CREDENTIALS:
# FIXME I'd really like to warn the user that their
# ANON_BIND_UID and ANON_BIND_PASSWD are wrong, but I
don't
# know how
pass
except ldap.NO_SUCH_OBJECT:
pass
except ldap.LDAPError:
pass
return user

def get_user(self, user_id):
return get_object_or_none(User, pk=user_id)

class SettingsBackend:
"""
Authenticate against the settings ADMIN_LOGIN and ADMIN_PASSWORD.

Use the login name, and a hash of the password. For example:

ADMIN_LOGIN = 'admin'
ADMIN_PASSWORD = 'sha1$blah'
"""
def authenticate(self, username=None, password=None):
login_valid = (settings.ADMIN_LOGIN == username)
pwd_valid = check_password(password, settings.ADMIN_PASSWORD)
if login_valid and pwd_valid:
try:
user = User.objects.get(use

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

Hi Christian,



After sending you my backends file,  I decided to start with the
default backends.py file and then added the additional classes that I
needed for theActiveDirectoryGroupMembershipSSLBackend
authentication.  Then I ran rb-site upgrade and I get a login prompt,
so that's an improvement!  When I try to log in, I get this error in
my ldap log

authenticate user: admin
exception caught!
global name 'ldap' is not defined

--steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Mod_python error with brand new RB 1.6 installation

[Steve]

On Sep 12, 11:09 am, Steve  wrote:
> Hi Christian,
>
> 
>
> After sending you my backends file,  I decided to start with the
> default backends.py file and then added the additional classes that I
> needed for theActiveDirectoryGroupMembershipSSLBackend
> authentication.  Then I ran rb-site upgrade and I get a login prompt,
> so that's an improvement!  When I try to log in, I get this error in
> my ldap log
>
> authenticate user: admin
> exception caught!
> global name 'ldap' is not defined
>

Importing ldap in backends.py fixed that problem and I can now log
in.  I may be out of the woods!

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

manage.py syncdb - should I run it or not?

[Steve]

I upgraded our RB site 2 weeks ago from 1.0.9 to 1.5.5.  As part of
the upgrade, I ran

$ rb-site upgrade /var/www/reviewboard

Everything went smoothly and RB has been running fine for over a week.
Then today, several users reported being unable to access RB. They
were getting a message saying:

"""
The Review Board database schema has changed since your last upgrade.
To update your schema, run:
   $ ./manage.py syncdb
"""

That seemed odd because I'm pretty sure 'rb-site upgrade' updated the
database schema. If it hadn't, RB would have been pretty non-
functional and that wasn't the case. So I searched here and found a
message from 2009 where the OP was getting the same message:

"""
"Database changes
The Review Board database schema has changed since your last upgrade.
To update your schema, run:

  $ ./manage.py syncdb
 Follow any additional instructions it may give you. If, for example,
it tells you to perform a schema evolution, run:

  $ ./manage.py evolve --execute"
"""

The reply to that was

"""
Those instructions should be changed. You need to follow the
instructions in
the admin guide on upgrading sites using 'rb-site upgrade /path/to/
site'
"""

Based on that, I decided to restart RB and that made the problem go
away. Or at least it made RB functional again, but I have a nagging
feeling the problem could return.  To add to my confusion, I see a
recent discussion here where 'manage.py syncdb' was the correct action
to take, for something called a django evolution.

So,

1. If I ran 'rb-site upgrade', do I still need to run 'manage.py
syncdb'?
2. Is that still an outdated message that should be changed?
3. Can anyone think of why the site would be running fine for over a
week (it gets pretty high traffic) and then suddenly behave in this
way?

Thanks!

--
-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: manage.py syncdb - should I run it or not?

[Steve]

Thanks for the explanation Chris. Very helpful and reassuring - I'll
be adding this information to our internal docs.

Moving to 1.6 is on my TODO list, but we have some key scripts that
use the 1.0 version of the Web API which we need to do something with
before we can move to 1.6.

Thanks again!

--
-- Steve


On Oct 4, 12:56 pm, Christian Hammond  wrote:
> Hi Steve,
>
> That error is, indeed, old and wrong. We've fixed this in 1.6, and it's much
> more clear now.
>
> What probably happened is that, for some reason, there was a temporary
> communication problem or something with your database. Perhaps it couldn't
> talk to it, or it reached a max number of connections, or it had some other
> error. Either way, our checks saw "We failed to get this table we were
> checking for!" and made an assumption. A bad assumption. One that 1.6
> doesn't make anymore.
>
> So you did the right thing with rb-site upgrade. No, those commands it lists
> shouldn't be used. The assumption in the past is that you'd only see that in
> development installs, hence the lack of rb-site, and that you'd never see
> them anymore because the table we try to fetch is from pre-1.0 days.
>
> If you upgrade to 1.6, you'll start seeing actual error messages telling you
> exactly what went wrong. Hopefully you never see them again, but if you do,
> it'll at least give you an idea what to look for.
>
> Christian
>
> --
> Christian Hammond - chip...@chipx86.com
> Review Board -http://www.reviewboard.org
> VMware, Inc. -http://www.vmware.com
>
> On Tue, Oct 4, 2011 at 12:43 PM, Steve  wrote:
> > I upgraded our RB site 2 weeks ago from 1.0.9 to 1.5.5.  As part of
> > the upgrade, I ran
>
> > $ rb-site upgrade /var/www/reviewboard
>
> > Everything went smoothly and RB has been running fine for over a week.
> > Then today, several users reported being unable to access RB. They
> > were getting a message saying:
>
> > """
> > The Review Board database schema has changed since your last upgrade.
> > To update your schema, run:
> >   $ ./manage.py syncdb
> > """
>
> > That seemed odd because I'm pretty sure 'rb-site upgrade' updated the
> > database schema. If it hadn't, RB would have been pretty non-
> > functional and that wasn't the case. So I searched here and found a
> > message from 2009 where the OP was getting the same message:
>
> > """
> > "Database changes
> > The Review Board database schema has changed since your last upgrade.
> > To update your schema, run:
>
> >  $ ./manage.py syncdb
> >  Follow any additional instructions it may give you. If, for example,
> > it tells you to perform a schema evolution, run:
>
> >  $ ./manage.py evolve --execute"
> > """
>
> > The reply to that was
>
> > """
> > Those instructions should be changed. You need to follow the
> > instructions in
> > the admin guide on upgrading sites using 'rb-site upgrade /path/to/
> > site'
> > """
>
> > Based on that, I decided to restart RB and that made the problem go
> > away. Or at least it made RB functional again, but I have a nagging
> > feeling the problem could return.  To add to my confusion, I see a
> > recent discussion here where 'manage.py syncdb' was the correct action
> > to take, for something called a django evolution.
>
> > So,
>
> > 1. If I ran 'rb-site upgrade', do I still need to run 'manage.py
> > syncdb'?
> > 2. Is that still an outdated message that should be changed?
> > 3. Can anyone think of why the site would be running fine for over a
> > week (it gets pretty high traffic) and then suddenly behave in this
> > way?
>
> > Thanks!
>
> > --
> > -- Steve
>
> > --
> > Want to help the Review Board project? Donate today at
> >http://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group at
> >http://groups.google.com/group/reviewboard?hl=en
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Enhancement request - add a 'Hold It' tag

[Steve]

I have an enhancement request I'd like to run by you.

When viewing a review, it is easy to spot 'Ship It!' tags.  I'd like
to add similar 'Hold It' tags.There are times when I'd like to
communicate to the owner of the review  that even though they've
received 'Ship It's from some of the reviewers, I'd like more time to
look at it before they submit.  I know this could be done via
comments, but a more formalized approach would be nice. The hold would
also need to be in the database so that  scripts can detect that a
review has a hold on it.

What do you think?  Sound doable? Useful? Should I enter this in
bugzilla?

Thanks

--
-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Enhancement request - add a 'Hold It' tag

[Steve]

D'oh!  I must remember to search bugzilla *before* posting.  Found it
here:

http://code.google.com/p/reviewboard/issues/detail?id=489&sort=component%20-type&colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestone&start=100


--Steve

On Nov 9, 11:12 am, David Trowbridge  wrote:
> You're not the only one :)
>
> We've been discussing for a while the best way to handle this use
> case, and hopefully we'll be able to fix it by 1.7 (but no promises).
>
> -David
>
> On Wed, Nov 9, 2011 at 10:50 AM, Steve  wrote:
> > I have an enhancement request I'd like to run by you.
>
> > When viewing a review, it is easy to spot 'Ship It!' tags.  I'd like
> > to add similar 'Hold It' tags.There are times when I'd like to
> > communicate to the owner of the review  that even though they've
> > received 'Ship It's from some of the reviewers, I'd like more time to
> > look at it before they submit.  I know this could be done via
> > comments, but a more formalized approach would be nice. The hold would
> > also need to be in the database so that  scripts can detect that a
> > review has a hold on it.
>
> > What do you think?  Sound doable? Useful? Should I enter this in
> > bugzilla?
>
> > Thanks
>
> > --
> > -- Steve
>
> > --
> > Want to help the Review Board project? Donate today 
> > athttp://www.reviewboard.org/donate/
> > Happy user? Let us know athttp://www.reviewboard.org/users/
> > -~--~~~~--~~--~--~---
> > To unsubscribe from this group, send email to 
> > reviewboard+unsubscr...@googlegroups.com
> > For more options, visit this group 
> > athttp://groups.google.com/group/reviewboard?hl=en
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Occasional "illegal mix of collations" error

[Steve]

I occasionally get an error message from Django that reports:

  File "build/bdist.linux-x86_64/egg/MySQLdb/connections.py", line 36,
in defaulterrorhandler

OperationalError: (1267, "Illegal mix of collations
(latin1_swedish_ci,IMPLICIT) and (utf8_general_ci,COERCIBLE) for
operation 'like'")

The one I received this morning was for a review with 3 files - 2 .cpp
ahd 1 .h. It doesn't appear to prevent the review process, but it is
somewhat noisy. Is there some way I can prevent it?

I'm running RB 1.5.5 on CentOS 5.6. The full traceback is below.

Thanks!

--
-- Steve

Traceback (most recent call last):

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
core/handlers/base.py", line 178, in get_response
response = middleware_method(request, response)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
middleware/http.py", line 15, in process_response
response['Content-Length'] = str(len(response.content))

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/webapi/core.py", line 276, in _get_content
content = adapter.encode(self.api_data, request=self.request)

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/webapi/core.py", line 88, in encode
return super(JSONEncoderAdapter, self).encode(o)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
utils/simplejson/encoder.py", line 193, in encode
chunks = list(chunks)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
utils/simplejson/encoder.py", line 416, in _iterencode
for chunk in _iterencode_dict(o, _current_indent_level):

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
utils/simplejson/encoder.py", line 390, in _iterencode_dict
for chunk in chunks:

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
utils/simplejson/encoder.py", line 424, in _iterencode
o = _default(o)

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/webapi/core.py", line 96, in default
result = self.encoder.encode(o, *self.encode_args,
**self.encode_kwargs)

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/webapi/core.py", line 257, in encode
result = encoder.encode(*args, **kwargs)

  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/webapi/encoders.py", line 14, in encode
return list(o)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
db/models/query.py", line 84, in __len__
self._result_cache.extend(self._iter)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
db/models/query.py", line 273, in iterator
for row in compiler.results_iter():

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
db/models/sql/compiler.py", line 680, in results_iter
for rows in self.execute_sql(MULTI):

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
db/models/sql/compiler.py", line 735, in execute_sql
cursor.execute(sql, params)

  File "/usr/lib/python2.4/site-packages/Django-1.3.1-py2.4.egg/django/
db/backends/mysql/base.py", line 86, in execute
return self.cursor.execute(query, args)

  File "build/bdist.linux-x86_64/egg/MySQLdb/cursors.py", line 174, in
execute

  File "build/bdist.linux-x86_64/egg/MySQLdb/connections.py", line 36,
in defaulterrorhandler

OperationalError: (1267, "Illegal mix of collations
(latin1_swedish_ci,IMPLICIT) and (utf8_general_ci,COERCIBLE) for
operation 'like'")

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Cannot access the main page for a review

[Steve]

One of my users created a review and in the 'Testing Done' field she
pasted in the contents of a large, complex shell script that was used
for the testing. When we try to access the main page for the review,
we see this:


Something broke! (Error 500)

It appears something broke when you tried to go to here. This is
either a bug in Review Board or a server configuration error. Please
report this to your administrator.


The message I get in the log is:

SyntaxError: EOL while scanning single-quoted string

and it's clear from the context that RB wasn't able to parse what had
been pasted into the description field (lot's of nested quotes in the
script). I had the user remove all that from the description, but the
problem remains because apparently RB saves diffs on that field. So
the error now looks like:


  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/util/fields.py", line 205, in loads
val = eval(val)

  File "", line 1

{"diff": {"added": [["Diff r4", "/r/33599/diff/4/", 71332]]},
"testing_done": {"new": ["I used a script that I wrote to test out
which headers are returned for various types of content SNIPPED REST\n
\n\n\n\n"], "old": ["I used a script that I wrote to test out which
headers are returned for various types of content SCRIPT CONTENT HERE
 
^

SyntaxError: EOL while scanning single-quoted string


We'd like to avoid creating a new RB request, and the only solution I
could come up with is to hack the database to remove the 'Testing
Done' stuff entirely. Is that feasible? Advisable? Is there another
way to fix this?

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Cannot access the main page for a review

[Steve]

One of my users created a review and in the 'Testing Done' field she
pasted in the contents of a large, complex shell script that was used
for the testing. When we try to access the main page for the review,
we see this:


Something broke! (Error 500)

It appears something broke when you tried to go to here. This is
either a bug in Review Board or a server configuration error. Please
report this to your administrator.


The message I get in the log is:

SyntaxError: EOL while scanning single-quoted string

and it's clear from the context that RB wasn't able to parse what had
been pasted into the description field (lot's of nested quotes in the
script). I had the user remove all that from the description, but the
problem remains because apparently RB saves diffs on that field. So
the error now looks like:


  File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
djblets/util/fields.py", line 205, in loads
val = eval(val)

  File "", line 1

{"diff": {"added": [["Diff r4", "/r/33599/diff/4/", 71332]]},
"testing_done": {"new": ["I used a script that I wrote to test out
which headers are returned for various types of content SNIPPED REST\n
\n\n\n\n"], "old": ["I used a script that I wrote to test out which
headers are returned for various types of content SCRIPT CONTENT HERE
 
^

SyntaxError: EOL while scanning single-quoted string


We'd like to avoid creating a new RB request, and the only solution I
could come up with is to hack the database to remove the 'Testing
Done' stuff entirely. Is that feasible? Advisable? Is there another
way to fix this?

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Need to find the changedescs_changedescription row for a given review

[Steve]

I would like to find the entry in the changedescs_changedescription
table for a given reviews_reviewrequest id. Neither the id nor the
diffset_history_id from the reviewrequest get me there directly. I'm
thinking that the diffset_history_id gets me into a table that will
then get me to the changedescription I'm after, but I haven't been
able to connect the dots. Anyone know how to navigate between these
two tables?

Thanks!

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Cannot access the main page for a review

[Steve]

I found the very long script text in the

reviewboard.changedescs_changedescription

table. In the "fields_changed" dict the script was in the "old" entry
for testing_done. I set the "old" entry to [""], but that didn't fix
the problem.

I copied the dict into a python shell and it parsed fine, so I'm
stumped. Maybe this testing_done entry isn't the source of the
problem? Or maybe there's another database entry that needs cleaning
up?

I did all this in a sandbox, not the production server :)


--Steve


On Feb 23, 7:56 am, Steve  wrote:
> One of my users created a review and in the 'Testing Done' field she
> pasted in the contents of a large, complex shell script that was used
> for the testing. When we try to access the main page for the review,
> we see this:
>
> 
> Something broke! (Error 500)
>
> It appears something broke when you tried to go to here. This is
> either a bug in Review Board or a server configuration error. Please
> report this to your administrator.
> 
>
> The message I get in the log is:
>
> SyntaxError: EOL while scanning single-quoted string
>
> and it's clear from the context that RB wasn't able to parse what had
> been pasted into the description field (lot's of nested quotes in the
> script). I had the user remove all that from the description, but the
> problem remains because apparently RB saves diffs on that field. So
> the error now looks like:
>
> 
>   File "/usr/lib/python2.4/site-packages/Djblets-0.6.11-py2.4.egg/
> djblets/util/fields.py", line 205, in loads
>     val = eval(val)
>
>   File "", line 1
>
>     {"diff": {"added": [["Diff r4", "/r/33599/diff/4/", 71332]]},
> "testing_done": {"new": ["I used a script that I wrote to test out
> which headers are returned for various types of content SNIPPED REST\n
> \n\n\n\n"], "old": ["I used a script that I wrote to test out which
> headers are returned for various types of content SCRIPT CONTENT HERE
>
> ^
>
> SyntaxError: EOL while scanning single-quoted string
> 
>
> We'd like to avoid creating a new RB request, and the only solution I
> could come up with is to hack the database to remove the 'Testing
> Done' stuff entirely. Is that feasible? Advisable? Is there another
> way to fix this?
>
> Thanks
>
> --Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Cannot access the main page for a review

[Steve]

Thanks Christian,

I'm running 1.5.5 on a Centos 5 box. I attempted replacing the long string 
with an empty one in the

reviewboard.changedescs_changedescription 

table. In the "fields_changed" dict the bad text was in the "old" entry for 
testing_done. I set the "old" entry to [""], but that didn't fix the 
problem.

--Steve


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Need to find the changedescs_changedescription row for a given review

[Steve]

 Unfortunately, I'm trying to find the bad text inserted into the 'Testing 
Done' field so I can edit it (my other post). I can find the broken review 
in the admin interface,  but when I select it for further investigation, I 
get an error (my other post) and can't go any further :(

I was trying to find it using mysql workbench, but I couldn't follow the 
various pointers to other tables.  I eventually found it by brute force.

--
-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Cannot access the main page for a review

[Steve]

Hi Christian,

I'm guessing the broken review can't be fixed. Though I don't understand 
why removing that big text string directly from the database table didn't 
work.  What would be the closest version to 1.5.5 where the string limit 
was increased. The mysql settings I see in 1.5.5 are for the table that I 
think is causing the problem are:

Table changedescs_changedescription
===
id, timestamp, public, text, fields_changed
---
id   int(11) PK
timestampdatetime
public   tinyint(1)
text longtext
fields_changed   text


The offending text was in the fields_change entry.

Thanks

--Steve


On Thursday, February 23, 2012 2:26:27 PM UTC-8, Steve wrote:
>
> Thanks Christian,
>
> I'm running 1.5.5 on a Centos 5 box. I attempted replacing the long string 
> with an empty one in the
>
> reviewboard.changedescs_changedescription 
>
> table. In the "fields_changed" dict the bad text was in the "old" entry 
> for testing_done. I set the "old" entry to [""], but that didn't fix the 
> problem.
>
> --Steve
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

I'd like to create an RB schema diagram

[Steve]

I'd like an RB schema diagram to help me understand how the database is 
organized. I was able to create some nice output using SchemaSpy, but the 
output claims there are no relationships between the tables, which I don't 
believe.  Reverse engineering in MySQL Workbench didn't display any table 
relationships either. Any advice on where to find or create a schema 
diagram that shows how the tables are related would be greatly appreciated.

Thanks!

--
-- Steve


-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

RB 1.5.5 - Bug in rb-site install when using sqlite3 and --noinput option

[Steve]

For testing purposes, I've been creating reviewboard sites with sqlite3.  
I've been running rb-site install with the --noinput option to automate the 
process, and ran into a bug - either in the docs or functionality.  rb-site 
help install says this:

  --db-name=DB_NAME   database name (not for sqlite3)

When running my script, I was unable to log into the site and would get 
messages about the database being out of date.  After comparing a site 
created interactively with one created with --noinput,  I was able to get a 
working site using this option to rb-site intall:

  --db-name='/var/www/rb/data/reviewboard.db

This is with ReviewBoard 1.5.5 on Fedora 13.

-- Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Installer is hanging with 1.5.7 on Fedora 16 and sqlite3

[Steve]

I'm attempting to install RB 1.5.7 on a new Fedora 16 machine. Everything 
went well up to the point where I create a test site.  Since I'm just 
testing, I chose the sqlite3 database. My installer hang's at the 'Creating 
database' step, and the console reports this:

  File 
"/usr/lib/python2.7/site-packages/Django-1.4-py2.7.egg/django/db/backends/dummy/base.py",
line 15, in complain
raise ImproperlyConfigured("settings.DATABASES is improperly 
configured. "
django.core.exceptions.ImproperlyConfigured: settings.DATABASES is 
improperly
configured. Please supply the ENGINE value. Check settings documentation for
more details.

A search for 'DATABASES is improperly configured' didn't turn up anything 
and I'm at a loss. I installed with this command:

$ easy_install -U 
http://downloads.reviewboard.org/releases/ReviewBoard/1.5/ReviewBoard-1.5.7-py2.7.egg

and ended up with these eggs:

drwxr-xr-x   2 root root   4096 Jun  8 10:04 
distribute-0.6.24-py2.7.egg-info
drwxr-xr-x   3 root root   4096 Jun  8 10:04 setuptools
drwxr-xr-x   4 root root   4096 Jun  8 10:04 distribute-0.6.27-py2.7.egg
-rw-r--r--   1 root root 30 Jun  8 10:04 setuptools.pth
drwxr-xr-x   2 root root   4096 Jun 11 07:55 
python_memcached-1.47-py2.7.egg-info
drwxr-xr-x   4 root root   4096 Jun 11 07:57 
recaptcha_client-1.0.6-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:57 pytz-2012c-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:57 python_dateutil-1.5-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:57 paramiko-1.7.7.2-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:57 
flup-1.0.3.dev_20110405-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:58 Pygments-1.5-py2.7.egg
drwxr-xr-x   5 root root   4096 Jun 11 07:58 Djblets-0.6.18-py2.7.egg
drwxr-xr-x   5 root root   4096 Jun 11 07:58 
django_evolution-0.6.7-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:59 Django-1.4-py2.7.egg
drwxr-xr-x   4 root root   4096 Jun 11 07:59 
pycrypto-2.6-py2.7-linux-x86_64.egg
drwxr-xr-x   3 root root  12288 Jun 11 07:59 
PIL-1.1.7-py2.7-linux-x86_64.egg
-rw-r--r--   1 root root583 Jun 11 07:59 easy-install.pth
drwxr-xr-x   5 root root   4096 Jun 12 08:12 ReviewBoard-1.5.7-py2.7.egg

Can anyone suggest where I might look for the cause of this problem?

Thanks!

--steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

RBTools 0.7.4: rbt patch --px bug

[Steve]

There's a bug in RBTools 0.7.4 when using 'rbt patch' with the --px option. 
The problem is the option string isn't being converted to an integer:

$ rbt --version
RBTools 0.7.4

$ rbt patch --px 4  --repository-type perforce -d 128385



File "C:\Python27\lib\site-packages\rbtools\clients__init__.py", line 197, 
in apply_patch
cmd.append('-p%d' % p_num)
TypeError: %d format: a number is required, not str

The simplest fix is:

< cmd.append('-p%d' % p_num)
> cmd.append('-p%d' % int(p_num))

The problem is also in 0.7.5 alpha.

I opened a ticket here:

https://hellosplat.com/s/beanbag/tickets/4364/

But I wanted to post it here as well for visibility since others may run 
into this.

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

RBTools 0.7.4: rbt post --diff-only no longer works

[Steve]

I've noticed that the --diff-only option to rbt post is no longer working 
the way it used to with Perforce.  It may be trying to be too clever. If I 
create a review with this perforce change description:

Description:
   Bogus review request to test --diff-only option


Using

$ rbt post CL

I get a review request where both the title and description read: "Bogus 
review request to test --diff-only option".  That's good.  Then I modify 
the file and the change list description so the new change list description 
reads:


Description:
Bogus review request to test --diff-only option

   I'm adding this comment for Rev 2. Using --diff-only, this text 
should not appear in ReviewBoard


and do

$ rbt post --diff-only CL

When I look at the new review draft, the title remains the same (good), but 
the description field now says:


   "I'm adding this comment for Rev 2. Using --diff-only, this text should 
not appear in ReviewBoard"

which is not good.

Even worse is this case:

I edit the description field in Review Board to add aditional information 
directly. It now reads:

'''
Bogus review request to test --diff-only option

Someone reported a problem with 'rbt post --diff-only'  I'm using this 
bogus review request to test and see if this is broken. I expect this 
comment to remain after an update using --diff-only.
'''

Now I run

$ rbt post --diff-only CL

And my description in Review Board has been overwritten with the 
description in my perforce change list.

I searched for '--diff-only' in the bug tracker and didn't find anything, 
so I'm posting here to see if this is a known issue.

Thanks

--Steve

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: RBTools 0.7.4: rbt post --diff-only no longer works

[Steve]

Hi David,

Ticket opened: https://hellosplat.com/s/beanbag/tickets/4368/

--Steve

On Monday, March 14, 2016 at 2:34:51 PM UTC-7, David Trowbridge wrote:
>
> I don't think we've heard about this before. Mind filing a bug?
>
> -David
>
> On Thu, Mar 10, 2016 at 9:15 AM Steve > 
> wrote:
>
>> I've noticed that the --diff-only option to rbt post is no longer working 
>> the way it used to with Perforce.  It may be trying to be too clever. If I 
>> create a review with this perforce change description:
>>
>> Description:
>>Bogus review request to test --diff-only option
>>
>>
>> Using
>>
>> $ rbt post CL
>>
>> I get a review request where both the title and description read: "Bogus 
>> review request to test --diff-only option".  That's good.  Then I modify 
>> the file and the change list description so the new change list description 
>> reads:
>>
>>
>> Description:
>> Bogus review request to test --diff-only option
>>
>>I'm adding this comment for Rev 2. Using --diff-only, this 
>> text should not appear in ReviewBoard
>>
>>
>> and do
>>
>> $ rbt post --diff-only CL
>>
>> When I look at the new review draft, the title remains the same (good), 
>> but the description field now says:
>>
>>
>>"I'm adding this comment for Rev 2. Using --diff-only, this text 
>> should not appear in ReviewBoard"
>>
>> which is not good.
>>
>> Even worse is this case:
>>
>> I edit the description field in Review Board to add aditional information 
>> directly. It now reads:
>>
>> '''
>> Bogus review request to test --diff-only option
>>
>> Someone reported a problem with 'rbt post --diff-only'  I'm using this 
>> bogus review request to test and see if this is broken. I expect this 
>> comment to remain after an update using --diff-only.
>> '''
>>
>> Now I run
>>
>> $ rbt post --diff-only CL
>>
>> And my description in Review Board has been overwritten with the 
>> description in my perforce change list.
>>
>> I searched for '--diff-only' in the bug tracker and didn't find anything, 
>> so I'm posting here to see if this is a known issue.
>>
>> Thanks
>>
>> --Steve
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -David
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board fails to create a review -- apparently failing to grab valid revision of files from SVN

[Steve]

On Wednesday, February 15, 2017 at 1:08:14 AM UTC-8, Christian Hammond 
wrote:
>
> Hi Steve,
>
> What version of Review Board are you using?
>
> Can you show me the appropriate line from the diff from `rbt diff`? The 
> entire set of diff headers (filenames + revisions + Index line, no data 
> needed) where it specifies 8525 would help a lot.
>
> Thanks!
>
> Christian
>
> -- 
> Christian Hammond
> President/CEO of Beanbag <https://www.beanbaginc.com/>
> Makers of Review Board <https://www.reviewboard.org/>
>
> On Tue, Feb 14, 2017 at 5:06 PM, Steve Muller  > wrote:
>
>> When I try to manually post from the review board GUI for one specific 
>> SVN repository, it give me the following message:
>>
>>  
>>
>> The specified diff file could not be parsed.
>> Line undefined: No such revision 8525
>>
>>  
>>
>> In this case, revision 8525 is the original revision the change is based 
>> on and is valid.  From the command line *rbt post* also fails, but* rbt 
>> diff* generates a diff file just fine.  
>>
>>  
>>
>> It looks like failure in both cases is that it can’t grab the SVN 
>> revision of files even though they should be there.  Accessing SVN directly 
>> of these revision seem fine.
>>
>>  
>>
>> Is there a way to debug this either from the SVN side or the Review Board 
>> side??
>>
>>  
>>
>>  
>>
>> Thanks.
>>
>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/d/optout.
>>
>
>

This is a simplified, one file change that I was trying to create a 
review with.  It's actually incremented the SVN revision, but it's still a 
valid revision.

Index: src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c

===

--- src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c (revision 
8527)

+++ src/vip_bcm97405B1_stage1_bl/CFE/bcm97405A/src/user_input.c (revision 
8528)

@@ -2481,3 +2481,5 @@

}

return halError;

}

+

+/** steve's review board test **/
 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Review Board fails to create a review -- apparently failing to grab valid revision of files from SVN

[Steve]

Version:  *Review Board*  2.5.2 

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Page rendering and default route

[Steve]

Hi,

I'm new to Reviewboard but managed to find my way around through an upgrade 
from 1.6.. to 3.0. whilst changing from Mod_Python to WSGI. Also upgraded 
from Ubuntu 12.04  to 18.06 and there seemed to be a few dependency issues 
to sort out on the way.

Anyway Reviewboard seems to working now at least with all the original data 
but I have two problems.


Problem 1.

There is no page rendering or graphics throughout, it's just plain text 
based. Initially I thought it was permissions related or at least in the 
/var/www/RB directory so I created a test site under 3.0.. and just 
compared the two, all seemed to be the same.


[image: snip.png]


Problem 2.

I have trac/svn running on the same machine. If I enable reviewboard.conf 
in apache, reviewboard seems to take over and what was 
http://localhost/trac or locahost/ goes to reviewboard. If I disable 
reviewboard.conf then trac/svn works fine. Been through .conf, .wsgi and 
settings_local.py but cant seem to make it work. I thought that site route 
as /reviewboard/ would have changed it's focus but I guess not.
 

Any help would be appreciated.


Thanks in advance.
Steve.

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b8627e3c-4dbb-4732-b17c-1e8d39660263%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Yes all present and correct.




On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>
> check you have the following mappings in your apache config for reviewboard
>
> # Alias static media requests to filesystem
> Alias /media "/var/www/reviewboard/htdocs/media"
> Alias /static "/var/www/reviewboard/htdocs/static"
> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
> Alias /favicon.ico 
> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Hi Christian,

Hm, the paths seem to have old references as well as new. site_media_root 
is definitely a throw back from the original install. Originally 
reviewboard was running on Gentoo and I created a working clone under 
Ubuntu with a reviewboard default directory structure. All seemed to work 
fine until the upgrade from 1.6.. to 3.0.. At that point the directory 
structure changed so I assume these paths are not part of the upgrade 
process.

"logging_directory": "/var/log/reviewboard"
"site_media_root": "/var/www/localhost/htdocs/reviewboard/htdocs/media",
"site_static_root": "/var/www/reviewboard/htdocs/static",
"site_static_url": "/reviewboard/static/",
"site_media_url": "/reviewboard/media/",

Where can I modify these.



DEBUG = False


Steve.




On Thursday, 27 June 2019 01:04:29 UTC+1, Christian Hammond wrote:
>
> Hi,
>
> Can you show me one of the URLs it’s trying to load (say, a CSS file)?
>
> Also, two things to check:
>
> 1) Make sure you have the following in your $sitedir/conf/settings_local.py
>
> DEBUG = False
>
> 2) Run this and look at the paths that are set. Make sure they are what 
> you expect:
>
> rb-site manage $sitedir list-siteconfig
>
> Christian
>
>
> On Wed, Jun 26, 2019 at 09:06 Steve > 
> wrote:
>
>> Yes all present and correct.
>>
>>
>>
>>
>> On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>>>
>>> check you have the following mappings in your apache config for 
>>> reviewboard
>>>
>>> # Alias static media requests to filesystem
>>> Alias /media "/var/www/reviewboard/htdocs/media"
>>> Alias /static "/var/www/reviewboard/htdocs/static"
>>> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
>>> Alias /favicon.ico 
>>> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>>>
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/3519b207-35bb-46b1-bd41-442c4e5d29a4%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/41adf1f6-934a-44ac-902d-da9d0bad3d5d%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Also console log.

(index):28 GET 
http://10.132.40.199/reviewboard/static/rb/css/common.min.4a69e5741dc4.css 
net::ERR_ABORTED 404 (NOT FOUND)
(index):52 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-migrate-1.2.1.min.eb05d8d73b5b.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):256 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-ui-1.8.24.custom.min.f6148fb67d77.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):258 GET 
http://10.132.40.199/reviewboard/static/lib/js/3rdparty.min.1719e20827dd.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):259 GET 
http://10.132.40.199/reviewboard/static/djblets/js/jquery.gravy.min.e24d040808fd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):260 GET 
http://10.132.40.199/reviewboard/static/djblets/js/utils.min.84b7b8c324db.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):261 GET 
http://10.132.40.199/reviewboard/static/djblets/js/extensions.min.1d8986b3c3cd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):100 GET 
http://10.132.40.199/reviewboard/static/rb/images/logo.cc81d3ae01b2.png 404 
(NOT FOUND)
(index):51 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-1.11.1.min.8101d596b2b8.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):52 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-migrate-1.2.1.min.eb05d8d73b5b.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):262 GET 
http://10.132.40.199/reviewboard/static/rb/js/base.min.af574b99af97.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):256 GET 
http://10.132.40.199/reviewboard/static/lib/js/jquery-ui-1.8.24.custom.min.f6148fb67d77.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):258 GET 
http://10.132.40.199/reviewboard/static/lib/js/3rdparty.min.1719e20827dd.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):259 GET 
http://10.132.40.199/reviewboard/static/djblets/js/jquery.gravy.min.e24d040808fd.js
 
404 (NOT FOUND)
(index):260 GET 
http://10.132.40.199/reviewboard/static/djblets/js/utils.min.84b7b8c324db.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):261 GET 
http://10.132.40.199/reviewboard/static/djblets/js/extensions.min.1d8986b3c3cd.js
 
net::ERR_ABORTED 404 (NOT FOUND)
(index):262 GET 
http://10.132.40.199/reviewboard/static/rb/js/base.min.af574b99af97.js 
net::ERR_ABORTED 404 (NOT FOUND)
(index):264 Uncaught ReferenceError: RB is not defined
at (index):264
(anonymous) @ (index):264






On Thursday, 27 June 2019 10:19:58 UTC+1, Steve wrote:
>
> Hi Christian,
>
> Hm, the paths seem to have old references as well as new. site_media_root 
> is definitely a throw back from the original install. Originally 
> reviewboard was running on Gentoo and I created a working clone under 
> Ubuntu with a reviewboard default directory structure. All seemed to work 
> fine until the upgrade from 1.6.. to 3.0.. At that point the directory 
> structure changed so I assume these paths are not part of the upgrade 
> process.
>
> "logging_directory": "/var/log/reviewboard"
> "site_media_root": "/var/www/localhost/htdocs/reviewboard/htdocs/media",
> "site_static_root": "/var/www/reviewboard/htdocs/static",
> "site_static_url": "/reviewboard/static/",
> "site_media_url": "/reviewboard/media/",
>
> Where can I modify these.
>
> 
>
> DEBUG = False
>
>
> Steve.
>
>
>
>
> On Thursday, 27 June 2019 01:04:29 UTC+1, Christian Hammond wrote:
>>
>> Hi,
>>
>> Can you show me one of the URLs it’s trying to load (say, a CSS file)?
>>
>> Also, two things to check:
>>
>> 1) Make sure you have the following in your 
>> $sitedir/conf/settings_local.py
>>
>> DEBUG = False
>>
>> 2) Run this and look at the paths that are set. Make sure they are what 
>> you expect:
>>
>> rb-site manage $sitedir list-siteconfig
>>
>> Christian
>>
>>
>> On Wed, Jun 26, 2019 at 09:06 Steve  wrote:
>>
>>> Yes all present and correct.
>>>
>>>
>>>
>>>
>>> On Wednesday, 26 June 2019 16:39:44 UTC+1, Paul Mansfield wrote:
>>>>
>>>> check you have the following mappings in your apache config for 
>>>> reviewboard
>>>>
>>>> # Alias static media requests to filesystem
>>>> Alias /media "/var/www/reviewboard/htdocs/media"
>>>> Alias /static "/var/www/reviewboard/htdocs/static"
>>>> Alias /errordocs "/var/www/reviewboard/htdocs/errordocs"
>>>> Alias /favicon.ico 
>>>> "/var/www/reviewboard/htdocs/static/rb/images/favicon.png"
>>>>
>>>>
>>>>
>>>> -- 
>>> Supercharge your Review Board with Power Pack: 
>>> https://www.reviewboard.org/powerpack/
>

Re: Page rendering and default route

[Steve]

re-set site_media_root and tried again but still the same issue.

re-set site_static_url and then tried site_madia_url but keep getting this 
back



  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
 
line 326, in apply_django_settings
setter(settings, setting_key, value)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", 
line 242, in __setattr__
setattr(self._wrapped, name, value)
  File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
line 110, in __setattr__
raise ImproperlyConfigured("If set, %s must end with a slash" % name)
django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
with a slash


svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
/var/www/reviewboard set-siteconfig -- --key=site_media_url 
--value=/var/www/reviewboard/htdocs/media/




can't seem to get a list-siteconfig without the same error.


Steve.







On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>
> You can use the set-siteconfig management command, like so:
>
> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
> --value=...
>
> Note the -- before the first flag. This is currently necessary for 
> ensuring the arguments are passed to set-siteconfig and not rb-site.
>
> Christian
>
>
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

The test site I created within 3.0..showed the same as you describe so I 
tried /static/ and /media/ but still get the same error message. Trouble is 
I now cant run list-siteconfig on the site i'm upgrading so cant check 
other settings for conflicts. What settings should I set that relate to 
domain, only I cant see anything in the test site that would give me a 
clue. Or are we talking about settings in another file.


Steve.


 

On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>
> Hi Steve,
>
> The URL parameters are used to build the URLs to media files. They must be 
> a path relative to the domain, or the absolute path to a server (CDN) 
> serving the files. You’re going to want to only set the “root” equivalents.
>
> Try setting site_static_url to /static/ and site_media_url to /media/.
>
> Christian
>
>
> On Thu, Jun 27, 2019 at 05:03 Steve > 
> wrote:
>
>> re-set site_media_root and tried again but still the same issue.
>>
>> re-set site_static_url and then tried site_madia_url but keep getting 
>> this back
>>
>>
>>
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>  
>> line 326, in apply_django_settings
>> setter(settings, setting_key, value)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>> 242, in __setattr__
>> setattr(self._wrapped, name, value)
>>   File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
>> line 110, in __setattr__
>> raise ImproperlyConfigured("If set, %s must end with a slash" % name)
>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
>> with a slash
>>
>>
>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>> --value=/var/www/reviewboard/htdocs/media/
>>
>>
>>
>>
>> can't seem to get a list-siteconfig without the same error.
>>
>>
>> Steve.
>>
>>
>>
>>
>>
>>
>>
>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>
>>> You can use the set-siteconfig management command, like so:
>>>
>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>> --value=...
>>>
>>> Note the -- before the first flag. This is currently necessary for 
>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>
>>> Christian
>>>
>>>
>>> -- 
>> Supercharge your Review Board with Power Pack: 
>> https://www.reviewboard.org/powerpack/
>> Want us to host Review Board for you? Check out RBCommons: 
>> https://rbcommons.com/
>> Happy user? Let us know! https://www.reviewboard.org/users/
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "Review Board Community" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to revie...@googlegroups.com .
>> To view this discussion on the web visit 
>> https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com
>>  
>> <https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com?utm_medium=email&utm_source=footer>
>> .
>> For more options, visit https://groups.google.com/d/optout.
>>
> -- 
> -- 
> Christian Hammond
> President/CEO of Beanbag
> Makers of Review Board
>

-- 
Supercharge your Review Board with Power Pack: 
https://www.reviewboard.org/powerpack/
Want us to host Review Board for you? Check out RBCommons: 
https://rbcommons.com/
Happy user? Let us know! https://www.reviewboard.org/users/
--- 
You received this message because you are subscribed to the Google Groups 
"Review Board Community" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
To view this discussion on the web visit 
https://groups.google.com/d/msgid/reviewboard/74f2e570-c63a-49d0-a80f-e39966539536%40googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

Re: Page rendering and default route

[Steve]

Just comes back with the same error message below about " If set, MEDIA_URL 
must end with a slash". Doesn't seem to be able to get past the error.


Steve.



On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>
> These settings are stored in the database. What’s happening when you run 
> list-siteconfig?
>
> Christian
>
>
> On Sat, Jun 29, 2019 at 01:53 Steve > 
> wrote:
>
>> The test site I created within 3.0..showed the same as you describe so I 
>> tried /static/ and /media/ but still get the same error message. Trouble is 
>> I now cant run list-siteconfig on the site i'm upgrading so cant check 
>> other settings for conflicts. What settings should I set that relate to 
>> domain, only I cant see anything in the test site that would give me a 
>> clue. Or are we talking about settings in another file.
>>
>>
>> Steve.
>>
>>
>>  
>>
>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>
>>> Hi Steve,
>>>
>>> The URL parameters are used to build the URLs to media files. They must 
>>> be a path relative to the domain, or the absolute path to a server (CDN) 
>>> serving the files. You’re going to want to only set the “root” equivalents.
>>>
>>> Try setting site_static_url to /static/ and site_media_url to /media/.
>>>
>>> Christian
>>>
>>>
>>> On Thu, Jun 27, 2019 at 05:03 Steve  wrote:
>>>
>>>> re-set site_media_root and tried again but still the same issue.
>>>>
>>>> re-set site_static_url and then tried site_madia_url but keep getting 
>>>> this back
>>>>
>>>>
>>>>
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>>>  
>>>> line 326, in apply_django_settings
>>>> setter(settings, setting_key, value)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>>>> 242, in __setattr__
>>>> setattr(self._wrapped, name, value)
>>>>   File 
>>>> "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", line 
>>>> 110, 
>>>> in __setattr__
>>>> raise ImproperlyConfigured("If set, %s must end with a slash" % 
>>>> name)
>>>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
>>>> with a slash
>>>>
>>>>
>>>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>>>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>>>> --value=/var/www/reviewboard/htdocs/media/
>>>>
>>>>
>>>>
>>>>
>>>> can't seem to get a list-siteconfig without the same error.
>>>>
>>>>
>>>> Steve.
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>>>
>>>>> You can use the set-siteconfig management command, like so:
>>>>>
>>>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>>>> --value=...
>>>>>
>>>>> Note the -- before the first flag. This is currently necessary for 
>>>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>>>
>>>>> Christian
>>>>>
>>>>>
>>>>> -- 
>>>> Supercharge your Review Board with Power Pack: 
>>>> https://www.reviewboard.org/powerpack/
>>>> Want us to host Review Board for you? Check out RBCommons: 
>>>> https://rbcommons.com/
>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "Review Board Community" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to revie...@googlegroups.com.
>>>> To view this discussion on the web visit 
>>>> https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com
>>>>  
>>>> <https://groups.google.com/d/msgid/reviewboard/b0436597-3995-4349-ad4a-15b8d28615dd%40googlegroups.com?utm_medium=e

Re: Page rendering and default route

[Steve]

Hi Christian,

Any thoughts on getting past this error. Can I remove MEDIA_URL and add it 
back once I understand the problem.



Steve.



On Monday, 1 July 2019 10:02:52 UTC+1, Steve wrote:
>
> Just comes back with the same error message below about " If set, 
> MEDIA_URL must end with a slash". Doesn't seem to be able to get past the 
> error.
>
>
> Steve.
>
>
>
> On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>>
>> These settings are stored in the database. What’s happening when you run 
>> list-siteconfig?
>>
>> Christian
>>
>>
>> On Sat, Jun 29, 2019 at 01:53 Steve  wrote:
>>
>>> The test site I created within 3.0..showed the same as you describe so I 
>>> tried /static/ and /media/ but still get the same error message. Trouble is 
>>> I now cant run list-siteconfig on the site i'm upgrading so cant check 
>>> other settings for conflicts. What settings should I set that relate to 
>>> domain, only I cant see anything in the test site that would give me a 
>>> clue. Or are we talking about settings in another file.
>>>
>>>
>>> Steve.
>>>
>>>
>>>  
>>>
>>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>>
>>>> Hi Steve,
>>>>
>>>> The URL parameters are used to build the URLs to media files. They must 
>>>> be a path relative to the domain, or the absolute path to a server (CDN) 
>>>> serving the files. You’re going to want to only set the “root” equivalents.
>>>>
>>>> Try setting site_static_url to /static/ and site_media_url to /media/.
>>>>
>>>> Christian
>>>>
>>>>
>>>> On Thu, Jun 27, 2019 at 05:03 Steve  wrote:
>>>>
>>>>> re-set site_media_root and tried again but still the same issue.
>>>>>
>>>>> re-set site_static_url and then tried site_madia_url but keep getting 
>>>>> this back
>>>>>
>>>>>
>>>>>
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>>>>  
>>>>> line 326, in apply_django_settings
>>>>> setter(settings, setting_key, value)
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>>>>> 242, in __setattr__
>>>>> setattr(self._wrapped, name, value)
>>>>>   File 
>>>>> "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", line 
>>>>> 110, 
>>>>> in __setattr__
>>>>> raise ImproperlyConfigured("If set, %s must end with a slash" % 
>>>>> name)
>>>>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must 
>>>>> end with a slash
>>>>>
>>>>>
>>>>> svnadmin@NEO-SVN-SVR:/var/www/reviewboard$ sudo rb-site manage 
>>>>> /var/www/reviewboard set-siteconfig -- --key=site_media_url 
>>>>> --value=/var/www/reviewboard/htdocs/media/
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> can't seem to get a list-siteconfig without the same error.
>>>>>
>>>>>
>>>>> Steve.
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>> On Thursday, 27 June 2019 12:17:49 UTC+1, Christian Hammond wrote:
>>>>>>
>>>>>> You can use the set-siteconfig management command, like so:
>>>>>>
>>>>>> rb-site manage $sitedir set-siteconfig -- --key=site_media_root 
>>>>>> --value=...
>>>>>>
>>>>>> Note the -- before the first flag. This is currently necessary for 
>>>>>> ensuring the arguments are passed to set-siteconfig and not rb-site.
>>>>>>
>>>>>> Christian
>>>>>>
>>>>>>
>>>>>> -- 
>>>>> Supercharge your Review Board with Power Pack: 
>>>>> https://www.reviewboard.org/powerpack/
>>>>> Want us to host Review Board for you? Check out RBCommons: 
>>>>> https://rbcommons.com/
>>>>> Happy user? Let us know! https://www.reviewboard.org/users/
>>>&

Re: Page rendering and default route

[Steve]

I've tried the four keys below including values for these keys that are 
incorrect just to try and get a different result but is always the same. 
whether I list-siteconfig or try and set 'site_media_url' to '/media/' or 
any other keys, this error below is persistent. Cant seem to get past it.

Interestingly the response says "if set" does that mean I can remove it 
temporarily.



svnadmin@NEO-SVN-SVR:~$ sudo rb-site manage /var/www/reviewboard 
set-siteconfig -- --key=site_media_url --value=/media/
Traceback (most recent call last):
  File "/usr/local/bin/rb-site", line 11, in 
load_entry_point('ReviewBoard==3.0.15', 'console_scripts', 'rb-site')()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
 
line 1972, in main
command.run()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
 
line 1881, in run
initialize()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/__init__.py",
 
line 114, in initialize
load_site_config()
  File 
"/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/admin/siteconfig.py",
 
line 294, in load_site_config
apply_django_settings(siteconfig, settings_map)
  File 
"/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
 
line 326, in apply_django_settings
setter(settings, setting_key, value)
  File "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", 
line 242, in __setattr__
setattr(self._wrapped, name, value)
  File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
line 110, in __setattr__
raise ImproperlyConfigured("If set, %s must end with a slash" % name)
django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
with a slash





On Thursday, 11 July 2019 10:36:32 UTC+1, Christian Hammond wrote:
>
> Hi Steve,
>
> You need to set the following using set-siteconfig:
>
> site_media_url=/media/
> site_static_url=/static/
> site_static_root=/var/www/reviewboard/htdocs/static/
> site_media_root=/var/www/reviewboard/htdocs/media/
>
> I think from the example you gave, you're mixing up the site roots and 
> URLs.
>
> Sorry I haven't gotten back to you until now. Our paid support channel 
> takes a lot of my support time these days.
>
> Christian
>
> On Thu, Jul 11, 2019 at 1:56 AM Steve > 
> wrote:
>
>> Hi Christian,
>>
>> Any thoughts on getting past this error. Can I remove MEDIA_URL and add 
>> it back once I understand the problem.
>>
>>
>>
>> Steve.
>>
>>
>>
>> On Monday, 1 July 2019 10:02:52 UTC+1, Steve wrote:
>>>
>>> Just comes back with the same error message below about " If set, 
>>> MEDIA_URL must end with a slash". Doesn't seem to be able to get past the 
>>> error.
>>>
>>>
>>> Steve.
>>>
>>>
>>>
>>> On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>>>>
>>>> These settings are stored in the database. What’s happening when you 
>>>> run list-siteconfig?
>>>>
>>>> Christian
>>>>
>>>>
>>>> On Sat, Jun 29, 2019 at 01:53 Steve  wrote:
>>>>
>>>>> The test site I created within 3.0..showed the same as you describe so 
>>>>> I tried /static/ and /media/ but still get the same error message. 
>>>>> Trouble 
>>>>> is I now cant run list-siteconfig on the site i'm upgrading so cant check 
>>>>> other settings for conflicts. What settings should I set that relate to 
>>>>> domain, only I cant see anything in the test site that would give me a 
>>>>> clue. Or are we talking about settings in another file.
>>>>>
>>>>>
>>>>> Steve.
>>>>>
>>>>>
>>>>>  
>>>>>
>>>>> On Saturday, 29 June 2019 05:37:08 UTC+1, Christian Hammond wrote:
>>>>>>
>>>>>> Hi Steve,
>>>>>>
>>>>>> The URL parameters are used to build the URLs to media files. They 
>>>>>> must be a path relative to the domain, or the absolute path to a server 
>>>>>> (CDN) serving the files. You’re going to want to only set the “root” 
>>>>>> equivalents.
>>>>>>
>>>>>> Try setting site_static_url to /static

Re: Page rendering and default route

[Steve]

Yes, used SQL a while back.

I'll take a look



Steve.




On Friday, 12 July 2019 19:41:25 UTC+1, Christian Hammond wrote:
>
> I see what’s going on... it’s in a sort of stuck state. Django is trying 
> to validate those URLs before you’re able to set new ones.
>
> You’re going to have to hand-edit the JSON data in the 
> siteconfig_siteconfiguration table in the database. There’s a single row 
> there containing all the JSON data you see in list-siteconfig (though more 
> compact).
>
> Are you familiar with SQL?
>
> Christian 
>
>
> On Thu, Jul 11, 2019 at 03:17 Steve > 
> wrote:
>
>> I've tried the four keys below including values for these keys that are 
>> incorrect just to try and get a different result but is always the same. 
>> whether I list-siteconfig or try and set 'site_media_url' to '/media/' or 
>> any other keys, this error below is persistent. Cant seem to get past it.
>>
>> Interestingly the response says "if set" does that mean I can remove it 
>> temporarily.
>>
>>
>>
>> svnadmin@NEO-SVN-SVR:~$ sudo rb-site manage /var/www/reviewboard 
>> set-siteconfig -- --key=site_media_url --value=/media/
>> Traceback (most recent call last):
>>   File "/usr/local/bin/rb-site", line 11, in 
>> load_entry_point('ReviewBoard==3.0.15', 'console_scripts', 
>> 'rb-site')()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
>>  
>> line 1972, in main
>> command.run()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/cmdline/rbsite.py",
>>  
>> line 1881, in run
>> initialize()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/__init__.py",
>>  
>> line 114, in initialize
>> load_site_config()
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/ReviewBoard-3.0.15-py2.7.egg/reviewboard/admin/siteconfig.py",
>>  
>> line 294, in load_site_config
>> apply_django_settings(siteconfig, settings_map)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/Djblets-1.0.12-py2.7.egg/djblets/siteconfig/django_settings.py",
>>  
>> line 326, in apply_django_settings
>> setter(settings, setting_key, value)
>>   File 
>> "/usr/local/lib/python2.7/dist-packages/django/utils/functional.py", line 
>> 242, in __setattr__
>> setattr(self._wrapped, name, value)
>>   File "/usr/local/lib/python2.7/dist-packages/django/conf/__init__.py", 
>> line 110, in __setattr__
>> raise ImproperlyConfigured("If set, %s must end with a slash" % name)
>> django.core.exceptions.ImproperlyConfigured: If set, MEDIA_URL must end 
>> with a slash
>>
>>
>>
>>
>>
>> On Thursday, 11 July 2019 10:36:32 UTC+1, Christian Hammond wrote:
>>>
>>> Hi Steve,
>>>
>>> You need to set the following using set-siteconfig:
>>>
>>> site_media_url=/media/
>>> site_static_url=/static/
>>> site_static_root=/var/www/reviewboard/htdocs/static/
>>> site_media_root=/var/www/reviewboard/htdocs/media/
>>>
>>> I think from the example you gave, you're mixing up the site roots and 
>>> URLs.
>>>
>>> Sorry I haven't gotten back to you until now. Our paid support channel 
>>> takes a lot of my support time these days.
>>>
>>> Christian
>>>
>>> On Thu, Jul 11, 2019 at 1:56 AM Steve  wrote:
>>>
>> Hi Christian,
>>>>
>>>> Any thoughts on getting past this error. Can I remove MEDIA_URL and add 
>>>> it back once I understand the problem.
>>>>
>>>>
>>>>
>>>> Steve.
>>>>
>>>>
>>>>
>>>> On Monday, 1 July 2019 10:02:52 UTC+1, Steve wrote:
>>>>>
>>>>> Just comes back with the same error message below about " If set, 
>>>>> MEDIA_URL must end with a slash". Doesn't seem to be able to get past the 
>>>>> error.
>>>>>
>>>>>
>>>>> Steve.
>>>>>
>>>>>
>>>>>
>>>>> On Sunday, 30 June 2019 22:53:04 UTC+1, Christian Hammond wrote:
>>>>>>
>>>>>> These settings are stored in the database. What’s happening when you 
>>>>>>

How do I get logging for active directory backend?

[Steve]

I'm trying to migrate from 1.5 to 1.6. In 1.5, I had this in my 
settings_local.py file:

AD_DEBUG = True
AD_DEBUG_FILE = '/var/www/reviewboard/logs/ldap.debug'

Which was essential for debugging authentication problems. In fact, I had 
all my AD settings in settings_local.py.

For 1.6, these settings aren't having any affect at all, as far as I can 
tell. It appears things have moved or been renamed.  I'm not getting an 
ldap.debug file. When I use the web interface for configuration, the only 
place I can find to set logging is in the general logging pane. I have that 
enabled, but I'm only getting stuff like this:

2012-10-01 08:51:54,429 - DEBUG - Logging to 
/var/www/reviewboard/logs/reviewboard.log with a minimum level of DEBUG
2012-10-01 08:51:54,430 - DEBUG - Log file for Review Board v1.6.9 (PID 
12370)

So 2 questions:

1. How can I get debug information for my active directory authentication?
2. What are my non-web ui options for configuration settings?

Thanks!

--Steve



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

RB 1.6 - what is the new URI for logging in via the new API?

[Steve]

We have an old Perl script we use to create reviews. It was written against 
the old 1.5 API and I'm looking at porting it to the new 1.6 API. 
Unfortunately, I can't get past the login step. In the old script we used 
this uri:

api/json/account/login/

I've tried various alternative paths for the new API and looked in the code 
for postreview.py,  but have not made any progress and decided it was time 
to ask:

What is the login uri under the new API?

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: RB 1.6 - what is the new URI for logging in via the new API?

[Steve]

Knowing that I was able to get it working. Thanks David.

--steve

On Monday, October 8, 2012 4:54:09 PM UTC-7, David Trowbridge wrote:
>
> There's no specific login URL. The new API uses HTTP Basic 
> authentication for all requests. 
>
> -David 
>
>
> On Mon, Oct 8, 2012 at 4:47 PM, Steve > 
> wrote: 
> > We have an old Perl script we use to create reviews. It was written 
> against 
> > the old 1.5 API and I'm looking at porting it to the new 1.6 API. 
> > Unfortunately, I can't get past the login step. In the old script we 
> used 
> > this uri: 
> > 
> > api/json/account/login/ 
> > 
> > I've tried various alternative paths for the new API and looked in the 
> code 
> > for postreview.py,  but have not made any progress and decided it was 
> time 
> > to ask: 
> > 
> > What is the login uri under the new API? 
> > 
> > Thanks 
> > 
> > --Steve 
> > 
> > -- 
> > Want to help the Review Board project? Donate today at 
> > http://www.reviewboard.org/donate/ 
> > Happy user? Let us know at http://www.reviewboard.org/users/ 
> > -~--~~~~--~~--~--~--- 
> > To unsubscribe from this group, send email to 
> > reviewboard...@googlegroups.com  
> > For more options, visit this group at 
> > http://groups.google.com/group/reviewboard?hl=en 
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

RB 1.5.5: User can no longer access his own review - MultipleObjectsReturned error

[Steve]

I have a user who has a review which has been ongoing for several days with 
numerous comments. Yesterday when he tried to add another comment he 
received an error page from review board. The error message in the log is:

MultipleObjectsReturned: get() returned more than one Review -- it returned 
2! Lookup parameters were {'base_reply_to': , 
'user': , 'public': False}


I'm able to access the review and make comments, as is everyone else on the 
review, but the user can't. He has tried 2 different browsers, cleared his 
browser cache and even rebooted his machine. I don't know which table in 
the db that query is looking in, put the review is public.  The mod python 
request is:

'PATH_INFO': 
u'/api/json/reviewrequests/49901/reviews/183574/replies/draft/discard/'

Which seems odd, because that's not the only action he's attempting, but he 
keeps getting that error, as if the request is somehow cached.

I'm at a loss as to how to proceed. There's been so much activity on this 
review that abandoning it would be a last resort. Can anyone point me in a 
direction that might help me to fix this?

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: RB 1.5.5: User can no longer access his own review - MultipleObjectsReturned error

[Steve]

I think I found the offending db entry 

mysql> select * from reviews_review where id=49901 \G



*** 19. row ***
 id: 183820
  review_request_id: 49901
user_id: 439
  timestamp: 2012-10-11 14:06:11
 public: 0
ship_it: 0
   base_reply_to_id: 183574
   email_message_id: NULL
   time_emailed: NULL
   body_top: I think I got em.
body_bottom:
   body_top_reply_to_id: 183574
body_bottom_reply_to_id: NULL
reviewed_diffset_id: NULL
*** 20. row ***
 id: 183821
  review_request_id: 49901
user_id: 439
  timestamp: 2012-10-11 14:06:11
 public: 0
ship_it: 0
   base_reply_to_id: 183574
   email_message_id: NULL
   time_emailed: NULL
   body_top:
body_bottom:
   body_top_reply_to_id: NULL
body_bottom_reply_to_id: NULL
reviewed_diffset_id: NULL

Both of those have the same base_reply_id number, the one I keep seeing in 
the stack trace.

The million dollar question - can I safely delete the second of those 
entries, or will that cause me no end of trouble?

--Steve


On Friday, October 12, 2012 8:47:52 AM UTC-7, Steve wrote:
>
> I have a user who has a review which has been ongoing for several days 
> with numerous comments. Yesterday when he tried to add another comment he 
> received an error page from review board. The error message in the log is:
>
> MultipleObjectsReturned: get() returned more than one Review -- it 
> returned 2! Lookup parameters were {'base_reply_to':  'x'>, 'user': , 'public': False}
>
>
> I'm able to access the review and make comments, as is everyone else on 
> the review, but the user can't. He has tried 2 different browsers, cleared 
> his browser cache and even rebooted his machine. I don't know which table 
> in the db that query is looking in, put the review is public.  The mod 
> python request is:
>
> 'PATH_INFO': 
> u'/api/json/reviewrequests/49901/reviews/183574/replies/draft/discard/'
>
> Which seems odd, because that's not the only action he's attempting, but 
> he keeps getting that error, as if the request is somehow cached.
>
> I'm at a loss as to how to proceed. There's been so much activity on this 
> review that abandoning it would be a last resort. Can anyone point me in a 
> direction that might help me to fix this?
>
> --Steve
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: RB 1.5.5: User can no longer access his own review - MultipleObjectsReturned error

[Steve]

False alarm. Those aren't duplicate entries, they're unique entries in 
response to the same comment.

Back to square 1.



On Friday, October 12, 2012 9:43:38 AM UTC-7, Steve wrote:
>
> I think I found the offending db entry 
>
> mysql> select * from reviews_review where id=49901 \G
>
> 
>
> *** 19. row ***
>  id: 183820
>   review_request_id: 49901
> user_id: 439
>   timestamp: 2012-10-11 14:06:11
>  public: 0
> ship_it: 0
>base_reply_to_id: 183574
>email_message_id: NULL
>time_emailed: NULL
>body_top: I think I got em.
> body_bottom:
>body_top_reply_to_id: 183574
> body_bottom_reply_to_id: NULL
> reviewed_diffset_id: NULL
> *** 20. row ***
>  id: 183821
>   review_request_id: 49901
> user_id: 439
>   timestamp: 2012-10-11 14:06:11
>  public: 0
> ship_it: 0
>base_reply_to_id: 183574
>email_message_id: NULL
>time_emailed: NULL
>body_top:
> body_bottom:
>body_top_reply_to_id: NULL
> body_bottom_reply_to_id: NULL
> reviewed_diffset_id: NULL
>
> Both of those have the same base_reply_id number, the one I keep seeing in 
> the stack trace.
>
> The million dollar question - can I safely delete the second of those 
> entries, or will that cause me no end of trouble?
>
> --Steve
>
>
> On Friday, October 12, 2012 8:47:52 AM UTC-7, Steve wrote:
>>
>> I have a user who has a review which has been ongoing for several days 
>> with numerous comments. Yesterday when he tried to add another comment he 
>> received an error page from review board. The error message in the log is:
>>
>> MultipleObjectsReturned: get() returned more than one Review -- it 
>> returned 2! Lookup parameters were {'base_reply_to': > 'x'>, 'user': , 'public': False}
>>
>>
>> I'm able to access the review and make comments, as is everyone else on 
>> the review, but the user can't. He has tried 2 different browsers, cleared 
>> his browser cache and even rebooted his machine. I don't know which table 
>> in the db that query is looking in, put the review is public.  The mod 
>> python request is:
>>
>> 'PATH_INFO': 
>> u'/api/json/reviewrequests/49901/reviews/183574/replies/draft/discard/'
>>
>> Which seems odd, because that's not the only action he's attempting, but 
>> he keeps getting that error, as if the request is somehow cached.
>>
>> I'm at a loss as to how to proceed. There's been so much activity on this 
>> review that abandoning it would be a last resort. Can anyone point me in a 
>> direction that might help me to fix this?
>>
>> --Steve
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: RB 1.5.5: User can no longer access his own review - MultipleObjectsReturned error

[Steve]

On Friday, October 12, 2012 10:05:39 AM UTC-7, Christian Hammond wrote:
>
> You're close. It's two reviews with different IDs from the same user on 
> the same review request that are both still set to public=false.
>
> This really shouldn't be happening. It used to, but the cause was found 
> and fixed long ago. Please let us know if it happens again.
>

Is there something I can do to fix this entry to the user can access his 
review? Right now he's blocked. Would setting public=true in the db fix the 
problem?

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: RB 1.5.5: User can no longer access his own review - MultipleObjectsReturned error

[Steve]

Yes, that fixed the problem. Thanks!!

--steve


On Friday, October 12, 2012 10:20:52 AM UTC-7, Christian Hammond wrote:
>
> Just delete one of the draft reviews. It should take care of it.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Fri, Oct 12, 2012 at 10:15 AM, Steve  >wrote:
>
>>
>>
>> On Friday, October 12, 2012 10:05:39 AM UTC-7, Christian Hammond wrote:
>>>
>>> You're close. It's two reviews with different IDs from the same user on 
>>> the same review request that are both still set to public=false.
>>>
>>> This really shouldn't be happening. It used to, but the cause was found 
>>> and fixed long ago. Please let us know if it happens again.
>>>
>>
>> Is there something I can do to fix this entry to the user can access his 
>> review? Right now he's blocked. Would setting public=true in the db fix the 
>> problem?
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

API: adding a comment to a review request

[Steve]

When creating a new review via a wrapper script to post-review, I'd like to 
add an additional comment to the review.  Which API resource url would I 
use for that?

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: API: adding a comment to a review request

[Steve]

This seems to be doing what I want:

server.set_review_request_field(review_request, 'changedescription', 
description)

which is equivalent to:

server.api_put(review_request['links']['draft']['href'], {
   'changedescription': description,
})

--Steve


On Wednesday, December 12, 2012 3:13:11 PM UTC-8, Steve wrote:
>
> When creating a new review via a wrapper script to post-review, I'd like 
> to add an additional comment to the review.  Which API resource url would I 
> use for that?
>
> --Steve
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Cannot access the main page for a review

[Steve]

Since this original post from last year, I've seen this problem numerous 
time. Most recently today on our main 1.5.5 server.  It's quite pesky, so 
I'm coming back with a few more questions.

First, here's a recap.

Many of our users paste the content of large, complex test output files 
into the 'Testing Done' field. Sometimes, these break access to the main 
page for the review. When we click on the link, we get a 

Something Broke (Error 500)

page. I get a Django error email with this error message:

==

 File "", line 1

   {"testing_done": {"new": ["More tests (caught a bug that was missed in 
review) :) Will upload the new set of diffs\n\n>>> 
b.Security.ProfileDoS.get_protocol_sip(profile_names=['sip_dos_1']) 
 



b.Security.ProfileDoS.get_protocol_sip_error_attack_detection_sta

^

SyntaxError: EOL while scanning single-quoted string


==

What's odd is I can't access the main page for the review, but I can go to 
the diff_header page and see everything, including the 'Testing Done' 
field. So this produces the 500 error:

https://reviewboard/r/123/

But this works fine:

https://reviewboard/r/123/diff/#index_header

So my questions are:

1. Why does this text break the main page, but show up fine on the 
diff_header page.

2. Is there any way for me to repair a review once it gets in this state?

3. What guidelines can I give my users to prevent this problem from 
happening?

Thanks!



On Friday, February 24, 2012 1:18:47 PM UTC-8, Steve wrote:
>
> Hi Christian,
>
> I'm guessing the broken review can't be fixed. Though I don't understand 
> why removing that big text string directly from the database table didn't 
> work.  What would be the closest version to 1.5.5 where the string limit 
> was increased. The mysql settings I see in 1.5.5 are for the table that I 
> think is causing the problem are:
>
> Table changedescs_changedescription
> ===
> id, timestamp, public, text, fields_changed
> ---
> id   int(11) PK
> timestampdatetime
> public   tinyint(1)
> text     longtext
> fields_changed   text
>
>
> The offending text was in the fields_change entry.
>
> Thanks
>
> --Steve
>
>
> On Thursday, February 23, 2012 2:26:27 PM UTC-8, Steve wrote:
>>
>> Thanks Christian,
>>
>> I'm running 1.5.5 on a Centos 5 box. I attempted replacing the long 
>> string with an empty one in the
>>
>> reviewboard.changedescs_changedescription 
>>
>> table. In the "fields_changed" dict the bad text was in the "old" entry 
>> for testing_done. I set the "old" entry to [""], but that didn't fix the 
>> problem.
>>
>> --Steve
>>
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Post-review asks for password even with active cookie.

[Steve]

I noticed the same behavior when I had my user name set in .reviewboardrc. 
Removing that entry stopped the password prompts.

---Steve

On Thursday, January 10, 2013 12:46:55 PM UTC-8, sholsapp wrote:
>
> I've noticed that post-review will prompt me for a password even if I have 
> an active cookie. As a result, when prompted for a password, I can enter 
> gibberish and still successfully post a review.
>
> I don't see any options in post-review that allow me to say "[use|don't 
> use] cookie if available". Is this a bug? 
>
> -Steve
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Testing Done field frequently breaks reviews

[Steve]

I get about 1 of these per month, but I have 2 this week and it's getting 
to be a real problem. Developers paste large amounts of text into the 
Testing Done field, after which going to the main page for the review 
yields this:

 
Something broke! (Error 500) 

It appears something broke when you tried to go to here. This is 
either a bug in Review Board or a server configuration error. Please 
report this to your administrator. 
 

The odd thing is we can go around the main page to the diff page and see 
the text in Testing Done, which is baffling. In other words,

http://reviewboard/r/123

fails with the above error, but

http://reviewboard/r/123/diff/#index_header

looks fine.  This is really causing problems for our developers.  I have 3 
questions in descending order of importance:

1. How can I repair a review when it gets in this state?
2. What guidelines can I give my developers to prevent this from happening?
3. Why does the main page fail, when the text appears to be fine in the 
diff_header page?

We're using 1.5.5 on CentOS 5.

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Testing Done field frequently breaks reviews

[Steve]

I have a 1.6 server staged for testing that I'm planning to roll out soon. 
I'll import the latest database and see if the problem shows up there as 
well.

As for 

> Tell developers not to paste so much :) 

I thought it was the size of the text also, but I'm beginning to think it's 
not. I've been unable to reproduce with text much greater than what's being 
used in the broken reviews. I think it has something to do with the 
content. In many cases actual test scripts are being uploaded, which means 
they're filled with quotes, {} and other things that could be problematic 
to a parser.

I'll try repairing it through the admin UI.  I don't suppose I could make 
it any worse.

--Steve


On Wednesday, January 16, 2013 11:26:18 AM UTC-8, Christian Hammond wrote:
>
> Hi Steve,
>
> This breaks on the review request page because the Testing Done text is 
> being stored in a JSON structure along with other data for the "Review 
> request updated" sections. These sections do not show on the diff viewer.
>
> Repairing this would require going into the database viewer in the 
> administration UI, locating the Change Description table for the change (we 
> don't give you the easiest ways to do that, so you'll have to try narrowing 
> it down by date), and fixing the content to be valid JSON. YMMV.
>
> Tell developers not to paste so much :)
>
> Actually, the reason you're having this problem is that your release is so 
> old. If you upgrade, this shouldn't happen on newer review requests.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com
>
>
> On Wed, Jan 16, 2013 at 10:55 AM, Steve  >wrote:
>
>> I get about 1 of these per month, but I have 2 this week and it's getting 
>> to be a real problem. Developers paste large amounts of text into the 
>> Testing Done field, after which going to the main page for the review 
>> yields this:
>>
>>  
>> Something broke! (Error 500) 
>>
>> It appears something broke when you tried to go to here. This is 
>> either a bug in Review Board or a server configuration error. Please 
>> report this to your administrator. 
>>  
>>
>> The odd thing is we can go around the main page to the diff page and see 
>> the text in Testing Done, which is baffling. In other words,
>>
>> http://reviewboard/r/123
>>
>> fails with the above error, but
>>
>> http://reviewboard/r/123/diff/#index_header
>>
>> looks fine.  This is really causing problems for our developers.  I have 
>> 3 questions in descending order of importance:
>>
>> 1. How can I repair a review when it gets in this state?
>> 2. What guidelines can I give my developers to prevent this from 
>> happening?
>> 3. Why does the main page fail, when the text appears to be fine in the 
>> diff_header page?
>>
>> We're using 1.5.5 on CentOS 5.
>>
>> Thanks
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Testing Done field frequently breaks reviews

[Steve]

I just read this again more carefully:

> Actually, the reason you're having this problem is that your release is 
so old. If you upgrade, this shouldn't happen on newer review requests.

That sounds like even on the new server this particular review will be 
broken, but new reviews should not end up in this state.  Is that right?

--Steve


On Wednesday, January 16, 2013 10:55:34 AM UTC-8, Steve wrote:
>
> I get about 1 of these per month, but I have 2 this week and it's getting 
> to be a real problem. Developers paste large amounts of text into the 
> Testing Done field, after which going to the main page for the review 
> yields this:
>
>  
> Something broke! (Error 500) 
>
> It appears something broke when you tried to go to here. This is 
> either a bug in Review Board or a server configuration error. Please 
> report this to your administrator. 
>  
>
> The odd thing is we can go around the main page to the diff page and see 
> the text in Testing Done, which is baffling. In other words,
>
> http://reviewboard/r/123
>
> fails with the above error, but
>
> http://reviewboard/r/123/diff/#index_header
>
> looks fine.  This is really causing problems for our developers.  I have 3 
> questions in descending order of importance:
>
> 1. How can I repair a review when it gets in this state?
> 2. What guidelines can I give my developers to prevent this from happening?
> 3. Why does the main page fail, when the text appears to be fine in the 
> diff_header page?
>
> We're using 1.5.5 on CentOS 5.
>
> Thanks
>
> --Steve
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Re: Testing Done field frequently breaks reviews

[Steve]

Excellent - thanks Chris!

On Wednesday, January 16, 2013 2:39:20 PM UTC-8, Christian Hammond wrote:
>
> It won't fix existing review requests. The data is truncated at write, so 
> you have to fix it manually, by hand. It will only prevent the problem for 
> new review requests.
>
> It's certainly not the content. This is an old, very well known and tested 
> bug. The problem is that there's only so much room in the field used to 
> store the JSON payload, which contains the whole of all the changes made 
> since the last draft. If you had a very long Testing Done, or a smaller 
> Testing Done with a Description and other fields, or whatever combination, 
> you can trigger this. It also stores the old and new versions. So going 
> from a large Testing Done to another large Testing Done would result in 
> this as well.
>
> The fix was to migrate to a larger field that could store much larger data 
> sets, more than you'll ever actually end up putting into it. That was done 
> at some point in the 1.6 releases. The upgrade to the new field should be 
> automatic when upgrading the site.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Jan 16, 2013, at 2:35 PM, Steve > 
> wrote:
>
> I have a 1.6 server staged for testing that I'm planning to roll out soon. 
> I'll import the latest database and see if the problem shows up there as 
> well.
>
> As for 
>
> > Tell developers not to paste so much :) 
>
> I thought it was the size of the text also, but I'm beginning to think 
> it's not. I've been unable to reproduce with text much greater than what's 
> being used in the broken reviews. I think it has something to do with the 
> content. In many cases actual test scripts are being uploaded, which means 
> they're filled with quotes, {} and other things that could be problematic 
> to a parser.
>
> I'll try repairing it through the admin UI.  I don't suppose I could make 
> it any worse.
>
> --Steve
>
>
> On Wednesday, January 16, 2013 11:26:18 AM UTC-8, Christian Hammond wrote:
>>
>> Hi Steve,
>>
>> This breaks on the review request page because the Testing Done text is 
>> being stored in a JSON structure along with other data for the "Review 
>> request updated" sections. These sections do not show on the diff viewer.
>>
>> Repairing this would require going into the database viewer in the 
>> administration UI, locating the Change Description table for the change (we 
>> don't give you the easiest ways to do that, so you'll have to try narrowing 
>> it down by date), and fixing the content to be valid JSON. YMMV.
>>
>> Tell developers not to paste so much :)
>>
>> Actually, the reason you're having this problem is that your release is 
>> so old. If you upgrade, this shouldn't happen on newer review requests.
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com
>>
>>
>> On Wed, Jan 16, 2013 at 10:55 AM, Steve  wrote:
>>
>>> I get about 1 of these per month, but I have 2 this week and it's 
>>> getting to be a real problem. Developers paste large amounts of text into 
>>> the Testing Done field, after which going to the main page for the review 
>>> yields this:
>>>
>>>  
>>> Something broke! (Error 500) 
>>>
>>> It appears something broke when you tried to go to here. This is 
>>> either a bug in Review Board or a server configuration error. Please 
>>> report this to your administrator. 
>>>  
>>>
>>> The odd thing is we can go around the main page to the diff page and see 
>>> the text in Testing Done, which is baffling. In other words,
>>>
>>> http://reviewboard/r/123
>>>
>>> fails with the above error, but
>>>
>>> http://reviewboard/r/123/diff/#index_header
>>>
>>> looks fine.  This is really causing problems for our developers.  I have 
>>> 3 questions in descending order of importance:
>>>
>>> 1. How can I repair a review when it gets in this state?
>>> 2. What guidelines can I give my developers to prevent this from 
>>> happening?
>>> 3. Why does the main page fail, when the text appears to be fine in the 
>>> di

Re: Testing Done field frequently breaks reviews

[Steve]

> Repairing this would require going into the database viewer in the 
administration UI, locating the Change Description table for the change (we 
don't give you the easiest ways to do that, so you'll have to try narrowing 
it down by date), and fixing the content to be valid JSON. YMMV.

When I go to the database viewer in the admin UI and click on the link for 
'Change descriptions', I get the same 500 error and the same Django error 
stacktrace.  So I can't access any of the change descriptions through the 
UI. That's on the 1.5.5 server. I haven't tried it on the 1.6 server. 

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en

Web API: How to get the review id from the perforce change list number?

[Steve]

 

We have a perforce trigger that looks at the submitted change list number and 
makes an API call to review board to see if there is a corresponding review. If 
found, the url for the review is added to the submitted change list.  Using the 
Web API 1.0, we use this url

api/json/reviewrequests/repository/$repo/changenum/$changelist

which works fine. I need to port this code to Web API 2.0.  Using this url:

api/review-requests?changenum=$changelist

works for open reviews, but not for reviews that have been marked as submitted. 
 I get back a review request structure, but the  'review_requests' list, which 
is where the id number is found,  is empty.  Is there some way I can get the 
review board id from a change list number for a review marked as submitted? 
Perhaps a different url that I'm missing?


--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Web API: How to get the review id from the perforce change list number?

[Steve]

For some reason my initial post got mangled. Here it is again in briefer 
form:

I need to be able to query the Web API to get the RB ID given a perforce 
change list number.  With the 1.0 API, this url works:

api/json/reviewrequests/repository/$repo/changenum/$changelist

With the 2.0 API, I've tried this:

api/review-requests?changenum=$changelist

This works for open reviews, but I get an empty review_requests list back 
when a review has been marked as submitted.  Is there some way I can do 
this for submitted reviews? Some other url that I'm missing?

Thanks

--Steve



On Wednesday, February 27, 2013 7:52:35 AM UTC-8, Steve wrote:
>
>  We have a perforce trigger that looks at the submitted change list number 
> and makes an API call to review board to see if there is a corresponding 
> review. If found, the url for the review is added to the submitted change 
> list.  Using the Web API 1.0, we use this url
>
> api/json/reviewrequests/repository/$repo/changenum/$changelist
>
> which works fine. I need to port this code to Web API 2.0.  Using this url:
>
> api/review-requests?changenum=$changelist
>
> works for open reviews, but not for reviews that have been marked as 
> submitted.  I get back a review request structure, but the  'review_requests' 
> list, which is where the id number is found,  is empty.  Is there some way I 
> can get the review board id from a change list number for a review marked as 
> submitted? Perhaps a different url that I'm missing?
>
>
> --Steve
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Web API: How to get the review id from the perforce change list number?

[Steve]

Perfect!  Thank you Raja.

On Wednesday, February 27, 2013 8:53:10 AM UTC-8, Raja wrote:
>
> You can add a status=submitted to the query string, so something like
> api/review-requests?changenum=$changelist&status=submitted
>
> should get you the Submitted Requests. Same holds for "discarded" status 
> as well. The default is "pending", which is why you dont see the other 
> requests. I dont see a way to enter multiple status-es, maybe file an 
> enhancement request for that?
>
> Regards
> Raja
>
>
>
> On Wed, Feb 27, 2013 at 9:32 PM, Steve  >wrote:
>
>> For some reason my initial post got mangled. Here it is again in briefer 
>> form:
>>
>> I need to be able to query the Web API to get the RB ID given a perforce 
>> change list number.  With the 1.0 API, this url works:
>>
>> api/json/reviewrequests/repository/$repo/changenum/$changelist
>>
>> With the 2.0 API, I've tried this:
>>
>> api/review-requests?changenum=$changelist
>>
>> This works for open reviews, but I get an empty review_requests list back 
>> when a review has been marked as submitted.  Is there some way I can do 
>> this for submitted reviews? Some other url that I'm missing?
>>
>> Thanks
>>
>> --Steve
>>
>>
>>
>> On Wednesday, February 27, 2013 7:52:35 AM UTC-8, Steve wrote:
>>>
>>>  We have a perforce trigger that looks at the submitted change list number 
>>> and makes an API call to review board to see if there is a corresponding 
>>> review. If found, the url for the review is added to the submitted change 
>>> list.  Using the Web API 1.0, we use this url
>>>
>>> api/json/reviewrequests/**repository/$repo/changenum/$**changelist
>>>
>>> which works fine. I need to port this code to Web API 2.0.  Using this url:
>>>
>>> api/review-requests?changenum=**$changelist
>>>
>>> works for open reviews, but not for reviews that have been marked as 
>>> submitted.  I get back a review request structure, but the  
>>> 'review_requests' list, which is where the id number is found,  is empty.  
>>> Is there some way I can get the review board id from a change list number 
>>> for a review marked as submitted? Perhaps a different url that I'm missing?
>>>
>>>
>>> --Steve
>>>
>>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Error on 1.5 -> 1.7.1 upgrade: Model 'reviews.FileAttachmentComment' already has a field named 'extra_data'

[Steve]

I can also test it on my sandbox which is currently in this state.

--steve


On Wednesday, February 27, 2013 12:05:31 AM UTC-8, Christian Hammond wrote:
>
> Hi again,
>
> I actually think I may have a fix for Django Evolution, but I will need 
> volunteers to test. I'll be sending out an e-mail with instructions shortly.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Feb 26, 2013, at 9:00 PM, Nachiketh G > 
> wrote:
>
> Hi Sebastien/Christian,
> I tried the upgrading from a 1.0 release of RB to 1.7.x and ran into the 
> exact same error when I did a "rb-site upgrade". 
> *Error: Model 'reviews.FileAttachmentComment' already has a field named 
> 'extra_data'*
>
> Were you guys able to find a solution to this problem? Do let me know.
> Thanks & Regards,
> Nachiketh
>
>
> On Thursday, 27 December 2012 20:45:22 UTC+5:30, Sébastien Douche wrote:
>>
>> Hi, 
>> I'm trying to upgrade RB to the last version: 
>>
>> rd1:~/ReviewBoard-1.7.1# rb-site upgrade /srv/reviewboard 
>> Rebuilding directory structure 
>> Updating database. This may take a while. 
>>
>> The log output below, including warnings and errors, 
>> can be ignored unless upgrade fails. 
>>
>> --  -- 
>> /usr/local/lib/python2.6/dist-packages/Djblets-0.7.7-py2.6.egg/djblets/gravatars/__init__.py:26:
>>  
>>
>> DeprecationWarning: the md5 module is deprecated; use hashlib instead 
>>   from md5 import md5 
>> Creating tables ... 
>> Creating table extensions_registeredextension 
>> Creating table accounts_localsiteprofile 
>> Creating table attachments_fileattachment 
>> Creating table diffviewer_filediffdata 
>> Creating table hostingsvcs_hostingserviceaccount 
>> Creating table reviews_fileattachmentcomment 
>> Creating table site_localsite_users 
>> Creating table site_localsite_admins 
>> Creating table site_localsite 
>> Upgrading Review Board from 1.5 to 1.7.1 
>> There are unapplied evolutions for auth. 
>> There are unapplied evolutions for sessions. 
>> There are unapplied evolutions for accounts. 
>> There are unapplied evolutions for changedescs. 
>> There are unapplied evolutions for diffviewer. 
>> There are unapplied evolutions for reviews. 
>> There are unapplied evolutions for scmtools. 
>> Adding baseline version for new models 
>> Project signature has changed - an evolution is required 
>> Installing custom SQL ... 
>> Installing indexes ... 
>> Installed 0 object(s) from 0 fixture(s) 
>> Registering new SCM Tool Plastic SCM 
>> (reviewboard.scmtools.plastic.PlasticTool) in database 
>> Error: Model 'reviews.FileAttachmentComment' already has a field named 
>> 'extra_data' 
>>
>> On IHM: 
>>
>> DatabaseError at /dashboard/ 
>> (1054, "Unknown column 'accounts_profile.is_private' in 'field list'") 
>>
>> Any ideas? 
>>
>>
>>
>>
>> -- 
>> Sebastien Douche  
>> Twitter: @sdouche / G+: +sdouche 
>>
>
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Database upgrade issues - Possible fix

[Steve]

Sorry for the long, messy output, here's what happened when I tested the 
fix. This is an attempt to upgrade a 1.5.5 database to 1.7.6.

[root@crush]~/ReviewBoard# easy_install -U django_evolution -f 
http://downloads.reviewboard.org/temp/django-evolution/
Searching for django-evolution
Reading http://pypi.python.org/simple/django_evolution/
Reading http://code.google.com/p/django-evolution/
Best match: django-evolution 0.6.8
Downloading 
http://pypi.python.org/packages/2.6/d/django_evolution/django_evolution-0.6.8-py2.6.egg#md5=7527e0ca398639c87b68969ceb1cd2d7
Processing django_evolution-0.6.8-py2.6.egg
removing 
'/usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg' (and 
everything under it)
creating /usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg
Extracting django_evolution-0.6.8-py2.6.egg to 
/usr/lib/python2.6/site-packages
django-evolution 0.6.8 is already the active version in easy-install.pth

Installed /usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg
Processing dependencies for django-evolution
Finished processing dependencies for django-evolution
Searching for -f
Reading http://pypi.python.org/simple/-f/
Couldn't find index page for '-f' (maybe misspelled?)
Scanning index of all packages (this may take a while)
Reading http://pypi.python.org/simple/
  C-c C-c^Cinterrupted

I don't know why easy_install got confused by '-f', but I did get a new 
django_evolution, so I tried updating my broken site:

[root@crush]~/ReviewBoard# cat rb-upgrade.log
Error: Model 'reviews.FileAttachmentComment' already has a field named 
'extra_data'
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
There are unapplied evolutions for auth.
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)

Now when I log in to my site, I get this:

(1054, "Unknown column 'accounts_profile.is_private' in 'field list'")

Request Method:GETRequest URL:https://crush/Django Version:1.4.5Exception 
Type:DatabaseErrorException Value:

(1054, "Unknown column 'accounts_profile.is_private' in 'field list'")

Exception 
Location:/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg/MySQLdb/connections.py
 
in defaulterrorhandler, line 36Python Executable:/usr/bin/pythonPython 
Version:2.6.6Python Path:

['/var/www/reviewboard/conf',
 '/usr/lib64/python2.6/site-packages/JCC-2.14-py2.6-linux-x86_64.egg',
 '/usr/lib64/python2.6/site-packages/lucene-3.6.1-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/distribute-0.6.27-py2.6.egg',
 '/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/recaptcha_client-1.0.6-py2.6.egg',
 '/usr/lib/python2.6/site-packages/python_dateutil-1.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/PIL-1.1.7-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/pycrypto-2.6-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/feedparser-5.1.3-py2.6.egg',
 '/usr/lib/python2.6/site-packages/ReviewBoard-1.7.6-py2.6.egg',
 '/usr/lib/python2.6/site-packages/pytz-2012j-py2.6.egg',
 '/usr/lib/python2.6/site-packages/paramiko-1.9.0-py2.6.egg',
 '/usr/lib/python2.6/site-packages/mimeparse-0.1.3-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Markdown-2.2.1-py2.6.egg',
 '/usr/lib/python2.6/site-packages/docutils-0.10-py2.6.egg',
 '/usr/lib/python2.6/site-packages/django_pipeline-1.2.24-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Djblets-0.7.11-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Django-1.4.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg',
 '/usr/lib64/python26.zip',
 '/usr/lib64/python2.6',
 '/usr/lib64/python2.6/plat-linux2',
 '/usr/lib64/python2.6/lib-tk',
 '/usr/lib64/python2.6/lib-old',
 '/usr/lib64/python2.6/lib-dynload',
 '/usr/lib64/python2.6/site-packages',
 '/usr/lib64/python2.6/site-packages/gst-0.10',
 '/usr/lib64/python2.6/site-packages/gtk-2.0',
 '/usr/lib64/python2.6/site-packag

Re: Database upgrade issues - Possible fix

[Steve]

Now I get this error:

(1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")

Request Method:GETRequest URL:https://crush/dashboard/Django 
Version:1.4.5Exception 
Type:DatabaseErrorException Value:

(1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")

Exception 
Location:/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg/MySQLdb/connections.py
 
in defaulterrorhandler, line 36Python Executable:/usr/bin/pythonPython 
Version:2.6.6Python Path:

['/var/www/reviewboard/conf',
 '/usr/lib64/python2.6/site-packages/JCC-2.14-py2.6-linux-x86_64.egg',
 '/usr/lib64/python2.6/site-packages/lucene-3.6.1-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/distribute-0.6.27-py2.6.egg',
 '/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/recaptcha_client-1.0.6-py2.6.egg',
 '/usr/lib/python2.6/site-packages/python_dateutil-1.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/PIL-1.1.7-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/pycrypto-2.6-py2.6-linux-x86_64.egg',
 '/usr/lib/python2.6/site-packages/feedparser-5.1.3-py2.6.egg',
 '/usr/lib/python2.6/site-packages/ReviewBoard-1.7.6-py2.6.egg',
 '/usr/lib/python2.6/site-packages/pytz-2012j-py2.6.egg',
 '/usr/lib/python2.6/site-packages/paramiko-1.9.0-py2.6.egg',
 '/usr/lib/python2.6/site-packages/mimeparse-0.1.3-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Markdown-2.2.1-py2.6.egg',
 '/usr/lib/python2.6/site-packages/docutils-0.10-py2.6.egg',
 '/usr/lib/python2.6/site-packages/django_pipeline-1.2.24-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Djblets-0.7.11-py2.6.egg',
 '/usr/lib/python2.6/site-packages/Django-1.4.5-py2.6.egg',
 '/usr/lib/python2.6/site-packages/django_evolution-0.6.9alpha0.dev-py2.6.egg',
 '/usr/lib64/python26.zip',
 '/usr/lib64/python2.6',
 '/usr/lib64/python2.6/plat-linux2',
 '/usr/lib64/python2.6/lib-tk',
 '/usr/lib64/python2.6/lib-old',
 '/usr/lib64/python2.6/lib-dynload',
 '/usr/lib64/python2.6/site-packages',
 '/usr/lib64/python2.6/site-packages/gst-0.10',
 '/usr/lib64/python2.6/site-packages/gtk-2.0',
 '/usr/lib64/python2.6/site-packages/webkit-1.0',
 '/usr/lib/python2.6/site-packages']



Maybe I should try on a fresh database.

--Steve

On Friday, March 1, 2013 11:26:36 AM UTC-8, Christian Hammond wrote:
>
> That's the wrong Django Evolution. Can you try downloading the one from 
> that URL and just passing it directly to easy_install?
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Mar 1, 2013, at 11:20 AM, Steve > 
> wrote:
>
> Sorry for the long, messy output, here's what happened when I tested the 
> fix. This is an attempt to upgrade a 1.5.5 database to 1.7.6.
>
> [root@crush]~/ReviewBoard# easy_install -U django_evolution -f 
> http://downloads.reviewboard.org/temp/django-evolution/
> Searching for django-evolution
> Reading http://pypi.python.org/simple/django_evolution/
> Reading http://code.google.com/p/django-evolution/
> Best match: django-evolution 0.6.8
> Downloading 
> http://pypi.python.org/packages/2.6/d/django_evolution/django_evolution-0.6.8-py2.6.egg#md5=7527e0ca398639c87b68969ceb1cd2d7
> Processing django_evolution-0.6.8-py2.6.egg
> removing 
> '/usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg' (and 
> everything under it)
> creating /usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg
> Extracting django_evolution-0.6.8-py2.6.egg to 
> /usr/lib/python2.6/site-packages
> django-evolution 0.6.8 is already the active version in easy-install.pth
>
> Installed /usr/lib/python2.6/site-packages/django_evolution-0.6.8-py2.6.egg
> Processing dependencies for django-evolution
> Finished processing dependencies for django-evolution
> Searching for -f
> Reading http://pypi.python.org/simple/-f/
> Couldn't find index page for '-f' (maybe misspelled?)
> Scanning index of all packages (this may take a while)
> Reading http://pypi.python.org/simple/
>   C-c C-c^Cinterrupted
>
> I don't know why easy_install got confused by '-f', but I did get a new 
> django_evolution, so I tried updating my broken site:
>
> [root@crush]~/ReviewBoard# cat r

Re: Database upgrade issues - Possible fix

[Steve]

I went back to a pristine version of the 1.5.5 database and ran rb-site 
again:

# rb-site upgrade /var/www/reviewboard 
Rebuilding directory structure
Updating database. This may take a while.

The log output below, including warnings and errors,
can be ignored unless upgrade fails.

--  --
Creating tables ...
Creating table extensions_registeredextension
Creating table accounts_localsiteprofile
Creating table attachments_fileattachment
Creating table diffviewer_filediffdata
Creating table hostingsvcs_hostingserviceaccount
Creating table reviews_fileattachmentcomment
Creating table site_localsite_users
Creating table site_localsite_admins
Creating table site_localsite
Upgrading Review Board from 1.5.5 to 1.7.6
There are unapplied evolutions for auth.
There are unapplied evolutions for accounts.
There are unapplied evolutions for changedescs.
There are unapplied evolutions for diffviewer.
There are unapplied evolutions for reviews.
There are unapplied evolutions for scmtools.
Adding baseline version for new models
Project signature has changed - an evolution is required
Installing custom SQL ...
Installing indexes ...
Installed 0 object(s) from 0 fixture(s)
Registering new SCM Tool Plastic SCM 
(reviewboard.scmtools.plastic.PlasticTool) in database
Evolution could not be simulated, possibly due to raw SQL mutations
...

It's been sitting at that point for about 15 minutes. It's a 7GB database, 
so it might really be taking this long.  Or it might be hung.  I'll just 
leave it for a while.

--Steve


On Friday, March 1, 2013 12:38:11 PM UTC-8, Christian Hammond wrote:
>
> Did you revert to your state before the previous test, or is this on top 
> of the previous? It's possible the previous test will have caused a problem 
> for this one (though unlikely).
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Mar 1, 2013, at 11:42 AM, Steve > 
> wrote:
>
> Now I get this error:
>
> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")
>
> Request Method:GETRequest URL:https://crush/dashboard/Django 
> Version:1.4.5Exception 
> Type:DatabaseErrorException Value:
>
> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")
>
> Exception 
> Location:/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg/MySQLdb/connections.py
>  
> in defaulterrorhandler, line 36Python Executable:/usr/bin/pythonPython 
> Version:2.6.6Python Path:
>
> ['/var/www/reviewboard/conf',
>  '/usr/lib64/python2.6/site-packages/JCC-2.14-py2.6-linux-x86_64.egg',
>  '/usr/lib64/python2.6/site-packages/lucene-3.6.1-py2.6-linux-x86_64.egg',
>  '/usr/lib/python2.6/site-packages/distribute-0.6.27-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg',
>  '/usr/lib/python2.6/site-packages/recaptcha_client-1.0.6-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/python_dateutil-1.5-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/PIL-1.1.7-py2.6-linux-x86_64.egg',
>  '/usr/lib/python2.6/site-packages/pycrypto-2.6-py2.6-linux-x86_64.egg',
>  '/usr/lib/python2.6/site-packages/feedparser-5.1.3-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/ReviewBoard-1.7.6-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/pytz-2012j-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/paramiko-1.9.0-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/mimeparse-0.1.3-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/Markdown-2.2.1-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/docutils-0.10-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/django_pipeline-1.2.24-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/Djblets-0.7.11-py2.6.egg',
>  '/usr/lib/python2.6/site-packages/Django-1.4.5-py2.6.egg',
>  
> '/usr/lib/python2.6/site-packages/django_evolution-0.6.9alpha0.dev-py2.6.egg',
>  '/usr/lib64/python26.zip',
>  '/usr/lib64/python2.6',
>  '/usr/lib64/python2.6/plat-linux2',
>  '/usr/lib64/python2.6/lib-tk',
>  '/usr/lib64/python2.6/lib-old',
>  '/usr/lib64/python2.6/lib-dynload',
>  '/usr/lib64/python2.6/site-packages',
>  '/usr/lib64/python2.6/site-packages/gst-0.10',
>  '/usr/lib64/python2.6/site-packages/gtk-2.0',
>  '/usr/lib

Re: Database upgrade issues - Possible fix

[Steve]

It's still sitting at the same place and appears to be stuck.  I see the 
rb-site process in ps, but no child processes so I have no idea what it's 
doing.  Sorry I've been more trouble than help in testing this fix.

--steve


On Friday, March 1, 2013 1:09:10 PM UTC-8, Christian Hammond wrote:
>
> Hmm, longer than I'd expect, but it's a fairly big upgrade I suppose, 
> given how old the DB is. Shame we don't have logging set up to show what 
> it's doing. Still, no errors in the simulation stage, which is promising. 
> Hopefully the other issue you hit won't crop up. If it does, we'll need to 
> investigate further.
>
> Christian
>
> On Mar 1, 2013, at 13:03, Steve > wrote:
>
> I went back to a pristine version of the 1.5.5 database and ran rb-site 
> again:
>
> # rb-site upgrade /var/www/reviewboard 
> Rebuilding directory structure
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
> Creating tables ...
> Creating table extensions_registeredextension
> Creating table accounts_localsiteprofile
> Creating table attachments_fileattachment
> Creating table diffviewer_filediffdata
> Creating table hostingsvcs_hostingserviceaccount
> Creating table reviews_fileattachmentcomment
> Creating table site_localsite_users
> Creating table site_localsite_admins
> Creating table site_localsite
> Upgrading Review Board from 1.5.5 to 1.7.6
> There are unapplied evolutions for auth.
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for changedescs.
> There are unapplied evolutions for diffviewer.
> There are unapplied evolutions for reviews.
> There are unapplied evolutions for scmtools.
> Adding baseline version for new models
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> Registering new SCM Tool Plastic SCM 
> (reviewboard.scmtools.plastic.PlasticTool) in database
> Evolution could not be simulated, possibly due to raw SQL mutations
> ...
>
> It's been sitting at that point for about 15 minutes. It's a 7GB database, 
> so it might really be taking this long.  Or it might be hung.  I'll just 
> leave it for a while.
>
> --Steve
>
>
> On Friday, March 1, 2013 12:38:11 PM UTC-8, Christian Hammond wrote:
>>
>> Did you revert to your state before the previous test, or is this on top 
>> of the previous? It's possible the previous test will have caused a problem 
>> for this one (though unlikely).
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com 
>>
>> On Mar 1, 2013, at 11:42 AM, Steve  wrote:
>>
>> Now I get this error:
>>
>> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")
>>
>> Request Method:GETRequest URL:https://crush/dashboard/Django Version:
>> 1.4.5Exception Type:DatabaseErrorException Value:
>>
>> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on clause'")
>>
>> Exception 
>> Location:/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg/MySQLdb/connections.py
>>  
>> in defaulterrorhandler, line 36Python Executable:/usr/bin/pythonPython 
>> Version:2.6.6Python Path:
>>
>> ['/var/www/reviewboard/conf',
>>  '/usr/lib64/python2.6/site-packages/JCC-2.14-py2.6-linux-x86_64.egg',
>>  '/usr/lib64/python2.6/site-packages/lucene-3.6.1-py2.6-linux-x86_64.egg',
>>  '/usr/lib/python2.6/site-packages/distribute-0.6.27-py2.6.egg',
>>  
>> '/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg',
>>  '/usr/lib/python2.6/site-packages/recaptcha_client-1.0.6-py2.6.egg',
>>  '/usr/lib/python2.6/site-packages/python_dateutil-1.5-py2.6.egg',
>>  '/usr/lib/python2.6/site-packages/flup-1.0.3.dev_20110405-py2.6.egg',
>>  '/usr/lib/python2.6/site-packages/Pygments-1.5-py2.6.egg',
>>  '/usr/lib/python2.6/site-packages/PIL-1.1.7-py2.6-linux-x86_64.egg',
>>  '/usr/lib/python2.6/site-packages/pycrypto-2.6-py2.6-linux-x86_64.egg',
>>  '/usr/lib/python2.6/site-packages/feedparser-5.1.3-py2.6.egg',
>>  '/usr/lib/python2.6/site-packages/ReviewBoard-1.7.6-py2.6.egg',
>>  '/usr/lib/python2.6/site-packag

Re: Database upgrade issues - Possible fix

[Steve]

It's a MySQL database. I was able to migrate the same database to 1.6 with 
no difficulty.  I'll give it another try later after my head clears a bit 
to make sure I'm not doing something goofy.

--steve

On Friday, March 1, 2013 1:38:21 PM UTC-8, Christian Hammond wrote:
>
> Yeah that sounds stuck.
>
> Maybe try doing it one more time, to be sure?
>
> What type of database is this?
>
> I can try to get you a build later tonight that has some extra debugging 
> so we can at least see what it's trying to do before it gets stuck.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Mar 1, 2013, at 1:33 PM, Steve > 
> wrote:
>
> It's still sitting at the same place and appears to be stuck.  I see the 
> rb-site process in ps, but no child processes so I have no idea what it's 
> doing.  Sorry I've been more trouble than help in testing this fix.
>
> --steve
>
>
> On Friday, March 1, 2013 1:09:10 PM UTC-8, Christian Hammond wrote:
>>
>> Hmm, longer than I'd expect, but it's a fairly big upgrade I suppose, 
>> given how old the DB is. Shame we don't have logging set up to show what 
>> it's doing. Still, no errors in the simulation stage, which is promising. 
>> Hopefully the other issue you hit won't crop up. If it does, we'll need to 
>> investigate further.
>>
>> Christian
>>
>> On Mar 1, 2013, at 13:03, Steve  wrote:
>>
>> I went back to a pristine version of the 1.5.5 database and ran rb-site 
>> again:
>>
>> # rb-site upgrade /var/www/reviewboard 
>> Rebuilding directory structure
>> Updating database. This may take a while.
>>
>> The log output below, including warnings and errors,
>> can be ignored unless upgrade fails.
>>
>> --  --
>> Creating tables ...
>> Creating table extensions_registeredextension
>> Creating table accounts_localsiteprofile
>> Creating table attachments_fileattachment
>> Creating table diffviewer_filediffdata
>> Creating table hostingsvcs_hostingserviceaccount
>> Creating table reviews_fileattachmentcomment
>> Creating table site_localsite_users
>> Creating table site_localsite_admins
>> Creating table site_localsite
>> Upgrading Review Board from 1.5.5 to 1.7.6
>> There are unapplied evolutions for auth.
>> There are unapplied evolutions for accounts.
>> There are unapplied evolutions for changedescs.
>> There are unapplied evolutions for diffviewer.
>> There are unapplied evolutions for reviews.
>> There are unapplied evolutions for scmtools.
>> Adding baseline version for new models
>> Project signature has changed - an evolution is required
>> Installing custom SQL ...
>> Installing indexes ...
>> Installed 0 object(s) from 0 fixture(s)
>> Registering new SCM Tool Plastic SCM 
>> (reviewboard.scmtools.plastic.PlasticTool) in database
>> Evolution could not be simulated, possibly due to raw SQL mutations
>> ...
>>
>> It's been sitting at that point for about 15 minutes. It's a 7GB 
>> database, so it might really be taking this long.  Or it might be hung. 
>>  I'll just leave it for a while.
>>
>> --Steve
>>
>>
>> On Friday, March 1, 2013 12:38:11 PM UTC-8, Christian Hammond wrote:
>>>
>>> Did you revert to your state before the previous test, or is this on top 
>>> of the previous? It's possible the previous test will have caused a problem 
>>> for this one (though unlikely).
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com 
>>>
>>> On Mar 1, 2013, at 11:42 AM, Steve  wrote:
>>>
>>> Now I get this error:
>>>
>>> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on 
>>> clause'")
>>>
>>> Request Method:GETRequest URL:https://crush/dashboard/Django Version:
>>> 1.4.5Exception Type:DatabaseErrorException Value:
>>>
>>> (1054, "Unknown column 'reviews_reviewrequest.local_site_id' in 'on 
>>> clause'")
>>>
>>> Exception 
>>> Location:/usr/lib/python2.6/site-packages/MySQL_python-1.2.3-py2.6-linux-x86_64.egg/MySQLdb/connections.py
>>>  
>>> in defaulterrorhandler, line 36Python Executable:/usr/bin/pythonP

Re: Database upgrade issues - Possible fix

[Steve]

Well, sometimes procrastination pays off.  When I came back to my session, 
I saw this:

Evolution successful.
---  ---

Resetting in-database caches.

Upgrade complete!

The location of static media files (CSS, JavaScript, images)
has changed. You will need to make manual changes to
your web server configuration.

For Apache, you will need to add:


SetHandler None


Alias /static "/var/www/reviewboard/htdocs/static"

For lighttpd:

alias.url = (
...
"/static" => "/var/www/reviewboard/htdocs/static",
...
)

url.rewrite-once = (
...
"^(/static/.*)$" => "$1",
...
)

Once you have made these changes, type the following
to resolve this:

$ rb-site manage /var/www/reviewboard resolve-check static-media

So that's good, right?  I'll respond back when I've made those changes and 
had a chance to test out the server.

Thanks

--Steve


On Friday, March 1, 2013 1:51:23 PM UTC-8, Steve wrote:
>
> It's a MySQL database. I was able to migrate the same database to 1.6 with 
> no difficulty.  I'll give it another try later after my head clears a bit 
> to make sure I'm not doing something goofy.
>
> --steve
>
> On Friday, March 1, 2013 1:38:21 PM UTC-8, Christian Hammond wrote:
>>
>> Yeah that sounds stuck.
>>
>> Maybe try doing it one more time, to be sure?
>>
>> What type of database is this?
>>
>> I can try to get you a build later tonight that has some extra debugging 
>> so we can at least see what it's trying to do before it gets stuck.
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> VMware, Inc. - http://www.vmware.com 
>>
>> On Mar 1, 2013, at 1:33 PM, Steve  wrote:
>>
>> It's still sitting at the same place and appears to be stuck.  I see the 
>> rb-site process in ps, but no child processes so I have no idea what it's 
>> doing.  Sorry I've been more trouble than help in testing this fix.
>>
>> --steve
>>
>>
>> On Friday, March 1, 2013 1:09:10 PM UTC-8, Christian Hammond wrote:
>>>
>>> Hmm, longer than I'd expect, but it's a fairly big upgrade I suppose, 
>>> given how old the DB is. Shame we don't have logging set up to show what 
>>> it's doing. Still, no errors in the simulation stage, which is promising. 
>>> Hopefully the other issue you hit won't crop up. If it does, we'll need to 
>>> investigate further.
>>>
>>> Christian
>>>
>>> On Mar 1, 2013, at 13:03, Steve  wrote:
>>>
>>> I went back to a pristine version of the 1.5.5 database and ran rb-site 
>>> again:
>>>
>>> # rb-site upgrade /var/www/reviewboard 
>>> Rebuilding directory structure
>>> Updating database. This may take a while.
>>>
>>> The log output below, including warnings and errors,
>>> can be ignored unless upgrade fails.
>>>
>>> --  --
>>> Creating tables ...
>>> Creating table extensions_registeredextension
>>> Creating table accounts_localsiteprofile
>>> Creating table attachments_fileattachment
>>> Creating table diffviewer_filediffdata
>>> Creating table hostingsvcs_hostingserviceaccount
>>> Creating table reviews_fileattachmentcomment
>>> Creating table site_localsite_users
>>> Creating table site_localsite_admins
>>> Creating table site_localsite
>>> Upgrading Review Board from 1.5.5 to 1.7.6
>>> There are unapplied evolutions for auth.
>>> There are unapplied evolutions for accounts.
>>> There are unapplied evolutions for changedescs.
>>> There are unapplied evolutions for diffviewer.
>>> There are unapplied evolutions for reviews.
>>> There are unapplied evolutions for scmtools.
>>> Adding baseline version for new models
>>> Project signature has changed - an evolution is required
>>> Installing custom SQL ...
>>> Installing indexes ...
>>> Installed 0 object(s) from 0 fixture(s)
>>> Registering new SCM Tool Plastic SCM 
>>> (reviewboard.scmtools.plastic.PlasticTool) in database
>>> Evolution could not be simulated, possibly due to raw SQL mutations
>>> ...
>>>
>>> It's been sitting at that point for about 15 minutes. It's a 7GB 
>>> database, so it might really be taking this long.  Or it might be hung. 
>>>  I'll ju

Re: Database upgrade issues - Possible fix

[Steve]

I'm happy to report the patch you provided seems to have worked. I'm able 
to log on to my 1.7.6 site and browse reviews.  I'll test it more today, 
but so far it looks good.

Thanks Chris!

--Steve


On Friday, March 1, 2013 2:48:22 PM UTC-8, Steve wrote:
>
> Well, sometimes procrastination pays off.  When I came back to my session, 
> I saw this:
>
> Evolution successful.
> ---  ---
>
> Resetting in-database caches.
>
> Upgrade complete!
>
> The location of static media files (CSS, JavaScript, images)
> has changed. You will need to make manual changes to
> your web server configuration.
>
> For Apache, you will need to add:
>
> 
> SetHandler None
> 
>
> Alias /static "/var/www/reviewboard/htdocs/static"
>
> For lighttpd:
>
> alias.url = (
> ...
> "/static" => "/var/www/reviewboard/htdocs/static",
> ...
> )
>
> url.rewrite-once = (
> ...
> "^(/static/.*)$" => "$1",
> ...
> )
>
> Once you have made these changes, type the following
> to resolve this:
>
> $ rb-site manage /var/www/reviewboard resolve-check static-media
>
> So that's good, right?  I'll respond back when I've made those changes and 
> had a chance to test out the server.
>
> Thanks
>
> --Steve
>
>
> On Friday, March 1, 2013 1:51:23 PM UTC-8, Steve wrote:
>>
>> It's a MySQL database. I was able to migrate the same database to 1.6 
>> with no difficulty.  I'll give it another try later after my head clears a 
>> bit to make sure I'm not doing something goofy.
>>
>> --steve
>>
>> On Friday, March 1, 2013 1:38:21 PM UTC-8, Christian Hammond wrote:
>>>
>>> Yeah that sounds stuck.
>>>
>>> Maybe try doing it one more time, to be sure?
>>>
>>> What type of database is this?
>>>
>>> I can try to get you a build later tonight that has some extra debugging 
>>> so we can at least see what it's trying to do before it gets stuck.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com 
>>>
>>> On Mar 1, 2013, at 1:33 PM, Steve  wrote:
>>>
>>> It's still sitting at the same place and appears to be stuck.  I see the 
>>> rb-site process in ps, but no child processes so I have no idea what it's 
>>> doing.  Sorry I've been more trouble than help in testing this fix.
>>>
>>> --steve
>>>
>>>
>>> On Friday, March 1, 2013 1:09:10 PM UTC-8, Christian Hammond wrote:
>>>>
>>>> Hmm, longer than I'd expect, but it's a fairly big upgrade I suppose, 
>>>> given how old the DB is. Shame we don't have logging set up to show what 
>>>> it's doing. Still, no errors in the simulation stage, which is promising. 
>>>> Hopefully the other issue you hit won't crop up. If it does, we'll need to 
>>>> investigate further.
>>>>
>>>> Christian
>>>>
>>>> On Mar 1, 2013, at 13:03, Steve  wrote:
>>>>
>>>> I went back to a pristine version of the 1.5.5 database and ran rb-site 
>>>> again:
>>>>
>>>> # rb-site upgrade /var/www/reviewboard 
>>>> Rebuilding directory structure
>>>> Updating database. This may take a while.
>>>>
>>>> The log output below, including warnings and errors,
>>>> can be ignored unless upgrade fails.
>>>>
>>>> --  --
>>>> Creating tables ...
>>>> Creating table extensions_registeredextension
>>>> Creating table accounts_localsiteprofile
>>>> Creating table attachments_fileattachment
>>>> Creating table diffviewer_filediffdata
>>>> Creating table hostingsvcs_hostingserviceaccount
>>>> Creating table reviews_fileattachmentcomment
>>>> Creating table site_localsite_users
>>>> Creating table site_localsite_admins
>>>> Creating table site_localsite
>>>> Upgrading Review Board from 1.5.5 to 1.7.6
>>>> There are unapplied evolutions for auth.
>>>> There are unapplied evolutions for accounts.
>>>> There are unapplied evolutions for changedescs.
>>>> There are unapplied evol

Re: Error on 1.5 -> 1.7.1 upgrade: Model 'reviews.FileAttachmentComment' already has a field named 'extra_data'

[Steve]

I reported success with the new django-evolution in a different thread, but 
I'm replying again here just to get all the information in one place.  The 
conversion of my 1.5 database to 1.7 took a long time - possibly hours.  I 
monitored it for about an hour and then just left it for the weekend. When 
I came back on Monday it had successfully finished. Our database is about 
6GB in size running on a MySQL server.  Hope that helps.

Thanks for the patch Chris.

--Steve

On Saturday, March 9, 2013 2:44:59 PM UTC-8, Christian Hammond wrote:
>
> I haven't received enough replies to be able to say. Having you test this 
> would really help.
>
> Would you be willing to make a backup of your database, then install the 
> Django Evolution package from 
> http://downloads.reviewboard.org/temp/django-evolution/? You'd need to 
> attempt the upgrade again and then test out the site a bit, make sure 
> nothing is broken (including commenting on file attachments).
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> VMware, Inc. - http://www.vmware.com 
>
> On Mar 9, 2013, at 2:37 PM, tex.b...@gmail.com  wrote:
>
> Hi,
> was this experiment successful ?
> Like some others, I took a snapshot of a working 1.5.5 installation from 
> Centos 5.5, copied it to a Centos 6.3 machine, and upgraded to 1.6.15, then 
> to 1.7.6.
> That all took 2 months, due to various issues and lack of focus. Today I 
> took another snapshot of my working 1.5.5 installation, and tried to apply 
> that. I dropped the working but out-of-date reviewboard table in the 1.7.6 
> installation, then restored the current .sql file from the 1.5.5 release; 
> then did 
> "/usr/bin/python" "/usr/bin/rb-site" upgrade "/var/www/reviewboard". That 
> produced a site which just sayd 'Something broke." The output from the 
> upgrade command is:
> Error: Model 'reviews.FileAttachmentComment' already has a field named 
> 'extra_data'
> Rebuilding directory structure
> Updating database. This may take a while.
>
> The log output below, including warnings and errors,
> can be ignored unless upgrade fails.
>
> --  --
> Creating tables ...
> Creating table extensions_registeredextension
> Creating table accounts_localsiteprofile
> Creating table attachments_fileattachment
> Creating table diffviewer_filediffdata
> Creating table hostingsvcs_hostingserviceaccount
> Creating table reviews_fileattachmentcomment
> Creating table site_localsite_users
> Creating table site_localsite_admins
> Creating table site_localsite
> Upgrading Review Board from 1.5.5 to 1.7.6
> There are unapplied evolutions for auth.
> There are unapplied evolutions for accounts.
> There are unapplied evolutions for changedescs.
> There are unapplied evolutions for diffviewer.
> There are unapplied evolutions for reviews.
> There are unapplied evolutions for scmtools.
> Adding baseline version for new models
> Project signature has changed - an evolution is required
> Installing custom SQL ...
> Installing indexes ...
> Installed 0 object(s) from 0 fixture(s)
> Registering new SCM Tool Plastic SCM 
> (reviewboard.scmtools.plastic.PlasticTool) in database
>
> I expect I'm doing something fundamentally wrong, but this seems to be a 
> common usage model, so perhaps someone can steer me straight ?
> Thanks,
>
>
>
> On Friday, March 1, 2013 9:58:34 AM UTC-8, Steve wrote:
>>
>> I can also test it on my sandbox which is currently in this state.
>>
>> --steve
>>
>>
>> On Wednesday, February 27, 2013 12:05:31 AM UTC-8, Christian Hammond 
>> wrote:
>>>
>>> Hi again,
>>>
>>> I actually think I may have a fix for Django Evolution, but I will need 
>>> volunteers to test. I'll be sending out an e-mail with instructions shortly.
>>>
>>> Christian
>>>
>>> -- 
>>> Christian Hammond - chi...@chipx86.com
>>> Review Board - http://www.reviewboard.org
>>> VMware, Inc. - http://www.vmware.com 
>>>
>>> On Feb 26, 2013, at 9:00 PM, Nachiketh G  wrote:
>>>
>>> Hi Sebastien/Christian,
>>> I tried the upgrading from a 1.0 release of RB to 1.7.x and ran into the 
>>> exact same error when I did a "rb-site upgrade". 
>>> *Error: Model 'reviews.FileAttachmentComment' already has a field named 
>>> 'extra_data'*
>>>
>>> Were you guys able to find a solution to this problem? Do let me know.
>>> Thanks & Regards,
>>> Nachiketh
>>>
>

post-review created 2 reviews for the same change list number

[Steve]

We're currently using Review Board 1.5.5 in production (we'll be upgrading 
to 1.7.6 soon) and RBTools 0.4.2.  One of our developers created a new 
review with post-review, and then when he used post-review again to update 
the review, it created a new review.  I verified that we ended up with 2 
reviews with the same change list number.  I didn't even think that was 
possible - I thought their was a 1-1 correspondence between review ids and 
changenums.  Any ideas how this could have happened?  Now when we try to 
update the review, it finds the newer review, even though it was discarded. 
 Can I fix this?

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: post-review created 2 reviews for the same change list number

[Steve]

Yes it's perforce.

On Friday, March 15, 2013 2:05:56 PM UTC-7, Christian Hammond wrote:
>
> Hi Steve,
>
> Is this with Perforce?
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  
> On Mar 15, 2013, at 2:05 PM, Steve > 
> wrote:
>
> We're currently using Review Board 1.5.5 in production (we'll be upgrading 
> to 1.7.6 soon) and RBTools 0.4.2.  One of our developers created a new 
> review with post-review, and then when he used post-review again to update 
> the review, it created a new review.  I verified that we ended up with 2 
> reviews with the same change list number.  I didn't even think that was 
> possible - I thought their was a 1-1 correspondence between review ids and 
> changenums.  Any ideas how this could have happened?  Now when we try to 
> update the review, it finds the newer review, even though it was discarded. 
>  Can I fix this?
>
> Thanks
>
> --Steve
>
>
> -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: post-review created 2 reviews for the same change list number

[Steve]

Any thoughts on the duplicate review problem?  It's a concern because we're 
currently using RB 1.5.5 with an in-house perl script for posting reviews. 
 We plan to upgrade soon to 1.7.6 so I'm migrating our users to the 
post-review script.  This duplicate review occurred within a few days of 
using post-review with our 1.5.5 server and has us a bit skittish about 
making the jump.  Any thoughts or advise would be great.  If it's a rare 
event that I can easily repair by deleting the extra review, or assigning 
it a bogus change list number, that would at least provide some comfort :)

Thanks

--Steve


On Friday, March 15, 2013 2:12:24 PM UTC-7, Steve wrote:
>
> Yes it's perforce.
>
> On Friday, March 15, 2013 2:05:56 PM UTC-7, Christian Hammond wrote:
>>
>> Hi Steve,
>>
>> Is this with Perforce?
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>> On Mar 15, 2013, at 2:05 PM, Steve  wrote:
>>
>> We're currently using Review Board 1.5.5 in production (we'll be 
>> upgrading to 1.7.6 soon) and RBTools 0.4.2.  One of our developers created 
>> a new review with post-review, and then when he used post-review again to 
>> update the review, it created a new review.  I verified that we ended up 
>> with 2 reviews with the same change list number.  I didn't even think that 
>> was possible - I thought their was a 1-1 correspondence between review ids 
>> and changenums.  Any ideas how this could have happened?  Now when we try 
>> to update the review, it finds the newer review, even though it was 
>> discarded.  Can I fix this?
>>
>> Thanks
>>
>> --Steve
>>
>>
>> -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: post-review created 2 reviews for the same change list number

[Steve]

That may be it. I forgot we added a perforce sandbox server to the 
repository list for testing and they are at the top of the repository list. 
 I just removed them.

Thanks!

--Steve


On Tuesday, March 19, 2013 8:17:17 AM UTC-7, Kudret Güler wrote:
>
> Hi, 
>
> Can there be two different Perforce servers involved with the two 
> submissions?
> one submission using perforce-main vs another using perforce-backup for 
> instance...
>
> Kudret
>
>
> On Tue, Mar 19, 2013 at 10:45 AM, Steve  >wrote:
>
>> Any thoughts on the duplicate review problem?  It's a concern because 
>> we're currently using RB 1.5.5 with an in-house perl script for posting 
>> reviews.  We plan to upgrade soon to 1.7.6 so I'm migrating our users to 
>> the post-review script.  This duplicate review occurred within a few days 
>> of using post-review with our 1.5.5 server and has us a bit skittish about 
>> making the jump.  Any thoughts or advise would be great.  If it's a rare 
>> event that I can easily repair by deleting the extra review, or assigning 
>> it a bogus change list number, that would at least provide some comfort :)
>>
>> Thanks
>>
>> --Steve
>>
>>
>> On Friday, March 15, 2013 2:12:24 PM UTC-7, Steve wrote:
>>>
>>> Yes it's perforce.
>>>
>>> On Friday, March 15, 2013 2:05:56 PM UTC-7, Christian Hammond wrote:
>>>>
>>>> Hi Steve,
>>>>
>>>> Is this with Perforce?
>>>>
>>>> Christian
>>>>
>>>>  -- 
>>>> Christian Hammond - chi...@chipx86.com
>>>> Review Board - http://www.reviewboard.org
>>>> Beanbag, Inc. - http://www.beanbaginc.com
>>>>  
>>>> On Mar 15, 2013, at 2:05 PM, Steve  wrote:
>>>>
>>>> We're currently using Review Board 1.5.5 in production (we'll be 
>>>> upgrading to 1.7.6 soon) and RBTools 0.4.2.  One of our developers created 
>>>> a new review with post-review, and then when he used post-review again to 
>>>> update the review, it created a new review.  I verified that we ended up 
>>>> with 2 reviews with the same change list number.  I didn't even think that 
>>>> was possible - I thought their was a 1-1 correspondence between review ids 
>>>> and changenums.  Any ideas how this could have happened?  Now when we try 
>>>> to update the review, it finds the newer review, even though it was 
>>>> discarded.  Can I fix this?
>>>>
>>>> Thanks
>>>>
>>>> --Steve
>>>>
>>>>
>>>> -- 
>>>> Want to help the Review Board project? Donate today at 
>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>> Happy user? Let us know at 
>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>> -~--~~~~--**~~--~--~---
>>>> To unsubscribe from this group, send email to 
>>>> reviewboard...@googlegroups.**com
>>>> For more options, visit this group at http://groups.google.com/**
>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to reviewboard...@googlegroups.**com.
>>>> For more options, visit 
>>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
>>>> .
>>>>  
>>>>  
>>>>
>>>>
>>>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: RBTools 0.5 released!

[Steve]

I just installed RBTools 0.5 in a virtuaenv, and it installed rbt, but not 
post-review.  I know post-review is being deprecated, but this looks more 
like it's been removed completely.  Is that intentional?

--Steve


On Tuesday, March 19, 2013 1:43:44 AM UTC-7, Christian Hammond wrote:
>
> Hi everyone,
>
> The new RBTools 0.5 is out. This is a major release, led by our own Steven 
> MacLeod, and is, to me, the most exciting release of RBTools we've put out. 
> There's a bunch of new command line scripts and a brand new Python API that 
> you can use to talk to Review Board.
>
> There's a lot of new awesomeness that I'm not going to repeat here. 
> Instead, I'll just link you to our official announcement.
>
> http://www.reviewboard.org/news/2013/03/19/rbtools-0-5-released/
>
> If you have questions about using the Python API or developing scripts, 
> please use reviewb...@googlegroups.com . Otherwise, go ahead 
> and post here!
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>  

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: RBTools 0.5 released!

[Steve]

Sorry, my mistake.  post-review was installed, I was in the wrong 
virtualenv.

--Steve


On Wednesday, March 20, 2013 10:13:42 AM UTC-7, Steve wrote:
>
> I just installed RBTools 0.5 in a virtuaenv, and it installed rbt, but not 
> post-review.  I know post-review is being deprecated, but this looks more 
> like it's been removed completely.  Is that intentional?
>
> --Steve
>
>
> On Tuesday, March 19, 2013 1:43:44 AM UTC-7, Christian Hammond wrote:
>>
>> Hi everyone,
>>
>> The new RBTools 0.5 is out. This is a major release, led by our own 
>> Steven MacLeod, and is, to me, the most exciting release of RBTools we've 
>> put out. There's a bunch of new command line scripts and a brand new Python 
>> API that you can use to talk to Review Board.
>>
>> There's a lot of new awesomeness that I'm not going to repeat here. 
>> Instead, I'll just link you to our official announcement.
>>
>> http://www.reviewboard.org/news/2013/03/19/rbtools-0-5-released/
>>
>> If you have questions about using the Python API or developing scripts, 
>> please use reviewb...@googlegroups.com. Otherwise, go ahead and post 
>> here!
>>
>> Christian
>>
>> -- 
>> Christian Hammond - chi...@chipx86.com
>> Review Board - http://www.reviewboard.org
>> Beanbag, Inc. - http://www.beanbaginc.com
>>  
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Timestamps are off after 1.6.3 to 1.7.6 upgrade

[Steve]

We upgraded from 1.5.5 to 1.7.6 and I'm also seeing incorrect timestamps, 
even with new reviews.  I verified that our timezone is set to US/Pacific 
in Review Board general settings.  I just created a review at:

Tue Mar 26 11:47:57 PDT 2013

and it shows up in Review Board as 

Tue Mar 26 18:47:57 2013

which looks like UTC.

--steve

On Wednesday, March 20, 2013 10:15:23 AM UTC-7, David Lee wrote:
>
> This morning, I upgraded our ReviewBoard installation from 1.6.3 to 1.7.6, 
> and almost everything went smoothly.
>
> The only problem we've had with the upgrade is that the timestamps for 
> pre-upgrade reviews, comments, etc. are wrong. Timestamps for new content 
> are correct.
>
> I've set the Time Zone setting in Admin/General Settings, and I've set the 
> timezone for My Account as well. Prior to the upgrade, we also had 
> TIME_ZONE set in settings_local.py.
>
> We're using a MySQL database, with a Memcached cache backend, in case that 
> makes a difference.
>
> I've poked around on the database, and it looks as though with 1.6, 
> timestamps were being stored in local time, but now in 1.7 timestamps are 
> being stored in UTC.
>
> Are there any tools or scripts that someone can point me to for fixing the 
> timestamps in the database?
>
> Thanks!
> -- 
> David M. Lee
> Digium, Inc. | Software Developer
> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
> Check us out at:  www.digium.com  & www.asterisk.org
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Timestamps are off after 1.6.3 to 1.7.6 upgrade

[Steve]

On Tuesday, March 26, 2013 12:56:55 PM UTC-7, Christian Hammond wrote:
>
> Hey,
>
> Was US/Pacific what you had before the upgrade? They should have been 
> stored as PST in that case, and any new times should also then be stored as 
> PST, and shown based on the timezone you have set for yourself in your 
> account settings.
>


That's what I was missing. Our old version 1.5.5 didn't have timezone 
settings for individual users, so I never set that.  I just checked my 
account in 1.7 and while the server was US/Pacific, my account was UTC.  I 
changed it Pacific and now the timestamps look correct.

--Steve
 

>
> Christian
>
>
> On Mar 26, 2013, at 12:03, Steve > wrote:
>
> We upgraded from 1.5.5 to 1.7.6 and I'm also seeing incorrect timestamps, 
> even with new reviews.  I verified that our timezone is set to US/Pacific 
> in Review Board general settings.  I just created a review at:
>
> Tue Mar 26 11:47:57 PDT 2013
>
> and it shows up in Review Board as 
>
> Tue Mar 26 18:47:57 2013
>
> which looks like UTC.
>
> --steve
>
> On Wednesday, March 20, 2013 10:15:23 AM UTC-7, David Lee wrote:
>>
>> This morning, I upgraded our ReviewBoard installation from 1.6.3 to 
>> 1.7.6, and almost everything went smoothly.
>>
>> The only problem we've had with the upgrade is that the timestamps for 
>> pre-upgrade reviews, comments, etc. are wrong. Timestamps for new content 
>> are correct.
>>
>> I've set the Time Zone setting in Admin/General Settings, and I've set 
>> the timezone for My Account as well. Prior to the upgrade, we also had 
>> TIME_ZONE set in settings_local.py.
>>
>> We're using a MySQL database, with a Memcached cache backend, in case 
>> that makes a difference.
>>
>> I've poked around on the database, and it looks as though with 1.6, 
>> timestamps were being stored in local time, but now in 1.7 timestamps are 
>> being stored in UTC.
>>
>> Are there any tools or scripts that someone can point me to for fixing 
>> the timestamps in the database?
>>
>> Thanks!
>> -- 
>> David M. Lee
>> Digium, Inc. | Software Developer
>> 445 Jan Davis Drive NW - Huntsville, AL 35806 - USA
>> Check us out at:  www.digium.com  & www.asterisk.org
>>
>>  -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Problem with futures package in clean install of 1.7 - taking a nap

[Steve]

I'm setting up a brand new Review Board server from scratch on a fresh 
Centos 6 linux box.  After installing the prerequisites, I ran

$ easy_install -U ReviewBoard==1.7

One of the packages that was installed by that was 

*futures-2.1.3-py2.6.egg*

After creating a new site and restarting httpd, I got the dreaded 
'ReviewBoard is taking a nap' page.  I checked the error log and found this:

*IOError: [Errno 13] Permission denied: 
'/usr/lib/python2.6/site-packages/futures-2.1.3-py2.6.egg/EGG-INFO/top_level.txt'
*

Sure enough, the permissions in that directory are:

-rw--- 1 root root   1 Mar 27 10:56 dependency_links.txt

-rw--- 1 root root   1 Mar 27 10:56 not-zip-safe

-rw--- 1 root root 737 Mar 27 10:56 PKG-INFO

-rw--- 1 root root 515 Mar 27 10:56 SOURCES.txt

-rw--- 1 root root  19 Mar 27 10:56 top_level.txt

I changed those all to 622, restarted httpd and successfully got the log in 
page.

So I guess this is part bug report and part alert to others who may run 
into this.

--Steve



-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

What is the safest way to alter siteconfig_siteconfiguration settings?

[Steve]

Somehow when I upgraded our 2 reviewboard servers to 1.7.6 one of them 
ended up with an incorrect path in the siteconfig_siteconfiguration table 
(mysql).   This string is correct:

"search_index_file": "/var/www/reviewboard-testcases/data",  

But this one is not:

 "site_media_root":"/var/www/reviewboard/htdocs/media",

My httpd conf files has these settings:

# Alias static media requests to filesystem 

  

  SetHandler None

Alias /media "/var/www/reviewboard-testcases/htdocs/media"
Alias /static "/var/www/reviewboard-testcases/htdocs/static"
Alias /errordocs "/var/www/reviewboard-testcases/htdocs/errordocs"
Alias /favicon.ico 
"/var/www/reviewboard-testcases/htdocs/static/rb/images/favicon.png"

I'm not real comfortable with mysql - is there a way I can fix that path in 
the database without manually editing the table? 

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: What is the safest way to alter siteconfig_siteconfiguration settings?

[Steve]

That worked perfectly!  Very nice tool to have.  Thanks Chris!

--Steve


On Saturday, April 6, 2013 12:40:04 PM UTC-7, Christian Hammond wrote:
>
> Hi Steve,
>
> 1.7.6 has a couple new management commands you can use.
>
> Try:
>
>   $ rb-site manage /path/to/site set-siteconfig -- --key=site_media_root 
> --value=/var/www/reviewboard-testcases/htdocs/media
>
> Christian
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Local sites, private groups, or multiple review board instances?

[Steve]

We currently have 2 review board servers  running 1.7.6 on 2 different 
CenotOS 6 hosts.  We set up 2 servers way back in the 1.0 days to restrict 
visibility of some portions of our perforce repository.  I'm now tasked 
with setting up a third server with even greater restrictions.   All 3 
servers point to a single perforce repository. I don't want to tie up a 3rd 
box for this, so I'm looking to run 2 sites on 1 machine.  My first thought 
was to set up a second IP and try to get 2 different instances of RB 
running on the same box, but with distinct databases and directories.  But 
I see that 1.7 has private groups and the concept of 'local sites' which 
look like they may be another way to solve the problem.  However, I haven't 
been able to find enough detail on local sites to determine if I should go 
down that road. I was hoping others out there may have some hard-earned 
experience on which of these approaches is the most viable.

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Local sites, private groups, or multiple review board instances?

[Steve]

Thanks for the insight Chris.  I really appreciate your work and 
responsiveness.

--Steve


On Tuesday, April 23, 2013 4:07:18 PM UTC-7, Christian Hammond wrote:
>
> Hi Steve,
>
> Local sites aren't something that are deeply exposed. They're usable, 
> certainly, but my feeling is that you may really want two instances.
>
> With Local Sites, you can basically have a path that goes to a specific 
> site, which certain people will have access to. However, in your case, 
> everything that already exists on the server will be independent of  a 
> Local Site, so you'd be in this weird setup where some things are at, 
> /r/123, and some are at /s/sitename/r/456.
>
> We built Local Sites originally for RBCommons.com, our Review Board SaaS. 
> I don't know if anyone out there has used them for any other installations. 
> Possibly, and you could certainly try it, but there may be some gotchas.
>
> Christian
>
> -- 
> Christian Hammond - chi...@chipx86.com 
> Review Board - http://www.reviewboard.org
> Beanbag, Inc. - http://www.beanbaginc.com
>
>
> On Tue, Apr 23, 2013 at 3:05 PM, Steve  >wrote:
>
>> We currently have 2 review board servers  running 1.7.6 on 2 different 
>> CenotOS 6 hosts.  We set up 2 servers way back in the 1.0 days to restrict 
>> visibility of some portions of our perforce repository.  I'm now tasked 
>> with setting up a third server with even greater restrictions.   All 3 
>> servers point to a single perforce repository. I don't want to tie up a 3rd 
>> box for this, so I'm looking to run 2 sites on 1 machine.  My first thought 
>> was to set up a second IP and try to get 2 different instances of RB 
>> running on the same box, but with distinct databases and directories.  But 
>> I see that 1.7 has private groups and the concept of 'local sites' which 
>> look like they may be another way to solve the problem.  However, I haven't 
>> been able to find enough detail on local sites to determine if I should go 
>> down that road. I was hoping others out there may have some hard-earned 
>> experience on which of these approaches is the most viable.
>>
>> Thanks
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Cannot get reviewboard to display my whitespace-only diff

[Steve]

We have 1.7.6 in production on a linux server. I posted a review of a php 
file with whitespace-only diffs on one line. When I view it on reviewboard 
it won't show me the diff.  With these settings:

+ Expand Changes+ Show Whitespace changes

I see the message:

"This file contains only whitespace changes."

That makes sense.  When I click on the 'Show Whitespace changes' box, I 
still don't see any diff.


I posted the same exact review to my 1.6 sandbox, and there it behaves the 
way I would expect, namely when I click on the "Show Whitespace changes", I 
see my 1 line diff.

This is a serious problem because those whitespace differences are not 
leading/trailing spaces and they're significant to the change under review.

I compared my site settings for the diff viewer, I don't see anything that 
jumps out at me. Maybe something will jump out at you:

# 1.6 server that behaves the way I want
 u'diffviewer_context_num_lines': 5,
 u'diffviewer_include_space_patterns': [u''],
 u'diffviewer_max_diff_size': 0,
 u'diffviewer_paginate_by': 20,
 u'diffviewer_paginate_orphans': 10,
 u'diffviewer_show_trailing_whitespace': False,
 u'diffviewer_syntax_highlighting': True,
 u'diffviewer_syntax_highlighting_threshold': 0,

# 1.7.6 server that does not behave the way I want
 u'diffviewer_context_num_lines': 7,
 u'diffviewer_include_space_patterns': [u''],
 u'diffviewer_max_diff_size': 0,
 u'diffviewer_paginate_by': 10,
 u'diffviewer_paginate_orphans': 3,
 u'diffviewer_show_trailing_whitespace': False,
 u'diffviewer_syntax_highlighting': True,
 u'diffviewer_syntax_highlighting_threshold': None,


I don't know why the last setting is 0 for 1.6 and None for 1.7. They seem 
logically the same and not related to whitespace, but I obviously don't 
know that for sure. The 1.7.6 database was migrated from a 1.5 server so 
maybe that's why.  The 1.6 sandbox was created from scratch.

Is this a bug, or do I have something misconfigured?


--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Cannot get reviewboard to display my whitespace-only diff

[Steve]

On Friday, April 26, 2013 12:01:45 PM UTC-7, Christian Hammond wrote:
>
> Hi Steve,
>
> I'm not aware off-hand of any changes that would have broken whitespace 
> changes within a line. Definitely something that we need to fix if this is 
> reproducible.
>
> Do you see anything in the browser's console log when you click the Show 
> Whitespace Changes?
>


Using firefox with the console on, I see this with the 1.7.6 server:

[14:37:19.943] Unknown property 'box-sizing'.  Declaration dropped. @ 
https://reviewboard/r/64801/diff/#index_header
[14:37:19.951] Use of Mutation Events is deprecated. Use MutationObserver 
instead. @ https://reviewboard/static/lib/js/jquery-1.8.2.min.js:2
[14:37:20.012] Error in parsing value for 'white-space'.  Declaration 
dropped. @ https://reviewboard/r/64801/diff/#index_header

But I see the same messages with 1.6.9, and the diff shows correctly, so 
that may not mean much.
 

>
> What version of 1.6 are you testing in the sandbox?
>


1.6.9.

Thanks

--Steve

 

>
> Christian
>
>
> On Apr 26, 2013, at 8:29, Steve > wrote:
>
> We have 1.7.6 in production on a linux server. I posted a review of a php 
> file with whitespace-only diffs on one line. When I view it on reviewboard 
> it won't show me the diff.  With these settings:
>
> + Expand Changes+ Show Whitespace changes
>
> I see the message:
>
> "This file contains only whitespace changes."
>
> That makes sense.  When I click on the 'Show Whitespace changes' box, I 
> still don't see any diff.
>
>
> I posted the same exact review to my 1.6 sandbox, and there it behaves the 
> way I would expect, namely when I click on the "Show Whitespace changes", I 
> see my 1 line diff.
>
> This is a serious problem because those whitespace differences are not 
> leading/trailing spaces and they're significant to the change under review.
>
> I compared my site settings for the diff viewer, I don't see anything that 
> jumps out at me. Maybe something will jump out at you:
>
> # 1.6 server that behaves the way I want
>  u'diffviewer_context_num_lines': 5,
>  u'diffviewer_include_space_patterns': [u''],
>  u'diffviewer_max_diff_size': 0,
>  u'diffviewer_paginate_by': 20,
>  u'diffviewer_paginate_orphans': 10,
>  u'diffviewer_show_trailing_whitespace': False,
>  u'diffviewer_syntax_highlighting': True,
>  u'diffviewer_syntax_highlighting_threshold': 0,
>
> # 1.7.6 server that does not behave the way I want
>  u'diffviewer_context_num_lines': 7,
>  u'diffviewer_include_space_patterns': [u''],
>  u'diffviewer_max_diff_size': 0,
>  u'diffviewer_paginate_by': 10,
>  u'diffviewer_paginate_orphans': 3,
>  u'diffviewer_show_trailing_whitespace': False,
>  u'diffviewer_syntax_highlighting': True,
>  u'diffviewer_syntax_highlighting_threshold': None,
>
>
> I don't know why the last setting is 0 for 1.6 and None for 1.7. They seem 
> logically the same and not related to whitespace, but I obviously don't 
> know that for sure. The 1.7.6 database was migrated from a 1.5 server so 
> maybe that's why.  The 1.6 sandbox was created from scratch.
>
> Is this a bug, or do I have something misconfigured?
>
>
> --Steve
>
>  -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Cannot get reviewboard to display my whitespace-only diff

[Steve]

Our SCM is perforce and I used post-review 0.4.2 to post the review.

Thanks!

--Steve

On Friday, April 26, 2013 12:25:13 PM UTC-7, David Trowbridge wrote:
>
> One other question: how are you creating your diff?
> -David
>
>
> On Fri, Apr 26, 2013 at 12:01 PM, Christian Hammond 
> 
> > wrote:
>
>> Hi Steve,
>>
>> I'm not aware off-hand of any changes that would have broken whitespace 
>> changes within a line. Definitely something that we need to fix if this is 
>> reproducible.
>>
>> Do you see anything in the browser's console log when you click the Show 
>> Whitespace Changes?
>>
>> What version of 1.6 are you testing in the sandbox?
>>
>> Christian
>>
>>
>> On Apr 26, 2013, at 8:29, Steve > wrote:
>>
>> We have 1.7.6 in production on a linux server. I posted a review of a php 
>> file with whitespace-only diffs on one line. When I view it on reviewboard 
>> it won't show me the diff.  With these settings:
>>
>> + Expand Changes+ Show Whitespace changes
>>
>> I see the message:
>>
>> "This file contains only whitespace changes."
>>
>> That makes sense.  When I click on the 'Show Whitespace changes' box, I 
>> still don't see any diff.
>>
>>
>> I posted the same exact review to my 1.6 sandbox, and there it behaves 
>> the way I would expect, namely when I click on the "Show Whitespace 
>> changes", I see my 1 line diff.
>>
>> This is a serious problem because those whitespace differences are not 
>> leading/trailing spaces and they're significant to the change under review.
>>
>> I compared my site settings for the diff viewer, I don't see anything 
>> that jumps out at me. Maybe something will jump out at you:
>>
>> # 1.6 server that behaves the way I want
>>  u'diffviewer_context_num_lines': 5,
>>  u'diffviewer_include_space_patterns': [u''],
>>  u'diffviewer_max_diff_size': 0,
>>  u'diffviewer_paginate_by': 20,
>>  u'diffviewer_paginate_orphans': 10,
>>  u'diffviewer_show_trailing_whitespace': False,
>>  u'diffviewer_syntax_highlighting': True,
>>  u'diffviewer_syntax_highlighting_threshold': 0,
>>
>> # 1.7.6 server that does not behave the way I want
>>  u'diffviewer_context_num_lines': 7,
>>  u'diffviewer_include_space_patterns': [u''],
>>  u'diffviewer_max_diff_size': 0,
>>  u'diffviewer_paginate_by': 10,
>>  u'diffviewer_paginate_orphans': 3,
>>  u'diffviewer_show_trailing_whitespace': False,
>>  u'diffviewer_syntax_highlighting': True,
>>  u'diffviewer_syntax_highlighting_threshold': None,
>>
>>
>> I don't know why the last setting is 0 for 1.6 and None for 1.7. They 
>> seem logically the same and not related to whitespace, but I obviously 
>> don't know that for sure. The 1.7.6 database was migrated from a 1.5 server 
>> so maybe that's why.  The 1.6 sandbox was created from scratch.
>>
>> Is this a bug, or do I have something misconfigured?
>>
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Cannot get reviewboard to display my whitespace-only diff

[Steve]

On Friday, April 26, 2013 2:44:17 PM UTC-7, Steve wrote:
>
> On Friday, April 26, 2013 12:01:45 PM UTC-7, Christian Hammond wrote:
>>
>> Hi Steve,
>>
>> I'm not aware off-hand of any changes that would have broken whitespace 
>> changes within a line. Definitely something that we need to fix if this is 
>> reproducible.
>>
>> Do you see anything in the browser's console log when you click the Show 
>> Whitespace Changes?
>>
>
>
> Using firefox with the console on, I see this with the 1.7.6 server:
>
> [14:37:19.943] Unknown property 'box-sizing'.  Declaration dropped. @ 
> https://reviewboard/r/64801/diff/#index_header
> [14:37:19.951] Use of Mutation Events is deprecated. Use MutationObserver 
> instead. @ https://reviewboard/static/lib/js/jquery-1.8.2.min.js:2
> [14:37:20.012] Error in parsing value for 'white-space'.  Declaration 
> dropped. @ https://reviewboard/r/64801/diff/#index_header
>
> But I see the same messages with 1.6.9, and the diff shows correctly, so 
> that may not mean much.
>

Sorry, I was mistaken. I get those messages when I click on the 'Expand 
changes' box, which is working fine.  When I click on the 'Show Whitespace 
changes' I don't see any messages with either 1.7.6 or 1.6.9.  I know, I'm 
making a confusing problem even more confusing.

--Steve

 

>  
>
>>
>> What version of 1.6 are you testing in the sandbox?
>>
>
>
> 1.6.9.
>
> Thanks
>
> --Steve
>
>  
>
>>
>> Christian
>>
>>
>> On Apr 26, 2013, at 8:29, Steve  wrote:
>>
>> We have 1.7.6 in production on a linux server. I posted a review of a php 
>> file with whitespace-only diffs on one line. When I view it on reviewboard 
>> it won't show me the diff.  With these settings:
>>
>> + Expand Changes+ Show Whitespace changes
>>
>> I see the message:
>>
>> "This file contains only whitespace changes."
>>
>> That makes sense.  When I click on the 'Show Whitespace changes' box, I 
>> still don't see any diff.
>>
>>
>> I posted the same exact review to my 1.6 sandbox, and there it behaves 
>> the way I would expect, namely when I click on the "Show Whitespace 
>> changes", I see my 1 line diff.
>>
>> This is a serious problem because those whitespace differences are not 
>> leading/trailing spaces and they're significant to the change under review.
>>
>> I compared my site settings for the diff viewer, I don't see anything 
>> that jumps out at me. Maybe something will jump out at you:
>>
>> # 1.6 server that behaves the way I want
>>  u'diffviewer_context_num_lines': 5,
>>  u'diffviewer_include_space_patterns': [u''],
>>  u'diffviewer_max_diff_size': 0,
>>  u'diffviewer_paginate_by': 20,
>>  u'diffviewer_paginate_orphans': 10,
>>  u'diffviewer_show_trailing_whitespace': False,
>>  u'diffviewer_syntax_highlighting': True,
>>  u'diffviewer_syntax_highlighting_threshold': 0,
>>
>> # 1.7.6 server that does not behave the way I want
>>  u'diffviewer_context_num_lines': 7,
>>  u'diffviewer_include_space_patterns': [u''],
>>  u'diffviewer_max_diff_size': 0,
>>  u'diffviewer_paginate_by': 10,
>>  u'diffviewer_paginate_orphans': 3,
>>  u'diffviewer_show_trailing_whitespace': False,
>>  u'diffviewer_syntax_highlighting': True,
>>  u'diffviewer_syntax_highlighting_threshold': None,
>>
>>
>> I don't know why the last setting is 0 for 1.6 and None for 1.7. They 
>> seem logically the same and not related to whitespace, but I obviously 
>> don't know that for sure. The 1.7.6 database was migrated from a 1.5 server 
>> so maybe that's why.  The 1.6 sandbox was created from scratch.
>>
>> Is this a bug, or do I have something misconfigured?
>>
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com.
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Cannot get reviewboard to display my whitespace-only diff

[Steve]

Well, I'm stumped. Just to be sure I hadn't messed up the installation of 
1.7.6, I installed from scratch on a sandbox server and looked at the 
review over there - same issue.  I can't see anything odd in the 
configuration.  About the only thing I can say with certainty is it works 
properly on my 1.6.9 server, but not my two 1.7.6 servers.   Am I the only 
person experiencing this problem?

--Steve


On Friday, April 26, 2013 3:14:44 PM UTC-7, Steve wrote:
>
>
>
> On Friday, April 26, 2013 2:44:17 PM UTC-7, Steve wrote:
>>
>> On Friday, April 26, 2013 12:01:45 PM UTC-7, Christian Hammond wrote:
>>>
>>> Hi Steve,
>>>
>>> I'm not aware off-hand of any changes that would have broken whitespace 
>>> changes within a line. Definitely something that we need to fix if this is 
>>> reproducible.
>>>
>>> Do you see anything in the browser's console log when you click the Show 
>>> Whitespace Changes?
>>>
>>
>>
>> Using firefox with the console on, I see this with the 1.7.6 server:
>>
>> [14:37:19.943] Unknown property 'box-sizing'.  Declaration dropped. @ 
>> https://reviewboard/r/64801/diff/#index_header
>> [14:37:19.951] Use of Mutation Events is deprecated. Use MutationObserver 
>> instead. @ https://reviewboard/static/lib/js/jquery-1.8.2.min.js:2
>> [14:37:20.012] Error in parsing value for 'white-space'.  Declaration 
>> dropped. @ https://reviewboard/r/64801/diff/#index_header
>>
>> But I see the same messages with 1.6.9, and the diff shows correctly, so 
>> that may not mean much.
>>
>
> Sorry, I was mistaken. I get those messages when I click on the 'Expand 
> changes' box, which is working fine.  When I click on the 'Show Whitespace 
> changes' I don't see any messages with either 1.7.6 or 1.6.9.  I know, I'm 
> making a confusing problem even more confusing.
>
> --Steve
>
>  
>
>>  
>>
>>>
>>> What version of 1.6 are you testing in the sandbox?
>>>
>>
>>
>> 1.6.9.
>>
>> Thanks
>>
>> --Steve
>>
>>  
>>
>>>
>>> Christian
>>>
>>>
>>> On Apr 26, 2013, at 8:29, Steve  wrote:
>>>
>>> We have 1.7.6 in production on a linux server. I posted a review of a 
>>> php file with whitespace-only diffs on one line. When I view it on 
>>> reviewboard it won't show me the diff.  With these settings:
>>>
>>> + Expand Changes+ Show Whitespace changes
>>>
>>> I see the message:
>>>
>>> "This file contains only whitespace changes."
>>>
>>> That makes sense.  When I click on the 'Show Whitespace changes' box, I 
>>> still don't see any diff.
>>>
>>>
>>> I posted the same exact review to my 1.6 sandbox, and there it behaves 
>>> the way I would expect, namely when I click on the "Show Whitespace 
>>> changes", I see my 1 line diff.
>>>
>>> This is a serious problem because those whitespace differences are not 
>>> leading/trailing spaces and they're significant to the change under review.
>>>
>>> I compared my site settings for the diff viewer, I don't see anything 
>>> that jumps out at me. Maybe something will jump out at you:
>>>
>>> # 1.6 server that behaves the way I want
>>>  u'diffviewer_context_num_lines': 5,
>>>  u'diffviewer_include_space_patterns': [u''],
>>>  u'diffviewer_max_diff_size': 0,
>>>  u'diffviewer_paginate_by': 20,
>>>  u'diffviewer_paginate_orphans': 10,
>>>  u'diffviewer_show_trailing_whitespace': False,
>>>  u'diffviewer_syntax_highlighting': True,
>>>  u'diffviewer_syntax_highlighting_threshold': 0,
>>>
>>> # 1.7.6 server that does not behave the way I want
>>>  u'diffviewer_context_num_lines': 7,
>>>  u'diffviewer_include_space_patterns': [u''],
>>>  u'diffviewer_max_diff_size': 0,
>>>  u'diffviewer_paginate_by': 10,
>>>  u'diffviewer_paginate_orphans': 3,
>>>  u'diffviewer_show_trailing_whitespace': False,
>>>  u'diffviewer_syntax_highlighting': True,
>>>  u'diffviewer_syntax_highlighting_threshold': None,
>>>
>>>
>>> I don't know why the last setting is 0 for 1.6 and None for 1.7. They 
>>>

Listing all groups a user belongs to

[Steve]

I'm using ReviewBoard 1.7.6.  I was hoping the new UI would have some way 
to list the ReviewBoard groups that a user belongs to, but I can't find it. 
 Is there a way to do that?  If not, are there plans to add it?  When 
someone leaves the company we want to remove them from ReviewBoard groups 
and right now I have a script that talks directly to the database, but it 
would be nice if the Web UI could present that information.

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Unable to create review using P4 repository

[Steve]

I have these set in my htdocs/reviewboard.wsgi file:

os.environ['P4PORT'] = ""
os.environ['P4USER'] = ""
os.environ['P4CLIENT'] = ""
os.environ['P4TICKETS'] = "path to ticket file"
os.environ['PATH'] = os.environ['PATH'] + ":/usr/local/bin"

I need P4TICKETS because we use p4 passwords.  If you don't, you won't 
 need that.

--Steve


On Thursday, May 23, 2013 1:40:16 PM UTC-7, Hussein Khalil wrote:
>
> Hi,
>
> I am attempting to use ReviewBoard along with a P4 repository.
>
> When I try to create a review using post-review, I get the following error:
>
> Error creating review request: Unable to authenticate with the repository 
> using the provided credentials (HTTP 403, API Error 218)
>
> After enabling logging, I discovered that the problem was that the 
> 'www-data' user was being used instead of my p4user:
>
>  Got unexpected SCMError when creating repository: [P4#run] Errors during 
> command execution( "p4 describe -s 202213" )
>
> [Error]: "Access for user 'www-data' has not been enabled by 'p4 protect'."
>
>
> How can I tell the Web Server to use a pre-defined P4 user instead of 
> 'www-data' ? I tried setting the P4 username and P4 password in the 
> ReviewBoard Repository management page, yet the same problem still occurs.
>
> I also tried setting environment variables in the envvars file for apache, 
> and I also still get the same problem.
>
> What am I doing wrong ?
>
> Thanks
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Listing all groups a user belongs to

[Steve]

Do you mean the 'Groups' box in the 'Permissions' section on the 'Change 
User' page?  For every user I've checked, the only entry in the 'Groups' 
box is 'default reviewer'.  It doesn't correctly show the groups they 
belong to, which may be why I missed it before.  A bug maybe?

--Steve


On Wednesday, June 5, 2013 11:56:54 AM UTC-7, David Trowbridge wrote:
>
> If you go to the site admin, and browse to the desired user, there's a 
> "Groups" box where you can unselect everything.
>
> -David
>
>
> On Wed, Jun 5, 2013 at 7:30 AM, Steve >wrote:
>
>> I'm using ReviewBoard 1.7.6.  I was hoping the new UI would have some way 
>> to list the ReviewBoard groups that a user belongs to, but I can't find it. 
>>  Is there a way to do that?  If not, are there plans to add it?  When 
>> someone leaves the company we want to remove them from ReviewBoard groups 
>> and right now I have a script that talks directly to the database, but it 
>> would be nice if the Web UI could present that information.
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Listing all groups a user belongs to

[Steve]

Okay, will do.


On Wednesday, June 5, 2013 3:57:15 PM UTC-7, David Trowbridge wrote:
>
> Oh, I guess I just cursorily looked at this and was confused. You're right 
> that we don't have an admin-visible UI.
>
> This is something that's probably worth adding, but we're pretty bogged 
> down right now. Mind filing an enhancement request in the issue tracker?
>
> Thanks,
> -David
>
>
> On Wed, Jun 5, 2013 at 2:43 PM, Steve >wrote:
>
>> Do you mean the 'Groups' box in the 'Permissions' section on the 'Change 
>> User' page?  For every user I've checked, the only entry in the 'Groups' 
>> box is 'default reviewer'.  It doesn't correctly show the groups they 
>> belong to, which may be why I missed it before.  A bug maybe?
>>
>> --Steve
>>
>>
>> On Wednesday, June 5, 2013 11:56:54 AM UTC-7, David Trowbridge wrote:
>>
>>> If you go to the site admin, and browse to the desired user, there's a 
>>> "Groups" box where you can unselect everything.
>>>
>>> -David
>>>
>>>
>>> On Wed, Jun 5, 2013 at 7:30 AM, Steve  wrote:
>>>
>>>>  I'm using ReviewBoard 1.7.6.  I was hoping the new UI would have some 
>>>> way to list the ReviewBoard groups that a user belongs to, but I can't 
>>>> find 
>>>> it.  Is there a way to do that?  If not, are there plans to add it?  When 
>>>> someone leaves the company we want to remove them from ReviewBoard groups 
>>>> and right now I have a script that talks directly to the database, but it 
>>>> would be nice if the Web UI could present that information.
>>>>  
>>>> --Steve
>>>>
>>>>  -- 
>>>> Want to help the Review Board project? Donate today at 
>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>> Happy user? Let us know at 
>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>> -~--~~~~--**~~--~--~---
>>>> To unsubscribe from this group, send email to reviewboard...@**
>>>> googlegroups.com
>>>>
>>>> For more options, visit this group at http://groups.google.com/**
>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>> --- 
>>>> You received this message because you are subscribed to the Google 
>>>> Groups "reviewboard" group.
>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>> an email to reviewboard...@**googlegroups.com.
>>>>
>>>> For more options, visit 
>>>> https://groups.google.com/**groups/opt_out<https://groups.google.com/groups/opt_out>
>>>> .
>>>>  
>>>>  
>>>>
>>>
>>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: RB1.7.7.1 Upgrade Bug: Hide WhiteSpace changes in viewdiff is not functioning.

[Steve]

I wonder if this issue is related to the problem I asked about here last 
month, with this subject line:

*Cannot get reviewboard to display my whitespace-only diff*

I'd be happy to test out proposed fixes if it's not too invasive.

--Steve


On Wednesday, June 5, 2013 6:59:40 AM UTC-7, satish singh wrote:
>
> I looked at this issue today. The issue here is, a class called 
> "whitespace-chunk"
> is not being generated to html page:
>
> It should be like:
>
> 
> 
>
> But its coming rendering like this:
>
> 
> 
>
>
> As per my anaysis, this calss is getting rendered through:
> reviewboard/templates/diffviewer/diff_file_fragment.html
>
> {% if chunk.meta.whitespace_chunk%} whitespace-chunk{% endif %}
>
> I am not getting what is chunk.meta.whitespace_chunk, why its coming as 
> false ?
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Reviews are being mysteriously marked as submitted

[Steve]

We're running RB 1.7.6.  I've had several users report their reviews have 
been marked as submitted, and I've seen it as well. As an experiment, I 
asked a user without admin or superuser rights to mark one of my reviews as 
submitted and they were able to do so.  This raises these questions:

1. Should that be possible, or is something wrong with my site?

2. Is it configurable, and if so, how do I configure things so only the 
owner or admin can close a review?

3. Is can mine the database to see when a review gets changed from pending 
to submitted, but I can't figure out how to determine who made the change. 
 Is that possible?

I've searched our cron jobs to see if we had scripts closing  reviews 
automatically, but we have nothing doing that as far as I can see, and it 
seems unlikely that someone would mark a review as submitted accidentally, 
so I'm quite stumped by this.

Thanks

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: RB1.7.7.1 Upgrade Bug: Hide WhiteSpace changes in viewdiff is not functioning.

[Steve]

Okay, but it's not working on my 1.7.6 site and I haven't been able to 
figure out why. Maybe it will fix itself when I upgrade.

--steve

On Friday, June 7, 2013 3:21:26 AM UTC-7, Varun Jain wrote:
>
> Hi Steve,
>
> Hide Whitespace changes is working fine, Actually it highlights the line 
> containing white space changes only.
>
> If you have only white space changes in some lines then those lines will 
> be highlighted when you toggle Hide whitespace
>
> changes.
>
>
> Regards,
> Varun
>
> On Wednesday, 5 June 2013 19:29:40 UTC+5:30, satish singh wrote:
>>
>> I looked at this issue today. The issue here is, a class called 
>> "whitespace-chunk"
>> is not being generated to html page:
>>
>> It should be like:
>>
>> 
>> 
>>
>> But its coming rendering like this:
>>
>> 
>> 
>>
>>
>> As per my anaysis, this calss is getting rendered through:
>> reviewboard/templates/diffviewer/diff_file_fragment.html
>>
>> {% if chunk.meta.whitespace_chunk%} whitespace-chunk{% endif %}
>>
>> I am not getting what is chunk.meta.whitespace_chunk, why its coming as 
>> false ?
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviews are being mysteriously marked as submitted

[Steve]

The box on their user page entitled 'chosen user permissions' is blank.

--Steve


On Tuesday, June 11, 2013 1:58:02 PM UTC-7, David Trowbridge wrote:
>
> Normal users should not have the ability to close others' review requests.
>
> You say these users are not admin or superuser. Do they have the "can 
> change status" permission enabled?
>
> -David
>
>
> On Tue, Jun 11, 2013 at 10:23 AM, Steve  >wrote:
>
>> We're running RB 1.7.6.  I've had several users report their reviews have 
>> been marked as submitted, and I've seen it as well. As an experiment, I 
>> asked a user without admin or superuser rights to mark one of my reviews as 
>> submitted and they were able to do so.  This raises these questions:
>>
>> 1. Should that be possible, or is something wrong with my site?
>>
>> 2. Is it configurable, and if so, how do I configure things so only the 
>> owner or admin can close a review?
>>
>> 3. Is can mine the database to see when a review gets changed from 
>> pending to submitted, but I can't figure out how to determine who made the 
>> change.  Is that possible?
>>
>> I've searched our cron jobs to see if we had scripts closing  reviews 
>> automatically, but we have nothing doing that as far as I can see, and it 
>> seems unlikely that someone would mark a review as submitted accidentally, 
>> so I'm quite stumped by this.
>>
>> Thanks
>>
>> --Steve
>>
>>  -- 
>> Want to help the Review Board project? Donate today at 
>> http://www.reviewboard.org/donate/
>> Happy user? Let us know at http://www.reviewboard.org/users/
>> -~--~~~~--~~--~--~---
>> To unsubscribe from this group, send email to 
>> reviewboard...@googlegroups.com 
>> For more options, visit this group at 
>> http://groups.google.com/group/reviewboard?hl=en
>> --- 
>> You received this message because you are subscribed to the Google Groups 
>> "reviewboard" group.
>> To unsubscribe from this group and stop receiving emails from it, send an 
>> email to reviewboard...@googlegroups.com .
>> For more options, visit https://groups.google.com/groups/opt_out.
>>  
>>  
>>
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviews are being mysteriously marked as submitted

[Steve]

I'm  I just had another user report this same problem: 

"""
Here’s the issue; after creating a new review and updating and publishing 
it via the Review Board ‘Outgoing Reviews’, within an hour or two I’m 
finding  that the review is being marked as submitted without me having 
done so. I don’t submit a lot of reviews but I’ve noticed this happening on 
the my last two reviews at least. I’ve talked with other team members and 
no one has indicated that they submitted the change.
"""

I'm not seeing anything in the rb logs and am completely stumped.  Any 
ideas on how I can debug this?  It's so bizarre.

--Steve


On Wednesday, June 12, 2013 7:15:59 AM UTC-7, Steve wrote:
>
> The box on their user page entitled 'chosen user permissions' is blank.
>
> --Steve
>
>
> On Tuesday, June 11, 2013 1:58:02 PM UTC-7, David Trowbridge wrote:
>>
>> Normal users should not have the ability to close others' review requests.
>>
>> You say these users are not admin or superuser. Do they have the "can 
>> change status" permission enabled?
>>
>> -David
>>
>>
>> On Tue, Jun 11, 2013 at 10:23 AM, Steve  wrote:
>>
>>> We're running RB 1.7.6.  I've had several users report their reviews 
>>> have been marked as submitted, and I've seen it as well. As an experiment, 
>>> I asked a user without admin or superuser rights to mark one of my reviews 
>>> as submitted and they were able to do so.  This raises these questions:
>>>
>>> 1. Should that be possible, or is something wrong with my site?
>>>
>>> 2. Is it configurable, and if so, how do I configure things so only the 
>>> owner or admin can close a review?
>>>
>>> 3. Is can mine the database to see when a review gets changed from 
>>> pending to submitted, but I can't figure out how to determine who made the 
>>> change.  Is that possible?
>>>
>>> I've searched our cron jobs to see if we had scripts closing  reviews 
>>> automatically, but we have nothing doing that as far as I can see, and it 
>>> seems unlikely that someone would mark a review as submitted accidentally, 
>>> so I'm quite stumped by this.
>>>
>>> Thanks
>>>
>>> --Steve
>>>
>>>  -- 
>>> Want to help the Review Board project? Donate today at 
>>> http://www.reviewboard.org/donate/
>>> Happy user? Let us know at http://www.reviewboard.org/users/
>>> -~--~~~~--~~--~--~---
>>> To unsubscribe from this group, send email to 
>>> reviewboard...@googlegroups.com
>>> For more options, visit this group at 
>>> http://groups.google.com/group/reviewboard?hl=en
>>> --- 
>>> You received this message because you are subscribed to the Google 
>>> Groups "reviewboard" group.
>>> To unsubscribe from this group and stop receiving emails from it, send 
>>> an email to reviewboard...@googlegroups.com.
>>> For more options, visit https://groups.google.com/groups/opt_out.
>>>  
>>>  
>>>
>>
>>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviews are being mysteriously marked as submitted

[Steve]

We have a custom authentication backend we use to authenticate via ldap. 
 Other than that, it's out-of-the-box.  The server is brand new, so RB 1.7 
was newly installed.  However, our database schema has migrated from 1.0 to 
1.5 to 1.7.6.  Any chance of an old configuration setting in the database 
having any impact on this?

--Steve

On Wednesday, June 12, 2013 3:19:31 PM UTC-7, David Trowbridge wrote:
>
> This is incredibly strange. Web server logs may let you see if there are 
> any API requests that could be causing this, but it's probably pretty hard 
> to find in the noise.
>
> Do you have any custom modifications or extensions or is it purely the 
> released version?
>
> -David
>
>
> On Wed, Jun 12, 2013 at 3:08 PM, Steve  >wrote:
>
>> I'm  I just had another user report this same problem: 
>>
>> """
>> Here’s the issue; after creating a new review and updating and publishing 
>> it via the Review Board ‘Outgoing Reviews’, within an hour or two I’m 
>> finding  that the review is being marked as submitted without me having 
>> done so. I don’t submit a lot of reviews but I’ve noticed this happening on 
>> the my last two reviews at least. I’ve talked with other team members and 
>> no one has indicated that they submitted the change.
>> """
>>
>> I'm not seeing anything in the rb logs and am completely stumped.  Any 
>> ideas on how I can debug this?  It's so bizarre.
>>
>> --Steve
>>
>>
>> On Wednesday, June 12, 2013 7:15:59 AM UTC-7, Steve wrote:
>>>
>>> The box on their user page entitled 'chosen user permissions' is blank.
>>>
>>> --Steve
>>>
>>>
>>> On Tuesday, June 11, 2013 1:58:02 PM UTC-7, David Trowbridge wrote:
>>>>
>>>> Normal users should not have the ability to close others' review 
>>>> requests.
>>>>
>>>> You say these users are not admin or superuser. Do they have the "can 
>>>> change status" permission enabled?
>>>>
>>>> -David
>>>>
>>>>
>>>> On Tue, Jun 11, 2013 at 10:23 AM, Steve  wrote:
>>>>
>>>>> We're running RB 1.7.6.  I've had several users report their reviews 
>>>>> have been marked as submitted, and I've seen it as well. As an 
>>>>> experiment, 
>>>>> I asked a user without admin or superuser rights to mark one of my 
>>>>> reviews 
>>>>> as submitted and they were able to do so.  This raises these questions:
>>>>>
>>>>> 1. Should that be possible, or is something wrong with my site?
>>>>>
>>>>> 2. Is it configurable, and if so, how do I configure things so only 
>>>>> the owner or admin can close a review?
>>>>>
>>>>> 3. Is can mine the database to see when a review gets changed from 
>>>>> pending to submitted, but I can't figure out how to determine who made 
>>>>> the 
>>>>> change.  Is that possible?
>>>>>
>>>>> I've searched our cron jobs to see if we had scripts closing  reviews 
>>>>> automatically, but we have nothing doing that as far as I can see, and it 
>>>>> seems unlikely that someone would mark a review as submitted 
>>>>> accidentally, 
>>>>> so I'm quite stumped by this.
>>>>>
>>>>> Thanks
>>>>>
>>>>> --Steve
>>>>>
>>>>>  -- 
>>>>> Want to help the Review Board project? Donate today at 
>>>>> http://www.reviewboard.org/**donate/<http://www.reviewboard.org/donate/>
>>>>> Happy user? Let us know at 
>>>>> http://www.reviewboard.org/**users/<http://www.reviewboard.org/users/>
>>>>> -~--~~~~--**~~--~--~---
>>>>> To unsubscribe from this group, send email to 
>>>>> reviewboard...@googlegroups.**com
>>>>> For more options, visit this group at http://groups.google.com/**
>>>>> group/reviewboard?hl=en<http://groups.google.com/group/reviewboard?hl=en>
>>>>> --- 
>>>>> You received this message because you are subscribed to the Google 
>>>>> Groups "reviewboard" group.
>>>>> To unsubscribe from this group and stop receiving emails from it, send 
>>>>> an email to reviewboard...@googlegroups.**com.
>>>>

Re: Reviews are being mysteriously marked as submitted

[Steve]

I'd like to back up and break this down into smaller, simpler questions.

When I go to my 1.6.9 RB server and browse to another user's review, I see 
these buttons along the top, right portion of the page:

Download DiffReviewShip It!View Diff

When I go to  both of my 1.7.6 servers and browse to another user's review, 
I see these buttons along the top, right portion of the page:

CloseUpdateDownload DiffReviewShip It!View Diff

I only see the 'Close' button in 1.6.9 when I'm viewing my own requests. 

So, is that an intentional change in RB 1.7, or is my site somehow 
misconfigured?

Thanks!

--Steve

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.

Re: Reviews are being mysteriously marked as submitted

[Steve]

I do not have staff or superuser set for this account, nor any special mod 
permissions.  And everyone here also sees the same 'Close' button on other 
people's reviews.  So, something is configured.  I wonder if there's an old 
database setting that we've been pulling along since the 1.0.x, 1.5 days 
that's causing this.  Do you have some ideas on what db tables I can look 
in for clues?

--Steve


On Friday, June 14, 2013 2:09:49 PM UTC-7, Christian Hammond wrote:
>
> Hi Steve,
>
> Are you set up as an admin on both servers? Or do you have the Can Close 
> privilege set?
>
> If so, 1.7.x should behave the same as it did in 1.6.x (and certainly does 
> in our installs).
>
> Christian
>
>
> On Jun 14, 2013, at 14:04, Steve > wrote:
>
> I'd like to back up and break this down into smaller, simpler questions.
>
> When I go to my 1.6.9 RB server and browse to another user's review, I see 
> these buttons along the top, right portion of the page:
>
> Download DiffReviewShip It!View Diff
>
> When I go to  both of my 1.7.6 servers and browse to another user's 
> review, I see these buttons along the top, right portion of the page:
>
> CloseUpdateDownload DiffReviewShip It!View Diff
>
> I only see the 'Close' button in 1.6.9 when I'm viewing my own requests. 
>
> So, is that an intentional change in RB 1.7, or is my site somehow 
> misconfigured?
>
> Thanks!
>
> --Steve
>
>  -- 
> Want to help the Review Board project? Donate today at 
> http://www.reviewboard.org/donate/
> Happy user? Let us know at http://www.reviewboard.org/users/
> -~--~~~~--~~--~--~---
> To unsubscribe from this group, send email to 
> reviewboard...@googlegroups.com 
> For more options, visit this group at 
> http://groups.google.com/group/reviewboard?hl=en
> --- 
> You received this message because you are subscribed to the Google Groups 
> "reviewboard" group.
> To unsubscribe from this group and stop receiving emails from it, send an 
> email to reviewboard...@googlegroups.com .
> For more options, visit https://groups.google.com/groups/opt_out.
>  
>  
>
>

-- 
Want to help the Review Board project? Donate today at 
http://www.reviewboard.org/donate/
Happy user? Let us know at http://www.reviewboard.org/users/
-~--~~~~--~~--~--~---
To unsubscribe from this group, send email to 
reviewboard+unsubscr...@googlegroups.com
For more options, visit this group at 
http://groups.google.com/group/reviewboard?hl=en
--- 
You received this message because you are subscribed to the Google Groups 
"reviewboard" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to reviewboard+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.