Re: Post-review thinks CVS diff file is empty

2011-09-26 Thread Matthew
raise SCMError(errmsg) SCMError: cvs [checkout aborted]: Absolute module reference invalid: `/ usr/local/cvsroot/WorldWind/src/gov/nasa/worldwind/Version.ja va' On Sep 26, 4:05 pm, Christian Hammond wrote: > Hi Matthew, > > It's entirely possible that that error is misleading.

Post-review thinks CVS diff file is empty

2011-09-26 Thread Matthew
The cvs command issued by post-review executes, but post-review doesn't seem to think there are any diffs to upload. I'll include the result of post-review --output-diff --debug at the end of this message Although I have a software background it has been a long time since I've done any sort of sys

Re: Review Board has moved to Git - Changes required

2009-09-09 Thread Matthew Woehlke
ow to get post-review to work with rbtools git? (Also, I hate using actual mail for mailing lists ;-), anyone mind if I ask gmane to carry reviewbo...@?) -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups &q

Re: Review Board has moved to Git - Changes required

2009-09-09 Thread Matthew Woehlke
That's not NNTP :-). (IMO HTTP interfaces are even worse than mail. /me laments underappreciated NNTP which is still by far the best interface for discussion lists.) -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to

Re: Review Board has moved to Git - Changes required

2009-09-10 Thread Matthew Woehlke
no > trouble rebasing your patch until it gets accepted! True :-). (Actually, the patch still applied cleanly, sans needing to type manually the name of the file to patch, since "post-review" is now named "postreview.py". Alas, Review Board didn't see

Re: ReviewBoard + GIT Integration

2009-09-15 Thread Matthew Woehlke
just snag postreview.py and make sure everyone has a copy.) -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewboard@googlegroups.com T

Re: ReviewBoard + GIT Integration

2009-09-16 Thread Matthew Woehlke
dows machine, I think it should work. Obviously, you'll also need Python :-). -- Matthew --~--~-~--~~~---~--~~ You received this message because you are subscribed to the Google Groups "reviewboard" group. To post to this group, send email to reviewb

setting up memcache (for RB) on Fedora 12?

2009-12-03 Thread Matthew Woehlke
Is libmemcache/cmemcache still needed, or is RB using some other way to talk to memcached? I wonder because the latest "rc2" of libmemcache is almost three years old. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy us

Re: setting up memcache (for RB) on Fedora 12?

2009-12-07 Thread Matthew Woehlke
On 2009-12-03 15:59, Matthew Woehlke wrote: > Is libmemcache/cmemcache still needed, or is RB using some other way to > talk to memcached? I wonder because the latest "rc2" of libmemcache is > almost three years old. So... apparently python-memcached suffices. At least, I got

Re: Multiple diffs per review?

2010-02-04 Thread Matthew Woehlke
. I use this frequently when I have vcs:r1 == a bunch of whitespace changes and vcs:r2 == interesting changes. Note that you can assign the review initially to a dummy user to avoid spamming everyone when you incrementally upload+publish diffs. -- Matthew -- Want to help the Review Board

Re: Multiple diffs per review?

2010-02-05 Thread Matthew Woehlke
On 2010-02-04 18:15, Stodge wrote: On Feb 4, 6:21 pm, Matthew Woehlke wrote: On 2010-02-04 10:13, Stodge wrote: [...] we need to be able to group multiple revisions on one review. Is this possible with RB? You could upload the diff of the first revision, publish it, upload the cumulative

granting staff permissions without superuser permission?

2010-03-10 Thread Matthew Woehlke
peruser. Is there a permission to prevent that? I'm using RB 1.0.5.1. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To un

Re: granting staff permissions without superuser permission?

2010-03-10 Thread Matthew Woehlke
ynonymous. I guess I should bug Django about it? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this

how to rotate reviewboard log?

2010-04-14 Thread Matthew Woehlke
uot; Well, various sources say I can do that for lighttpd with logrotate and 'service lighttpd reload'. But will that work for Review Board's log? What is the proper way to rotate Review Board's log file? -- Matthew -- Want to help the Review Board project? Donate today at

Re: how to rotate reviewboard log?

2010-04-14 Thread Matthew Woehlke
On 2010-04-14 12:42, Jan Koprowski wrote: On Apr 14, 7:05 pm, Matthew Woehlke wrote: So, while wondering why a request was taking a while to post, I was poking around for the logs, and noticed that the lighttpd log had grown to over 240 MiB. "Okay," I said to myself, "I need t

Re: how to rotate reviewboard log?

2010-04-19 Thread Matthew Woehlke
ble. (Maybe I will even take a look at what would be required...) For now I may just deal with the lighttpd restart, maybe I'll use weekly instead of daily rotation to minimize disruption. Thanks for the useful info. -- Matthew -- Want to help the Review Board project? Donate today at

Re: Review Board 1.0.8 released

2010-05-17 Thread Matthew Woehlke
re how one achieves that? Or does that mean it is safe to just move the log file and RB will notice and adjust? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard

Re: How do I install RBTools under windows?

2010-05-17 Thread Matthew Woehlke
sy_install RBTools". See http://pypi.python.org/pypi/setuptools#installation-instructions . Hope that helps. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~---

Re: Review Board 1.0.8 released

2010-05-17 Thread Matthew Woehlke
ly. Thanks for this improvement! -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, sen

Search not enabled on Ubuntu Server 11.04

2011-07-28 Thread Matthew Blair
guide for Linux seems to pretty indicate that PyLucene must be installed, then search must be enabled via the admin page, followed by setting up a cron job. What is my next step for debugging this problem? Thanks for any help you can provide, Matthew -- Want to help the Review Board project

Re: Search not enabled on Ubuntu Server 11.04

2011-07-28 Thread Matthew Blair
David - yes, running in apache, and have executed several restarts of httpd after the install of pylucene. The restarts were related to other configuration items though, such as enabling SSL. Thanks, Matthew On Jul 28, 12:33 pm, David Trowbridge wrote: > Are you running in apache? Have

Method names in condensed diff view - I love you all

2011-09-14 Thread Matthew Flint
Hey, We just upgraded ReviewBoard, and I see there are now method names shown even when that part of the file is hidden. It is brilliant. I love you all. Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http

Re: Unable to get post-review to recognise a P4 repository

2012-03-27 Thread Matthew Waddilove
I think that this is similar to a problem that I've come across, or might be the same tbh. :) I had all sorts of issues as we're both using a perforce proxy and reviewboard at a remote location so had to do some fiddling to get it all to work, both configuring reviewboard, and poking ssh tunnels

Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
I'm trying to post a review request for a changeset I created on a new branch of our public github repo. Since I already committed the change, I enter: $ post-review --parent 5f7fc000274abab9cbfb7a00a5b9602314ae6268 I'm getting the dreaded 207 (the file was not found in the repository) error.

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
chip...@chipx86.com > Review Board - http://www.reviewboard.org > VMware, Inc. - http://www.vmware.com > > > On Tue, Jun 19, 2012 at 9:37 AM, Matthew Gertner > wrote: > >> I'm trying to post a review request for a changeset I created on a new >> branch of our public git

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
BTW, I just tried uploading the diff manually (no parent diff) and I get exactly the same error message about the file not being in the repo. The only thing I can think of is perhaps their are some Windows line endings in the file. Would that bother RB? -- Want to help the Review Board project

Re: Error 207 when using post-review with github

2012-06-19 Thread Matthew Gertner
On Wednesday, June 20, 2012 8:34:41 AM UTC+2, Christian Hammond wrote: > > Which version of RB though? This is important as GitHub made some major > changes recently that are only compatible with the latest 1.6.x releases. > > Christian > > Aha, we're still on 1.6.4.1. I'll ask our sysadmin to upd

How does ReviewBoard access repositories?

2017-12-04 Thread Matthew Donovan
e the user's credentials. Is that correct? Thanks -Matthew -- Supercharge your Review Board with Power Pack: https://www.reviewboard.org/powerpack/ Want us to host Review Board for you? Check out RBCommons: https://rbcommons.com/ Happy user? Let us know! https://www.reviewboard.org/users

htdocs/media/ext and htdocs/static/ext ownership changes

2018-01-30 Thread Matthew Donovan
I installed ReviewBoard yesterday on CentOS 7 with the command 'yum install ReviewBoard'. We got it working by making all files owned by apache. Today, I updated the software through easy_install and manually updated/upgraded my site and tried to tighten up the file permissions. The problem

custom fields redux

2012-11-07 Thread Matthew Woehlke
(especially with working completion) would be ideal, but what we're doing now with gerrit is requiring a machine-readable tag in the request description, so this would be okay too. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user

cannot join review group?

2012-11-08 Thread Matthew Woehlke
checked and 'invite only' not checked. Am I doing something wrong? Is there a permission somewhere that is not set properly? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happ

Re: cannot join review group?

2012-11-08 Thread Matthew Woehlke
eta. Okay; good to know it is a known issue. Thanks. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this

Re: Extension generator throwing exception

2012-11-08 Thread Matthew Woehlke
have the same problem, except it is complaining about extension/__init__.py. Help would be appreciated. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.o

owner cannot drop issues?

2012-11-16 Thread Matthew Woehlke
If I create an issue on a request, and later realize it is not an issue, is there no way for me (as the issue creator) to drop the issue? If not, would it be possible to add this ability? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate

Re: Integration of RB with Gitlab

2012-11-20 Thread Matthew Woehlke
p.s. If you end up patching Gitlab yourself, what you need is basically a URL that gives you the output of 'git show '. The path isn't actually needed for git. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/

Re: Integration of RB with Gitlab

2012-11-20 Thread Matthew Woehlke
clone the gitorious repo for such a service (and at that point, you might as well keep the clone where RB can talk to it directly). -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.r

Re: Configuring Review Board for GIT

2012-12-04 Thread Matthew Woehlke
27;s for experimenting, read up on git's 'ls-tree' command. (Short form: 'git ls-tree ' will give you the list of blobs (files) with their respective ID's in as of .) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewbo

Re: Error using post-review with git

2012-12-04 Thread Matthew Woehlke
ply returns. That could mean the value is an empty string (it shouldn't be), or the command failed. What does 'git config core.bare; echo $?' say? Note: what *should* happen is it echoes 'false' (unless run in a bare repository, in which case it would echo 't

Re: I have implemented --file-list in post-review

2012-12-04 Thread Matthew Woehlke
the same branch. We would also like to record the SHA that was posted (mostly to be able to verify when doing a merge that the branch hasn't changed) as well as the name of the branch that was posted, but this needs server-side changes of course. -- Matthew -- Want to help the Revie

post-review fails if no tracking branch, when not needed?

2012-12-04 Thread Matthew Woehlke
I'm seeing this out of post-review: post-review --revision-range=: --output-diff --debug RBTools 0.4.1 Home = /home/matthew HTTP GETting api/ HTTP GETting https://manticore/api/info/ Using the new web API Failed to execute command: ['git', 'merge-base', 'origin/m

post-review doesn't work with extraneous git-svn remote?

2012-12-04 Thread Matthew Woehlke
? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr

Re: post-review fails if no tracking branch, when not needed?

2012-12-06 Thread Matthew Woehlke
k that needs to be done to refactor this code and clean it up. Would you mind filing a bug to help us track this? Sure. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.review

Re: Configuring Review Board for GIT

2012-12-07 Thread Matthew Woehlke
still get an error. ...looks reasonable. I would guess the Raw File URL is the issue. (Have you checked the server's logs to see what it is trying to do?) What about the id2 in the raw file URL mask - should I leave it as id2 or should I use just id ? This I don't know... whatever w

open issue without code comment?

2012-12-07 Thread Matthew Woehlke
it has e.g. introduced a behavioral regression, but don't know what specific code is the culprit. I think it makes sense for tracking purposes to be able to open an issue describing the problem, rather than just a review stating that a problem exists. Thanks, -- Matthew -- Want to help t

Re: open issue without code comment?

2012-12-07 Thread Matthew Woehlke
On 2012-12-07 14:55, Christian Hammond wrote: On Dec 7, 2012, at 11:52 AM, Matthew Woehlke wrote: Is it possible to create an issue for a review request without it being associated with a code comment? (I don't see a way, but want to check if I'm missing something before filing an e

Re: Will there be a 1.6.14 release

2012-12-12 Thread Matthew Woehlke
ine 63, in run self.run_command('build_media') File "/usr/lib64/python2.7/distutils/cmd.py", line 326, in run_command self.distribution.run_command(command) File "/usr/lib64/python2.7/distutils/dist.py", line 972, in run_command cmd_obj.run() File &

Re: Will there be a 1.6.14 release

2012-12-12 Thread Matthew Woehlke
not going to try to test it today, though; I don't have a VM set up for a test install, so I don't plan on dropping the new build in without at least a database backup in case something goes wrong, and I don't expect to get to that immediately. -- Matthew -- Want to help the Rev

record git branch name in request?

2012-12-13 Thread Matthew Woehlke
short term solution (longer term I would rather have the SHA there). Another would be an RB extension to add a custom field. In the latter case, does anyone have an example of doing this, both in terms of the extension, and also how to retrieve the value from the server? -- Matthew -- Want to

FYI 1.7 rc1 results (was: Will there be a 1.6.14 release)

2012-12-13 Thread Matthew Woehlke
olling the Fedora package that djblets 0.7.2 is no longer sufficient for rc1. (I just rebuilt the RPM bumping the source to 0.7.6 with no issue, so am using that; not sure what the actual requirement is.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.revie

Re: record git branch name in request?

2012-12-13 Thread Matthew Woehlke
this in existing 'change request') We're also going to want/need a few local fields, but not things that would make sense for inclusion in RB proper. Ability to view individual commit diffs in a multi-commit request would be awesome (you probably know that already) but I expect

cannot add remote repository in 1.7 rc1?

2012-12-14 Thread Matthew Woehlke
but is not visible... -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboar

Re: cannot add remote repository in 1.7 rc1?

2012-12-14 Thread Matthew Woehlke
...) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr

Re: Extension generator throwing exception

2012-12-15 Thread Matthew Woehlke
On 2012-11-08 19:53, Matthew Woehlke wrote: On 2012-10-11 00:43, kvr wrote: I'm trying to generate an extension using extension_generator.py but it is throwing the following exception> *jinja2.exceptions.TemplateNotFound: extension/templates/extension/dashboard.html* But actua

Re: Review Board, Git and patch-series

2012-12-16 Thread Matthew Woehlke
On 2012-12-15 14:13, Matthew Woehlke wrote: On Monday, October 31, 2011 10:45:15 AM UTC-4, Stephen Gallagher wrote: I've been trying to work out for some time now how to accomplish patch-series in Git with Review Board. [...] Modify post-review so that it will create an individual revi

Re: Review Board 1.7.1 released

2012-12-21 Thread Matthew Woehlke
the '+', and as I recall, I had to put it there. I'm also on Fedora 18.) p.s. Big thanks to Stephen for the packages! -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.review

trouble editing review with code comments

2012-12-21 Thread Matthew Woehlke
s this a known issue? I feel like I remember hearing about something similar on the list... I'm on RB 1.7.1 upgraded from 1.7.0 rc1 from 1.7.0 beta 4; maybe I missed a step upgrading? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate

Re: trouble editing review with code comments

2012-12-21 Thread Matthew Woehlke
httpd?) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr

Re: trouble editing review with code comments

2012-12-21 Thread Matthew Woehlke
.. Thanks for the help (also thanks to Stephen, again, for the package... sheesh, 0.7.7 didn't last long, did it? :-) ). -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.review

Re: Customization the Review Board

2012-12-26 Thread Matthew Woehlke
before publishing and how to publish it also. What is the work flow. I'm having a similar issue. If you manage to create a working example, PLEASE share it, as one is desperately needed for those of us that aren't intimately familiar with RB's source. -- Matthew -- Want to

Re: Customization the Review Board

2012-12-26 Thread Matthew Woehlke
f we can't see the name of the request branch on the web interface, but if we can get/set it through the API, I could at least write a functional 'git rb merge'. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Le

Re: Some noob questions...

2012-12-28 Thread Matthew Woehlke
anyway, but I'd stay away from gerrit; it's interface is absolute rubbish compared to RB. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~

Re: Testing 1.7.1 on Fedora 18

2013-01-04 Thread Matthew Woehlke
the appropriate database backend, as well as any VCS or authentication method in use; those are just the ones I'm using.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/

Re: Ready VM or Recommended distribution for Review Board 1.7

2013-01-07 Thread Matthew Woehlke
d the still-in-beta version 18 thereof, I'm happily doing likewise using Stephen's packages of RB 1.7.1. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.review

Re: Help Needed: How to deploy Review board with Perforce

2013-01-15 Thread Matthew Woehlke
AIK. You definitely don't need P4D (that's the server). -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe

Re: Review Board 1.7.2 is released

2013-01-17 Thread Matthew Woehlke
s! It will be good to get some of the other fixes out (e.g. renames and disabling git copy config, prompt on stderr, etc.). -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/

can't close other users' requests?

2013-01-18 Thread Matthew Woehlke
ermission exception thrown.) Am I missing something? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from thi

Re: when adding Repository: "Unable to retrieve information from local Git repository"

2013-01-18 Thread Matthew Woehlke
ation from local Git repository (Possibly) silly question... have you tried without the .git? (I would have guessed that is not wanted, although I could be wrong.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at

Re: Review Board 1.7.2 is released

2013-01-18 Thread Matthew Woehlke
://reviews.reviewboard.org/r/3707/ (send mail when closing requests) would make 1.7.2... might I expect it for 1.7.3? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users

Re: when adding Repository: "Unable to retrieve information from local Git repository"

2013-01-21 Thread Matthew Woehlke
he 'source' version and don't know how to recreate it from the 'compiled' version.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~-

Re: can't close other users' requests?

2013-01-21 Thread Matthew Woehlke
On 2013-01-19 22:34, Raja wrote: Hi Matthew It looks you also need "reviews.can_edit_reviewrequest" for this to done. Just granting "can change status" seems to throw a permission denied error when trying to check if the user can edit the request. The UI doesnt reflect this

Re: Failed to get repository information svn+ssh

2013-01-21 Thread Matthew Woehlke
not found at the specified path". This sounds suspiciously like Jonathan's recent git troubles... is your server using SELinux? If yes, have you checked your SELinux log for denials? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/don

Re: How to deal with a found bug in post-review

2013-01-23 Thread Matthew Woehlke
de to discard the request. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send ema

Re: Accessing reviewboard using https

2013-01-25 Thread Matthew Woehlke
... it's pretty easy; just get basic ssl working and - if needed - disable regular http. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~---

curious inter-diff bug?

2013-02-15 Thread Matthew Woehlke
revision 1. Is this correct/expected? Known issue? I would have expected to see a reverse of the changes to foo.cpp from revision 1. (This is with RB 1.7.5. Also, the merge base between revisions 1 and 2 differs, which may be part of the trouble.) -- Matthew -- Want to help the Review Boa

Re: curious inter-diff bug?

2013-02-15 Thread Matthew Woehlke
to find lines that were moved with changes. (There's lots of stuff - like this - that I'd actually love to work on if I could justify doing it 'on the clock'...) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happ

Re: curious inter-diff bug?

2013-02-18 Thread Matthew Woehlke
On 2013-02-16 02:43, Christian Hammond wrote: On Feb 15, 2013, at 1:26 PM, Matthew Woehlke wrote: Drifting even further off topic, have you ever given thought to using patience diff in RB? (I've seen spots where it would have been an improvement... might help with better moved-

Re: How to upload a diff for specific branch of Git

2013-02-18 Thread Matthew Woehlke
ever, on Reviewboard, the branch of repo that is connected is origin/master. Hence, Reviewboard, will not be able to patch and display this diff. I'm confused... do you mean that RB is not able to access origin/foo? How do you have RB set up that it can only see a subset of what is on origin?

Re: How to get review id before publishing a review request

2013-02-20 Thread Matthew Woehlke
as you create a new request; just look at your address bar. If you generically know that there exists a review request draft, the best you will be able to do is list all requests, query the status of each, and note any that are drafts. -- Matthew -- Want to help the Review Board project? Do

Re: How to get review id before publishing a review request

2013-02-22 Thread Matthew Woehlke
else you need to do.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to reviewboard+unsubscr

Re: RB migration- non-existent revisions?

2013-02-25 Thread Matthew Woehlke
should get a dump of the file contents. It sounds like your 'raw file URL' for your repository is not set correctly. Make sure it is set to a template from which cgit will accept a *blob ID* (not a commit ID) to retrieve a specific version of a file. -- Matthew -- Want to help the Revi

example extension adding field to review request?

2013-03-04 Thread Matthew Woehlke
Does anyone have an RB extension that adds a custom field to a review request, that they would be willing to share as an example of how to do this? (On a related note, am I missing something, or is the extra_data field still not in 1.7.x?) -- Matthew -- Want to help the Review Board

Re: Review Board, Git and patch-series

2013-03-12 Thread Matthew Woehlke
. I think we'd need something more general that could have an extension for defining such rules. I think it's separate work from the DVCS work. This sounds like a good excuse to develop the extension system to allow an extension to implement the logic. Probably this just nee

Re: RBTools 0.5 released!

2013-03-19 Thread Matthew Woehlke
to talk to Review Board. Is there a (CLI) way to get field information (e.g. description) from a review request? I need this for the merge command of my git-rb script. Thanks, -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy us

Re: forcing post-review to disregard current working directory

2013-03-19 Thread Matthew Woehlke
or? If not please suggest your development workflows. Probably not, but why can you not just cd to the repository from which you actually want to push changes, and then specify the path to your modified post-review.py? -- Matthew -- Want to help the Review Board project? Donate toda

Re: forcing post-review to disregard current working directory

2013-03-20 Thread Matthew Woehlke
o use all major debug features such as stepping, watching, etc. I am new in Python. Does eclipse not allow you to specify the working directory when you run the program for debugging? -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy

Re: Use new python API to get latest changes

2013-03-21 Thread Matthew Woehlke
y) less latency, and less load on the server and network because it is event driven (the server and network only need to do work when an event actually happens; you aren't making them work every poll-interval just to tell you that nothing has changed). -- Matthew -- Want to help the Review Bo

Re: Unable to view diff for multiple files.

2013-04-22 Thread Matthew Woehlke
ultiple browser failures still sounds to me more like a server problem. While you're checking your browser console logs, it is probably worth also checking the server logs if there is any message that would indicate a problem generating the diffs. -- Matthew -- Want to help the Review B

can't add comments

2013-04-25 Thread Matthew Woehlke
/js/reviews.min.8dcc237657b9.js:112 TypeError: 'undefined' is not a function (evaluating 'RB.setFileAttachmentComments({ })') ...and indeed it seems there is something wrong with the page content. Has anyone seen this before, or have an idea what might be wrong? -- Matthew

Re: can't add comments

2013-04-25 Thread Matthew Woehlke
en this started? Unfortunately, no, just that I first noticed it about a week ago (and given others are commenting, presumably it only affects some users of a given RB instance). -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let

Re: can't add comments

2013-04-25 Thread Matthew Woehlke
. In the meantime, go into My Account, uncheck the Open An Issue, save, re-check, save. Should fix it. That fixed it; thanks! -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboar

Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.

2013-05-01 Thread Matthew Woehlke
On 2013-05-01 07:23, Tim wrote: Review Board won't handle password protected private keys. If you entered a passphrase when generating the key then I found ReviewBoard can't handle it. Well... yeah. Where would RB store the pass-phrase? :-) -- Matthew -- Want to help the Review Boa

Re: Trying to upload an id_rsa gives Uploading SSH key failed: This SSH key is not a valid RSA or DSS key error.

2013-05-02 Thread Matthew Woehlke
On 2013-05-02 06:36, Tim wrote: On Wednesday, May 1, 2013 8:35:18 PM UTC+1, Matthew Woehlke wrote: On 2013-05-01 07:23, Tim wrote: Review Board won't handle password protected private keys. If you entered a passphrase when generating the key then I found ReviewBoard can't handle

Re: Gatekeeping mechanism in Reviewboard?

2013-05-03 Thread Matthew Woehlke
if not it is (AFAICT) solely from a lack of glue. Between RB's extensions and event system, you should be able - without much difficulty - to write an RB extension to either publish events and/or fire off automated regression tests and such. -- Matthew -- Want to help the Review Board

Re: Review board upgrade from 1.0.5.1 to 1.7.7.1

2013-05-07 Thread Matthew Woehlke
Error: (1045, "Access denied for user 'admin'@'localhost' (using password: YES)") .Doesn't the 1.7.7.1 version supports postgressql? I'm using it :-). More likely RB setup is not finding it. You are probably missing python bindings for postgresql or some s

Re: Unable to view diff for multiple files.

2013-05-28 Thread Matthew Woehlke
o force it to be rewritten.) -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscribe from this group, send email to r

Re: easy_install not working for ReviewBoard

2013-05-30 Thread Matthew Woehlke
local packages or download links found for ReviewBoard error: Could not find suitable distribution for Requirement.parse('ReviewBoard') While it is probably desirable to fix this, is there a reason you are not using Stephen's EPEL packaged version? -- Matthew -- Want to help th

'depends' feature requests

2013-06-07 Thread Matthew Woehlke
out having to leave the current request page). Even better would be to have a full-blown hover element that would show the 'full' summary information (i.e. at least summary and description). Thoughts/Comments? -- Matthew -- Want to help the Review Board project? Donate today at htt

Re: Automatically commiting code upon receiving a ShipIt!

2013-06-10 Thread Matthew Woehlke
s easier because you aren't dealing with an existing commit. In either case you are probably talking about separate tools/extensions at least for git and svn, possibly even two different ones for git (for pre- and post-commit review). -- Matthew -- Want to help the Review Board proje

Re: Unable to use git diff with post-review or diff upload.

2013-06-10 Thread Matthew Woehlke
h=' rather than 'hb=' with your gitweb instance. -- Matthew -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at http://www.reviewboard.org/users/ -~--~~~~--~~--~--~--- To unsubscr

Re: Automatically commiting code upon receiving a ShipIt!

2013-06-10 Thread Matthew Woehlke
The SHA is a good check against mistakes, but not actively malicious users.) Disclaimer: I read Allan's original post as offering to write something. So take the above as encouragement that I believe that should be possible, not complaint that the core RB team hasn't already done

  1   2   >