Re: Unable to upload screenshots

2012-10-19 Thread Chris Clark
-dev sudo apt-get install libfreetype6-dev Using the base OS provided library is usually the better option though (as per my last update). On Monday, October 24, 2011 2:29:59 PM UTC-7, Chris Clark wrote: Thilo-Alexander Ginkel wrote: On Mon, Feb 14, 2011 at 23:01, Christian Hammond

Re: reviewboard 1.6.11 and reviewing problems with FireFox 3.6 and IE 9

2012-10-04 Thread Chris Clark
saver so I know this is benign (and I'm hitting publish too) but again sharing in case anyone else is seeing this. We're planning an upgrade to 1.6.12 soon, so maybe these will go away? Chris On Thursday, September 27, 2012 2:38:14 PM UTC-7, Chris Clark wrote: On Thursday, September 27, 2012 2

reviewboard 1.6.11 and reviewing problems with FireFox 3.6 and IE 9

2012-09-27 Thread Chris Clark
We upgraded a few weeks ago to 1.6.11 and we've hit a few minor problems. For IE users when they edit the description the newlines disappear and they get one massive line of text. Some times this occurs when viewing the description too and not editing. The IE compatibility mode usually helps

Re: Screenshots for version 1.7?

2012-09-27 Thread Chris Clark
On Wednesday, September 26, 2012 11:26:36 AM UTC-7, Robert Dailey wrote: Are there any screenshots I can look at for various UI improvements for version 1.7? What do code review pages look like? Have you seen the live site http://reviews.reviewboard.org/r/3347/ ? -- Want to help the

Re: reviewboard 1.6.11 and reviewing problems with FireFox 3.6 and IE 9

2012-09-27 Thread Chris Clark
On Thursday, September 27, 2012 2:12:08 PM UTC-7, Christian Hammond wrote: The IE thing is weird, because I don't think anything should have changed as far as text entry goes in a while... Which IE? The IE behavior may not be new, for the version see the title (9) but recall it was seen

Re: Unable to upload screenshots

2011-10-24 Thread Chris Clark
Thilo-Alexander Ginkel wrote: On Mon, Feb 14, 2011 at 23:01, Christian Hammond chip...@chipx86.com wrote: I don't believe they're stored temporarily anywhere. If so, it's internal to Django and I don't know it off-hand. The only thing I've ever seen permission-wise is when there's a

Re: Diff viewer vs. control-L

2011-10-12 Thread Chris Clark
Bill Fenner wrote: We've been having trouble with the diff viewer highlighting the wrong part of the file (e.g., it highlights 6 lines as being added, but those 6 lines are 12 lines above the lines that were actually added). I finally root-caused this to embedded control characters inside

Re: Is there a print function in review board?

2011-09-30 Thread Chris Clark
One option is to print the email sent from reviewboard. If you want to print the diffs you are likely to find sizing issues with the web page approach with the wide side-by-side diff view. We've modified our RB server to include the diff in the email that is sent out for review (we've not yet

Re: Is there a print function in review board?

2011-09-30 Thread Chris Clark
On 9/30/2011 11:34 AM, Stephen Gallagher wrote: On Fri, 2011-09-30 at 11:32 -0700, Chris Clark wrote: One option is to print the email sent from reviewboard. If you want to print the diffs you are likely to find sizing issues with the web page approach with the wide side-by-side diff view

Re: Change email of users

2011-09-27 Thread Chris Clark
Martin wrote: Hi, I'm using RB 1.6.1 with LDAP authentication. I want to each user can modifiy his email address. I tried add the users a group with auth|user|Can change user, but it still not working... NOTE I'm not using LDAP with RB :-) Usually when using LDAP it is a read only resource,

Re: upgrade from 1.0.9 tp 1.6.1 failed

2011-09-27 Thread Chris Clark
premod dev wrote: I have been trying to upgrade my current reviewboard instance to 1.6.1 from the older 1.0.9. But when I try to upgrade the site, its giving me the following error and failing the upgrade. Any idea why? ... No fixtures found. Registering new SCM Tool Plastic SCM

changing backends Re: Upgrading database/site from 1.0 to 1.6.1

2011-09-26 Thread Chris Clark
Christian Hammond wrote: [RE changing backend databases] Unofficially, you can do the following: On the old site: rb-site manage /path/to/site dumpdata dbdump.json On the new: . loaddata dbdump.json There are no guarantees it'll work, but give it a try. Note: They will both need to be

Re: How can I run ReviewBoard 1.5.5 and 1.6rc1 in same time?

2011-07-19 Thread Chris Clark
Christian Hammond wrote: ...A couple important notes: 1) I would strongly recommend that, if you want to test new versions, that you do it on a non-production system, such as your own machine or on a VM. You can always copy over your database if you need to. That's the best way of making

Re: Easy_install post-review issue with 64-bit windows

2011-05-17 Thread Chris Clark
Eric Johnson wrote: I've got some clients of the server I set up that wish to use 64-bit Windows. Unfortunately, it appears that Python easy_install doesn't work properly in that environment. Consequently, those users cannot get RBTools (post-review) to work. Is there a work-around, or

Minimum version of Python for RBTools?

2011-04-29 Thread Chris Clark
What is the minimum supported version of Python for RBtools? The Windows specific docs mention 2.5 http://www.reviewboard.org/docs/manual/dev/admin/installation/windows/ I just stumbled across some code that fails in 2.4 in the ClearCase code (and hacked it to work with 2.4):

Re: About the submit workflow

2011-04-28 Thread Chris Clark
Hongbin Lu wrote: My name is Hongbin Lu. I am currently working on the issue below. http://code.google.com/p/reviewboard/issues/detail?can=2q=693colspec=ID%20Type%20Status%20Priority%20Component%20Owner%20Summary%20Milestoneid=693

Re: 1.5.5 diff viewer not showing files with a single whitespace change?

2011-04-27 Thread Chris Clark
Bruce Cran wrote: I recently upgraded to 1.5.5 and found that with one review which had several files changed, Review Board starts out listing all the files under Files Changed, but quickly decides not to show one of them, which has a 1-line change to the amount of leading whitespace. Other

Re: I have some problems about Languages.

2011-04-11 Thread Chris Clark
Christian Hammond wrote: I think we need a better way to factor this all out, though. Otherwise you'll have to maintain a custom patch for every upgrade. Can you tell me where you placed the first bit of code (encoding changeset0['desc'])? We probably can reuse the repository's Encoding

Re: I have some problems about Languages.

2011-04-08 Thread Chris Clark
jh5774@samsung.com wrote: Well, I found a little clue about encoding. /usr/lib/python2.6/json/__init__.py in this codes, they said python only decode 'ASCII' and 'Unicode'. So, python couldn't decode when encounter like a 'Korean word' I find some solution about decoding. For example,

Re: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

2011-04-07 Thread Chris Clark
Leonel Togniolli wrote: Every week or so I get one of these below in the mail from my RB server. I wasn't able to determine what triggers it, unfortunately. Me too. See http://code.google.com/p/reviewboard/issues/detail?id=1526 I suggest you log a comment on the issue/bug so that there is

Re: AttributeError: 'DashboardDataGrid' object has no attribute 'id_list'

2011-04-07 Thread Chris Clark
Leonel, I forgot to ask, are you seeing this after an upgrade? Chris Clark wrote: Leonel Togniolli wrote: Every week or so I get one of these below in the mail from my RB server. I wasn't able to determine what triggers it, unfortunately. Me too. See http://code.google.com/p/reviewboard

Re: Error with post-review. I get Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD']

2011-04-06 Thread Chris Clark
Martin wrote: Failed to execute command: ['git', 'symbolic-ref', '-q', 'HEAD'] What happens when you manually run: git symbolic-ref -q HEAD -- Want to help the Review Board project? Donate today at http://www.reviewboard.org/donate/ Happy user? Let us know at

Re: UnicodeDecodeError with Visual Studio files, RB 1.5.4, RBTools-0.3.2 (Python 2.7.1)

2011-04-05 Thread Chris Clark
Craig A wrote: This may well be fixed by trying python 2.6 (or even 2.5) as you suggested. I tried Python 2.6.6 (could not find an msi installer for 2.5.5) and voila! It works now, no more problems with BOM characters. Thanks for your help Chris, I am glad this is working now.

Re: Successful upgrade from Reviewboard 1.0.5.1 to 1.5.5

2011-04-04 Thread Chris Clark
, Chris Clark chris.cl...@ingres.com mailto:chris.cl...@ingres.com wrote: We had a customized version of 1.0.5.1 and we now have a (less) customized version 1.5.5 (custom SCM back end and minor email/template tweaks). We're using Ubuntu 8.04.3 LTS (hardy) on x86 (same as the last

Successful upgrade from Reviewboard 1.0.5.1 to 1.5.5

2011-03-30 Thread Chris Clark
We had a customized version of 1.0.5.1 and we now have a (less) customized version 1.5.5 (custom SCM back end and minor email/template tweaks). We're using Ubuntu 8.04.3 LTS (hardy) on x86 (same as the last time we upgraded, we've left the OS alone) . We had no problems at all with this

Re: UnicodeDecodeError with Visual Studio files, RB 1.5.4, RBTools-0.3.2 (Python 2.7.1)

2011-03-25 Thread Chris Clark
Craig A wrote: I am getting an error similar to what was reported some time ago in this post: http://groups.google.com/group/reviewboard/browse_thread/thread/56fb450ceaef45c1 UnicodeDecodeError: 'ascii' codec can't decode byte 0xef in position 1285: ordinal not in range(128) Specifically

Re: UnicodeDecodeError with Visual Studio files, RB 1.5.4, RBTools-0.3.2 (Python 2.7.1)

2011-03-25 Thread Chris Clark
Craig A wrote: You mention you've customized postreview ... is it possible that your new code has the Unicode assumption in it rather than the original RBtools. I don't think so, the relevant line of code looks like this: return content_type, content The trace back

Re: Users are automatically created if authenticated through ldap

2011-03-24 Thread Chris Clark
Christian, Is this a Reviewboard feature or a Django one? I would have guessed this was a Django behavior. I'm not even a Django (auth) novice, let alone expert, so sorry if this is a dumb question! Chris Christian Hammond wrote: Hi Pablo, No, there's no way to do this out of the box.

Re: Help debugging a hang in RB 1.5

2011-02-07 Thread Chris Clark
Alfred von Campe wrote: We are experiencing a strange hang when viewing one particular review. When we click on the View DIff we get a new web page and the Files Changed: section lists all the files that have changed in this particular request. There are 20 files, and the information for

javascript detect/protect back button presses when content updated?

2011-01-21 Thread Chris Clark
I've recently been using a laptop with forward/back keys. These are conveniently located by the arrow/cursor keys. In a web browser these keys are the equivalent of alt-left/right (or the backwards/forwards on screen button). I've just spent the last 10 mins re-entering (multiple times) in

Re: ReviewBoard not displaying content of diff file

2010-10-13 Thread Chris Clark
cogo wrote: I have just started trying out reviewboard and I have some issues with some diffs not beeing displayed when I click View diff in the review request. When i download the diff I can see the content: Index: //trunk/library/extras/global-post-commit-hook.php

Re: Timezone for London

2010-10-05 Thread Chris Clark
brokenn wrote: I've just installed Reviewboard 1.5RC2 on a Centos 5 box. When selecting the timezone from the Admin-Settings-General Settings menu, it lists time zones for all parts of the world, but under Europe there are no UK cities. I'm not London-centric, but would like to select a

Error: No module named django_evolution

2010-10-01 Thread Chris Clark
I was following the instructions on http://www.reviewboard.org/docs/codebase/dev/getting-started/ And at the setup Reviewboard stage: python ./contrib/internal/prepare-dev.py I got : Error: No module named django_evolution I worked around it by issuing: python setup.py develop

Re: post-review fails on HTTP POST

2010-09-23 Thread Chris Clark
jdt141 wrote: File /usr/lib/python2.5/site-packages/RBTools-0.2-py2.5.egg/rbtools/ postreview.py, line 549, in process_json AttributeError: 'module' object has no attribute 'loads' I'm at a loss... Any and all help would be appreciated. It looks like the json/simplejson module isn't

Re: Accessing different repo types from post-review

2010-09-22 Thread Chris Clark
Jay wrote: On Sep 21, 12:11 pm, Chris Clark chris.cl...@ingres.com wrote: It looks like p4 is claiming there is a perforce repo in the svn location. A quick hack/test would be to modify postreview to check svn first. I.e. hack the SCMCLIENTS def. Let's assume this suggestion

Re: Accessing different repo types from post-review

2010-09-21 Thread Chris Clark
Jay wrote: I have post-review installed on windows and have successfully been creating RB requests against perforce. We also have SVN projects, but when I try to use post-review against them it wants to talk to perforce instead. For instance if I enter: post-review

Re: Release party planning for Review Board 1.5

2010-09-13 Thread Chris Clark
Christian Hammond wrote: We're finalizing the documentation and performing some final testing before releasing Review Board 1.5. As per tradition, we're looking at putting together a release party, and we'd like to invite anyone who wants to come. Details are still being worked out, but will

Re: post-review tool: How to post only *.c and *.h files

2010-08-23 Thread Chris Clark
sakthi wrote: Could find i have to use post-review tool to post the code into review board. Can some one help me out how to post ONLY *.c and *.h files recursively from SVN directory. Is there any automated script available.. where i shall modify the require information to post the code that is

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Chris Clark
Timothy Pinet wrote: In which file does reviewboard invoke the svn diff --diff-cmd=diff command? I have been looking but can not find it. I then thought that you probably call the pysvn lib for this. I checked the pysvn documentation (http://pysvn.tigris.org/docs/

Re: post-review error with svn and gnu diffutils (new review with an added binary file)

2010-08-20 Thread Chris Clark
Timothy Pinet wrote: I wanted to check post-review however since I am on Windows my Python26\Scripts\post-review.exe is a compiled executable and not a python file. Would it be enough to grab the post-review.py from the repo and delete the exe? Not with the current version. There are a few

Re: Facing problem installing in Windows!

2010-08-19 Thread Chris Clark
sakthi v wrote: I followed the following link to install ReviewBoard in Windows http://yuanyi-wang.blogspot.com/2009/03/install-review-board-on-windows.html I tried installed twice.. and from blank page .. i got stuck in page showing Manual Server Updates Required I tried re-installation PIL

Re: How to create svn diff for a new file

2010-08-12 Thread Chris Clark
ms wrote: We use SVN for source control. I have a bunch of newly written code in new java files that are not yet committed in subversion. I want to review the code in these files using ReviewBoard, but I'm wondering how to create diff for these files since they do not have a prior version

Re: Custom authentication against external DB?

2010-08-12 Thread Chris Clark
abrightwell wrote: I am considering integrating Review Board for my current project. However, before doing so, I need to determine whether or not it will place nicely with our current authentication process. All authentication for every tool on our project revolves around the authentication

Re: Programmatic way to check review status?

2010-08-12 Thread Chris Clark
Adam wrote: However what I'm not seeing is any scriptable way of checking the status of a review. Does something like this exist and I'm just not finding it? http://www.reviewboard.org/docs/manual/dev/webapi/ or you could hit the database directly (using raw SQL or the Django ORM).

Re: Successful upgrade from Reviewboard 0.9 to 1.0.5.1

2010-05-25 Thread Chris Clark
Chris Clark wrote: Follow up after a days usage after the upgrade. Follow up a number of months later :-) It turns out I also hit a problem with missing screenshots, but no error for the user see: http://groups.google.com/group/reviewboard/browse_thread/thread/d158d97bf5344847

Re: How apply patches in pre-review process?

2010-04-30 Thread Chris Clark
Jan Koprowski wrote: . When review is done and submitted developer can change everything he want in working tree and commit everything he want. I'm thinking how be sure that reviewed changes is commited changes. For us, we are just using the honour/honor system, i.e. no checks :-) This

Re: No new line at end of file crash diffviewer

2010-04-29 Thread Chris Clark
Christian Hammond wrote: What version of patch are you guys running? I'm running Ubuntu 8.04.3 LTS - I have patch 2.5.9 ing...@reviews:~$ cat /etc/*elease* DISTRIB_ID=Ubuntu DISTRIB_RELEASE=8.04 DISTRIB_CODENAME=hardy DISTRIB_DESCRIPTION=Ubuntu 8.04.3 LTS ing...@reviews:~$

Re: No new line at end of file crash diffviewer

2010-04-28 Thread Chris Clark
Jan Koprowski wrote: When I make review for file where some changes was made near last line and it have not new line at end of file diffviewer crush :/ I'm thinking about adding one more fake new line sign at the end everytime. Is this patch will be submitted if I create one? That is

Re: Is it possible to specify a change number/revision for an SVN repository when creating a review request via json?

2010-02-09 Thread Chris Clark
Stodge wrote: Thanks. I got confused between revisions and changesets, especially as I develop stuff using Mercurial, while the other developers use SVN! I'm curious why I can't create a review request via the json api with the revision numbers as parameters. I guess I assumed review board

Re: Can I use anonymous mail ID as Mail Sender for for review requests and reviews ?

2010-02-08 Thread Chris Clark
qhlonline wrote: Hi, all In the Admin page, There will be an Email setting. items will be as follows: Mail Server: Port: Username: Password: So there will be SMTPAuthentication. But we want to use this Email account to send email

Re: RB review Process Automation

2010-02-05 Thread Chris Clark
VMware, Inc. - http://www.vmware.com On Wed, Feb 3, 2010 at 11:00 AM, Chris Clark chris.cl...@ingres.com mailto:chris.cl...@ingres.com wrote: Kunjal wrote: Once the Review is done, user has to make Review

Re: RB review Process Automation

2010-02-03 Thread Chris Clark
Kunjal wrote: Once the Review is done, user has to make Review as Close-Submitted eles reviewers dashboard will still have the review. We enforce this process on developers and developers are saying that this is one extra step. I was thinking whether it is possible to close the review

Re: Does reviewboard support new review notifications other than email?

2010-01-28 Thread Chris Clark
Tino Breddin wrote: I'm interested in notifying external system about new review requests where email isn't a good option. I've read in the roadmap that generic hooks are planed for version 2.0, but is there anything similar in place now which could be used for this purpose? This suggestion

Re: Is there a size limit on diffs?

2010-01-28 Thread Chris Clark
Dave Hocker wrote: We have a large Perforce change list that generates a 550K diff file. When we submit the review request, the request is created but there is no diff attached. .snip logs. Is there a limit on diff file size? If so, can it be changed? I can't comment on the

Re: Question on code review for files after they've been modified by another persons checkin

2010-01-22 Thread Chris Clark
seacgmk wrote: I've recently set up ReviewBoard with Perforce configured for pre- commits. Perforce allows source files to be checked out by multiple developers at the same time. If one developer submits a file for review and then a second developer checks in their changes to the same file

Re: post-review failing to work on CVS because I have cleartool with a view set

2010-01-19 Thread Chris Clark
Christian Hammond wrote: What you could do now is modify postreview.py so that the CVSClient instance is created before the ClearCaseClient. That would guarantee that CVS would check first. An easy technique for dealing with this is to add another definition for SCMCLIENTS, this way if the

Re: post-review failing to work on CVS because I have cleartool with a view set

2010-01-19 Thread Chris Clark
David McCloskey wrote: But Another problem is appearing now. Once it tries to do the post, I get an error that the connection was refused on port 2401. I'm guessing this is because we're using ssh tunnels only to connect to our CVS servers. Is there some special way to configure my repository

Re: post-review doesn't find my CVS repository

2010-01-06 Thread Chris Clark
The other option is to add a command line override for the SCM repository information. I ended up doing this for the SCM we use . although I've not yet needed to make use of it :-) I think this is what the --p4-port flag is for with Perforce. You could also have some sort of mapping in

Re: Totals / Reports?

2010-01-05 Thread Chris Clark
grimbeaver wrote: I need a simple way to get the total number of reviews in a group. We've assigned all the code reviews into groups based on project. Project management has to report the total number of code reviews completed for a project to our partner. When you look at the group view it

Re: About Post-Review User change problem

2009-12-23 Thread Chris Clark
qhlonline wrote: 在2009-12-23,Chris Clark chris.cl...@ingres.com 写道: Try the --submit-as flag instead. e.g.: post-review --submit-as=A myfile post-review --submit-as=B myfile But We need that the loged user and the submiter to be the same user. We are desiring detaied

Re: post-review and

2009-12-23 Thread Chris Clark
prestomation wrote: I am currently demo'ing review board to interface with our Perforce server. I seems that using post-review with a command like the following: post-review --username=USERNAME --server=reviewboard 65428 tries to access the api at a subfolder with the same name as the

Re: About Post-Review User change problem

2009-12-22 Thread Chris Clark
Try the --submit-as flag instead. e.g.: post-review --submit-as=A myfile post-review --submit-as=B myfile Christian Hammond wrote: Known bug. See http://code.google.com/p/reviewboard/issues/detail?id=762 Christian -- Christian Hammond - chip...@chipx86.com

Re: post-review with bypass proxy settings in Internet Explorer

2009-12-02 Thread Chris Clark
My 2 cents. Modifying the registry and then restoring is not a great idea. I can see why you are doing it but I'd encourage you to NOT do this. There is a potential here for a background web app to fail (e.g. web browser based IM tool). I'd be tempted to monkey patch urllib(2), presumably

Re: ValueError: No JSON object could be decoded

2009-12-02 Thread Chris Clark
Have you tried using the: --server= flag? RE the version of reviewboard, if this is a new install I would go ahead and use 1.0.5.1 this shouldn't impact the error you are seeing but why use an old version when you can use the new stable one ;-) Chris Christian Hammond wrote: Hi, Is

Re: fields_changed in changedescs_changedescription

2009-11-23 Thread Chris Clark
Out of curiosity what size limit is this likely to be? 80 chars, 1024, 1Mb, 1Gb... :-) Chris Christian Hammond wrote: Hi Ronak, We will be limiting the lengths of these fields in a future version. We're aware of the problem and have encountered this with some users too. Expect a field

Re: fields_changed in changedescs_changedescription

2009-11-23 Thread Chris Clark
Christian Hammond wrote: I don't know off-hand what we're going to set it to. We're thinking about it, and suggestions are welcome. Here's where it gets tricky... We're running up to maximum field lengths for the change info, and that's a combination of multiple fields, including

Re: Review Board 1.1 alpha 2 released

2009-11-16 Thread Chris Clark
Christian Hammond wrote: We've just put out a release of Review Board 1.1 alpha 2. This is a major enhancement release, and we'd love to get some testing for it. It looks like 1.1 alpha 2 is at http://reviews.reviewboard.org. I've a question on bug or behavior, someone posted a review url

Anyone seeing multiple emails from ReviewBoard

2009-11-16 Thread Chris Clark
I've a report from _some_ users that they are seeing multiple emails being sent from Reviewboard. The scenario is this: 1. postreview used to create/publish new review 2. review comments posted by reviewer, this code sucks change it... etc 3. postreview used to post new diffs, post

Re: Customize ReviewBoard for Email Subject

2009-11-05 Thread Chris Clark
Kunjal wrote: we want to customize the subject line of the email which RB sends on submit of review. Check out reviewboard/reviews/email.py - mail_review_request() look for subject. I nice to have would be a way to customize this from the site admin page. I'm not likely to implement

Re: How to post-commit review a first time checkin?

2009-11-05 Thread Chris Clark
Christian Hammond wrote: Actually, I wouldn't mind such a parameter. (though, --diff-filename, as we don't use underscores in parameter names). There's actually a patch up for review for accepting via stdin (though it's a bit stale and isn't the design we want), so I guess there are more

Successful upgrade from Reviewboard 0.9 to 1.0.5.1

2009-10-28 Thread Chris Clark
Just a quick note that I was able to upgrade from Reviewboard 0.9 to 1.0.5.1. Yes zero point nine to latest (stable) 0.9 pre-dates the rb-site so I simply had to: 1. Use rb-site to deploy a NEW EMPTY reviewboard server (yup, with a new secret key, I didn't have to mess with it at all)

Re: Successful upgrade from Reviewboard 0.9 to 1.0.5.1

2009-10-28 Thread Chris Clark
On Oct 29, 2:22 am, Christian Hammond chip...@chipx86.com wrote: I should point out for anyone else reading the notes that you were able to get away with not needing the old secret key because you're (I'm assuming) using something like LDAP or NIS or Active Directory. In these cases, we

git and diffs against branches

2009-10-23 Thread Chris Clark
Whilst I use other distributed SCM's I've only just started with git (as ReviewBoard uses it) and I think I'm having some trouble understanding git (and reviewboard). What I'd like to do is post for review changes/diffs against a branch (not master/bleeding edge). E.g. git clone

Re: Can't enable search though PyLucene is installed

2009-10-22 Thread Chris Clark
David, Which Ubuntu version did you use? I've not (yet) setup search but I've found the LTS (8.10) Server version to be REALLY good for reliable config. If you need a reliable, *production* server I wouldn't use anything other than LTS. I can't promise LTS will handle Lucene but it has the

dev getting-started - missing django_evolution step

2009-10-22 Thread Chris Clark
I'm setting up a new dev environment for some hacking and I'm following: http://www.reviewboard.org/docs/codebase/dev/getting-started/#gettingstarted After using git to get the reviewboard source and using ./contrib/internal/prepare-dev.py I get errors about django_evolution.

Re: dev getting-started - missing django_evolution step

2009-10-22 Thread Chris Clark
Chris Clark wrote: I'm setting up a new dev environment for some hacking and I'm following: http://www.reviewboard.org/docs/codebase/dev/getting-started/#gettingstarted After using git to get the reviewboard source and using ./contrib/internal/prepare-dev.py I get errors about

Re: Installing PyLucene on Windows

2009-10-20 Thread Chris Clark
Christian Hammond wrote: At the time we wrote search, this functionality didn't exist. However, it's still too limited for our needs. . I'm hoping to find a better solution in the long term, but I don't believe that the native database full text search is it. Now, maybe if we

pure python patch tool, maybe useful to win32 users

2009-09-20 Thread Chris Clark
http://code.google.com/p/python-patch/wiki/README pure python patch tool (only handles unified diffs though). I've not tested it out but it may be useful to Windows users running a server who do not want to install binaries. Chris --~--~-~--~~~---~--~~ You

Re: Custom post-review implementations making them easier proposal

2009-06-09 Thread Chris Clark
Christian Hammond wrote: ...I also would like an rbapi (or something) package for all the server communication code. This would be separate from RBTools, but RBTools would use it. post-review would be greatly simplified by these two changes. That would be awesome, we've had a couple of

Re: Custom post-review implementations making them easier proposal

2009-06-05 Thread Chris Clark
Ritesh Nadhani wrote: For one, I would be interested. We use Bazaar and and have been slowly trying to intergrate ReviewBoard in our system. I looked into the post-review and it does not seem to support Bazaar. I have already extended it using the Mercurial example and override two or three

Re: give up with subversion

2009-06-04 Thread Chris Clark
sailor...@gmail.com wrote: I tried a couple of days on FC4, but I still can not let reviewboard work for subversion repository. The main reason is pysvn.. I guess if someone can provide some simple way to install, it will help reviewboard is used by more guys.Maybe, specific versoin

Re: Mail features

2009-06-02 Thread Chris Clark
Vesterbaek wrote: I would find it useful to to be able to configure this independently for groups and people, such that a user can choose to be member of a particular group, but not receive any emails from review requests to that group, but only get emails if a review request is directed at

Custom post-review implementations making them easier proposal

2009-06-02 Thread Chris Clark
If you want to deploy post-review with some site specific customizations (e.g. add support for a custom in house SCM) there are only a few options: * Privately fork post-review and try and sync all the changes that occur in trunk into your version * add a wrapper script around

Re: Newbie question: setup problems

2009-01-08 Thread Chris Clark
Phil wrote: .Sqlite3 is complaining that it cannot open the database file. (sqlite3.OperationalError: unable to open database file) Has anyone else had this problem? My understanding is that Python 2.5 includes sqlite thus I wouldn't have to install it again -- is this incorrect? Have

Re: New SCMTools fot PVCS repository

2008-12-15 Thread Chris Clark
Tee - your best bet is to just get stuck in and play :-) I've not come across any docs other than what is in the code, I ended up setting up a reviewboard server to svn and seeing what it did as well as creating an empty NEWscmtool that subclasses SCMTool and adding methods as they were

Re: C++ Highlighting

2008-12-11 Thread Chris Clark
bart wrote: However I am having some problems regarding C/C++ highlighting. Generally the highlighting appears to be on but for some keywords that are highlighted by pygmentize program I am not able to see highlight in the review diff... I tried to turn on the guess option in diffutils.py

Upgrade issues

2008-12-05 Thread Chris Clark
I've just moved to rev 1623 in trunk (I was at 1519). I do like the new manual upgrade required screen that pops up (settings.py has been updated to change the location for htdocs/media/uploaded/images). Very slick and should saves lots of admin hair pulling :-) However when I first loaded

Re: Where is the post-review tool

2008-12-04 Thread Chris Clark
AndyP wrote: I installed the latest stuff (blew everything away first) and can't find the latest version of the post-review tool. Where do I go to get it? You can pull it down from svn (and you can even use wget if you don't have svn to hand):

Re: Using ignore file extensions on post-review

2008-11-12 Thread Chris Clark
Russell Bryant wrote: On Wed, Nov 5, 2008 at 6:54 AM, Dave Hocker [EMAIL PROTECTED] mailto:[EMAIL PROTECTED] wrote: You can use the Perforce p4 files command to determine if Perforce thinks the file is text or binary. The last token of the output will be something like (text)

Re: Limitations with diff files - any suggestions?

2008-10-28 Thread Chris Clark
fts1050 wrote: To remedy this..any chance Post Review can be modified to handle an external file that contain a list of specific files that should be included in the review? I can do this myself but then when I upgrade I have to manage my own version of post review and that's no fun. Just a

Re: Publishing and target group error

2008-10-23 Thread Chris Clark
You won't like the answer use apache. I reported a similar problem in the faq (with solution) http://code.google.com/p/reviewboard/wiki/FAQ I think this is another manifestation. If this is the case do you could you add a comment to the faq too? Also see

Re: How to add another scmtool support?

2008-10-13 Thread Chris Clark
On 10/13/2008 8:38 AM, Jay wrote: If I want to add another scmtool support, is it enough to add a new file in scmtools folder like anotherscmtool.py which will implements several classes and methold? Or any change in other module? I can confirm that this is pretty much what you have to do

Re: Using ignore file extensions on post-review

2008-10-08 Thread Chris Clark
On 10/8/2008 1:38 AM, Marcos wrote: I am using Perforce. The error is with tga files. I'm not a Perforce user so dumb question coming. Does Perforce have the concept of binary files? Can this information be picked up from Perforce (I notice a describe is done before the diffs are

Re: weird error in review-board and post-review in windows

2008-10-08 Thread Chris Clark
On 10/8/2008 3:45 PM, Paulo Eduardo Neves wrote: .. my problem with cygwin is that I'll have to deploy the client in dozens of developer Windows machines. I don't want to force everybody to install cygwin just to have diff. Don't forget that the patch requirement is only on the

Re: Nothing happens when I upload a patch

2008-10-08 Thread Chris Clark
On 10/8/2008 4:21 PM, Paulo Eduardo Neves wrote: I've already did some patch uploads through the web interface, but now when I try to upload a diff generated by subversion nothing happens. My steps: 1) generate diff with this command: svn diff -r 15854:15855 e:\revision15855.patch 2)